[jira] [Closed] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-30 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-5426.
--
Fix Version/s: Upcoming Branch
   Resolution: Fixed

This has been fixed in trunk via the mentioned PRs.

Thanks, Leon for the report and Adrian Crum, Jacques Le Roux, Ingo Wolfmayr, 
Deepak Dixit, Pierre Smits Gil Portenseigne and Jacopo for the discussion and 
review.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Pawan Verma
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-30 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-5426:
--

Assignee: Pawan Verma  (was: Deepak Dixit)

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071180#comment-17071180
 ] 

ASF subversion and git services commented on OFBIZ-5426:


Commit 3b86754e141a97076b0bf3fe84ef10f18d74c00d in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3b86754 ]

Improved: Added new data model changes done under OFBIZ-5426 in DataModel 
changes file. (#55)

(OFBIZ-5426)

Thanks, Deepak Dixit for the report.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-5426) mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes

2020-03-30 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-5426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071179#comment-17071179
 ] 

ASF subversion and git services commented on OFBIZ-5426:


Commit 3b86754e141a97076b0bf3fe84ef10f18d74c00d in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3b86754 ]

Improved: Added new data model changes done under OFBIZ-5426 in DataModel 
changes file. (#55)

(OFBIZ-5426)

Thanks, Deepak Dixit for the report.

> mysql: ERROR 1071 (42000): Specified key was too long; max key length is 767 
> bytes
> --
>
> Key: OFBIZ-5426
> URL: https://issues.apache.org/jira/browse/OFBIZ-5426
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Leon
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-5426.patch, OFBIZ-5426.patch, OFBIZ-5426.patch, 
> OFBIZ-5426.patch, OFBIZ-5426.patch
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> Due to revision 1529838, the length of data type "email" was increased from 
> 254 to 320. But It makes the ofbiz failed to create tables such as 
> "PRODUCT_PROMO_CODE_EMAIL" which includes an email fields as its primary key.
> The database is mysql, innodb engine and utf8 charset. The error msg:
> ERROR 1071 (42000): Specified key was too long; max key length is 767 bytes.
> I suggest to revert change of r1529838.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] verma-pawan merged pull request #55: Implemented: Added new data model changes done under OFBIZ-5426 in DataModel changes file.

2020-03-30 Thread GitBox
verma-pawan merged pull request #55: Implemented: Added new data model changes 
done under OFBIZ-5426 in DataModel changes file.
URL: https://github.com/apache/ofbiz-framework/pull/55
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Assigned] (OFBIZ-11315) Add “--graph” option

2020-03-30 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11315:


Assignee: (was: Mathieu Lirzin)

> Add “--graph” option
> 
>
> Key: OFBIZ-11315
> URL: https://issues.apache.org/jira/browse/OFBIZ-11315
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Attachments: 0001-Implemented-Add-graph-option.patch, 
> OFBIZ-11315-complete.patch, 
> OFBIZ-11315_standard-no-prefix-format_0001-Implemented-Add-graph-option.patch,
>  ofbiz.dot
>
>
> In order to inspect what components are loaded by OFBiz and their dependency
> relationship, it is convenient to have a visual graph representation.
> {code}
> gradlew "ofbiz --graph"
> {code}
> will output a {{ofbiz.dot}} file that can be processed with Graphviz:
> {code}
> cat ofbiz.dot | dot -T png -o ofbiz.png
> {code}
> Currently there is no dependency relationship specified by components but to 
> check the kind of graph is produced it is possible to revert commit 
> aae1c8a8f5fed7de717290c938297be62c0460fa



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11296) Use 'depends-on' everywhere

2020-03-30 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11296:


Assignee: (was: Mathieu Lirzin)

> Use 'depends-on' everywhere
> ---
>
> Key: OFBIZ-11296
> URL: https://issues.apache.org/jira/browse/OFBIZ-11296
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11296_0001-Improved-Use-depends-on-attribute-instead-of-compone.patch, 
> OFBIZ-11296_ignore-depends-on-when-a-component-load.xml-is-prese.patch
>
>
> We currently have two ways to define component loading order. Either
> by using ‘depends-on’ attribute in “component-config.xml” or by adding
> a “component-load.xml” file at the root of a component directory.
> “depends-on” is more flexible because it handles partial ordering when
> “component-load.xml” defines a total order which is not necessarily
> meaningful, so it is better to rely only “depends-on”.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11314) Avoid stack overflow in the presence of cycles in controller inclusion

2020-03-30 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11314:


Assignee: (was: Mathieu Lirzin)

> Avoid stack overflow in the presence of cycles in controller inclusion
> --
>
> Key: OFBIZ-11314
> URL: https://issues.apache.org/jira/browse/OFBIZ-11314
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Attachments: 0001-Improved-Rewrite-Digraph.patch, 
> 0001-Improved-Rewrite-Digraph.patch, 
> 0002-Improved-Detect-inclusion-cycles-in-controller-confi.patch
>
>
> The inclusion of controller configuration files can lead to inclusion cycles 
> which are not safely handled, because they can lead to infinite recursion 
> that end up in stack overflow exception.
> A very basic form of cycle is controllers A and B which includes each other.
> I would be better to check the inclusion cycles and report an appropriate 
> error.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11161) OFBiz distribution should not require including extra content

2020-03-30 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11161:


Assignee: (was: Mathieu Lirzin)

> OFBiz distribution should not require including extra content
> -
>
> Key: OFBIZ-11161
> URL: https://issues.apache.org/jira/browse/OFBIZ-11161
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Major
> Attachments: 
> OFBIZ-11161_0001-Separate-resources-from-Java-source-files.patch, 
> OFBIZ-11161_0002-Don-t-exclude-properties-and-labels-file-fr.patch, 
> OFBIZ-11161_0003-framework_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0003-plugins_Remove-redundant-dtd-directory-from-classpa.patch, 
> OFBIZ-11161_0004-Move-APACHE2_HEADER_FOR_XML.patch, 
> OFBIZ-11161_0005-Do-not-exclude-files-from-component-config-.patch
>
>
> Currently to deploy OFBiz it is necessary to include the source directories 
> containing xml and groovy files in addition of {{ofbiz.jar}}, because loading 
> of those files is not done using the standard [location independent resource 
> mechanism|https://docs.oracle.com/javase/8/docs/technotes/guides/lang/resources.html]
>  of Java.
> To facilitate the deployment on production servers, the following 
> configuration is added in {{build.gradle}}
> {code:groovy}
> distributions.main.contents.from(rootDir) {
> include 'framework/**', 'applications/**', 'themes/**', 'plugins/**'
> }
> {code}
> However this doesn't solve the problem that OFBiz is not usable as a library 
> downloaded from a Jar repository. The proper solution would be to remove any 
> dependencies on OFBiz home directory and bundle every resource in 
> {{ofbiz.jar}}
> This has been [discussed on Development mailing 
> list|https://lists.apache.org/thread.html/c2612f1e296b6ea15872185871d3a9d83d6a4afc6d2a76f7a336a126@%3Cdev.ofbiz.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11192) Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files

2020-03-30 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11192:


Assignee: (was: Mathieu Lirzin)

> Use ‘java.nio.file’ API instead of ‘java.io’ when manipulating files
> 
>
> Key: OFBIZ-11192
> URL: https://issues.apache.org/jira/browse/OFBIZ-11192
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11192_0001-Refactor-ComponentLoaderConfig-class.patch, 
> OFBIZ-11192_0002-Convert-Config-ofbizHome-and-Config-logDir-.patch, 
> OFBIZ-11192_0003-Use-java.nio.file-API-in-ComponentContainer.patch, 
> OFBIZ-11192_0004-Refactor-ComponentContainer-loadComponentFr.patch, 
> OFBIZ-11192_0005-Use-Path-for-component-config-rootLocation-.patch
>
>
> Since Java 1.7 the {{java.nio.file}} package provides a more modern way to 
> manipulate the filesystem than {{java.io}}. For example the presence of a 
> Path class allows more typesafe manipulation of file and directory names than 
> using plain strings.
> Currently OFBiz uses {{java.io}} exclusively but it would improve safety, 
> maintainability and readability to move to the new {{java.nio.file}} API 
> instead.
> Some documentation regarding how to migrate to new API is available:
> * https://docs.oracle.com/javase/tutorial/essential/io/fileio.html
> * https://docs.oracle.com/javase/tutorial/essential/io/legacy.html#mapping



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11271) Add a ‘CONTRIBUTING.adoc’ file

2020-03-30 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11271:


Assignee: (was: Mathieu Lirzin)

> Add a ‘CONTRIBUTING.adoc’ file
> --
>
> Key: OFBIZ-11271
> URL: https://issues.apache.org/jira/browse/OFBIZ-11271
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
>
> Contributing guidelines are currently defined in 
> [Confluence|https://cwiki.apache.org/confluence/display/OFBIZ/Apache+OFBiz+Contribution+and+Development]
>  which is far from the code and not easily editable locally. It would be 
> better to have a {{CONTRIBUTING.adoc}} file inside the framework repository.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11067) Migrate integration tests to unit tests when possible

2020-03-30 Thread Pierre Smits (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pierre Smits reassigned OFBIZ-11067:


Assignee: (was: Mathieu Lirzin)

> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch, 
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch, 
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch, 
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch, 
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch, 
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch, 
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch, 
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch, 
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch, 
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch, 
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch
>
>
> In OFBiz there are both unit tests and integration tests which are 
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}. 
> However some integration tests are in fact unit tests that doesn't depend on 
> the entity and service engines. Those unit tests should run on the their 
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3 
> which is what is done for the integration test suite.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11572) Convert LeadServices.xml minilang to groovy

2020-03-30 Thread Sebastian Berg (Jira)
Sebastian Berg created OFBIZ-11572:
--

 Summary: Convert LeadServices.xml minilang to groovy
 Key: OFBIZ-11572
 URL: https://issues.apache.org/jira/browse/OFBIZ-11572
 Project: OFBiz
  Issue Type: Sub-task
  Components: marketing
Affects Versions: Trunk
Reporter: Sebastian Berg
Assignee: Sebastian Berg
 Fix For: Upcoming Branch






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11571) improve loadSalesOrderItemFact re dimension and fact entity changes

2020-03-30 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070785#comment-17070785
 ] 

Pierre Smits commented on OFBIZ-11571:
--

Patch available via https://github.com/apache/ofbiz-plugins/pull/11 See 
OFBIZ-11414

> improve loadSalesOrderItemFact re dimension and fact entity changes
> ---
>
> Key: OFBIZ-11571
> URL: https://issues.apache.org/jira/browse/OFBIZ-11571
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: Fact, SalesOrderItemFact, birt, dimension, dwh, service
>
> Improve the loadSalesOrderItemFact function to include changes in dimension 
> and fact entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on issue #11: Improved: BI Component (OFBIZ-11414)

2020-03-30 Thread GitBox
sonarcloud[bot] removed a comment on issue #11: Improved: BI Component 
(OFBIZ-11414)
URL: https://github.com/apache/ofbiz-plugins/pull/11#issuecomment-605829508
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on issue #11: Improved: BI Component (OFBIZ-11414)

2020-03-30 Thread GitBox
sonarcloud[bot] commented on issue #11: Improved: BI Component (OFBIZ-11414)
URL: https://github.com/apache/ofbiz-plugins/pull/11#issuecomment-605855295
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Created] (OFBIZ-11571) improve loadSalesOrderItemFact re dimension and fact entity changes

2020-03-30 Thread Pierre Smits (Jira)
Pierre Smits created OFBIZ-11571:


 Summary: improve loadSalesOrderItemFact re dimension and fact 
entity changes
 Key: OFBIZ-11571
 URL: https://issues.apache.org/jira/browse/OFBIZ-11571
 Project: OFBiz
  Issue Type: Sub-task
  Components: bi
Affects Versions: Trunk
Reporter: Pierre Smits
Assignee: Pierre Smits


Improve the loadSalesOrderItemFact function to include changes in dimension and 
fact entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on issue #11: Improved: BI Component (OFBIZ-11414)

2020-03-30 Thread GitBox
sonarcloud[bot] commented on issue #11: Improved: BI Component (OFBIZ-11414)
URL: https://github.com/apache/ofbiz-plugins/pull/11#issuecomment-605829508
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on issue #11: Improved: BI Component (OFBIZ-11414)

2020-03-30 Thread GitBox
sonarcloud[bot] removed a comment on issue #11: Improved: BI Component 
(OFBIZ-11414)
URL: https://github.com/apache/ofbiz-plugins/pull/11#issuecomment-605819311
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (OFBIZ-11074) Have a service to load records in the sales channel dimension

2020-03-30 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070742#comment-17070742
 ] 

Pierre Smits commented on OFBIZ-11074:
--

Patch available via https://github.com/apache/ofbiz-plugins/pull/11 See 
OFBIZ-11414

> Have a service to load records in the sales channel dimension
> -
>
> Key: OFBIZ-11074
> URL: https://issues.apache.org/jira/browse/OFBIZ-11074
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Release Branch 18.12, Release Branch 17.12
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: SalesChannel, SalesChannelDimension, birt, dwh, 
> initialisation, service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on issue #11: Improved: BI Component (OFBIZ-11414)

2020-03-30 Thread GitBox
sonarcloud[bot] removed a comment on issue #11: Improved: BI Component 
(OFBIZ-11414)
URL: https://github.com/apache/ofbiz-plugins/pull/11#issuecomment-605683637
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on issue #11: Improved: BI Component (OFBIZ-11414)

2020-03-30 Thread GitBox
sonarcloud[bot] commented on issue #11: Improved: BI Component (OFBIZ-11414)
URL: https://github.com/apache/ofbiz-plugins/pull/11#issuecomment-605819311
 
 
   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=VULNERABILITY)
 (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=SECURITY_HOTSPOT)
 to review)  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=11=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=11=new_duplicated_lines_density=list)
   
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (OFBIZ-10991) Have a SalesChannel dimension

2020-03-30 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070734#comment-17070734
 ] 

Pierre Smits commented on OFBIZ-10991:
--

Patch available via https://github.com/apache/ofbiz-plugins/pull/11 See 
OFBIZ-11414

> Have a SalesChannel dimension
> -
>
> Key: OFBIZ-10991
> URL: https://issues.apache.org/jira/browse/OFBIZ-10991
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: SalesChannel, SalesChannelDimension, birt, dimension, dwh
>
> The component would benefit from a sales channel dimension for future fact 
> tables and star schema view entities



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11086) Have a ProjectTask Dimension

2020-03-30 Thread Pierre Smits (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070733#comment-17070733
 ] 

Pierre Smits commented on OFBIZ-11086:
--

Patch available via https://github.com/apache/ofbiz-plugins/pull/11 See 
OFBIZ-11414

> Have a ProjectTask Dimension
> 
>
> Key: OFBIZ-11086
> URL: https://issues.apache.org/jira/browse/OFBIZ-11086
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: ProjectTaskDimension, birt, dimension, dwh
>
> The component would benefit from a project task dimension for future fact 
> tables and star schema view entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11534) Error in uploading large files

2020-03-30 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070704#comment-17070704
 ] 

Jacques Le Roux commented on OFBIZ-11534:
-

Thanks CHandan,

I think I have a slution coded, just testing...

> Error in uploading large files 
> ---
>
> Key: OFBIZ-11534
> URL: https://issues.apache.org/jira/browse/OFBIZ-11534
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-11534.patch
>
>
> There is an issue in uploading large files, I am able to upload files up to 2 
> GB successfully but getting an error when trying to upload a file larger than 
> 2GB.
> Example - 
> 1. Go to party profile -
> [https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=admin]
> 2. Try to create a party content with a file larger than 2 GB
> 3. Error on console
> 
> java.lang.NegativeArraySizeException: 
> nulljava.lang.NegativeArraySizeException: null at 
> org.apache.commons.fileupload.disk.DiskFileItem.get(DiskFileItem.java:308) 
> ~[commons-fileupload-1.4.jar:1.4] at 
> org.apache.ofbiz.base.util.UtilHttp.getMultiPartParameterMap(UtilHttp.java:275)
>  ~[main/:?] at 
> =
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-11534) Error in uploading large files

2020-03-30 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070704#comment-17070704
 ] 

Jacques Le Roux edited comment on OFBIZ-11534 at 3/30/20, 6:02 AM:
---

Thanks CHandan,

I think I have a solution coded, just testing...


was (Author: jacques.le.roux):
Thanks CHandan,

I think I have a slution coded, just testing...

> Error in uploading large files 
> ---
>
> Key: OFBIZ-11534
> URL: https://issues.apache.org/jira/browse/OFBIZ-11534
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Chandan Khandelwal
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-11534.patch
>
>
> There is an issue in uploading large files, I am able to upload files up to 2 
> GB successfully but getting an error when trying to upload a file larger than 
> 2GB.
> Example - 
> 1. Go to party profile -
> [https://demo-trunk.ofbiz.apache.org/partymgr/control/viewprofile?partyId=admin]
> 2. Try to create a party content with a file larger than 2 GB
> 3. Error on console
> 
> java.lang.NegativeArraySizeException: 
> nulljava.lang.NegativeArraySizeException: null at 
> org.apache.commons.fileupload.disk.DiskFileItem.get(DiskFileItem.java:308) 
> ~[commons-fileupload-1.4.jar:1.4] at 
> org.apache.ofbiz.base.util.UtilHttp.getMultiPartParameterMap(UtilHttp.java:275)
>  ~[main/:?] at 
> =
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)