[jira] [Commented] (OFBIZ-11389) Convert createContentAlternativeUrl service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080259#comment-17080259 ] Priya Sharma commented on OFBIZ-11389: -- Updated the find conditions for the content. Thanks, [~pawan] for suggesting the change. > Convert createContentAlternativeUrl service from mini-lang to groovy DSL > > > Key: OFBIZ-11389 > URL: https://issues.apache.org/jira/browse/OFBIZ-11389 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-11389.patch, OFBIZ-11389.patch > > > Convert createContentAlternativeUrl service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11389) Convert createContentAlternativeUrl service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-11389: - Attachment: OFBIZ-11389.patch > Convert createContentAlternativeUrl service from mini-lang to groovy DSL > > > Key: OFBIZ-11389 > URL: https://issues.apache.org/jira/browse/OFBIZ-11389 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-11389.patch, OFBIZ-11389.patch > > > Convert createContentAlternativeUrl service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11480) Convert updatePayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-11480: Assignee: Priya Sharma (was: Devanshu Vyas) > Convert updatePayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11480 > URL: https://issues.apache.org/jira/browse/OFBIZ-11480 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > > Convert the updatePayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11389) Convert createContentAlternativeUrl service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17080211#comment-17080211 ] Priya Sharma commented on OFBIZ-11389: -- Updated the patch with some better code practices * removed usage of UtilValidate and used groovy truth instead * used specific exceptions catch instead of the generic one. Someone, please review the patch. Thanks! > Convert createContentAlternativeUrl service from mini-lang to groovy DSL > > > Key: OFBIZ-11389 > URL: https://issues.apache.org/jira/browse/OFBIZ-11389 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-11389.patch > > > Convert createContentAlternativeUrl service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11389) Convert createContentAlternativeUrl service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-11389: - Attachment: (was: OFBIZ-11389.patch) > Convert createContentAlternativeUrl service from mini-lang to groovy DSL > > > Key: OFBIZ-11389 > URL: https://issues.apache.org/jira/browse/OFBIZ-11389 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-11389.patch > > > Convert createContentAlternativeUrl service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11389) Convert createContentAlternativeUrl service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-11389: - Attachment: OFBIZ-11389.patch > Convert createContentAlternativeUrl service from mini-lang to groovy DSL > > > Key: OFBIZ-11389 > URL: https://issues.apache.org/jira/browse/OFBIZ-11389 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-11389.patch, OFBIZ-11389.patch > > > Convert createContentAlternativeUrl service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11409) POC for Dynamic Screen Using MVVM
[
https://issues.apache.org/jira/browse/OFBIZ-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-11409:
---
Description:
Proof of concept for Model–view–viewmodel (MVVM) in form widgets.
Added data-bind attribute to the field, form and grid tag.
Example 1:
Go to [https://localhost:8443/humanres/control/NewEmployee] and try the
following field:
# First name
# Middle name
# Last name
Added Full Name field to demonstrate computed observable/property.
Example 2:
Page at
[https://localhost:8443/ordermgr/control/ListQuoteItemsDemo?quoteId=CQ0001]
duplicated the functionality of Quote Items page, but done using data-binding
way.
mbrohl: here is a link to the discussion on the dev mailing list:
[https://lists.apache.org/thread.html/r1cddbc8041e5a6559bfad979bc8570581a3d1f662a0f8692c7ee9e59%40%3Cdev.ofbiz.apache.org%3E]
*15th March 2020*
Updated the patch with more concrete examples for form and grid.
*10th April 2020*
Updated the patch with initVmFunc and some refactoring.
1) A javascript model function will be generated for the form / grid widgets
when its data-bind attribute is defined.
2) First row of the grid is generated by the ofbiz renderer at the server side.
Subsequent rows will be generated by knockout at the browser side.
3) Naming convention of the viewmodel function is *VmFunc*. There is a viewmodel for the Grid widget at row level; naming
convention is *VmRowFunc*.
4) Viewmodel function can be extended using javascript prototype. See the
*.js.ftl files in the patch.
5) The following javascript files are used:
* big/big.js - for basic mathematics operation
* knockout/knockout-3.5.1.js - knockout library
* knockout/knockout-config.js - extending the library and some code to
configure knockout-secure-binding
* knockout/knockout-secure-binding - allow knockout js to be used with a
Content Security Policy that disables eval and new Function.
6) Example of hyperlink:
Before:
{code:xml}
{code}
After:
{code:xml}
{code}
{code:javascript}
ListQuoteItemsDemoVmRowFunc.prototype = {
computed: {
"editQuoteItemLink": function(){
return "<@ofbizUrl>EditQuoteItem?=" +
this.quoteItemSeqId() + "=" + this.quoteId();
},
...
};
{code}
>From the value of data-bind attribute, we can see that the href attribute
>points to the editQuoteItemLink function.
editQuoteItemLink is a prototype member of ListQuoteItemsDemo*VmRowFunc* which
is viewmodel function for the Grid widget at row level.
7) Example of decimal places:
{code:javascript}
extend: {
"quoteUnitPrice": {numeric: 2}
}
{code}
The column or field for qouteUnitPrice will be rounded to 2 decimal places.
8) Example of calculating line totals:
{code:xml}
{code}
{code:javascript}
ListQuoteItemsDemoVmRowFunc.prototype = {
computed: {
...
"lineTotal": function() {
var itemPrice = this.quoteUnitPrice();
var selectedAmount = this.selectedAmount() || 1;
var quantity = this.quantity() || 0;
return new
Big(itemPrice).times(selectedAmount).times(quantity).toFixed(2);
}
...
};
{code}
was:
Proof of concept for Model–view–viewmodel (MVVM) in form widgets.
Added data-bind attribute to the field, form and grid tag.
Example 1:
Go to [https://localhost:8443/humanres/control/NewEmployee] and try the
following field:
# First name
# Middle name
# Last name
Added Full Name field to demonstrate computed observable/property.
Example 2:
Page at
[https://localhost:8443/ordermgr/control/ListQuoteItemsDemo?quoteId=CQ0001]
duplicated the functionality of Quote Items page, but done using data-binding
way.
mbrohl: here is a link to the discussion on the dev mailing list:
[https://lists.apache.org/thread.html/r1cddbc8041e5a6559bfad979bc8570581a3d1f662a0f8692c7ee9e59%40%3Cdev.ofbiz.apache.org%3E]
*15th March 2020*
Updated the patch with more concrete examples for form and grid.
1) A javascript viewmodel function will be generated for the form / grid
widgets when its data-bind attribute is defined.
2) First row of the grid is generated by the ofbiz renderer at the server side.
Subsequent rows will be generated by knockout at the browser side.
3) Naming convention of the viewmodel is Vm. There is a
viewmodel for the Grid widget at row level; naming convention is RowVm.
4) Viewmodel can be extended. See the *.js.ftl files in the patch.
5) The following javascript files are used:
* big/big.js - for basic mathematics operation
* knockout/knockout-3.5.1.js - knockout library
* knockout/knockout-config.js - extending the library and some code to
configure knockout-secure-binding
* knockout/knockout-secure-binding - allow knockout js to be used with a
Content Security Policy that disables eval and new Function.
6)
[jira] [Updated] (OFBIZ-11409) POC for Dynamic Screen Using MVVM
[
https://issues.apache.org/jira/browse/OFBIZ-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-11409:
---
Attachment: OFBIZ-11409.patch
> POC for Dynamic Screen Using MVVM
> -
>
> Key: OFBIZ-11409
> URL: https://issues.apache.org/jira/browse/OFBIZ-11409
> Project: OFBiz
> Issue Type: Improvement
> Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch,
> OFBIZ-11409.patch
>
>
> Proof of concept for Model–view–viewmodel (MVVM) in form widgets.
> Added data-bind attribute to the field, form and grid tag.
> Example 1:
> Go to [https://localhost:8443/humanres/control/NewEmployee] and try the
> following field:
> # First name
> # Middle name
> # Last name
> Added Full Name field to demonstrate computed observable/property.
> Example 2:
> Page at
> [https://localhost:8443/ordermgr/control/ListQuoteItemsDemo?quoteId=CQ0001]
> duplicated the functionality of Quote Items page, but done using data-binding
> way.
> mbrohl: here is a link to the discussion on the dev mailing list:
> [https://lists.apache.org/thread.html/r1cddbc8041e5a6559bfad979bc8570581a3d1f662a0f8692c7ee9e59%40%3Cdev.ofbiz.apache.org%3E]
> *15th March 2020*
> Updated the patch with more concrete examples for form and grid.
> 1) A javascript viewmodel function will be generated for the form / grid
> widgets when its data-bind attribute is defined.
> 2) First row of the grid is generated by the ofbiz renderer at the server
> side. Subsequent rows will be generated by knockout at the browser side.
> 3) Naming convention of the viewmodel is Vm. There is a
> viewmodel for the Grid widget at row level; naming convention is RowVm of Grid>.
> 4) Viewmodel can be extended. See the *.js.ftl files in the patch.
> 5) The following javascript files are used:
> * big/big.js - for basic mathematics operation
> * knockout/knockout-3.5.1.js - knockout library
> * knockout/knockout-config.js - extending the library and some code to
> configure knockout-secure-binding
> * knockout/knockout-secure-binding - allow knockout js to be used with a
> Content Security Policy that disables eval and new Function.
> 6) Example of hyperlink:
> Before:
> {code:xml}
> widget-style="buttontext" use-when="${groovy: 'N'.equals(isPromo)}">
> also-hidden="false">
>
>
>
>
> {code}
> After:
> {code:xml}
> data-bind="text:quoteItemSeqId, attr: { href:
> editQuoteItemLink, title: 'Quote Item Seq ID'}"
>widget-style="buttontext">
>
>
> {code}
> {code:javascript}
> RowVmListQuoteItemsDemo.prototype = {
> computed: {
> "editQuoteItemLink": function(){
> return "<@ofbizUrl>EditQuoteItem?=" +
> this.quoteItemSeqId() + "=" + this.quoteId();
> },
>...
> };
> {code}
> From the value of data-bind attribute, we can see that the href attribute
> points to the editQuoteItemLink function.
> editQuoteItemLink is a prototype member of RowVmListQuoteItemsDemo, while
> RowVmListQuoteItemsDemo is viewmodel for the Grid widget at row level.
> 7) Example of decimal places:
> {code:javascript}
> extend: {
> "quoteUnitPrice": {numeric: 2}
> }
> {code}
> The column or field for qouteUnitPrice will be rounded to 2 decimal places.
> 8) Example of calculating line totals:
> {code:xml}
>
> {code}
> {code:javascript}
> RowVmListQuoteItemsDemo.prototype = {
> computed: {
> ...
> "lineTotal": function() {
> var itemPrice = this.quoteUnitPrice();
> var selectedAmount = this.selectedAmount() || 1;
> var quantity = this.quantity() || 0;
> return new
> Big(itemPrice).times(selectedAmount).times(quantity).toFixed(2);
> }
> ...
> };
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079294#comment-17079294 ] Pawan Verma commented on OFBIZ-11479: - Thanks, [~jleroux] :) > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch, OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079281#comment-17079281 ] Priya Sharma commented on OFBIZ-11479: -- I am good with it. Thanks [~pawan]. > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch, OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079274#comment-17079274 ] ASF subversion and git services commented on OFBIZ-11479: - Commit aef9382a9c8e242af0d629f331bb5c73ea4e4746 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=aef9382 ] Implemented: Convert createPayment service from mini-lang to groovy DSL (OFBIZ-11479) Better code with Groovy truth Thanks: Pawan Verma > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch, OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079275#comment-17079275 ] Jacques Le Roux commented on OFBIZ-11479: - Thank you Pawan! > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch, OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11479: Attachment: OFBIZ-11479.patch > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch, OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079250#comment-17079250 ] Pawan Verma commented on OFBIZ-11479: - Hello [~priya.sharma.9362], [~jleroux] Thanks, for the work. Sorry I got late to review the patch. I have a small suggestion, Should we use Groovy truth instead of UtilValidate Methods? Also, added some lined space to make code more beautiful :D I've attached a patch with this improvement. If it looks good to you guys, we can proceed with it :) > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch, OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079104#comment-17079104 ] Jacques Le Roux commented on OFBIZ-11479: - Quite happy to do so :) > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079100#comment-17079100 ] Priya Sharma commented on OFBIZ-11479: -- Thanks [~jleroux]. You really keep me motivated to provide more patches ;) > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079093#comment-17079093 ] ASF subversion and git services commented on OFBIZ-11479: - Commit b8848355d188ff91ce84e71b16433c9cf278b8d0 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b884835 ] Implemented: Convert createPayment service from mini-lang to groovy DSL (OFBIZ-11479) jleroux: I have only changed the MODULE name (and uppercased it) Thanks: Priya Sharma > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11479. --- Resolution: Implemented > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11591) Convert InventoryIssueServices minilang to groovy
Sebastian Berg created OFBIZ-11591: -- Summary: Convert InventoryIssueServices minilang to groovy Key: OFBIZ-11591 URL: https://issues.apache.org/jira/browse/OFBIZ-11591 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11479: --- Assignee: Priya Sharma (was: Jacques Le Roux) Thanks Priya, I'll soon commit. I have only changed the MODULE name (and uppercased it) > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"
[
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079047#comment-17079047
]
Sebastian Berg commented on OFBIZ-4361:
---
Hi [~nmalin],
you wrote
{quote}Also I will open an issue for the works submitted by [~Dennis Balkir] to
open a new login with validation process
{quote}
a couple of month ago. Did you ever got around creating the issue? If so maybe
you can link it for me?
> Any ecommerce user has the ability to reset anothers password (including
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release
> Branch 14.12, Release Branch 15.12, Release Branch 16.11, Release Branch
> 17.12, Trunk
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: security
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch,
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch,
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to
> reset another users password, including "admin" without permission. By
> simply entering "admin" and clicking "Email Password", the following is
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password. It is also
> possible to generate a dictionary attack against ofbiz because there is no
> capta code required. This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name
> is optionally in the format of an email address, and maybe require a capta
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was
> generated via an ecommerce transaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11462) Convert ShipmentServices.xml from minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-11462: - Assignee: Nicolas Malin (was: Sebastian Berg) > Convert ShipmentServices.xml from minilang to groovy > > > Key: OFBIZ-11462 > URL: https://issues.apache.org/jira/browse/OFBIZ-11462 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Nicolas Malin >Priority: Minor > Fix For: Upcoming Branch > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11479) Convert createPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11479: --- Assignee: Jacques Le Roux (was: Priya Sharma) > Convert createPayment service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11479 > URL: https://issues.apache.org/jira/browse/OFBIZ-11479 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11479.patch > > > Convert the createPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10672) Errors on Quick Add Page
[ https://issues.apache.org/jira/browse/OFBIZ-10672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-10672. --- Resolution: Not A Problem Closing: no pb in any of the currently supported branches: R17, R18 and trunk > Errors on Quick Add Page > > > Key: OFBIZ-10672 > URL: https://issues.apache.org/jira/browse/OFBIZ-10672 > Project: OFBiz > Issue Type: Bug >Reporter: Rashi Dhagat >Assignee: Aman Mishra >Priority: Major > Attachments: OFBIZ-10672-BigGizmo.png, > OFBIZ-10672-ItemsAndPromosInCart.png, OFBIZ-10672-Products.png, > OFBIZ-10672-RoundGizmo.png, QuickAdd.gif, QuickAddPage.png, > QuickAdd[16.11].jpg > > > Steps to regenerate: > # Open URL https://demo-old.ofbiz.apache.org/ecommerce/control/main > # Click on Quick Add > # Add 1 quantity of Round Gizmo > # Click on Add all to cart > # Add 1 quantity of Big Gizmo > # Click on Add all to cart > Actual: > # When added Round Gizmo, only one quantity is added to cart with 0 price > # When added Big Gizmo, all items are added to cart > # Distorted UI of Quick Add page > # Quantity field is empty > -- This message was sent by Atlassian Jira (v8.3.4#803005)
