[jira] [Updated] (OFBIZ-11729) Import products from Shopify
[ https://issues.apache.org/jira/browse/OFBIZ-11729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shikha Jaiswal updated OFBIZ-11729: --- Description: We will be creating screen to import all products from Shopify. This screen will also contain date fields to import products created in a specific time duration on Shopify. Shopify Product API: [https://shopify.dev/docs/admin-api/rest/reference/products/product?api[version]=2020-04#index-2020-04|https://shopify.dev/docs/admin-api/rest/reference/products/product?api[version]=2020-04#index-2020-04] was:We will be creating screen to import all products from Shopify. This screen will also contain date fields to import products created in a specific time duration on Shopify. > Import products from Shopify > > > Key: OFBIZ-11729 > URL: https://issues.apache.org/jira/browse/OFBIZ-11729 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Shikha Jaiswal >Priority: Major > > We will be creating screen to import all products from Shopify. This screen > will also contain date fields to import products created in a specific time > duration on Shopify. > Shopify Product API: > [https://shopify.dev/docs/admin-api/rest/reference/products/product?api[version]=2020-04#index-2020-04|https://shopify.dev/docs/admin-api/rest/reference/products/product?api[version]=2020-04#index-2020-04] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17117401#comment-17117401 ] Aditya Sharma commented on OFBIZ-11574: --- Thanks [~holivier] > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #117: Improved: Update Data Sets
PierreSmits commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-633900985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on pull request #153: Improved: instruction on data-model upgrade (OFBIZ-11719)
PierreSmits commented on pull request #153: URL: https://github.com/apache/ofbiz-framework/pull/153#issuecomment-633896879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #58: OFBIZ-11574 Datamodel_change migration to asciidoc
adityasharma7 commented on pull request #58: URL: https://github.com/apache/ofbiz-framework/pull/58#issuecomment-633592640 I have created a new PR resolving the conflicts https://github.com/apache/ofbiz-framework/pull/160 There was field entry added after the above PR. I tried with the above steps to resolve conflicts not sure why it didn't allow me to push to trunk. I will check later This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] verma-pawan merged pull request #121: Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677)
verma-pawan merged pull request #121: URL: https://github.com/apache/ofbiz-framework/pull/121 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 closed pull request #58: OFBIZ-11574 Datamodel_change migration to asciidoc
adityasharma7 closed pull request #58: URL: https://github.com/apache/ofbiz-framework/pull/58 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 merged pull request #160: OFBIZ-11574 Datamodel_change migration to asciidoc
adityasharma7 merged pull request #160: URL: https://github.com/apache/ofbiz-framework/pull/160 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #121: Fixed: organisation tree in humanres doesn't show person names (OFBIZ-11677)
JacquesLeRoux commented on pull request #121: URL: https://github.com/apache/ofbiz-framework/pull/121#issuecomment-633616503 Thanks Pawan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #164: Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)
sonarcloud[bot] commented on pull request #164: URL: https://github.com/apache/ofbiz-framework/pull/164#issuecomment-633982385 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=164=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=164) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=164=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits edited a comment on pull request #117: Improved: Update Data Sets
PierreSmits edited a comment on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-633900985 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits closed pull request #153: Improved: instruction on data-model upgrade (OFBIZ-11719)
PierreSmits closed pull request #153: URL: https://github.com/apache/ofbiz-framework/pull/153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 opened a new pull request #160: OFBIZ-11574 Datamodel_change migration to asciidoc
adityasharma7 opened a new pull request #160: URL: https://github.com/apache/ofbiz-framework/pull/160 Documented: datamodel markdown migration to asciidoc (OFBIZ-11574) - DATAMODEL_CHANGE migration to asciidoc and add a included in developer_manual - Readme migration to asciidoc - Added new field parentGlXbrlClassId taking reference from DATAMODEL_CHANGES.md which was added with OFBIZ-10613 and missing in adoc file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #162: Improved: instructions to upgrade due to datamodel changes (OFBIZ-11719)
sonarcloud[bot] commented on pull request #162: URL: https://github.com/apache/ofbiz-framework/pull/162#issuecomment-633957145 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=162=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=162) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=162=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=162=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #163: Fixed: Multiple menu item link parameters get lost for layered-modal (OFBIZ-11743)
sonarcloud[bot] commented on pull request #163: URL: https://github.com/apache/ofbiz-framework/pull/163#issuecomment-633966108 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=163=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=163) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=163=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #153: Improved: instruction on data-model upgrade (OFBIZ-11719)
adityasharma7 commented on pull request #153: URL: https://github.com/apache/ofbiz-framework/pull/153#issuecomment-633892047 Thanks for your contribution @PierreSmits With OFBIZ-11574, we have migrated the DATAMODEL_CHANGES.md to DATAMODEL_CHANGES.adoc. Please update your local branch and add these changes in adoc file This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #117: Improved: Update Data Sets
adityasharma7 commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-633894581 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #160: OFBIZ-11574 Datamodel_change migration to asciidoc
sonarcloud[bot] commented on pull request #160: URL: https://github.com/apache/ofbiz-framework/pull/160#issuecomment-633593006 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=160=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=160) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=160=new_duplicated_lines_density=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=160=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 opened a new pull request #164: Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)
adityasharma7 opened a new pull request #164: URL: https://github.com/apache/ofbiz-framework/pull/164 - DATAMODEL_CHANGE migration to asciidoc and add a included in developer_manual - Readme migration to asciidoc This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #161: Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304)
sonarcloud[bot] commented on pull request #161: URL: https://github.com/apache/ofbiz-framework/pull/161#issuecomment-633814044 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=161=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=161) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=161=new_duplicated_lines_density=list) [0.3% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=161=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] uheidfeld opened a new pull request #163: Fixed: Multiple menu item link parameters get lost for layered-modal (OFBIZ-11743)
uheidfeld opened a new pull request #163: URL: https://github.com/apache/ofbiz-framework/pull/163 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] Olivier-Heintz closed pull request #164: Documented: datamodel markdown migration to asciidoc (OFBIZ-11574)
Olivier-Heintz closed pull request #164: URL: https://github.com/apache/ofbiz-framework/pull/164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #117: Improved: Update Data Sets
sonarcloud[bot] commented on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-633845650 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits commented on a change in pull request #113: Improved: Convert EntitySyncServices.xml mini-lang to groovy (OFBIZ-11660)
PierreSmits commented on a change in pull request #113: URL: https://github.com/apache/ofbiz-framework/pull/113#discussion_r430054089 ## File path: framework/entityext/servicedef/services.xml ## @@ -447,7 +447,7 @@ under the License. + location="component://entityext/groovyScripts/EntitySyncServices.groovy" invoke="entitySyncPermissionCheck"> Review comment: Thanks for the suggestion, @surajkhurana. I will look into that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets
sonarcloud[bot] removed a comment on pull request #117: URL: https://github.com/apache/ofbiz-framework/pull/117#issuecomment-632598485 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=117=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=117=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] PierreSmits opened a new pull request #162: Improved: instructions to upgrade due to datamodel changes (OFBIZ-11719)
PierreSmits opened a new pull request #162: URL: https://github.com/apache/ofbiz-framework/pull/162 New PR due to merge conflicts on PR #153 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 opened a new pull request #161: Implemented: pre commit hook to check staged files with list issues (OFBIZ-11304)
adityasharma7 opened a new pull request #161: URL: https://github.com/apache/ofbiz-framework/pull/161 Used git-hooks-gradle-plugin with MIT license that helps configure shared Git hooks with Gradle buildscript https://github.com/jakemarsden/git-hooks-gradle-plugin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 commented on pull request #162: Improved: instructions to upgrade due to datamodel changes (OFBIZ-11719)
adityasharma7 commented on pull request #162: URL: https://github.com/apache/ofbiz-framework/pull/162#issuecomment-633977070 Thank you @PierreSmits for your contribution! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] adityasharma7 merged pull request #162: Improved: instructions to upgrade due to datamodel changes (OFBIZ-11719)
adityasharma7 merged pull request #162: URL: https://github.com/apache/ofbiz-framework/pull/162 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (OFBIZ-11693) Help system using asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115746#comment-17115746 ] Jacques Le Roux edited comment on OFBIZ-11693 at 5/26/20, 5:18 PM: --- Thanks Olivier, Looks good to me, I made few modifications: [^ofbiz.conf.patch] . Nothing functional, only the titles and removed a duplicated line in RAT build, please review. We can't commit yet because the tree structure is not ready: https://ci.apache.org/projects/ofbiz/site/ Also while at it I'd like to finalise INFRA-20148 before committing... was (Author: jacques.le.roux): Thanks Olivier, Looks good to me, I made few modifications: . Nothing functional, only the titles and removed a duplicated line in RAT build, please review. We can't commit yet because the tree structure is not ready: https://ci.apache.org/projects/ofbiz/site/ Also while at it I'd like to finalise INFRA-20148 before committing... > Help system using asciidoc files > > > Key: OFBIZ-11693 > URL: https://issues.apache.org/jira/browse/OFBIZ-11693 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: documentation, help, help-system > Attachments: > OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, > OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, > OFBIZ-11693_0003-Documented-Migrate-CommonExtHelData.xml-to-added-som.patch, > ofbiz.conf.patch, ofbiz.conf.patch > > > a very simple solution which is a link to a documentation site. > This solution use > 1. at application level, a default proprety for documentation website uri > 2. at the screen level > * it would be possible to give a other uri (for user documentation) > * if the anchor in the user documentation for this screen is put, the new > help is used otherwise the older link is used -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11693) Help system using asciidoc files
[ https://issues.apache.org/jira/browse/OFBIZ-11693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115746#comment-17115746 ] Jacques Le Roux edited comment on OFBIZ-11693 at 5/26/20, 5:17 PM: --- Thanks Olivier, Looks good to me, I made few modifications: . Nothing functional, only the titles and removed a duplicated line in RAT build, please review. We can't commit yet because the tree structure is not ready: https://ci.apache.org/projects/ofbiz/site/ Also while at it I'd like to finalise INFRA-20148 before committing... was (Author: jacques.le.roux): Thanks Olivier, Looks good to me, I made few modifications. Nothing functional, only the titles and removed a duplicated line in RAT build, please review. We can't commit yet because the tree structure is not ready: https://ci.apache.org/projects/ofbiz/site/ Also while at it I'd like to finalise INFRA-20148 before committing... > Help system using asciidoc files > > > Key: OFBIZ-11693 > URL: https://issues.apache.org/jira/browse/OFBIZ-11693 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Major > Labels: documentation, help, help-system > Attachments: > OFBIZ-11693_0001-Improvement-Help-link-using-asciidoc-files-via-gener.patch, > OFBIZ-11693_0002-Documented-Migrate-AccountingHelData.xml-to-added-so.patch, > OFBIZ-11693_0003-Documented-Migrate-CommonExtHelData.xml-to-added-som.patch, > ofbiz.conf.patch, ofbiz.conf.patch > > > a very simple solution which is a link to a documentation site. > This solution use > 1. at application level, a default proprety for documentation website uri > 2. at the screen level > * it would be possible to give a other uri (for user documentation) > * if the anchor in the user documentation for this screen is put, the new > help is used otherwise the older link is used -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz closed OFBIZ-11574. -- Resolution: Implemented > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116839#comment-17116839 ] Olivier Heintz commented on OFBIZ-11574: done > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116832#comment-17116832 ] ASF subversion and git services commented on OFBIZ-11574: - Commit 59be769be42ef7c2649ac70b8eb362e5ec721344 in ofbiz-framework's branch refs/heads/release18.12 from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=59be769 ] Documented: datamodel markdown migration to asciidoc (OFBIZ-11574) - DATAMODEL_CHANGE migration to asciidoc and add a included in developer_manual - Readme migration to asciidoc > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116833#comment-17116833 ] ASF subversion and git services commented on OFBIZ-11574: - Commit 9c51ae428951f875499576d4ba7f904d0fa7f437 in ofbiz-framework's branch refs/heads/release18.12 from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9c51ae4 ] Documented: theme/README.md change theme/README.adoc but with very simple content (OFBIZ-11574) README.md has been migrated to asciidoc as doc/themes.adoc previously but remove README.md has been forgot. In this commit README.md is removed and a new README.adoc is created with only a brief component definition and link to the theme documentation (and developer-manual which included theme.adoc) > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116821#comment-17116821 ] Olivier Heintz commented on OFBIZ-11574: Answer to myself: In the previous comment, I was speaking about user-documentation file and not DATAMODEL_CHANGE :( so you are right, it's needed to change to release 18.12, because this file should be related to its current release. So, one more commit just after the merge. > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116812#comment-17116812 ] Olivier Heintz commented on OFBIZ-11574: [~adityasharma] you have created a new branch Olivier-Heintz-OFBIZ-11574_release18.12 same as the your PullRequest. I propose to directly do a merge (fast-forward) with release18.12 and remove the branch and close the PR currently all doc are with release 17.12 because it's the only one which is published I'm waiting, INFRA to have one directory per release to change in each release, to have the correct related release version. It will be a other commit Olivier > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11716) Apache OFBiz unsafe deserialization of XMLRPC arguments
[ https://issues.apache.org/jira/browse/OFBIZ-11716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116810#comment-17116810 ] Jacques Le Roux commented on OFBIZ-11716: - We should add the CVE number in the title once 17.12.04 is released. > Apache OFBiz unsafe deserialization of XMLRPC arguments > --- > > Key: OFBIZ-11716 > URL: https://issues.apache.org/jira/browse/OFBIZ-11716 > Project: OFBiz > Issue Type: Sub-task > Components: framework/webtools >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 18.12.01, 17.12.04 > > > Because the 2 xmlrpc related requets in webtools (xmlrpc and ping) are not > using authentication they are vulnerable to unsafe deserialization. > This issue was reported to the security team by Alvaro Munoz > from the GitHub Security Lab team -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11743:
-
Affects Version/s: (was: Release Branch 17.12)
17.12.03
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11742) AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask
[ https://issues.apache.org/jira/browse/OFBIZ-11742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116771#comment-17116771 ] Jacques Le Roux commented on OFBIZ-11742: - Hi Carsten, I wondered but it's something different than OFBIZ-11133, right? > AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask > -- > > Key: OFBIZ-11742 > URL: https://issues.apache.org/jira/browse/OFBIZ-11742 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk > Environment: IntelliJ IDEA Community Edition >Reporter: Carsten Schinzer >Priority: Minor > > in build.gradle (commit > [5e1a23d|https://github.com/apache/ofbiz-framework/commit/5e1a23de1c6cc92fa10cd6008e2e758cdf7ffe4f], > line #498) the context help states that: > @Deprecated class AsciidoctorTask extends AsciidoctorCompatibilityTask > This is just a wrapper class in a legacy package. All of the code has moved > to AsciidoctorCompatibilityTask. > Also, the gradle viewer in my IDE states that the following rows contain > syntax errors, yet it builds: > attributes \ > 'doctype': 'book', > 'experimental': '', > 'icons': 'font', > 'sectnums': '', > 'chapter-label': '', > 'toc': 'left@', > 'toclevels': '3' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11688) unable to load main class org.gradle.wrapper.GradleWrapperMain
[ https://issues.apache.org/jira/browse/OFBIZ-11688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-11688. --- Resolution: Abandoned > unable to load main class org.gradle.wrapper.GradleWrapperMain > -- > > Key: OFBIZ-11688 > URL: https://issues.apache.org/jira/browse/OFBIZ-11688 > Project: OFBiz > Issue Type: Bug >Reporter: muhammad >Priority: Major > > Hi everybody, > > I'm fedora user, for run ofbiz i meet an error!!! > Error: Could not find or load main class org.gradle.wrapper.GradleWrapperMain > How to fix it? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11679) OFBiz - Shopify integration plugin
[ https://issues.apache.org/jira/browse/OFBIZ-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116559#comment-17116559 ] Jacques Le Roux edited comment on OFBIZ-11679 at 5/26/20, 1:55 PM: --- Thanks everyone for your inputs. I think example of OFBIZ-10365, doesn't fits here, this is an integration and that was completely new process flow being introduced in OFBiz. IMO, regarding data model changes, again as this is an integration so no DM changes, except a new entity for configuration if we agreed upon, otherwise SystemProperty will do the job. Similarly, there is not much business logic involved, specially in integrations, you are simply mapping fields from 3rd party JSON data structure to one with your data model. Apart from these, we already mentioned in description that initially, we are trying to create an MVP and then anyone can pick up API's and start implementing those using that basic framework. We are taking references from existing eBay, Magento integration components. +1 [~arunpati] for Magento integration OFBIZ-6236, I also believe that if we still could have Magento integration in OFBiz (whatever version) it would be like another feather in the cap. For adopters, we can surely plan to create UM's. I hope that sounds good to everyone. was (Author: suraj.khurana): Thanks everyone for your inputs. I think example of OFBIZ-10365, doesn't fits here, this is an integration and that was completely new process flow being introduced in OFBiz. IMO, regarding data model changes, again as this is an integration so no DM changes, except a new entity for configuration if we agreed upon, otherwise SystemProperty will do the job. Similarly, there is not much business logic involved, specially in integrations, you are simply mapping fields from 3rd party JSON data structure to one with your data model. Apart from these, we already mentioned in description that initially, we are trying to create an MVP and then anyone can pick up API's and start implementing those using that basic framework. We are taking references from existing eBay, Magento integration components. +1 [~arunpati] for Magento integration ([https://issues.apache.org/jira/browse/OFBIZ-6236|https://www.google.com/url?q=https://issues.apache.org/jira/browse/OFBIZ-6236=D=hangouts=1590569964302000=AFQjCNHEFBItSJT6fBbkj2o1_X1l547y1w]), I also believe that if we still could have Magento integration in OFBiz (whatever version) it would be like another feather in the cap. For adopters, we can surely plan to create UM's. I hope that sounds good to everyone. > OFBiz - Shopify integration plugin > -- > > Key: OFBIZ-11679 > URL: https://issues.apache.org/jira/browse/OFBIZ-11679 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Here is the reference of ML discussion: > [https://markmail.org/thread/pktfygbz44a7z5kk] > This integration can be used to provide Order and Fulfillment Management to > the orders placed via Shopify store. > We are taking reference from available Magento plugin and planning to built > the same features as MVP. As an MVP, minimal features to implement are: > – Import locations > – Import products > – Import pending orders > – Create fulfillment on Shopify ie push shipment details and tracking code to > Shopify > After MVP, we will further move with other features like: > – Edit Order > – Order Cancellation > – Returns > Reference Shopify API documents: > [https://shopify.dev/docs/admin-api/rest/reference|https://shopify.dev/docs/admin-api/rest/reference] > We are planning to manage all the configurations in SystemProperty. > Thanks [~surajk] and [~ritesh.kumar] for discussing things. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11743:
Affects Version/s: (was: 17.12.03)
Release Branch 17.12
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11304) Install a Checkstyle pre-push (on every committer machine?)
[ https://issues.apache.org/jira/browse/OFBIZ-11304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116744#comment-17116744 ] Jacques Le Roux commented on OFBIZ-11304: - Thanks Aditya, I have still to review but that sounds promising. One thing I'm unsure about: is there a way to block a commit if tasks.checkstyleMain.maxErrors increases? > Install a Checkstyle pre-push (on every committer machine?) > --- > > Key: OFBIZ-11304 > URL: https://issues.apache.org/jira/browse/OFBIZ-11304 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Branch > > > The ofbizTrunkFrameworkPlugins build fails when a lint error is detected by > the check gradle task. It's "hard" to exactly know from where lint errors > come among all still present. > I think we should rely on a Checkstyle pre-commit hook like > https://gist.github.com/davetron5000/37350 to complement > tasks.checkstyleMain.maxErrors. This pre-commit hook prevents to commit when > a lint error is present in the commit. > Every committer would have it installed locally and the problem would be gone > with some committers good will. I started a discussion about it at > https://markmail.org/message/guxbsvdkzky7gtdx. Jacopo made the same > proposition years ago: https://markmail.org/message/gkgmko4axj3vtnv3 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Comment: was deleted
(was: Hi [~nmalin],
i have created a [GitHub pull
request|https://github.com/apache/ofbiz-framework/pull/163].)
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116716#comment-17116716
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~nmalin],
i have created a [GitHub pull
request|https://github.com/apache/ofbiz-framework/pull/163].
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116708#comment-17116708
]
Pierre Smits commented on OFBIZ-11743:
--
Manually added link to PR.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116703#comment-17116703
]
Pierre Smits commented on OFBIZ-11743:
--
HI [~nmalin],
A PR exists. See https://github.com/apache/ofbiz-framework/pull/163.
Unfortunately, it is not listed under links (which normally happens when
everything is ok). Maybe there is some delay happening.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116701#comment-17116701
]
Nicolas Malin commented on OFBIZ-11743:
---
Hi [~uHeidfeld] do you have a patch to submit ? otherwise I will investigate.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116680#comment-17116680 ] Aditya Sharma edited comment on OFBIZ-11574 at 5/26/20, 12:11 PM: -- [~holivier] I have created a PR. I have skipped the last commit that I added manually as those changes were not present in 18.12. https://github.com/apache/ofbiz-framework/pull/164/files Could you please verify once? Also, I noticed that in readme.adoc we have release as 17.12. I think we should also change that. [https://github.com/apache/ofbiz-framework/pull/164/files#diff-cc96f031b150a8184b5d9d4ec454a3cbR21] was (Author: aditya.sharma): [~holivier] I have created a PR. I have skipped the last commit that I added manually as those changes were not present in 18.12. Could you please verify once? Also, I noticed that in readme.adoc we have release as 17.12. I think we should also change that. https://github.com/apache/ofbiz-framework/pull/164/files#diff-cc96f031b150a8184b5d9d4ec454a3cbR21 > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116680#comment-17116680 ] Aditya Sharma commented on OFBIZ-11574: --- [~holivier] I have created a PR. I have skipped the last commit that I added manually as those changes were not present in 18.12. Could you please verify once? Also, I noticed that in readme.adoc we have release as 17.12. I think we should also change that. https://github.com/apache/ofbiz-framework/pull/164/files#diff-cc96f031b150a8184b5d9d4ec454a3cbR21 > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116671#comment-17116671 ] ASF subversion and git services commented on OFBIZ-11574: - Commit db6cab94c0466614d24ad05c6968d0516bde4ad9 in ofbiz-framework's branch refs/heads/Olivier-Heintz-OFBIZ-11574_release18.12 from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=db6cab9 ] Documented: datamodel markdown migration to asciidoc (OFBIZ-11574) - DATAMODEL_CHANGE migration to asciidoc and add a included in developer_manual - Readme migration to asciidoc > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11574) DATAMODEL_CHANGE migration to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116672#comment-17116672 ] ASF subversion and git services commented on OFBIZ-11574: - Commit eb57d93a68fc89ca6e91f16f4fcc7fa7170c7acf in ofbiz-framework's branch refs/heads/Olivier-Heintz-OFBIZ-11574_release18.12 from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=eb57d93 ] Documented: theme/README.md change theme/README.adoc but with very simple content (OFBIZ-11574) README.md has been migrated to asciidoc as doc/themes.adoc previously but remove README.md has been forgot. In this commit README.md is removed and a new README.adoc is created with only a brief component definition and link to the theme documentation (and developer-manual which included theme.adoc) > DATAMODEL_CHANGE migration to asciidoc > -- > > Key: OFBIZ-11574 > URL: https://issues.apache.org/jira/browse/OFBIZ-11574 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 10m > Remaining Estimate: 0h > > Migrate form datamodel component Readme and DATAMODEL_CHANGE from md format > to asciidoc > Modification of developer_manual to Include DATAMODEL_CHANGE in Entity-Engine > chapter. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11719) Add instructions re Field Changes in DATAMODEL_CHANGES.md
[ https://issues.apache.org/jira/browse/OFBIZ-11719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Smits closed OFBIZ-11719. Fix Version/s: Trunk Resolution: Implemented Thanks [~adityasharma], for your assistance to get this into the codebase. > Add instructions re Field Changes in DATAMODEL_CHANGES.md > - > > Key: OFBIZ-11719 > URL: https://issues.apache.org/jira/browse/OFBIZ-11719 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: data-model, devops, entity-model > Fix For: Trunk > > > Add a few instructions how to deal with field changes that include prim-key > (IsPK) changes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11719) Add instructions re Field Changes in DATAMODEL_CHANGES.md
[ https://issues.apache.org/jira/browse/OFBIZ-11719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116664#comment-17116664 ] ASF subversion and git services commented on OFBIZ-11719: - Commit 96c428d1cfd8fa2f72e91a219af7de642dd6 in ofbiz-framework's branch refs/heads/trunk from Pierre Smits [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=96c428d ] Improved: instructions to upgrade due to datamodel changes (OFBIZ-11719) (#162) > Add instructions re Field Changes in DATAMODEL_CHANGES.md > - > > Key: OFBIZ-11719 > URL: https://issues.apache.org/jira/browse/OFBIZ-11719 > Project: OFBiz > Issue Type: Improvement > Components: datamodel >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Labels: data-model, devops, entity-model > > Add a few instructions how to deal with field changes that include prim-key > (IsPK) changes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116661#comment-17116661
]
Pierre Smits commented on OFBIZ-11743:
--
Hi [~uHeidfeld],
I made the 'Affected Version(s) field a bit more specific. Unfortunately,
17.12.01 couldn't be selected, due to guidelines/policies. See [1] and [2]
IMO, release 18.12 shouldn't be selected either, as it has no releases. It
should, however, be used in the 'Fix version(s) if and when back ported.
[1] https://cwiki.apache.org/confluence/display/OFBIZ/Guidelines+For+Using+JIRA
[2]
https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Committers+Roles+and+Responsibilities
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11743:
-
Affects Version/s: (was: Release Branch 17.12)
17.12.03
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Affects Version/s: Release Branch 17.12
Release Branch 18.12
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116649#comment-17116649
]
Ulrich Heidfeld commented on OFBIZ-11743:
-
Hi [~pierresmits],
this bug appears in 17.12.1, 17.12.3 and 18.12 too. It would be nice, if this
versions also get fixed.
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116616#comment-17116616
]
Pierre Smits commented on OFBIZ-11743:
--
This also appears in releases (17.12.1 and 17.12.3)? If so, should we backport?
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Smits updated OFBIZ-11743:
-
Labels: Modal link menu menu-item (was: Modal link menu)
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu, menu-item
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Labels: Modal link menu (was: )
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Labels: Modal, link, menu
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ulrich Heidfeld updated OFBIZ-11743:
Component/s: framework/widget
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
[
https://issues.apache.org/jira/browse/OFBIZ-11743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116610#comment-17116610
]
Pierre Smits commented on OFBIZ-11743:
--
Hi [~uHeidfeld],
+1. Makes sense. Layer-model application in widgets (and templates) are
essential to modern-day solutions visavis usability.
Can you update the component and label fields?
> Multiple menu item link parameters get lost if link type is layered-modal
> -
>
> Key: OFBIZ-11743
> URL: https://issues.apache.org/jira/browse/OFBIZ-11743
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Trunk
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
>
> I got problems by opening a modal via menu link with two parameters. Only the
> first parameter is successfully accessible in modal's screens definition.
> Investigation revealed that for a menu link of type 'layered-modal' inline
> JS-Code get created with defined action-String. This String is used to set
> following context parameters.
> The problem is, that parameter concatenating expression '&' is not encoded
> like
> {code:java}
> // .../control/uri?param1=1param2=2
> {code}
>
> My solution for this problem was to extend MacroMenuRenderer#renderLink by
> replacing
> {code:java}
> {code}
> by '&'.
> Furthermore, this method shows that submitted parameters, defined between
> menus link tags, will be ignored, if link type is 'layered-modal'. So, within
> action-String, we have to submit parameters.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11743) Multiple menu item link parameters get lost if link type is layered-modal
Ulrich Heidfeld created OFBIZ-11743:
---
Summary: Multiple menu item link parameters get lost if link type
is layered-modal
Key: OFBIZ-11743
URL: https://issues.apache.org/jira/browse/OFBIZ-11743
Project: OFBiz
Issue Type: Bug
Affects Versions: Trunk
Reporter: Ulrich Heidfeld
Assignee: Ulrich Heidfeld
I got problems by opening a modal via menu link with two parameters. Only the
first parameter is successfully accessible in modal's screens definition.
Investigation revealed that for a menu link of type 'layered-modal' inline
JS-Code get created with defined action-String. This String is used to set
following context parameters.
The problem is, that parameter concatenating expression '&' is not encoded like
{code:java}
// .../control/uri?param1=1param2=2
{code}
My solution for this problem was to extend MacroMenuRenderer#renderLink by
replacing
{code:java}
{code}
by '&'.
Furthermore, this method shows that submitted parameters, defined between menus
link tags, will be ignored, if link type is 'layered-modal'. So, within
action-String, we have to submit parameters.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11739) Change resource with RESOURCE in all application components
[ https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116593#comment-17116593 ] Jacques Le Roux commented on OFBIZ-11739: - Hi Suraj, Makes sense to me > Change resource with RESOURCE in all application components > --- > > Key: OFBIZ-11739 > URL: https://issues.apache.org/jira/browse/OFBIZ-11739 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > As we have done it for modules, it is better to get this done for all > resource variables as well. > Also, we should make module and resource variables as private instead of > public -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11742) AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask
[ https://issues.apache.org/jira/browse/OFBIZ-11742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Schinzer updated OFBIZ-11742: - Component/s: Gradle Affects Version/s: Trunk Description: in build.gradle (commit [5e1a23d|https://github.com/apache/ofbiz-framework/commit/5e1a23de1c6cc92fa10cd6008e2e758cdf7ffe4f], line #498) the context help states that: @Deprecated class AsciidoctorTask extends AsciidoctorCompatibilityTask This is just a wrapper class in a legacy package. All of the code has moved to AsciidoctorCompatibilityTask. Also, the gradle viewer in my IDE states that the following rows contain syntax errors, yet it builds: attributes \ 'doctype': 'book', 'experimental': '', 'icons': 'font', 'sectnums': '', 'chapter-label': '', 'toc': 'left@', 'toclevels': '3' Environment: IntelliJ IDEA Community Edition Priority: Minor (was: Major) > AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask > -- > > Key: OFBIZ-11742 > URL: https://issues.apache.org/jira/browse/OFBIZ-11742 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk > Environment: IntelliJ IDEA Community Edition >Reporter: Carsten Schinzer >Priority: Minor > > in build.gradle (commit > [5e1a23d|https://github.com/apache/ofbiz-framework/commit/5e1a23de1c6cc92fa10cd6008e2e758cdf7ffe4f], > line #498) the context help states that: > @Deprecated class AsciidoctorTask extends AsciidoctorCompatibilityTask > This is just a wrapper class in a legacy package. All of the code has moved > to AsciidoctorCompatibilityTask. > Also, the gradle viewer in my IDE states that the following rows contain > syntax errors, yet it builds: > attributes \ > 'doctype': 'book', > 'experimental': '', > 'icons': 'font', > 'sectnums': '', > 'chapter-label': '', > 'toc': 'left@', > 'toclevels': '3' -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11742) AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask
Carsten Schinzer created OFBIZ-11742: Summary: AsciidoctorTask is deprecated in favor of AsciidoctorCompatibilityTask Key: OFBIZ-11742 URL: https://issues.apache.org/jira/browse/OFBIZ-11742 Project: OFBiz Issue Type: Bug Reporter: Carsten Schinzer -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11679) OFBiz - Shopify integration plugin
[ https://issues.apache.org/jira/browse/OFBIZ-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116559#comment-17116559 ] Suraj Khurana commented on OFBIZ-11679: --- Thanks everyone for your inputs. I think example of OFBIZ-10365, doesn't fits here, this is an integration and that was completely new process flow being introduced in OFBiz. IMO, regarding data model changes, again as this is an integration so no DM changes, except a new entity for configuration if we agreed upon, otherwise SystemProperty will do the job. Similarly, there is not much business logic involved, specially in integrations, you are simply mapping fields from 3rd party JSON data structure to one with your data model. Apart from these, we already mentioned in description that initially, we are trying to create an MVP and then anyone can pick up API's and start implementing those using that basic framework. We are taking references from existing eBay, Magento integration components. +1 [~arunpati] for Magento integration ([https://issues.apache.org/jira/browse/OFBIZ-6236|https://www.google.com/url?q=https://issues.apache.org/jira/browse/OFBIZ-6236=D=hangouts=1590569964302000=AFQjCNHEFBItSJT6fBbkj2o1_X1l547y1w]), I also believe that if we still could have Magento integration in OFBiz (whatever version) it would be like another feather in the cap. For adopters, we can surely plan to create UM's. I hope that sounds good to everyone. > OFBiz - Shopify integration plugin > -- > > Key: OFBIZ-11679 > URL: https://issues.apache.org/jira/browse/OFBIZ-11679 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Here is the reference of ML discussion: > [https://markmail.org/thread/pktfygbz44a7z5kk] > This integration can be used to provide Order and Fulfillment Management to > the orders placed via Shopify store. > We are taking reference from available Magento plugin and planning to built > the same features as MVP. As an MVP, minimal features to implement are: > – Import locations > – Import products > – Import pending orders > – Create fulfillment on Shopify ie push shipment details and tracking code to > Shopify > After MVP, we will further move with other features like: > – Edit Order > – Order Cancellation > – Returns > Reference Shopify API documents: > [https://shopify.dev/docs/admin-api/rest/reference|https://shopify.dev/docs/admin-api/rest/reference] > We are planning to manage all the configurations in SystemProperty. > Thanks [~surajk] and [~ritesh.kumar] for discussing things. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11679) OFBiz - Shopify integration plugin
[ https://issues.apache.org/jira/browse/OFBIZ-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116555#comment-17116555 ] Pierre Smits commented on OFBIZ-11679: -- [~arunpati], Can you please link to ticket(s) to this OFBIz-Magento integration so that it can be followed-up on? > OFBiz - Shopify integration plugin > -- > > Key: OFBIZ-11679 > URL: https://issues.apache.org/jira/browse/OFBIZ-11679 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Here is the reference of ML discussion: > [https://markmail.org/thread/pktfygbz44a7z5kk] > This integration can be used to provide Order and Fulfillment Management to > the orders placed via Shopify store. > We are taking reference from available Magento plugin and planning to built > the same features as MVP. As an MVP, minimal features to implement are: > – Import locations > – Import products > – Import pending orders > – Create fulfillment on Shopify ie push shipment details and tracking code to > Shopify > After MVP, we will further move with other features like: > – Edit Order > – Order Cancellation > – Returns > Reference Shopify API documents: > [https://shopify.dev/docs/admin-api/rest/reference|https://shopify.dev/docs/admin-api/rest/reference] > We are planning to manage all the configurations in SystemProperty. > Thanks [~surajk] and [~ritesh.kumar] for discussing things. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11679) OFBiz - Shopify integration plugin
[ https://issues.apache.org/jira/browse/OFBIZ-11679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116553#comment-17116553 ] Arun Patidar commented on OFBIZ-11679: -- After reading all the details given in task, It seems that all the efforts are well planned and designed. Also, If we do any third party integration then it always come with defined scope and processes. There are rare chances of any changes in existing tables, plugins always comes with tables specific to it. There can be various way to plan and design a new feature. Not necessary that each feature will go with same strategy. I did similar efforts for OFBiz-Magento integration in which we properly discussed on ML and proceed further after getting approval on some concerns. So IMO, there is no need to do additional effort on design phase as all these details already came from various discussions within ML and team. Apart from this, Can we also plan to push existing OFBIZ-Magento integration as it is so that we can have atleast running integration that can be upgrade in future. > OFBiz - Shopify integration plugin > -- > > Key: OFBIZ-11679 > URL: https://issues.apache.org/jira/browse/OFBIZ-11679 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > Here is the reference of ML discussion: > [https://markmail.org/thread/pktfygbz44a7z5kk] > This integration can be used to provide Order and Fulfillment Management to > the orders placed via Shopify store. > We are taking reference from available Magento plugin and planning to built > the same features as MVP. As an MVP, minimal features to implement are: > – Import locations > – Import products > – Import pending orders > – Create fulfillment on Shopify ie push shipment details and tracking code to > Shopify > After MVP, we will further move with other features like: > – Edit Order > – Order Cancellation > – Returns > Reference Shopify API documents: > [https://shopify.dev/docs/admin-api/rest/reference|https://shopify.dev/docs/admin-api/rest/reference] > We are planning to manage all the configurations in SystemProperty. > Thanks [~surajk] and [~ritesh.kumar] for discussing things. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11739) Change resource with RESOURCE in all application components
[ https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116537#comment-17116537 ] Suraj Khurana commented on OFBIZ-11739: --- [~pierresmits] , Here is the commit reference: ddb8f4273a28b1f465af65907b507ff6535a9d36 HTH !! > Change resource with RESOURCE in all application components > --- > > Key: OFBIZ-11739 > URL: https://issues.apache.org/jira/browse/OFBIZ-11739 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > As we have done it for modules, it is better to get this done for all > resource variables as well. > Also, we should make module and resource variables as private instead of > public -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11739) Change resource with RESOURCE in all application components
[ https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11739: -- Description: As we have done it for modules, it is better to get this done for all resource variables as well. Also, we should make module and resource variables as private instead of public was: As we have done it for modules, it is better to get this done for all resource variables as well. Also, we should make module ans resource variable as private instead of public > Change resource with RESOURCE in all application components > --- > > Key: OFBIZ-11739 > URL: https://issues.apache.org/jira/browse/OFBIZ-11739 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > As we have done it for modules, it is better to get this done for all > resource variables as well. > Also, we should make module and resource variables as private instead of > public -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11739) Change resource with RESOURCE in all application components
[ https://issues.apache.org/jira/browse/OFBIZ-11739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116516#comment-17116516 ] Pierre Smits commented on OFBIZ-11739: -- [~surajk], What a confusing ticket ?As we have done it for modules, it is better to get this done for all resource variables as well?? What? Is there a reference? And why combining with other action items too: # Make module variables private instead of public # Make resource variables private instead of public if these can be combined and commited/merged in one go, that would be a nice to have. But if there are going to appear constraints, then it would be better to keep it split up to get to small achievable goals where everybody can help. > Change resource with RESOURCE in all application components > --- > > Key: OFBIZ-11739 > URL: https://issues.apache.org/jira/browse/OFBIZ-11739 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > > As we have done it for modules, it is better to get this done for all > resource variables as well. > Also, we should make module ans resource variable as private instead of public -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template
[
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-11741:
---
Attachment: OFBIZ-11741.patch
> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered
> within the html head tag, when a new attribute data-import is set to “head”
> e.g.
> {code:xml}
> type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html
> template that is using the library, instead of setting in
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also
> reduce CSP errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template
[
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Yong updated OFBIZ-11741:
---
Attachment: (was: OFBIZ-11741.patch)
> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered
> within the html head tag, when a new attribute data-import is set to “head”
> e.g.
> {code:xml}
> type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html
> template that is using the library, instead of setting in
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also
> reduce CSP errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
