[jira] [Comment Edited] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157885#comment-17157885 ] Jacques Le Roux edited comment on OFBIZ-11882 at 7/15/20, 5:06 AM: --- Hi Alex, What's the rationale behind that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js was (Author: jacques.le.roux): Hi Alex, What's the rationale for that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157885#comment-17157885 ] Jacques Le Roux commented on OFBIZ-11882: - Hi Alex, What's the rationale for that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11882) rename a few map files
[ https://issues.apache.org/jira/browse/OFBIZ-11882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11882: --- Assignee: Jacques Le Roux > rename a few map files > -- > > Key: OFBIZ-11882 > URL: https://issues.apache.org/jira/browse/OFBIZ-11882 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Attachments: ecommerce-js.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > tells a few files to be renamed, to suppress warnings in the browser console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11883) added missing map for minified ol js and css
[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11883: Comment: was deleted (was: Hi Alex, What's the rationale for that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js) > added missing map for minified ol js and css > > > Key: OFBIZ-11883 > URL: https://issues.apache.org/jira/browse/OFBIZ-11883 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Labels: patch-available > Attachments: ol-map.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > added the missing files for the in browser development. > they may be downloaded from the openlayers site. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11883) added missing map for minified ol js and css
[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11883: --- Assignee: Jacques Le Roux > added missing map for minified ol js and css > > > Key: OFBIZ-11883 > URL: https://issues.apache.org/jira/browse/OFBIZ-11883 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Labels: patch-available > Attachments: ol-map.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > added the missing files for the in browser development. > they may be downloaded from the openlayers site. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11881) wrong image name in css. missing map file
[ https://issues.apache.org/jira/browse/OFBIZ-11881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11881: --- Assignee: Jacques Le Roux > wrong image name in css. missing map file > - > > Key: OFBIZ-11881 > URL: https://issues.apache.org/jira/browse/OFBIZ-11881 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Trivial > Labels: patch > Attachments: jquery-plugins.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch conclusive > the missing map file may be downloaded from the plugin site. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11889) fixes for csp-report subsystem
[ https://issues.apache.org/jira/browse/OFBIZ-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-11889: --- Assignee: Jacques Le Roux > fixes for csp-report subsystem > -- > > Key: OFBIZ-11889 > URL: https://issues.apache.org/jira/browse/OFBIZ-11889 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Assignee: Jacques Le Roux >Priority: Major > Attachments: csp-report.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > added report-uri and unsafe-inline support for csp report. > added handling of csp-reports and logging them as errors. > unhandled reports are poluting the browser error console. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11883) added missing map for minified ol js and css
[ https://issues.apache.org/jira/browse/OFBIZ-11883?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157884#comment-17157884 ] Jacques Le Roux commented on OFBIZ-11883: - Hi Alex, What's the rationale for that? We intentionally keep the real names for security reason: to easily update when necessary using retire.js > added missing map for minified ol js and css > > > Key: OFBIZ-11883 > URL: https://issues.apache.org/jira/browse/OFBIZ-11883 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Trivial > Labels: patch-available > Attachments: ol-map.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > added the missing files for the in browser development. > they may be downloaded from the openlayers site. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11889) fixes for csp-report subsystem
[
https://issues.apache.org/jira/browse/OFBIZ-11889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157874#comment-17157874
]
Jacques Le Roux commented on OFBIZ-11889:
-
Hi Alex,
Thanks for your interesting patch.
I understand your POV: a clean log in browser and I much agree with that (it's
awful at the moment). But as I said already I'm against using unsafe-inline for
security reason: https://content-security-policy.com/unsafe-inline/
As explained in this page it would be OK coupled with strict-dynamic. Among the
"major" browsers only IE (not a major browser anymore) is not able to cope with
it. We should not worry about that, IE is non longer supported (only in Windows
< 8) and it's the responsability of users to take care of their own security,
as main browsers and more and more sites warn you and even sometimes don't load.
So if you are up for it, let's go...
About your patch, you certainly did not use trunk HEAD to create it, but your
own modified version (no unsafe-inline in trunk). Please remember to stash,
pull and check before creating your patches or PRs.
Also I believe the best place for {{}} is not in
webtools controller but in common-controller.
> fixes for csp-report subsystem
> --
>
> Key: OFBIZ-11889
> URL: https://issues.apache.org/jira/browse/OFBIZ-11889
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
> Attachments: csp-report.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> added report-uri and unsafe-inline support for csp report.
> added handling of csp-reports and logging them as errors.
> unhandled reports are poluting the browser error console.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-11884) log csp reports for the site pages
[ https://issues.apache.org/jira/browse/OFBIZ-11884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11884. - Resolution: Duplicate > log csp reports for the site pages > -- > > Key: OFBIZ-11884 > URL: https://issues.apache.org/jira/browse/OFBIZ-11884 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: plugin-csp.patch > > > it's a plugin that handles csp reports from the browser, > and logs them as errors. my first java program. > to operate it, the csp header should give /csp/control/report as the > report-url. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11884) log csp reports for the site pages
[ https://issues.apache.org/jira/browse/OFBIZ-11884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-11884: --- > log csp reports for the site pages > -- > > Key: OFBIZ-11884 > URL: https://issues.apache.org/jira/browse/OFBIZ-11884 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: plugin-csp.patch > > > it's a plugin that handles csp reports from the browser, > and logs them as errors. my first java program. > to operate it, the csp header should give /csp/control/report as the > report-url. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157711#comment-17157711 ] Michael Brohl commented on OFBIZ-11885: --- In this case, these issues should not be closed as fixed because they are not fixed here. Improvements are also not "Fixed" but "Implemented". I am closing this issues as a duplicate to the new issue. > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-11885. - Resolution: Duplicate > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-11885: --- > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157705#comment-17157705 ] Alex Bodnaru edited comment on OFBIZ-11885 at 7/14/20, 9:19 PM: hi [~mbrohl] i appologize to have closed the issue on you. i've just understood how to fix it in one patch to the framework, without the plugin. so i've closed these 2 issues, and provided the solution in [OFBIZ-11889|https://issues.apache.org/jira/browse/OFBIZ-11889] with patch. was (Author: alexbodn): hi [~mbrohl] i appologize to have closed the issue on you. i've just understood how to fix it in one patch to the framework, without the plugin. so i've closed these 2 issues, and provided the solution in another issue with patch. > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157705#comment-17157705 ] Alex Bodnaru commented on OFBIZ-11885: -- hi [~mbrohl] i appologize to have closed the issue on you. i've just understood how to fix it in one patch to the framework, without the plugin. so i've closed these 2 issues, and provided the solution in another issue with patch. > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru closed OFBIZ-11885. Resolution: Fixed > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #205: set xmlns to many WEB-INF/web.xml files.
sonarcloud[bot] commented on pull request #205: URL: https://github.com/apache/ofbiz-framework/pull/205#issuecomment-658411351 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=205) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=205=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Reopened] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl reopened OFBIZ-11885: --- Hi [~alexbodn] , I am confused: is this fixed as stated in the issue resolution or is it not? If not and/or this will be done in another Jira, the resolution should be Won't Do, Duplicate or similar fitting selections. > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11884) log csp reports for the site pages
[ https://issues.apache.org/jira/browse/OFBIZ-11884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru updated OFBIZ-11884: - Attachment: (was: plugin-csp.patch) > log csp reports for the site pages > -- > > Key: OFBIZ-11884 > URL: https://issues.apache.org/jira/browse/OFBIZ-11884 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: plugin-csp.patch > > > it's a plugin that handles csp reports from the browser, > and logs them as errors. my first java program. > to operate it, the csp header should give /csp/control/report as the > report-url. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11884) log csp reports for the site pages
[ https://issues.apache.org/jira/browse/OFBIZ-11884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru closed OFBIZ-11884. Resolution: Fixed will be resolved in an unified patch > log csp reports for the site pages > -- > > Key: OFBIZ-11884 > URL: https://issues.apache.org/jira/browse/OFBIZ-11884 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: plugin-csp.patch > > > it's a plugin that handles csp reports from the browser, > and logs them as errors. my first java program. > to operate it, the csp header should give /csp/control/report as the > report-url. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11885) set csp report-uri
[ https://issues.apache.org/jira/browse/OFBIZ-11885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Bodnaru closed OFBIZ-11885. Resolution: Fixed will be resolved in an unified patch > set csp report-uri > -- > > Key: OFBIZ-11885 > URL: https://issues.apache.org/jira/browse/OFBIZ-11885 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: csp-report-uri.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > patch to add the csp report uri, to use the plugin i've provided too. > the report uri is required in the csp report-only setup. > in my opinion, these headers should be set in an external configuration file > or db record. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157612#comment-17157612 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 647e10377b3fcf78e5b51b632cbacdf9af8e71f0 in ofbiz-plugins's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=647e103 ] Documented: ofbiz-framework /framework, migration for SingleSignOn-docbook files to asciidoc (OFBIZ-11587) - SingleSignOn with LDAP: move to plugin LDAP and include in developer-manual in deployment section > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157611#comment-17157611 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 647e10377b3fcf78e5b51b632cbacdf9af8e71f0 in ofbiz-plugins's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=647e103 ] Documented: ofbiz-framework /framework, migration for SingleSignOn-docbook files to asciidoc (OFBIZ-11587) - SingleSignOn with LDAP: move to plugin LDAP and include in developer-manual in deployment section > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157607#comment-17157607 ] ASF subversion and git services commented on OFBIZ-11587: - Commit b0f445b123e0df6dd71786ad945384972c43bd4d in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b0f445b ] Documented: Framework, migration all docbook files to asciidoc (OFBIZ-11587) - common-sending-email: include in email - datafile: move as a include at the end of entity-engine section - entity-engine: list of link to OFBiz wiki about entity configuration - service-engine: a link to OFBiz wiki Service Engine Guide - webtools: help for main screen - mini-lang: include a link to OFBiz wiki mini-lang-reference at the beginning of minilang-to-groovy-manual move minilang-to-groovy-manual to Development environment section - unit-test: include as Junit test, and use README to list gradle command available (so add a tag in REAME.adoc) - base: add a link to OFBiz wiki Configuration Guide, in deployment section - SingleSignOn with LDAP: move to plugin LDAP and include in deployment section developer-manual is updated with some include lines or with directly a sentence. > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157604#comment-17157604 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 5f56177d0276f8ad03cf0aac7ce2f352ec3243c1 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=5f56177 ] Documented: Framework/base migration to asciidoc (OFBIZ-11587) Delete docbook files > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157606#comment-17157606 ] ASF subversion and git services commented on OFBIZ-11587: - Commit b36943d56faadaf650cb7c96c889e68a4dc8ac6b in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b36943d ] Documented: Check all docbook file in each applications-component documents directory (OFBIZ-11587) remove all files > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157608#comment-17157608 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 91fe7bf4cce245268319ca75efe365191e6867f9 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=91fe7bf ] Documented: Framework, delete all docbook files related to migration to asciidoc (OFBIZ-11587) - common-sending-email: include in email - datafile: move as a include at the end of entity-engine section - entity-engine: list of link to OFBiz wiki about entity configuration - service-engine: a link to OFBiz wiki Service Engine Guide - webtools: help for main screen - mini-lang: include a link to OFBiz wiki mini-lang-reference at the beginning of minilang-to-groovy-manual move minilang-to-groovy-manual to Development environment section - unit-test: include as Junit test, and use README to list gradle command available (so add a tag in REAME.adoc) - base: add a link to OFBiz wiki Configuration Guide, in deployment section - SingleSignOn with LDAP: move to plugin LDAP and include in deployment section > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157601#comment-17157601 ] ASF subversion and git services commented on OFBIZ-11587: - Commit f4d01e8610b97e8b905e937a90b98e55f0e97460 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f4d01e8 ] Documented: Workeffort migration to asciidoc (OFBIZ-11587) only one file about portlet-calendar, currently not include in a document > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157600#comment-17157600 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 63daf2511270037b269bccb3dd0c567861e69afb in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=63daf25 ] Documented: migrate help link to asciidoc user manual for Product (OFBIZ-11587) All files have been migrated to asciidoc format and help link now point to the html file generated from the asciidoc files In the global Help Docbook index tree, remove all points about Product & Facility and add a short page with a link to the new help Remove docbook help files for Product & Facility > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157609#comment-17157609 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 9ec3d9ca771dd379af1b8eb942fc36bf329686d7 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=9ec3d9c ] Documented: Framework, delete all docbook files related to migration to asciidoc (OFBIZ-11587) Add a link to developer-manual for webtools in old help system > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157603#comment-17157603 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 2c700e86af00afa3f70e4267fb8ab2d774e231f2 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=2c700e8 ] Documented: Framework/base migration to asciidoc (OFBIZ-11587) only one file about receiving email, so create email.adoc which included receiving and later sending. email.adoc is included in developer-manual.adoc in deployment section > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157605#comment-17157605 ] ASF subversion and git services commented on OFBIZ-11587: - Commit e5d49b26053a8244772b7a1716280f0ceeb46472 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e5d49b2 ] Documented: Check all docbook file in each applications-component documents directory (OFBIZ-11587) theses files have no content except for marketing component (2 sentences, migrated to overview for marketing and sfa) > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11587) Migration all docbook file to asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157602#comment-17157602 ] ASF subversion and git services commented on OFBIZ-11587: - Commit 28e82c217b866ae580dc932c0ebbac9c4c70e827 in ofbiz-framework's branch refs/heads/trunk from Olivier Heintz [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=28e82c2 ] Documented: Workeffort migration to asciidoc (OFBIZ-11587) deleted related docbook file > Migration all docbook file to asciidoc > -- > > Key: OFBIZ-11587 > URL: https://issues.apache.org/jira/browse/OFBIZ-11587 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Olivier Heintz >Priority: Minor > Labels: documentation > Time Spent: 40m > Remaining Estimate: 0h > > Umbrella task, for all components migration tasks. > Idea is to have only one branch/PR for all tasks, with one commit per > component / sub-component migration, it will be more easy to merge it when it > will be finish -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11732) Rendering issue on findorders page
[ https://issues.apache.org/jira/browse/OFBIZ-11732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11732. --- Resolution: Cannot Reproduce Thanks, Arpit, Akash, and Jacques! > Rendering issue on findorders page > -- > > Key: OFBIZ-11732 > URL: https://issues.apache.org/jira/browse/OFBIZ-11732 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Akash Jain >Priority: Major > Attachments: OFBIZ-11732.png, RenderingIssue.png > > > Steps to regenerate: > # Navigate to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders] > # Click on find button > Actual: Rendering issue on pages. Please refer attachment: RenderingIssue.jpg > !RenderingIssue.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11732) Rendering issue on findorders page
[ https://issues.apache.org/jira/browse/OFBIZ-11732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157355#comment-17157355 ] Arpit Mor commented on OFBIZ-11732: --- Yes, since we are unable to regenerate the issue, we can close this ticket > Rendering issue on findorders page > -- > > Key: OFBIZ-11732 > URL: https://issues.apache.org/jira/browse/OFBIZ-11732 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Akash Jain >Priority: Major > Attachments: OFBIZ-11732.png, RenderingIssue.png > > > Steps to regenerate: > # Navigate to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders] > # Click on find button > Actual: Rendering issue on pages. Please refer attachment: RenderingIssue.jpg > !RenderingIssue.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] verma-pawan commented on a change in pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)
verma-pawan commented on a change in pull request #158:
URL: https://github.com/apache/ofbiz-framework/pull/158#discussion_r454323351
##
File path: applications/accounting/groovyScripts/payment/PaymentServices.groovy
##
@@ -134,3 +136,77 @@ def updatePaymentContent() {
}
}
+def createPaymentApplication() {
+// Create a Payment Application
+if (!parameters.invoiceId && !parameters.billingAccountId &&
!parameters.taxAuthGeoId && !parameters.toPaymentId) {
+return error(UtilProperties.getResourceBundleMap("AccountingUiLabels",
locale)?.AccountingPaymentApplicationParameterMissing)
+}
+GenericValue paymentAppl = delegator.makeValue("PaymentApplication")
+paymentAppl.setNonPKFields(parameters)
+
+GenericValue payment = from("Payment").where("paymentId",
parameters.paymentId).queryOne()
+if (!payment) {
+return error(UtilProperties.getResourceBundleMap("AccountingUiLabels",
locale)?.AccountingPaymentApplicationParameterMissing)
+}
+
+BigDecimal notAppliedPayment = PaymentWorker.getPaymentNotApplied(payment)
+
+if (parameters.invoiceId) {
+// get the invoice and do some further validation against it
+GenericValue invoice = from("Invoice").where("invoiceId",
parameters.invoiceId).queryOne()
+// check the currencies if they are compatible
+if (invoice.currencyUomId != payment.currencyUomId &&
invoice.currencyUomId != payment.actualCurrencyUomId) {
+return
error(UtilProperties.getResourceBundleMap("AccountingUiLabels",
locale)?.AccountingCurrenciesOfInvoiceAndPaymentNotCompatible)
+}
+if (invoice.currencyUomId != payment.currencyUomId &&
invoice.currencyUomId == payment.actualCurrencyUomId) {
+// if required get the payment amount in foreign currency (local
we already have)
+Boolean actual = true
+notAppliedPayment = PaymentWorker.getPaymentNotApplied(payment,
actual)
+}
+// get the amount that has not been applied yet for the invoice
(outstanding amount)
+BigDecimal notAppliedInvoice =
InvoiceWorker.getInvoiceNotApplied(invoice)
+if (notAppliedInvoice <= notAppliedPayment) {
+paymentAppl.amountApplied = notAppliedInvoice
+} else {
+paymentAppl.amountApplied = notAppliedPayment
+}
+
+if (invoice.billingAccountId) {
+paymentAppl.billingAccountId = invoice.billingAccountId
+}
+}
+
+if (parameters.toPaymentId) {
+// get the to payment and check the parent types are compatible
+GenericValue toPayment = from("Payment").where("paymentId",
parameters.toPaymentId).queryOne()
+if (toPayment) {
+toPaymentType = from("PaymentType").where("paymentTypeId",
toPayment.paymentTypeId).queryOne()
Review comment:
Hi Priya,
Yes, If a variable is never used we can remove it safely.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11888: --- Assignee: Pawan Verma > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157332#comment-17157332 ] Pawan Verma commented on OFBIZ-11888: - Yes, thanks [~jleroux] , dev discussion would be good, I'll start a thread soon. > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Priority: Major > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)
sonarcloud[bot] commented on pull request #158: URL: https://github.com/apache/ofbiz-framework/pull/158#issuecomment-658150509 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=158=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=158) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=158=new_duplicated_lines_density=list) [6.5% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=158=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157331#comment-17157331 ] Jacques Le Roux commented on OFBIZ-11888: - Hi Pawan, Right, we forgot that with Olivier when we created the new directories structure with trunk, next and stable: https://ci.apache.org/projects/ofbiz/site/ I think we should refer to stable API now, but maybe that is worth a discuss in dev ML, what do you think? > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Priority: Major > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157323#comment-17157323 ] Jacques Le Roux commented on OFBIZ-11887: - Hi Suraj, I was unsure because we have a lot of them and I used to do the same (no space after cast). So I checked, both Oracle ((actually initially Sun) and Google say the same than you Suraj: https://www.oracle.com/technetwork/java/javase/documentation/codeconventions-141388.html https://google.github.io/styleguide/javaguide.html#s4.6-whitespace I then tested the patches and they are OK with me: +1 for commit > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
Pawan Verma created OFBIZ-11888: --- Summary: OFBiz API Reference link does not work for Developers#Documentation and Help Key: OFBIZ-11888 URL: https://issues.apache.org/jira/browse/OFBIZ-11888 Project: OFBiz Issue Type: Bug Components: site Affects Versions: Trunk Reporter: Pawan Verma Steps: # Go to [https://ofbiz.apache.org/developers.html] # Navigate to Documentation and Help section # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Issue Comment Deleted] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11886: Comment: was deleted (was: Commit 33ca531db450d757399ff26a7300546731be0cef in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33ca531 ] Improved: correct formatting of LoginServices This was a WIP related to "Allow single line statements in checkstyle" (OFBIZ-11886) but not really part of it. See OFBIZ-11886-format-LoginServices-checkNewPassword.patch. It may also include changes from "Checkstyle formatting issues: 'typecast' is not followed by whitespace" (OFBIZ-11887) ) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157320#comment-17157320 ] ASF subversion and git services commented on OFBIZ-11887: - Commit 33ca531db450d757399ff26a7300546731be0cef in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33ca531 ] Improved: correct formatting of LoginServices This was a WIP related to "Allow single line statements in checkstyle" (OFBIZ-11886) but not really part of it. See OFBIZ-11886-format-LoginServices-checkNewPassword.patch. It may also include changes from "Checkstyle formatting issues: 'typecast' is not followed by whitespace" (OFBIZ-11887) > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157318#comment-17157318 ] ASF subversion and git services commented on OFBIZ-11886: - Commit 33ca531db450d757399ff26a7300546731be0cef in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33ca531 ] Improved: correct formatting of LoginServices This was a WIP related to "Allow single line statements in checkstyle" (OFBIZ-11886) but not really part of it. See OFBIZ-11886-format-LoginServices-checkNewPassword.patch. It may also include changes from "Checkstyle formatting issues: 'typecast' is not followed by whitespace" (OFBIZ-11887) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157319#comment-17157319 ] ASF subversion and git services commented on OFBIZ-11886: - Commit 33ca531db450d757399ff26a7300546731be0cef in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33ca531 ] Improved: correct formatting of LoginServices This was a WIP related to "Allow single line statements in checkstyle" (OFBIZ-11886) but not really part of it. See OFBIZ-11886-format-LoginServices-checkNewPassword.patch. It may also include changes from "Checkstyle formatting issues: 'typecast' is not followed by whitespace" (OFBIZ-11887) > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11732) Rendering issue on findorders page
[ https://issues.apache.org/jira/browse/OFBIZ-11732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157303#comment-17157303 ] Jacques Le Roux commented on OFBIZ-11732: - If it's OK, I think we can close :) > Rendering issue on findorders page > -- > > Key: OFBIZ-11732 > URL: https://issues.apache.org/jira/browse/OFBIZ-11732 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Akash Jain >Priority: Major > Attachments: OFBIZ-11732.png, RenderingIssue.png > > > Steps to regenerate: > # Navigate to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders] > # Click on find button > Actual: Rendering issue on pages. Please refer attachment: RenderingIssue.jpg > !RenderingIssue.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11732) Rendering issue on findorders page
[ https://issues.apache.org/jira/browse/OFBIZ-11732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157296#comment-17157296 ] Arpit Mor commented on OFBIZ-11732: --- Hi [~akash.jain], [~pawan] I am unable to regenerate the issue. Maybe its fixed under [OFBIZ-11736|https://issues.apache.org/jira/browse/OFBIZ-11736] as suggested by [~pawan] Thanks > Rendering issue on findorders page > -- > > Key: OFBIZ-11732 > URL: https://issues.apache.org/jira/browse/OFBIZ-11732 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Akash Jain >Priority: Major > Attachments: OFBIZ-11732.png, RenderingIssue.png > > > Steps to regenerate: > # Navigate to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders] > # Click on find button > Actual: Rendering issue on pages. Please refer attachment: RenderingIssue.jpg > !RenderingIssue.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11844) Unable to upload additional image for a product
[ https://issues.apache.org/jira/browse/OFBIZ-11844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157291#comment-17157291 ] Arpit Mor commented on OFBIZ-11844: --- Hi [~akash.jain], [~jleroux] I am also unable to regenerate the issue. Maybe it was a temporary issue > Unable to upload additional image for a product > --- > > Key: OFBIZ-11844 > URL: https://issues.apache.org/jira/browse/OFBIZ-11844 > Project: OFBiz > Issue Type: Bug > Components: product/catalog >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Akash Jain >Priority: Minor > Fix For: Upcoming Branch > > Attachments: Image1.png, OFBIZ-11844.png > > > Steps to regenerate: > 1. Navigate to URL: > [https://demo-trunk.ofbiz.apache.org/catalog/control/FindProduct] > 2. Click on find button > 3. Click on any product Id > 4. Click on content tab > 5. Near bottom of page, click on choose file button for additional images > 6. Select image to be uploaded > 7. Click on upload image button > Actual: Following error message is displayed, “The Following Errors Occurred: > Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: > Service invocation error (org.apache.ofbiz.service.GenericServiceException: > Service [addAdditionalViewForProduct] target threw an unexpected exception > (null))”. Please refer attachment: Image1 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-11886: Attachment: OFBIZ-11886-format-LoginServices-checkNewPassword.patch > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157209#comment-17157209 ] Jacques Le Roux commented on OFBIZ-11886: - Hi Suraj, I posted a message on the dev ML in [your "Single line statements - checkstyle" thread|https://markmail.org/message/ahf373lljgkypkxn]. Here is the patch I speak about there: [^OFBIZ-11886-format-LoginServices-checkNewPassword.patch] > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886-format-LoginServices-checkNewPassword.patch, > OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
[ https://issues.apache.org/jira/browse/OFBIZ-11887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11887: -- Attachment: OFBIZ-11887.patch OFBIZ-11887-plugins.patch > Checkstyle formatting issues: 'typecast' is not followed by whitespace. > --- > > Key: OFBIZ-11887 > URL: https://issues.apache.org/jira/browse/OFBIZ-11887 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11887-plugins.patch, OFBIZ-11887.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11887) Checkstyle formatting issues: 'typecast' is not followed by whitespace.
Suraj Khurana created OFBIZ-11887: - Summary: Checkstyle formatting issues: 'typecast' is not followed by whitespace. Key: OFBIZ-11887 URL: https://issues.apache.org/jira/browse/OFBIZ-11887 Project: OFBiz Issue Type: Sub-task Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Suraj Khurana Assignee: Suraj Khurana -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11886) Allow single line statements in checkstyle
[ https://issues.apache.org/jira/browse/OFBIZ-11886?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11886: -- Attachment: OFBIZ-11886.patch > Allow single line statements in checkstyle > -- > > Key: OFBIZ-11886 > URL: https://issues.apache.org/jira/browse/OFBIZ-11886 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11886.patch > > > We need to add this module in checkstyle.xml > > > > After this, single line statements like: > if (Debug.verboseOn()) Debug.logVerbose(...) > Will be considered safe. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] priyasharma1 commented on a change in pull request #158: [Improved] Convert createPaymentApplication service from mini-lang to groovy DSL (OFBIZ-11481)
priyasharma1 commented on a change in pull request #158:
URL: https://github.com/apache/ofbiz-framework/pull/158#discussion_r454121486
##
File path: applications/accounting/groovyScripts/payment/PaymentServices.groovy
##
@@ -134,3 +136,77 @@ def updatePaymentContent() {
}
}
+def createPaymentApplication() {
+// Create a Payment Application
+if (!parameters.invoiceId && !parameters.billingAccountId &&
!parameters.taxAuthGeoId && !parameters.toPaymentId) {
+return error(UtilProperties.getResourceBundleMap("AccountingUiLabels",
locale)?.AccountingPaymentApplicationParameterMissing)
+}
+GenericValue paymentAppl = delegator.makeValue("PaymentApplication")
+paymentAppl.setNonPKFields(parameters)
+
+GenericValue payment = from("Payment").where("paymentId",
parameters.paymentId).queryOne()
+if (!payment) {
+return error(UtilProperties.getResourceBundleMap("AccountingUiLabels",
locale)?.AccountingPaymentApplicationParameterMissing)
+}
+
+BigDecimal notAppliedPayment = PaymentWorker.getPaymentNotApplied(payment)
+
+if (parameters.invoiceId) {
+// get the invoice and do some further validation against it
+GenericValue invoice = from("Invoice").where("invoiceId",
parameters.invoiceId).queryOne()
+// check the currencies if they are compatible
+if (invoice.currencyUomId != payment.currencyUomId &&
invoice.currencyUomId != payment.actualCurrencyUomId) {
+return
error(UtilProperties.getResourceBundleMap("AccountingUiLabels",
locale)?.AccountingCurrenciesOfInvoiceAndPaymentNotCompatible)
+}
+if (invoice.currencyUomId != payment.currencyUomId &&
invoice.currencyUomId == payment.actualCurrencyUomId) {
+// if required get the payment amount in foreign currency (local
we already have)
+Boolean actual = true
+notAppliedPayment = PaymentWorker.getPaymentNotApplied(payment,
actual)
+}
+// get the amount that has not been applied yet for the invoice
(outstanding amount)
+BigDecimal notAppliedInvoice =
InvoiceWorker.getInvoiceNotApplied(invoice)
+if (notAppliedInvoice <= notAppliedPayment) {
+paymentAppl.amountApplied = notAppliedInvoice
+} else {
+paymentAppl.amountApplied = notAppliedPayment
+}
+
+if (invoice.billingAccountId) {
+paymentAppl.billingAccountId = invoice.billingAccountId
+}
+}
+
+if (parameters.toPaymentId) {
+// get the to payment and check the parent types are compatible
+GenericValue toPayment = from("Payment").where("paymentId",
parameters.toPaymentId).queryOne()
+if (toPayment) {
+toPaymentType = from("PaymentType").where("paymentTypeId",
toPayment.paymentTypeId).queryOne()
Review comment:
Thanks, Deepak.
As I was trying to make this improvement, I noticed that there two variables
are never used i.e. paymentType and toPaymentType.
Will it be fine to skip these two entity operations if they are not used?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
