[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167617#comment-17167617
]
Devanshu Vyas commented on OFBIZ-9254:
--
Yes, the last 2 patches which I added in May are pending. I think we should
reopen it and commit them.
Any other improvements or points can be later covered in a new ticket.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
JacquesLeRoux edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665591935 OK, GH is not able to show the zipped WidgetWorker.java.rej.zip file in preview above despite saying it's uploaded :/. Trying here rather... OK same "Error rendering preview" in Preview. Not sure how to see this file, trying a trick with changing extension to txt... Nothing works or I don't understand how it works :/ Maybe because I use an old FF version. Trying with Edge... [WidgetWorker.java.rej.txt](https://github.com/apache/ofbiz-framework/files/4994339/WidgetWorker.java.rej.txt) OK works :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] danwatford edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
danwatford edited a comment on pull request #217:
URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665611006
I'm don't know how to resolve this @JacquesLeRoux .
Before the most recent merge commit a few moments ago I attempted to apply
the patch you linked to against trunk and saw the failures you mentioned. As
far as I can tell they are due to a difference in whitespace in the trunk
compared to the lines expected to be replaced by the patch.
I then tried generated another patch using 'git format-patch trunk --stdout
> OFBIZ-11907.patch', but saw the exact same problem with then applying the new
patch to trunk.
The issue appears to be with the whitespace is this part of the patch:
```
-String tokenValue = CsrfUtil.generateTokenForNonAjax(request,
target);
-if (UtilValidate.isNotEmpty(tokenValue)) {
-String currentString = externalWriter.toString();
-if (currentString.startsWith("
[GitHub] [ofbiz-framework] fehnomenal opened a new pull request #220: Make latitude and longitude numeric fields for correct comparisons
fehnomenal opened a new pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220 Improved: Make the latitude and longitude fields of `GeoPoint` numeric Explanation: Before this commit both are stored as strings in the database and at least PostgreSQL does not correctly compare numeric strings. Tthey will be sorted lexically which was not correct with floats. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665512570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
danwatford commented on pull request #217:
URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665611006
I'm don't know how to resolve this @JacquesLeRoux .
Before the most recent merge commit a few moments ago I attempted to apply
the patch you linked to against trunk and saw the failures you mentioned. As
far as I can tell they are due to a difference in whitespace in the trunk
compared to the lines expected to be replaced by the patch.
I then tried generated another patch using 'git format-patch trunk --stdout
> OFBIZ-11907.patch', but saw the exact same problem with then applying the new
patch to trunk.
The issue appears to be with the whitespace is this part of the patch:
-String tokenValue = CsrfUtil.generateTokenForNonAjax(request,
target);
-if (UtilValidate.isNotEmpty(tokenValue)) {
-String currentString = externalWriter.toString();
-if (currentString.startsWith("
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665190079 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons
sonarcloud[bot] commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-665603293 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=220=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=220) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=220=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=220=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665608381 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167308#comment-17167308
]
Pawan Verma edited comment on OFBIZ-9254 at 7/29/20, 3:12 PM:
--
Hi [~jleroux] [~devanshu.vyas]
I think we missed to commit the latest patch that incorporates changes related
to this ticket i.e. [^OFBIZ-9254_plugins.patch] [^OFBIZ-9254.patch]
Shouldn't we reopen and handle this?
was (Author: pawan.verma):
Hi [~jleroux] [~devanshu.vyas]
I think we missed to commit the latest patch that corporates changes related to
this ticket i.e. [^OFBIZ-9254_plugins.patch] [^OFBIZ-9254.patch]
Shouldn't we reopen and handle this?
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167308#comment-17167308
]
Pawan Verma commented on OFBIZ-9254:
Hi [~jleroux] [~devanshu.vyas]
I think we missed to commit the latest patch that corporates changes related to
this ticket i.e. [^OFBIZ-9254_plugins.patch] [^OFBIZ-9254.patch]
Shouldn't we reopen and handle this?
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro
[ https://issues.apache.org/jira/browse/OFBIZ-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167282#comment-17167282 ] Suraj Khurana commented on OFBIZ-11184: --- Hello Priya, Thanks for the findings, as per comments on OfbizCurrencyTransform, currently it is default to 10. // check the rounding -- DEFAULT is 10 to not round for display, only use this when necessary. Also, It can easily be applied globally, you can change this property in 'number' resource (number.properties), i.e. currency.rounding.default and set it to 2. HTH. > No option for passing rounding mode to the ofbizCurrency Macro > --- > > Key: OFBIZ-11184 > URL: https://issues.apache.org/jira/browse/OFBIZ-11184 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 16.11 >Reporter: Murugeswari >Priority: Minor > Attachments: Capture.PNG > > > No option to pass roundingMode to the Ofbiz Currency macro. > Please refer attached screenshot, there is difference in line item total and > header total. > Is there any way, to match line item total and header total with 2 decimal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167235#comment-17167235 ] Priya Sharma commented on OFBIZ-10791: -- Thanks for the review Pawan. Yes, that was a good suggestion, updated the patch. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Priya Sharma >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10791: - Attachment: OFBIZ-10791.patch > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Priya Sharma >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167180#comment-17167180
]
Pawan Verma commented on OFBIZ-10791:
-
Hi [~priya.sharma.9362]
The solution makes sense to me. Just one suggestion shouldn't we use a
condition like:
if (quantity.compareTo(BigDecimal.ZERO) > 0) {
Does this make sense to you?
> Unable to add product (of ASSET_USAGE type) in order
>
>
> Key: OFBIZ-10791
> URL: https://issues.apache.org/jira/browse/OFBIZ-10791
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Praveen Sharma
>Assignee: Priya Sharma
>Priority: Major
> Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL,
> SALES_RENTAL
> Attachments: OFBIZ-10791.patch, Screenshot from 2019-03-09
> 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot from
> 2019-03-09 11-06-36.png, asset-addtocart.png
>
>
> Steps to regenerate:
> # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
> # Click on order entry
> # Set customer and click on continue
> # Click continue on Enter Order Currency, Agreements, and Ship Dates page
> (Please refer attachment: 2-Continue)
> # Try to add product from Quick Lookup.
> Actual: Unable to add product for order.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11877: -- Assignee: (was: Akash Jain) > Convert testCreateAndUpdateContactList test from XML to Groovy > -- > > Key: OFBIZ-11877 > URL: https://issues.apache.org/jira/browse/OFBIZ-11877 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Akash Jain >Priority: Minor > > Convert testCreateAndUpdateContactList test from XML to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11876) Convert tests (available in WorkEffortSimpleServices.xml) from xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11876: -- Assignee: (was: Akash Jain) > Convert tests (available in WorkEffortSimpleServices.xml) from xml to Groovy > > > Key: OFBIZ-11876 > URL: https://issues.apache.org/jira/browse/OFBIZ-11876 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: Trunk >Reporter: Akash Jain >Priority: Minor > > Convert following tests (available in WorkEffortSimpleServices.xml) from xml > to groovy: > -- testCreateEventService > -- testUpdateEventService > -- testCreateProjectService > -- testUpdateProjectService > -- testCreateWorkEffortNoteService -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11867) Convert ShoppingCartTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11867: -- Assignee: (was: Akash Jain) > Convert ShoppingCartTests.xml to Groovy > --- > > Key: OFBIZ-11867 > URL: https://issues.apache.org/jira/browse/OFBIZ-11867 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Priority: Minor > Attachments: OFBIZ-11867.patch > > > Convert ShoppingCartTests XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11869) Convert ProductionRunTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11869: -- Assignee: (was: Akash Jain) > Convert ProductionRunTests.xml to Groovy > > > Key: OFBIZ-11869 > URL: https://issues.apache.org/jira/browse/OFBIZ-11869 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Akash Jain >Priority: Minor > > Convert ProductionRunTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11875) Convert WorkEffortTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11875: -- Assignee: (was: Akash Jain) > Convert WorkEffortTests.xml to Groovy > - > > Key: OFBIZ-11875 > URL: https://issues.apache.org/jira/browse/OFBIZ-11875 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Affects Versions: Trunk >Reporter: Akash Jain >Priority: Minor > > Convert WorkEffortTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11861) Convert ShoppingListTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11861: -- Assignee: (was: Akash Jain) > Convert ShoppingListTests.xml to Groovy > --- > > Key: OFBIZ-11861 > URL: https://issues.apache.org/jira/browse/OFBIZ-11861 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Priority: Minor > > Convert ShoppingListTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11184) No option for passing rounding mode to the ofbizCurrency Macro
[ https://issues.apache.org/jira/browse/OFBIZ-11184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167147#comment-17167147 ] Priya Sharma commented on OFBIZ-11184: -- Hi Murugeswari/All We do have support for rounding in OfbizCurrency Macro but has not been used so far. I am adding an example for your reference, more detail can be found in OfbizCurrencyTransform.java: <@ofbizCurrency amount=12.123456123450 isoCode=USD rounding=2/> We can use it to resolve these inconsistencies. What are the community's views? > No option for passing rounding mode to the ofbizCurrency Macro > --- > > Key: OFBIZ-11184 > URL: https://issues.apache.org/jira/browse/OFBIZ-11184 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Release Branch 16.11 >Reporter: Murugeswari >Priority: Minor > Attachments: Capture.PNG > > > No option to pass roundingMode to the Ofbiz Currency macro. > Please refer attached screenshot, there is difference in line item total and > header total. > Is there any way, to match line item total and header total with 2 decimal. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11860) Convert CustRequestTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-11860: -- Assignee: (was: Akash Jain) > Convert CustRequestTests.xml to Groovy > -- > > Key: OFBIZ-11860 > URL: https://issues.apache.org/jira/browse/OFBIZ-11860 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Priority: Minor > > Convert CustRequestTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-7107) RMA should be able to reject the items in the return before accepting the return
[ https://issues.apache.org/jira/browse/OFBIZ-7107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Akash Jain reassigned OFBIZ-7107: - Assignee: (was: Akash Jain) > RMA should be able to reject the items in the return before accepting the > return > - > > Key: OFBIZ-7107 > URL: https://issues.apache.org/jira/browse/OFBIZ-7107 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Anuj Jain >Priority: Major > > In the current system, RMA doesn't have any options to reject return items > before changing the status of the return to accepted. > RMA should have an ability to change the status of return items to rejected > before accepting any return, as there can be a scenario where RMA don't want > to accept the items and want to mark those items as rejected in the system. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167077#comment-17167077 ] Priya Sharma commented on OFBIZ-10111: -- Hello All, I have attached a quick-fix patch of the duplicate banner issue. (Since the banner is somehow printed twice due to nesting forms, which needs some deeper analysis) I also have a few suggestions - 1) We already have two menus to either add a new workEffort as a child or an existing. !child.png! We also have this option on the form that is supposed to add a new work effort child !child-2.png! I suggest eliminating the second menu and use single for both. 2) The form also makes it mandatory to enter the name, which makes no sense if we are adding "workEffortIdTo". Since it is an optional field it should not be required. Please correct me if I misunderstood the flow. Looking forward for your views.. > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, OFBIZ-10111.patch, child-2.png, > child.png, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11910) product summary cards don't have uniform height
[ https://issues.apache.org/jira/browse/OFBIZ-11910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167060#comment-17167060 ] Jacques Le Roux commented on OFBIZ-11910: - Thanks Alex, Good point, in the past we had few related discussions about duplicated urls ([like this comment from Paul|https://issues.apache.org/jira/browse/OFBIZ-11229?focusedCommentId=17050707=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17050707]), but not about migration from ecommerce to ecomseo. BTW, for the sake of history ecomseo was put in with OFBIZ-5312 (a long one full of comments...) > product summary cards don't have uniform height > --- > > Key: OFBIZ-11910 > URL: https://issues.apache.org/jira/browse/OFBIZ-11910 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 17.12, Trunk >Reporter: Alex Bodnaru >Priority: Major > Attachments: Screen Shot changed 1936.png, Screen Shot changed.png, > Screen Shot original.png, Screen Shot trunk 1936.png, Screen Shot trunk.png > > > while several product summaries are in the same row, especially products with > different statuses and properties, they are terribly unalligned. > i did attach classes to the various elements, most of them static but few of > them calculated, so it's stylable in custom.css. > a css artist will highly outperform my css capabilities, but even my idea > gives a sensibly uniform result. > my diff is a little intermingled, but i would be glad to explain everything. > thanks in advance, > alex -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template
[
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11741:
Fix Version/s: Upcoming Branch
Affects Version/s: (was: Upcoming Branch)
Trunk
> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch, Trunk
>
> Attachments: HtmlWidget.java.rej, OFBIZ-11741.patch,
> OFBIZ-11741.patch, OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered
> within the html head tag, when a new attribute data-import is set to “head”
> e.g.
> {code:xml}
> type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html
> template that is using the library, instead of setting in
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also
> reduce CSP errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11741) Headerize external script in multi-block html template
[
https://issues.apache.org/jira/browse/OFBIZ-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-11741:
Fix Version/s: (was: Trunk)
> Headerize external script in multi-block html template
> --
>
> Key: OFBIZ-11741
> URL: https://issues.apache.org/jira/browse/OFBIZ-11741
> Project: OFBiz
> Issue Type: New Feature
> Components: framework
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: HtmlWidget.java.rej, OFBIZ-11741.patch,
> OFBIZ-11741.patch, OFBIZ-11741.patch
>
>
> Allow external scripts within the multi-block html template, to be rendered
> within the html head tag, when a new attribute data-import is set to “head”
> e.g.
> {code:xml}
> type="application/javascript" data-import="head">
> {code}
> With the new feature we can define external scripts in the multi-block html
> template that is using the library, instead of setting in
> layoutSetting.javaScripts.
> This new feature helps with dependency management of Javascript and also
> reduce CSP errors.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10111: - Attachment: child.png > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, OFBIZ-10111.patch, child.png, > screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10575) Move 'SecurityPermission' data to seed data files
[ https://issues.apache.org/jira/browse/OFBIZ-10575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma reassigned OFBIZ-10575: Assignee: Priya Sharma (was: Deepak Nigam) > Move 'SecurityPermission' data to seed data files > - > > Key: OFBIZ-10575 > URL: https://issues.apache.org/jira/browse/OFBIZ-10575 > Project: OFBiz > Issue Type: Improvement > Components: humanres, securityext >Affects Versions: Trunk >Reporter: Deepak Nigam >Assignee: Priya Sharma >Priority: Minor > > HumanresDemoData.xml file contains the following data: > permissionId="EMPLOYEE_VIEW"/> > SecurityGroupDemoData.xml file contains the following data: > > > Above mentioned data is seed data, so we should remove it from demo data > files and move it to seed data files. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665155521 Hi Daniel, Sorry again, "This branch has conflicts that must be resolved" as reports GH. I guess it will be easier to fix for you. TIA :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10111: - Attachment: child-2.png > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, OFBIZ-10111.patch, child-2.png, > child.png, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10111) The child event added is not listed in the Child Work Efforts. While if we add an existing event it is listed in the WorkEffort component
[ https://issues.apache.org/jira/browse/OFBIZ-10111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Priya Sharma updated OFBIZ-10111: - Attachment: OFBIZ-10111.patch > The child event added is not listed in the Child Work Efforts. While if we > add an existing event it is listed in the WorkEffort component > - > > Key: OFBIZ-10111 > URL: https://issues.apache.org/jira/browse/OFBIZ-10111 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Reporter: Rubia Elza Joshep >Assignee: Priya Sharma >Priority: Major > Attachments: OFBIZ-10111.patch, OFBIZ-10111.patch, screenshot-1.png > > > Steps to regenerate: > 1) Open URL [https://demo-trunk.ofbiz.apache.org/sfa/control/Events] > 2) Click on the event created. > 3) To create the child events, click on the "Children" button. > 4) Click on "Add New WorkEffort Child" button. Create a new child event. Fill > in the details of the child events. Click on the Save button. > Actual: The child event added is not listed in the Child Work Efforts. While > if we add an existing event it is listed. > 5) Open URL > [https://demo-trunk.ofbiz.apache.org/workeffort/control/AddWorkEffortAndAssoc?workEffortIdFrom=10001] > 6) "Enter an existing workEffortId below, OR enter the WorkEffort Details > below" label is repeated twice. > Note: ScreenShot Attached. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-663977154 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665190079 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=VULNERABILITY) (and [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/issue s?id=apache_ofbiz-framework=217=false=SECURITY_HOTSPOT) to review) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=217=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)
danwatford commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665192736 All fixed @JacquesLeRoux This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11928: Description: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 2) Now change explode item to Y 3) Again create same order with same products and same quantity 4) Notice difference in item subtotal and grand total I see two issues here: - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order) Code reference: It should be handled inside ShoppingCartItem.java#explodeItem - Total sales tax is different in both orders: 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items. Demo orders on trunk (will not last for long): explode: N [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 ]explode: Y [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] was: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 2) Now change explode item to Y 3) Again create same order with same products and same quantity 4) Notice difference in item subtotal and grand total I see two issues here: - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order)Code reference: It should be handled inside explodeItem method of ShoppingCartItem.java - Total sales tax is different in both orders: 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items. Demo orders on trunk (will not last for long): explode: N [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001] explode: Y [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Priority: Major > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order) > Code reference: It should be handled inside ShoppingCartItem.java#explodeItem > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 > ]explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Suraj Khurana updated OFBIZ-11928: -- Description: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 2) Now change explode item to Y 3) Again create same order with same products and same quantity 4) Notice difference in item subtotal and grand total I see two issues here: - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order)Code reference: It should be handled inside explodeItem method of ShoppingCartItem.java - Total sales tax is different in both orders: 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items. Demo orders on trunk (will not last for long): explode: N [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001] explode: Y [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] was: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 2) Now change explode item to Y 3) Again create same order with same products and same quantity 4) Notice difference in item subtotal and grand total I see two issues here: - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order) Code reference: It should be handled inside [explodei...@shoppingcartitem.java|mailto:explodei...@shoppingcartitem.java] - Total sales tax is different in both orders: 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items. Demo orders on trunk (will not last for long): explode: N [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 ]explode: Y [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Priority: Major > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order)Code reference: It should be > handled inside explodeItem method of ShoppingCartItem.java > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001] > explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11928) Explode items not handling tax and adjustments properly
Suraj Khurana created OFBIZ-11928: - Summary: Explode items not handling tax and adjustments properly Key: OFBIZ-11928 URL: https://issues.apache.org/jira/browse/OFBIZ-11928 Project: OFBiz Issue Type: Bug Components: order Affects Versions: Trunk, Release Branch 18.12, Release Branch 17.12 Reporter: Suraj Khurana Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 2) Now change explode item to Y 3) Again create same order with same products and same quantity 4) Notice difference in item subtotal and grand total I see two issues here: - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order) Code reference: It should be handled inside [explodei...@shoppingcartitem.java|mailto:explodei...@shoppingcartitem.java] - Total sales tax is different in both orders: 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items. Demo orders on trunk (will not last for long): explode: N [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 ]explode: Y [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
