[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196265#comment-17196265 ] Jacques Le Roux commented on OFBIZ-10303: - bq. + at the end of line are same as thanks > Add a

[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196264#comment-17196264 ] Jacques Le Roux commented on OFBIZ-11036: - Thanks, I think I'll continue as I do now :) > User

[jira] [Commented] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196262#comment-17196262 ] Jacques Le Roux commented on OFBIZ-10251: - I see no problems with that. > Move Human Resources

[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196197#comment-17196197 ] ASF subversion and git services commented on OFBIZ-11995: - Commit

[jira] [Commented] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Olivier Heintz (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196181#comment-17196181 ] Olivier Heintz commented on OFBIZ-10251: Thank you very mush for the review, You are right,

[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Olivier Heintz (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196175#comment-17196175 ] Olivier Heintz commented on OFBIZ-11036: to apply patch generated by git format-patch, you have

[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Olivier Heintz (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: (was:

[jira] [Updated] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Olivier Heintz (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-10303: --- Attachment: OFBIZ-10303_Documented-Add-a-Global-Glossary-for-user-documentat.patch > Add a

[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Olivier Heintz (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196165#comment-17196165 ] Olivier Heintz commented on OFBIZ-10303: Thanks you very much for the review, I have made some

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196146#comment-17196146 ] ASF subversion and git services commented on OFBIZ-11926: - Commit

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196147#comment-17196147 ] ASF subversion and git services commented on OFBIZ-11926: - Commit

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196149#comment-17196149 ] ASF subversion and git services commented on OFBIZ-11926: - Commit

[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196101#comment-17196101 ] ASF subversion and git services commented on OFBIZ-11995: - Commit

[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196070#comment-17196070 ] ASF subversion and git services commented on OFBIZ-11995: - Commit

[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.

2020-09-15 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196035#comment-17196035 ] ASF subversion and git services commented on OFBIZ-11995: - Commit

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #43: Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995)

2020-09-15 Thread GitBox
sonarcloud[bot] commented on pull request #43: URL: https://github.com/apache/ofbiz-plugins/pull/43#issuecomment-692620920 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=43=false=BUG)

[GitHub] [ofbiz-plugins] girishvasmatkar closed pull request #43: Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995)

2020-09-15 Thread GitBox
girishvasmatkar closed pull request #43: URL: https://github.com/apache/ofbiz-plugins/pull/43 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] girishvasmatkar opened a new pull request #43: Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995)

2020-09-15 Thread GitBox
girishvasmatkar opened a new pull request #43: URL: https://github.com/apache/ofbiz-plugins/pull/43 Fixed: javadoc generation error fixed. Dereferenced 'Service' link (OFBIZ-11995) This is an automated message from the

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #42: WIP: Model classes added corresponding to REST XML schema

2020-09-15 Thread GitBox
sonarcloud[bot] commented on pull request #42: URL: https://github.com/apache/ofbiz-plugins/pull/42#issuecomment-692544188 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=42=false=BUG)

[GitHub] [ofbiz-plugins] girishvasmatkar merged pull request #42: WIP: Model classes added corresponding to REST XML schema

2020-09-15 Thread GitBox
girishvasmatkar merged pull request #42: URL: https://github.com/apache/ofbiz-plugins/pull/42 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] girishvasmatkar opened a new pull request #42: WIP: Model classes added corresponding to REST XML schema

2020-09-15 Thread GitBox
girishvasmatkar opened a new pull request #42: URL: https://github.com/apache/ofbiz-plugins/pull/42 Implemented: Added Model classes for the corresponding XML schema (OFBIZ-11995) Explanation First in a series of commits. This commit adds Model classes corresponding to the

[jira] [Commented] (OFBIZ-11039) add a chapter "About this documentation"

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195931#comment-17195931 ] Jacques Le Roux commented on OFBIZ-11039: - I have cursorily reviewed and applied the patch. I

[jira] [Commented] (OFBIZ-11027) HR Doc, Associated a scenario UI test for each process

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195932#comment-17195932 ] Jacques Le Roux commented on OFBIZ-11027: - I have cursorily reviewed and applied the patch. I

[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195930#comment-17195930 ] Jacques Le Roux commented on OFBIZ-11036: - I have cursorily reviewed and applied the patch. I

[jira] [Commented] (OFBIZ-11026) HR Doc drive by process

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195929#comment-17195929 ] Jacques Le Roux commented on OFBIZ-11026: - I have cursorily reviewed and applied the patch. I

[jira] [Commented] (OFBIZ-11026) HR Doc drive by process

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195928#comment-17195928 ] Jacques Le Roux commented on OFBIZ-11026: - Olivier, the link in the description don't work, I

[jira] [Comment Edited] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195919#comment-17195919 ] Jacques Le Roux edited comment on OFBIZ-10251 at 9/15/20, 7:11 AM: --- Hi

[jira] [Comment Edited] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195919#comment-17195919 ] Jacques Le Roux edited comment on OFBIZ-10251 at 9/15/20, 7:10 AM: --- Hi

[jira] [Commented] (OFBIZ-11036) User Manual : change the level of from 2 to 1

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195920#comment-17195920 ] Jacques Le Roux commented on OFBIZ-11036: - Hi Olivier, You said bq. (apply it with git am) I'm

[jira] [Commented] (OFBIZ-10251) Move Human Resources Guide into OFBiz Asciidoc Framework

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195919#comment-17195919 ] Jacques Le Roux commented on OFBIZ-10251: - Hi Olivier, I'm currently reviewing subtasks here. I

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread Suraj Khurana (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195909#comment-17195909 ] Suraj Khurana commented on OFBIZ-11926: --- Yes, +1 to have this for all "do nothing" kind of code

[jira] [Commented] (OFBIZ-11926) Checkstyle: Variable name must match pattern

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195905#comment-17195905 ] Jacques Le Roux commented on OFBIZ-11926: - Hi Suraj, Since we have only 10 of them and it's not

[jira] [Commented] (OFBIZ-10303) Add a Global Glossary for Documentation Guides

2020-09-15 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195893#comment-17195893 ] Jacques Le Roux commented on OFBIZ-10303: - Hi Olivier, I very like it (did not apply just