[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205965#comment-17205965
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit 9b92939318fc29f19915844953978e4c4e4d994f in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=9b92939 ]

Improved: Changed display name for OFBiz Rest APIs on swagger(OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205964#comment-17205964
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit 9b92939318fc29f19915844953978e4c4e4d994f in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=9b92939 ]

Improved: Changed display name for OFBiz Rest APIs on swagger(OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205825#comment-17205825
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit 6c9c0d6e3615ebc64c96a0a472afbabe7eeafd9e in ofbiz-plugins's branch 
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=6c9c0d6 ]

Fixed: Javadoc issues (OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205691#comment-17205691
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit e30634fba1b776219b9cc5674b15bf4d1b44fa53 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e30634f ]

Implemented: Exception Mapper for GenericServiceException.
> Improved: Cleaned up code for exception handling and moved the code to 
> ErrorUtil. Still some improvements needed. (OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205690#comment-17205690
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit e30634fba1b776219b9cc5674b15bf4d1b44fa53 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e30634f ]

Implemented: Exception Mapper for GenericServiceException.
> Improved: Cleaned up code for exception handling and moved the code to 
> ErrorUtil. Still some improvements needed. (OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205688#comment-17205688
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit e30634fba1b776219b9cc5674b15bf4d1b44fa53 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e30634f ]

Implemented: Exception Mapper for GenericServiceException.
> Improved: Cleaned up code for exception handling and moved the code to 
> ErrorUtil. Still some improvements needed. (OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205686#comment-17205686
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit e30634fba1b776219b9cc5674b15bf4d1b44fa53 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e30634f ]

Implemented: Exception Mapper for GenericServiceException.
> Improved: Cleaned up code for exception handling and moved the code to 
> ErrorUtil. Still some improvements needed. (OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11328) Add JAX-RS capabilities (Jersey)

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205685#comment-17205685
 ] 

ASF subversion and git services commented on OFBIZ-11328:
-

Commit e30634fba1b776219b9cc5674b15bf4d1b44fa53 in ofbiz-plugins's branch 
refs/heads/trunk from Girish Vasmatkar
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e30634f ]

Implemented: Exception Mapper for GenericServiceException.
> Improved: Cleaned up code for exception handling and moved the code to 
> ErrorUtil. Still some improvements needed. (OFBIZ-11328)


> Add JAX-RS capabilities (Jersey) 
> -
>
> Key: OFBIZ-11328
> URL: https://issues.apache.org/jira/browse/OFBIZ-11328
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
> Attachments: image-2020-01-29-19-24-52-312.png
>
>
> Add a new Jersey component leveraging JAX-RS. Also add capability to generate 
> swagger documentation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11976) svg files not removed on clean

2020-10-01 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205665#comment-17205665
 ] 

Jacques Le Roux commented on OFBIZ-11976:
-

I just tested {{g generateAllPluginsDocumentation}} and no OFBiz-Logo.svg files 
remains after. However the same is no true for {{g generateOFBizDocumentation}}

> svg files not removed on clean
> --
>
> Key: OFBIZ-11976
> URL: https://issues.apache.org/jira/browse/OFBIZ-11976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL PLUGINS
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.01, 17.12.05
>
>
> files like birt/src/docs/asciidoc/images/OFBiz-Logo.svg,
> in many plugins, don't get removed on clean.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11893) Error messages when generating HTML and PDF file from AsciiDoc files

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205562#comment-17205562
 ] 

ASF subversion and git services commented on OFBIZ-11893:
-

Commit f2f43bc8d146fbbb3470e7b204494df59abe3a54 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f2f43bc ]

Improved: solve Error messages when generating HTML and PDF file from
AsciiDoc files (OFBIZ-11893)

* Add allow-uri-read when generated html and pdf to be able to allow
image from external uri, it's used for apache2.0 image;
Generalize usage of apache2.0 image for all main documents
* Put Trunk Version in gradle generation parameter and so remove in all
documents (to avoid Version unspecified)


> Error messages when generating HTML and PDF file from AsciiDoc files
> 
>
> Key: OFBIZ-11893
> URL: https://issues.apache.org/jira/browse/OFBIZ-11893
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> {noformat}
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> juil. 10, 2020 2:24:54 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:24:57 PM
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:26:01 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> juil. 10, 2020 2:26:19 PM 
> uri:classloader:/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb 
> convert_inline_icon
> {noformat}
> There are also warnings and infos:
> {noformat}
> AVERTISSEMENT: sy-CSRF-defense.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-CSRF-defense.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs
> /asciidoc/_include/sy-CSRF-defense.adoc:31
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:31
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 36: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:36
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 53: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, 

[jira] [Commented] (OFBIZ-11893) Error messages when generating HTML and PDF file from AsciiDoc files

2020-10-01 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205563#comment-17205563
 ] 

ASF subversion and git services commented on OFBIZ-11893:
-

Commit ee20e6c715e0301eb29b90ca5a0231b3fcc18816 in ofbiz-framework's branch 
refs/heads/trunk from Olivier Heintz
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ee20e6c ]

Improved: solve Error messages when generating HTML and PDF file from
AsciiDoc files (OFBIZ-11893)

Add the correct set when use icon, to avoid INFO message

> Error messages when generating HTML and PDF file from AsciiDoc files
> 
>
> Key: OFBIZ-11893
> URL: https://issues.apache.org/jira/browse/OFBIZ-11893
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Minor
>
> {noformat}
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> juil. 10, 2020 2:24:54 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:24:57 PM
> ERROR: hr-employments.adoc: line 58: invalid part, must have at least one 
> section (e.g., chapter, appendix, etc.)
> invalid part, must have at least one section (e.g., chapter, appendix, etc.) 
> :: hr-employments.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/humanres/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/applications/hu
> manres/src/docs/asciidoc/_include/hr-employments.adoc:58
> include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
>  :: manufacturing_NL.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/C:
> /projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/manufacturing_NL.adoc:29
> juil. 10, 2020 2:26:01 PM
> ERROR: manufacturing_NL.adoc: line 29: include file not found: 
> C:/projectsASF/Git/ofbiz-framework/applications/manufacturing/src/docs/asciidoc/_include/hr-intro.adoc
> juil. 10, 2020 2:26:19 PM 
> uri:classloader:/gems/asciidoctor-pdf-1.5.3/lib/asciidoctor/pdf/converter.rb 
> convert_inline_icon
> {noformat}
> There are also warnings and infos:
> {noformat}
> AVERTISSEMENT: sy-CSRF-defense.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-CSRF-defense.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs
> /asciidoc/_include/sy-CSRF-defense.adoc:31
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:31
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 31: section title out of sequence: 
> expected levels 0 or 1, got level 2
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 36: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:36
> juil. 10, 2020 2:24:57 PM
> AVERTISSEMENT: sy-impersonation.adoc: line 53: section title out of sequence: 
> expected levels 0 or 1, got level 2
> section title out of sequence: expected levels 0 or 1, got level 2 :: 
> sy-impersonation.adoc :: 
> C:/projectsASF/Git/ofbiz-framework/framework/security/src/docs/asciidoc/_include/C:/projectsASF/Git/ofbiz-framework/framework/security/src/doc
> s/asciidoc/_include/sy-impersonation.adoc:53
> 

[jira] [Comment Edited] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205534#comment-17205534
 ] 

Olivier Heintz edited comment on OFBIZ-12035 at 10/1/20, 1:55 PM:
--

Two patch generated by git format-patch, one for ofbiz-framework and one for 
ofbiz-plugins

To apply it use git am \{patchName} in each environment

 [^framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch]

^[^plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch]^


was (Author: holivier):
Two patch generated by git format-patch, one for ofbiz-framework and one for 
ofbiz-plugins

To apply it use git am \{patchName} in each environment

[^0001-Improved-change-asciidoc-Image-directory-convention-.patch] 
[^framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch]

^[^plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch]^

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz reassigned OFBIZ-12035:
--

Assignee: (was: Olivier Heintz)

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205534#comment-17205534
 ] 

Olivier Heintz commented on OFBIZ-12035:


Two patch generated by git format-patch, one for ofbiz-framework and one for 
ofbiz-plugins

To apply it use git am \{patchName} in each environment

[^0001-Improved-change-asciidoc-Image-directory-convention-.patch] 
[^framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch]

^[^plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch]^

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> 0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-12035:
---
Attachment: 
plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-12035:
---
Attachment: (was: 
0001-Improved-change-asciidoc-Image-directory-convention-.patch)

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> plugins_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-12035:
---
Attachment: 
framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> 0001-Improved-change-asciidoc-Image-directory-convention-.patch, 
> framework_0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Heintz updated OFBIZ-12035:
---
Attachment: 0001-Improved-change-asciidoc-Image-directory-convention-.patch

> asciidoc Image directory convention for plugins and components
> --
>
> Key: OFBIZ-12035
> URL: https://issues.apache.org/jira/browse/OFBIZ-12035
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Olivier Heintz
>Priority: Major
>  Labels: Documentation
> Attachments: 
> 0001-Improved-change-asciidoc-Image-directory-convention-.patch
>
>
> Plugins documentation (in asciidoc) can be generated with one document per 
> plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
> directory) or include in the general 
> [user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
>  or 
> [developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]
> Currently, image usage not works in the two case, because image path is 
> relative to the root document.
> To solve the problem, I propose to put image(s) relative to a component in 
> the src/docs/asciidoc/images/${component.name} of the component and modifying 
> gradle generateDocumentation task to copy the subdirectory in the general 
> docs/asciidoc/images/ directory before generation and remove it after.
> Currently only birt is concern but it's better to have schema and other image 
> in documentation, so in future all components should be concerned.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12035) asciidoc Image directory convention for plugins and components

2020-10-01 Thread Olivier Heintz (Jira)
Olivier Heintz created OFBIZ-12035:
--

 Summary: asciidoc Image directory convention for plugins and 
components
 Key: OFBIZ-12035
 URL: https://issues.apache.org/jira/browse/OFBIZ-12035
 Project: OFBiz
  Issue Type: Improvement
  Components: birt
Affects Versions: Trunk
Reporter: Olivier Heintz
Assignee: Olivier Heintz


Plugins documentation (in asciidoc) can be generated with one document per 
plugins (in [https://ci.apache.org/projects/ofbiz/site/trunk/pluginsdoc/] 
directory) or include in the general 
[user-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/user-manual.html#_apache_ofbiz_plugins]
 or 
[developer-manual|https://ci.apache.org/projects/ofbiz/site/trunk/ofbizdoc/html5/developer-manual.html#_apache_ofbiz_plugins_for_developer]

Currently, image usage not works in the two case, because image path is 
relative to the root document.

To solve the problem, I propose to put image(s) relative to a component in the 
src/docs/asciidoc/images/${component.name} of the component and modifying 
gradle generateDocumentation task to copy the subdirectory in the general 
docs/asciidoc/images/ directory before generation and remove it after.

Currently only birt is concern but it's better to have schema and other image 
in documentation, so in future all components should be concerned.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12018) Open FTL File from browser

2020-10-01 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205492#comment-17205492
 ] 

Jacques Le Roux commented on OFBIZ-12018:
-

Hi James,

Still does not work. I mostly use FF, after a Ctlr+F5, I saw a 404 there, then 
looked into access.log got this for FF

127.0.0.1 - - [01/Oct/2020:14:35:15 +0200] "POST /openSourceFile HTTP/1.1" 404 
682 "https://localhost:8443/ecomseo; "Mozilla/5.0 (Windows NT 6.1; Win64; x64; 
rv:56.0) Gecko/20100101 Firefox/56.0"

for Chrome (twice, after F12 in Network with disable chache on):

14:41:20.180 jquery-3.5.1.min.js:2 POST https://localhost:8443/openSourceFile 
404
send @ jquery-3.5.1.min.js:2
ajax @ jquery-3.5.1.min.js:2
s.ajax @ jquery-migrate-3.3.0.min.js:2
(anonymous) @ OfbizUtil.js:53
dispatch @ jquery-3.5.1.min.js:2
v.handle @ jquery-3.5.1.min.js:2
14:41:20.183 jquery-3.5.1.min.js:2 XHR failed loading: POST 
"https://localhost:8443/openSourceFile;.
send @ jquery-3.5.1.min.js:2
ajax @ jquery-3.5.1.min.js:2
s.ajax @ jquery-migrate-3.3.0.min.js:2
(anonymous) @ OfbizUtil.js:53
dispatch @ jquery-3.5.1.min.js:2
v.handle @ jquery-3.5.1.min.js:2
14:41:23.526 jquery-3.5.1.min.js:2 POST https://localhost:8443/openSourceFile 
404
send @ jquery-3.5.1.min.js:2
ajax @ jquery-3.5.1.min.js:2
s.ajax @ jquery-migrate-3.3.0.min.js:2
(anonymous) @ OfbizUtil.js:53
dispatch @ jquery-3.5.1.min.js:2
v.handle @ jquery-3.5.1.min.js:2
14:41:23.527 jquery-3.5.1.min.js:2 XHR failed loading: POST 
"https://localhost:8443/openSourceFile;.
send @ jquery-3.5.1.min.js:2
ajax @ jquery-3.5.1.min.js:2
s.ajax @ jquery-migrate-3.3.0.min.js:2
(anonymous) @ OfbizUtil.js:53
dispatch @ jquery-3.5.1.min.js:2
v.handle @ jquery-3.5.1.min.js:2
14:41:23.829 DevTools failed to load SourceMap: Could not load content for 
https://localhost:8443/ecommerce/js/bootstrap/css/bootstrap-4.3.1.min.css.map: 
HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

And for Edge (chromium)

Failed to load resource: the server responded with a status of 404  
openSourceFile:1

When getting to the page Edge suggest in Network (F12)
HTTP Status 404  Not Found
Type Status Report
Description The origin server did not find a current representation for the 
target resource or is not willing to disclose that one exists.
Apache Tomcat/9.0.37


Works in 3 browsers for ecommerce, nothing special spotted in js console; in 
access.log, respectively:
127.0.0.1 - - [01/Oct/2020:14:56:02 +0200] "POST 
/ecommerce/control/openSourceFile HTTP/1.1" 200 - 
"https://localhost:8443/ecommerce/control/main; "Mozilla/5.0 (Windows NT 6.1; 
Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0"
0:0:0:0:0:0:0:1 - - [01/Oct/2020:14:50:41 +0200] "POST 
/ecommerce/control/openSourceFile HTTP/1.1" 200 - 
"https://localhost:8443/ecommerce/control/main; "Mozilla/5.0 (Windows NT 6.1; 
Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 
Safari/537.36"
0:0:0:0:0:0:0:1 - - [01/Oct/2020:14:50:50 +0200] "POST 
/ecommerce/control/openSourceFile HTTP/1.1" 200 - 
"https://localhost:8443/ecommerce/control/main; "Mozilla/5.0 (Windows NT 6.1; 
Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/85.0.4183.121 
Safari/537.36 Edg/85.0.564.63"

HTH

> Open FTL File from browser 
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename 
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12018) Open FTL File from browser

2020-10-01 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17205443#comment-17205443
 ] 

James Yong commented on OFBIZ-12018:


Hi Jacques,

I believe it is a cache issue, since js file is updated.
If you are using Chrome, can go to Developer Tools -> Network tab and set 
"Disable cache" to true?

 

> Open FTL File from browser 
> ---
>
> Key: OFBIZ-12018
> URL: https://issues.apache.org/jira/browse/OFBIZ-12018
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12018.patch, OFBIZ-12018.patch, OFBIZ-12018.patch
>
>
> Allow developer to open FTL file from the browser by clicking on the filename 
> on the named border.
> There are 2 properties involved:
> {code:java}
> # Enable widget named border for development
> # NONE - For production where no named border will be shown.
> # LABEL - Show named border
> # SOURCE - Show named border with link to open the source code
> widget.dev.namedBorder=SOURCE
> # Command template to open file with editor
> # For intellij IDEA use: idea ${sourceLocation}
> widget.dev.cmd.openSourceFile=idea ${sourceLocation}{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)