[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #54: Removed HelpData file entries from ofbiz-component.xml

2021-02-11 Thread GitBox


sonarcloud[bot] commented on pull request #54:
URL: https://github.com/apache/ofbiz-plugins/pull/54#issuecomment-778025896


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=54=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=54=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=54=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=54=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=54)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=54=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=54=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-11587) Migration all docbook file to asciidoc

2021-02-11 Thread Deepak Dixit (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit closed OFBIZ-11587.

Fix Version/s: Upcoming Branch
   Resolution: Fixed

Removed files entries from ofbiz-component.xml file at following PR

https://github.com/apache/ofbiz-plugins/pull/54

> Migration all docbook file to asciidoc
> --
>
> Key: OFBIZ-11587
> URL: https://issues.apache.org/jira/browse/OFBIZ-11587
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Deepak Dixit
>Priority: Minor
>  Labels: documentation
> Fix For: Upcoming Branch
>
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Umbrella task, for all components migration tasks.
> Idea is to have only one branch/PR for all tasks, with one commit per 
> component / sub-component migration, it will be more easy to merge it when it 
> will be finish



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-plugins] dixitdeepak merged pull request #54: Removed HelpData file entries from ofbiz-component.xml

2021-02-11 Thread GitBox


dixitdeepak merged pull request #54:
URL: https://github.com/apache/ofbiz-plugins/pull/54


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [ofbiz-plugins] dixitdeepak opened a new pull request #54: Removed HelpData file entries from ofbiz-component.xml

2021-02-11 Thread GitBox


dixitdeepak opened a new pull request #54:
URL: https://github.com/apache/ofbiz-plugins/pull/54


   Improved:
   Implemented:
   Documented:
   Completed:
   Reverted:
   Fixed:
   (OFBIZ-)
   
   Explanation
   
   Thanks:
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Reopened] (OFBIZ-11587) Migration all docbook file to asciidoc

2021-02-11 Thread Deepak Dixit (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Deepak Dixit reopened OFBIZ-11587:
--
  Assignee: Deepak Dixit  (was: Olivier Heintz)

Following warnings of console

Need to remove entry from ofbiz-component.xml file
{code:java}
2021-02-12 12:27:22,370 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/plugins/birt/data/BirtHelpData.xml
2021-02-12 12:27:22,370 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/plugins/birt/data/example/ExampleHelpData.xml
2021-02-12 12:27:22,370 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/plugins/ebay/data/EbayHelpData.xml
2021-02-12 12:27:22,370 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/plugins/example/data/ExampleHelpData.xml
2021-02-12 12:27:22,371 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/plugins/projectmgr/data/ProjectMgrHelpData.xml
2021-02-12 12:27:22,371 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/plugins/scrum/data/scrumHelpData.xml
2021-02-12 12:27:22,374 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/framework/security/data/SecurityTypeDemoData.xml
2021-02-12 12:27:22,374 |main |EntityDataLoader  
|W| Could not get URL for Component ResourceHandler: 
org.apache.ofbiz.base.component.ComponentException: File Resource not found: 
/Users/deepakdixit/git-sandbox/ofbiz_sandbox/ofbiz-framework/framework/common/data/CommonScheduledServicesDemoData.xml
{code}

> Migration all docbook file to asciidoc
> --
>
> Key: OFBIZ-11587
> URL: https://issues.apache.org/jira/browse/OFBIZ-11587
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Olivier Heintz
>Assignee: Deepak Dixit
>Priority: Minor
>  Labels: documentation
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Umbrella task, for all components migration tasks.
> Idea is to have only one branch/PR for all tasks, with one commit per 
> component / sub-component migration, it will be more easy to merge it when it 
> will be finish



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12168) Rename some connoted words like blacklist and whitelist.

2021-02-11 Thread Deepak Dixit (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283532#comment-17283532
 ] 

Deepak Dixit commented on OFBIZ-12168:
--

Hi [~jleroux] 

Need to change the fk-name for OrderDenylist entity. 
{code:java}
2021-02-12 12:27:00,742 |delegator-startup-1 |GenericDelegator |W| 
[RelationFkDuplicate] Relation to OrderDenylistType from entity OrderDenylist 
has a duplicate fk-name "ORDER_BKL_TYPE".{code}

> Rename some connoted words like blacklist and whitelist. 
> -
>
> Key: OFBIZ-12168
> URL: https://issues.apache.org/jira/browse/OFBIZ-12168
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2021-02-11 Thread Suraj Khurana (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-11680.
-
Fix Version/s: 17.12.05
   18.12.01
   Resolution: Fixed

Thanks [~mbrohl] for reminder.
Done from my side.

> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: quote
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283515#comment-17283515
 ] 

ASF subversion and git services commented on OFBIZ-11680:
-

Commit a5e96763e4cca40be15fe638bf35e0b1cfb5 in ofbiz-framework's branch 
refs/heads/release17.12 from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=a5e9676 ]

Fixed: ViewQuoteProfit shows fields in wrong order.
(OFBIZ-11680)
Thanks Pierre for reporting and Lalit Dashora for providing the patch.


> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: quote
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283511#comment-17283511
 ] 

ASF subversion and git services commented on OFBIZ-11680:
-

Commit e1f3cd92c36f8148e2902d83c324d012853e870e in ofbiz-framework's branch 
refs/heads/release18.12 from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e1f3cd9 ]

Fixed: ViewQuoteProfit shows fields in wrong order.
(OFBIZ-11680)
Thanks Pierre for reporting and Lalit Dashora for providing the patch.


> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: quote
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283510#comment-17283510
 ] 

ASF subversion and git services commented on OFBIZ-11680:
-

Commit cbec4d7b7c3584f4478d0a117877cf359363e357 in ofbiz-framework's branch 
refs/heads/trunk from Suraj Khurana
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=cbec4d7 ]

Fixed: ViewQuoteProfit shows fields in wrong order.
(OFBIZ-11680)
Thanks Pierre for reporting and Lalit Dashora for providing the patch.


> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: quote
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script

2021-02-11 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma closed OFBIZ-12173.
---
Fix Version/s: Release Branch 17.12
   Release Branch 18.12
   Resolution: Fixed

Thanks, [~Giulio_MpStyle] for the report and patch. And [~jacopoc] and 
[~deepak] for review.

I've used UtilHttp.getSessionId() as suggested by [~deepak].

 

> Visit disabling causes NullPointerException on ecomm groovy script
> --
>
> Key: OFBIZ-12173
> URL: https://issues.apache.org/jira/browse/OFBIZ-12173
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
> Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03
>Reporter: Giulio Speri
>Assignee: Pawan Verma
>Priority: Blocker
>  Labels: visit
> Fix For: Release Branch 18.12, Release Branch 17.12
>
> Attachments: 
> OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, 
> newcustomer_error.jpg
>
>
> Disable tracking of Visits and Visitors, setting false the value of 
> stats.persist.visit stats.persist.visitor in serverstats.properties file, 
> causes a NullPointerException in the groovy script 
> ecommerce/groovyScript/customer/NewCustomer.groovy.
>  Attached here below a screenshot of the error.
> !newcustomer_error.jpg!
> This error also afflicts older version of OFBiz (the screenshot is taken from 
> an ecommerce site running on OFBiz 13.07.03)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283488#comment-17283488
 ] 

ASF subversion and git services commented on OFBIZ-12173:
-

Commit 38419ef257a9de03fd8ac76c78b3d296fc99deb9 in ofbiz-plugins's branch 
refs/heads/release17.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=38419ef ]

Fixed: Visit disabling causes NullPointerException on ecomm groovy 
script(OFBIZ-12173)

Used UtilHttp.getSessionId() instead of visit to get session Id.

Thanks: Giulio, Jacopo and Deepak.


> Visit disabling causes NullPointerException on ecomm groovy script
> --
>
> Key: OFBIZ-12173
> URL: https://issues.apache.org/jira/browse/OFBIZ-12173
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
> Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03
>Reporter: Giulio Speri
>Assignee: Pawan Verma
>Priority: Blocker
>  Labels: visit
> Attachments: 
> OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, 
> newcustomer_error.jpg
>
>
> Disable tracking of Visits and Visitors, setting false the value of 
> stats.persist.visit stats.persist.visitor in serverstats.properties file, 
> causes a NullPointerException in the groovy script 
> ecommerce/groovyScript/customer/NewCustomer.groovy.
>  Attached here below a screenshot of the error.
> !newcustomer_error.jpg!
> This error also afflicts older version of OFBiz (the screenshot is taken from 
> an ecommerce site running on OFBiz 13.07.03)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283487#comment-17283487
 ] 

ASF subversion and git services commented on OFBIZ-12173:
-

Commit 7afe2b73e596969f56a5f7ea782387e35b1561dd in ofbiz-plugins's branch 
refs/heads/release18.12 from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=7afe2b7 ]

Fixed: Visit disabling causes NullPointerException on ecomm groovy 
script(OFBIZ-12173)

Used UtilHttp.getSessionId() instead of visit to get session Id.

Thanks: Giulio, Jacopo and Deepak.


> Visit disabling causes NullPointerException on ecomm groovy script
> --
>
> Key: OFBIZ-12173
> URL: https://issues.apache.org/jira/browse/OFBIZ-12173
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
> Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03
>Reporter: Giulio Speri
>Assignee: Pawan Verma
>Priority: Blocker
>  Labels: visit
> Attachments: 
> OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, 
> newcustomer_error.jpg
>
>
> Disable tracking of Visits and Visitors, setting false the value of 
> stats.persist.visit stats.persist.visitor in serverstats.properties file, 
> causes a NullPointerException in the groovy script 
> ecommerce/groovyScript/customer/NewCustomer.groovy.
>  Attached here below a screenshot of the error.
> !newcustomer_error.jpg!
> This error also afflicts older version of OFBiz (the screenshot is taken from 
> an ecommerce site running on OFBiz 13.07.03)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283485#comment-17283485
 ] 

ASF subversion and git services commented on OFBIZ-12173:
-

Commit 728354a0cb6b0a6874d6e1627826978b776ce8c4 in ofbiz-plugins's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=728354a ]

Fixed: Visit disabling causes NullPointerException on ecomm groovy 
script(OFBIZ-12173)

Used UtilHttp.getSessionId() instead of visit to get session Id.

Thanks: Giulio, Jacopo and Deepak.


> Visit disabling causes NullPointerException on ecomm groovy script
> --
>
> Key: OFBIZ-12173
> URL: https://issues.apache.org/jira/browse/OFBIZ-12173
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
> Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03
>Reporter: Giulio Speri
>Assignee: Pawan Verma
>Priority: Blocker
>  Labels: visit
> Attachments: 
> OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, 
> newcustomer_error.jpg
>
>
> Disable tracking of Visits and Visitors, setting false the value of 
> stats.persist.visit stats.persist.visitor in serverstats.properties file, 
> causes a NullPointerException in the groovy script 
> ecommerce/groovyScript/customer/NewCustomer.groovy.
>  Attached here below a screenshot of the error.
> !newcustomer_error.jpg!
> This error also afflicts older version of OFBiz (the screenshot is taken from 
> an ecommerce site running on OFBiz 13.07.03)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script

2021-02-11 Thread Pawan Verma (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pawan Verma reassigned OFBIZ-12173:
---

Assignee: Pawan Verma  (was: Giulio Speri)

> Visit disabling causes NullPointerException on ecomm groovy script
> --
>
> Key: OFBIZ-12173
> URL: https://issues.apache.org/jira/browse/OFBIZ-12173
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
> Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03
>Reporter: Giulio Speri
>Assignee: Pawan Verma
>Priority: Blocker
>  Labels: visit
> Attachments: 
> OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, 
> newcustomer_error.jpg
>
>
> Disable tracking of Visits and Visitors, setting false the value of 
> stats.persist.visit stats.persist.visitor in serverstats.properties file, 
> causes a NullPointerException in the groovy script 
> ecommerce/groovyScript/customer/NewCustomer.groovy.
>  Attached here below a screenshot of the error.
> !newcustomer_error.jpg!
> This error also afflicts older version of OFBiz (the screenshot is taken from 
> an ecommerce site running on OFBiz 13.07.03)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11839) Add CHANGELOG.adoc file

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283418#comment-17283418
 ] 

Michael Brohl commented on OFBIZ-11839:
---

Thanks [~deepak]  !

> Add CHANGELOG.adoc file
> ---
>
> Key: OFBIZ-11839
> URL: https://issues.apache.org/jira/browse/OFBIZ-11839
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Deepak Dixit
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Add new changelog.adoc file to maintain the changelog
> *What is a changelog?*
> A changelog is a file which contains a curated, chronologically ordered list 
> of notable changes for each version of a project.
> **
>  *Why keep a changelog?*
> To make it easier for users and contributors to see precisely what notable 
> changes have been made between each release (or version) of the project.
> **
>  *Who needs a changelog?*
> People do. Whether consumers or developers, the end users of software are 
> human beings who care about what's in the software. When the software 
> changes, people want to know why and how.
> [https://keepachangelog.com/en/1.0.0/]
>  [Here|https://s.apache.org/7klg3] is the link for Dev list discussion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283417#comment-17283417
 ] 

Michael Brohl commented on OFBIZ-10476:
---

I had to rework the patch. There were changes in forms which should not be made 
(parent content), probably because of a misleading uiLabel. The uiLabel was 
renamed and the parent content Id fields were not removed in the forms.

The changes are now in a pull request linked to this issue. I'd appreciate if 
someone could test if everything works as expected in the content component 
after the changes are applied. Thanks!

 

> Remove Compdoc functionality from content manager
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #271: Improved: Remove Compdoc functionality from content manager (OFBIZ-10476)

2021-02-11 Thread GitBox


sonarcloud[bot] commented on pull request #271:
URL: https://github.com/apache/ofbiz-framework/pull/271#issuecomment-777840366


   Kudos, SonarCloud Quality Gate passed!
   
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=BUG)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=BUG)
 [0 
Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=BUG)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=VULNERABILITY)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=VULNERABILITY)
 [0 
Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=VULNERABILITY)
  
   [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=271=false=SECURITY_HOTSPOT)
 [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=271=false=SECURITY_HOTSPOT)
 [0 Security 
Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=271=false=SECURITY_HOTSPOT)
  
   [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=CODE_SMELL)
 [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=CODE_SMELL)
 [0 Code 
Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=271=false=CODE_SMELL)
   
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=271)
 No Coverage information  
   [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=271=new_duplicated_lines_density=list)
 [0.0% 
Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=271=new_duplicated_lines_density=list)
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-10476) Remove Compdoc functionality from content manager

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10476:
--
Attachment: (was: OFBIZ-10476_Content-CompDoc.patch)

> Remove Compdoc functionality from content manager
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] mbrohl opened a new pull request #271: Improved: Remove Compdoc functionality from content manager (OFBIZ-10476)

2021-02-11 Thread GitBox


mbrohl opened a new pull request #271:
URL: https://github.com/apache/ofbiz-framework/pull/271


   Reworked the patch from the Jira, please test and approve.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Closed] (OFBIZ-12164) NPE in Party/My Communications

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-12164.
-
Fix Version/s: Upcoming Branch
   18.12.01
   Resolution: Fixed

Thanks Benjamin, fixed in trunk and backported to 18.12.

> NPE in Party/My Communications
> --
>
> Key: OFBIZ-12164
> URL: https://issues.apache.org/jira/browse/OFBIZ-12164
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Fix For: 18.12.01, Upcoming Branch
>
>
> If you create a new communication in the "Party" menu, "Communications" tab, 
> which concerns the current user, it is shown in the "My communications" tab 
> in the "ListPartyCommEvents" section. However, it throws an NPE with the 
> following message:
> ??java.lang.RuntimeException: Error rendering included form named 
> [ListPartyCommEvents] at location 
> [component://party/widget/partymgr/CommunicationEventForms.xml]: 
> java.lang.NullPointerExceptionjava.lang.NullPointerException??



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12164) NPE in Party/My Communications

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283354#comment-17283354
 ] 

ASF subversion and git services commented on OFBIZ-12164:
-

Commit 85150bc7ab5206761aa70e2f0ffde16bc28fa29a in ofbiz-framework's branch 
refs/heads/release18.12 from Benjamin Jugl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=85150bc ]

Fixed: Prevents NPE in Party/My Communications (OFBIZ-12164)

> NPE in Party/My Communications
> --
>
> Key: OFBIZ-12164
> URL: https://issues.apache.org/jira/browse/OFBIZ-12164
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
>
> If you create a new communication in the "Party" menu, "Communications" tab, 
> which concerns the current user, it is shown in the "My communications" tab 
> in the "ListPartyCommEvents" section. However, it throws an NPE with the 
> following message:
> ??java.lang.RuntimeException: Error rendering included form named 
> [ListPartyCommEvents] at location 
> [component://party/widget/partymgr/CommunicationEventForms.xml]: 
> java.lang.NullPointerExceptionjava.lang.NullPointerException??



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12164) NPE in Party/My Communications

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283353#comment-17283353
 ] 

ASF subversion and git services commented on OFBIZ-12164:
-

Commit ce5397dbc6cd1402dd6f4e42a55cea7a5baff409 in ofbiz-framework's branch 
refs/heads/trunk from Benjamin Jugl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=ce5397d ]

Fixed: Prevents NPE in Party/My Communications (OFBIZ-12164)

> NPE in Party/My Communications
> --
>
> Key: OFBIZ-12164
> URL: https://issues.apache.org/jira/browse/OFBIZ-12164
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
>
> If you create a new communication in the "Party" menu, "Communications" tab, 
> which concerns the current user, it is shown in the "My communications" tab 
> in the "ListPartyCommEvents" section. However, it throws an NPE with the 
> following message:
> ??java.lang.RuntimeException: Error rendering included form named 
> [ListPartyCommEvents] at location 
> [component://party/widget/partymgr/CommunicationEventForms.xml]: 
> java.lang.NullPointerExceptionjava.lang.NullPointerException??



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [ofbiz-framework] mbrohl merged pull request #261: OFBIZ-12164 Fixed: Prevents NPE in Party/My Communications

2021-02-11 Thread GitBox


mbrohl merged pull request #261:
URL: https://github.com/apache/ofbiz-framework/pull/261


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Updated] (OFBIZ-10476) Remove Compdoc functionality from content manager

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10476:
--
Affects Version/s: Release Branch 18.12
   Trunk

> Remove Compdoc functionality from content manager
> -
>
> Key: OFBIZ-10476
> URL: https://issues.apache.org/jira/browse/OFBIZ-10476
> Project: OFBiz
>  Issue Type: Improvement
>  Components: content
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Dennis Balkir
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10476_Content-CompDoc.patch
>
>
> While creating a theme and looking for not correctly styled elements I came 
> across "some" not functional links and buttons in Compdoc.
> This module seems not to be finished or working properly, because most of the 
> times, the buttons inside the appbar produce errors or just empty pages.
> Even when searching for existing elements and then clicking on them to 
> examine or edit them will mostly create an error (example: go to compdoc, 
> search for template child, click edit on some random found element -> error).
> Sometimes the menu which is included inside the appbar, mostly the menu 
> called "tree", need the contentId for the buttons to work.
> Including this menu while creating a new entry will result in every button 
> not working and throwing an error, except the edit button, which will produce 
> a completely empty page.
> Those things appear all over the module, trying some button or clicking some 
> link resulted in an error screen more than it resulted in something actually 
> working.
> This should either be fixed or removed, if this doesn't has a real purpose at 
> all.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283344#comment-17283344
 ] 

Michael Brohl commented on OFBIZ-6510:
--

[~bjugl] during my tests for the r18.12 backport I noticed that the XML entity 
model does not contain any relations / foreign keys.

Where these also missing in the previous implementation or do we have a 
regression? Please check, thanks.

> Replace webtools/control/view/ModelInduceFromDb with widgets
> 
>
> Key: OFBIZ-6510
> URL: https://issues.apache.org/jira/browse/OFBIZ-6510
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Christian Carlow
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, 
> OFBIZ-6510.patch
>
>
> The page is written in JSP probably from very long ago when FTL and widgets 
> didn't even exist yet.  It should be implemented in widgets now that they are 
> available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-6510.

Fix Version/s: 18.12.01
   Resolution: Implemented

Backported to r18.12. Thanks everyone!

> Replace webtools/control/view/ModelInduceFromDb with widgets
> 
>
> Key: OFBIZ-6510
> URL: https://issues.apache.org/jira/browse/OFBIZ-6510
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Christian Carlow
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, 
> OFBIZ-6510.patch
>
>
> The page is written in JSP probably from very long ago when FTL and widgets 
> didn't even exist yet.  It should be implemented in widgets now that they are 
> available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets

2021-02-11 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283339#comment-17283339
 ] 

ASF subversion and git services commented on OFBIZ-6510:


Commit 177b96300fd0f8b3208cb67678faf732b73c4b2d in ofbiz-framework's branch 
refs/heads/release18.12 from Michael Brohl
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=177b963 ]

Improved: Replaces ModelInduceFromDb with widgets (OFBIZ-6510)

This is a manual backport of the related two commits in trunk with minor
changes to fit the r18.12 codebase.

> Replace webtools/control/view/ModelInduceFromDb with widgets
> 
>
> Key: OFBIZ-6510
> URL: https://issues.apache.org/jira/browse/OFBIZ-6510
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Christian Carlow
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, 
> OFBIZ-6510.patch
>
>
> The page is written in JSP probably from very long ago when FTL and widgets 
> didn't even exist yet.  It should be implemented in widgets now that they are 
> available.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10914) Fitering on StatusId in FindTask does not work

2021-02-11 Thread Deepak Dixit (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283336#comment-17283336
 ] 

Deepak Dixit commented on OFBIZ-10914:
--

Let me check

> Fitering on StatusId in FindTask does not work
> --
>
> Key: OFBIZ-10914
> URL: https://issues.apache.org/jira/browse/OFBIZ-10914
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-10914.patch
>
>
> Filtering on one of the available status options (statusId) does not yield 
> the expected result. 
> To reproduce:
>  # go to [https://demo-stable.ofbiz.apache.org/projectmgr/control/FindTask]
>  # select one of the status options, e.g. Created
>  # see appropriate list of tasks
> Actual result (with selected status option Created):
> Overview shows tasks with statusId = Created PLUS the tasks with status In 
> Progress



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script

2021-02-11 Thread Deepak Dixit (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283335#comment-17283335
 ] 

Deepak Dixit commented on OFBIZ-12173:
--

I think instead of parameters.session we can use 
{color:#00}UtilHttp{color}.getSessionId(request)

> Visit disabling causes NullPointerException on ecomm groovy script
> --
>
> Key: OFBIZ-12173
> URL: https://issues.apache.org/jira/browse/OFBIZ-12173
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
> Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Blocker
>  Labels: visit
> Attachments: 
> OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, 
> newcustomer_error.jpg
>
>
> Disable tracking of Visits and Visitors, setting false the value of 
> stats.persist.visit stats.persist.visitor in serverstats.properties file, 
> causes a NullPointerException in the groovy script 
> ecommerce/groovyScript/customer/NewCustomer.groovy.
>  Attached here below a screenshot of the error.
> !newcustomer_error.jpg!
> This error also afflicts older version of OFBiz (the screenshot is taken from 
> an ecommerce site running on OFBiz 13.07.03)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11839) Add CHANGELOG.adoc file

2021-02-11 Thread Deepak Dixit (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283326#comment-17283326
 ] 

Deepak Dixit commented on OFBIZ-11839:
--

 [~mbrohl] I think we can star this with fresh in trunk (R21) release, as there 
is no sense to backport this to 17.12 (reached EOL) and 18.12 as we are 
planning to release it soon so maintain half backed thing not a good idea.

Thanks for closing the task

 

> Add CHANGELOG.adoc file
> ---
>
> Key: OFBIZ-11839
> URL: https://issues.apache.org/jira/browse/OFBIZ-11839
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Deepak Dixit
>Assignee: Michael Brohl
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Add new changelog.adoc file to maintain the changelog
> *What is a changelog?*
> A changelog is a file which contains a curated, chronologically ordered list 
> of notable changes for each version of a project.
> **
>  *Why keep a changelog?*
> To make it easier for users and contributors to see precisely what notable 
> changes have been made between each release (or version) of the project.
> **
>  *Who needs a changelog?*
> People do. Whether consumers or developers, the end users of software are 
> human beings who care about what's in the software. When the software 
> changes, people want to know why and how.
> [https://keepachangelog.com/en/1.0.0/]
>  [Here|https://s.apache.org/7klg3] is the link for Dev list discussion.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12101) partymgr fails to upload image

2021-02-11 Thread Jacques Le Roux (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-12101:

Fix Version/s: (was: 17.12.05)
   (was: 18.12.01)

> partymgr fails to upload image
> --
>
> Key: OFBIZ-12101
> URL: https://issues.apache.org/jira/browse/OFBIZ-12101
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
> Environment: OS: Ubuntu 20.04
> $ java -version
> java version "1.8.0_271"
> Java(TM) SE Runtime Environment (build 1.8.0_271-b09)
> Java HotSpot(TM) 64-Bit Server VM (build 25.271-b09, mixed mode)
>Reporter: Wai
>Assignee: Ankit Joshi
>Priority: Major
> Attachments: v.jpeg
>
>
> partymgr fails to upload image
>  
> Steps to reproduce issue:
> open https://localhost:8443/partymgr/control/viewprofile?partyId=admin
> in Party Content panel
>  select image to upload
>  select "Logo Image URL"
> click ok
> console output:
> 2020-12-25 16:24:06,533 |sse-nio-18443-exec-4 |UtilHttp |E| File upload 
> errororg.apache.commons.fileupload.FileUploadBase$IOFileUploadException: 
> Processing of multipart/form-data request failed. java.io.EOFException
> 2020-12-25 16:24:06,573 |sse-nio-18443-exec-4 |ModelService |I| Set default 
> value [DOCUMENT] for parameter [contentTypeId]
> 2020-12-25 16:24:06,661 |sse-nio-18443-exec-4 |UtilProperties |I| 
> ResourceBundle ServiceErrorUiLabels (en) created in 0.087s with 40 properties
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ModelService |E| 
> [ModelService.validate] : \{uploadPartyContentFile} : (IN) Required test 
> error: org.apache.ofbiz.service.ServiceValidationException: The following 
> required parameter is missing: [IN] 
> [uploadPartyContentFile.partyContentTypeId]
> 2020-12-25 16:24:06,662 |sse-nio-18443-exec-4 |ServiceDispatcher |E| Incoming 
> context (in runSync : uploadPartyContentFile) does not match expected 
> requirements
> org.apache.ofbiz.service.ServiceValidationException: The following required 
> parameter is missing: [IN] [uploadPartyContentFile.partyContentTypeId]
>  at org.apache.ofbiz.service.ModelService.validate(ModelService.java:1305) 
> ~[main/:?]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2021-02-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283291#comment-17283291
 ] 

Jacques Le Roux commented on OFBIZ-0:
-

Yes, it could be an improvement where we would remove all  contact mech types 
but Postal Address, Phone Number and Email Address... Not sure another Jira is 
necessary, but maybe clearer...

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11181) paymentMethodId choices wrong in form for creating/editing a received payment

2021-02-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283289#comment-17283289
 ] 

Jacques Le Roux commented on OFBIZ-11181:
-

Not very soon ;) Unless I don't have other priorities, lately it hasn't been 
like that.

> paymentMethodId choices wrong in form for creating/editing a received payment
> -
>
> Key: OFBIZ-11181
> URL: https://issues.apache.org/jira/browse/OFBIZ-11181
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
> Environment: Ofbiz 16.11.05 on Fedora 30 with OpenJDK 64-Bit Server 
> VM (build 25.222-b10, mixed mode) and mariadb-server.x86_64 3:10.3.17-1.fc30 
> as database
>Reporter: Parminder
>Assignee: Jacques Le Roux
>Priority: Major
>
> {color:#737373}There is a bug in the forms   for 
> Payment{color}{color:#737373} method field(drop down) for Incoming payment. 
> Payment methods should be{color}
> {color:#737373} whatever is  defined for getting the payments from customers 
> like  {color}{color:#737373}Company Check, Cash etc. etc. but it is showing 
> the methods which are{color}{color:#737373} applicable for outgoing payments 
> such as Petty cash and defined{color}{color:#737373} Financial accounts (from 
> where you pay the suppliers).{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.

2021-02-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283284#comment-17283284
 ] 

Jacques Le Roux commented on OFBIZ-10150:
-

I agree Michael, I let you create one...

> supplierProductId Should Have Consistent Types Across Entities.
> ---
>
> Key: OFBIZ-10150
> URL: https://issues.apache.org/jira/browse/OFBIZ-10150
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, product
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
> Environment: all
>Reporter: jesse thomas
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId 
> was too long. So I looked up the fields and noticed that the order item 
> entity had a different type for the field than the supplier product entity. I 
> think it would be a good idea to pick one so the two fields can be treated 
> consistently. I would vote for id-long, but I think either way it would be 
> good to have them be the same type. There are other fields that have this 
> issue too if you are interested?
>   
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:  
>  
> applications/datamodel/entitydef/product-entitymodel.xml:  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails

2021-02-11 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283282#comment-17283282
 ] 

Jacques Le Roux commented on OFBIZ-6638:


Hi Michael,

Sorry, I don't think so

> TrialBalance PDF export fails
> -
>
> Key: OFBIZ-6638
> URL: https://issues.apache.org/jira/browse/OFBIZ-6638
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png
>
>
> # Get to 
> http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company
> #pick a "Custom Time Period Id" (default works also)
> #Submit
> Then the CSV export works but not the PDF, this in trunk demo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-2363) Improvements in Sales Force Automation component

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-2363:
-
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Improvements in Sales Force Automation component
> 
>
> Key: OFBIZ-2363
> URL: https://issues.apache.org/jira/browse/OFBIZ-2363
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Trunk
> Environment: Mac OS X
>Reporter: Vikas Mayur
>Priority: Minor
>  Labels: SFA
>
> This is a parent issue that is related to doing improvements in the existing 
> screens in Sales Force Automation (SFA) application. Each improvement should 
> be a sub-task of this issue. 
> The existing screens in SFA are:
> -- Accounts
> -- Contacts
> -- Leads
> -- Forecast
> -- Opportunities 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-2363) Improvements in Sales Force Automation component

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283260#comment-17283260
 ] 

Michael Brohl commented on OFBIZ-2363:
--

Removing affects versions except trunk because this is an improvement (no bug).

> Improvements in Sales Force Automation component
> 
>
> Key: OFBIZ-2363
> URL: https://issues.apache.org/jira/browse/OFBIZ-2363
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Trunk
> Environment: Mac OS X
>Reporter: Vikas Mayur
>Priority: Minor
>  Labels: SFA
>
> This is a parent issue that is related to doing improvements in the existing 
> screens in Sales Force Automation (SFA) application. Each improvement should 
> be a sub-task of this issue. 
> The existing screens in SFA are:
> -- Accounts
> -- Contacts
> -- Leads
> -- Forecast
> -- Opportunities 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-2371) Improvements in "Account" Screens

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-2371:
-
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Improvements in "Account" Screens
> -
>
> Key: OFBIZ-2371
> URL: https://issues.apache.org/jira/browse/OFBIZ-2371
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Trunk
>Reporter: Ashish Vijaywargiya
>Priority: Minor
>  Labels: Forecasting, SFA
> Attachments: Exerpt CRM requirements - accounts.pdf, 
> SFA-Accounts-addSalesForecast.patch, SfaAccountsImprovements.patch
>
>
> Account should be treated as a PartyGroup. This group can be associated with 
> any type of party. Party can be either other Party Group or Person.
> Each account will be in Account role. The Parties (more then one party) can 
> be associated with Party Group through Party Relationship by 
> partyRelationshipTypeId being "Parent_Account".
> Left Navigation Section : There will be following link / section present in 
> left side. There will be two block in the left section similar to catalog.
> 1) Shortcuts
> 2) Quick Add Account
> Shorcuts block contains following link :
> - Create Account - Exists, modification required.
> - Find Accounts - Exists, Modification required.
> - Clone Account - It will navigate to the Party Group lookup form and from 
> there we should select the existing Account and lets clone it.
> Quick Add Account : This block will be similar to that of the Quick Add form 
> for Lead and Contacts.
> Lets keep only two fields in this block : Group Name (use "Account Name" on 
> GUI), Office Site Name (Use "Website" on GUI).
> Right side will be the content area (body section).
> 1) Modification in Create Account :
> a) Add Few more fields.The sequence of the fields will be (R - Required) :
> Fields from Party Group Entity : Group Name(R) (Use "Company Name") , Office 
> Site Name (Use "Website" on GUI), Annual Revenue, Number of Employees, Ticker 
> Symbol.
> b) Modification in General Correspondence address : Remove the field Address 
> Field 2 from the form. Instead of this use Separate Block to have "Other 
> Correspondence Address" block and provide all the fields there. (Similar 
> thing that we do in Ecommerce application for Billing & Shipping Address).
> 2) Modification in Find Account Screen :
> a) Search the records that has partyTypeId ="Party_Group" and has 
> roleTypeId="Account"
> b) Remove the Party Id field from the find form.
> c) Rename the Party Group Name to Account Name on GUI.
> d) The search result form will contain one more field titled "Email Address".
> e) For providing easy navigation to the user change Party Id field link to 
> Edit button. Also remove the Party ID label from the top. As we have changed 
> it to Edit link.
> f) Remove the "Type" column from the Search Result area. All the Account name 
> will be in role "Party_Group".
> 3) Modification on Summary Section :
> a) Add the screenlet section that will contain the contacts associated with 
> this Party Group (i.e Account). Also Provide small form at the bottom of 
> party list to add the other contacts on the existing list. For this provide 
> one lookup to search contacts (Person in the role of Contact) and then submit 
> button. If we do this through Ajax(Using Prototype Library) then it would be 
> good. The Contacts (more then one contact) can be associated with Party Group 
> through Party Relationship by partyRelationshipTypeId being "Parent_Account".
> b) Remove the Party Attribute block for now. It won't make any sense to me 
> for now.
> c) The list of all the Work Efforts(Activities/ Event & Tasks) associated 
> with the Party Group.Provide option to associate the existing work effort 
> record with the party. Create/Update & Delete form.
> 4) After editing any account (Party Group) we come to the Summary screen. 
> Provide another tab adjacent to it by name "Clone Account". Navigate to a 
> form where we could clone this record.
> Rest of the functionality in the Accounts header should be tested properly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-2371) Improvements in "Account" Screens

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283259#comment-17283259
 ] 

Michael Brohl commented on OFBIZ-2371:
--

Removing affects versions except trunk because this is an improvement (no bug).

> Improvements in "Account" Screens
> -
>
> Key: OFBIZ-2371
> URL: https://issues.apache.org/jira/browse/OFBIZ-2371
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: marketing
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Ashish Vijaywargiya
>Priority: Minor
>  Labels: Forecasting, SFA
> Attachments: Exerpt CRM requirements - accounts.pdf, 
> SFA-Accounts-addSalesForecast.patch, SfaAccountsImprovements.patch
>
>
> Account should be treated as a PartyGroup. This group can be associated with 
> any type of party. Party can be either other Party Group or Person.
> Each account will be in Account role. The Parties (more then one party) can 
> be associated with Party Group through Party Relationship by 
> partyRelationshipTypeId being "Parent_Account".
> Left Navigation Section : There will be following link / section present in 
> left side. There will be two block in the left section similar to catalog.
> 1) Shortcuts
> 2) Quick Add Account
> Shorcuts block contains following link :
> - Create Account - Exists, modification required.
> - Find Accounts - Exists, Modification required.
> - Clone Account - It will navigate to the Party Group lookup form and from 
> there we should select the existing Account and lets clone it.
> Quick Add Account : This block will be similar to that of the Quick Add form 
> for Lead and Contacts.
> Lets keep only two fields in this block : Group Name (use "Account Name" on 
> GUI), Office Site Name (Use "Website" on GUI).
> Right side will be the content area (body section).
> 1) Modification in Create Account :
> a) Add Few more fields.The sequence of the fields will be (R - Required) :
> Fields from Party Group Entity : Group Name(R) (Use "Company Name") , Office 
> Site Name (Use "Website" on GUI), Annual Revenue, Number of Employees, Ticker 
> Symbol.
> b) Modification in General Correspondence address : Remove the field Address 
> Field 2 from the form. Instead of this use Separate Block to have "Other 
> Correspondence Address" block and provide all the fields there. (Similar 
> thing that we do in Ecommerce application for Billing & Shipping Address).
> 2) Modification in Find Account Screen :
> a) Search the records that has partyTypeId ="Party_Group" and has 
> roleTypeId="Account"
> b) Remove the Party Id field from the find form.
> c) Rename the Party Group Name to Account Name on GUI.
> d) The search result form will contain one more field titled "Email Address".
> e) For providing easy navigation to the user change Party Id field link to 
> Edit button. Also remove the Party ID label from the top. As we have changed 
> it to Edit link.
> f) Remove the "Type" column from the Search Result area. All the Account name 
> will be in role "Party_Group".
> 3) Modification on Summary Section :
> a) Add the screenlet section that will contain the contacts associated with 
> this Party Group (i.e Account). Also Provide small form at the bottom of 
> party list to add the other contacts on the existing list. For this provide 
> one lookup to search contacts (Person in the role of Contact) and then submit 
> button. If we do this through Ajax(Using Prototype Library) then it would be 
> good. The Contacts (more then one contact) can be associated with Party Group 
> through Party Relationship by partyRelationshipTypeId being "Parent_Account".
> b) Remove the Party Attribute block for now. It won't make any sense to me 
> for now.
> c) The list of all the Work Efforts(Activities/ Event & Tasks) associated 
> with the Party Group.Provide option to associate the existing work effort 
> record with the party. Create/Update & Delete form.
> 4) After editing any account (Party Group) we come to the Summary screen. 
> Provide another tab adjacent to it by name "Clone Account". Navigate to a 
> form where we could clone this record.
> Rest of the functionality in the Accounts header should be tested properly.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283258#comment-17283258
 ] 

Michael Brohl commented on OFBIZ-6638:
--

Hi [~jleroux]  looks like this is a tough one. Any chance to bring this further 
in regard to the upcoming r18.12 release?

> TrialBalance PDF export fails
> -
>
> Key: OFBIZ-6638
> URL: https://issues.apache.org/jira/browse/OFBIZ-6638
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 14.12.01, 15.12.01
>
> Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png
>
>
> # Get to 
> http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company
> #pick a "Custom Time Period Id" (default works also)
> #Submit
> Then the CSV export works but not the PDF, this in trunk demo.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283255#comment-17283255
 ] 

Michael Brohl commented on OFBIZ-6705:
--

Removing affects versions except trunk because this is an improvement (no bug).

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-6705) some files set viewIndex to 1 by default rather than 0

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6705:
-
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> some files set viewIndex to 1 by default rather than 0
> --
>
> Key: OFBIZ-6705
> URL: https://issues.apache.org/jira/browse/OFBIZ-6705
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Gareth Carter
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-6705.patch, OFBIZ-6705.patch, 
> OFBIZ-6705_2020.patch, OFBIZ-6705_sample.patch
>
>
> The following files set viewIndex to 1
> {noformat}
> ./applications/order/src/org/ofbiz/order/order/OrderLookupServices.java:  
>   if (viewIndex == null) viewIndex = 1;
> ./applications/order/webapp/ordermgr/entry/catalog/categorydetail.ftl:
> <#--assign viewIndex = viewIndex - 1/-->
> ./applications/order/webapp/ordermgr/WEB-INF/actions/order/FindOrders.groovy:viewIndex
>  = request.getParameter("viewIndex") ? 
> Integer.valueOf(request.getParameter("viewIndex")) : 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/communication/ListCommunications.groovy:context.viewIndex
>  = 1;
> ./applications/party/webapp/partymgr/WEB-INF/actions/visit/ShowVisits.groovy: 
>viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> ./specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/actions/shoppinglist/EditShoppingList.groovy:
> viewIndex = Integer.valueOf(parameters.VIEW_INDEX  ?: 1);
> {noformat}
> I ran this command to get the output:
> grep -R --exclude-dir=.svn "viewIndex = " . | grep " 1"
> As far as I am aware, viewIndex starts from 0



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-6964) Support for replenishment of a secondary warehouse from a main warehouse

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283253#comment-17283253
 ] 

Michael Brohl commented on OFBIZ-6964:
--

Removing affects versions except trunk because this is an improvement (no bug).

> Support for replenishment of a secondary warehouse from a main warehouse
> 
>
> Key: OFBIZ-6964
> URL: https://issues.apache.org/jira/browse/OFBIZ-6964
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing, product
>Affects Versions: Release Branch 15.12, Release Branch 16.11, Trunk
>Reporter: Shrenik Bhura
>Assignee: Arun Patidar
>Priority: Major
>  Labels: Forecasting, SFA, features
> Attachments: screenshot-1.png
>
>
> At the onset let me define a few terms clearly as I mean it in the story 
> description below :
> Requirement - A request generated for a particular product for a specific 
> quantity that needs to be purchased from a supplier for satisfying certain 
> inventory needs of a particular facility.
> Replenishment - A request generated for a particular product for a specific 
> quantity that needs to be transferred from a "backup facility" for satisfying 
> certain inventory needs of a particular facility.
> Fulfilment - The process of reserving, picking, packing and shipping the 
> ordered quantity of product(s) as per a sales order.
> Terms 'warehouse' and 'facility' have been used interchangeably.
> *The Use Case:*
> Consider a scenario wherein there is a website and a physical retail store of 
> the same Company.
> Each having its own facility i.e. 1:1 mapping.
> {{Store A (webstore) -> associated with facility 1 (webstore facility)}}
> {{Store B (retailstore) -> associated with facility 2 (retailstore facility)}}
> However, both the stores share the same catalog/products. But both have 
> independent inventory requirement and replenishment rules for the same 
> product. 
> There is a Requirement Method Enum ID (RMEI) of each product which is 
> applicable irrespective of the store and supersedes the RMEI defined, if any, 
> on a store. 
> A product's inventory thresholds (Minimum Stock, Reorder Quantity) are 
> independently managed via the facilities tab for the product. A product has 
> its ATP and QOH levels on a per facility basis. _Do note that all these 
> inventory numbers are at a facility level and has no bearing at a store 
> level._
> Where the difficulty crops up with the current implementation is the way 
> requirements are generated. A product can have only one RMEI. When an order 
> is placed from any store, then based on the combination of a product's RMEI 
> and the store mapped facility's inventory threshold, requirements are 
> generated. This is without consideration of the inventory status (surplus or 
> otherwise) at another facility of the same Company. If a store has multiple 
> facilities associated with it then the one defined in the ProductStore entity 
> -> inventoryFacilityId field would be considered for picking the inventory 
> threshold values and thus for requirement generation. 
> Most typical real-world facility arrangements: 
>   1. Usually an organisation would have a main facility/warehouse where 
> all the purchases are received and sub-facilities which are replenished from 
> the main facility after QA, internal processes, etc. OR 
>   2. For each product there would be a primary facility where the product 
> is received from the supplier (to derive benefits of demographic convenience 
> and consumption patterns) and then replenished to other facilities on a 
> demand based pull basis.
> To drive efficiencies across an organisation they need methods to consider 
> open fulfilment needs, in process purchase orders and inventory levels across 
> multiple facilities and thereafter propose inventory transfers across them to 
> facilitate better stocking and thus order fulfilment.
> Coming back to our use case, the webstore warehouse is the main facility at 
> which incoming shipments from suppliers are received for the entire Company 
> but sales order fulfilment happens only for the webstore. The retail 
> warehouse is primarily 're-stocked' via replenishment requests raised upon 
> the webstore warehouse and thus need not issue direct purchase orders to 
> suppliers. However, if the need be, requirement generated based on the 
> product's RMEI and the retail facility's inventory thresholds can also be 
> approved, converted into Purchase order and issued.
> *Proposed Solution:*
> There doesn't seem to be an out of the box solution for this in OFBiz. This 
> could work if either we think of -
> Approach A: Setting RMEI at a ProductFacility level as well which shall 
> supersede the Product level RMEI setting OR 
> 

[jira] [Updated] (OFBIZ-6964) Support for replenishment of a secondary warehouse from a main warehouse

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6964:
-
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Support for replenishment of a secondary warehouse from a main warehouse
> 
>
> Key: OFBIZ-6964
> URL: https://issues.apache.org/jira/browse/OFBIZ-6964
> Project: OFBiz
>  Issue Type: New Feature
>  Components: manufacturing, product
>Affects Versions: Release Branch 15.12, Release Branch 16.11, Trunk
>Reporter: Shrenik Bhura
>Assignee: Arun Patidar
>Priority: Major
>  Labels: Forecasting, SFA, features
> Attachments: screenshot-1.png
>
>
> At the onset let me define a few terms clearly as I mean it in the story 
> description below :
> Requirement - A request generated for a particular product for a specific 
> quantity that needs to be purchased from a supplier for satisfying certain 
> inventory needs of a particular facility.
> Replenishment - A request generated for a particular product for a specific 
> quantity that needs to be transferred from a "backup facility" for satisfying 
> certain inventory needs of a particular facility.
> Fulfilment - The process of reserving, picking, packing and shipping the 
> ordered quantity of product(s) as per a sales order.
> Terms 'warehouse' and 'facility' have been used interchangeably.
> *The Use Case:*
> Consider a scenario wherein there is a website and a physical retail store of 
> the same Company.
> Each having its own facility i.e. 1:1 mapping.
> {{Store A (webstore) -> associated with facility 1 (webstore facility)}}
> {{Store B (retailstore) -> associated with facility 2 (retailstore facility)}}
> However, both the stores share the same catalog/products. But both have 
> independent inventory requirement and replenishment rules for the same 
> product. 
> There is a Requirement Method Enum ID (RMEI) of each product which is 
> applicable irrespective of the store and supersedes the RMEI defined, if any, 
> on a store. 
> A product's inventory thresholds (Minimum Stock, Reorder Quantity) are 
> independently managed via the facilities tab for the product. A product has 
> its ATP and QOH levels on a per facility basis. _Do note that all these 
> inventory numbers are at a facility level and has no bearing at a store 
> level._
> Where the difficulty crops up with the current implementation is the way 
> requirements are generated. A product can have only one RMEI. When an order 
> is placed from any store, then based on the combination of a product's RMEI 
> and the store mapped facility's inventory threshold, requirements are 
> generated. This is without consideration of the inventory status (surplus or 
> otherwise) at another facility of the same Company. If a store has multiple 
> facilities associated with it then the one defined in the ProductStore entity 
> -> inventoryFacilityId field would be considered for picking the inventory 
> threshold values and thus for requirement generation. 
> Most typical real-world facility arrangements: 
>   1. Usually an organisation would have a main facility/warehouse where 
> all the purchases are received and sub-facilities which are replenished from 
> the main facility after QA, internal processes, etc. OR 
>   2. For each product there would be a primary facility where the product 
> is received from the supplier (to derive benefits of demographic convenience 
> and consumption patterns) and then replenished to other facilities on a 
> demand based pull basis.
> To drive efficiencies across an organisation they need methods to consider 
> open fulfilment needs, in process purchase orders and inventory levels across 
> multiple facilities and thereafter propose inventory transfers across them to 
> facilitate better stocking and thus order fulfilment.
> Coming back to our use case, the webstore warehouse is the main facility at 
> which incoming shipments from suppliers are received for the entire Company 
> but sales order fulfilment happens only for the webstore. The retail 
> warehouse is primarily 're-stocked' via replenishment requests raised upon 
> the webstore warehouse and thus need not issue direct purchase orders to 
> suppliers. However, if the need be, requirement generated based on the 
> product's RMEI and the retail facility's inventory thresholds can also be 
> approved, converted into Purchase order and issued.
> *Proposed Solution:*
> There doesn't seem to be an out of the box solution for this in OFBiz. This 
> could work if either we think of -
> Approach A: Setting RMEI at a ProductFacility level as well which shall 
> supersede the Product level RMEI setting OR 
> Approach B: Build 

[jira] [Updated] (OFBIZ-9329) User should be notified with success message on successful completion of any action

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-9329:
-
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> User should be notified with success message on successful completion of any 
> action
> ---
>
> Key: OFBIZ-9329
> URL: https://issues.apache.org/jira/browse/OFBIZ-9329
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> On performing any action, user should be notified with the success message if 
> the action has been performed successfully.
> Listing actions with no alert messages delivered on success and will be 
> creating sub-tickets for the same.
> Ecommerce:
> 1. Subscribe to Newsletter: OFBIZ-9320
> 2. Add to Cart: OFBIZ-9521
> 3. Create/Update Shopping List: OFBIZ-9522
> 4. Last Categories > Clear: 
> Order Manager:
> 1. Update Quote: OFBIZ-9519
> 2. remove Quote Role:
> 3. Send Report by Mail from View Quote: OFBIZ-9321
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9329) User should be notified with success message on successful completion of any action

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283250#comment-17283250
 ] 

Michael Brohl commented on OFBIZ-9329:
--

Removing affects versions except trunk because this is an improvement (no bug).

> User should be notified with success message on successful completion of any 
> action
> ---
>
> Key: OFBIZ-9329
> URL: https://issues.apache.org/jira/browse/OFBIZ-9329
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> On performing any action, user should be notified with the success message if 
> the action has been performed successfully.
> Listing actions with no alert messages delivered on success and will be 
> creating sub-tickets for the same.
> Ecommerce:
> 1. Subscribe to Newsletter: OFBIZ-9320
> 2. Add to Cart: OFBIZ-9521
> 3. Create/Update Shopping List: OFBIZ-9522
> 4. Last Categories > Clear: 
> Order Manager:
> 1. Update Quote: OFBIZ-9519
> 2. remove Quote Role:
> 3. Send Report by Mail from View Quote: OFBIZ-9321
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-9894) Dropdown dependent mechanism should be there while selecting any Sales Forecast detail

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283247#comment-17283247
 ] 

Michael Brohl commented on OFBIZ-9894:
--

[~sonal.patwari] Can you please specify in more detail/with examples what you 
are expecting?

>From what I understand this would be more of an UI improvement instead of a 
>bug.

> Dropdown dependent mechanism should be there while selecting any Sales 
> Forecast detail
> --
>
> Key: OFBIZ-9894
> URL: https://issues.apache.org/jira/browse/OFBIZ-9894
> Project: OFBiz
>  Issue Type: Bug
>  Components: marketing
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Sonal Patwari
>Priority: Major
>  Labels: Forecasting, SFA
>
> Navigate to SFA component and on Sales Forecast screen, after creating a 
> forecast when we add forecast details, it allows us to add any of the fields 
> separately without depending on the other fields. 
> Expected result: There should be a dependency while selecting forecast 
> details.
> For example, While adding quantity, quantity UOM field should be dependent 
> and vice versa should also be possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9894) Dropdown dependent mechanism should be there while selecting any Sales Forecast detail

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-9894:
-
Issue Type: Improvement  (was: Bug)

> Dropdown dependent mechanism should be there while selecting any Sales 
> Forecast detail
> --
>
> Key: OFBIZ-9894
> URL: https://issues.apache.org/jira/browse/OFBIZ-9894
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Sonal Patwari
>Priority: Major
>  Labels: Forecasting, SFA
>
> Navigate to SFA component and on Sales Forecast screen, after creating a 
> forecast when we add forecast details, it allows us to add any of the fields 
> separately without depending on the other fields. 
> Expected result: There should be a dependency while selecting forecast 
> details.
> For example, While adding quantity, quantity UOM field should be dependent 
> and vice versa should also be possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-9894) Dropdown dependent mechanism should be there while selecting any Sales Forecast detail

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-9894:
-
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Dropdown dependent mechanism should be there while selecting any Sales 
> Forecast detail
> --
>
> Key: OFBIZ-9894
> URL: https://issues.apache.org/jira/browse/OFBIZ-9894
> Project: OFBiz
>  Issue Type: Improvement
>  Components: marketing
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Sonal Patwari
>Priority: Major
>  Labels: Forecasting, SFA
>
> Navigate to SFA component and on Sales Forecast screen, after creating a 
> forecast when we add forecast details, it allows us to add any of the fields 
> separately without depending on the other fields. 
> Expected result: There should be a dependency while selecting forecast 
> details.
> For example, While adding quantity, quantity UOM field should be dependent 
> and vice versa should also be possible.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283241#comment-17283241
 ] 

Michael Brohl edited comment on OFBIZ-10150 at 2/11/21, 5:42 PM:
-

[~jleroux] Do you still want this to be open as a bug?

Should we not better close this specific bug issue and create another one as an 
improvement?


was (Author: mbrohl):
[~jleroux] Do you still want this to be open as a bug?

Should we not better close this specifix bug issue and create another one as an 
improvement?

> supplierProductId Should Have Consistent Types Across Entities.
> ---
>
> Key: OFBIZ-10150
> URL: https://issues.apache.org/jira/browse/OFBIZ-10150
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, product
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
> Environment: all
>Reporter: jesse thomas
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId 
> was too long. So I looked up the fields and noticed that the order item 
> entity had a different type for the field than the supplier product entity. I 
> think it would be a good idea to pick one so the two fields can be treated 
> consistently. I would vote for id-long, but I think either way it would be 
> good to have them be the same type. There are other fields that have this 
> issue too if you are interested?
>   
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:  
>  
> applications/datamodel/entitydef/product-entitymodel.xml:  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10150) supplierProductId Should Have Consistent Types Across Entities.

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283241#comment-17283241
 ] 

Michael Brohl commented on OFBIZ-10150:
---

[~jleroux] Do you still want this to be open as a bug?

Should we not better close this specifix bug issue and create another one as an 
improvement?

> supplierProductId Should Have Consistent Types Across Entities.
> ---
>
> Key: OFBIZ-10150
> URL: https://issues.apache.org/jira/browse/OFBIZ-10150
> Project: OFBiz
>  Issue Type: Bug
>  Components: order, product
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
> Environment: all
>Reporter: jesse thomas
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-10150.patch
>
>
> During some data migration I hit an issue where my data for supplierProductId 
> was too long. So I looked up the fields and noticed that the order item 
> entity had a different type for the field than the supplier product entity. I 
> think it would be a good idea to pick one so the two fields can be treated 
> consistently. I would vote for id-long, but I think either way it would be 
> good to have them be the same type. There are other fields that have this 
> issue too if you are interested?
>   
> Thanks!
> applications/datamodel/entitydef/order-entitymodel.xml:  
>  
> applications/datamodel/entitydef/product-entitymodel.xml:  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10308) Financial account transaction --> accounting transaction

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283238#comment-17283238
 ] 

Michael Brohl commented on OFBIZ-10308:
---

[~wpaetzold] can you please try to apply this patch to latest trunk and provide 
a PR? Thanks!

> Financial account transaction --> accounting transaction
> 
>
> Key: OFBIZ-10308
> URL: https://issues.apache.org/jira/browse/OFBIZ-10308
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Priority: Major
> Attachments: ofbiz.patch
>
>
> When creating a financial account transaction some of the accounting 
> transaction are in the wrong direction.
> 1) Withdraw 10$:
>  DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other 
> Consulting Fees (10$)
>  2) Debit 10$:
>  *DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other 
> Consulting Fees (10$) (WRONG)*
>  3) Adjustment +10$:
>  DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other 
> Consulting Fees (10$)
>  4) Adjustment -10$:
>  *CREDIT 00 General Checking Account (-10$) -->DEBIT 649000 Other 
> Consulting Fees (-10$) (WRONG)*
> 2) should be:
>  DEBIT 649000 Other Consulting Fees   -->  CREDIT 00 General Checking 
> Account (10$)
>  4) should be:
>  CREDIT 00 General Checking Account (++*10$) -->DEBIT 649000 Other 
> Consulting Fees (+*+10$)
>  
> The attached patch fixes the issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10308) Financial account transaction --> accounting transaction

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-10308:
-

Assignee: Wiebke Pätzold

> Financial account transaction --> accounting transaction
> 
>
> Key: OFBIZ-10308
> URL: https://issues.apache.org/jira/browse/OFBIZ-10308
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Assignee: Wiebke Pätzold
>Priority: Major
> Attachments: ofbiz.patch
>
>
> When creating a financial account transaction some of the accounting 
> transaction are in the wrong direction.
> 1) Withdraw 10$:
>  DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other 
> Consulting Fees (10$)
>  2) Debit 10$:
>  *DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other 
> Consulting Fees (10$) (WRONG)*
>  3) Adjustment +10$:
>  DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other 
> Consulting Fees (10$)
>  4) Adjustment -10$:
>  *CREDIT 00 General Checking Account (-10$) -->DEBIT 649000 Other 
> Consulting Fees (-10$) (WRONG)*
> 2) should be:
>  DEBIT 649000 Other Consulting Fees   -->  CREDIT 00 General Checking 
> Account (10$)
>  4) should be:
>  CREDIT 00 General Checking Account (++*10$) -->DEBIT 649000 Other 
> Consulting Fees (+*+10$)
>  
> The attached patch fixes the issue.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-6113) Problem with Financial Account GL Entries when using Payment Deposit Transactions

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-6113:
-
Affects Version/s: Release Branch 18.12

> Problem with Financial Account GL Entries when using Payment Deposit 
> Transactions
> -
>
> Key: OFBIZ-6113
> URL: https://issues.apache.org/jira/browse/OFBIZ-6113
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 13.07, 16.11.05, Release Branch 18.12, 
> 17.12.01, Trunk
>Reporter: Storm Trinh
>Assignee: Sharan Foga
>Priority: Major
>  Labels: finAccount
> Attachments: Screenshot 2019-03-05 at 14.29.48.png, Screenshot 
> 2019-03-05 at 14.32.23.png, Screenshot 2019-03-05 at 14.33.41.png
>
>
> Problem with transaction when we use financial account.
>  When we receipt with financial account,
>   Payment :
>   Debit  = 100$ - Post To Gl Account Id Financial Account  (122100)
>   Credit = 100$ - Accounts Receivable (12)
>  When we use bank Bank Reconciliation, transaction is :
>   Debit  = 100$ - Post To Gl Account Id Financial Account  (122100)
>   Crebit  = 100$ - Post To Gl Account Id Financial Account  (122100)
>===>  In GL : Debit 122100= 200$, Credit  122100= 100$
> In fact, Debit 122100= 100$, Credit 122100 = 0$
> Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10782) Replace jQuery-Timepicker-Addon with flatpickr.js

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283226#comment-17283226
 ] 

Michael Brohl commented on OFBIZ-10782:
---

Removing affects versions except trunk because this is an improvement (no bug).

> Replace jQuery-Timepicker-Addon with flatpickr.js
> -
>
> Key: OFBIZ-10782
> URL: https://issues.apache.org/jira/browse/OFBIZ-10782
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> [jQuery-Timepicker-Addon|https://github.com/trentrichardson/jQuery-Timepicker-Addon]
>  seems to be a dead end now. Refer 
> [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955]
> As suggested in  
> [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955].
> [Flatpickr|https://github.com/flatpickr/flatpickr] seems a better 
> proposition. MIT license with a community of 158 contributors and 123 
> releases. A lightweight, powerful javascript datetimepicker with no 
> dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10782) Replace jQuery-Timepicker-Addon with flatpickr.js

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10782:
--
Affects Version/s: (was: Release Branch 18.12)

> Replace jQuery-Timepicker-Addon with flatpickr.js
> -
>
> Key: OFBIZ-10782
> URL: https://issues.apache.org/jira/browse/OFBIZ-10782
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Minor
>
> [jQuery-Timepicker-Addon|https://github.com/trentrichardson/jQuery-Timepicker-Addon]
>  seems to be a dead end now. Refer 
> [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955]
> As suggested in  
> [#955|https://github.com/trentrichardson/jQuery-Timepicker-Addon/issues/955].
> [Flatpickr|https://github.com/flatpickr/flatpickr] seems a better 
> proposition. MIT license with a community of 158 contributors and 123 
> releases. A lightweight, powerful javascript datetimepicker with no 
> dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283224#comment-17283224
 ] 

Michael Brohl commented on OFBIZ-10791:
---

[~sberg] can you please check the patch and try to apply it on lastest trunk / 
provide a pr? Thanks!

> Unable to add product (of ASSET_USAGE type) in order
> 
>
> Key: OFBIZ-10791
> URL: https://issues.apache.org/jira/browse/OFBIZ-10791
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Praveen Sharma
>Assignee: Sebastian Berg
>Priority: Major
>  Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, 
> SALES_RENTAL
> Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from 
> 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot 
> from 2019-03-09 11-06-36.png, asset-addtocart.png
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on order entry
>  # Set customer and click on continue
>  # Click continue on Enter Order Currency, Agreements, and Ship Dates page 
> (Please refer attachment: 2-Continue)
>  # Try to add product from Quick Lookup.
> Actual: Unable to add product for order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-10791:
-

Assignee: Sebastian Berg

> Unable to add product (of ASSET_USAGE type) in order
> 
>
> Key: OFBIZ-10791
> URL: https://issues.apache.org/jira/browse/OFBIZ-10791
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Praveen Sharma
>Assignee: Sebastian Berg
>Priority: Major
>  Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, 
> SALES_RENTAL
> Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from 
> 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot 
> from 2019-03-09 11-06-36.png, asset-addtocart.png
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
>  # Click on order entry
>  # Set customer and click on continue
>  # Click continue on Enter Order Currency, Agreements, and Ship Dates page 
> (Please refer attachment: 2-Continue)
>  # Try to add product from Quick Lookup.
> Actual: Unable to add product for order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10831) Re-reservation of Inventory Items when Ship Group Destination Address or Shipment Method is updated in Sales Order

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283219#comment-17283219
 ] 

Michael Brohl commented on OFBIZ-10831:
---

[~aditi17] [~vijayganeshb] Are you working on this? Can you provide a patch?
We are currently squashing bugs for the upcoming 18.12 release and it would 
help us getting this done.

> Re-reservation of Inventory Items when Ship Group Destination Address or 
> Shipment Method is updated in Sales Order
> --
>
> Key: OFBIZ-10831
> URL: https://issues.apache.org/jira/browse/OFBIZ-10831
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Vijay Ganesh
>Assignee: Aditi Patidar
>Priority: Major
> Attachments: image-2019-04-27-12-32-44-743.png, 
> image-2019-04-27-12-34-57-818.png, image-2019-04-27-12-46-52-368.png
>
>
> Hi,
> We came across this issue recently and also have fixed the same. 
> After creating a sales order and approving it, we created a shipment and 
> receive all the items and change the status to Packed. 
> Moving to the sales order edit screen. We are able to update the Ship Group 
> Destination Address or Shipment Method. Even without changing anything if we 
> simply click the update button, Inventory re-reservation service is being 
> called and getting re-reserved. Since there are no records in the 
> [OrderItemShipGrpInvRes|https://localhost:8443/webtools/control/FindGeneric?entityName=OrderItemShipGrpInvRes]
>  Entity, the inventory values are getting re-reserved again and this is a 
> major issue.
> For a Sales Order of quantity 10, after approving and creating a shipment, we 
> issue 10 items and change status to packed. Now we go to the Order View/Edit 
> Screen and update the shipment method/Address or simply click the update 
> button and the quantity in the Shipment for that order changes to 20 which 
> should not happen.
>  
> The fix we made is passing a hidden variable from the shipping Info Section 
> and when clicking the update button, we pass that value to the Inventory 
> Re-reservation event and check the value in that method.
> In the loadCartForUpdate method in OrderService.java, we pass the checkValue 
> to see whether this request is coming from the Shipping Information update 
> section and prevent the cancelOrderInventoryReservation service from calling.
> In the saveUpdatedCartToOrder method in OrderService.java using the same 
> checkValue, we prevent the reserveInventory service from calling. 
> This occurs when an existing shipment is in packed status for an order and 
> that order's shipping information needs to be edited.
> This was an issue in our case and we fixed this way.
> If it is ok we will provide the patch here?.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10845) Product Search Constraint on CountBy...methods

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283215#comment-17283215
 ] 

Michael Brohl commented on OFBIZ-10845:
---

[~akash.jain] Are you working on this? Can you provide a patch?
We are currently squashing bugs for the upcoming 18.12 release and it would 
help us getting this done.

> Product Search Constraint on CountBy...methods
> --
>
> Key: OFBIZ-10845
> URL: https://issues.apache.org/jira/browse/OFBIZ-10845
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, product
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Ingo Wolfmayr
>Assignee: Akash Jain
>Priority: Minor
>  Labels: search
> Fix For: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12
>
> Attachments: SearchCount.patch
>
>
> If a search constraint like featuresId or categorieId is applied, the 
> CountBy...methods in the ProductSearchSession fail.
> Error: mainProductId field is missing.
> Attached is a patch that fixes the problem.
> *Test:*
>  # Enable LayeredNavigation function in ecommerce module.
>  # Add feature "TEXT_BLACK" to product GZ-1000 as standard feature
>  # Add "ProductSearchSession.searchAddConstraint(new 
> ProductSearch.FeatureConstraint("TEXT_BLACK", true), session);" in 
> LayeredNavigation.groovy before "result = 
> ProductSearchSession.getProductSearchResult(request, delegator, 
> prodCatalogId);"
>  # Navigate to the product via category menu.
>  # --> GZ-1000 should not be visible + no error message



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10863) Field 'govAgencyPartyId' shows all parties, not just Government Agencies

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283212#comment-17283212
 ] 

Michael Brohl commented on OFBIZ-10863:
---

Removing affects versions except trunk because this is an improvement (no bug).

A role based filter would definetely be a valuable improvement, though. Are you 
working on this, [~priya.sharma.9362]  ?

> Field 'govAgencyPartyId' shows all parties, not just Government Agencies
> 
>
> Key: OFBIZ-10863
> URL: https://issues.apache.org/jira/browse/OFBIZ-10863
> Project: OFBiz
>  Issue Type: Improvement
>  Components: assetmaint
>Affects Versions: Release Branch 16.11, 16.11.04, 16.11.05, 16.11.06, 
> 17.12.01, Trunk
>Reporter: Pierre Smits
>Assignee: Priya Sharma
>Priority: Major
>  Labels: asset, registration
>
> The field govAgencyPartyId in the AddFixedAssetRegistration form shows all 
> parties through the 
> lookup target-form-name="LookupPartyName function.
> This should be limited to those parties that qualify with the constraint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10863) Field 'govAgencyPartyId' shows all parties, not just Government Agencies

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10863:
--
Affects Version/s: (was: 18.12.01)
   (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Field 'govAgencyPartyId' shows all parties, not just Government Agencies
> 
>
> Key: OFBIZ-10863
> URL: https://issues.apache.org/jira/browse/OFBIZ-10863
> Project: OFBiz
>  Issue Type: Improvement
>  Components: assetmaint
>Affects Versions: Release Branch 16.11, 16.11.04, 16.11.05, 16.11.06, 
> 17.12.01, Trunk
>Reporter: Pierre Smits
>Assignee: Priya Sharma
>Priority: Major
>  Labels: asset, registration
>
> The field govAgencyPartyId in the AddFixedAssetRegistration form shows all 
> parties through the 
> lookup target-form-name="LookupPartyName function.
> This should be limited to those parties that qualify with the constraint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10863) Field 'govAgencyPartyId' shows all parties, not just Government Agencies

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10863:
--
Issue Type: Improvement  (was: Bug)

> Field 'govAgencyPartyId' shows all parties, not just Government Agencies
> 
>
> Key: OFBIZ-10863
> URL: https://issues.apache.org/jira/browse/OFBIZ-10863
> Project: OFBiz
>  Issue Type: Improvement
>  Components: assetmaint
>Affects Versions: Release Branch 16.11, 16.11.04, 16.11.05, 16.11.06, 
> Release Branch 18.12, 18.12.01, Release Branch 17.12, 17.12.01, Trunk
>Reporter: Pierre Smits
>Assignee: Priya Sharma
>Priority: Major
>  Labels: asset, registration
>
> The field govAgencyPartyId in the AddFixedAssetRegistration form shows all 
> parties through the 
> lookup target-form-name="LookupPartyName function.
> This should be limited to those parties that qualify with the constraint.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10897) Have UI elements in play regarding agreement attributes

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283207#comment-17283207
 ] 

Michael Brohl commented on OFBIZ-10897:
---

Removing affects versions except trunk because this is an improvement (no bug).

> Have UI elements in play regarding agreement attributes
> ---
>
> Key: OFBIZ-10897
> URL: https://issues.apache.org/jira/browse/OFBIZ-10897
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Even though there are entity models related to agreement attributes there are 
> no associated UI elements (screen, form, template). To enhance the UX these 
> functionalities should be implemented.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-10901) Editable screens/forms are shown to user with only VIEW permissions

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283206#comment-17283206
 ] 

Michael Brohl edited comment on OFBIZ-10901 at 2/11/21, 5:19 PM:
-

This would be a great improvement for the user interface but it's not a bug.

Removing affects versions except trunk.


was (Author: mbrohl):
This would be a great improvement for the user interface but it's not a bug.

Removing affects versions except trunk

> Editable screens/forms are shown to user with only VIEW permissions
> ---
>
> Key: OFBIZ-10901
> URL: https://issues.apache.org/jira/browse/OFBIZ-10901
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: audit
>
> Edit screens should not be shown to users who have only VIEW permissions. 
> They should be shown only display screens. 
> When such a user is misled and enters data to change the record an error is 
> thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10901) Editable screens/forms are shown to user with only VIEW permissions

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283206#comment-17283206
 ] 

Michael Brohl commented on OFBIZ-10901:
---

This would be a great improvement for the user interface but it's not a bug.

Removing affects versions except trunk

> Editable screens/forms are shown to user with only VIEW permissions
> ---
>
> Key: OFBIZ-10901
> URL: https://issues.apache.org/jira/browse/OFBIZ-10901
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: audit
>
> Edit screens should not be shown to users who have only VIEW permissions. 
> They should be shown only display screens. 
> When such a user is misled and enters data to change the record an error is 
> thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10897) Have UI elements in play regarding agreement attributes

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10897:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Have UI elements in play regarding agreement attributes
> ---
>
> Key: OFBIZ-10897
> URL: https://issues.apache.org/jira/browse/OFBIZ-10897
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Priority: Major
>
> Even though there are entity models related to agreement attributes there are 
> no associated UI elements (screen, form, template). To enhance the UX these 
> functionalities should be implemented.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10901) Editable screens/forms are shown to user with only VIEW permissions

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10901:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Editable screens/forms are shown to user with only VIEW permissions
> ---
>
> Key: OFBIZ-10901
> URL: https://issues.apache.org/jira/browse/OFBIZ-10901
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: audit
>
> Edit screens should not be shown to users who have only VIEW permissions. 
> They should be shown only display screens. 
> When such a user is misled and enters data to change the record an error is 
> thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10901) Editable screens/forms are shown to user with only VIEW permissions

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10901?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10901:
--
Issue Type: Improvement  (was: Bug)

> Editable screens/forms are shown to user with only VIEW permissions
> ---
>
> Key: OFBIZ-10901
> URL: https://issues.apache.org/jira/browse/OFBIZ-10901
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: audit
>
> Edit screens should not be shown to users who have only VIEW permissions. 
> They should be shown only display screens. 
> When such a user is misled and enters data to change the record an error is 
> thrown.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10902) Have a status on agreement records

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283197#comment-17283197
 ] 

Michael Brohl commented on OFBIZ-10902:
---

Removing affects versions except trunk because this is an improvement (no bug).

> Have a status on agreement records
> --
>
> Key: OFBIZ-10902
> URL: https://issues.apache.org/jira/browse/OFBIZ-10902
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> h2. Pre-amble
> Currently, unlike many other entities, the Agreement entity does not have the 
> statusId field defined. Agreements, like the other entities, should have a 
> status (values that help determine the phase of the lifespan beyond the 
> start- and end date of the agreement), such as:
>  * Created
>  * In Progress
>  * Approved
>  * etc.
> h2. Flows
>  # Happy flows:
>  ## Happy flow a) created ->b) submitted (for review) -> c) reviewed -> d) 
> approved -> e) in effect -> f) concluded (ended)
>  ## Same, with more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) approved -> g) in effect -> h) 
> concluded (ended)
>  # Unhappy flows:
>  ## Unhappy flow: a) created ->b) submitted (for review) -> c) reviewed -> d) 
> cancelled
>  ## Same, whit more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) cancelled
>  # Prematurely ended flows:
>  ## Nipped in the bud flow a) created  -> b) cancelled
>  # flows from approval (in effect or in execution) till the end-of-times
>  ## a) approved -> b) in effect -> c) concluded (ended)
>  ## a) approved -> b) in effect -> c) terminated (prematurely ended)
> h2. Party Roles
> Following Party Roles are involved:
>  # Agreement Creator - the party (person) that creates, edit, updates and 
> submits the agreement for review
>  # Agreement Reviewer - the party (person) that reviews the agreement on its 
> merits and impact for the company/organisation
>  # Agreement Approver - the party (person) that, based on law, regulations 
> and/or business policies approves (or rejects) the agreement
>  # Agreement Manager - the party (person) that manages the execution of terms 
> of the agreement after the approval till the end-of-times
>  # Agreement Owner - the Party (party group with roleTypeId 
> INTERNAL_ORGANIZATIO, and  and registered in PartyAcctgPreference) that is 
> legally bound by the agreement
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10902) Have a status on agreement records

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10902:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)
   Trunk

> Have a status on agreement records
> --
>
> Key: OFBIZ-10902
> URL: https://issues.apache.org/jira/browse/OFBIZ-10902
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> h2. Pre-amble
> Currently, unlike many other entities, the Agreement entity does not have the 
> statusId field defined. Agreements, like the other entities, should have a 
> status (values that help determine the phase of the lifespan beyond the 
> start- and end date of the agreement), such as:
>  * Created
>  * In Progress
>  * Approved
>  * etc.
> h2. Flows
>  # Happy flows:
>  ## Happy flow a) created ->b) submitted (for review) -> c) reviewed -> d) 
> approved -> e) in effect -> f) concluded (ended)
>  ## Same, with more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) approved -> g) in effect -> h) 
> concluded (ended)
>  # Unhappy flows:
>  ## Unhappy flow: a) created ->b) submitted (for review) -> c) reviewed -> d) 
> cancelled
>  ## Same, whit more flow: a) created ->b) submitted (for review) -> c) 
> reviewed -> d) adjusted -> e) reviewed -> f) cancelled
>  # Prematurely ended flows:
>  ## Nipped in the bud flow a) created  -> b) cancelled
>  # flows from approval (in effect or in execution) till the end-of-times
>  ## a) approved -> b) in effect -> c) concluded (ended)
>  ## a) approved -> b) in effect -> c) terminated (prematurely ended)
> h2. Party Roles
> Following Party Roles are involved:
>  # Agreement Creator - the party (person) that creates, edit, updates and 
> submits the agreement for review
>  # Agreement Reviewer - the party (person) that reviews the agreement on its 
> merits and impact for the company/organisation
>  # Agreement Approver - the party (person) that, based on law, regulations 
> and/or business policies approves (or rejects) the agreement
>  # Agreement Manager - the party (person) that manages the execution of terms 
> of the agreement after the approval till the end-of-times
>  # Agreement Owner - the Party (party group with roleTypeId 
> INTERNAL_ORGANIZATIO, and  and registered in PartyAcctgPreference) that is 
> legally bound by the agreement
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10914) Fitering on StatusId in FindTask does not work

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283196#comment-17283196
 ] 

Michael Brohl commented on OFBIZ-10914:
---

[~deepak] any chance to get this committed and backported? 

We are currently squashing bugs for the upcoming 18.12 release and it would 
help us getting this done.

Thanks!

> Fitering on StatusId in FindTask does not work
> --
>
> Key: OFBIZ-10914
> URL: https://issues.apache.org/jira/browse/OFBIZ-10914
> Project: OFBiz
>  Issue Type: Bug
>  Components: projectmgr
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: OFBIZ-10914.patch
>
>
> Filtering on one of the available status options (statusId) does not yield 
> the expected result. 
> To reproduce:
>  # go to [https://demo-stable.ofbiz.apache.org/projectmgr/control/FindTask]
>  # select one of the status options, e.g. Created
>  # see appropriate list of tasks
> Actual result (with selected status option Created):
> Overview shows tasks with statusId = Created PLUS the tasks with status In 
> Progress



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10923) Simplify folder structure regarding report designs

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10923:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Simplify folder structure regarding report designs
> --
>
> Key: OFBIZ-10923
> URL: https://issues.apache.org/jira/browse/OFBIZ-10923
> Project: OFBiz
>  Issue Type: Improvement
>  Components: birt
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
> Attachments: OFBIZ-10923-birt.patch, 
> OFBIZ-10923-ofbiz-plugins-birt.patch, OFBIZ-10923-plugings-birth.diff
>
>
> Currently the report designs in the Birt component are nested within webapp 
> subfolders. The folder structure for the designs should follow the convention 
> for Freemarker templates and Groovy scripts.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10931) Improve the selection of the parent period for CustomTimePeriod update

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283191#comment-17283191
 ] 

Michael Brohl commented on OFBIZ-10931:
---

Removing affects versions except trunk because this is an improvement (no bug).

> Improve the selection of the parent period for CustomTimePeriod update
> --
>
> Key: OFBIZ-10931
> URL: https://issues.apache.org/jira/browse/OFBIZ-10931
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently in the overviews of Edit Custom Time Periods screen (see [1]) the 
> user can select a parent period for any given period record. This is done 
> through a drop down widget from EditCustomTimePeriod.ftl
> The construct for the values shown is: 
>  # the organisationPartyId, 
>  # the periodTypeId, and 
>  # the periodNum
>  # the customPeriodId
> The page shows the drop-down values as following examples:
>  * Company Fiscal Quarter: 2 [6011]
>  
>  * Company Fiscal Quarter: 3 [6012]
>  * Company Fiscal Quarter: 5 [6014]
>  * Company Fiscal Quarter: 2 [6016]
>  * Company Fiscal Quarter: 3 [6017]
>  * Company Fiscal Year: 1 [6010]
>  * Company Fiscal Year: 1 [6015]
> As can be observed, the information provided is confusing. And when the 
> number of periods to select from gets long (consider the hierarchy: 
> month-quarter-year) it is easy to make mistakes. 
> Furthermore, given that there is a hierarchy between periods, it should not 
> be possible to select a period that is outside the higher order. Meaning 
> there is a FISCAL_MONTH defined for say fromDate=2019-03-01 and thruDate = 
> 2019-03-31, then It can not belong to a FISCAL_YEAR that either ends before 
> the fromDate of the FISCAL_MONTH period or start after the thruDate of the 
> FISCAL_MONTH.
>  
>  
>  
> [1] 
> https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10931) Improve the selection of the parent period for CustomTimePeriod update

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-10931:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Improve the selection of the parent period for CustomTimePeriod update
> --
>
> Key: OFBIZ-10931
> URL: https://issues.apache.org/jira/browse/OFBIZ-10931
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: CustomTimePeriod
>
> Currently in the overviews of Edit Custom Time Periods screen (see [1]) the 
> user can select a parent period for any given period record. This is done 
> through a drop down widget from EditCustomTimePeriod.ftl
> The construct for the values shown is: 
>  # the organisationPartyId, 
>  # the periodTypeId, and 
>  # the periodNum
>  # the customPeriodId
> The page shows the drop-down values as following examples:
>  * Company Fiscal Quarter: 2 [6011]
>  
>  * Company Fiscal Quarter: 3 [6012]
>  * Company Fiscal Quarter: 5 [6014]
>  * Company Fiscal Quarter: 2 [6016]
>  * Company Fiscal Quarter: 3 [6017]
>  * Company Fiscal Year: 1 [6010]
>  * Company Fiscal Year: 1 [6015]
> As can be observed, the information provided is confusing. And when the 
> number of periods to select from gets long (consider the hierarchy: 
> month-quarter-year) it is easy to make mistakes. 
> Furthermore, given that there is a hierarchy between periods, it should not 
> be possible to select a period that is outside the higher order. Meaning 
> there is a FISCAL_MONTH defined for say fromDate=2019-03-01 and thruDate = 
> 2019-03-31, then It can not belong to a FISCAL_YEAR that either ends before 
> the fromDate of the FISCAL_MONTH period or start after the thruDate of the 
> FISCAL_MONTH.
>  
>  
>  
> [1] 
> https://demo-stable.ofbiz.apache.org/accounting/control/EditCustomTimePeriod



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10970) Issue with email validation

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10970?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283190#comment-17283190
 ] 

Michael Brohl commented on OFBIZ-10970:
---

[~nitish.mishra] Are you working on this? Can you provide a patch? 
We are currently squashing bugs for the upcoming 18.12 release and it would 
help us getting this done.

Thanks!

> Issue with email validation
> ---
>
> Key: OFBIZ-10970
> URL: https://issues.apache.org/jira/browse/OFBIZ-10970
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Nitish Mishra
>Priority: Major
>
> Steps to regenerate:
>  # Open URL [https://demo-stable.ofbiz.apache.org/ecommerce/control/main]
>  # Click on any item
>  # Click on "Tell a friend"
>  # Enter invalid email
>  # Enter message
>  # Click on send
> Actual: Able to send a message
> Expected: Email validation should be applied.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11016) Setting 'Payment (net days)' term does not update 'due date' of invoice

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283187#comment-17283187
 ] 

Michael Brohl commented on OFBIZ-11016:
---

[~Kumar Rahul] are you working on a fix for this? We are currently squashing 
bugs for the upcoming 18.12 release and it would help us getting this done.

Thanks!

> Setting 'Payment (net days)'  term does not update 'due date' of invoice
> 
>
> Key: OFBIZ-11016
> URL: https://issues.apache.org/jira/browse/OFBIZ-11016
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Kumar Rahul
>Priority: Major
>  Labels: Payable, invoice, payments, receivable
> Attachments: Accounting-AR.png, Find AR Invoices.png, Invoice .png, 
> Screen Shot 2019-05-09 at 10.10.31.png, Screen Shot 2019-05-09 at 
> 10.10.55.png, Screen Shot 2019-09-10 at 10.23.41.png, Screen Shot 2019-09-10 
> at 10.24.04.png, Screenshot from 2019-09-28 17-13-36.png
>
>
> When setting the 'Payment (net days) ' terms, and setting the number of days, 
> the due date of the invoice does not get updated. 
> As a result the overviews for Accounts Payable and Accounts Receivable show 
> incorrect results.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11037) Improve PartyAcctgPrefAndGroup to reflect all fields from the PartyAcctgPreference entity

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11037:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Improve PartyAcctgPrefAndGroup to reflect all fields from the 
> PartyAcctgPreference entity
> -
>
> Key: OFBIZ-11037
> URL: https://issues.apache.org/jira/browse/OFBIZ-11037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>  Labels: internalOrganisation, view
> Attachments: OFBIZ-11037-Party.patch.diff
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11037) Improve PartyAcctgPrefAndGroup to reflect all fields from the PartyAcctgPreference entity

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11037:
--
Priority: Minor  (was: Major)

> Improve PartyAcctgPrefAndGroup to reflect all fields from the 
> PartyAcctgPreference entity
> -
>
> Key: OFBIZ-11037
> URL: https://issues.apache.org/jira/browse/OFBIZ-11037
> Project: OFBiz
>  Issue Type: Improvement
>  Components: party
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Minor
>  Labels: internalOrganisation, view
> Attachments: OFBIZ-11037-Party.patch.diff
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11080) View-entity: show entities and their relations the view is composed of

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11080:
--
Summary: View-entity: show entities and their relations the view is 
composed of  (was: View-entity does not show relations to underlying entities)

> View-entity: show entities and their relations the view is composed of
> --
>
> Key: OFBIZ-11080
> URL: https://issues.apache.org/jira/browse/OFBIZ-11080
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: engine, entity, views
>
> View entities don't show the relations to underlying source entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11080) View-entity does not show relations to underlying entities

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11080:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> View-entity does not show relations to underlying entities
> --
>
> Key: OFBIZ-11080
> URL: https://issues.apache.org/jira/browse/OFBIZ-11080
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: engine, entity, views
>
> View entities don't show the relations to underlying source entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11080) View-entity does not show relations to underlying entities

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11080:
--
Priority: Minor  (was: Major)

> View-entity does not show relations to underlying entities
> --
>
> Key: OFBIZ-11080
> URL: https://issues.apache.org/jira/browse/OFBIZ-11080
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Pierre Smits
>Priority: Minor
>  Labels: engine, entity, views
>
> View entities don't show the relations to underlying source entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11080) View-entity does not show relations to underlying entities

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11080:
--
Issue Type: Improvement  (was: Bug)

> View-entity does not show relations to underlying entities
> --
>
> Key: OFBIZ-11080
> URL: https://issues.apache.org/jira/browse/OFBIZ-11080
> Project: OFBiz
>  Issue Type: Improvement
>  Components: datamodel
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: engine, entity, views
>
> View entities don't show the relations to underlying source entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11080) View-entity does not show relations to underlying entities

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283181#comment-17283181
 ] 

Michael Brohl commented on OFBIZ-11080:
---

I think this is not a bug. A view is a virtual entity which is composed out of 
sevareal other entities (which are related to each other).

The view itself does not have a relation to other entities, hence there is 
nothing shown in the relationship view.

While I agree that it would be nice to see the entities/relations from which 
the view is composed as an *improvement*, I do not see it being a bug.

Changing to improvement and removing the affects versions to trunk only.

> View-entity does not show relations to underlying entities
> --
>
> Key: OFBIZ-11080
> URL: https://issues.apache.org/jira/browse/OFBIZ-11080
> Project: OFBiz
>  Issue Type: Bug
>  Components: datamodel
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch 
> 17.12, Trunk
>Reporter: Pierre Smits
>Priority: Major
>  Labels: engine, entity, views
>
> View entities don't show the relations to underlying source entities.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11096) ShoppingCart's autoUserLogin does not got reinitialized when user tries to logout using ecommerce's autoLogout

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283171#comment-17283171
 ] 

Michael Brohl commented on OFBIZ-11096:
---

[~deepa.barfa] [~pawan] are you working on this issue? We are currently 
squashing bugs for the upcoming 18.12 release and this one is affecting it.

Thanks!

> ShoppingCart's autoUserLogin does not got reinitialized when user tries to 
> logout using ecommerce's autoLogout
> --
>
> Key: OFBIZ-11096
> URL: https://issues.apache.org/jira/browse/OFBIZ-11096
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pawan Verma
>Assignee: Deepa Barfa
>Priority: Major
>
> Steps to regenerate:
> 1. Login into e-commerce application with any user(I've used DemoCustomer)
> 2. Browse the website and/or wait till the session become ideal.
> 3. The system will set userLogin to ShoppingCart's autoUserLogin, which is 
> actually correct behavior.
> 4. Now, when user logout from the Logout button session and ShoppingCart's 
> autoUserLogin got reinitialized.
> 5. But when the user tries to Logout using *Not You?  Click Here(autoLogout)* 
> link only session got reinitialized,  ShoppingCart's autoUserLogin does not 
> get reinitialized.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11110) Able to add phone no. as contact type without adding number

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-0?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283165#comment-17283165
 ] 

Michael Brohl commented on OFBIZ-0:
---

[~jleroux] [~pawan] is this really to be classified as a bug?

I do not see a problem to add an empty telecom number (or wipe an existing 
one). It would be a bug if the empty number breaks some other functionality but 
this is not reported.

What do you think?

> Able to add phone no. as contact type without adding number
> ---
>
> Key: OFBIZ-0
> URL: https://issues.apache.org/jira/browse/OFBIZ-0
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Rashi Dhagat
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: OFBIZ-0.patch
>
>
> Steps to regenerate:
>  # Open url 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/viewprofile]
>  # Click on "Create new" in Contact Information section
>  # Select phone no as contact type
>  # Click on Create
>  # Click on Save
> Actual: Able to add phone no as contact type without adding no.
> Expected: Error message should be displayed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11120) Issue while creating an order for product of type (Fixed) Asset Usage

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283157#comment-17283157
 ] 

Michael Brohl commented on OFBIZ-11120:
---

[~amit.gadaley] are you working on this? Will you provide a patch?

Thanks!

> Issue while creating an order for product of type (Fixed) Asset Usage
> -
>
> Key: OFBIZ-11120
> URL: https://issues.apache.org/jira/browse/OFBIZ-11120
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Vedansh Tiwari
>Assignee: Amit Gadaley
>Priority: Major
>  Labels: asset
> Attachments: ProductAO03.png, ProductAO04.png, ProductAO1.png, 
> ProductAO2.png
>
>
> Steps to regenerate
>  # Login to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
>  # Click on the product lookup icon
>  # Click on the "Find" button
>  # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
>  # Click on "Add to order" button             
> Actual: Error message "The following occurred: Enter Booking Information 
> Before Adding to Cart" is showing. Please refer the attachment: ProductAO1.jpg
> Expected: Error message should be corrected
>  
> Issue 2: 
> Steps to regenerate:
>  # Login to URL: 
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/additem]
>  # Click on the product lookup icon
>  # Click on the "Find" button
>  # Select the "(Fixed) Asset Usage" product  (FORKLIFT_PROPANE)
>  # Click on "Add to order" button 
>  # Select the date and time
>  # Click on the "Add to cart"
>  # Again click on the product look-up for selecting the product.
>               
>  Actual: UI issue on the model. Please refer the attachment: ProductAO04
>  
> Note: please refer the attachment.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11181) paymentMethodId choices wrong in form for creating/editing a received payment

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283155#comment-17283155
 ] 

Michael Brohl commented on OFBIZ-11181:
---

Hi [~jleroux]  are you going to work on this (just celaning up for the 18.12 
release).

> paymentMethodId choices wrong in form for creating/editing a received payment
> -
>
> Key: OFBIZ-11181
> URL: https://issues.apache.org/jira/browse/OFBIZ-11181
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
> Environment: Ofbiz 16.11.05 on Fedora 30 with OpenJDK 64-Bit Server 
> VM (build 25.222-b10, mixed mode) and mariadb-server.x86_64 3:10.3.17-1.fc30 
> as database
>Reporter: Parminder
>Assignee: Jacques Le Roux
>Priority: Major
>
> {color:#737373}There is a bug in the forms   for 
> Payment{color}{color:#737373} method field(drop down) for Incoming payment. 
> Payment methods should be{color}
> {color:#737373} whatever is  defined for getting the payments from customers 
> like  {color}{color:#737373}Company Check, Cash etc. etc. but it is showing 
> the methods which are{color}{color:#737373} applicable for outgoing payments 
> such as Petty cash and defined{color}{color:#737373} Financial accounts (from 
> where you pay the suppliers).{color}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11188) Forgot Password feature in ecommerce needs an access to partymngr

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283154#comment-17283154
 ] 

Michael Brohl commented on OFBIZ-11188:
---

Removing release branches as this is an improvement.

> Forgot Password feature in ecommerce needs an access to partymngr
> -
>
> Key: OFBIZ-11188
> URL: https://issues.apache.org/jira/browse/OFBIZ-11188
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> As Pierre Smits initially reported in OFBIZ-4361
> bq. another issue is that to change their passwords ecommerce clients need to 
> get access to partymngr.  I think that's not secure enough and restriction of 
> the possible actions (eg only allowed to reset password) would be a good 
> idea...
> It should be noted that it was already like that before OFBIZ-4361



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11188) Forgot Password feature in ecommerce needs an access to partymngr

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11188:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)

> Forgot Password feature in ecommerce needs an access to partymngr
> -
>
> Key: OFBIZ-11188
> URL: https://issues.apache.org/jira/browse/OFBIZ-11188
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Release 
> Branch 15.12, Release Branch 16.11, Trunk
>Reporter: Jacques Le Roux
>Priority: Major
>
> As Pierre Smits initially reported in OFBIZ-4361
> bq. another issue is that to change their passwords ecommerce clients need to 
> get access to partymngr.  I think that's not secure enough and restriction of 
> the possible actions (eg only allowed to reset password) would be a good 
> idea...
> It should be noted that it was already like that before OFBIZ-4361



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11202) Issue in validating date of format yyyy-MM-dd'T'HH:mm:ss

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283151#comment-17283151
 ] 

Michael Brohl commented on OFBIZ-11202:
---

[~lalit.dashora]  can you please give us more information about this problem or 
provide a patch?

If we get no response I'd close this issue in a week. Thanks!

> Issue in validating date of format -MM-dd'T'HH:mm:ss
> 
>
> Key: OFBIZ-11202
> URL: https://issues.apache.org/jira/browse/OFBIZ-11202
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Michael Brohl
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11202) Issue in validating date of format yyyy-MM-dd'T'HH:mm:ss

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-11202:
-

Assignee: Michael Brohl  (was: Lalit Dashora)

> Issue in validating date of format -MM-dd'T'HH:mm:ss
> 
>
> Key: OFBIZ-11202
> URL: https://issues.apache.org/jira/browse/OFBIZ-11202
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release 
> Branch 17.12, Trunk
>Reporter: Lalit Dashora
>Assignee: Michael Brohl
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11234) Invoice status fails to update after payment application

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283146#comment-17283146
 ] 

Michael Brohl commented on OFBIZ-11234:
---

[~harman.kaur] [~plehal] is this being worked on? Can you provide a patch or PR 
for this issue?

Thanks!

> Invoice status fails to update after payment application
> 
>
> Key: OFBIZ-11234
> URL: https://issues.apache.org/jira/browse/OFBIZ-11234
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
> Environment: Ofbiz 16.11.06
> Database Mariadb
>  
>Reporter: Parminder
>Assignee: Harman kaur Matharu
>Priority: Major
>  Labels: invoice
>
> The invoice status fails to change (to paid etc.) after applying payment to 
> it.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11333) Cookie Consent In E-Commerce

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11333.
-
Fix Version/s: 17.12.03
   Upcoming Branch
   18.12.01
   Resolution: Implemented

> Cookie Consent In E-Commerce
> 
>
> Key: OFBIZ-11333
> URL: https://issues.apache.org/jira/browse/OFBIZ-11333
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Deepak Nigam
>Assignee: Aditya Sharma
>Priority: Minor
>  Labels: compliance, law
> Fix For: 18.12.01, Upcoming Branch, 17.12.03
>
>
> This ticket has been cloned from OFBIZ-10639: in the original ticket the work 
> was completed and committed only to the Release Branch 16.11; this new ticket 
> has been created to implement a solution for the other branches.
> =
> As per discussion on Dev ML [https://markmail.org/message/rcatehtckz6vlvuv] 
> The Cookie Law is a piece of privacy legislation that requires websites to 
> get consent from visitors to store or retrieve any information on their 
> computer, smartphone or tablet. It was designed to protect online privacy, by 
> making consumers aware of how information about them is collected and used 
> online, and give them a choice to allow it or not. 
>   
>  The EU Cookie Legislation began as a directive from the European Union. Some 
> variation on the policy has since been adopted by all countries within the EU.
>   
>  The EU Cookie Legislation requires 4 actions from website owners who use 
> cookies:
>  1. When someone visits your website, you need to let them know that your 
> site uses cookies. 
>  2. You need to provide detailed information regarding how that cookie data 
> will be utilized. 
>  3. You need to provide visitors with some means of accepting or refusing the 
> use of cookies in your site. 
>  4. If they refuse, you need to ensure that cookies will not be placed on 
> their machine.
>  
>  For more information about EU cookie policy, please visit 
> [here|http://ec.europa.eu/ipg/basics/legal/cookies/index_en.htm].
>   
>  As this crucial feature is missing in OFBiz E-Commerce application, we 
> should work towards its implementation. There are numerous open-source jQuery 
> plugins available which we can use.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11467) Missing map files for 3rd party javascript libraries

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl closed OFBIZ-11467.
-
Resolution: Not A Problem

I cannot reproduce either in latest Firefox, closing.

> Missing map files for 3rd party javascript libraries
> 
>
> Key: OFBIZ-11467
> URL: https://issues.apache.org/jira/browse/OFBIZ-11467
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Screen Shot 2020-03-21 at 10.51.16.png, Screen Shot 
> 2020-03-21 at 10.51.49.png
>
>
> Mozilla browser debugger shows following errors:
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: https://localhost:8443/common/js/plugins/OpenLayers-5.3.0.js
> Source Map URL: ol.js.map
> {code}
> and
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: 
> https://localhost:8443/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js
> Source Map URL: jquery.jgrowl.map
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11467) Missing map files for 3rd party javascript libraries

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl reassigned OFBIZ-11467:
-

Assignee: Michael Brohl

> Missing map files for 3rd party javascript libraries
> 
>
> Key: OFBIZ-11467
> URL: https://issues.apache.org/jira/browse/OFBIZ-11467
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Pierre Smits
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Screen Shot 2020-03-21 at 10.51.16.png, Screen Shot 
> 2020-03-21 at 10.51.49.png
>
>
> Mozilla browser debugger shows following errors:
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: https://localhost:8443/common/js/plugins/OpenLayers-5.3.0.js
> Source Map URL: ol.js.map
> {code}
> and
> {code}
> Source map error: Error: request failed with status 404
> Resource URL: 
> https://localhost:8443/common/js/jquery/plugins/jquery-jgrowl/jquery.jgrowl-1.4.6.min.js
> Source Map URL: jquery.jgrowl.map
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11680) ViewQuoteProfit shows fields in wrong order

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283129#comment-17283129
 ] 

Michael Brohl commented on OFBIZ-11680:
---

Hi [~surajk],

will you handle this for trunk and the backports? We are trying to crush bugs 
for the upcoming 18.12 release.

Thanks!

 

> ViewQuoteProfit shows fields in wrong order
> ---
>
> Key: OFBIZ-11680
> URL: https://issues.apache.org/jira/browse/OFBIZ-11680
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
>  Labels: quote
> Attachments: OFBIZ-11680.patch, Screen Shot 2020-05-09 at 10.40.39.png
>
>
> See attached image.
> Total amount (of the quote) should be before total cost.
> On line items,  the quoteUnitPrice should be before averageCost



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11682) ListAgreementItemSupplierProducts doesn't show products

2021-02-11 Thread Michael Brohl (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283128#comment-17283128
 ] 

Michael Brohl commented on OFBIZ-11682:
---

Removed PR references as they are all closed and need rework.

> ListAgreementItemSupplierProducts doesn't show products
> ---
>
> Key: OFBIZ-11682
> URL: https://issues.apache.org/jira/browse/OFBIZ-11682
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>
> The products applied to a purchase agreement doesn't get shown in the 
> ListAgreementItemSupplierProducts overview.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11074) Have a service to load records in the sales channel dimension

2021-02-11 Thread Michael Brohl (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Brohl updated OFBIZ-11074:
--
Affects Version/s: (was: Release Branch 18.12)
   (was: Release Branch 17.12)
   Trunk

> Have a service to load records in the sales channel dimension
> -
>
> Key: OFBIZ-11074
> URL: https://issues.apache.org/jira/browse/OFBIZ-11074
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: SalesChannel, SalesChannelDimension, birt, dwh, 
> initialisation, service
>
> For dwh initialisation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   >