[jira] [Commented] (OFBIZ-10863) Field 'govAgencyPartyId' shows all parties, not just Government Agencies
[ https://issues.apache.org/jira/browse/OFBIZ-10863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284091#comment-17284091 ] Priya Sharma commented on OFBIZ-10863: -- Thanks for the update Micheal, I will provide a PR for the improvement. > Field 'govAgencyPartyId' shows all parties, not just Government Agencies > > > Key: OFBIZ-10863 > URL: https://issues.apache.org/jira/browse/OFBIZ-10863 > Project: OFBiz > Issue Type: Improvement > Components: assetmaint >Affects Versions: Release Branch 16.11, 16.11.04, 16.11.05, 16.11.06, > 17.12.01, Trunk >Reporter: Pierre Smits >Assignee: Priya Sharma >Priority: Major > Labels: asset, registration > > The field govAgencyPartyId in the AddFixedAssetRegistration form shows all > parties through the > lookup target-form-name="LookupPartyName function. > This should be limited to those parties that qualify with the constraint. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12171) Handling the JCenter shutdown
[ https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284006#comment-17284006 ] Michael Brohl edited comment on OFBIZ-12171 at 2/12/21, 10:11 PM: -- I solved the conflict by adding a runtimeOnly dependency to log4j-jcl. All tests pass now on my side. Can someone confirm? was (Author: mbrohl): I solved the conclict by adding a runtimeOnly dependency to log4j-jcl. All tests pass now on my side. Can someone confirm? > Handling the JCenter shutdown > - > > Key: OFBIZ-12171 > URL: https://issues.apache.org/jira/browse/OFBIZ-12171 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > Citing Taher's message at [2]: > Hello Everyone, > > I received emails and checked resources [1] that seem to confirm JCenter from > JFrog is going down and that the last day of operation for the repository is > going to be May 1st 2021. > > This is a big deal as many running instances will crash unless updated, so > not only do future versions of OFBiz need to adapt, but also existing > installations. > > I'm not sure how to best handle this? Especially for production instances out > there on older versions of OFBiz. Maybe one solution is to host the existing > libraries in some temporary location or try to migrate them to MavenCentral > ... Whatever is the solution I think we should make a fast move. > > [1] > [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter] > > [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure] > [2] > [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown
[ https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284016#comment-17284016 ] Michael Brohl commented on OFBIZ-12171: --- The PR for framework will only work together with the corresponding PR for the plugins. > Handling the JCenter shutdown > - > > Key: OFBIZ-12171 > URL: https://issues.apache.org/jira/browse/OFBIZ-12171 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > Citing Taher's message at [2]: > Hello Everyone, > > I received emails and checked resources [1] that seem to confirm JCenter from > JFrog is going down and that the last day of operation for the repository is > going to be May 1st 2021. > > This is a big deal as many running instances will crash unless updated, so > not only do future versions of OFBiz need to adapt, but also existing > installations. > > I'm not sure how to best handle this? Especially for production instances out > there on older versions of OFBiz. Maybe one solution is to host the existing > libraries in some temporary location or try to migrate them to MavenCentral > ... Whatever is the solution I think we should make a fast move. > > [1] > [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter] > > [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure] > [2] > [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] mbrohl commented on pull request #270: Improved: Switch from jCenter to mavenCentral to handle the jCenter shutdown (OFBIZ-12171)
mbrohl commented on pull request #270: URL: https://github.com/apache/ofbiz-framework/pull/270#issuecomment-778482264 Ah, I see. This is a problem which is fixed in the ldap plugin but the fix is not available for this build because it is not committed to the official repo yet. Please check with both PR's for plugins and framework. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #270: Improved: Switch from jCenter to mavenCentral to handle the jCenter shutdown (OFBIZ-12171)
sonarcloud[bot] removed a comment on pull request #270: URL: https://github.com/apache/ofbiz-framework/pull/270#issuecomment-776331662 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=270=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=270=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=270=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=270) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=270=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #270: Improved: Switch from jCenter to mavenCentral to handle the jCenter shutdown (OFBIZ-12171)
sonarcloud[bot] commented on pull request #270: URL: https://github.com/apache/ofbiz-framework/pull/270#issuecomment-778479105 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=270=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=270=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=270=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=270=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=270) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=270=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] mbrohl commented on pull request #270: Improved: Switch from jCenter to mavenCentral to handle the jCenter shutdown (OFBIZ-12171)
mbrohl commented on pull request #270: URL: https://github.com/apache/ofbiz-framework/pull/270#issuecomment-778478904 Strange, this worked on my side now, will check again... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown
[ https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284006#comment-17284006 ] Michael Brohl commented on OFBIZ-12171: --- I solved the conclict by adding a runtimeOnly dependency to log4j-jcl. All tests pass now on my side. Can someone confirm? > Handling the JCenter shutdown > - > > Key: OFBIZ-12171 > URL: https://issues.apache.org/jira/browse/OFBIZ-12171 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > Citing Taher's message at [2]: > Hello Everyone, > > I received emails and checked resources [1] that seem to confirm JCenter from > JFrog is going down and that the last day of operation for the repository is > going to be May 1st 2021. > > This is a big deal as many running instances will crash unless updated, so > not only do future versions of OFBiz need to adapt, but also existing > installations. > > I'm not sure how to best handle this? Especially for production instances out > there on older versions of OFBiz. Maybe one solution is to host the existing > libraries in some temporary location or try to migrate them to MavenCentral > ... Whatever is the solution I think we should make a fast move. > > [1] > [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter] > > [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure] > [2] > [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E] > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #57: Ofbiz 11756 vue js renderer
sonarcloud[bot] commented on pull request #57: URL: https://github.com/apache/ofbiz-plugins/pull/57#issuecomment-778302411 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=57=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=57=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=57=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=CODE_SMELL) [220 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=57=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=57) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=57=new_duplicated_lines_density=list) [3.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=57=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] Olivier-Heintz commented on pull request #57: Ofbiz 11756 vue js renderer
Olivier-Heintz commented on pull request #57: URL: https://github.com/apache/ofbiz-plugins/pull/57#issuecomment-778300381 there are some related comments on [PR#27](https://github.com/apache/ofbiz-plugins/pull/27) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] Olivier-Heintz opened a new pull request #57: Ofbiz 11756 vue js renderer
Olivier-Heintz opened a new pull request #57: URL: https://github.com/apache/ofbiz-plugins/pull/57 Implemented: add plugins to have ofbiz components usable with the vuejs renderer (OFBIZ-11756) Explanation 4 new addons: vuejs, themefrontjs, examplefjs and partyfjs to be able to have a complete usage of vuejs renderer (included in vuejs plugin) This PR is to demonstrate frontjs renderer and vuejs implementation, to easily discuss on technical choices Thanks: to Julien Bachelier for Vue.Js code in vuejs plugin This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] Olivier-Heintz closed pull request #27: OFBIZ-11756 vue js renderer
Olivier-Heintz closed pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283798#comment-17283798 ] Michael Brohl commented on OFBIZ-6510: -- Ok, this IMO warrants a new issue to add relations to the XML output too. The entity relations and foreign key constraints are an important part of the database model. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283789#comment-17283789 ] Benjamin Jugl commented on OFBIZ-6510: -- You are right, the relations should be contained. But I think this never worked. The .jsp did iterate over the relations and ModelEntity.toXmlElement() does this as well. Problem is, that the ModelEntities are generated using a constructor that does not initialize the Relations. This was used in the old version as well as in this one. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
[
https://issues.apache.org/jira/browse/OFBIZ-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283778#comment-17283778
]
Rajesh Kumar commented on OFBIZ-12143:
--
Great [~deepak],
Though I have created altogether a new lookup for this, now I have changed it
per your solution
Thanks
> Incorrect mapping for Lookup Purchase Order
>
>
> Key: OFBIZ-12143
> URL: https://issues.apache.org/jira/browse/OFBIZ-12143
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> Trunk, 17.12.05
> Environment: All
>Reporter: Rajesh Kumar
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: image-2021-01-19-02-43-58-567.png
>
>
> Lookup screen for {color:#33}Purchase Order Header and Ship Info{color}
> has {color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list.
> This mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
> paginate-target due to this pagination buttons are failing when result has
> multiple pages.
>
> This can be fixed by adding a new form as
> {color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
> {color:#032f62}filename: {color}
> *applications\order\widget\ordermgr\LookupScreens.xml*
>
> {color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-plugins] Olivier-Heintz commented on pull request #27: OFBIZ-11756 vue js renderer
Olivier-Heintz commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778264215 Thank you Michael for your remarks. This PR is to show what is working but clearly, not yet ready to be merge. I will try to create a "draft pull request". PS: Currently, my knowledge of vuejs is not enough to remove all duplicate lines ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #27: OFBIZ-11756 vue js renderer
sonarcloud[bot] removed a comment on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778230641 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [8 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [216 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list) [3.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778253843 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [220 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list) [3.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] mbrohl commented on pull request #27: OFBIZ-11756 vue js renderer
mbrohl commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778239041 If you want to show that this is a draft PR which is not finished yet to be reviewed and merged, you can also specify a "draft pull request". I did not find a way to specify this afterwards so you might need to provide a new PR instead. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-11350) Checkstyle improvements
[
https://issues.apache.org/jira/browse/OFBIZ-11350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283738#comment-17283738
]
Wiebke Pätzold commented on OFBIZ-11350:
Hi [~jleroux],
I did a little research on the Checkstyle rules for the parentheses and I think
it is only possible to completely allow '(' at the beginning of a line. I did
not find a way to specify this only for type cast.
So maybe it is better to store the type cast in a variable before.
> Checkstyle improvements
> ---
>
> Key: OFBIZ-11350
> URL: https://issues.apache.org/jira/browse/OFBIZ-11350
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
>
> This is an umbrella task for checkstyle improvements.
> See related discussion on the dev mailinglist:
> https://lists.apache.org/thread.html/rf417d7b136eda217916483592f7e072184a0687babfe7f0b74bf820e%40%3Cdev.ofbiz.apache.org%3E
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-plugins] mbrohl commented on pull request #27: OFBIZ-11756 vue js renderer
mbrohl commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778237015 @Olivier-Heintz This PR seems to be problematic in several aspects: - there is too much code duplication, see sonarcloud analysis. Please try to avoid copied inline functions and write them in separate function to reuse them - the commits do not follow the commit message template (Fixed:, Improved: etc.) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10308) Financial account transaction --> accounting transaction
[ https://issues.apache.org/jira/browse/OFBIZ-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283730#comment-17283730 ] Wiebke Pätzold commented on OFBIZ-10308: [~mbrohl] I applied the patch and made a PR from it. > Financial account transaction --> accounting transaction > > > Key: OFBIZ-10308 > URL: https://issues.apache.org/jira/browse/OFBIZ-10308 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 13.07, Release Branch 14.12, Release > Branch 15.12, Release Branch 16.11, Release Branch 18.12, Release Branch > 17.12, Trunk >Reporter: Ingo Wolfmayr >Assignee: Wiebke Pätzold >Priority: Major > Attachments: ofbiz.patch > > > When creating a financial account transaction some of the accounting > transaction are in the wrong direction. > 1) Withdraw 10$: > DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other > Consulting Fees (10$) > 2) Debit 10$: > *DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other > Consulting Fees (10$) (WRONG)* > 3) Adjustment +10$: > DEBIT 00 General Checking Account (10$) --> CREDIT 649000 Other > Consulting Fees (10$) > 4) Adjustment -10$: > *CREDIT 00 General Checking Account (-10$) -->DEBIT 649000 Other > Consulting Fees (-10$) (WRONG)* > 2) should be: > DEBIT 649000 Other Consulting Fees --> CREDIT 00 General Checking > Account (10$) > 4) should be: > CREDIT 00 General Checking Account (++*10$) -->DEBIT 649000 Other > Consulting Fees (+*+10$) > > The attached patch fixes the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-778230641 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [8 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=27=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [216 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list) [3.2% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=27=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283718#comment-17283718 ] Olivier Heintz commented on OFBIZ-12047: Why not, new patch, [^RequestHandler.java.patch] > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > Attachments: RequestHandler.java.patch, RequestHandler.java.patch, > RequestHandler.java.patch > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-12047: --- Attachment: RequestHandler.java.patch > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > Attachments: RequestHandler.java.patch, RequestHandler.java.patch, > RequestHandler.java.patch > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #275: OFBIZ-10791 Fixed: Unable to add product (of ASSET_USAGE type) in order
sonarcloud[bot] commented on pull request #275: URL: https://github.com/apache/ofbiz-framework/pull/275#issuecomment-778197383 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=275=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=275=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=275=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=275=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=275) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=275=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=275=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283685#comment-17283685 ] Sebastian Berg commented on OFBIZ-10791: [~mbrohl] I had no issues applying the patch. I created a PR for convenience. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Sebastian Berg >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] SebastianEcomify opened a new pull request #275: OFBIZ-10791 Fixed: Unable to add product (of ASSET_USAGE type) in order
SebastianEcomify opened a new pull request #275: URL: https://github.com/apache/ofbiz-framework/pull/275 Fixed: Unable to add product (of ASSET_USAGE type) in order OFBIZ-10791 Thanks Priya for providing the patch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283666#comment-17283666 ] Michael Brohl commented on OFBIZ-12047: --- The best way to handle all (current OOTB and custom projects cases) is to provide a configuration option to exclude requests from the special handling. It does not require additional hardcoding in the RequestHandler and brings the most flexibility. We should have in mind that OFBiz is a framework and has a plugin mechanism, so custom implementations could also have the need to configure addtional requests to be excluded. Hence the suggestion to make the list of excluded requests configurable (through properties and SystemProperty.get...). > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > Attachments: RequestHandler.java.patch, RequestHandler.java.patch > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[
https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283636#comment-17283636
]
Olivier Heintz commented on OFBIZ-12047:
After a strange behavior in vueJs components I have checked a little more.
In my point of view (but clearly I have not an understanding of RequestHandler
and login java process) there are already a lot of hardcoded request name
("checkLogin" ,"ajaxCheckLogin", ...) and it's possible to test with
equals("login") not contain, it seems more secure.
If we want to manage all case, it will be necessary to add not
equals("SetTimeZoneFromBrowser") too but it's necessary in a very specifics
case, so I prefer to forget this case.
so in the new patch, the only modification is change from path.contain("login")
to requestUri.equal("login")
[^RequestHandler.java.patch]
> Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
> ---
>
> Key: OFBIZ-12047
> URL: https://issues.apache.org/jira/browse/OFBIZ-12047
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webapp
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Ingo Könemann
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: RequestHandler.java.patch, RequestHandler.java.patch
>
>
> There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and
> execute the previous request after a login occurs. This attribute is not
> removed properly when navigating away from a page without logging in.
> When navigating to a page that requires authentication the
> "_PREVIOUS_REQUEST_" attribute is saved in the session from within the
> LoginWorker to be called again when the login was successful through the
> RequestHandler. Currently, the attribute is only removed when a login occurs
> resulting in the previous request being stored in the session until some form
> of login is successfully executed.
> This behavior potentially results in navigation problems since a user is able
> to navigate to a page requiring authentication without logging in. An old
> request will be pulled from the session when a similar event occurs and the
> user logs in.
>
> I propose to have the RequestHandler remove the session attribute
> "_PREVIOUS_REQUEST_" after calling a request that does not require
> authentication. We also have to restructure the sequence of request handling
> to have the "targetRequestUri" handled after the security check and a
> possible removal of the session attribute.
>
> One problem arises with this solution, however, which should be less of an
> issue than the current state:
> If the login page includes a request call that is handled after the request
> showing the login page (for example an ajax call rendering a screen), the
> "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To
> my knowledge such a case does not exist within the OFBiz environment and
> seems to be an edge case far less problematic than the above mentioned
> problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12047) Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages
[ https://issues.apache.org/jira/browse/OFBIZ-12047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Heintz updated OFBIZ-12047: --- Attachment: RequestHandler.java.patch > Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages > --- > > Key: OFBIZ-12047 > URL: https://issues.apache.org/jira/browse/OFBIZ-12047 > Project: OFBiz > Issue Type: Bug > Components: framework/webapp >Affects Versions: Release Branch 18.12, Trunk >Reporter: Ingo Könemann >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 18.12.01, Upcoming Branch > > Attachments: RequestHandler.java.patch, RequestHandler.java.patch > > > There is a session attribute called "_PREVIOUS_REQUEST_" used to remember and > execute the previous request after a login occurs. This attribute is not > removed properly when navigating away from a page without logging in. > When navigating to a page that requires authentication the > "_PREVIOUS_REQUEST_" attribute is saved in the session from within the > LoginWorker to be called again when the login was successful through the > RequestHandler. Currently, the attribute is only removed when a login occurs > resulting in the previous request being stored in the session until some form > of login is successfully executed. > This behavior potentially results in navigation problems since a user is able > to navigate to a page requiring authentication without logging in. An old > request will be pulled from the session when a similar event occurs and the > user logs in. > > I propose to have the RequestHandler remove the session attribute > "_PREVIOUS_REQUEST_" after calling a request that does not require > authentication. We also have to restructure the sequence of request handling > to have the "targetRequestUri" handled after the security check and a > possible removal of the session attribute. > > One problem arises with this solution, however, which should be less of an > issue than the current state: > If the login page includes a request call that is handled after the request > showing the login page (for example an ajax call rendering a screen), the > "_PREVIOUS_REQUEST_" attribute will be lost before the login is processed. To > my knowledge such a case does not exist within the OFBiz environment and > seems to be an edge case far less problematic than the above mentioned > problem. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12168) Rename some connoted words like blacklist and whitelist.
[ https://issues.apache.org/jira/browse/OFBIZ-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283629#comment-17283629 ] ASF subversion and git services commented on OFBIZ-12168: - Commit 0044d288a69251eca80568411cdab809554f82b6 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0044d28 ] Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168) Updates DATAMODEL_CHANGES.adoc > Rename some connoted words like blacklist and whitelist. > - > > Key: OFBIZ-12168 > URL: https://issues.apache.org/jira/browse/OFBIZ-12168 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > It's related to this discussion https://markmail.org/message/jl4uu72vt2nnt5cb -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12168) Rename some connoted words like blacklist and whitelist.
[ https://issues.apache.org/jira/browse/OFBIZ-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283628#comment-17283628 ] ASF subversion and git services commented on OFBIZ-12168: - Commit 49a1438806a6b69fb713157865d565fd5e3055d1 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=49a1438 ] Improved: Rename some connoted words like blacklist and whitelist (OFBIZ-12168) The fk-name for OrderDenylist entity needs to be different from the one of OldOrderBlacklist Thanks to Deepak Dixit for spotting it > Rename some connoted words like blacklist and whitelist. > - > > Key: OFBIZ-12168 > URL: https://issues.apache.org/jira/browse/OFBIZ-12168 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > It's related to this discussion https://markmail.org/message/jl4uu72vt2nnt5cb -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12168) Rename some connoted words like blacklist and whitelist.
[ https://issues.apache.org/jira/browse/OFBIZ-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283627#comment-17283627 ] Jacques Le Roux commented on OFBIZ-12168: - Thanks Deepak! > Rename some connoted words like blacklist and whitelist. > - > > Key: OFBIZ-12168 > URL: https://issues.apache.org/jira/browse/OFBIZ-12168 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > It's related to this discussion https://markmail.org/message/jl4uu72vt2nnt5cb -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #274: Fixed: Financial account transaction (OFBIZ-10308)
sonarcloud[bot] commented on pull request #274: URL: https://github.com/apache/ofbiz-framework/pull/274#issuecomment-778135917 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=274=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=274=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=274=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=274=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=274) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=274=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=274=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] wpaetzold opened a new pull request #274: Fixed: Financial account transaction (OFBIZ-10308)
wpaetzold opened a new pull request #274: URL: https://github.com/apache/ofbiz-framework/pull/274 Fixes the direction of some accounting transactions. Thanks Ingo Wolfmayr for the patch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-12168) Rename some connoted words like blacklist and whitelist.
[ https://issues.apache.org/jira/browse/OFBIZ-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12168: Description: It's related to this discussion > Rename some connoted words like blacklist and whitelist. > - > > Key: OFBIZ-12168 > URL: https://issues.apache.org/jira/browse/OFBIZ-12168 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > It's related to this discussion -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12168) Rename some connoted words like blacklist and whitelist.
[ https://issues.apache.org/jira/browse/OFBIZ-12168?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12168: Description: It's related to this discussion https://markmail.org/message/jl4uu72vt2nnt5cb (was: It's related to this discussion ) > Rename some connoted words like blacklist and whitelist. > - > > Key: OFBIZ-12168 > URL: https://issues.apache.org/jira/browse/OFBIZ-12168 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > It's related to this discussion https://markmail.org/message/jl4uu72vt2nnt5cb -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #273: Fixed: Incorrect mapping for Lookup Purchase Order
sonarcloud[bot] commented on pull request #273: URL: https://github.com/apache/ofbiz-framework/pull/273#issuecomment-778123445 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=273=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=273=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=273=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=273=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=273) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=273=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=273=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
[
https://issues.apache.org/jira/browse/OFBIZ-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit closed OFBIZ-12143.
Fix Version/s: Upcoming Branch
18.12.01
Resolution: Fixed
Thanks Rajesh Kumar for reporting the issue
> Incorrect mapping for Lookup Purchase Order
>
>
> Key: OFBIZ-12143
> URL: https://issues.apache.org/jira/browse/OFBIZ-12143
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> Trunk, 17.12.05
> Environment: All
>Reporter: Rajesh Kumar
>Assignee: Deepak Dixit
>Priority: Major
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: image-2021-01-19-02-43-58-567.png
>
>
> Lookup screen for {color:#33}Purchase Order Header and Ship Info{color}
> has {color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list.
> This mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
> paginate-target due to this pagination buttons are failing when result has
> multiple pages.
>
> This can be fixed by adding a new form as
> {color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
> {color:#032f62}filename: {color}
> *applications\order\widget\ordermgr\LookupScreens.xml*
>
> {color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
[
https://issues.apache.org/jira/browse/OFBIZ-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283605#comment-17283605
]
ASF subversion and git services commented on OFBIZ-12143:
-
Commit 6616a0208efc92d6df66ed6b4bd4149799615908 in ofbiz-framework's branch
refs/heads/release18.12 from Deepak Dixit
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=6616a02 ]
Fixed: Incorrect mapping for Lookup Purchase Order (#273)
(OFBIZ-12143)
This issue was due to common form is being used for
LookupPurchaseOrderHeaderAndShipInfo and LookupOrderHeaderAndShipInfo screen.
Passed the paginateTargetUrl from screen to make sure pagination works properly
Thanks Rajesh Kumar for reporting the issue
> Incorrect mapping for Lookup Purchase Order
>
>
> Key: OFBIZ-12143
> URL: https://issues.apache.org/jira/browse/OFBIZ-12143
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> Trunk, 17.12.05
> Environment: All
>Reporter: Rajesh Kumar
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: image-2021-01-19-02-43-58-567.png
>
>
> Lookup screen for {color:#33}Purchase Order Header and Ship Info{color}
> has {color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list.
> This mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
> paginate-target due to this pagination buttons are failing when result has
> multiple pages.
>
> This can be fixed by adding a new form as
> {color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
> {color:#032f62}filename: {color}
> *applications\order\widget\ordermgr\LookupScreens.xml*
>
> {color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] dixitdeepak merged pull request #273: Fixed: Incorrect mapping for Lookup Purchase Order
dixitdeepak merged pull request #273: URL: https://github.com/apache/ofbiz-framework/pull/273 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dixitdeepak opened a new pull request #273: Fixed: Incorrect mapping for Lookup Purchase Order
dixitdeepak opened a new pull request #273: URL: https://github.com/apache/ofbiz-framework/pull/273 (OFBIZ-12143) This issue was due to common form is being used for LookupPurchaseOrderHeaderAndShipInfo and LookupOrderHeaderAndShipInfo screen. Passed the paginateTargetUrl from screen to make sure pagination works properly Thanks Rajesh Kumar for reporting the issue Improved: Implemented: Documented: Completed: Reverted: Fixed: (OFBIZ-) Explanation Thanks: This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #272: Fixed: Incorrect mapping for Lookup Purchase Order
sonarcloud[bot] commented on pull request #272: URL: https://github.com/apache/ofbiz-framework/pull/272#issuecomment-778119358 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=272=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=272=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=272=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=272=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=272) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=272=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=272=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
[
https://issues.apache.org/jira/browse/OFBIZ-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283594#comment-17283594
]
ASF subversion and git services commented on OFBIZ-12143:
-
Commit 32737938425cbe0fe8c83acbdd46e71a45818f66 in ofbiz-framework's branch
refs/heads/trunk from Deepak Dixit
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3273793 ]
Fixed: Incorrect mapping for Lookup Purchase Order (#272)
(OFBIZ-12143)
This issue was due to common form is being used for
LookupPurchaseOrderHeaderAndShipInfo and LookupOrderHeaderAndShipInfo screen.
Passed the paginateTargetUrl from screen to make sure pagination works properly
Thanks Rajesh Kumar for reporting the issue
> Incorrect mapping for Lookup Purchase Order
>
>
> Key: OFBIZ-12143
> URL: https://issues.apache.org/jira/browse/OFBIZ-12143
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> Trunk, 17.12.05
> Environment: All
>Reporter: Rajesh Kumar
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: image-2021-01-19-02-43-58-567.png
>
>
> Lookup screen for {color:#33}Purchase Order Header and Ship Info{color}
> has {color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list.
> This mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
> paginate-target due to this pagination buttons are failing when result has
> multiple pages.
>
> This can be fixed by adding a new form as
> {color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
> {color:#032f62}filename: {color}
> *applications\order\widget\ordermgr\LookupScreens.xml*
>
> {color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-framework] dixitdeepak merged pull request #272: Fixed: Incorrect mapping for Lookup Purchase Order
dixitdeepak merged pull request #272: URL: https://github.com/apache/ofbiz-framework/pull/272 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] dixitdeepak opened a new pull request #272: Fixed: Incorrect mapping for Lookup Purchase Order
dixitdeepak opened a new pull request #272: URL: https://github.com/apache/ofbiz-framework/pull/272 Fixed: Incorrect mapping for Lookup Purchase Order (OFBIZ-12143) This issue was due to common form is being used for LookupPurchaseOrderHeaderAndShipInfo and LookupOrderHeaderAndShipInfo screen. Passed the paginateTargetUrl from screen to make sure pagination works properly Thanks Rajesh Kumar for reporting the issue This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (OFBIZ-12143) Incorrect mapping for Lookup Purchase Order
[
https://issues.apache.org/jira/browse/OFBIZ-12143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Deepak Dixit reassigned OFBIZ-12143:
Assignee: Deepak Dixit
> Incorrect mapping for Lookup Purchase Order
>
>
> Key: OFBIZ-12143
> URL: https://issues.apache.org/jira/browse/OFBIZ-12143
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12,
> Trunk, 17.12.05
> Environment: All
>Reporter: Rajesh Kumar
>Assignee: Deepak Dixit
>Priority: Major
> Attachments: image-2021-01-19-02-43-58-567.png
>
>
> Lookup screen for {color:#33}Purchase Order Header and Ship Info{color}
> has {color:#032f62}ListLookupOrderHeaderAndShipInfo{color} for result list.
> This mapping has {color:#032f62}LookupOrderHeaderAndShipInfo{color} as
> paginate-target due to this pagination buttons are failing when result has
> multiple pages.
>
> This can be fixed by adding a new form as
> {color:#032f62}ListPurchaseOrderHeaderAndShipInfo.{color}
> {color:#032f62}filename: {color}
> *applications\order\widget\ordermgr\LookupScreens.xml*
>
> {color:#032f62}!image-2021-01-19-02-43-58-567.png!{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #56: Fixed: Fitering on StatusId in FindTask does not work
sonarcloud[bot] commented on pull request #56: URL: https://github.com/apache/ofbiz-plugins/pull/56#issuecomment-778106992 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=56=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=56=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=56=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=56=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=56) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=56=new_duplicated_lines_density=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=56=new_duplicated_lines_density=list) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10914) Fitering on StatusId in FindTask does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283583#comment-17283583 ] Deepak Dixit commented on OFBIZ-10914: -- Thanks Pierre Smits for reporting the issue. > Fitering on StatusId in FindTask does not work > -- > > Key: OFBIZ-10914 > URL: https://issues.apache.org/jira/browse/OFBIZ-10914 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit >Priority: Major > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-10914.patch > > > Filtering on one of the available status options (statusId) does not yield > the expected result. > To reproduce: > # go to [https://demo-stable.ofbiz.apache.org/projectmgr/control/FindTask] > # select one of the status options, e.g. Created > # see appropriate list of tasks > Actual result (with selected status option Created): > Overview shows tasks with statusId = Created PLUS the tasks with status In > Progress -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10914) Fitering on StatusId in FindTask does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Deepak Dixit closed OFBIZ-10914. Fix Version/s: Upcoming Branch 18.12.01 Resolution: Fixed > Fitering on StatusId in FindTask does not work > -- > > Key: OFBIZ-10914 > URL: https://issues.apache.org/jira/browse/OFBIZ-10914 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit >Priority: Major > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-10914.patch > > > Filtering on one of the available status options (statusId) does not yield > the expected result. > To reproduce: > # go to [https://demo-stable.ofbiz.apache.org/projectmgr/control/FindTask] > # select one of the status options, e.g. Created > # see appropriate list of tasks > Actual result (with selected status option Created): > Overview shows tasks with statusId = Created PLUS the tasks with status In > Progress -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #55: Fixed: Fitering on StatusId in FindTask does not work
sonarcloud[bot] commented on pull request #55: URL: https://github.com/apache/ofbiz-plugins/pull/55#issuecomment-778105057 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=55=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=55=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-plugins=55=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=55=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=55) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-plugins=55=duplicated_lines_density=list) No Duplication information This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10914) Fitering on StatusId in FindTask does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283579#comment-17283579 ] ASF subversion and git services commented on OFBIZ-10914: - Commit 27baf80c9861e00d11b67365b337c5e830550614 in ofbiz-plugins's branch refs/heads/release18.12 from Deepak Dixit [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=27baf80 ] Fixed: Fitering on StatusId in FindTask does not work (#56) (OFBIZ-10914) > Fitering on StatusId in FindTask does not work > -- > > Key: OFBIZ-10914 > URL: https://issues.apache.org/jira/browse/OFBIZ-10914 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10914.patch > > > Filtering on one of the available status options (statusId) does not yield > the expected result. > To reproduce: > # go to [https://demo-stable.ofbiz.apache.org/projectmgr/control/FindTask] > # select one of the status options, e.g. Created > # see appropriate list of tasks > Actual result (with selected status option Created): > Overview shows tasks with statusId = Created PLUS the tasks with status In > Progress -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] dixitdeepak merged pull request #56: Fixed: Fitering on StatusId in FindTask does not work
dixitdeepak merged pull request #56: URL: https://github.com/apache/ofbiz-plugins/pull/56 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] dixitdeepak opened a new pull request #56: Fixed: Fitering on StatusId in FindTask does not work
dixitdeepak opened a new pull request #56: URL: https://github.com/apache/ofbiz-plugins/pull/56 Fixed: Fitering on StatusId in FindTask does not work (OFBIZ-10914) As per implementation getProjectTask service is used to get the task status, it returned manipulated status for display based on some condition. Ideally list task should show the actual status set on the entity rather manipulated status. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-10914) Fitering on StatusId in FindTask does not work
[ https://issues.apache.org/jira/browse/OFBIZ-10914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283576#comment-17283576 ] ASF subversion and git services commented on OFBIZ-10914: - Commit 9cb1101e3fbfaa311bf8338febc3c58b3436015f in ofbiz-plugins's branch refs/heads/trunk from Deepak Dixit [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=9cb1101 ] Fixed: Fitering on StatusId in FindTask does not work (#55) (OFBIZ-10914) > Fitering on StatusId in FindTask does not work > -- > > Key: OFBIZ-10914 > URL: https://issues.apache.org/jira/browse/OFBIZ-10914 > Project: OFBiz > Issue Type: Bug > Components: projectmgr >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Deepak Dixit >Priority: Major > Attachments: OFBIZ-10914.patch > > > Filtering on one of the available status options (statusId) does not yield > the expected result. > To reproduce: > # go to [https://demo-stable.ofbiz.apache.org/projectmgr/control/FindTask] > # select one of the status options, e.g. Created > # see appropriate list of tasks > Actual result (with selected status option Created): > Overview shows tasks with statusId = Created PLUS the tasks with status In > Progress -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [ofbiz-plugins] dixitdeepak merged pull request #55: Fixed: Fitering on StatusId in FindTask does not work
dixitdeepak merged pull request #55: URL: https://github.com/apache/ofbiz-plugins/pull/55 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-plugins] dixitdeepak opened a new pull request #55: Fixed: Fitering on StatusId in FindTask does not work
dixitdeepak opened a new pull request #55: URL: https://github.com/apache/ofbiz-plugins/pull/55 Fixed: Fitering on StatusId in FindTask does not work (OFBIZ-10914) As per implementation getProjectTask service is used to get the task status, it returned manipulated status for display based on some condition. Ideally list task should show the actual status set on the entity rather manipulated status. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script
[ https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl updated OFBIZ-12173: -- Fix Version/s: (was: Release Branch 18.12) 18.12.01 > Visit disabling causes NullPointerException on ecomm groovy script > -- > > Key: OFBIZ-12173 > URL: https://issues.apache.org/jira/browse/OFBIZ-12173 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 > Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Pawan Verma >Priority: Blocker > Labels: visit > Fix For: 18.12.01, Release Branch 17.12 > > Attachments: > OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, > newcustomer_error.jpg > > > Disable tracking of Visits and Visitors, setting false the value of > stats.persist.visit stats.persist.visitor in serverstats.properties file, > causes a NullPointerException in the groovy script > ecommerce/groovyScript/customer/NewCustomer.groovy. > Attached here below a screenshot of the error. > !newcustomer_error.jpg! > This error also afflicts older version of OFBiz (the screenshot is taken from > an ecommerce site running on OFBiz 13.07.03) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script
[ https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283547#comment-17283547 ] Giulio Speri commented on OFBIZ-12173: -- [~pawan] nice, thank you and have a good day! > Visit disabling causes NullPointerException on ecomm groovy script > -- > > Key: OFBIZ-12173 > URL: https://issues.apache.org/jira/browse/OFBIZ-12173 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 > Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Pawan Verma >Priority: Blocker > Labels: visit > Fix For: Release Branch 18.12, Release Branch 17.12 > > Attachments: > OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, > newcustomer_error.jpg > > > Disable tracking of Visits and Visitors, setting false the value of > stats.persist.visit stats.persist.visitor in serverstats.properties file, > causes a NullPointerException in the groovy script > ecommerce/groovyScript/customer/NewCustomer.groovy. > Attached here below a screenshot of the error. > !newcustomer_error.jpg! > This error also afflicts older version of OFBiz (the screenshot is taken from > an ecommerce site running on OFBiz 13.07.03) -- This message was sent by Atlassian Jira (v8.3.4#803005)
