[jira] [Commented] (OFBIZ-9350) Deprecate Mini Lang

2023-02-08 Thread Rohit Koushal (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17686019#comment-17686019 ] Rohit Koushal commented on OFBIZ-9350: -- Is the focus on this area still ongoing? I observe a

[jira] [Created] (OFBIZ-12756) Show used promotion codes

2023-02-08 Thread Chenghu Shan (Jira)
Chenghu Shan created OFBIZ-12756: Summary: Show used promotion codes Key: OFBIZ-12756 URL: https://issues.apache.org/jira/browse/OFBIZ-12756 Project: OFBiz Issue Type: New Feature

[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #588: Fixed: Use ending balance from GlAccountHistory when calculating balance sheet balances (OFBIZ-12755)

2023-02-08 Thread via GitHub
gilPts commented on code in PR #588: URL: https://github.com/apache/ofbiz-framework/pull/588#discussion_r1100146762 ## applications/accounting/groovyScripts/reports/BalanceSheet.groovy: ## @@ -209,24 +204,15 @@ enum RootClass {DEBIT, CREDIT} * This controls how the balance of

[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #586: Fixed: Display contra accounts on balance sheet as negative values (OFBIZ-12754)

2023-02-08 Thread via GitHub
gilPts commented on code in PR #586: URL: https://github.com/apache/ofbiz-framework/pull/586#discussion_r1100136979 ## applications/accounting/groovyScripts/reports/BalanceSheet.groovy: ## @@ -101,7 +101,12 @@ if (lastClosedTimePeriod) {

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #517: Codenarc integration

2023-02-08 Thread via GitHub
sonarcloud[bot] commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1422564098 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration

2023-02-08 Thread via GitHub
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1100091707 ## framework/webtools/groovyScripts/entity/XmlDsDump.groovy: ## @@ -17,151 +17,158 @@ * under the License. */ -import java.util.* -import java.io.* -import

[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration

2023-02-08 Thread via GitHub
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1100087132 ## applications/accounting/groovyScripts/invoice/EditInvoice.groovy: ## @@ -94,58 +91,57 @@ if (invoice) { context.invoiceItems = invoiceItemsConv -

[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration

2023-02-08 Thread via GitHub
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1100076320 ## framework/webtools/groovyScripts/stats/StatsSinceStart.groovy: ## @@ -85,17 +60,23 @@ while (iterator.hasNext()) { statsId = iterator.next() Review

[GitHub] [ofbiz-framework] gilPts commented on a diff in pull request #517: Codenarc integration

2023-02-08 Thread via GitHub
gilPts commented on code in PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1100075028 ## framework/webtools/groovyScripts/service/JobDetails.groovy: ## @@ -22,15 +22,15 @@ import org.apache.ofbiz.entity.GenericValue import

[jira] [Commented] (OFBIZ-12752) Extend standard view OrderItemAndShipGroupAssoc with missing relation to OrderItemAttribute

2023-02-08 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17685767#comment-17685767 ] ASF subversion and git services commented on OFBIZ-12752: - Commit

[jira] [Closed] (OFBIZ-12752) Extend standard view OrderItemAndShipGroupAssoc with missing relation to OrderItemAttribute

2023-02-08 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-12752. --- Fix Version/s: Upcoming Branch Resolution: Implemented > Extend standard view

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #582: Improved: Extend standard view OrderItemAndShipGroupAssoc with missing relation to OrderItemAttribute (OFBIZ-12752)

2023-02-08 Thread via GitHub
JacquesLeRoux merged PR #582: URL: https://github.com/apache/ofbiz-framework/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (OFBIZ-12752) Extend standard view OrderItemAndShipGroupAssoc with missing relation to OrderItemAttribute

2023-02-08 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12752: Summary: Extend standard view OrderItemAndShipGroupAssoc with missing relation to

[jira] [Updated] (OFBIZ-12752) Improved:

2023-02-08 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12752: Summary: Improved: (was: Extend standard view OrderItemAndShipGroupAssoc with missing