[jira] [Created] (OFBIZ-12766) CVE-2023-24998 Apache Commons FileUpload and Tomcat - DoS with excessive parts
Jacques Le Roux created OFBIZ-12766: --- Summary: CVE-2023-24998 Apache Commons FileUpload and Tomcat - DoS with excessive parts Key: OFBIZ-12766 URL: https://issues.apache.org/jira/browse/OFBIZ-12766 Project: OFBiz Issue Type: Task Components: framework/security, tomcat Affects Versions: 22.01.01 Reporter: Jacques Le Roux Assignee: Jacques Le Roux See https://commons.apache.org/proper/commons-fileupload/security-reports.html https://tomcat.apache.org/security-9.html#Fixed_in_Apache_Tomcat_9.0.71 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12765) Improvement to createPartyRelationship service
[ https://issues.apache.org/jira/browse/OFBIZ-12765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691390#comment-17691390 ] Deepak Dixit commented on OFBIZ-12765: -- Instead of having logic in createPartyRelationship service, we can make it simple create service, service will simply create party relationship record, and at the business side we can implement checks. > Improvement to createPartyRelationship service > --- > > Key: OFBIZ-12765 > URL: https://issues.apache.org/jira/browse/OFBIZ-12765 > Project: OFBiz > Issue Type: Improvement > Components: party >Reporter: Chenghu Shan >Assignee: Chenghu Shan >Priority: Minor > > Currently, createPartyRelationship service does not allow the creation of a > new PartyRelationship of the same parties until the thruDate has passed. This > also disallows the creation new PartyRelationships of the same parties beyond > that thruDate. > This improvement checks for time interval conflicts and allows the creation > of a different PartyRelationship of the same parties before the thruDate has > passed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] dixitdeepak commented on a diff in pull request #592: Improved: Improvement to createPartyRelationship service (OFBIZ-12765)
dixitdeepak commented on code in PR #592:
URL: https://github.com/apache/ofbiz-framework/pull/592#discussion_r1112547954
##
applications/party/groovyScripts/party/PartyServices.groovy:
##
@@ -427,13 +427,49 @@ def createPartyRelationship() {
partyIdTo: parameters.partyIdTo,
roleTypeIdFrom: parameters.roleTypeIdFrom,
roleTypeIdTo: parameters.roleTypeIdTo)
-.filterByDate()
.queryList()
-if (!partyRels) {
-GenericValue partyRelationship = makeValue('PartyRelationship',
parameters)
-partyRelationship.create()
+
+if (partyRels) {
+// checks for conflicts with existing unlimited valid entries
+for (GenericValue partyRel : partyRels) {
+if (!partyRel.thruDate) {
+if (parameters.fromDate.after(partyRel.fromDate))
+return success()
+}
+}
+
+// checks if there are any conflicts with the time periods of the
entries
+if (!parameters.thruDate) {
+for(GenericValue partyRel : partyRels) {
+if ((parameters.fromDate.before(partyRel.fromDate)) ||
(parameters.fromDate.before(partyRel.thruDate))) {
+return success()
+}
+}
+} else {
+EntityCondition partyCond =
Review Comment:
Instead of having logic in createPartyRelationship service, we can make it
simple create service, service will simply create party relationship record,
and at the business side we can implement checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #592: Improved: Improvement to createPartyRelationship service (OFBIZ-12765)
sonarcloud[bot] commented on PR #592: URL: https://github.com/apache/ofbiz-framework/pull/592#issuecomment-1437144767 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework=592) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=BUG) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=592=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=592=false=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework=592=false=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=592=false=CODE_SMELL) [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=592) No Coverage information [](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework=592=duplicated_lines_density=list) No Duplication information -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-framework] cshan-ecomify opened a new pull request, #592: Improved: Improvement to createPartyRelationship service (OFBIZ-12765)
cshan-ecomify opened a new pull request, #592: URL: https://github.com/apache/ofbiz-framework/pull/592 Improved: Improvement to createPartyRelationship service (OFBIZ-12765) The createPartyRelationship service now allows new relationships of the same parties if there are no conflicts in their period of validity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (OFBIZ-12762) OFBiz Asciidoc documentation is broken
[
https://issues.apache.org/jira/browse/OFBIZ-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691140#comment-17691140
]
Jacques Le Roux commented on OFBIZ-12762:
-
Thanks Deepak, currently figthing this:
https://github.com/groovy/groovy-eclipse/issues/1425 :)
> OFBiz Asciidoc documentation is broken
> --
>
> Key: OFBIZ-12762
> URL: https://issues.apache.org/jira/browse/OFBIZ-12762
> Project: OFBiz
> Issue Type: Bug
> Components: asciidoc
>Reporter: Jacques Le Roux
>Priority: Major
>
> Here are the errors locally (Windows):
> {noformat}
> > Task :generateOfbizDocumentation
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 193: include file not found:
> C:/projectsASF/Git/ofbiz-framework/_include/OFBizDocumentationSystem.adoc
> include file not found:
> C:/projectsASF/Git/ofbiz-framework/_include/OFBizDocumentationSystem.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:193
> (
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 197: include file not found:
> C:/projectsASF/framework/webapp/src/docs/asciidoc/webapp.adoc
> include file not found:
> C:/projectsASF/framework/webapp/src/docs/asciidoc/webapp.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:197
> (uri:classloa
> der:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 205: include file not found:
> C:/projectsASF/framework/entity/src/docs/asciidoc/entity-engine.adoc
> include file not found:
> C:/projectsASF/framework/entity/src/docs/asciidoc/entity-engine.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:205
> (uri:c
> lassloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 219: include file not found:
> C:/projectsASF/framework/datafile/src/docs/asciidoc/datafiles.adoc
> include file not found:
> C:/projectsASF/framework/datafile/src/docs/asciidoc/datafiles.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:219
> (uri:cla
> ssloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 225: include file not found:
> C:/projectsASF/applications/datamodel/DATAMODEL_CHANGES.adoc
> include file not found:
> C:/projectsASF/applications/datamodel/DATAMODEL_CHANGES.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:225
> (uri:classload
> er:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 255: include file not found:
> C:/projectsASF/themes/docs/themes.adoc
> include file not found: C:/projectsASF/themes/docs/themes.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:255
> (uri:classloader:/gems/asciidoctor-2
> .0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> include file not found:
> C:/projectsASF/framework/webtools/src/docs/asciidoc/_include/webtools-main.adoc
> :: developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc
> :276
> (uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> GRAVE: developer-manual.adoc: line 276: include file not found:
>
[GitHub] [ofbiz-site] mbrohl merged pull request #10: Implemented: Optimizes and corrects the css files.
mbrohl merged PR #10: URL: https://github.com/apache/ofbiz-site/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12765) Improvement to createPartyRelationship service
Chenghu Shan created OFBIZ-12765: Summary: Improvement to createPartyRelationship service Key: OFBIZ-12765 URL: https://issues.apache.org/jira/browse/OFBIZ-12765 Project: OFBiz Issue Type: Improvement Components: party Reporter: Chenghu Shan Assignee: Chenghu Shan Currently, createPartyRelationship service does not allow the creation of a new PartyRelationship of the same parties until the thruDate has passed. This also disallows the creation new PartyRelationships of the same parties beyond that thruDate. This improvement checks for time interval conflicts and allows the creation of a different PartyRelationship of the same parties before the thruDate has passed. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12762) OFBiz Asciidoc documentation is broken
[
https://issues.apache.org/jira/browse/OFBIZ-12762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1769#comment-1769
]
Deepak Dixit commented on OFBIZ-12762:
--
https://github.com/asciidoctor/asciidoctorj/issues/739
> OFBiz Asciidoc documentation is broken
> --
>
> Key: OFBIZ-12762
> URL: https://issues.apache.org/jira/browse/OFBIZ-12762
> Project: OFBiz
> Issue Type: Bug
> Components: asciidoc
>Reporter: Jacques Le Roux
>Priority: Major
>
> Here are the errors locally (Windows):
> {noformat}
> > Task :generateOfbizDocumentation
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 193: include file not found:
> C:/projectsASF/Git/ofbiz-framework/_include/OFBizDocumentationSystem.adoc
> include file not found:
> C:/projectsASF/Git/ofbiz-framework/_include/OFBizDocumentationSystem.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:193
> (
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 197: include file not found:
> C:/projectsASF/framework/webapp/src/docs/asciidoc/webapp.adoc
> include file not found:
> C:/projectsASF/framework/webapp/src/docs/asciidoc/webapp.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:197
> (uri:classloa
> der:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 205: include file not found:
> C:/projectsASF/framework/entity/src/docs/asciidoc/entity-engine.adoc
> include file not found:
> C:/projectsASF/framework/entity/src/docs/asciidoc/entity-engine.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:205
> (uri:c
> lassloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 219: include file not found:
> C:/projectsASF/framework/datafile/src/docs/asciidoc/datafiles.adoc
> include file not found:
> C:/projectsASF/framework/datafile/src/docs/asciidoc/datafiles.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:219
> (uri:cla
> ssloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 225: include file not found:
> C:/projectsASF/applications/datamodel/DATAMODEL_CHANGES.adoc
> include file not found:
> C:/projectsASF/applications/datamodel/DATAMODEL_CHANGES.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:225
> (uri:classload
> er:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> GRAVE: developer-manual.adoc: line 255: include file not found:
> C:/projectsASF/themes/docs/themes.adoc
> include file not found: C:/projectsASF/themes/docs/themes.adoc ::
> developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc:255
> (uri:classloader:/gems/asciidoctor-2
> .0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> fÚvr. 17, 2023 5:07:01 PM
> uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb
> preprocess_include_directive
> include file not found:
> C:/projectsASF/framework/webtools/src/docs/asciidoc/_include/webtools-main.adoc
> :: developer-manual.adoc ::
> C:/projectsASF/Git/ofbiz-framework/C:/projectsASF/Git/ofbiz-framework/docs/asciidoc/developer-manual.adoc
> :276
> (uri:classloader:/gems/asciidoctor-2.0.10/lib/asciidoctor/reader.rb:preprocess_include_directive)
> GRAVE: developer-manual.adoc: line 276: include file not found:
> C:/projectsASF/framework/webtools/src/docs/asciidoc/_include/webtools-main.adoc
> fÚvr. 17, 2023 5:07:01 PM
[jira] [Closed] (OFBIZ-12763) OFBiz Website: store and load fonts locally
[ https://issues.apache.org/jira/browse/OFBIZ-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Brohl closed OFBIZ-12763. - Resolution: Implemented > OFBiz Website: store and load fonts locally > --- > > Key: OFBIZ-12763 > URL: https://issues.apache.org/jira/browse/OFBIZ-12763 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The fonts should be stored locally and loaded from the webserver instead of > external sites. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12763) OFBiz Website: store and load fonts locally
[ https://issues.apache.org/jira/browse/OFBIZ-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691104#comment-17691104 ] ASF subversion and git services commented on OFBIZ-12763: - Commit b24c79c0b2472dbb82a2d95c3e4a68ef9c45e299 in ofbiz-site's branch refs/heads/master from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-site.git;h=b24c79c ] Implemented: OFBiz Website: store and load fonts locally (OFBIZ-12763) Provides the newly generated HTML files using local fonts. > OFBiz Website: store and load fonts locally > --- > > Key: OFBIZ-12763 > URL: https://issues.apache.org/jira/browse/OFBIZ-12763 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The fonts should be stored locally and loaded from the webserver instead of > external sites. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12763) OFBiz Website: store and load fonts locally
[ https://issues.apache.org/jira/browse/OFBIZ-12763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17691103#comment-17691103 ] ASF subversion and git services commented on OFBIZ-12763: - Commit 6c1af752cbcd6ae1409014979083ab75133beea3 in ofbiz-site's branch refs/heads/master from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-site.git;h=6c1af75 ] Implemented: OFBiz Website: store and load fonts locally (OFBIZ-12763) Provides the local font files, fonts.css containing the font faces and the change to the header to laod fonts.css. > OFBiz Website: store and load fonts locally > --- > > Key: OFBIZ-12763 > URL: https://issues.apache.org/jira/browse/OFBIZ-12763 > Project: OFBiz > Issue Type: Improvement > Components: site >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Major > > The fonts should be stored locally and loaded from the webserver instead of > external sites. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-site] mbrohl merged pull request #9: OFBiz website: store and load fonts locally (OFBIZ-12763)
mbrohl merged PR #9: URL: https://github.com/apache/ofbiz-site/pull/9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [ofbiz-site] mbrohl commented on pull request #9: OFBiz website: store and load fonts locally (OFBIZ-12763)
mbrohl commented on PR #9: URL: https://github.com/apache/ofbiz-site/pull/9#issuecomment-1436634002 Thank you, @danwatford ! I tested it the same way using the Live Server Plugin in VSCode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (OFBIZ-12764) Create IDE profiles for groovy styling
Jacques Le Roux created OFBIZ-12764: --- Summary: Create IDE profiles for groovy styling Key: OFBIZ-12764 URL: https://issues.apache.org/jira/browse/OFBIZ-12764 Project: OFBiz Issue Type: Task Components: ALL COMPONENTS Affects Versions: Upcoming Branch Reporter: Jacques Le Roux LIke we have https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;a=blob_plain;f=wiki-files/OFBizJavaFormatter.xml (See https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions for details) it would be great to have something similar for Groovy before pushing OFBIZ-11167 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12764) Create IDE profiles for groovy styling
[ https://issues.apache.org/jira/browse/OFBIZ-12764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-12764: Parent: OFBIZ-11167 Issue Type: Sub-task (was: Task) > Create IDE profiles for groovy styling > -- > > Key: OFBIZ-12764 > URL: https://issues.apache.org/jira/browse/OFBIZ-12764 > Project: OFBiz > Issue Type: Sub-task > Components: ALL COMPONENTS >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Priority: Major > > LIke we have > https://gitbox.apache.org/repos/asf?p=ofbiz-tools.git;a=blob_plain;f=wiki-files/OFBizJavaFormatter.xml > (See https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions > for details) it would be great to have something similar for Groovy before > pushing OFBIZ-11167 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #517: Codenarc integration
JacquesLeRoux commented on PR #517: URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1436626800 `I would suggest creating a separate ticket to 'create IDE profiles for groovy styling' as we already have a lot do take care of with this ticket.` Done with https://issues.apache.org/jira/browse/OFBIZ-12764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ofbiz.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
