[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-19 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744826#comment-17744826 ] Paul Foxworthy commented on OFBIZ-12837: Yes, I'll commit > Log SQL statement in exceptions in

[jira] [Comment Edited] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-19 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744811#comment-17744811 ] Paul Foxworthy edited comment on OFBIZ-12836 at 7/19/23 11:58 PM: -- New

[jira] [Updated] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-19 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-12836: --- Attachment: Fixed__Resource_leaks_in_EntitySQLProcessor_groovy-1.patch

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-19 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744811#comment-17744811 ] Paul Foxworthy commented on OFBIZ-12836: OK, I will change it to use explicit types. > Resource

[jira] [Comment Edited] (OFBIZ-11167) Use Codenarc to test Groovy code

2023-07-19 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561935#comment-17561935 ] Paul Foxworthy edited comment on OFBIZ-11167 at 7/19/23 10:35 PM: -- I

[jira] [Comment Edited] (OFBIZ-11167) Use Codenarc to test Groovy code

2023-07-19 Thread Paul Foxworthy (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-11167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17561935#comment-17561935 ] Paul Foxworthy edited comment on OFBIZ-11167 at 7/19/23 10:32 PM: -- I

[jira] [Commented] (OFBIZ-12813) Refactor groovy folder structure and add package declaration

2023-07-19 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744722#comment-17744722 ] Jacques Le Roux commented on OFBIZ-12813: - Hi Wiebke, We have a problem with

[jira] [Commented] (OFBIZ-12836) Resource leaks in EntitySQLProcessor.groovy

2023-07-19 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744720#comment-17744720 ] Jacques Le Roux commented on OFBIZ-12836: - Hi Paul, Your patch looks good to me. With

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #650: Improved: Refactoring groovy folder structure and package declaration (OFBIZ-12813)

2023-07-19 Thread via GitHub
sonarcloud[bot] commented on PR #650: URL: https://github.com/apache/ofbiz-framework/pull/650#issuecomment-1642000714 Kudos, SonarCloud Quality Gate passed! [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png

[jira] [Commented] (OFBIZ-12837) Log SQL statement in exceptions in EntitySQLProcessor

2023-07-19 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17744517#comment-17744517 ] Jacques Le Roux commented on OFBIZ-12837: - Hi Paul, Will you commit and backport (22.01) ? Else