[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839837#comment-17839837 ] Pierre Smits commented on OFBIZ-13035: -- Jacques, ExampleExt is quite the outlier compared to the

Re: [PR] Improved: PRI- parameterized menu location (OFBIZ-13044) [ofbiz-plugins]

2024-04-22 Thread via GitHub
mbrohl commented on PR #122: URL: https://github.com/apache/ofbiz-plugins/pull/122#issuecomment-2070886984 The plugin was deactivated because it had issues and was not working, please look at the history. It should never have been committed being in that shape, yes. -- This is an

[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-22 Thread Pierre Smits (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839836#comment-17839836 ] Pierre Smits commented on OFBIZ-13049: -- HI Jacques, I am just utilising what is available OOTB.

Re: [PR] Improved: PRI- parameterized menu location (OFBIZ-13044) [ofbiz-plugins]

2024-04-22 Thread via GitHub
PierreSmits commented on PR #122: URL: https://github.com/apache/ofbiz-plugins/pull/122#issuecomment-2070864434 @JacquesLeRoux , if not ready, why merge it into trunk? I guess, having it in a feature branch and inviting the community to assist/help would have been a good approach.

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-22 Thread via GitHub
PierreSmits commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2070842051 HI Jacques, Did you clear your cache? Logging out and in again could also help. -- This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (OFBIZ-13062) Error in PayGradeForms.xml Line: 65

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839798#comment-17839798 ] Jacques Le Roux commented on OFBIZ-13062: - This line was put in by OFBIZ-1659. It seems useless.

[jira] [Created] (OFBIZ-13062) Error in PayGradeForms.xml Line: 65

2024-04-22 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13062: --- Summary: Error in PayGradeForms.xml Line: 65 Key: OFBIZ-13062 URL: https://issues.apache.org/jira/browse/OFBIZ-13062 Project: OFBiz Issue Type: Bug

[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839760#comment-17839760 ] ASF subversion and git services commented on OFBIZ-13035: - Commit

Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux merged PR #121: URL: https://github.com/apache/ofbiz-plugins/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #121: URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2070016829 Thanks, quite easier -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Improved: PRI- parameterized menu location (OFBIZ-13044) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #122: URL: https://github.com/apache/ofbiz-plugins/pull/122#issuecomment-2070001358 > why having a plugin while not making it available to the demo sites? Because the app is not ready as is. You need to at least read the README.md. I guess that's why

Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub
PierreSmits commented on PR #121: URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2069989295 As a mentioned in the commit message: re calendar screen of a fixed asset Here is a link in demo-trunk:

Re: [PR] Improved: Fix cross-app menu location issues (OFBIZ-13035) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #121: URL: https://github.com/apache/ofbiz-plugins/pull/121#issuecomment-2069961809 Yes a link will be welcome... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2069939651 Ha, maybe it needs PR121 1st, trying... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Improved: HumanRes-Main page (OFBIZ-13050) [ofbiz-framework]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #779: URL: https://github.com/apache/ofbiz-framework/pull/779#issuecomment-2069927544 Hi @PierreSmits , When applying your PR as patch, I get: > java.lang.RuntimeException: Could not find PortalPage with portalPageId [] -- This is an automated

[PR] Improved: PRI- parameterized menu location (OFBIZ-13044) [ofbiz-plugins]

2024-04-22 Thread via GitHub
PierreSmits opened a new pull request, #122: URL: https://github.com/apache/ofbiz-plugins/pull/122 modified: - CommonScreens.xml: correcting typo - SampleScreens.xml: change menu location - ofbiz-component.xml: change app-bar-display value (why having a plugin while not making it

Re: [PR] Improved: PRI- parameterized menu location (OFBIZ-13044) [ofbiz-plugins]

2024-04-22 Thread via GitHub
sonarcloud[bot] commented on PR #122: URL: https://github.com/apache/ofbiz-plugins/pull/122#issuecomment-2069815107 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[jira] [Closed] (OFBIZ-13047) SOLR-parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13047. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Fixed

[jira] [Commented] (OFBIZ-13047) SOLR-parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839718#comment-17839718 ] ASF subversion and git services commented on OFBIZ-13047: - Commit

Re: [PR] improved: SOLR - parameterized menu location (OFBIZ-13047) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux merged PR #120: URL: https://github.com/apache/ofbiz-plugins/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (OFBIZ-13045) FIRST - parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13045. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution: Fixed

[jira] [Commented] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839716#comment-17839716 ] Jacques Le Roux commented on OFBIZ-13046: -

[jira] [Commented] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839715#comment-17839715 ] ASF subversion and git services commented on OFBIZ-13046: - Commit

[jira] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046 ] Jacques Le Roux deleted comment on OFBIZ-13046: - was (Author: jacques.le.roux): https://github.com/apache/ofbiz-plugins/commit/d460f2beadebdd5af47395c40a35b0b278dbcfec Improved:

Re: [PR] Improved: ExampleExt - move to parameterized menu location (OFBIZ-13045) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux merged PR #119: URL: https://github.com/apache/ofbiz-plugins/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046 ] Jacques Le Roux deleted comment on OFBIZ-13046: - was (Author: jira-bot): Commit b48f71ebdd072b28bd52d80065bfb81cc79facea in ofbiz-plugins's branch refs/heads/trunk from Pierre Smits [

[jira] [Commented] (OFBIZ-13045) FIRST - parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839709#comment-17839709 ] Jacques Le Roux commented on OFBIZ-13045: - Commit b48f71ebdd072b28bd52d80065bfb81cc79facea in

[jira] [Comment Edited] (OFBIZ-13045) FIRST - parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839709#comment-17839709 ] Jacques Le Roux edited comment on OFBIZ-13045 at 4/22/24 2:29 PM: --

[jira] [Updated] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13046: Description: (was: GitHub Pull Request #119) > ExampleExt- parameterized menu

[jira] [Updated] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13046: Description: GitHub Pull Request #119 > ExampleExt- parameterized menu location >

[jira] [Closed] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13046. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution:

[jira] [Commented] (OFBIZ-13046) ExampleExt- parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839682#comment-17839682 ] ASF subversion and git services commented on OFBIZ-13046: - Commit

Re: [PR] Improved: FIRST - move to parameterized menu location (OFBIZ-13045) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux merged PR #118: URL: https://github.com/apache/ofbiz-plugins/pull/118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Closed] (OFBIZ-13044) PRI- parameterized menu location

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13044. --- Fix Version/s: Upcoming Branch Assignee: Jacques Le Roux Resolution:

[jira] [Commented] (OFBIZ-13043) MSG-parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839677#comment-17839677 ] ASF subversion and git services commented on OFBIZ-13043: - Commit

[jira] [Commented] (OFBIZ-13044) PRI- parameterized menu location

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839676#comment-17839676 ] ASF subversion and git services commented on OFBIZ-13044: - Commit

Re: [PR] Improved: PRI - move to parameterized menu location (OFBIZ-13044) [ofbiz-plugins]

2024-04-22 Thread via GitHub
JacquesLeRoux merged PR #117: URL: https://github.com/apache/ofbiz-plugins/pull/117 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixed: invoiceOverview generates an error (OFBIZ-13017) [ofbiz-framework]

2024-04-22 Thread via GitHub
JacquesLeRoux commented on PR #780: URL: https://github.com/apache/ofbiz-framework/pull/780#issuecomment-2069222939 Thanks @MkLeila , I'd not say I seriously reviewed but I tested and all is correct with me, +1 for pushing/ -- This is an automated message from the Apache Git

[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839584#comment-17839584 ] Jacques Le Roux commented on OFBIZ-13049: - Pierre, Now that you have set OFBIZ-12966 and

[jira] [Closed] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-13061. --- Resolution: Implemented It's hard to test locally, I think it's OK anyway > Prevents to

[jira] [Commented] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839559#comment-17839559 ] ASF subversion and git services commented on OFBIZ-13061: - Commit

[jira] [Created] (OFBIZ-13061) Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors

2024-04-22 Thread Jacques Le Roux (Jira)
Jacques Le Roux created OFBIZ-13061: --- Summary: Prevents to uselessly clutter the logs up with SetTimeZoneFromBrowser errors Key: OFBIZ-13061 URL: https://issues.apache.org/jira/browse/OFBIZ-13061

[jira] [Commented] (OFBIZ-12994) Convert Invoice relation screen to dynamic Compound

2024-04-22 Thread Mekika Leila (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-12994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839549#comment-17839549 ] Mekika Leila commented on OFBIZ-12994: -- PR: https://github.com/apache/ofbiz-framework/pull/780

Re: [PR] Fixed: invoiceOverview generates an error (OFBIZ-13017) [ofbiz-framework]

2024-04-22 Thread via GitHub
sonarcloud[bot] commented on PR #780: URL: https://github.com/apache/ofbiz-framework/pull/780#issuecomment-2068787842 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Fixed: invoiceOverview generates an error (OFBIZ-13017) [ofbiz-framework]

2024-04-22 Thread via GitHub
MkLeila opened a new pull request, #780: URL: https://github.com/apache/ofbiz-framework/pull/780 Update fix to combine OFBIZ-12966 and OFBIZ-13011 updates with modifications brought by jira OFBIZ-12994 It brings back the changes introduced by OFBIZ-12994 and adapt it with the

[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839535#comment-17839535 ] Jacques Le Roux commented on OFBIZ-13035: - Less easy: 2024-04-22 07:19:55,968

[jira] [Updated] (OFBIZ-13059) Old error in showPortalPage screen

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-13059: Fix Version/s: 18.12.13 (was: Upcoming Branch) Affects

[jira] [Commented] (OFBIZ-13049) Configurable Main page

2024-04-22 Thread Daniel Watford (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839533#comment-17839533 ] Daniel Watford commented on OFBIZ-13049: Hi [~pierresmits] , I'm going to make an assumption

[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen

2024-04-22 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839513#comment-17839513 ] ASF subversion and git services commented on OFBIZ-13059: - Commit

[jira] [Commented] (OFBIZ-13059) Old error in showPortalPage screen

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839512#comment-17839512 ] Jacques Le Roux commented on OFBIZ-13059: - I finally decided to backport, it's easy and should

[jira] [Commented] (OFBIZ-13035) Fix cross-app menu location issues

2024-04-22 Thread Jacques Le Roux (Jira)
[ https://issues.apache.org/jira/browse/OFBIZ-13035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839508#comment-17839508 ] Jacques Le Roux commented on OFBIZ-13035: - Hi Pierre, We have this one today: 2024-04-22