[jira] [Commented] (OFBIZ-10625) Convert updateContent and removeContent service to entity-auto

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722676#comment-16722676 ] Aditya Sharma commented on OFBIZ-10625: --- Thanks Deepak :)  > Convert updateContent and

[jira] [Commented] (OFBIZ-9743) updateContent service does not return an error/success message

2018-12-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722681#comment-16722681 ] Aditya Sharma commented on OFBIZ-9743: -- Indeed. With OFBIZ-10625 being done we can close it. >

[jira] [Commented] (OFBIZ-10708) visual-editor not workign on ecommerce

2018-12-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721087#comment-16721087 ] Aditya Sharma commented on OFBIZ-10708: --- At a cursory view, I noticed the jQuery file being loaded

[jira] [Updated] (OFBIZ-10708) visual-editor not working on ecommerce

2018-12-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10708: -- Summary: visual-editor not working on ecommerce (was: visual-editor not workign on

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722984#comment-16722984 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks [~jacques.le.roux] for the review :)  > Empty

[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728325#comment-16728325 ] Aditya Sharma commented on OFBIZ-10745: --- Makes Sense [~jacques.le.roux]. Thanks for sharing :)  >

[jira] [Commented] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728398#comment-16728398 ] Aditya Sharma commented on OFBIZ-10745: --- Improves code in isPaymentMethodType() and

[jira] [Closed] (OFBIZ-10745) Refactor boolean returns for ShoppingCart methods

2018-12-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10745. - > Refactor boolean returns for ShoppingCart methods >

[jira] [Created] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10724: - Summary: Refactor ServiceUtil.isSuccess() method Key: OFBIZ-10724 URL: https://issues.apache.org/jira/browse/OFBIZ-10724 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10724) Refactor ServiceUtil.isSuccess() method

2018-12-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10724: -- Attachment: OFBIZ-10724.patch > Refactor ServiceUtil.isSuccess() method >

[jira] [Updated] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-26 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10457: -- Description: In reference to the [proposal|https://markmail.org/message/pna6ce3mkssbhg36] 

[jira] [Created] (OFBIZ-10782) Replace jQuery-Timepicker-Addon with flatpickr.js

2019-01-08 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10782: - Summary: Replace jQuery-Timepicker-Addon with flatpickr.js Key: OFBIZ-10782 URL: https://issues.apache.org/jira/browse/OFBIZ-10782 Project: OFBiz Issue

[jira] [Commented] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739099#comment-16739099 ] Aditya Sharma commented on OFBIZ-10785: --- Done for trunk at r1850921. Converted file

[jira] [Created] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
Aditya Sharma created OFBIZ-10785: - Summary: Upgrade jquery-validation plugin from 1.17.0 to 1.19.0 Key: OFBIZ-10785 URL: https://issues.apache.org/jira/browse/OFBIZ-10785 Project: OFBiz

[jira] [Resolved] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-10785. --- Resolution: Done Fix Version/s: 18.12.01 > Upgrade jquery-validation plugin from

[jira] [Commented] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739104#comment-16739104 ] Aditya Sharma commented on OFBIZ-10785: --- Changes can also be backported to R18.12 Done for

[jira] [Comment Edited] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739104#comment-16739104 ] Aditya Sharma edited comment on OFBIZ-10785 at 1/10/19 6:17 AM: Changes

[jira] [Updated] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10785: -- Affects Version/s: Release Branch 18.12 > Upgrade jquery-validation plugin from 1.17.0 to

[jira] [Closed] (OFBIZ-10785) Upgrade jquery-validation plugin from 1.17.0 to 1.19.0

2019-01-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10785. - > Upgrade jquery-validation plugin from 1.17.0 to 1.19.0 >

[jira] [Commented] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736735#comment-16736735 ] Aditya Sharma commented on OFBIZ-10758: --- Done for all instances in custom code for trunk at 

[jira] [Updated] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10758: -- Affects Version/s: Release Branch 18.12 > Replace jQuery.bind() with jQuery.on() >

[jira] [Closed] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10758. - > Replace jQuery.bind() with jQuery.on() > -- > >

[jira] [Resolved] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-10758. --- Resolution: Done Fix Version/s: 18.12.01 > Replace jQuery.bind() with jQuery.on() >

[jira] [Commented] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736747#comment-16736747 ] Aditya Sharma commented on OFBIZ-10758: --- Found following plugins with instances: Fancybox jsTree

[jira] [Commented] (OFBIZ-10758) Replace jQuery.bind() with jQuery.on()

2019-01-07 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16736745#comment-16736745 ] Aditya Sharma commented on OFBIZ-10758: --- Done for all instances in custom code for R18.12 at 

[jira] [Commented] (OFBIZ-10725) Refactor boolean returns from methods

2018-12-28 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16730268#comment-16730268 ] Aditya Sharma commented on OFBIZ-10725: --- Done for all classes under

[jira] [Assigned] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-10 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-9848: Assignee: Aditya Sharma (was: Aishwary Shrivastava) > Replace Inline js with External js

[jira] [Updated] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-10 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9848: - Attachment: OFBIZ-9848.patch > Replace Inline js with External js in renderDateTimeField macro >

[jira] [Commented] (OFBIZ-9978) Upgrade jQuery 1.11.0 to jQuery 3.2.1

2019-01-10 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740127#comment-16740127 ] Aditya Sharma commented on OFBIZ-9978: -- Removed unused jQuery MockJax Plugin. Thanks Michael Brohl

[jira] [Commented] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-10 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740068#comment-16740068 ] Aditya Sharma commented on OFBIZ-9848: -- Attached a patch. I will commit asap. > Replace Inline js

[jira] [Commented] (OFBIZ-10782) Replace jQuery-Timepicker-Addon with flatpickr.js

2019-01-10 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740069#comment-16740069 ] Aditya Sharma commented on OFBIZ-10782: --- Thanks Jacques :-) I will start after OFBIZ-9848. >

[jira] [Closed] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-13 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9848. > Replace Inline js with External js in renderDateTimeField macro >

[jira] [Commented] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-13 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741773#comment-16741773 ] Aditya Sharma commented on OFBIZ-9848: -- Done for trunk at r1851224 and R18.12 at r1851225 > Replace

[jira] [Comment Edited] (OFBIZ-9848) Replace Inline js with External js in renderDateTimeField macro

2019-01-13 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741773#comment-16741773 ] Aditya Sharma edited comment on OFBIZ-9848 at 1/14/19 5:25 AM: --- Done for

[jira] [Assigned] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-10682: - Assignee: Aditya Sharma > When using Select2 for multiple selects the field is too

[jira] [Updated] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10682: -- Attachment: OFBIZ-10682.patch > When using Select2 for multiple selects the field is too

[jira] [Commented] (OFBIZ-10682) When using Select2 for multiple selects the field is too narrow in "no results" case

2018-12-31 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731236#comment-16731236 ] Aditya Sharma commented on OFBIZ-10682: --- Added solution patch. We can fix a specific width for 

[jira] [Assigned] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro

2019-01-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-9850: Assignee: Aditya Sharma > Replace Inline js with External js in renderDateFindField macro

[jira] [Updated] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro

2019-01-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9850: - Attachment: OFBIZ-9850.patch OFBIZ-9850_example.patch > Replace Inline js with

[jira] [Commented] (OFBIZ-9850) Replace Inline js with External js in renderDateFindField macro

2019-01-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741991#comment-16741991 ] Aditya Sharma commented on OFBIZ-9850: -- Added patch. I will commit asap. Added an example in

[jira] [Updated] (OFBIZ-7535) Broken page renders while click on Submit button

2018-09-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-7535: - Affects Version/s: Release Branch 17.12 Trunk

[jira] [Assigned] (OFBIZ-7535) Broken page renders while click on Submit button

2018-09-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-7535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-7535: Assignee: Aditya Sharma (was: Divesh Dutta) > Broken page renders while click on Submit

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724878#comment-16724878 ] Aditya Sharma commented on OFBIZ-10645: --- I will commit in a day if no conflicts. > Empty entity

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724708#comment-16724708 ] Aditya Sharma commented on OFBIZ-10721: --- Thanks [~deepak.dixit] for the review :) Changes that

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724808#comment-16724808 ] Aditya Sharma commented on OFBIZ-10721: --- Done for trunk at r1849275. Started a discussion on the

[jira] [Commented] (OFBIZ-10645) Empty entity name should not be allowed in entity definition

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724898#comment-16724898 ] Aditya Sharma commented on OFBIZ-10645: --- Thanks [~mthl] :) I will test with your changes and

[jira] [Commented] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724875#comment-16724875 ] Aditya Sharma commented on OFBIZ-10721: --- Done for R17.12 at r1849288. > Remove all the fk

[jira] [Updated] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10721: -- Affects Version/s: Release Branch 17.12 Release Branch 16.11 > Remove

[jira] [Updated] (OFBIZ-10721) Remove all the fk dependencies from stats entities to the business entities

2018-12-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10721: -- Fix Version/s: 17.12.01 > Remove all the fk dependencies from stats entities to the business

[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805708#comment-16805708 ] Aditya Sharma commented on OFBIZ-9849: -- Done for trunk at R1856610 and R18.12 at R1856611. Silghtly

[jira] [Closed] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9849. > Replace Inline js with External js in renderDropDownField macro >

[jira] [Closed] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-10759. - > Replace document.write() occurrences with some legitimate code >

[jira] [Commented] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805782#comment-16805782 ] Aditya Sharma commented on OFBIZ-10759: --- I think the plugin is no longer visible and the code is

[jira] [Resolved] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-10759. --- Resolution: Done Fix Version/s: 18.12.01 > Replace document.write() occurrences with

[jira] [Commented] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805715#comment-16805715 ] Aditya Sharma commented on OFBIZ-10759: --- Hi [~jacques.le.roux] , I can still find some instances

[jira] [Resolved] (OFBIZ-9089) Unit test case for service - createProductFeatureType

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-9089. -- Resolution: Done Fix Version/s: 18.12.01 > Unit test case for service -

[jira] [Closed] (OFBIZ-9089) Unit test case for service - createProductFeatureType

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-9089. > Unit test case for service - createProductFeatureType >

[jira] [Commented] (OFBIZ-9089) Unit test case for service - createProductFeatureType

2019-03-30 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805738#comment-16805738 ] Aditya Sharma commented on OFBIZ-9089: -- Done for trunk at r1856613 and 18.12 at r1856614 Slightly

[jira] [Closed] (OFBIZ-6531) Support transaction-timout for

2019-02-24 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-6531. Resolution: Won't Do I close this issue [as discussed in dev

[jira] [Commented] (OFBIZ-9849) Replace Inline js with External js in renderDropDownField macro

2019-03-09 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788611#comment-16788611 ] Aditya Sharma commented on OFBIZ-9849: -- Hi Dhaval, While applying your patch I noticed that

[jira] [Commented] (OFBIZ-10759) Replace document.write() occurrences with some legitimate code

2019-03-08 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788559#comment-16788559 ] Aditya Sharma commented on OFBIZ-10759: --- Removed js code and added Js files in LookupDecorator.

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-05 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856606#comment-16856606 ] Aditya Sharma commented on OFBIZ-10639: --- Thanks for your patch [~deepak.nigam] :) Few inputs from

[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.

2019-06-05 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856793#comment-16856793 ] Aditya Sharma commented on OFBIZ-10093: --- While exploring about Summernote I just noticed it

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-05 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856794#comment-16856794 ] Aditya Sharma commented on OFBIZ-10639: --- Thanks [~jacques.le.roux] :) > Cookie Consent In

[jira] [Assigned] (OFBIZ-10729) Add subscribe email on website mailing list page

2019-06-05 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-10729: - Assignee: Aditya Sharma > Add subscribe email on website mailing list page >

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865307#comment-16865307 ] Aditya Sharma commented on OFBIZ-10678: ---   Thanks Jacques :) I just observed a quirk, the screen

[jira] [Comment Edited] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-16 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865307#comment-16865307 ] Aditya Sharma edited comment on OFBIZ-10678 at 6/17/19 5:11 AM: Thanks

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865503#comment-16865503 ] Aditya Sharma commented on OFBIZ-10678: --- Sure Jacques. As the plugin is only used on

[jira] [Comment Edited] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866268#comment-16866268 ] Aditya Sharma edited comment on OFBIZ-10678 at 6/18/19 6:06 AM: Updated

[jira] [Updated] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10678: -- Attachment: OFBIZ-10678.patch > CLONE - Check embedded Javascript libs vulnerabilities using

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866268#comment-16866268 ] Aditya Sharma commented on OFBIZ-10678: --- Updated the patch with featherlight plugin. Added custom

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866380#comment-16866380 ] Aditya Sharma commented on OFBIZ-10678: --- I am not able to reproduce it on my local. Though I just

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-13 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862779#comment-16862779 ] Aditya Sharma commented on OFBIZ-10639: --- HI [~deepak.nigam] , Thanks for the updated patch. I

[jira] [Comment Edited] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-13 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16862779#comment-16862779 ] Aditya Sharma edited comment on OFBIZ-10639 at 6/13/19 7:09 AM: Hi

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865748#comment-16865748 ] Aditya Sharma commented on OFBIZ-10678: --- Found some more plugins.

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-19 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867475#comment-16867475 ] Aditya Sharma commented on OFBIZ-10639: --- Sounds like a plan to me Jacques :) > Cookie Consent In

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-20 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868376#comment-16868376 ] Aditya Sharma commented on OFBIZ-10678: --- For

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869306#comment-16869306 ] Aditya Sharma commented on OFBIZ-10639: --- As per the post I explored, it can last maximum 1 year.

[jira] [Comment Edited] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-21 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16869306#comment-16869306 ] Aditya Sharma edited comment on OFBIZ-10639 at 6/21/19 9:04 AM: As per

[jira] [Updated] (OFBIZ-9533) User should be notified with success message on MRP run in manufacturing component

2019-06-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9533: - Component/s: (was: ALL COMPONENTS) manufacturing > User should be notified

[jira] [Updated] (OFBIZ-9533) User should be notified with success message on MRP run in manufacturing component

2019-06-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-9533: - Affects Version/s: Release Branch 18.12 Release Branch 17.12 > User

[jira] [Commented] (OFBIZ-9533) User should be notified with success message on MRP run in manufacturing component

2019-06-22 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16870144#comment-16870144 ] Aditya Sharma commented on OFBIZ-9533: -- Thanks Pierre for pointing that out. I think when I have

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-10 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859849#comment-16859849 ] Aditya Sharma commented on OFBIZ-10678: --- Hi [~jacques.le.roux] , I did some findings around them.

[jira] [Updated] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10639: -- Attachment: image-2019-06-18-16-55-24-395.png > Cookie Consent In E-Commerce >

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866448#comment-16866448 ] Aditya Sharma commented on OFBIZ-10678: --- Done for 16.11 at r1861566. Thanks Jacques for the

[jira] [Commented] (OFBIZ-10678) CLONE - Check embedded Javascript libs vulnerabilities using retire.js

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10678?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866457#comment-16866457 ] Aditya Sharma commented on OFBIZ-10678: --- For favicon icon I think it uses LookupDecorator and we

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866504#comment-16866504 ] Aditya Sharma commented on OFBIZ-10639: --- +1 I think we should go with

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-18 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866576#comment-16866576 ] Aditya Sharma commented on OFBIZ-10639: --- {quote}I mean you have an option to accept necessary

[jira] [Commented] (OFBIZ-10639) Cookie Consent In E-Commerce

2019-06-17 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865450#comment-16865450 ] Aditya Sharma commented on OFBIZ-10639: ---   {quote}From that plugin, I removed the feature of

[jira] [Comment Edited] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

2019-05-13 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838420#comment-16838420 ] Aditya Sharma edited comment on OFBIZ-10934 at 5/13/19 9:49 AM: Adding

[jira] [Commented] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

2019-05-13 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16838420#comment-16838420 ] Aditya Sharma commented on OFBIZ-10934: --- Adding to Mathieu's comment Jira itself handles patch

[jira] [Assigned] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-11029: - Assignee: Aditya Sharma (was: Pawan Verma) > Issue in function

[jira] [Commented] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16840021#comment-16840021 ] Aditya Sharma commented on OFBIZ-11029: --- Thanks Denglong Zhou for reporting the issue, Pawan Verma

[jira] [Resolved] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma resolved OFBIZ-11029. --- Resolution: Fixed Fix Version/s: 18.12.01 16.11.06

[jira] [Closed] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma closed OFBIZ-11029. - > Issue in function getVariantSelectionFeatures of ProductWorker.java >

[jira] [Updated] (OFBIZ-11029) Issue in function getVariantSelectionFeatures of ProductWorker.java

2019-05-14 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-11029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-11029: -- Affects Version/s: (was: 18.12.01) (was: 16.11.05)

[jira] [Commented] (OFBIZ-9978) Upgrade jQuery 1.11.0 to jQuery 3.2.1

2019-04-29 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-9978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16829104#comment-16829104 ] Aditya Sharma commented on OFBIZ-9978: -- Hi Jacques, Yes, We can close it for now. > Upgrade jQuery

[jira] [Assigned] (OFBIZ-10962) UI issues on Edit Product page

2019-04-27 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma reassigned OFBIZ-10962: - Assignee: Aditya Sharma (was: Garima jain) > UI issues on Edit Product page >

[jira] [Updated] (OFBIZ-10962) UI issues on Edit Product page

2019-04-27 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aditya Sharma updated OFBIZ-10962: -- Attachment: screenshot-1.png > UI issues on Edit Product page >

[jira] [Commented] (OFBIZ-10962) UI issues on Edit Product page

2019-04-27 Thread Aditya Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827582#comment-16827582 ] Aditya Sharma commented on OFBIZ-10962: --- Is it possible to solve this issue with some media

<    2   3   4   5   6   7   8   9   10   >