sonarcloud[bot] commented on pull request #386:
URL: https://github.com/apache/ofbiz-framework/pull/386#issuecomment-986245877
Kudos, SonarCloud Quality Gate passed! 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
sonarcloud[bot] commented on pull request #387:
URL: https://github.com/apache/ofbiz-framework/pull/387#issuecomment-986559425
Kudos, SonarCloud Quality Gate passed! 
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
JacquesLeRoux merged pull request #386:
URL: https://github.com/apache/ofbiz-framework/pull/386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #390:
URL: https://github.com/apache/ofbiz-framework/pull/390
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk
demo with userId = auditor, accessing the Financial Account overview screen,
sees editable fields and/or triggers (to
PierreSmits opened a new pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391
Removing unused labels from AccountingUiLabels.xml
Checked screens, forms, templates, scripts and java code
--
This is an automated message from the Apache Git Service.
To respond to
sonarcloud[bot] commented on pull request #390:
URL: https://github.com/apache/ofbiz-framework/pull/390#issuecomment-986893408
Kudos, SonarCloud Quality Gate passed! : "Some efforts have been done to produce those.
Are we sure we want to remove them? This does not break anything and can s
JacquesLeRoux edited a comment on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-987893446
Pierre,
Today I asked myself (again): "Some efforts have been done to produce those.
Are we sure we want to remove them? This does not break anything an
JacquesLeRoux merged pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-987908621
Hi Jacques,
Thank you for taking the time to look back, and see why something came about
to be.
These things, like so many others in the codebase, came t
JacquesLeRoux commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-988067070
Yes, we can always revert (easy with labels, not much changes now).
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
JacquesLeRoux merged pull request #385:
URL: https://github.com/apache/ofbiz-framework/pull/385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux commented on pull request #393:
URL: https://github.com/apache/ofbiz-framework/pull/393#issuecomment-988084294
Pierre,
I guess you will continue to disable for auditor (or alike) the screens
accessible from this screen? As it would not make sense to disable the menus
t
JacquesLeRoux merged pull request #393:
URL: https://github.com/apache/ofbiz-framework/pull/393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #392:
URL: https://github.com/apache/ofbiz-framework/pull/392
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux commented on pull request #392:
URL: https://github.com/apache/ofbiz-framework/pull/392#issuecomment-988097190
I'll now adapt the commit comment when there are several commits...
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
PierreSmits commented on pull request #393:
URL: https://github.com/apache/ofbiz-framework/pull/393#issuecomment-98881
Hi Jacques,
Thanks for the question.
How do you mean 'disable the menus'? As in the whole menu for a given
screen? Or multiple screens related to same object
PierreSmits commented on pull request #128:
URL: https://github.com/apache/ofbiz-framework/pull/128#issuecomment-988119027
Implemented via the merge of PR388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
PierreSmits closed pull request #128:
URL: https://github.com/apache/ofbiz-framework/pull/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
JacquesLeRoux commented on pull request #393:
URL: https://github.com/apache/ofbiz-framework/pull/393#issuecomment-988145288
Forget it, I just meant that the screens accessible from the sub-menus
should still be accessible, nothing new.
--
This is an automated message from the Apache Git
PierreSmits opened a new pull request #394:
URL: https://github.com/apache/ofbiz-framework/pull/394
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #394:
URL: https://github.com/apache/ofbiz-framework/pull/394#issuecomment-988572812
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
JacquesLeRoux merged pull request #388:
URL: https://github.com/apache/ofbiz-framework/pull/388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #394:
URL: https://github.com/apache/ofbiz-framework/pull/394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #395:
URL: https://github.com/apache/ofbiz-framework/pull/395
Currently, a user with only 'VIEW' permissions, as demonstrated in trunk
demo with userId = auditor, accessing the Financial Account transactions screen
sees editable fields and/or triggers
sonarcloud[bot] commented on pull request #395:
URL: https://github.com/apache/ofbiz-framework/pull/395#issuecomment-988637984
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
PierreSmits opened a new pull request #396:
URL: https://github.com/apache/ofbiz-framework/pull/396
Though there is an entity PaymentAttribute this cannot be accessed by user
with VIEW permissions when accessing a Payment.
See:
for entity data:
https://demo-trunk.ofbiz.apache.org/web
sonarcloud[bot] commented on pull request #396:
URL: https://github.com/apache/ofbiz-framework/pull/396#issuecomment-988670270
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
JacquesLeRoux merged pull request #395:
URL: https://github.com/apache/ofbiz-framework/pull/395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #397:
URL: https://github.com/apache/ofbiz-framework/pull/397
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #397:
URL: https://github.com/apache/ofbiz-framework/pull/397#issuecomment-988746800
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
PierreSmits closed pull request #357:
URL: https://github.com/apache/ofbiz-framework/pull/357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
PierreSmits closed pull request #117:
URL: https://github.com/apache/ofbiz-framework/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
PierreSmits opened a new pull request #398:
URL: https://github.com/apache/ofbiz-framework/pull/398
The configuration of an OFBiz is determined by 2 aspects:
configuration settings required to successfully start the implementation
configuration settings required to have component funct
sonarcloud[bot] commented on pull request #398:
URL: https://github.com/apache/ofbiz-framework/pull/398#issuecomment-988831070
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
PierreSmits opened a new pull request #399:
URL: https://github.com/apache/ofbiz-framework/pull/399
Currently, when a user with only VIEW permissions accesses the manufacturing
component menu-items of the ManufacturingAppBar are not shown due to too
restrictive conditions.
These menu-it
sonarcloud[bot] commented on pull request #399:
URL: https://github.com/apache/ofbiz-framework/pull/399#issuecomment-988867617
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
PierreSmits opened a new pull request #400:
URL: https://github.com/apache/ofbiz-framework/pull/400
In some screens the $ currency symbol is not showing well. I guess it's true
for all screens so I put all applications and plugins. I don't know if only
trunk is affected.
Modified:
sonarcloud[bot] commented on pull request #400:
URL: https://github.com/apache/ofbiz-framework/pull/400#issuecomment-988957766
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
sonarcloud[bot] removed a comment on pull request #400:
URL: https://github.com/apache/ofbiz-framework/pull/400#issuecomment-988957766
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge
sonarcloud[bot] commented on pull request #400:
URL: https://github.com/apache/ofbiz-framework/pull/400#issuecomment-988971609
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
JacquesLeRoux merged pull request #400:
URL: https://github.com/apache/ofbiz-framework/pull/400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #396:
URL: https://github.com/apache/ofbiz-framework/pull/396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
sonarcloud[bot] commented on pull request #401:
URL: https://github.com/apache/ofbiz-framework/pull/401#issuecomment-989904013
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
PierreSmits opened a new pull request #402:
URL: https://github.com/apache/ofbiz-framework/pull/402
Improved: labels in CommonUiLabels.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
sonarcloud[bot] commented on pull request #402:
URL: https://github.com/apache/ofbiz-framework/pull/402#issuecomment-989928919
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
JacquesLeRoux merged pull request #402:
URL: https://github.com/apache/ofbiz-framework/pull/402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #403:
URL: https://github.com/apache/ofbiz-framework/pull/403
Currently the create buttons for the main objects of the accounting
application are located within find and profile widgets/templates of those
objects.
In order to improve the usability o
sonarcloud[bot] commented on pull request #403:
URL: https://github.com/apache/ofbiz-framework/pull/403#issuecomment-990713917
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
PierreSmits closed pull request #181:
URL: https://github.com/apache/ofbiz-framework/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
PierreSmits commented on pull request #181:
URL: https://github.com/apache/ofbiz-framework/pull/181#issuecomment-990725799
Closing due to going stale. Superseded by PR 403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
JacquesLeRoux merged pull request #399:
URL: https://github.com/apache/ofbiz-framework/pull/399
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #403:
URL: https://github.com/apache/ofbiz-framework/pull/403
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #404:
URL: https://github.com/apache/ofbiz-framework/pull/404
With the implementation of the Accounting MainActionMenu, various menu-items
and/or other triggers to create an object are now obsolete
modified:
AccountingMenus.xml
- removed 'c
PierreSmits commented on pull request #397:
URL: https://github.com/apache/ofbiz-framework/pull/397#issuecomment-990762065
Hi Jacques,
Thanks for the feedback. I'll look into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
sonarcloud[bot] commented on pull request #404:
URL: https://github.com/apache/ofbiz-framework/pull/404#issuecomment-990762392
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
JacquesLeRoux merged pull request #397:
URL: https://github.com/apache/ofbiz-framework/pull/397
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #405:
URL: https://github.com/apache/ofbiz-framework/pull/405
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #405:
URL: https://github.com/apache/ofbiz-framework/pull/405#issuecomment-990832606
Kudos, SonarCloud Quality Gate passed! 
Currently the create buttons for the main objects of the manufacturing
application are located within find and profile widgets/templates of those
objects
sonarcloud[bot] commented on pull request #406:
URL: https://github.com/apache/ofbiz-framework/pull/406#issuecomment-990892664
Kudos, SonarCloud Quality Gate passed! .
I noticed this that seems a too ear
PierreSmits commented on pull request #398:
URL: https://github.com/apache/ofbiz-framework/pull/398#issuecomment-991879095
Hi Jacques,
My apologies. I must have missed those two. I will amend.
Thanks for the observation and the review.
--
This is an automated message from th
sonarcloud[bot] removed a comment on pull request #398:
URL: https://github.com/apache/ofbiz-framework/pull/398#issuecomment-988831070
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge
sonarcloud[bot] commented on pull request #398:
URL: https://github.com/apache/ofbiz-framework/pull/398#issuecomment-991880715
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
JacquesLeRoux merged pull request #398:
URL: https://github.com/apache/ofbiz-framework/pull/398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #406:
URL: https://github.com/apache/ofbiz-framework/pull/406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #405:
URL: https://github.com/apache/ofbiz-framework/pull/405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
JacquesLeRoux merged pull request #404:
URL: https://github.com/apache/ofbiz-framework/pull/404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: no
PierreSmits opened a new pull request #407:
URL: https://github.com/apache/ofbiz-framework/pull/407
Currently the create buttons for the main objects of the order components
are located within the find and profile widgets/templates of those object.
In order to improve the usability of OF
PierreSmits closed pull request #170:
URL: https://github.com/apache/ofbiz-framework/pull/170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: noti
PierreSmits commented on pull request #170:
URL: https://github.com/apache/ofbiz-framework/pull/170#issuecomment-991933721
Closing due to going stale. Superseded by PR 407
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
sonarcloud[bot] commented on pull request #407:
URL: https://github.com/apache/ofbiz-framework/pull/407#issuecomment-991933712
Kudos, SonarCloud Quality Gate passed! ![Quality Gate
passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-
PierreSmits opened a new pull request #408:
URL: https://github.com/apache/ofbiz-framework/pull/408
According to the definition in widget-form.xsd the use of a combination of a
form with type="list" is deprecated in favour of a grid.
Refactor various list forms into grids.
Refactor va
sonarcloud[bot] commented on pull request #408:
URL: https://github.com/apache/ofbiz-framework/pull/408#issuecomment-991939565
Kudos, SonarCloud Quality Gate passed! 