[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #30: a plugin to log csp errors reported by the browsers.

2020-09-20 Thread GitBox
sonarcloud[bot] removed a comment on pull request #30: URL: https://github.com/apache/ofbiz-plugins/pull/30#issuecomment-683537492 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=30=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #204: added a report uri and unsafe-inline to the csp header.

2020-09-20 Thread GitBox
sonarcloud[bot] commented on pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204#issuecomment-695815850 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=204=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #204: added a report uri and unsafe-inline to the csp header.

2020-09-20 Thread GitBox
sonarcloud[bot] removed a comment on pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204#issuecomment-685696165 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=204=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #230: WIP: Implemented: Use NPM with gradle to get external JS dependencies (OFBIZ-11960)

2020-09-20 Thread GitBox
JacquesLeRoux commented on pull request #230: URL: https://github.com/apache/ofbiz-framework/pull/230#issuecomment-695823882 Hi Aditya, I just checked and we are still in the same situation, TIA This is an

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-23 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-715249505 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-714451694 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-22 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-714451694 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] lodhiravi opened a new pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-22 Thread GitBox
lodhiravi opened a new pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45 Done following- 1. Headless Commerce Plugin initial directory structures. 2. Started adding API endpoints. Thanks:

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-10-23 Thread GitBox
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-715473955 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #27: OFBIZ-11756 vue js renderer

2020-10-23 Thread GitBox
sonarcloud[bot] removed a comment on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-702762946 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-28 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717905185 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-28 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717747047 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-28 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717271064 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-28 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717747047 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-25 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-715918134 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-25 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-716296866 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-25 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-716294058 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-25 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-716294058 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717086085 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-716529712 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717263889 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717263589 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717086085 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717263589 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717271064 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-27 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-717263889 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #236: Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)

2020-10-26 Thread GitBox
sonarcloud[bot] commented on pull request #236: URL: https://github.com/apache/ofbiz-framework/pull/236#issuecomment-716543909 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=236=false=BUG)

[GitHub] [ofbiz-framework] ingo-koenemann opened a new pull request #236: Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047)

2020-10-26 Thread GitBox
ingo-koenemann opened a new pull request #236: URL: https://github.com/apache/ofbiz-framework/pull/236 Improved: Remove _PREVIOUS_REQUEST_ Session Attribute on non-authentication pages (OFBIZ-12047) Added removal of the _PREVIOUS_REQUEST_ attribute when requesting non-authenticated

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-26 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-716529712 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-26 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-716296866 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-24 Thread GitBox
sonarcloud[bot] removed a comment on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-715249505 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #45: WIP: Headless Commerce Plugin Implementation

2020-10-24 Thread GitBox
sonarcloud[bot] commented on pull request #45: URL: https://github.com/apache/ofbiz-plugins/pull/45#issuecomment-715918134 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=45=false=BUG)

[GitHub] [ofbiz-framework] PierreSmits commented on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

2020-07-17 Thread GitBox
PierreSmits commented on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-659888727 If we're talking about an action here, why don't we call it 'action'? This is an automated message

[GitHub] [ofbiz-framework] girishvasmatkar commented on pull request #214: Implemented: New service definition attribute "verb" to denote the corresponding HTTP method (OFBIZ-11328)

2020-07-17 Thread GitBox
girishvasmatkar commented on pull request #214: URL: https://github.com/apache/ofbiz-framework/pull/214#issuecomment-659904734 @PierreSmits : "action" makes more sense. I'll change the attribute name and then merge. Thanks.

[GitHub] [ofbiz-framework] surajkhurana merged pull request #215: Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894)

2020-07-21 Thread GitBox
surajkhurana merged pull request #215: URL: https://github.com/apache/ofbiz-framework/pull/215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #215: Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894)

2020-07-19 Thread GitBox
priyasharma1 opened a new pull request #215: URL: https://github.com/apache/ofbiz-framework/pull/215 (OFBIZ-11894) - Removed the java implementation - Converted the service to entity-auto - Updated the service call in Party tests where this service was used.

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #215: Improved : Convert createRoleType service to entity-auto from Java and update its service calls (OFBIZ-11894)

2020-07-19 Thread GitBox
sonarcloud[bot] commented on pull request #215: URL: https://github.com/apache/ofbiz-framework/pull/215#issuecomment-660635724 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=215=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-07-29 Thread GitBox
sonarcloud[bot] commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-665603293 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=220=false=BUG)

[GitHub] [ofbiz-framework] danwatford edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
danwatford edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665611006 I'm don't know how to resolve this @JacquesLeRoux . Before the most recent merge commit a few moments ago I attempted to apply the patch you linked to

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665608381 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] fehnomenal opened a new pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-07-29 Thread GitBox
fehnomenal opened a new pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220 Improved: Make the latitude and longitude fields of `GeoPoint` numeric Explanation: Before this commit both are stored as strings in the database and at least PostgreSQL does not

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
sonarcloud[bot] removed a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665190079 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=217=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665512570 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [ofbiz-framework] danwatford commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
danwatford commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665611006 I'm don't know how to resolve this @JacquesLeRoux . Before the most recent merge commit a few moments ago I attempted to apply the patch you linked to against trunk

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-29 Thread GitBox
JacquesLeRoux edited a comment on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-665591935 OK, GH is not able to show the zipped WidgetWorker.java.rej.zip file in preview above despite saying it's uploaded :/. Trying here rather... OK

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668096472 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #27: OFBIZ-11756 vue js renderer

2020-08-03 Thread GitBox
sonarcloud[bot] removed a comment on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668083695 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668083695 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-03 Thread GitBox
JacquesLeRoux commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-668131743 Hi Wiebke, Yes: in https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions, HTH

[GitHub] [ofbiz-framework] wpaetzold commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-03 Thread GitBox
wpaetzold commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-668054832 Hi @JacquesLeRoux, I did not notice that I exceeded the max line length. I am sorry about this and I will gladly correct it. Is there a formatter for eclipse

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #14: Implemented: Added new inventory cycle count feature for warehouse.

2020-08-03 Thread GitBox
sonarcloud[bot] commented on pull request #14: URL: https://github.com/apache/ofbiz-framework/pull/14#issuecomment-668385084 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=14=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-669061057 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #27: OFBIZ-11756 vue js renderer

2020-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-668096472 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #169: OFBIZ-11756 vue js renderer

2020-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #169: URL: https://github.com/apache/ofbiz-framework/pull/169#issuecomment-669065582 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=169=false=BUG)

[GitHub] [ofbiz-plugins] priyasharma1 opened a new pull request #37: Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

2020-08-07 Thread GitBox
priyasharma1 opened a new pull request #37: URL: https://github.com/apache/ofbiz-plugins/pull/37 (OFBIZ-11930) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #224: Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

2020-08-07 Thread GitBox
priyasharma1 opened a new pull request #224: URL: https://github.com/apache/ofbiz-framework/pull/224 (OFBIZ-11930) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #37: Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

2020-08-07 Thread GitBox
sonarcloud[bot] commented on pull request #37: URL: https://github.com/apache/ofbiz-plugins/pull/37#issuecomment-670381807 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=37=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #224: Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

2020-08-07 Thread GitBox
sonarcloud[bot] commented on pull request #224: URL: https://github.com/apache/ofbiz-framework/pull/224#issuecomment-670381398 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=224=false=BUG)

[GitHub] [ofbiz-framework] priyasharma1 closed pull request #223: Improved: Make all related Cancel/Done buttons return to backHome ie. party profile page (OFBIZ-11943)

2020-08-07 Thread GitBox
priyasharma1 closed pull request #223: URL: https://github.com/apache/ofbiz-framework/pull/223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] surajkhurana merged pull request #37: Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

2020-08-07 Thread GitBox
surajkhurana merged pull request #37: URL: https://github.com/apache/ofbiz-plugins/pull/37 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ofbiz-framework] surajkhurana merged pull request #224: Improved: Removed unused imports from Java files for fixing checkstyle errors (OFBIZ-11930)

2020-08-07 Thread GitBox
surajkhurana merged pull request #224: URL: https://github.com/apache/ofbiz-framework/pull/224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #205: set xmlns to many WEB-INF/web.xml files.

2020-08-12 Thread GitBox
sonarcloud[bot] commented on pull request #205: URL: https://github.com/apache/ofbiz-framework/pull/205#issuecomment-672810198 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #205: set xmlns to many WEB-INF/web.xml files.

2020-08-12 Thread GitBox
sonarcloud[bot] removed a comment on pull request #205: URL: https://github.com/apache/ofbiz-framework/pull/205#issuecomment-658411351 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=205=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #204: added a report uri and unsafe-inline to the csp header.

2020-08-12 Thread GitBox
sonarcloud[bot] commented on pull request #204: URL: https://github.com/apache/ofbiz-framework/pull/204#issuecomment-672810749 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=204=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
sonarcloud[bot] commented on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-666319404 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=221=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
JacquesLeRoux commented on pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217#issuecomment-666229891 HI Daniel, That would be perfect, working and updating from trunk HEAD should work, TIA This

[GitHub] [ofbiz-framework] JacquesLeRoux closed pull request #217: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
JacquesLeRoux closed pull request #217: URL: https://github.com/apache/ofbiz-framework/pull/217 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] danwatford opened a new pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
danwatford opened a new pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221 Refactoring of WidgetWorker so that it generates URI and JSoup Element objects to represent created URLs, hidden forms and anchor tags. This replaces the previous approach where

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-07-30 Thread GitBox
JacquesLeRoux commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-666306192 Hi fehnomenal, Did you check the implications on the other locations in code where latitude and longitude are used? Thanks

[GitHub] [ofbiz-framework] danwatford commented on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-30 Thread GitBox
danwatford commented on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-666318149 @JacquesLeRoux New PR created after applying the code changes to trunk HEAD. Patching should be cleaner this time.

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-02 Thread GitBox
JacquesLeRoux commented on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-667652461 Hi Wiebke, Just a cursory review for now, please respect the max filelenght (150), TIA This

[GitHub] [ofbiz-framework] JacquesLeRoux edited a comment on pull request #209: OFBIZ-11446 Improved: Convert ContentPermissionServices.xml mini lang to groovy

2020-08-02 Thread GitBox
JacquesLeRoux edited a comment on pull request #209: URL: https://github.com/apache/ofbiz-framework/pull/209#issuecomment-667652461 Hi Wiebke, Just a cursory review for now, please respect the max linelenght (150), TIA

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-31 Thread GitBox
JacquesLeRoux merged pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-31 Thread GitBox
sonarcloud[bot] commented on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-667228770 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=221=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #221: Improved: WidgetWorker should not write generated html to Appendable (OFBIZ-11907)

2020-07-31 Thread GitBox
sonarcloud[bot] removed a comment on pull request #221: URL: https://github.com/apache/ofbiz-framework/pull/221#issuecomment-666319404 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=221=false=BUG)

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #222: Improved: Remove unused imports from Java files (OFBIZ-11930)

2020-08-05 Thread GitBox
priyasharma1 opened a new pull request #222: URL: https://github.com/apache/ofbiz-framework/pull/222 (OFBIZ-11930) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [ofbiz-plugins] priyasharma1 opened a new pull request #36: Improved: Remove unused imports from Java files (OFBIZ-11930)

2020-08-05 Thread GitBox
priyasharma1 opened a new pull request #36: URL: https://github.com/apache/ofbiz-plugins/pull/36 (OFBIZ-11930) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #27: OFBIZ-11756 vue js renderer

2020-08-05 Thread GitBox
sonarcloud[bot] removed a comment on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-669061057 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #27: OFBIZ-11756 vue js renderer

2020-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #27: URL: https://github.com/apache/ofbiz-plugins/pull/27#issuecomment-669169607 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=27=false=BUG)

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #222: Improved: Remove unused imports from Java files (OFBIZ-11930)

2020-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #222: URL: https://github.com/apache/ofbiz-framework/pull/222#issuecomment-669175053 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=222=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #36: Improved: Remove unused imports from Java files (OFBIZ-11930)

2020-08-05 Thread GitBox
sonarcloud[bot] commented on pull request #36: URL: https://github.com/apache/ofbiz-plugins/pull/36#issuecomment-669180768 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=36=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-06 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-669865493 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-06 Thread GitBox
sonarcloud[bot] removed a comment on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-669857875 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-06 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-669857875 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-06 Thread GitBox
sonarcloud[bot] removed a comment on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-667886102 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #223: Improved: Makes all related Cancel/Done buttons return to backHome ie. party profile page (OFBIZ-11943)

2020-08-06 Thread GitBox
priyasharma1 opened a new pull request #223: URL: https://github.com/apache/ofbiz-framework/pull/223 Explanation - Updated the targets to 'backHome' so as to return back to the profile page - Added roleTypeId on other instances as it is because of this missing parameter that the

[GitHub] [ofbiz-plugins] sonarcloud[bot] removed a comment on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-06 Thread GitBox
sonarcloud[bot] removed a comment on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-669865493 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #35: Implemented: (OFBIZ-11328) Added a new component to provide REST capabilities to OFBiz.

2020-08-06 Thread GitBox
sonarcloud[bot] commented on pull request #35: URL: https://github.com/apache/ofbiz-plugins/pull/35#issuecomment-669891871 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=35=false=BUG)

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #223: Improved: Make all related Cancel/Done buttons return to backHome ie. party profile page (OFBIZ-11943)

2020-08-06 Thread GitBox
JacquesLeRoux commented on pull request #223: URL: https://github.com/apache/ofbiz-framework/pull/223#issuecomment-669883947 We need another Jira for similar issues on the same page This is an automated message from the

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #223: Improved: Make all related Cancel/Done buttons return to backHome ie. party profile page (OFBIZ-11943)

2020-08-06 Thread GitBox
JacquesLeRoux commented on pull request #223: URL: https://github.com/apache/ofbiz-framework/pull/223#issuecomment-669883724 Closing as it was committed as a slightly modified patch This is an automated message from the

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #223: Improved: Make all related Cancel/Done buttons return to backHome ie. party profile page (OFBIZ-11943)

2020-08-06 Thread GitBox
sonarcloud[bot] commented on pull request #223: URL: https://github.com/apache/ofbiz-framework/pull/223#issuecomment-669778179 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=223=false=BUG)

[GitHub] [ofbiz-plugins] surajkhurana merged pull request #36: Improved: Remove unused imports from Java files (OFBIZ-11930)

2020-08-06 Thread GitBox
surajkhurana merged pull request #36: URL: https://github.com/apache/ofbiz-plugins/pull/36 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [ofbiz-framework] surajkhurana merged pull request #222: Improved: Remove unused imports from Java files (OFBIZ-11930)

2020-08-06 Thread GitBox
surajkhurana merged pull request #222: URL: https://github.com/apache/ofbiz-framework/pull/222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-framework] sonarcloud[bot] commented on pull request #225: Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575)

2020-08-11 Thread GitBox
sonarcloud[bot] commented on pull request #225: URL: https://github.com/apache/ofbiz-framework/pull/225#issuecomment-671827107 SonarCloud Quality Gate failed. [](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework=225=false=BUG)

[GitHub] [ofbiz-plugins] sonarcloud[bot] commented on pull request #38: Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575)

2020-08-11 Thread GitBox
sonarcloud[bot] commented on pull request #38: URL: https://github.com/apache/ofbiz-plugins/pull/38#issuecomment-671826188 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_ofbiz-plugins=38=false=BUG)

[GitHub] [ofbiz-framework] priyasharma1 opened a new pull request #225: Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575)

2020-08-11 Thread GitBox
priyasharma1 opened a new pull request #225: URL: https://github.com/apache/ofbiz-framework/pull/225 (OFBIZ-10575) This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [ofbiz-plugins] priyasharma1 opened a new pull request #38: Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575)

2020-08-11 Thread GitBox
priyasharma1 opened a new pull request #38: URL: https://github.com/apache/ofbiz-plugins/pull/38 (OFBIZ-10575) This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #220: Make latitude and longitude numeric fields for correct comparisons

2020-08-11 Thread GitBox
JacquesLeRoux commented on pull request #220: URL: https://github.com/apache/ofbiz-framework/pull/220#issuecomment-671840152 Hi fehnomenal, From https://github.com/fehnomenal/ofbiz-framework/tree/numeric-latlon I guess you used trunk. I did the same locally and

[GitHub] [ofbiz-framework] JacquesLeRoux merged pull request #225: Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575)

2020-08-11 Thread GitBox
JacquesLeRoux merged pull request #225: URL: https://github.com/apache/ofbiz-framework/pull/225 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [ofbiz-plugins] JacquesLeRoux merged pull request #38: Improved: Move 'SecurityPermission' data to seed data files (OFBIZ-10575)

2020-08-11 Thread GitBox
JacquesLeRoux merged pull request #38: URL: https://github.com/apache/ofbiz-plugins/pull/38 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

<    3   4   5   6   7   8   9   10   11   12   >