[jira] [Assigned] (OFBIZ-9198) Missing file results in infinite loop
[ https://issues.apache.org/jira/browse/OFBIZ-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-9198: -- Assignee: Jacques Le Roux > Missing file results in infinite loop > - > > Key: OFBIZ-9198 > URL: https://issues.apache.org/jira/browse/OFBIZ-9198 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 13.07, Trunk, Release Branch 15.12, > Release Branch 16.11 >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Critical > Attachments: errror.txt > > > When accessing a file/image in ecommerce (only seo version) that is > physically missing or the dataresource attribute isPublic=="N" the request > results in an infinite loop. > Demo data: > statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" dataResourceName="Test > Image" objectInfo="PATH TO FILE" isPublic="N" /> > dataResourceId="testurl" statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" > objectInfo="/testbild-content" isPublic="N"/> > contentAssocTypeId="ALTERNATE_URL" fromDate="2006-09-22 00:00:00.0"/> > Call: > /ecomseo/testbild-content > /ecomseo/stream?contentId=test > I found that because I had server problems (server down), so it is quite easy > to kill the server by streaming a not existing contentId via via the ecomseo > app. > /ecomseo/stream?contentId=test1 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9198) Missing file results in infinite loop
[ https://issues.apache.org/jira/browse/OFBIZ-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850552#comment-15850552 ] Jacques Le Roux commented on OFBIZ-9198: Ouch! It's not exactly an infinite loop. Here it tooks 4+ seconds {code} 2017-02-02 22:29:18,344 |http-nio-8443-exec-8 |ControlServlet |T| [[[stream(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] [...] 2017-02-02 22:29:22,410 |http-nio-8443-exec-8 |ControlServlet |T| [[[stream(Domain:https://localhost)] Request Done- total:4.066,since last([stream(Domain:ht...):4.066]] {code} But indeed it can be easily used with a massive DDOS. So this is a security issue and since it's already disclosed I make it a subtask of OFBIZ-1525 Please Ingo note that in case of security issues the ASF has some logical recommendation that we relay in the "Security Vulnerabilities" section at http://ofbiz.apache.org/download.html Thanks > Missing file results in infinite loop > - > > Key: OFBIZ-9198 > URL: https://issues.apache.org/jira/browse/OFBIZ-9198 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 13.07, Trunk, Release Branch 15.12, > Release Branch 16.11 >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Critical > Attachments: errror.txt > > > When accessing a file/image in ecommerce (only seo version) that is > physically missing or the dataresource attribute isPublic=="N" the request > results in an infinite loop. > Demo data: > statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" dataResourceName="Test > Image" objectInfo="PATH TO FILE" isPublic="N" /> > dataResourceId="testurl" statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" > objectInfo="/testbild-content" isPublic="N"/> > contentAssocTypeId="ALTERNATE_URL" fromDate="2006-09-22 00:00:00.0"/> > Call: > /ecomseo/testbild-content > /ecomseo/stream?contentId=test > I found that because I had server problems (server down), so it is quite easy > to kill the server by streaming a not existing contentId via via the ecomseo > app. > /ecomseo/stream?contentId=test1 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847573#comment-15847573 ] Jacques Le Roux edited comment on OFBIZ-9182 at 2/2/17 10:05 PM: - Hi Taher, Just thinking out loud for now... We don't need 2 Buildbot scripts if we can use svn externals http://svnbook.red-bean.com/en/1.8/svn.advanced.externals.html Note about automation: currently https://github.com/martoe/gradle-svntools-plugin does not support svn propedit, we could contribute, it's groovy code after all... BTW, there is a similar solutions with Git if we need it later https://stackoverflow.com/questions/571232/svnexternals-equivalent-in-git I have one worry, what about people relying on branches (evolving with new features eg R16.11) and not releases (fixed but bugs, eg 16.11.01) ? It seems they will loose something, don't they? Fortunately svn externals allows to define specific revisions. For instance we could define a revision for each plugin. As you said maybe too much, but maybe also convenient. Anyway this needs at least to be evaluated (ie more than just thinking out loud late in the evening...) was (Author: jacques.le.roux): Hi Taher, Just thinking out loud for now... We don't need 2 Buildbot scripts if we can use svn externals http://svnbook.red-bean.com/en/1.8/svn.advanced.externals.html Note about automation: currently https://github.com/martoe/gradle-svntools-plugin does not support svn propedit, we could contribute, it's groovy code after all... BTW, there is a similar solutions with Git if we need it later https://stackoverflow.com/questions/571232/svnexternals-equivalent-in-git I have one worry, what about people relying on branches (eg evolving with new features R16.11) and not release (fixed but bug 16.11.01) ? It seems they will loose something, don't they? Fortunately svn externals allows to define specific revisions. For instance we could define a revision for each plugin. As you said maybe too much, but maybe also convenient. Anyway this needs at least to be evaluated (ie more than just thinking out loud late in the evening...) > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850586#comment-15850586 ] Jacques Le Roux edited comment on OFBIZ-9182 at 2/2/17 10:19 PM: - Nicolas, that's why svn externals is perfect in this case, because it opens all possibilities svn provides. When associating a plugin, you can either use a revision (for a published release you can use its tags) or w/o revision which means taking HEAD. Ah yes, answering your point: people not able to use a checkout are indeed in another situation. But we could document it by simply suggesting to check out using the release tag. It's the same thing, just not packaged, and with the svn bagages. The svn bagages can be droppped later by using an export, note that the required svn externals (for the used plugins) will be also exported by default. Now it's not an official way to do things... Because only releases are published. So we have indeed to think about this aspect. Even if for most people using OFBiz it's not really an issue. We also miss the automation. Because so far the Gradle plugin has no task for properties. Properties are very powerful features of Svn, often neglected. Disclaimer: I must say I have not yet a clear picture in mind, just ideas... was (Author: jacques.le.roux): Nicolas, that's why svn externals is perfect in this case, because it opens all possibilities svn provides. When associating a plugin, you can either use a revision (for a published release you can use its tags) or w/o revision which means taking HEAD. We just miss the automation. Because so far the Gradle plugin has no task for properties. And properties are very powerful features of Svn, often neglected. Disclaimer: I must say I have not yet a clear picture in mind, just ideas... > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9198) Missing file results in infinite loop
[ https://issues.apache.org/jira/browse/OFBIZ-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850552#comment-15850552 ] Jacques Le Roux edited comment on OFBIZ-9198 at 2/2/17 9:41 PM: Ouch! It's not exactly an infinite loop. Here it tooks 4+ seconds {code} 2017-02-02 22:29:18,344 |http-nio-8443-exec-8 |ControlServlet |T| [[[stream(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] [...] 2017-02-02 22:29:22,410 |http-nio-8443-exec-8 |ControlServlet |T| [[[stream(Domain:https://localhost)] Request Done- total:4.066,since last([stream(Domain:ht...):4.066]] {code} But indeed it can be easily used with a massive DDOS. So this is a security issue and since it's already disclosed I make it a subtask of OFBIZ-1525 Please Ingo note that in case of security issues the ASF has some logical recommendations that we relay in the "Security Vulnerabilities" section at http://ofbiz.apache.org/download.html Thanks was (Author: jacques.le.roux): Ouch! It's not exactly an infinite loop. Here it tooks 4+ seconds {code} 2017-02-02 22:29:18,344 |http-nio-8443-exec-8 |ControlServlet |T| [[[stream(Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]] [...] 2017-02-02 22:29:22,410 |http-nio-8443-exec-8 |ControlServlet |T| [[[stream(Domain:https://localhost)] Request Done- total:4.066,since last([stream(Domain:ht...):4.066]] {code} But indeed it can be easily used with a massive DDOS. So this is a security issue and since it's already disclosed I make it a subtask of OFBIZ-1525 Please Ingo note that in case of security issues the ASF has some logical recommendation that we relay in the "Security Vulnerabilities" section at http://ofbiz.apache.org/download.html Thanks > Missing file results in infinite loop > - > > Key: OFBIZ-9198 > URL: https://issues.apache.org/jira/browse/OFBIZ-9198 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 13.07, Trunk, Release Branch 15.12, > Release Branch 16.11 >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Critical > Attachments: errror.txt > > > When accessing a file/image in ecommerce (only seo version) that is > physically missing or the dataresource attribute isPublic=="N" the request > results in an infinite loop. > Demo data: > statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" dataResourceName="Test > Image" objectInfo="PATH TO FILE" isPublic="N" /> > dataResourceId="testurl" statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" > objectInfo="/testbild-content" isPublic="N"/> > contentAssocTypeId="ALTERNATE_URL" fromDate="2006-09-22 00:00:00.0"/> > Call: > /ecomseo/testbild-content > /ecomseo/stream?contentId=test > I found that because I had server problems (server down), so it is quite easy > to kill the server by streaming a not existing contentId via via the ecomseo > app. > /ecomseo/stream?contentId=test1 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850586#comment-15850586 ] Jacques Le Roux edited comment on OFBIZ-9182 at 2/2/17 10:12 PM: - Nicolas, that's why svn externals is perfect in this case, because it opens all possibilities svn provides. When associating a plugin, you can either use a revision (for a published release you can use its tags) or w/o revision which means taking HEAD. We just miss the automation. Because so far the Gradle plugin has no task for properties. And properties are very powerful features of Svn, often neglected. Disclaimer: I must say I have not yet a clear picture in mind, just ideas... was (Author: jacques.le.roux): Nicolas, that's why svn externals is perfect in this case, because it opens all possibilities svn provides. You can either use it with a revision (for a published release you can use its tags) or w/o which means taking HEAD. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850586#comment-15850586 ] Jacques Le Roux commented on OFBIZ-9182: Nicolas, that's why svn externals is perfect in this case, because it opens all possibilities svn provides. You can either use it with a revision (for a published release you can use its tags) or w/o which means taking HEAD. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15850586#comment-15850586 ] Jacques Le Roux edited comment on OFBIZ-9182 at 2/2/17 10:25 PM: - Nicolas, Has Taher suggested, people using releases would have available corresponding plugins released. They don't need to use pullPluginSource only pullPlugin In other cases (relying on checked out sources), svn externals is perfect. Because it opens all possibilities svn provides. When associating a plugin, you can either use a revision or w/o revision which means taking HEAD. We though miss the automation. Because so far the Gradle plugin has no task for properties. Properties are very powerful features of Svn, often neglected. Disclaimer: I must say I have not yet a clear picture in mind, just ideas... was (Author: jacques.le.roux): Nicolas, that's why svn externals is perfect in this case, because it opens all possibilities svn provides. When associating a plugin, you can either use a revision (for a published release you can use its tags) or w/o revision which means taking HEAD. Ah yes, answering your point: people not able to use a checkout are indeed in another situation. But we could document it by simply suggesting to check out using the release tag. It's the same thing, just not packaged, and with the svn bagages. The svn bagages can be droppped later by using an export, note that the required svn externals (for the used plugins) will be also exported by default. Now it's not an official way to do things... Because only releases are published. So we have indeed to think about this aspect. Even if for most people using OFBiz it's not really an issue. We also miss the automation. Because so far the Gradle plugin has no task for properties. Properties are very powerful features of Svn, often neglected. Disclaimer: I must say I have not yet a clear picture in mind, just ideas... > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (OFBIZ-9192) Implement and demonstrate few services in Birt Report Builder
Title: Message Title Jacques Le Roux assigned an issue to Jacques Le Roux OFBiz / OFBIZ-9192 Implement and demonstrate few services in Birt Report Builder Change By: Jacques Le Roux Assignee: Jacques Le Roux Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9192) Implement and demonstrate few services in Birt Report Builder
Title: Message Title Jacques Le Roux commented on OFBIZ-9192 Re: Implement and demonstrate few services in Birt Report Builder OK I did not check it right, there is already an example with "Turnover", I'll continue on this... Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Commented] (OFBIZ-9194) After creating a new Flexible Birt report, before visualising it you need other actions
[ https://issues.apache.org/jira/browse/OFBIZ-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848083#comment-15848083 ] Jacques Le Roux commented on OFBIZ-9194: We can get also this kind of error when pressing the "Send" button beore having published the report bq. org.eclipse.birt.report.engine.api.EngineException: The design file can not be found. {code} 2017-02-01 08:15:57,255 |http-nio-8443-exec-7 |RequestHandler |I| Rendering View [ExecuteFlexibleReport]. Hidden sessionId by default. 2017-02-01 08:15:57,264 |http-nio-8443-exec-7 |ControlServlet |E| Error in request handler: org.eclipse.birt.report.engine.api.EngineException: The design file can not be found. at org.eclipse.birt.report.engine.api.impl.ReportEngineHelper.openReportDesign(ReportEngineHelper.java:113) ~[org.eclipse.birt.runtime-4.4.1.jar:?] at org.eclipse.birt.report.engine.api.impl.ReportEngine.openReportDesign(ReportEngine.java:310) ~[org.eclipse.birt.runtime-4.4.1.jar:?] at org.apache.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:89) ~[ofbiz.jar:?] at org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:985) ~[ofbiz.jar:?] at org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:649) ~[ofbiz.jar:?] at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210) [ofbiz.jar:?] at org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:85) [ofbiz.jar:?] at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) [javax.servlet-api-3.1.0.jar:3.1.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) [javax.servlet-api-3.1.0.jar:3.1.0] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-embed-websocket-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:209) [ofbiz.jar:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) [ofbiz.jar:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:509) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1104) [tomcat-coyote-8.0.39.jar:8.0.39] at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:684) [tomcat-coyote-8.0.39.jar:8.0.39] at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520) [tomcat-coyote-8.0.39.jar:8.0.39] at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476) [tomcat-coyote-8.0.39.jar:8.0.39] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_112] at
[jira] [Closed] (OFBIZ-9193) NPE when changing locale from birt/control/CreateFlexibleReport
[ https://issues.apache.org/jira/browse/OFBIZ-9193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9193. -- Resolution: Duplicate It's the same issue: the report is not yet known by OFBiz > NPE when changing locale from birt/control/CreateFlexibleReport > > > Key: OFBIZ-9193 > URL: https://issues.apache.org/jira/browse/OFBIZ-9193 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release > > > After creating and trying (also w/o succes, another issue to come) to > visualise a new Flexible Birt report, trying to change the locale generate a > NPE > {code} > 2017-01-31 13:48:41,534 |http-nio-8443-exec-5 |RequestHandler > |I| Rendering View [ExecuteFlexibleReport]. Hidden sessionId by default. > 2017-01-31 13:48:41,535 |http-nio-8443-exec-5 |ControlServlet > |E| Error in request handler: > java.lang.NullPointerException > at > org.apache.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:85) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.webapp.control.RequestHandler.renderView(RequestHandler.java:985) > ~[ofbiz.jar:?] >at > org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:683) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210) > [ofbiz.jar:?] > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > [javax.servlet-api-3.1.0.jar:3.1.0] > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > [javax.servlet-api-3.1.0.jar:3.1.0] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) > [tomcat-embed-websocket-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:209) > [ofbiz.jar:?] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) > [ofbiz.jar:?] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:509) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1104) > [tomcat-coyote-8.0.39.jar:8.0.39] >at > org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:684) > [tomcat-coyote-8.0.39.jar:8.0.39] >at > org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520) > [tomcat-coyote-8.0.39.jar:8.0.39] >at >
[jira] [Updated] (OFBIZ-9194) After creating a new Flexible Birt report, before visualising it you need to do other actions
[ https://issues.apache.org/jira/browse/OFBIZ-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9194: --- Summary: After creating a new Flexible Birt report, before visualising it you need to do other actions (was: After creating a new Flexible Birt report, before visualising it you need other actions) > After creating a new Flexible Birt report, before visualising it you need to > do other actions > - > > Key: OFBIZ-9194 > URL: https://issues.apache.org/jira/browse/OFBIZ-9194 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Release > > > After creating a new Flexible Birt report, before visualising it you need to > add the data set fields with the Birt Report Designer and publish the report. > So the "Send" button of the "Preview" form on the "Edit report" page should > be grayed/unavailable before the report has been plublished. If it's then not > correclty done that's an user problem. > This should also be clearly documented, hence related with OFBIZ-9188 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-5306) Error of running "ant clean-all" or "ant refresh"
[ https://issues.apache.org/jira/browse/OFBIZ-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848136#comment-15848136 ] Jacques Le Roux commented on OFBIZ-5306: Hi Wei, I stumbled upon this by chance while waiting Gradle compilation You closed as fixed, but it seems it was actually not a problem or alike? > Error of running "ant clean-all" or "ant refresh" > - > > Key: OFBIZ-5306 > URL: https://issues.apache.org/jira/browse/OFBIZ-5306 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Wei Zhang > > see the details below > BUILD FAILED > D:\Projects\RHH\ofbiz-trunk\build.xml:64: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:77: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:145: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\applications\content\build.xml:64: Directory does > not exist: D:\Projects\RHH\ofbiz-trunk\runtime\data\indexes -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9194) After creating a new Flexible Birt report, before visualising it you need to do other actions
[ https://issues.apache.org/jira/browse/OFBIZ-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9194: --- Description: After creating a new Flexible Birt report, before visualising it you need to add the data set fields with the Birt Report Designer and publish the report. So the "Send" button of the "Preview" form on the "Edit report" page should be grayed/unavailable before the report has been plublished. If it's then not correctly done that's an user problem. This should also be clearly documented, hence related with OFBIZ-9188 was: After creating a new Flexible Birt report, before visualising it you need to add the data set fields with the Birt Report Designer and publish the report. So the "Send" button of the "Preview" form on the "Edit report" page should be grayed/unavailable before the report has been plublished. If it's then not correclty done that's an user problem. This should also be clearly documented, hence related with OFBIZ-9188 > After creating a new Flexible Birt report, before visualising it you need to > do other actions > - > > Key: OFBIZ-9194 > URL: https://issues.apache.org/jira/browse/OFBIZ-9194 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Release > > > After creating a new Flexible Birt report, before visualising it you need to > add the data set fields with the Birt Report Designer and publish the report. > So the "Send" button of the "Preview" form on the "Edit report" page should > be grayed/unavailable before the report has been plublished. If it's then not > correctly done that's an user problem. > This should also be clearly documented, hence related with OFBIZ-9188 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9194) After creating a new Flexible Birt report, before visualising it you need other actions
[ https://issues.apache.org/jira/browse/OFBIZ-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848088#comment-15848088 ] Jacques Le Roux commented on OFBIZ-9194: OK, the initial design of this page (report edition) by François has been totally changed by Nicolas and I have to wrap my head around... > After creating a new Flexible Birt report, before visualising it you need > other actions > --- > > Key: OFBIZ-9194 > URL: https://issues.apache.org/jira/browse/OFBIZ-9194 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Release > > > After creating a new Flexible Birt report, before visualising it you need to > add the data set fields with the Birt Report Designer and publish the report. > So the "Send" button of the "Preview" form on the "Edit report" page should > be grayed/unavailable before the report has been plublished. If it's then not > correclty done that's an user problem. > This should also be clearly documented, hence related with OFBIZ-9188 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
Title: Message Title Jacques Le Roux edited a comment on OFBIZ-6919 Re: Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation. I close this issue. We will use subtasks for create bugs and improvements issues rather than subtasks because you can't give a type (bugs, improvements, etc.) to Sub-tasks :/We will link these issues to the current one. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9194) After creating a new Flexible Birt report, before visualising it you need other actions
Title: Message Title Jacques Le Roux created an issue OFBiz / OFBIZ-9194 After creating a new Flexible Birt report, before visualising it you need other actions Issue Type: Bug Affects Versions: Trunk Assignee: Jacques Le Roux Components: specialpurpose/birt Created: 31/Jan/17 13:03 Fix Versions: Upcoming Release Priority: Trivial Reporter: Jacques Le Roux After creating a new Flexible Birt report, before visualising it you need to add the data set fields with the Birt Report Designer and publish the report. So the "Send" button of the "Preview" form on the "Edit report" page should be grayed/unavailable before the report has been plublished. If it's then not correclty done that's an user problem. This should also be clearly documented, hence related with OFBIZ-9188
[jira] (OFBIZ-9192) Implement and demonstrate few services in Birt Report Builder
Title: Message Title Jacques Le Roux commented on OFBIZ-9192 Re: Implement and demonstrate few services in Birt Report Builder OK did not notice this error in log 2017-01-31 15:00:22,908 |ttp-nio-8443-exec-10 |RequestHandler|I| Rendering View [ExecuteFlexibleReport]. Hidden sessionId by default. 2017-01-31 15:00:22,911 |ttp-nio-8443-exec-10 |BirtWorker|I| Get report engine 2017-01-31 15:00:22,911 |ttp-nio-8443-exec-10 |BirtWorker|I| Set BIRT locale:en 2017-01-31 15:00:22,913 |ttp-nio-8443-exec-10 |BirtWorker|I| BIRT's locale is: en 2017-01-31 15:00:22,913 |ttp-nio-8443-exec-10 |BirtWorker|I| Run report's task 2017-01-31 15:00:22,948 |ttp-nio-8443-exec-10 |rptdesign |I| ## In initialize 2017-01-31 15:00:22,952 |ttp-nio-8443-exec-10 |rptdesign |I| ## In beforeFactory Jan 31, 2017 3:00:22 PM uk.co.spudsoft.birt.emitters.excel.framework.Logger info INFO: start:org.eclipse.birt.report.engine.content.impl.ReportContent@5a321fc6 2017-01-31 15:00:22,980 |ttp-nio-8443-exec-10 |rptdesign |I| In open java.lang.IllegalArgumentException: Key(0), with value([thruDate <= '2017-01-31 15:00:22.986', thruDate IS NULL]) is not a String. at org.apache.ofbiz.entity.util.EntityUtil.makeFields(EntityUtil.java:66) at org.apache.ofbiz.entity.condition.EntityFieldMap.(EntityFieldMap.java:51) at org.apache.ofbiz.entity.condition.EntityCondition.makeCondition(EntityCondition.java:92) at org.apache.ofbiz.birt.flexible.BirtMasterReportServices.turnOver(BirtMasterReportServices.java:187) Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9192) Implement and demonstrate few services in Birt Report Builder
Title: Message Title Jacques Le Roux commented on OFBIZ-9192 Re: Implement and demonstrate few services in Birt Report Builder Also just noticed this 2017-01-31 15:00:23,000 |ttp-nio-8443-exec-10 |rptdesign |E| InternalError: Can't find method org.apache.ofbiz.base.util.Debug.logError(java.lang.String). (/report/data-sets/script-data-set[@id="6"]/method[@name="open"]#6) Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9191) Navigate Accounts tree
Title: Message Title Jacques Le Roux commented on OFBIZ-9191 Re: Navigate Accounts tree OK this is the problem: 2017-01-31 15:30:15,159 |http-nio-8443-exec-3 |ControlServlet|T| [[[GlAccountNavigate(Domain:https://localhost)] Request Done- total:0.715,since last([GlAccountNavigat...):0.715]] Jan 31, 2017 3:30:18 PM org.apache.coyote.http11.AbstractHttp11Processor process INFO: Error parsing HTTP request header Note: further occurrences of HTTP header parsing errors will be logged at DEBUG level. java.lang.IllegalArgumentException: Invalid character found in the request target. The valid characters are defined in RFC 7230 and RFC 3986 at org.apache.coyote.http11.AbstractNioInputBuffer.parseRequestLine(AbstractNioInputBuffer.java:283) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1017) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:684) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) at java.lang.Thread.run(Thread.java:745) So it seems Tomcat is no longer accepting the | char because https://ofbiz-vm2.apache.org:28443/accounting/control/GlAccountNavigate?trail=null|10 works (| not encoded) Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9191) Navigate Accounts tree
Title: Message Title Jacques Le Roux assigned an issue to Jacques Le Roux OFBiz / OFBIZ-9191 Navigate Accounts tree Change By: Jacques Le Roux Assignee: Jacques Le Roux Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
Title: Message Title Jacques Le Roux closed an issue as Implemented I close this issue. We will use subtasks for bugs and improvements OFBiz / OFBIZ-6919 Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation. Change By: Jacques Le Roux Status: Resolved Closed Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9193) NPE when changing locale from birt/control/CreateFlexibleReport
Title: Message Title Jacques Le Roux created an issue OFBiz / OFBIZ-9193 NPE when changing locale from birt/control/CreateFlexibleReport Issue Type: Bug Affects Versions: Trunk Assignee: Jacques Le Roux Components: specialpurpose/birt Created: 31/Jan/17 12:55 Fix Versions: Upcoming Release Priority: Major Reporter: Jacques Le Roux After creating and trying (also w/o succes, another issue to come) to visualise a new Flexible Birt report, trying to change the locale generate a NPE 2017-01-31 13:48:41,534 |http-nio-8443-exec-5 |RequestHandler|I| Rendering View [ExecuteFlexibleReport]. Hidden sessionId by default. 2017-01-31 13:48:41,535 |http-nio-8443-exec-5 |ControlServlet|E| Error in request handler: java.lang.NullPointerException at org.apache.ofbiz.birt.webapp.view.BirtViewHandler.render(BirtViewHandler.java:85) ~[ofbiz.jar:?] at
[jira] (OFBIZ-9192) Implement and demonstrate few services in Birt Report Builder
Title: Message Title Jacques Le Roux commented on OFBIZ-9192 Re: Implement and demonstrate few services in Birt Report Builder At revision: 1781084 are comiited trivial changes fixes missing Lookup maps and view in controller for the "rotation" report new needed labels typos fixed Before putting in new "service reports" I'll continue on the "rotation" report because by default you don't get any data in the report, even when setting from date at 2001/01/01, Product Category Id at CATALOG1 and Product Store Id at 9000 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9192) Implement and demonstrate few services in Birt Report Builder
Title: Message Title Jacques Le Roux updated an issue OFBiz / OFBIZ-9192 Implement and demonstrate few services in Birt Report Builder Change By: Jacques Le Roux Issue Type: Sub-task Bug Parent: OFBIZ-6919 Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Closed] (OFBIZ-9194) After creating a new Flexible Birt report, before visualising it you need to do other actions
[ https://issues.apache.org/jira/browse/OFBIZ-9194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9194. -- Resolution: Fixed Fixed with revision: 1781218 > After creating a new Flexible Birt report, before visualising it you need to > do other actions > - > > Key: OFBIZ-9194 > URL: https://issues.apache.org/jira/browse/OFBIZ-9194 > Project: OFBiz > Issue Type: Bug > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Trivial > Fix For: Upcoming Release > > > After creating a new Flexible Birt report, before visualising it you need to > add the data set fields with the Birt Report Designer and publish the report. > So the "Send" button of the "Preview" form on the "Edit report" page should > be grayed/unavailable before the report has been plublished. If it's then not > correctly done that's an user problem. > This should also be clearly documented, hence related with OFBIZ-9188 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9191. -- Resolution: Fixed Fix Version/s: 16.11.02 Upcoming Release Thanks Moatasim Al Masri for report, Fixed in trunk r1781125 R16.11 r1781126 This is due to a change in (at least) Tomcat 8.0.39 https://stackoverflow.com/questions/41053653/tomcat-8-is-not-able-to-handle-get-request-with-in-query-parameters http://tomcat.10.x6.nabble.com/Tomcat-8-0-39-and-tomcat-8-5-8-fails-handling-requsest-td5057320.html I tried other ways but none worked and I prefer to keep this simple. * Using an encoder at this stage (just before calling the macro) is not an option. Or maybe by using the encoder on the linkurl variable alone. But then linkurl must be transformed in a String and back to a StringBuilder or more refactoring is needed. It does not worth it IMO. * Also using encode="true" for links in AccountingTrees.xml does not work. > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9191: --- Summary: Navigate Accounts tree does not work (was: Navigate Accounts tree ) > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847176#comment-15847176 ] Jacques Le Roux commented on OFBIZ-9191: Actually using encode="true" for links in AccountingTrees.xml should work. We could create a JIra for that, but I fear that by encoding the whole URI it would be less legible, KISS way... Still it's bad to have an encoding option which does not work :/ > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-7928) Use "Let's encrypt" for OFBiz demos SSL/TLS certificates
[ https://issues.apache.org/jira/browse/OFBIZ-7928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-7928. -- Resolution: Done Fix Version/s: Release Branch 13.07 Trunk Release Branch 16.11 This is now done, thanks to Pierre and infra see INFRA-11960 I'll create a task to maintain the documentation in ofbiz\tools\demo-backup\README.MD which is then used to generate https://cwiki.apache.org/confluence/display/OFBIZ/The+official+demos+and+how+to+maintain+them > Use "Let's encrypt" for OFBiz demos SSL/TLS certificates > > > Key: OFBIZ-7928 > URL: https://issues.apache.org/jira/browse/OFBIZ-7928 > Project: OFBiz > Issue Type: Task >Reporter: Jacques Le Roux >Assignee: Pierre Smits > Fix For: Release Branch 16.11, Trunk, Release Branch 13.07 > > > This is a transtion from INFRA-11960 > {quote} > After some tries, I have finally decided to adapt and use > http://blog.ivantichy.cz/blogpost/view/74 which is the most convenient way > for OFBiz > Since we need to use SANs (for demo-trunk-ofbiz.apache.org, > demo-stable-ofbiz.apache.org and demo-old-ofbiz.apache.org which are actually > OFBiz instances using different set of ports), I will try to use "-d > ofbiz-vm.apache.org" as 1st "-d" argument and if that does not work I'll > simply use the "-d" parameter with the other sub-domains only. What I > actually need is a renewable certificate in the OFBiz Java keystore > (ofbiz.jks) with the SANs present. From my experiences, the (adapted) script > above should provide me that. > {quote} > Maybe another possibility would be to install our own HTTPS and use the > instructions provided by Sam Ruby in INFRA-11960. I have to balance the work > with adapting the script I refered to above. > {quote} > The EFF has published new instructions: > https://certbot.eff.org/#ubuntutrusty-apache > FWIW, I had no problem moving from whimy-vm2 to whimsy-vm3. I've now got > certs for a second machine (ghmon-vm). Here's the puppet instructions to > download certbot, create a cronjob, and add use the certificates with Apache > httpd: > https://github.com/apache/infrastructure-puppet/pull/107/commits/8fea8223f398a77e67173c1b0c1b06b80fe576b0 > Once this is deployed, all that is left is running a single command: > certbot-auto -d host1.apache.org -d host2.apache.org... and answering two > prompts (you need to provide an email address and to indicate that you have > read the terms of service). > {quote} -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9203) Update \tools\demo-backup\README.MD now that we use "Let's encrypt" on demos
Jacques Le Roux created OFBIZ-9203: -- Summary: Update \tools\demo-backup\README.MD now that we use "Let's encrypt" on demos Key: OFBIZ-9203 URL: https://issues.apache.org/jira/browse/OFBIZ-9203 Project: OFBiz Issue Type: Task Components: Demo Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Upcoming Release After OFBIZ-7928 we now use "Let's encrypt" on demos. We need to update ofbiz\tools\demo-backup\README.MD which is used to generate https://cwiki.apache.org/confluence/display/OFBIZ/The+official+demos+and+how+to+maintain+them -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9204) Cancelled OrderItems are still included in orderGrandTotal
[ https://issues.apache.org/jira/browse/OFBIZ-9204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855416#comment-15855416 ] Jacques Le Roux commented on OFBIZ-9204: I guess Deepak means bq. orderReadHelper.getOrderGrandTotal() > Cancelled OrderItems are still included in orderGrandTotal > -- > > Key: OFBIZ-9204 > URL: https://issues.apache.org/jira/browse/OFBIZ-9204 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Maurice Meyer >Assignee: Michael Brohl > > Cancelled OrderItems are still included in the calculation of the order price. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right still states 38.36$. It should be 0$ > because all the items got cancelled. > The error is probably in OrderView.groovy line 119: > OrderReadHelper.getOrderGrandTotal(orderItems, orderAdjustments) > This method apparently includes cancelled OrderItems in the grandTotal. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9206) Loginor login out in demos shows a certificate issue
Jacques Le Roux created OFBIZ-9206: -- Summary: Loginor login out in demos shows a certificate issue Key: OFBIZ-9206 URL: https://issues.apache.org/jira/browse/OFBIZ-9206 Project: OFBiz Issue Type: Bug Components: Demo Reporter: Jacques Le Roux Priority: Minor When, from the site main page http://ofbiz.apache.org/, you get to the demos depending on browser (tested on Windows 7) you get some issues: # FF * Management Apps: OK * Ecommerce: OK # Chrome * Initially ** Management Apps or Ecommerce *** stable: OK *** old: KO *** trunk: OK * If you copy the URL by hand all work, and after even from the main page it works for old. # IE, same than Chrome If, from any browser, you logout from Management Apps you get a certificate issue. Actually as we use HSTS the browsers protect us from any 3rd party intrusions... Same issue when login in. So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. Maybe it's due to how OFBiz redirects when login in or login out because, so far, only the login page is concerned... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9206) Loginor login out in demos shows a certificate issue
[ https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9206: --- Description: When, from the site main page http://ofbiz.apache.org/, you get to the demos depending on browser (tested on Windows 7) you get some issues: * FF ** Management Apps: OK ** Ecommerce: OK * Chrome (Management Apps or Ecommerce) ** stable: OK ** old: KO - If you copy the URL by hand it works, and after even from the main page it works. ** trunk: OK * IE, same than Chrome If, from any browser, you logout from Management Apps you get a certificate issue. Actually as we use HSTS the browsers protect us from any 3rd party intrusions... Same issue when login in. So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. Maybe it's due to how OFBiz redirects when login in or login out because, so far, only the login page is concerned... was: When, from the site main page http://ofbiz.apache.org/, you get to the demos depending on browser (tested on Windows 7) you get some issues: # FF * Management Apps: OK * Ecommerce: OK # Chrome * Initially ** Management Apps or Ecommerce *** stable: OK *** old: KO *** trunk: OK * If you copy the URL by hand all work, and after even from the main page it works for old. # IE, same than Chrome If, from any browser, you logout from Management Apps you get a certificate issue. Actually as we use HSTS the browsers protect us from any 3rd party intrusions... Same issue when login in. So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. Maybe it's due to how OFBiz redirects when login in or login out because, so far, only the login page is concerned... > Loginor login out in demos shows a certificate issue > > > Key: OFBIZ-9206 > URL: https://issues.apache.org/jira/browse/OFBIZ-9206 > Project: OFBiz > Issue Type: Bug > Components: Demo >Reporter: Jacques Le Roux >Priority: Minor > > When, from the site main page http://ofbiz.apache.org/, you get to the demos > depending on browser (tested on Windows 7) you get some issues: > * FF > ** Management Apps: OK > ** Ecommerce: OK > * Chrome (Management Apps or Ecommerce) > ** stable: OK > ** old: KO - If you copy the URL by hand it works, and after even from the > main page it works. > ** trunk: OK > * IE, same than Chrome > If, from any browser, you logout from Management Apps you get a certificate > issue. Actually as we use HSTS the browsers protect us from any 3rd party > intrusions... Same issue when login in. > So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. > Maybe it's due to how OFBiz redirects when login in or login out because, so > far, only the login page is concerned... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9205) Wrong OrderAdjustments (because of tax) when cancelling an Order
[ https://issues.apache.org/jira/browse/OFBIZ-9205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855952#comment-15855952 ] Jacques Le Roux commented on OFBIZ-9205: Thanks Maurice, please note that, since our demos restart anew everyday at 3 UTC, the Demo10090 will only be available today. Not a big issue seems easily reproductible. > Wrong OrderAdjustments (because of tax) when cancelling an Order > > > Key: OFBIZ-9205 > URL: https://issues.apache.org/jira/browse/OFBIZ-9205 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Maurice Meyer > > The Problem (tested with order Demo10090): When cancelling an order new > OrderAdjustments are created to substract the tax of the cancelled orderItems > from the existing order total amount. This leads to an amount of -0.04$ with > the demo order DEMO10090. > Tested with release 16.11, revision: 1781126 > Steps to reproduce: > 1. Setup a fresh OFBiz and do loadDefault > 2. Go to the Order Manager and cancel the only existing demo order named > DEMO10090 here: > https://localhost:8443/ordermgr/control/orderview?orderId=DEMO10090 > 3. The "Total Due" at the bottom right states -0.04$. It should be 0$. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9206) Login or login out in demos shows a certificate issue
[ https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9206: --- Summary: Login or login out in demos shows a certificate issue (was: Login and logout process in demos shows a certificate issue) > Login or login out in demos shows a certificate issue > - > > Key: OFBIZ-9206 > URL: https://issues.apache.org/jira/browse/OFBIZ-9206 > Project: OFBiz > Issue Type: Bug > Components: Demo >Reporter: Jacques Le Roux >Priority: Minor > > When, from the site main page http://ofbiz.apache.org/, you get to the demos > depending on browser (tested on Windows 7) you get some issues: > * FF > ** Management Apps: OK > ** Ecommerce: OK > * Chrome (Management Apps or Ecommerce) > ** stable: OK > ** old: KO - If you copy the URL by hand it works, and after even from the > main page it works. > ** trunk: OK > * IE, same than Chrome > If, from any browser, you logout from Management Apps you get a certificate > issue. Actually as we use HSTS the browsers protect us from any 3rd party > intrusions... Same issue when login in. > So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. > Maybe it's due to how OFBiz redirects when login in or login out because, so > far, only the login page is concerned... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9206) Login and logout process in demos shows a certificate issue
[ https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856192#comment-15856192 ] Jacques Le Roux commented on OFBIZ-9206: We crossed on wire Pierre, your summary is better, put back > Login and logout process in demos shows a certificate issue > --- > > Key: OFBIZ-9206 > URL: https://issues.apache.org/jira/browse/OFBIZ-9206 > Project: OFBiz > Issue Type: Bug > Components: Demo >Reporter: Jacques Le Roux >Priority: Minor > > When, from the site main page http://ofbiz.apache.org/, you get to the demos > depending on browser (tested on Windows 7) you get some issues: > * FF > ** Management Apps: OK > ** Ecommerce: OK > * Chrome (Management Apps or Ecommerce) > ** stable: OK > ** old: KO - If you copy the URL by hand it works, and after even from the > main page it works. > ** trunk: OK > * IE, same than Chrome > If, from any browser, you logout from Management Apps you get a certificate > issue. Actually as we use HSTS the browsers protect us from any 3rd party > intrusions... Same issue when login in. > So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. > Maybe it's due to how OFBiz redirects when login in or login out because, so > far, only the login page is concerned... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9206) Login and logout process in demos shows a certificate issue
[ https://issues.apache.org/jira/browse/OFBIZ-9206?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9206: --- Summary: Login and logout process in demos shows a certificate issue (was: Login or login out in demos shows a certificate issue) > Login and logout process in demos shows a certificate issue > --- > > Key: OFBIZ-9206 > URL: https://issues.apache.org/jira/browse/OFBIZ-9206 > Project: OFBiz > Issue Type: Bug > Components: Demo >Reporter: Jacques Le Roux >Priority: Minor > > When, from the site main page http://ofbiz.apache.org/, you get to the demos > depending on browser (tested on Windows 7) you get some issues: > * FF > ** Management Apps: OK > ** Ecommerce: OK > * Chrome (Management Apps or Ecommerce) > ** stable: OK > ** old: KO - If you copy the URL by hand it works, and after even from the > main page it works. > ** trunk: OK > * IE, same than Chrome > If, from any browser, you logout from Management Apps you get a certificate > issue. Actually as we use HSTS the browsers protect us from any 3rd party > intrusions... Same issue when login in. > So it seems we have a certificate issue after OFBIZ-7928 and INFRA-11960. > Maybe it's due to how OFBiz redirects when login in or login out because, so > far, only the login page is concerned... -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9196) Regression: the testIntegration Gradle taks shoud not use/block the ports
Jacques Le Roux created OFBIZ-9196: -- Summary: Regression: the testIntegration Gradle taks shoud not use/block the ports Key: OFBIZ-9196 URL: https://issues.apache.org/jira/browse/OFBIZ-9196 Project: OFBiz Issue Type: Bug Components: Gradle Affects Versions: Release Branch 16.11, Trunk Reporter: Jacques Le Roux Priority: Minor Fix For: Upcoming Release, 16.11.02 We got an issue on Buildbot because of a Puppet misconfiguration which was always using the port 8080. Pre-gradle OFBiz tests were still running fine on Buildbot. Before the Puppet misconfiguration fix by infra (INFRA-13402) bo bypass this issue I tried last weekend to use portoffset in Gradle versions. From the documentation, it's theoretically possible but does not work. Taher suggested, to get back to the previous behaviour were tests were not using/blocking the 8080 port. Taher suggested to have a look into Config.java... It's a regression because it was nice to not have ports blocked during tests, as it was before Gradle. So you can use another (or more) OFBiz instance while running tests, and vice-versa. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851083#comment-15851083 ] Jacques Le Roux commented on OFBIZ-9182: OK, it clear to me now. We don't need pullPluginSource if we set a svn external for the plugins repo. Taher said {quote} There are two ways to pull a plugin from source: Either have subversion installed on the machine and use exec {...} OR use an embedded subversion based on Java and hence avoid dependence on environment. {quote} Actually people should not have to worry about using "exec" manually. That's what a svn external for the plugins repo would do automatically for them, checking out the whole plugins dir without any efforts and even noticing it. I recap: # People using released packages use pullPlugin to get the released plugin/s they want (and more because of plugins interdependencies) # People not using released packages, ie using checked out working copies, don't have to worry they get all plugins with the svn externals as it is now. The dependencies will be resolved while building as it is now But then for svn externals, what for people who want to use only one or few plugins? Then maybe we need to reconsider component.load in plugins dir and de/activatePlugin tasks... So the decision about using svn external or pullPluginSource is up to the community. Maybe pullPluginSource is clearer because you easily get only what you want, but what about plugins inter-dependencies? Also if you want a lot of plugins it's kinda a pain. For now we have "only" 19 plugins but what's next? To summarize, as long as plugins inter-dependencies will not be resolved svn externals is more convenient. About resolving plugins inter-dependencies, is it even possible (we finally let it be in applications)? Consider DLL and Jar hells, even Microsoft and Sun were not able to cleanly do it. And now you have Java 9 and its modules coming: http://blog.codefx.org/java/dev/will-there-be-module-hell/ > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9197) Javadoc creation issue
Jacques Le Roux created OFBIZ-9197: -- Summary: Javadoc creation issue Key: OFBIZ-9197 URL: https://issues.apache.org/jira/browse/OFBIZ-9197 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Fix For: Upcoming Release While Buildbot was blocked (INFRA-13402) we did not spot that we have a Javadoc creation issue with trunk (we generate Javadoc only for trunk so far) I tried to revert to r1780691 (last commit before last Gradle change) to no avail This is currently blocking Buildbot. I'll temporarily bypass the Javadoc creation issue Buildbot task and will put it back when the issue will be fixed -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857622#comment-15857622 ] Jacques Le Roux commented on OFBIZ-9191: BTW I created OFBIZ-9202 "Encoding links for nodes in trees does not work" > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9191) Navigate Accounts tree does not work
[ https://issues.apache.org/jira/browse/OFBIZ-9191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857696#comment-15857696 ] Jacques Le Roux commented on OFBIZ-9191: Yes, it's fixed at r1781125, but we should be able to encode links in nodes trees. In this case I preferred to keep things simple, so OFBIZ-9202 more to remember for a perfect future ;) > Navigate Accounts tree does not work > > > Key: OFBIZ-9191 > URL: https://issues.apache.org/jira/browse/OFBIZ-9191 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Release Branch 16.11 > Environment: windows 10 >Reporter: Moatasim Al Masri >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02 > > > go to > Accounting --> Global GL Setting --> Navigate Accounts > when I try to open tree, gave me in URL > https://localhost:8443/accounting/control/GlAccountNavigate?glAccountId=10=null|10 > and gave me white page !!? it should expand the tree ! > NOTE: OFBiz ver. 16.11.01 and database Oracle 12c -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Resolved] (OFBIZ-9198) Missing file results in error
[ https://issues.apache.org/jira/browse/OFBIZ-9198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux resolved OFBIZ-9198. Resolution: Fixed Fix Version/s: 16.11.02 Upcoming Release Thankd for report Ingo I resolved the issue in trunk r1781662 R16.11 and R15.12 r1781664 Other branches don't contain ecomseo I was unable to load your data, got this error bq. ERROR: parsing file: ERROR parsing Entity Xml file: org.xml.sax.SAXException: A transaction error occurred reading dataorg.xml.sax.SAXException: Fatal Error reading XML on line 2, column 2org.xml.sax.SAXParseException; lineNumber: 2; columnNumber: 2; The markup in the document following the root element must be well-formed. and did not look further. Please check if the fix is OK with you and close if you agree > Missing file results in error > - > > Key: OFBIZ-9198 > URL: https://issues.apache.org/jira/browse/OFBIZ-9198 > Project: OFBiz > Issue Type: Sub-task > Components: specialpurpose/ecommerce >Affects Versions: Release Branch 13.07, Trunk, Release Branch 15.12, > Release Branch 16.11 >Reporter: Ingo Wolfmayr >Assignee: Jacques Le Roux >Priority: Critical > Fix For: Upcoming Release, 16.11.02 > > Attachments: errror.txt > > > When accessing a file/image in ecommerce (only seo version) that is > physically missing or the dataresource attribute isPublic=="N" the request > results in an a loop. > Demo data: > statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" dataResourceName="Test > Image" objectInfo="PATH TO FILE" isPublic="N" /> > dataResourceId="testurl" statusId="CTNT_PUBLISHED"/> > dataTemplateTypeId="NONE" statusId="CTNT_PUBLISHED" > objectInfo="/testbild-content" isPublic="N"/> > contentAssocTypeId="ALTERNATE_URL" fromDate="2006-09-22 00:00:00.0"/> > Call: > /ecomseo/testbild-content > /ecomseo/stream?contentId=test > I found that because I had server problems (server down), so it is quite easy > to kill the server by streaming a not existing contentId via via the ecomseo > app. > /ecomseo/stream?contentId=test1 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9202) Encoding links for nodes in trees does not work
Jacques Le Roux created OFBIZ-9202: -- Summary: Encoding links for nodes in trees does not work Key: OFBIZ-9202 URL: https://issues.apache.org/jira/browse/OFBIZ-9202 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Minor As explained in OFBIZ-9191 using encode="true" for links in AccountingTrees.xml should work. The encode attribute is false by default and setting it to true has no effect. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852746#comment-15852746 ] Jacques Le Roux edited comment on OFBIZ-9182 at 2/4/17 1:27 PM: As I said already, the pb with gradle-svntools-plugin is it does not handle properties (yet?) so I don't see how at this stage. You said: bq. svn externals could be an implementation detail then embedded inside pullPluginSourceAll Morevoer, as setting an svn:externals is only a matter of a property commit (done once), I don't see the need to have that embedded inside pullPluginSourceAll at all IMO pullPluginSource is only interesting if we can pass an URL for non ASF repos. But I agree we can go on with restructuring the OFBiz repo branch, and discuss further on dev ML if we should use svn:externals or not. I think we already put all the arguments on the table. was (Author: jacques.le.roux): As I said already, the pb with gradle-svntools-plugin is it does not handle property (yet?) so I don't see how at this stage bq. svn externals could be an implementation detail then embedded inside pullPluginSourceAll Morevoer as setting an svn:externals is only a matter of a property commit (done once) I don't see the need to have that embedded inside pullPluginSourceAll at all Moreover IMO pullPluginSource is only interesting if we can pass an URL for non ASF repos. But I agree we can go on with restructuring the OFBiz repo branch, and discuss further on dev ML if we should use svn:externals or not. I think we already put all the arguments on the table. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Comment Edited] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852723#comment-15852723 ] Jacques Le Roux edited comment on OFBIZ-9182 at 2/4/17 9:56 AM: Taher, Are you sure that's what Nicolas said? Nicolas? Anyway I agree we can go on, adding a svn externals is few seconds... was (Author: jacques.le.roux): Taher, Are you sure that's what Nicolas said? Nicolas? > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852724#comment-15852724 ] Jacques Le Roux commented on OFBIZ-9182: To be more clear, we have 3 types of users # committers # users basing their develoment on working copies # users basing their develoment on released package # want svn:externals # have svn:externals but want pullPluginSource to access their own repos # want pullPlugin > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852733#comment-15852733 ] Jacques Le Roux commented on OFBIZ-9182: Yes it's cumulative, the point is, as I already explained above, it's easier to have 19 plugins ready to use with svn:externals, when, if you want them with pullPluginSource (and have not svn:external), you have to use it 19 times, right? Also I guess adding an url, for users whot want pullPluginSource to access their own repos, is not a big deal? > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (OFBIZ-9200) Form widget: the image element used in the field element does not work when used with an existing field value
Jacques Le Roux created OFBIZ-9200: -- Summary: Form widget: the image element used in the field element does not work when used with an existing field value Key: OFBIZ-9200 URL: https://issues.apache.org/jira/browse/OFBIZ-9200 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Release Branch 16.11, Release Branch 15.12, Trunk, Release Branch 14.12, Release Branch 13.07 Reporter: Jacques Le Roux When you use the image element with a field name of an existing field value a fake chained request is weirdly called. This is true in both simple and list/grid forms, I did not test multi but I guess it's the same. For example if you add this line bq. just after the line bq. in the ListExamples form you get as much as errors as there are examples, eg: {code} 2017-02-04 06:03:27,605 |http-nio-8443-exec-7 |ControlServlet |E| Error in request handler: org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request [Example 1]; this request does not exist or cannot be called directly. at org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:197) ~[ofbiz.jar:?] at org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210) [ofbiz.jar:?] at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) [javax.servlet-api-3.1.0.jar:3.1.0] at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) [javax.servlet-api-3.1.0.jar:3.1.0] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) [tomcat-embed-websocket-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:209) [ofbiz.jar:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) [ofbiz.jar:?] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:509) [tomcat-catalina-8.0.39.jar:8.0.39] at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1104) [tomcat-coyote-8.0.39.jar:8.0.39] at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:684) [tomcat-coyote-8.0.39.jar:8.0.39] at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520) [tomcat-coyote-8.0.39.jar:8.0.39] at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476) [tomcat-coyote-8.0.39.jar:8.0.39] at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) [?:1.8.0_112] at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [?:1.8.0_112] at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61) [tomcat-util-8.0.39.jar:8.0.39] {code} As you can see from the
[jira] [Comment Edited] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852740#comment-15852740 ] Jacques Le Roux edited comment on OFBIZ-9182 at 2/4/17 10:41 AM: - Complexity, that's also my point. With a pullPluginSourceAll you have to maintain it each time you change the content of the plugins folder. While setting svn:externals is done in seconds for "eternity". Committers, users don't need to use pullPluginSourceAll. The plugins are already there checked out with the rest (for now ofbiz-core, later another externals can be set for ofbiz-framework and ofbiz-core as Jacopo suggested, and what-not anyway). For users using working copies, if they don't want to use a plugin they can either deactivate it or simply get rid of it by deleting its folder. was (Author: jacques.le.roux): Complexity, that's also my point. With a pullPluginSourceAll you have to maintain it each time you change the content of the plugins folder. While setting svn:externals is done in seconds for "eternity". Committers, users don't need to use pullPluginSourceAll. The plugins are already there checked out with the rest (for now ofbiz-core, alter another externals can be set for ofbiz-framework and ofbiz-core as Jacopo suggested, and what-not anyway). For users using working copies, if they don't want to use a plugin they can either deactivate it or simply get rid of it by deleting its folder. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852740#comment-15852740 ] Jacques Le Roux commented on OFBIZ-9182: Complexity, that's also my point. With a pullPluginSourceAll you have to maintain it each time you change the content of the plugins folder. While setting svn:externals is done in seconds for "eternity". Committers, users don't need to use pullPluginSourceAll. The plugins are already there checked out with the rest (for now ofbiz-core, alter another externals can be set for ofbiz-framework and ofbiz-core as Jacopo suggested, and what-not anyway). For users using working copies, if they don't want to use a plugin they can either deactivate it or simply get rid of it by deleting its folder. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852723#comment-15852723 ] Jacques Le Roux commented on OFBIZ-9182: Taher, Are you sure that's what Nicolas said? Nicolas? > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852746#comment-15852746 ] Jacques Le Roux commented on OFBIZ-9182: As I said already, the pb with gradle-svntools-plugin is it does not handle property (yet?) so I don't see how at this stage bq. svn externals could be an implementation detail then embedded inside pullPluginSourceAll Morevoer as setting an svn:externals is only a matter of a property commit (done once) I don't see the need to have that embedded inside pullPluginSourceAll at all Moreover IMO pullPluginSource is only interesting if we can pass an URL for non ASF repos. But I agree we can go on with restructuring the OFBiz repo branch, and discuss further on dev ML if we should use svn:externals or not. I think we already put all the arguments on the table. > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9200) Form widget: the image element used in the field element does not work when used with an existing field value
[ https://issues.apache.org/jira/browse/OFBIZ-9200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852900#comment-15852900 ] Jacques Le Roux commented on OFBIZ-9200: Another workaround is to create classes to use the images and use these classes in fields widget-style attribute with a display using a description with only a space. But this is quite circonvoluted when image is there! > Form widget: the image element used in the field element does not work when > used with an existing field value > - > > Key: OFBIZ-9200 > URL: https://issues.apache.org/jira/browse/OFBIZ-9200 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, Release Branch 16.11 >Reporter: Jacques Le Roux > > When you use the image element with a field name of an existing field value a > fake chained request is weirdly called. This is true in both simple and > list/grid forms, I did not test multi but I guess it's the same. > For example if you add this line > bq. value="/images/defaultImage.jpg"/> > just after the line > bq. sort-field="true"> > in the ListExamples form you get as much as errors as there are examples, eg: > {code} > 2017-02-04 06:03:27,605 |http-nio-8443-exec-7 |ControlServlet > |E| Error in request handler: > org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request > [Example 1]; this request does not exist or cannot be called directly. > at > org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:197) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.webapp.control.ControlServlet.doGet(ControlServlet.java:210) > [ofbiz.jar:?] > at javax.servlet.http.HttpServlet.service(HttpServlet.java:687) > [javax.servlet-api-3.1.0.jar:3.1.0] > at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) > [javax.servlet-api-3.1.0.jar:3.1.0] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52) > [tomcat-embed-websocket-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.ofbiz.webapp.control.ContextFilter.doFilter(ContextFilter.java:209) > [ofbiz.jar:?] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.ofbiz.webapp.control.ControlFilter.doFilter(ControlFilter.java:156) > [ofbiz.jar:?] > at > org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616) > [tomcat-catalina-8.0.39.jar:8.0.39] >at > org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:509) > [tomcat-catalina-8.0.39.jar:8.0.39] > at > org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1104) > [tomcat-coyote-8.0.39.jar:8.0.39] >at >
[jira] [Commented] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851363#comment-15851363 ] Jacques Le Roux commented on OFBIZ-9182: Actually I very well got what you said. I'm just adding that using externals is a very simple solution that should be considered for people who are using svn to check out things. bq. * First of all, the pullPluginSource won't stop you from using subversion if you want to. It's just a convenience task Yes got that bq. * In the first implementation way I described above, you need svn installed, in the second you don't Yes got that too, as I said what I'm suggesting is for people using svn to "automatically" have the same that we have now. For instance for committers it's very convenient. bq. * also using my patch we do not rely on a specific version control system. We can change it by changing implementation of pullPluginSource That could be indeed interesting if we move to Git for instance. Note that, as I said above, the same than svn externals can also be achieved by Git. bq. * with pullPluginSource we can easily add the logic to pull dependencies which we cannot do with raw subversion. The implementation is already there in "pullPlugin". OK good, not needed if we use svn externals for OOTB plugins. It could interesting if pullPluginSource accepted an url parameter for people having sources in other repos. This is what I was looking for when I spoke about Jitpack. bq. * activating / deactivating plugins (or any component) can be done using ofbiz-component.xml. I don't understand why component-load.xml is needed in your argument above. Yes right, that's a very good point I missed. Indeed using the enabled attribute of the ofbiz-component element is the way. So I think we can agree that having both solutions is possible. For svn externals, after changing the repo structure, it's only a matter of adding the property, et voilà. Do you think we need to discuss that on dev ML? > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Reopened] (OFBIZ-5306) Error of running "ant clean-all" or "ant refresh"
[ https://issues.apache.org/jira/browse/OFBIZ-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-5306: Assignee: Jacques Le Roux > Error of running "ant clean-all" or "ant refresh" > - > > Key: OFBIZ-5306 > URL: https://issues.apache.org/jira/browse/OFBIZ-5306 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Wei Zhang >Assignee: Jacques Le Roux > > see the details below > BUILD FAILED > D:\Projects\RHH\ofbiz-trunk\build.xml:64: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:77: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:145: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\applications\content\build.xml:64: Directory does > not exist: D:\Projects\RHH\ofbiz-trunk\runtime\data\indexes -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-5306) Error of running "ant clean-all" or "ant refresh"
[ https://issues.apache.org/jira/browse/OFBIZ-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15851370#comment-15851370 ] Jacques Le Roux commented on OFBIZ-5306: Thanks Wei, closed as not a pb > Error of running "ant clean-all" or "ant refresh" > - > > Key: OFBIZ-5306 > URL: https://issues.apache.org/jira/browse/OFBIZ-5306 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Wei Zhang >Assignee: Jacques Le Roux > > see the details below > BUILD FAILED > D:\Projects\RHH\ofbiz-trunk\build.xml:64: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:77: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:145: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\applications\content\build.xml:64: Directory does > not exist: D:\Projects\RHH\ofbiz-trunk\runtime\data\indexes -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Closed] (OFBIZ-5306) Error of running "ant clean-all" or "ant refresh"
[ https://issues.apache.org/jira/browse/OFBIZ-5306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-5306. -- Resolution: Not A Problem > Error of running "ant clean-all" or "ant refresh" > - > > Key: OFBIZ-5306 > URL: https://issues.apache.org/jira/browse/OFBIZ-5306 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk >Reporter: Wei Zhang >Assignee: Jacques Le Roux > > see the details below > BUILD FAILED > D:\Projects\RHH\ofbiz-trunk\build.xml:64: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:77: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\build.xml:145: The following error occurred while > executing this line: > D:\Projects\RHH\ofbiz-trunk\applications\content\build.xml:64: Directory does > not exist: D:\Projects\RHH\ofbiz-trunk\runtime\data\indexes -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Updated] (OFBIZ-9196) Regression: the testIntegration Gradle taks shoud not use/block the ports
[ https://issues.apache.org/jira/browse/OFBIZ-9196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-9196: --- Description: We got an issue on Buildbot because of a Puppet misconfiguration which was always using the port 8080. Pre-gradle OFBiz tests were still running fine on Buildbot. Before the Puppet misconfiguration fix by infra (INFRA-13402), to bypass this issue I tried last weekend to use portoffset in Gradle versions. From the documentation, it's theoretically possible but does not work. Taher suggested, to get back to the previous behaviour were tests were not using/blocking the 8080 port, and to have a look into Config.java... It's a regression because it was nice to not have ports blocked during tests, as it was before Gradle. So you can use another (or more) OFBiz instance while running tests, and vice-versa. was: We got an issue on Buildbot because of a Puppet misconfiguration which was always using the port 8080. Pre-gradle OFBiz tests were still running fine on Buildbot. Before the Puppet misconfiguration fix by infra (INFRA-13402) bo bypass this issue I tried last weekend to use portoffset in Gradle versions. From the documentation, it's theoretically possible but does not work. Taher suggested, to get back to the previous behaviour were tests were not using/blocking the 8080 port. Taher suggested to have a look into Config.java... It's a regression because it was nice to not have ports blocked during tests, as it was before Gradle. So you can use another (or more) OFBiz instance while running tests, and vice-versa. > Regression: the testIntegration Gradle taks shoud not use/block the ports > - > > Key: OFBIZ-9196 > URL: https://issues.apache.org/jira/browse/OFBIZ-9196 > Project: OFBiz > Issue Type: Bug > Components: Gradle >Affects Versions: Trunk, Release Branch 16.11 >Reporter: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release, 16.11.02 > > > We got an issue on Buildbot because of a Puppet misconfiguration which was > always using the port 8080. Pre-gradle OFBiz tests were still running fine on > Buildbot. > Before the Puppet misconfiguration fix by infra (INFRA-13402), to bypass this > issue I tried last weekend to use portoffset in Gradle versions. From the > documentation, it's theoretically possible but does not work. > Taher suggested, to get back to the previous behaviour were tests were not > using/blocking the 8080 port, and to have a look into Config.java... > It's a regression because it was nice to not have ports blocked during tests, > as it was before Gradle. So you can use another (or more) OFBiz instance > while running tests, and vice-versa. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
[ https://issues.apache.org/jira/browse/OFBIZ-9182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15847573#comment-15847573 ] Jacques Le Roux commented on OFBIZ-9182: Hi Taher, Just thinking out loud for now... We don't need 2 Buildbot scripts if we can use svn externals http://svnbook.red-bean.com/en/1.8/svn.advanced.externals.html Note about automation: currently https://github.com/martoe/gradle-svntools-plugin does not support svn propedit, we could contribute, it's groovy code after all... BTW, there is a similar solutions with Git if we need it later https://stackoverflow.com/questions/571232/svnexternals-equivalent-in-git I have one worry, what about people relying on branches (eg evolving with new features R16.11) and not release (fixed but bug 16.11.01) ? It seems they will loose something, don't they? Fortunately svn externals allows to define specific revisions. For instance we could define a revision for each plugin. As you said maybe too much, but maybe also convenient. Anyway this needs at least to be evaluated (ie more than just thinking out loud late in the evening...) > create a separate svn repository for OFBiz official plugins > --- > > Key: OFBIZ-9182 > URL: https://issues.apache.org/jira/browse/OFBIZ-9182 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Upcoming Release >Reporter: Taher Alkhateeb >Priority: Minor > Labels: gradle, plugins, subversion > Attachments: OFBIZ-9182-subversion-embedded.patch > > > This issue is related to the discussion found in [this > thread|https://s.apache.org/aohk] in which the community approved > restructuring our repositories. To achieve this task the following needs to > be done (in this order) > # Update the gradle scripts to assume that no plugins exist in the plugins > directory by default and no component-load.xml exists. It should follow the > same logic in loading the components as found in the ComponentContainer > class. Also the activation and deactivation of plugins happens in > ofbiz-component.xml, not in component-load.xml > # Add a new task to gradle called pullPluginSource that retrieves a plugin > from subversion and defaults to the official plugins repository of Apache > OFBiz. This task mostly serve "Trunk" because it always needs the latest > source code of the plugins. > # delete plugins/component-load.xml > # move all plugins to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-plugins > # move the core framework to a new repository called > http://svn.apache.org/repos/asf/ofbiz/ofbiz-framework > # fix buildbot to point to the new framework location > # update documentation where applicable including README.md -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (OFBIZ-9157) "View Order" throws exception in getReturnableQuantity
[ https://issues.apache.org/jira/browse/OFBIZ-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832916#comment-15832916 ] Jacques Le Roux commented on OFBIZ-9157: Hi Leonard, About bq. - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product I know no product with a null price. So you do that programatically, right? > "View Order" throws exception in getReturnableQuantity > -- > > Key: OFBIZ-9157 > URL: https://issues.apache.org/jira/browse/OFBIZ-9157 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 15.12, Release Branch 16.11 > Environment: Encountered this but in 15.x and 16.x Trunk versions >Reporter: Leonard Lin >Priority: Minor > Attachments: services_return.xml.patch > > > Steps to Reproduce: > - Create a sales order > - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product > - set the status of the order to completed > - go to order-management and try to open the order for display like: > https://localhost:8443/ordermgr/control/orderview?orderId=X > Expected: > - the order is displayed with status completed > Actual: > - A groovy exception is displayed. > Analysis: > The service "getReturnableQuantity" throws an exception because it returns > the returnablePrice = null, because the unitPrice of the orderItem was null. > The OUT field returnablePrice is mandatory according to the > service-definition. The return parameter is set but the value is null, hence > the exception. > Attached is a patch that will adjust the service-deinition to allow for > "null" value of the OUT parameter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-9128) Document current possiblities of the EntityAutoEngine
[ https://issues.apache.org/jira/browse/OFBIZ-9128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9128. -- Resolution: Works for Me Assignee: Paul Foxworthy Thanks Paul, works for me :) > Document current possiblities of the EntityAutoEngine > - > > Key: OFBIZ-9128 > URL: https://issues.apache.org/jira/browse/OFBIZ-9128 > Project: OFBiz > Issue Type: Sub-task > Components: Confluence, framework >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Paul Foxworthy >Priority: Minor > Fix For: Upcoming Release > > > As explained [~paul_foxworthy] [in this > comment|https://issues.apache.org/jira/browse/OFBIZ-9117?focusedCommentId=15672946=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15672946] > {quote} > I don't expect entity-auto to handle every possible situation. I'd suggest we > keep it simple and 80-20 rather than fiddle with it forever. > There's an error message if you try to push it too hard which lists what it > can do: > "1. a single OUT pk for primary auto-sequencing, " + > "2. a single INOUT pk for primary auto-sequencing with optional override, " + > "3. a 2-part pk with one part IN (existing primary pk) and one part OUT (the > secondary pk to sub-sequence), " + > "4. a N-part pk with N-1 part IN and one party OUT only (missing pk is a > sub-sequence mainly for entity assoc), " + > "5. all pk fields are IN for a manually specified primary key"); > So it can deliver one new id in an out parameter, but not more than one. I > can live with that. For more complex situations, we can write a service > rather than use entity auto. > {quote} > I suggest we document it in services.xsd and the [Service Engine > Guide|https://cwiki.apache.org/confluence/display/OFBIZ/Service+Engine+Guide], > explaining what the possiblities are based on the message above. BTW I had a > look at services.xsd and it's not yet documented enough. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832956#comment-15832956 ] Jacques Le Roux edited comment on OFBIZ-6919 at 1/21/17 12:02 PM: -- This new birt.zip archive replaces flexibleBirt.tar.gz, small not functional change, same usage (delete the birt component, replace it with the content of the birt.zip archive) was (Author: jacques.le.roux): This new birt.zip archive replaces flexibleBirt.tar.gz, small not functional change, same usage > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: birt.zip, flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6919: --- Attachment: birt.zip This new birt.zip archive replaces flexibleBirt.tar.gz, small not functional change, same usage > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: birt.zip, flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-9157) "View Order" throws exception in getReturnableQuantity
[ https://issues.apache.org/jira/browse/OFBIZ-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9157. -- Resolution: Fixed Assignee: Jacques Le Roux Fix Version/s: Release Branch 14.12 Release Branch 15.12 16.11.02 Upcoming Release Leonard, Your solution is committed in trunk r1779724 R16.11 r1779725 R15.12 r1779726 R14.12 r1779727 R13.07 r1779728 > "View Order" throws exception in getReturnableQuantity > -- > > Key: OFBIZ-9157 > URL: https://issues.apache.org/jira/browse/OFBIZ-9157 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 15.12, Release Branch 16.11 > Environment: Encountered this in 15.x and 16.x Trunk versions >Reporter: Leonard Lin >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release, 16.11.02, Release Branch 15.12, > Release Branch 14.12 > > Attachments: services_return.xml.patch > > > Steps to Reproduce: > - Create a sales order > - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product > - set the status of the order to completed > - go to order-management and try to open the order for display like: > https://localhost:8443/ordermgr/control/orderview?orderId=X > Expected: > - the order is displayed with status completed > Actual: > - A groovy exception is displayed. > Analysis: > The service "getReturnableQuantity" throws an exception because it returns > the returnablePrice = null, because the unitPrice of the orderItem was null. > The OUT field returnablePrice is mandatory according to the > service-definition. The return parameter is set but the value is null, hence > the exception. > Attached is a patch that will adjust the service-deinition to allow for > "null" value of the OUT parameter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9157) "View Order" throws exception in getReturnableQuantity
[ https://issues.apache.org/jira/browse/OFBIZ-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832930#comment-15832930 ] Jacques Le Roux commented on OFBIZ-9157: OK thanks, makes sense. I'll apply your solution > "View Order" throws exception in getReturnableQuantity > -- > > Key: OFBIZ-9157 > URL: https://issues.apache.org/jira/browse/OFBIZ-9157 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 15.12, Release Branch 16.11 > Environment: Encountered this in 15.x and 16.x Trunk versions >Reporter: Leonard Lin >Priority: Minor > Attachments: services_return.xml.patch > > > Steps to Reproduce: > - Create a sales order > - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product > - set the status of the order to completed > - go to order-management and try to open the order for display like: > https://localhost:8443/ordermgr/control/orderview?orderId=X > Expected: > - the order is displayed with status completed > Actual: > - A groovy exception is displayed. > Analysis: > The service "getReturnableQuantity" throws an exception because it returns > the returnablePrice = null, because the unitPrice of the orderItem was null. > The OUT field returnablePrice is mandatory according to the > service-definition. The return parameter is set but the value is null, hence > the exception. > Attached is a patch that will adjust the service-deinition to allow for > "null" value of the OUT parameter. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[ https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15834422#comment-15834422 ] Jacques Le Roux commented on OFBIZ-9185: Actually I even think we should do that by using remove-related with a default remove-foreign-key attribute sets to no. Because this issue is not only deleteWorkEffort but everywhere remove-related is used. If remove-foreign-key is set to yes then we 1st remove, from the WorkEffort record, the value linking it to the related entity. Then the EE will not prevent to remove the related entity, et voilà. > The deleteWorkEffort service is incomplete and even wrong > - > > Key: OFBIZ-9185 > URL: https://issues.apache.org/jira/browse/OFBIZ-9185 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > > This issue is very old (pre Apache) so all versions are affected (I just > tested with R09.04) > When you try to delete a Workeffort which has an established relationship > with a RuntimeData or any of the entities Workeffort has a relation with (eg > NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one > fails > Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort, > would be to add > {code} > relation-name="CustRequestWorkEffort"/> > {code} > Besides (minor) ApplicationSandbox is maybe missing in the implementation of > deleteWorkEffort. > There is indeed a workeffortId in ApplicationSandbox. > So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData. > But it can anyway be deleted by a simple delete-by-and (or alike), so not a > problem for deleteWorkEffort, though this case could be handled there also. > Summary: the deleteWorkEffort service needs more work. The only solution I > see is to remove the FK from the Workeffort (ie put null in the related field > if it's not) and then deleted the related entity instead of directly calling > remove-related -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5312) Proposal: URL-Generation Changes (mostly for SEO reasons but not only)
[ https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837371#comment-15837371 ] Jacques Le Roux commented on OFBIZ-5312: Thanks Paul, bq. Good, clean URLs are good for human beings, not just for SEO. .../control/... is definitely not a good, clean URL. This helps to get on the right way! bq. Good, clean URLs are beneficial for all of OFBiz, not just e-commerce, not just product information. Do you think we need to apply the same scheme everywhere? Even in backend? bq. The solution is to add a canonical URL link (https://en.wikipedia.org/wiki/Canonical_link_element) to the content, to make clear the primary URL and to make clear alternative URLs are just that, alternative paths to the same thing. That's quite a good idea, have you an idea on how to implement that in OFBiz? > Proposal: URL-Generation Changes (mostly for SEO reasons but not only) > -- > > Key: OFBIZ-5312 > URL: https://issues.apache.org/jira/browse/OFBIZ-5312 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Labels: changes, ecommerce, friendly, seo, url > Fix For: 16.11.01 > > Attachments: classloaderpatch.txt, > OFBiz-5312-allowpaths-email-jsp-patch-20140625.patch, > OFBIZ-5312-infinite-loop-20141209.patch, OFBIZ-5312 - > ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 > - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, > OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - > ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 > - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, > OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - > ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, > OFBiz-5312-product-ecommerce-seo-20131031.patch, > OFBiz-5312-product-ecommerce-seo-for-seo-branch.patch, > OFBiz-5312-product-ecommerce-seo.patch, SeoContextFilter.java.patch > > > [This was proposed by Paul Piper in Nabble 7 months > ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html]. > Here is quoted Paul's proposal > {quote} > Hey Everyone, > over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz > changes that we believe the entire community could benefit from. The changes > have been implemented in parts in Syracus (www.syracus.net) for a while now, > but we figured that some of which are too crucial for ofbiz' success in the > long run, so we are considering the contribution (as we did with the SOLR > component). > As you are probably aware, OFBiz has a pretty uncommon way of generating > URLs. Most of this has to do with the fact that OFBiz uses a servlet > (ControlServlet) to handle all requests. The servlet is mounted at /control, > so that it won't interfere with other servlets. Though functionally valid, > this has the sideeffect that all urls are actually created on /control, which > is neither pretty, nor good by any measures of SEO. It also means that a few > 302 redirects are necessary to forward the user from / to /control/main. It > also makes requests more complicated, since many forwards are necessary > whenever somebody wants to move away from this implementation. > Since this is hurtful to many of the implementers, I wanted to discuss > whether or not you guys would be interested in the changes we have made. The > functional changes contain: > * Removal of /control out of all the urls > * SEO-friendly URLS > * Configurable product/category and other URLs > * Frontpage mapping from /main to / > It was tested on our end and contains all necessary improvements (Transforms, > Sample Configuration, Servlets & Filters) for it to be applicable. > If interested, I would create a new JIRA ticket for this and after a few > minor internal discussions, we will gladly provide the rest of you with it. > Regards, > Paul > {quote} > There is even a patch, mostly done by Jinghai Shi, that I attach here. Even > if it has been already used in [Syracus|http://syracus.net/] since early this > year, some help would be needed to test it thoroughly in OFBiz. > Then we should discuss if it's the way to go. I believe it is. Who needs a > /control/ or /main by default in ecommerce urls? Would you not prefer > http://localhost:8080/ecommerce/ over > http://localhost:8080/ecommerce/control/main ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15840964#comment-15840964 ] Jacques Le Roux commented on OFBIZ-6919: Hi Nicolas, That's indeed another option that we would then need to document. But I still wonder when end users will need these fields in reports... Maybe we could even remove them altogether (all technical field types) but could have them with a (I guess rarely used) property (or maybe a property by type)? > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: birt.zip, flexibleBirt.tar.gz, flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-9187) payroll integration
[ https://issues.apache.org/jira/browse/OFBIZ-9187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9187. -- Resolution: Invalid Please ask questions on user mailing list http://ofbiz.apache.org/mailing-lists.html Thanks > payroll integration > --- > > Key: OFBIZ-9187 > URL: https://issues.apache.org/jira/browse/OFBIZ-9187 > Project: OFBiz > Issue Type: New Feature > Components: accounting, humanres >Affects Versions: Release Branch 16.11 >Reporter: Moatasim Al Masri > Labels: features > Fix For: Upcoming Release > > > is payroll is integrated with accounting and benefits and deduction? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6206) The "always" log level in minilang is logged as FATAL
[ https://issues.apache.org/jira/browse/OFBIZ-6206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843192#comment-15843192 ] Jacques Le Roux commented on OFBIZ-6206: Hi Nicolas, it's OK with me, we will hopefully see later how to fix that. Also looking at you patch, maybe some (maybe a lot...) of these logs could be discarded. like {code} {code} OK even stopping to collecting them! It seems most of them should be deleted! > The "always" log level in minilang is logged as FATAL > -- > > Key: OFBIZ-6206 > URL: https://issues.apache.org/jira/browse/OFBIZ-6206 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 14.12, Trunk >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-6206.patch > > -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15843281#comment-15843281 ] Jacques Le Roux commented on OFBIZ-6919: Hi Nicolas, Though because of a power outage I had no chances to make a review today as I expected, I agree we can commit and share with the community. I'll try to translate/migrate the developer documentation ASAP :) Then I'll do the same for the users documentation, which is actually also much useful for developers. About the properties, we 1st need to define the types. We can though obviously begin with the timestamp fields and increase later. Other ideas than timestamp fields already? Pierre, of course I see no reasons to not create EntityUtil calls for these properties. > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: birt.zip, flexibleBirt.tar.gz, flexibleBirt.tar.gz, > OFBIZ-6919.patch > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] (OFBIZ-9191) Navigate Accounts tree
Title: Message Title Jacques Le Roux commented on OFBIZ-9191 Re: Navigate Accounts tree Thanks Moatasim, There is indeed an issue which can be reproduced on the official demo stable (R16) https://ofbiz-vm2.apache.org:18443/accounting/control/GlAccountNavigate?trail=null|10 trunk https://ofbiz-vm2.apache.org:8443/accounting/control/GlAccountNavigate?trail=null|10 But works in old (R13) https://ofbiz-vm2.apache.org:28443/accounting/control/GlAccountNavigate?trail=null%7C10 Then note that it works also in both stable and trunk when encoding | with %7C1 trunk https://ofbiz-vm2.apache.org:8443/accounting/control/GlAccountNavigate?trail=null%7C10 stable (R16) https://ofbiz-vm2.apache.org:18443/accounting/control/GlAccountNavigate?trail=null%7C10 So it's an encoding issue... Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
Title: Message Title Jacques Le Roux commented on OFBIZ-6919 Re: Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation. Hi Nicolas, I just tested with trunk HEAD (so using Taher last plugins implementation) and all works perfectly, but I noticed the stamps fields are no longer present (which is great OOTB IMo), normal? Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Title: Message Title Jacques Le Roux commented on OFBIZ-9182 Re: create a separate svn repository for OFBiz official plugins Taher, I reviewed r1780790 and it's OK with me (not tested yet). About your proposed patch, it also looks good to me (though not tested). Something though which seems to miss in gradle-svntools-plugin is the svn:externals feature. It would be great if we could not only check plugins out, but also keep them updated later... Before commenting on Nicolas's comment, I'm not sure I clearly understand the sentence This task mostly server "Trunk" because it always needs the latest source code of the plugins. Now if I understand it the same way than Nicolas (ie plugins are always based on trunk) then I agree with Nicolas, and BTW small incompatibility between a stable branch and the trunk. is even an euphemism Nicolas, when you say With this a user can use a future published version like 16.10.01 I guess you mean 16.10.02? Because 16.10.01 is already released. If we really are on the same page, I think that rather than using a Java properties file, we should rely on the svn:external svn property. Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9182) create a separate svn repository for OFBiz official plugins
Title: Message Title Jacques Le Roux commented on OFBIZ-9182 Re: create a separate svn repository for OFBiz official plugins I tested r1780790, works for me, thanks Taher! Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9192) Implement and demonstrate few services in Birt Report Builder
Title: Message Title Jacques Le Roux created an issue OFBiz / OFBIZ-9192 Implement and demonstrate few services in Birt Report Builder Issue Type: Sub-task Affects Versions: Trunk Assignee: Unassigned Components: specialpurpose/birt Created: 30/Jan/17 20:47 Fix Versions: Upcoming Release Priority: Minor Reporter: Jacques Le Roux While reviewing r1780800 I stumbled upon BirtMasterReportServices class which remembered me that the Birt Report Builder can also use services. We will provide some simple examples based on OOTB entities to show how ti create and use such services
[jira] (OFBIZ-9189) Birt Report Builder: migrate delegator.find calls to EntityQuery
Title: Message Title Jacques Le Roux commented on OFBIZ-9189 Re: Birt Report Builder: migrate delegator.find calls to EntityQuery Thanks Nicolas! Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Created] (OFBIZ-9184) In entitymodel.xsd entity-alias for condition-expr must be required
Jacques Le Roux created OFBIZ-9184: -- Summary: In entitymodel.xsd entity-alias for condition-expr must be required Key: OFBIZ-9184 URL: https://issues.apache.org/jira/browse/OFBIZ-9184 Project: OFBiz Issue Type: Bug Components: datamodel Affects Versions: Release Branch 15.12, 16.11.01, Trunk, Release Branch 14.12, Release Branch 13.07 Reporter: Jacques Le Roux Assignee: Jacques Le Roux Fix For: Upcoming Release, 16.11.02, Release Branch 16.11, Release Branch 15.12, Release Branch 14.12, Release Branch 13.07 Currently in the entitymodel.xsd the line {code} {code} is wrong, should be {code} {code} Else in line {code} this.entityAlias = entityAlias; {code} in ModelViewEntity.ViewConditionExpr() {code} this.entityAlias {code} receives null. All supported branches are concerned -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Closed] (OFBIZ-9184) In entitymodel.xsd entity-alias for condition-expr must be required
[ https://issues.apache.org/jira/browse/OFBIZ-9184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-9184. -- Resolution: Fixed Fix Version/s: (was: Release Branch 16.11) Fixed in all supported branches at r1779625 > In entitymodel.xsd entity-alias for condition-expr must be required > --- > > Key: OFBIZ-9184 > URL: https://issues.apache.org/jira/browse/OFBIZ-9184 > Project: OFBiz > Issue Type: Bug > Components: datamodel >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > 16.11.01, Release Branch 15.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux > Fix For: Upcoming Release, 16.11.02, Release Branch 15.12, > Release Branch 14.12, Release Branch 13.07 > > > Currently in the entitymodel.xsd the line > {code} > > {code} > is wrong, should be > {code} > > {code} > Else in line > {code} > this.entityAlias = entityAlias; > {code} > in ModelViewEntity.ViewConditionExpr() > {code} > this.entityAlias > {code} > receives null. > All supported branches are concerned -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-8822) Search operation on 'AllExamplesWithDesiredCustomerFeaturesReport' entity causing exception
[ https://issues.apache.org/jira/browse/OFBIZ-8822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15831778#comment-15831778 ] Jacques Le Roux commented on OFBIZ-8822: Backported in R15 and R14 at r1779624 > Search operation on 'AllExamplesWithDesiredCustomerFeaturesReport' entity > causing exception > --- > > Key: OFBIZ-8822 > URL: https://issues.apache.org/jira/browse/OFBIZ-8822 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Jacques Le Roux > Fix For: 16.11.01 > > Attachments: OFBIZ-8822.patch > > > Steps to regenerate: > 1. Go to Entity Data Maintenance in webtools > 2. Search entity 'AllExamplesWithDesiredCustomerFeaturesReport'. Click and go > to the overview page. > 3. Click on the Search button. > We are getting following exception: > 2016-11-03 21:29:22,584 |ttp-nio-8443-exec-10 |ScriptUtil > |W| Error running script at location > [component://webtools/groovyScripts/entity/FindGeneric.groovy]: > java.lang.IllegalArgumentException: > [AllExamplesWithDesiredCustomerFeaturesReport]: Error in Entity Find: could > not find field [featureSourceEnumId] > java.lang.IllegalArgumentException: > [AllExamplesWithDesiredCustomerFeaturesReport]: Error in Entity Find: could > not find field [featureSourceEnumId] > at > org.apache.ofbiz.entity.model.ModelViewEntity$ViewConditionExpr.createCondition(ModelViewEntity.java:1395) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.entity.model.ModelViewEntity$ViewEntityCondition.getWhereCondition(ModelViewEntity.java:1307) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.entity.model.ModelViewEntity.populateViewEntityConditionInformation(ModelViewEntity.java:313) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:724) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:140) > ~[ofbiz.jar:?] > at > org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1551) > ~[ofbiz.jar:?] > at org.apache.ofbiz.entity.Delegator$find$2.call(Unknown Source) ~[?:?] > at > org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48) > ~[groovy-all-2.4.5.jar:2.4.5] > at > org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113) > ~[groovy-all-2.4.5.jar:2.4.5] > at FindGeneric.run(FindGeneric.groovy:183) ~[?:?] > Expected: Data for view entity should be searched and displayed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
Jacques Le Roux created OFBIZ-9185: -- Summary: The deleteWorkEffort service is incomplete and even wrong Key: OFBIZ-9185 URL: https://issues.apache.org/jira/browse/OFBIZ-9185 Project: OFBiz Issue Type: Bug Components: workeffort Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Minor This issue is very old (pre Apache) so all versions are affected (I just tested with R09.04) When you try to delete a Workeffort which has an established relationship with a RuntimeData or any of the entities Workeffort has a relation with (eg NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one fails Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort, would be to add {code} {code} Besides (minor) ApplicationSandbox is maybe missing in the implementation of deleteWorkEffort. There is indeed a workeffortId in ApplicationSandbox. So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData. But it can anyway be deleted by a simple delete-by-and (or alike), so not a problem for deleteWorkEffort, though this case could be handled there also. Summary: the deleteWorkEffort service needs more work. The only solution I see is to remove the FK from the Workeffort (ie put null in the related field if it's not) and then deleted the related entity instead of directly calling remove-related -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-9185) The deleteWorkEffort service is incomplete and even wrong
[ https://issues.apache.org/jira/browse/OFBIZ-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15833512#comment-15833512 ] Jacques Le Roux commented on OFBIZ-9185: I thought wonder if this has never worked, maybe it has not been tested when committed. But I still wonder because I guess people delete WorkEffort entities since then. > The deleteWorkEffort service is incomplete and even wrong > - > > Key: OFBIZ-9185 > URL: https://issues.apache.org/jira/browse/OFBIZ-9185 > Project: OFBiz > Issue Type: Bug > Components: workeffort >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > > This issue is very old (pre Apache) so all versions are affected (I just > tested with R09.04) > When you try to delete a Workeffort which has an established relationship > with a RuntimeData or any of the entities Workeffort has a relation with (eg > NoteData, RecurrenceInfo) using the the deleteWorkEffort service this one > fails > Also from my experience CustRequestWorkEffort is missing in deleteWorkEffort, > would be to add > {code} > relation-name="CustRequestWorkEffort"/> > {code} > Besides (minor) ApplicationSandbox is maybe missing in the implementation of > deleteWorkEffort. > There is indeed a workeffortId in ApplicationSandbox. > So ApplicationSandbox is indirectly linked to Workeffort by RuntimeData. > But it can anyway be deleted by a simple delete-by-and (or alike), so not a > problem for deleteWorkEffort, though this case could be handled there also. > Summary: the deleteWorkEffort service needs more work. The only solution I > see is to remove the FK from the Workeffort (ie put null in the related field > if it's not) and then deleted the related entity instead of directly calling > remove-related -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6919) New implementation of Birt. Easier user possibility of report creation
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6919: --- Description: This is a new implementation of Birt. It allows the creation of "report masters" by the developer, which will in turn let the user create its own reports. Data connection of report is fully generated by OFBiz based on report master. Design is user made. Filtering is made via content forms stored in the database ("FORM_COMBINED") data_resource. The patch should be available in a few days. Credits: this feature has been designed by Nicolas Malin, Pierre Gaudin and was: This is a new implementation of Birt. It allows the creation of "report masters" by the developer, which will in turn let the user create its own reports. Data connection of report is fully generated by OFBiz based on report master. Design is user made. Filtering is made via content forms stored in the database ("FORM_COMBINED") data_resource. The patch should be available in a few days. > New implementation of Birt. Easier user possibility of report creation > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > Credits: this feature has been designed by Nicolas Malin, Pierre Gaudin and -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6919) New implementation of Birt. Easier user possibility of report creation
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6919: --- Description: This is a new implementation of Birt. It allows the creation of "report masters" by the developer, which will in turn let the user create its own reports. Data connection of report is fully generated by OFBiz based on report master. Design is user made. Filtering is made via content forms stored in the database ("FORM_COMBINED") data_resource. The patch should be available in a few days. *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and François Wurmser. It has been implemented by François Wurmser as a Neogia addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to the OFBiz trunk with simple changes in the framework where it was secured using OWASP security policies. *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java code was: This is a new implementation of Birt. It allows the creation of "report masters" by the developer, which will in turn let the user create its own reports. Data connection of report is fully generated by OFBiz based on report master. Design is user made. Filtering is made via content forms stored in the database ("FORM_COMBINED") data_resource. The patch should be available in a few days. Credits: this feature has been designed by Nicolas Malin, Pierre Gaudin and > New implementation of Birt. Easier user possibility of report creation > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6919) Birt Report Builder: a new implementation of Birt. Easier user possibility of report creation
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6919: --- Summary: Birt Report Builder: a new implementation of Birt. Easier user possibility of report creation (was: New implementation of Birt. Easier user possibility of report creation) > Birt Report Builder: a new implementation of Birt. Easier user possibility of > report creation > - > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-6919: --- Summary: Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation. (was: Birt Report Builder: a new implementation of Birt. Easier user possibility of report creation) > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832846#comment-15832846 ] Jacques Le Roux commented on OFBIZ-6919: If you use the current "Birt Report Builder" version (WIP...) with another theme (tested with Tomahawk) than a Rainbow theme, to see the new functionnalities (added to current Birt component) look into the dropdown menus for the "Flexible Report" menu (to be renamed "Report Builder") > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832851#comment-15832851 ] Jacques Le Roux commented on OFBIZ-6919: I committed a small fix (contentId name changed) in the framework and content component at r1779701 > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
[ https://issues.apache.org/jira/browse/OFBIZ-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830019#comment-15830019 ] Jacques Le Roux edited comment on OFBIZ-6919 at 1/21/17 7:04 AM: - Hi François, First I'd like to congratulate you for the work you did, really good! I know you made a good documentation, without it I'd have needed much more time to understand how things works in the new Birt Report Builder. I just need to translate/create in English the same *user* documentation you made in French (ie "[DOC] Designer un rapport sous Birt.pdf" and "[DOC]Installation de l'interface de requétage.pdf") and Nicolas already gave me all he has. So it should not be a problem :) was (Author: jacques.le.roux): Hi François, First I'd like to congratulate you for the work you did, really good! I know you made a good documentatin, without it I'd have needed much more time to understand how things works in the new Birt Report Builder. I just need to translate/create the same *user* documentation you made in French (ie "[DOC] Designer un rapport sous Birt.pdf" and "[DOC]Installation de l'interface de requétage.pdf") and Nicolas already gave me all he has. So it should not be a problem :) > Birt Report Builder: an enhancement of the Birt component. Easier user > possibility of report creation. > -- > > Key: OFBIZ-6919 > URL: https://issues.apache.org/jira/browse/OFBIZ-6919 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/birt >Affects Versions: Trunk >Reporter: François Wurmser >Assignee: Jacques Le Roux >Priority: Minor > Fix For: Upcoming Release > > Attachments: flexibleBirt.tar.gz > > > This is a new implementation of Birt. It allows the creation of "report > masters" by the developer, which will in turn let the user create its own > reports. Data connection of report is fully generated by OFBiz based on > report master. Design is user made. > Filtering is made via content forms stored in the database ("FORM_COMBINED") > data_resource. > The patch should be available in a few days. > *Credits:* this feature has been designed by Nicolas Malin, Pierre Gaudin and > François Wurmser. It has been implemented by François Wurmser as a Neogia > addon and ported by Jacques Le Roux to a custom OFBiz R13 version and then to > the OFBiz trunk with simple changes in the framework where it was secured > using OWASP security policies. > *Note:* the BIRT_REPORT_BUILDER_USAGE_POLICY still needs to be completed. For > now it's bypassed on "FLEXIBLE_REPORT" contentTypeId, a FIXME exists in Java > code -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (OFBIZ-5312) Proposal: URL-Generation Changes (mostly for SEO reasons but not only)
[ https://issues.apache.org/jira/browse/OFBIZ-5312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838467#comment-15838467 ] Jacques Le Roux commented on OFBIZ-5312: I think we should rather create a new one. I believe I have not to explain why, should I? > Proposal: URL-Generation Changes (mostly for SEO reasons but not only) > -- > > Key: OFBIZ-5312 > URL: https://issues.apache.org/jira/browse/OFBIZ-5312 > Project: OFBiz > Issue Type: New Feature > Components: specialpurpose/ecommerce >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > Labels: changes, ecommerce, friendly, seo, url > Fix For: 16.11.01 > > Attachments: classloaderpatch.txt, > OFBiz-5312-allowpaths-email-jsp-patch-20140625.patch, > OFBIZ-5312-infinite-loop-20141209.patch, OFBIZ-5312 - > ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 > - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, > OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - > ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 > - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, > OFBIZ-5312 - ofbiz-ecommerce-seo.patch, OFBIZ-5312 - > ofbiz-ecommerce-seo.patch, OFBIZ-5312 - ofbiz-ecommerce-seo.patch, > OFBiz-5312-product-ecommerce-seo-20131031.patch, > OFBiz-5312-product-ecommerce-seo-for-seo-branch.patch, > OFBiz-5312-product-ecommerce-seo.patch, SeoContextFilter.java.patch > > > [This was proposed by Paul Piper in Nabble 7 months > ago|http://ofbiz.135035.n4.nabble.com/Proposal-URL-Generation-Changes-td4639289.html]. > Here is quoted Paul's proposal > {quote} > Hey Everyone, > over at ilscipio (www.ilscipio.com) we developed a set of functional OFBiz > changes that we believe the entire community could benefit from. The changes > have been implemented in parts in Syracus (www.syracus.net) for a while now, > but we figured that some of which are too crucial for ofbiz' success in the > long run, so we are considering the contribution (as we did with the SOLR > component). > As you are probably aware, OFBiz has a pretty uncommon way of generating > URLs. Most of this has to do with the fact that OFBiz uses a servlet > (ControlServlet) to handle all requests. The servlet is mounted at /control, > so that it won't interfere with other servlets. Though functionally valid, > this has the sideeffect that all urls are actually created on /control, which > is neither pretty, nor good by any measures of SEO. It also means that a few > 302 redirects are necessary to forward the user from / to /control/main. It > also makes requests more complicated, since many forwards are necessary > whenever somebody wants to move away from this implementation. > Since this is hurtful to many of the implementers, I wanted to discuss > whether or not you guys would be interested in the changes we have made. The > functional changes contain: > * Removal of /control out of all the urls > * SEO-friendly URLS > * Configurable product/category and other URLs > * Frontpage mapping from /main to / > It was tested on our end and contains all necessary improvements (Transforms, > Sample Configuration, Servlets & Filters) for it to be applicable. > If interested, I would create a new JIRA ticket for this and after a few > minor internal discussions, we will gladly provide the rest of you with it. > Regards, > Paul > {quote} > There is even a patch, mostly done by Jinghai Shi, that I attach here. Even > if it has been already used in [Syracus|http://syracus.net/] since early this > year, some help would be needed to test it thoroughly in OFBiz. > Then we should discuss if it's the way to go. I believe it is. Who needs a > /control/ or /main by default in ecommerce urls? Would you not prefer > http://localhost:8080/ecommerce/ over > http://localhost:8080/ecommerce/control/main ? -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] (OFBIZ-7061) Autocompletion for Compound Widget
Title: Message Title Jacques Le Roux commented on OFBIZ-7061 Re: Autocompletion for Compound Widget Hi Jacopo, Please if you agree with my comment above close the issue, else explain why it's not sufficient for you, thanks! Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9188) Complete Birt Report Builder documentation
Title: Message Title Jacques Le Roux created an issue OFBiz / OFBIZ-9188 Complete Birt Report Builder documentation Issue Type: Sub-task Affects Versions: Trunk Assignee: Jacques Le Roux Components: specialpurpose/birt Created: 29/Jan/17 09:09 Fix Versions: Upcoming Release Priority: Minor Reporter: Jacques Le Roux We have the documentation in French and partly in English (no users doc) but since then the UI has changed and the files are PDF. We will rather provide README.MD files which will also be used to generate pages in the wiki using Pandoc.
[jira] (OFBIZ-9189) Birt Report Builder: migrate delegator.find calls to EntityQuery
Title: Message Title Jacques Le Roux created an issue OFBiz / OFBIZ-9189 Birt Report Builder: migrate delegator.find calls to EntityQuery Issue Type: Sub-task Affects Versions: Trunk Assignee: Unassigned Components: specialpurpose/birt Created: 29/Jan/17 09:11 Fix Versions: Upcoming Release Priority: Minor Reporter: Jacques Le Roux The code came from a project under ofbiz 13.07 and is still using deprecated delegator.find calls
[jira] (OFBIZ-9166) Create and use an OWASP PolicyFactory for content sanitization in ContentWorker for Birt Report Builder
Title: Message Title Jacques Le Roux reopened an issue I reopen this because we also need a content policy for the usage phase, only the generation phase is covered for now. During the usage phase the security check is bypassed on the "FLEXIBLE_REPORT" contentId OFBiz / OFBIZ-9166 Create and use an OWASP PolicyFactory for content sanitization in ContentWorker for Birt Report Builder Change By: Jacques Le Roux Status: Closed Reopened Resolution: Done Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-6919) Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation.
Title: Message Title Jacques Le Roux commented on OFBIZ-6919 Re: Birt Report Builder: an enhancement of the Birt component. Easier user possibility of report creation. Thanks Nicolas, I created the 2 1st sub-tasks, I'll work on the doc ASAP Actually when I think about it, it's easier to document how to get rid of the technical entity fields when binding data set fields in Birt Report Designer. We will indeed see later if getting rif of them automatically is worth properties, YAGNI state of mind... Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] (OFBIZ-9190) Ugrade FishEye references
Title: Message Title Jacques Le Roux commented on OFBIZ-9190 Re: Ugrade FishEye references Hi Pierre, Could you explain more what you mean, it's not clear to me. Also you maybe know that Atlassian is no longer providing FishEye to the ASF. Do you have more information on this subject? Last one I found is https://s.apache.org/VYOo. And I also read in board agenda that infra wants to use FishEye "at" the ASF, not sure when and if it's already totally decided... Add Comment This message was sent by Atlassian JIRA (v6.3.15#6346-sha1:dbc023d)
[jira] [Created] (OFBIZ-9226) Check that OFBiz runs and compile with Oracle JDK 9
Jacques Le Roux created OFBIZ-9226: -- Summary: Check that OFBiz runs and compile with Oracle JDK 9 Key: OFBIZ-9226 URL: https://issues.apache.org/jira/browse/OFBIZ-9226 Project: OFBiz Issue Type: Test Components: ALL COMPONENTS Affects Versions: Trunk Reporter: Jacques Le Roux Priority: Trivial Fix For: Upcoming Release After reading https://docs.oracle.com/javase/9/migrate/ I believe we should not cross too much problems -- This message was sent by Atlassian JIRA (v6.3.15#6346)