[jira] [Commented] (OFBIZ-7353) Party : Arrange UI Labels in alphabetic order according to best practice.

2018-09-13 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613520#comment-16613520
 ] 

Suraj Khurana commented on OFBIZ-7353:
--

Attached patch which covers all uiLabel file changes under party component. 
Earlier patch was also not applicable as it was not created properly.

> Party : Arrange UI Labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7353
> URL: https://issues.apache.org/jira/browse/OFBIZ-7353
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7353.patch, OFBIZ-7353_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7196) UI labels are not in alphabetic order

2018-09-15 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16615616#comment-16615616
 ] 

Suraj Khurana commented on OFBIZ-7196:
--

Thanks everyone for your inputs and contribution that leads to complete this 
task.

Jacques,
It is a combination of an online tool, a script and some minute manual copy 
paste as of now.
I will try to compile and make a single script so that it can be used further 
as well.

Thanks again !! :)

> UI labels are not in alphabetic order
> -
>
> Key: OFBIZ-7196
> URL: https://issues.apache.org/jira/browse/OFBIZ-7196
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
>
> Actual: UI labels are not in alphabetic order.
> Expected: As per standard, UI labels should be in alphabetic order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10568) RequirementStatus record should be created while creating or updating requirement

2018-09-14 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10568:
-

 Summary: RequirementStatus record should be created while creating 
or updating requirement
 Key: OFBIZ-10568
 URL: https://issues.apache.org/jira/browse/OFBIZ-10568
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Upcoming Branch
Reporter: Suraj Khurana
Assignee: Suraj Khurana


As per current flow, requirement status record is never created, it must be 
created every time a requirement is created or updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614801#comment-16614801
 ] 

Suraj Khurana commented on OFBIZ-7281:
--

Here is the updated patch as earlier one not being applied due to improper path 
and quite old. 

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7281:
-
Attachment: OFBIZ-7281.patch

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7281.


This has been done at rev#1840920.

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7280) Ebaystore : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7280:
-
Attachment: OFBIZ-7280.patch

> Ebaystore : Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7280
> URL: https://issues.apache.org/jira/browse/OFBIZ-7280
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebaystore
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7280.patch, OFBIZ-7280_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7280) Ebaystore : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7280.


This has been done at rev#1840912.

> Ebaystore : Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7280
> URL: https://issues.apache.org/jira/browse/OFBIZ-7280
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebaystore
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7280.patch, OFBIZ-7280_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7340) Framework : Arrange UI Labels in alphabetic order according to best practice.

2018-09-13 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7340.

Resolution: Duplicate

Duplicate issue. Hence closing.

> Framework : Arrange UI Labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7340
> URL: https://issues.apache.org/jira/browse/OFBIZ-7340
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7282) Myportal : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7282:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Myportal :  Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7282
> URL: https://issues.apache.org/jira/browse/OFBIZ-7282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7282_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7284) Oagis : Arrange UI labels in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7284:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Oagis : Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7284
> URL: https://issues.apache.org/jira/browse/OFBIZ-7284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/oagis
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7284_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7280) Ebaystore : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7280:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Ebaystore : Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7280
> URL: https://issues.apache.org/jira/browse/OFBIZ-7280
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ebaystore
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7280_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7353) Party : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7353.


> Party : Arrange UI Labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7353
> URL: https://issues.apache.org/jira/browse/OFBIZ-7353
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7353.patch, OFBIZ-7353_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7370) Scrum : Arrange UI Labels in alphabetic order according to best practice

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7370.


> Scrum : Arrange UI Labels in alphabetic order according to best practice
> 
>
> Key: OFBIZ-7370
> URL: https://issues.apache.org/jira/browse/OFBIZ-7370
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: scrum
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7370.patch, OFBIZ-7370_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7285:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7281:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-7281) Example : Arrange UI Labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614801#comment-16614801
 ] 

Suraj Khurana edited comment on OFBIZ-7281 at 9/14/18 1:03 PM:
---

Here is the updated patch as earlier one was not being applied due to improper 
path and quite old. 


was (Author: suraj.khurana):
Here is the updated patch as earlier one not being applied due to improper path 
and quite old. 

> Example :  Arrange UI Labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7281
> URL: https://issues.apache.org/jira/browse/OFBIZ-7281
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: example
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7281.patch, OFBIZ-7281_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7284) Oagis : Arrange UI labels in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7284.


> Oagis : Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7284
> URL: https://issues.apache.org/jira/browse/OFBIZ-7284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/oagis
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7284_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7284) Oagis : Arrange UI labels in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614820#comment-16614820
 ] 

Suraj Khurana commented on OFBIZ-7284:
--

As per communication on ML [https://markmail.org/message/vkxdyulvgvtf7t4e], 
closing this ticket. 

> Oagis : Arrange UI labels in alphabetic order
> -
>
> Key: OFBIZ-7284
> URL: https://issues.apache.org/jira/browse/OFBIZ-7284
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: specialpurpose/oagis
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7284_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7282) Myportal : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7282:
-
Attachment: OFBIZ-7282.patch

> Myportal :  Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7282
> URL: https://issues.apache.org/jira/browse/OFBIZ-7282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7282.patch, OFBIZ-7282_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7282) Myportal : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7282.


This has been done at rev#1840923.

> Myportal :  Arrange UI labels in alphabetic order according to best practice.
> -
>
> Key: OFBIZ-7282
> URL: https://issues.apache.org/jira/browse/OFBIZ-7282
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: myportal
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7282.patch, OFBIZ-7282_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7285:
-
Attachment: OFBIZ-7285.patch

> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285.patch, OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614844#comment-16614844
 ] 

Suraj Khurana commented on OFBIZ-7285:
--

Hello team,

Attached updated patch file as previous one was not being applied, also made 
some enhancements in the naming convention of UiLabels so that they similar one 
can be easily clubbed. Updated related occurrences as well.

Thanks !!

> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285.patch, OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-7196) UI labels are not in alphabetic order

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-7196:


Assignee: Suraj Khurana  (was: Mridul Pathak)

> UI labels are not in alphabetic order
> -
>
> Key: OFBIZ-7196
> URL: https://issues.apache.org/jira/browse/OFBIZ-7196
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
>
> Actual: UI labels are not in alphabetic order.
> Expected: As per standard, UI labels should be in alphabetic order.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7285) Passport : Arrange UI labels in alphabetic order according to best practice.

2018-09-14 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7285.


> Passport : Arrange UI labels in alphabetic order according to best practice.
> 
>
> Key: OFBIZ-7285
> URL: https://issues.apache.org/jira/browse/OFBIZ-7285
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: passport
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7285.patch, OFBIZ-7285_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9227) Violation of foreign key constraint

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-9227.

Resolution: Not A Problem

> Violation of foreign key constraint
> ---
>
> Key: OFBIZ-9227
> URL: https://issues.apache.org/jira/browse/OFBIZ-9227
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 16.11
> Environment: Win 7
>Reporter: Michael Clifton
>Assignee: Aman Agrawal
>Priority: Minor
>  Labels: database, tasks, workeffort
>
> Trying to add a task to a project phase, I receive the below error.
> 2017-02-21 09:23:54,189 |http-nio-8443-exec-1 |ServiceDispatcher |E| Error in 
> Service [createProjectTask]: Exception thrown while creating the "newEntity" 
> GenericValue: org.apache.ofbiz.entity.GenericEntityException: Error while 
> inserting: 
> [GenericEntity:WorkEffort][createdByUserLogin,admin(java.lang.String)][createdDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][createdStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][createdTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][currentStatusId,PTS_CREATED(java.lang.String)][description,Test(java.lang.String)][estimatedCompletionDate,2017-02-24
>  00:00:00.0(java.sql.Timestamp)][estimatedStartDate,2017-02-21 
> 00:00:00.0(java.sql.Timestamp)][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][lastStatusUpdate,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][priority,1(java.lang.Long)][revisionNumber,1(java.lang.Long)][scopeEnumId,WES_PRIVATE(java.lang.String)][sequenceNum,1(java.lang.Long)][workEffortId,10090(java.lang.String)][workEffortName,Test(java.lang.String)][workEffortParentId,10048(java.lang.String)][workEffortTypeId,Task(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.WORK_EFFORT 
> (WORK_EFFORT_ID, WORK_EFFORT_TYPE_ID, CURRENT_STATUS_ID, LAST_STATUS_UPDATE, 
> WORK_EFFORT_PURPOSE_TYPE_ID, WORK_EFFORT_PARENT_ID, SCOPE_ENUM_ID, PRIORITY, 
> PERCENT_COMPLETE, WORK_EFFORT_NAME, SHOW_AS_ENUM_ID, SEND_NOTIFICATION_EMAIL, 
> DESCRIPTION, LOCATION_DESC, ESTIMATED_START_DATE, ESTIMATED_COMPLETION_DATE, 
> ACTUAL_START_DATE, ACTUAL_COMPLETION_DATE, ESTIMATED_MILLI_SECONDS, 
> ESTIMATED_SETUP_MILLIS, ESTIMATE_CALC_METHOD, ACTUAL_MILLI_SECONDS, 
> ACTUAL_SETUP_MILLIS, TOTAL_MILLI_SECONDS_ALLOWED, TOTAL_MONEY_ALLOWED, 
> MONEY_UOM_ID, SPECIAL_TERMS, TIME_TRANSPARENCY, UNIVERSAL_ID, 
> SOURCE_REFERENCE_ID, FIXED_ASSET_ID, FACILITY_ID, INFO_URL, 
> RECURRENCE_INFO_ID, TEMP_EXPR_ID, RUNTIME_DATA_ID, NOTE_ID, 
> SERVICE_LOADER_NAME, QUANTITY_TO_PRODUCE, QUANTITY_PRODUCED, 
> QUANTITY_REJECTED, RESERV_PERSONS, RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, 
> ACCOMMODATION_MAP_ID, ACCOMMODATION_SPOT_ID, REVISION_NUMBER, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, 
> SEQUENCE_NUM) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'WORK_EFFORT' caused a 
> violation of foreign key constraint 'WK_EFFRT_TYPE' for key (Task). The 
> statement has been rolled back.)) 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-9763) Create separate Permission Services for CRUD services of ShoppingList and ShoppingListItem

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-9763:


Assignee: Chinmay Patidar  (was: Suraj Khurana)

> Create separate Permission Services for CRUD services of ShoppingList and 
> ShoppingListItem
> --
>
> Key: OFBIZ-9763
> URL: https://issues.apache.org/jira/browse/OFBIZ-9763
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce, party
>Affects Versions: Trunk, Release Branch 16.11
>Reporter: Chinmay Patidar
>Assignee: Chinmay Patidar
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: OFBIZ-9763.patch, OFBIZ-9763.patch
>
>
> In CRUD services for ShoppingList and ShoppingListItem entities, the security 
> related checks are present inline in the services. This implementation 
> violates the best practice of keeping security implementation different from 
> the business logic.
> We need to implement security services for such operations and to call them 
> as a permission-service from the CRUD operation services definition



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9227) Violation of foreign key constraint

2018-09-18 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618706#comment-16618706
 ] 

Suraj Khurana commented on OFBIZ-9227:
--

Thanks Aman,

I also checked and hence closing the ticket.

> Violation of foreign key constraint
> ---
>
> Key: OFBIZ-9227
> URL: https://issues.apache.org/jira/browse/OFBIZ-9227
> Project: OFBiz
>  Issue Type: Bug
>  Components: workeffort
>Affects Versions: Release Branch 16.11
> Environment: Win 7
>Reporter: Michael Clifton
>Assignee: Aman Agrawal
>Priority: Minor
>  Labels: database, tasks, workeffort
>
> Trying to add a task to a project phase, I receive the below error.
> 2017-02-21 09:23:54,189 |http-nio-8443-exec-1 |ServiceDispatcher |E| Error in 
> Service [createProjectTask]: Exception thrown while creating the "newEntity" 
> GenericValue: org.apache.ofbiz.entity.GenericEntityException: Error while 
> inserting: 
> [GenericEntity:WorkEffort][createdByUserLogin,admin(java.lang.String)][createdDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][createdStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][createdTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][currentStatusId,PTS_CREATED(java.lang.String)][description,Test(java.lang.String)][estimatedCompletionDate,2017-02-24
>  00:00:00.0(java.sql.Timestamp)][estimatedStartDate,2017-02-21 
> 00:00:00.0(java.sql.Timestamp)][lastModifiedByUserLogin,admin(java.lang.String)][lastModifiedDate,2017-02-21
>  09:23:52.876(java.sql.Timestamp)][lastStatusUpdate,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedStamp,2017-02-21 
> 09:23:52.876(java.sql.Timestamp)][lastUpdatedTxStamp,2017-02-21 
> 09:23:51.627(java.sql.Timestamp)][priority,1(java.lang.Long)][revisionNumber,1(java.lang.Long)][scopeEnumId,WES_PRIVATE(java.lang.String)][sequenceNum,1(java.lang.Long)][workEffortId,10090(java.lang.String)][workEffortName,Test(java.lang.String)][workEffortParentId,10048(java.lang.String)][workEffortTypeId,Task(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO OFBIZ.WORK_EFFORT 
> (WORK_EFFORT_ID, WORK_EFFORT_TYPE_ID, CURRENT_STATUS_ID, LAST_STATUS_UPDATE, 
> WORK_EFFORT_PURPOSE_TYPE_ID, WORK_EFFORT_PARENT_ID, SCOPE_ENUM_ID, PRIORITY, 
> PERCENT_COMPLETE, WORK_EFFORT_NAME, SHOW_AS_ENUM_ID, SEND_NOTIFICATION_EMAIL, 
> DESCRIPTION, LOCATION_DESC, ESTIMATED_START_DATE, ESTIMATED_COMPLETION_DATE, 
> ACTUAL_START_DATE, ACTUAL_COMPLETION_DATE, ESTIMATED_MILLI_SECONDS, 
> ESTIMATED_SETUP_MILLIS, ESTIMATE_CALC_METHOD, ACTUAL_MILLI_SECONDS, 
> ACTUAL_SETUP_MILLIS, TOTAL_MILLI_SECONDS_ALLOWED, TOTAL_MONEY_ALLOWED, 
> MONEY_UOM_ID, SPECIAL_TERMS, TIME_TRANSPARENCY, UNIVERSAL_ID, 
> SOURCE_REFERENCE_ID, FIXED_ASSET_ID, FACILITY_ID, INFO_URL, 
> RECURRENCE_INFO_ID, TEMP_EXPR_ID, RUNTIME_DATA_ID, NOTE_ID, 
> SERVICE_LOADER_NAME, QUANTITY_TO_PRODUCE, QUANTITY_PRODUCED, 
> QUANTITY_REJECTED, RESERV_PERSONS, RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, 
> ACCOMMODATION_MAP_ID, ACCOMMODATION_SPOT_ID, REVISION_NUMBER, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, CREATED_TX_STAMP, 
> SEQUENCE_NUM) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
> ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) (INSERT on table 'WORK_EFFORT' caused a 
> violation of foreign key constraint 'WK_EFFRT_TYPE' for key (Task). The 
> statement has been rolled back.)) 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9989) Testing of New Releaes1

2018-09-18 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618805#comment-16618805
 ] 

Suraj Khurana commented on OFBIZ-9989:
--

Can we close this ticket ?

> Testing of New Releaes1
> ---
>
> Key: OFBIZ-9989
> URL: https://issues.apache.org/jira/browse/OFBIZ-9989
> Project: OFBiz
>  Issue Type: Bug
>Reporter: vivek
>Priority: Minor
>   Original Estimate: 8m
>  Remaining Estimate: 8m
>
> desct



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10570) Requirement is created for wrong facility

2018-09-18 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10570:
-

 Summary: Requirement is created for wrong facility
 Key: OFBIZ-10570
 URL: https://issues.apache.org/jira/browse/OFBIZ-10570
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Upcoming Branch
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Design description:

In service _createAutoRequirementsForOrder_ ProductStore.inventoryFacilityId is 
directly used for creating requirement.
Here, an order can have multiple ship group and each ship group can be 
fulfilled from various facilities, so instead of creating requirement for 
ProductStore.inventoryFacilityId, it should create requirement using 
OrderItemShipGroup.facilityId. If not found, we can have an additional check to 
use orderHeader.facilityId.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10372) Calculate estimated shipment delivery time

2018-09-12 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612092#comment-16612092
 ] 

Suraj Khurana commented on OFBIZ-10372:
---

Hi Nicolas,

I was confused with _isShippableToAddress_ with _shippingApplies_ method. My 
bad !!

I checked and this is already handled during _setShippingContactMechId._
All good (y) Please close this ticket.

Thanks for this effort. This is really an important feature to have.

> Calculate estimated shipment delivery time
> --
>
> Key: OFBIZ-10372
> URL: https://issues.apache.org/jira/browse/OFBIZ-10372
> Project: OFBiz
>  Issue Type: New Feature
>  Components: order
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
>  Labels: order, shipment, time
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10372-plugins.patch, OFBIZ-10372.patch, 
> OFBIZ-10372.patch, OFBIZ-10372.patch
>
>
> Currently when you pass an order in ofbiz you can select the shipment method 
> to delivery finish good and obtains an amount cost but you have nothing to 
> indicate how the delivration will during.
>  We have a good example with ship by plane or boat and for road the time is 
> different between the Portugal to Spain and Portugal to Slovenia.
> With this information, we can planned the estimated delivery date with the 
> estimated date to produce finish good and the time to delivery them
> To fill this gap, we introduce a new entity ShipmentTimeEstimate modelled as 
> ShipmentCostEstimate to define the estimated time for a shipment method, a 
> carrier and two geo location:
> {code:java}
>      package-name="org.apache.ofbiz.shipment.shipment"
>     title="Shipment Time Estimation Entity">
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     
>     ...
> {code}
> We have two asks related to this issue on users 
> [1|https://lists.apache.org/thread.html/de58aa36744804c28eccef6fc7ebc8f0311f65b0dc6b17f1fa5234d4@%3Cuser.ofbiz.apache.org%3E]
>  
> [2|https://lists.apache.org/thread.html/1d79dd9f42fc256e5986271e9e0447bde2980bf0310c4b5f04a35e9f@%3Cuser.ofbiz.apache.org%3E]
>  
>  The first patch made in collaboration with Leila Mekika lays bricks to 
> implement this idea
>  All remark and suggest are welcome to continue it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-12 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-7338:
-
Attachment: OFBIZ-7338.patch

> Manufacturing : Arrange UI Labels in alphabetic according to best practice.
> ---
>
> Key: OFBIZ-7338
> URL: https://issues.apache.org/jira/browse/OFBIZ-7338
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7338.patch, OFBIZ-7338_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-12 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612137#comment-16612137
 ] 

Suraj Khurana commented on OFBIZ-7338:
--

Uploaded proper updated patch as earlier one was not being applied due to wrong 
path mentioned in it. May be created via improper command.

> Manufacturing : Arrange UI Labels in alphabetic according to best practice.
> ---
>
> Key: OFBIZ-7338
> URL: https://issues.apache.org/jira/browse/OFBIZ-7338
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7338.patch, OFBIZ-7338_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-7338) Manufacturing : Arrange UI Labels in alphabetic according to best practice.

2018-09-12 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-7338.


This has been committed to trunk at rev#1840683.

> Manufacturing : Arrange UI Labels in alphabetic according to best practice.
> ---
>
> Key: OFBIZ-7338
> URL: https://issues.apache.org/jira/browse/OFBIZ-7338
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Shivangi Tanwar
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-7338.patch, OFBIZ-7338_trunk.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10571:
-

Assignee: Girish Vasmatkar  (was: Suraj Khurana)

> [FB] Package org.apache.ofbiz.minilang
> --
>
> Key: OFBIZ-10571
> URL: https://issues.apache.org/jira/browse/OFBIZ-10571
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> * [Should be a static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made static.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC*
> *org.apache.ofbiz.minilang.method.callops.CallService***
>  
>  * [Could be refactored into a named static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made into a _static_ inner 
> class. Since anonymous inner classes cannot be marked as static, doing this 
> will require refactoring the inner class so that it is a named inner class.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON*
> *org.apache.ofbiz.minilang.method.conditional.CombinedConditional*
>  
>  * [Boxing/unboxing to parse a 
> primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING]
> A boxed primitive is created from a String, just to extract the unboxed 
> primitive value. It is more efficient to just call the static parseXXX method.
> **
> *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING*
> *org.apache.ofbiz.minilang.method.otherops.Calculate*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10571) [FB] Package org.apache.ofbiz.minilang

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10571:
-

Assignee: Suraj Khurana  (was: Girish Vasmatkar)

> [FB] Package org.apache.ofbiz.minilang
> --
>
> Key: OFBIZ-10571
> URL: https://issues.apache.org/jira/browse/OFBIZ-10571
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Suraj Khurana
>Priority: Minor
>
> * [Should be a static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made static.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC*
> *org.apache.ofbiz.minilang.method.callops.CallService***
>  
>  * [Could be refactored into a named static inner 
> class|http://findbugs.sourceforge.net/bugDescriptions.html#SIC_INNER_SHOULD_BE_STATIC_ANON]
> This class is an inner class, but does not use its embedded reference to the 
> object which created it.  This reference makes the instances of the class 
> larger, and may keep the reference to the creator object alive longer than 
> necessary.  If possible, the class should be made into a _static_ inner 
> class. Since anonymous inner classes cannot be marked as static, doing this 
> will require refactoring the inner class so that it is a named inner class.
> *Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON*
> *org.apache.ofbiz.minilang.method.conditional.CombinedConditional*
>  
>  * [Boxing/unboxing to parse a 
> primitive|http://findbugs.sourceforge.net/bugDescriptions.html#DM_BOXED_PRIMITIVE_FOR_PARSING]
> A boxed primitive is created from a String, just to extract the unboxed 
> primitive value. It is more efficient to just call the static parseXXX method.
> **
> *Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING*
> *org.apache.ofbiz.minilang.method.otherops.Calculate*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10568) RequirementStatus record should be created while creating or updating requirement

2018-09-18 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10568:
--
Attachment: OFBIZ-10568.patch

> RequirementStatus record should be created while creating or updating 
> requirement
> -
>
> Key: OFBIZ-10568
> URL: https://issues.apache.org/jira/browse/OFBIZ-10568
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10568.patch
>
>
> As per current flow, requirement status record is never created, it must be 
> created every time a requirement is created or updated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-8931) Unit test case for service - AddRequirementTask

2019-03-26 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-8931:


Assignee: Suraj Khurana  (was: Pawan Verma)

> Unit test case for service - AddRequirementTask
> ---
>
> Key: OFBIZ-8931
> URL: https://issues.apache.org/jira/browse/OFBIZ-8931
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-8931.patch, OFBIZ-8931.patch
>
>
> Unit test case for service - AddRequirementTask



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-8579) Unit test case for service - updateProductCategory

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-8579.
--
   Resolution: Implemented
Fix Version/s: (was: Trunk)
   Upcoming Branch

This has bee done at ofbiz framework trunk at r#1856608

> Unit test case for service - updateProductCategory
> --
>
> Key: OFBIZ-8579
> URL: https://issues.apache.org/jira/browse/OFBIZ-8579
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8579.patch, OFBIZ-8579.patch
>
>
> Unit test case for service - updateProductCategory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8579) Unit test case for service - updateProductCategory

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8579.


Thanks Akash Jain for reporting and Yogesh Naroliya for providing the updated 
patch.

> Unit test case for service - updateProductCategory
> --
>
> Key: OFBIZ-8579
> URL: https://issues.apache.org/jira/browse/OFBIZ-8579
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8579.patch, OFBIZ-8579.patch
>
>
> Unit test case for service - updateProductCategory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10868) ReturnType entity should be extended with generic type entity fields

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10868.
-

> ReturnType entity should be extended with generic type entity fields
> 
>
> Key: OFBIZ-10868
> URL: https://issues.apache.org/jira/browse/OFBIZ-10868
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10868.patch
>
>
> Currently, as many type entities have parentTypeId and hasTable fields 
> available, we should have it in ReturnType entity as well to maintain 
> consistency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-8423) Unit test case for service - getDataResource

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-8423.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

This has bee done at ofbiz framework trunk at r#1856597

> Unit test case for service - getDataResource
> 
>
> Key: OFBIZ-8423
> URL: https://issues.apache.org/jira/browse/OFBIZ-8423
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Tanmay Muley
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8423.patch, OFBIZ-8423.patch
>
>
> Unit test case for service - getDataResource



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10735) Unable to add survey product to cart in order entry form

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10735:
-

Assignee: Suraj Khurana  (was: Amit Gadaley)

> Unable to add survey product to cart in order entry form
> 
>
> Key: OFBIZ-10735
> URL: https://issues.apache.org/jira/browse/OFBIZ-10735
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10735.patch
>
>
> When a survey product added to cart, system return error "No product 
> information passed, not adding anything to cart.".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10860) Send Email services should be called asynchronously

2019-03-30 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805663#comment-16805663
 ] 

Suraj Khurana commented on OFBIZ-10860:
---

This has bee done at ofbiz framework trunk at r#1856603

> Send Email services should be called asynchronously 
> 
>
> Key: OFBIZ-10860
> URL: https://issues.apache.org/jira/browse/OFBIZ-10860
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10860.patch
>
>
> Currently there are some code references in which with the business logic, 
> email services are triggered synchronously, so in any case if email service 
> fails, whole transaction is rolled back.
> All these occurrences should be replaced with asynchronous calling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10851) Upload new file button is not visible on My Profile page

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10851.
-

Thanks Shikha Jaiswal for reporting and providing the patch.

> Upload new file button is not visible on My Profile page
> 
>
> Key: OFBIZ-10851
> URL: https://issues.apache.org/jira/browse/OFBIZ-10851
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Shikha Jaiswal
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10851.patch
>
>
> Steps to generate:
> # Navigate to 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile|https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile]
> # See the File Manager section
> # Upload New File input is not visible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10851) Upload new file button is not visible on My Profile page

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-10851.
---
   Resolution: Fixed
Fix Version/s: Upcoming Branch

This has bee done at ofbiz framework trunk at r#1856612

> Upload new file button is not visible on My Profile page
> 
>
> Key: OFBIZ-10851
> URL: https://issues.apache.org/jira/browse/OFBIZ-10851
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Shikha Jaiswal
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10851.patch
>
>
> Steps to generate:
> # Navigate to 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile|https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile]
> # See the File Manager section
> # Upload New File input is not visible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10861) Correct typo in 'GiftCertificate' UiLabels

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10861.
-

> Correct typo in 'GiftCertificate' UiLabels
> --
>
> Key: OFBIZ-10861
> URL: https://issues.apache.org/jira/browse/OFBIZ-10861
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10861.patch
>
>
> There are some typos in UiLabels in code for GiftCertificates, need to fix 
> all those occurrences.
> 'GiftCerticate' is used in code instead of 'GiftCertificate'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8931) Unit test case for service - AddRequirementTask

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8931.


Thanks Avnindra Sharma for reporting and Pawan Verma for providing the updated 
patch.

> Unit test case for service - AddRequirementTask
> ---
>
> Key: OFBIZ-8931
> URL: https://issues.apache.org/jira/browse/OFBIZ-8931
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8931.patch, OFBIZ-8931.patch
>
>
> Unit test case for service - AddRequirementTask



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-8931) Unit test case for service - AddRequirementTask

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8931?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-8931.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

This has bee done at ofbiz framework trunk at r#1856596

> Unit test case for service - AddRequirementTask
> ---
>
> Key: OFBIZ-8931
> URL: https://issues.apache.org/jira/browse/OFBIZ-8931
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8931.patch, OFBIZ-8931.patch
>
>
> Unit test case for service - AddRequirementTask



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10860) Send Email services should be called asynchronously

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10860.
-

> Send Email services should be called asynchronously 
> 
>
> Key: OFBIZ-10860
> URL: https://issues.apache.org/jira/browse/OFBIZ-10860
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10860.patch
>
>
> Currently there are some code references in which with the business logic, 
> email services are triggered synchronously, so in any case if email service 
> fails, whole transaction is rolled back.
> All these occurrences should be replaced with asynchronous calling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10860) Send Email services should be called asynchronously

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-10860.
---
   Resolution: Implemented
Fix Version/s: Upcoming Branch

Committed slightly modified patch.

I checked and now only those services which are actually used for sending 
notification are using sendMail service in sync mode.

> Send Email services should be called asynchronously 
> 
>
> Key: OFBIZ-10860
> URL: https://issues.apache.org/jira/browse/OFBIZ-10860
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10860.patch
>
>
> Currently there are some code references in which with the business logic, 
> email services are triggered synchronously, so in any case if email service 
> fails, whole transaction is rolled back.
> All these occurrences should be replaced with asynchronous calling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10860) Send Email services should be called asynchronously

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10860:
--
Affects Version/s: (was: Upcoming Branch)
   Trunk

> Send Email services should be called asynchronously 
> 
>
> Key: OFBIZ-10860
> URL: https://issues.apache.org/jira/browse/OFBIZ-10860
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10860.patch
>
>
> Currently there are some code references in which with the business logic, 
> email services are triggered synchronously, so in any case if email service 
> fails, whole transaction is rolled back.
> All these occurrences should be replaced with asynchronous calling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId

2019-03-29 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805628#comment-16805628
 ] 

Suraj Khurana commented on OFBIZ-10846:
---

Thanks [~jacques.le.roux],

As there are no objections for treating this ticket as improvement, I will 
commit it as an improvement for trunk only.

> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05, 
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field 
> glAccountId are sorted on the primary key, per
> {code:java}
>         
>             
>                  key-field-name="glAccountId" description="${accountCode} - ${accountName} 
> [${glAccountId}]">
>                      operator="equals" env-name="defaultOrganizationPartyId"/>
>                     
>                 
>             
>         
> {code}
> The sort order should however be on the accountCode field of the entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-10867) OrderId should be set in FinAccountTrans while gift card redemption

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-10867.
---
   Resolution: Implemented
Fix Version/s: Upcoming Branch

This has bee done at ofbiz framework trunk at r#1856602

> OrderId should be set in FinAccountTrans while gift card redemption
> ---
>
> Key: OFBIZ-10867
> URL: https://issues.apache.org/jira/browse/OFBIZ-10867
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10867.patch
>
>
> Currently, there is a field in FinAccountTrans entity but it is not taken 
> care while redemption of gift card, payment got successfully settled and no 
> data renders on orderId field.
> I had a cursory look and found that reedemGiftCard service doesn't takes care 
> of this field while create transaction record.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10867) OrderId should be set in FinAccountTrans while gift card redemption

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10867.
-

Committed slightly modified patch.
Added orderId in createGiftCertificate service definition. 

> OrderId should be set in FinAccountTrans while gift card redemption
> ---
>
> Key: OFBIZ-10867
> URL: https://issues.apache.org/jira/browse/OFBIZ-10867
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10867.patch
>
>
> Currently, there is a field in FinAccountTrans entity but it is not taken 
> care while redemption of gift card, payment got successfully settled and no 
> data renders on orderId field.
> I had a cursory look and found that reedemGiftCard service doesn't takes care 
> of this field while create transaction record.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-8579) Unit test case for service - updateProductCategory

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-8579:
-
Affects Version/s: Trunk

> Unit test case for service - updateProductCategory
> --
>
> Key: OFBIZ-8579
> URL: https://issues.apache.org/jira/browse/OFBIZ-8579
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Affects Versions: Trunk
>Reporter: Akash Jain
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-8579.patch, OFBIZ-8579.patch
>
>
> Unit test case for service - updateProductCategory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (OFBIZ-8857) Unit test case for service - CreateReturnAdjustment

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana resolved OFBIZ-8857.
--
   Resolution: Implemented
Fix Version/s: Upcoming Branch

This has bee done at ofbiz framework trunk at r#1856609

> Unit test case for service - CreateReturnAdjustment
> ---
>
> Key: OFBIZ-8857
> URL: https://issues.apache.org/jira/browse/OFBIZ-8857
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8857.patch, OFBIZ-8857.patch, OFBIZ-8857.patch
>
>
> Unit test case for service - CreateReturnAdjustment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8857) Unit test case for service - CreateReturnAdjustment

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8857.


Thanks Avnindra Sharma for reporting, Pawan Verma for discussion and Vivek 
Singh Bisen for providing the updated patch.

> Unit test case for service - CreateReturnAdjustment
> ---
>
> Key: OFBIZ-8857
> URL: https://issues.apache.org/jira/browse/OFBIZ-8857
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8857.patch, OFBIZ-8857.patch, OFBIZ-8857.patch
>
>
> Unit test case for service - CreateReturnAdjustment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10797) CSS Styling for Party Content progress bar is wrong in multiple theme

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10797:
-

Assignee: Suraj Khurana

> CSS Styling for Party Content progress bar is wrong in multiple theme
> -
>
> Key: OFBIZ-10797
> URL: https://issues.apache.org/jira/browse/OFBIZ-10797
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ayushi Rathod
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10797.patch, OFBIZ_ProgressBar_CSS.png
>
>
> Steps to replicate:
>  # Login to demo-trunk: URL - 
> [https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
>  # Find a Party
>  # Go to Party Content section
>  # Upload a file and click on Upload
>  # Notice the progress bar while the file is uploading
> Actual - The styling for the progress bar is not correct
> Please refer the screenshot attached over ticket 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-8423) Unit test case for service - getDataResource

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-8423.


Thanks Tanmay Muley for reporting and Yogesh Naroliya for providing the updated 
patch.

> Unit test case for service - getDataResource
> 
>
> Key: OFBIZ-8423
> URL: https://issues.apache.org/jira/browse/OFBIZ-8423
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Tanmay Muley
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8423.patch, OFBIZ-8423.patch
>
>
> Unit test case for service - getDataResource



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10743) Error message is populating while clicking on product barcode

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10743:
-

Assignee: Suraj Khurana  (was: Pawan Verma)

> Error message is populating while clicking on product barcode
> -
>
> Key: OFBIZ-10743
> URL: https://issues.apache.org/jira/browse/OFBIZ-10743
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Sharma
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10743.patch, Screen Shot 2018-12-22 at 4.01.34 
> PM.png
>
>
> *Step to reproduce*
> Login with valid username and password.
> Navigate to Catalog->Product.
> Search for product (Please enter ‘a’ alphabet)
> Click on barcode
>  
> *Expected result:* Product barcode details should be displayed.
> *Actual result:*  Error message is populating while clicking on product 
> barcode.
>  
> Note:- Issue exist for some product (Forklift - Propane, Forklift - Battery, 
> Company Vehicle, Heating/Cooling Unit, Demo Product for Costing, Demo 
> Material A for Costing and Demo Material B for Costing) 
> Screen-print attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-8932) Unit test case for service - createInvoiceContent

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-8932:


Assignee: Suraj Khurana  (was: vivek singh bisen)

> Unit test case for service -  createInvoiceContent
> --
>
> Key: OFBIZ-8932
> URL: https://issues.apache.org/jira/browse/OFBIZ-8932
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-8932.patch, OFBIZ-8932.patch
>
>
> Unit test case for service -  createInvoiceContent



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10743) Error message is populating while clicking on product barcode

2019-03-30 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10743.
-

Thanks Ashish Sharma for reporting, everyone who participated in discussion and 
Pawan Verma for providing the patch.

> Error message is populating while clicking on product barcode
> -
>
> Key: OFBIZ-10743
> URL: https://issues.apache.org/jira/browse/OFBIZ-10743
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Sharma
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10743.patch, Screen Shot 2018-12-22 at 4.01.34 
> PM.png
>
>
> *Step to reproduce*
> Login with valid username and password.
> Navigate to Catalog->Product.
> Search for product (Please enter ‘a’ alphabet)
> Click on barcode
>  
> *Expected result:* Product barcode details should be displayed.
> *Actual result:*  Error message is populating while clicking on product 
> barcode.
>  
> Note:- Issue exist for some product (Forklift - Propane, Forklift - Battery, 
> Company Vehicle, Heating/Cooling Unit, Demo Product for Costing, Demo 
> Material A for Costing and Demo Material B for Costing) 
> Screen-print attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10868) ReturnType entity should be extended with generic type entity fields

2019-03-29 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10868:
--
Attachment: OFBIZ-10868.patch

> ReturnType entity should be extended with generic type entity fields
> 
>
> Key: OFBIZ-10868
> URL: https://issues.apache.org/jira/browse/OFBIZ-10868
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10868.patch
>
>
> Currently, as many type entities have parentTypeId and hasTable fields 
> available, we should have it in ReturnType entity as well to maintain 
> consistency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10811) PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all amount variables

2019-03-29 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804655#comment-16804655
 ] 

Suraj Khurana commented on OFBIZ-10811:
---

Hi [~jacques.le.roux],

Does this looks good to you now?
I think we can commit this now.

Thanks in advance !!

> PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all 
> amount variables
> 
>
> Key: OFBIZ-10811
> URL: https://issues.apache.org/jira/browse/OFBIZ-10811
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10811.patch
>
>
> Currently, it is direct typecasting into BigDecimal and it could throw 
> exception regarding string to BigDecimal typecasting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10627) Submit button should not display when there is no item present over Quote Prices Screen

2019-03-31 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10627:
-

Assignee: Suraj Khurana

> Submit button should not display when there is no item present over Quote 
> Prices Screen
> ---
>
> Key: OFBIZ-10627
> URL: https://issues.apache.org/jira/browse/OFBIZ-10627
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Ratnesh Upadhyay
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10627.patch, QuotePrices.png
>
>
> Currently system is showing submit button even though there is no rows to 
> process. Ideally it should not display is there is nothing to submit.
> Steps to replicate the issue:
>  * Create Quote from OrderMgr>Quotes screen.
>  * Navigate over Quote Prices Screen.
>  * In Quote Prices screenlet, here system is showing submit button even 
> though there is no quote items to process.
> Please refer attached screenshot for quick details.
> !QuotePrices.png!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10800) Unable to remove items from onePageCheckout screen of ecommerce

2019-04-01 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806419#comment-16806419
 ] 

Suraj Khurana commented on OFBIZ-10800:
---

Hello Dhaval,

Please update Affect Version/s so that this can be addressed.

Thanks in advance !!

> Unable to remove items from onePageCheckout screen of ecommerce
> ---
>
> Key: OFBIZ-10800
> URL: https://issues.apache.org/jira/browse/OFBIZ-10800
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Arpit Mor
>Assignee: Dhaval Wagela
>Priority: Major
> Attachments: 1-ToOnePageCheckout.png, 2-Remove.png, 3-NoAddress2.png, 
> 4-EmptyLine.png, 5-ScreenResolution.png, 6-100%Zoom.png, 7-80%Zoom.png, 
> OFBIZ-10800.patch, OFBIZ.10800.patch
>
>
> Steps to regenerate:
>  # Login to URL: 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/checkLogin/main]
>  # Add items to cart
>  # Click on One Page Checkout at top right of the page (Please refer 
> attachment: 1-ToOnePageCheckout)
> Actual: Remove link is not working on onePageCheckout screen (Please refer 
> attachment: 2-Remove)
>  
> Note: Following UI issues were also found on page
>  # Product image is not displayed on screen and UI is not proper (Please 
> refer attachment: 2-Remove)
>  # If in step 2 of the page, address line 2 is empty then on clicking on 
> continue to step 3, empty line is displayed (Please refer attachments: 
> 3-NoAddress2 and 4-EmptyLine)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10879) updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients from mail subject for general redirected mails

2019-04-01 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806424#comment-16806424
 ] 

Suraj Khurana commented on OFBIZ-10879:
---

Hello [~uHeidfeld],

Please update affect version/s so that this bug can be addressed.

Thanks in advance.

> updateCommEventAfterEmail: Restore original sendTo/sendCc/sendBcc recipients 
> from mail subject for general redirected mails
> ---
>
> Key: OFBIZ-10879
> URL: https://issues.apache.org/jira/browse/OFBIZ-10879
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Ulrich Heidfeld
>Assignee: Ulrich Heidfeld
>Priority: Minor
> Attachments: OFBIZ-10879.patch, OFBIZ-10879.patch
>
>
> "updateCommEventAfterEmail" method in CommunicationEventServices.java could 
> generate  wrong result. If general.properties value 
> "mail.notifications.redirectTo" is used, it is possible that the subject 
> string has more than 255 character. 
> Now:
> {code:java}
> Original subject [To: , Cc: , Bcc: ]
> {code}
> Solution:
> {code:java}
> Original subject [RedirectedTo: recipi...@example.com]
> {code}
> In this way we have fixed this in one of our OFBiz forks. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10896) Use code128 instead of code39 for barcode generation

2019-04-01 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10896:
-

Assignee: Suraj Khurana  (was: Pawan Verma)

> Use code128 instead of code39 for barcode generation
> 
>
> Key: OFBIZ-10896
> URL: https://issues.apache.org/jira/browse/OFBIZ-10896
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10896-plugins.patch, OFBIZ-10896.patch
>
>
> This has been discussed on [mailing 
> thread|https://markmail.org/message/2unwynhirkjfradl] over the dev list.
>  
> While researching on OFBIZ-10743, I have found that currently, we are using 
> code39 to generate barcodes but there are some limitations of code39 as it 
> only able to encrypt letters from A to Z, digits from 0 to 9 and an 
> additional set of special characters – “. $ % + – / *”.
>  
> To enhance the support for more characters in barcode I would suggest using 
> code128 instead of code39. 
>  
> Below are some of the advantages of code128:
>  # code128 supports all the 128 ASCII symbols.
>  # code128 standard is more concise and space-efficient. It also provides its 
> users with higher degrees of data security.  
> I will upload a patch soon for the improvement.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10856) Customer Party getting set as 'organizationPartyId' in one the Account transaction for Customer Invoice

2019-04-01 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10856:
-

Assignee: Suraj Khurana  (was: Chinmay Patidar)

> Customer Party getting set as 'organizationPartyId' in one the Account 
> transaction for Customer Invoice
> ---
>
> Key: OFBIZ-10856
> URL: https://issues.apache.org/jira/browse/OFBIZ-10856
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 14.12, Trunk, 17.12.01, Release Branch 
> 16.11, Release Branch 18.12
>Reporter: Chinmay Patidar
>Assignee: Suraj Khurana
>Priority: Critical
> Attachments: OFBIZ-10856.patch
>
>
> During the research over some of the unposted transactions, it was found that 
> the customer party Id is getting set as organization party Id for one of the 
> transactions belonging to a customer return invoice.
> Steps to regenerate:
> Simply create a return and receive it so as to eventually generate the return 
> invoice. Inspect the return invoice's transaction. One of the transaction 
> would be containing the customer party Id as the organization party Id.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2019-02-27 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779029#comment-16779029
 ] 

Suraj Khurana commented on OFBIZ-10579:
---

Hello Jacques,

Didn't got a chance yet. Will check soon.
Till then, if any further ideas/corrections in patch, please proceed.

Engaged in some other high priority work for now.

Thanks in advance !!

> Date filtered queries with caching should be restricted to cache
> 
>
> Key: OFBIZ-10579
> URL: https://issues.apache.org/jira/browse/OFBIZ-10579
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId

2019-03-11 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789193#comment-16789193
 ] 

Suraj Khurana commented on OFBIZ-10846:
---

Hello,

>>Every bug fix is an improvement.

Could you please explain this, with reason how a simple sorting thing can be a 
bug rather than improvement?
It will help others to put their thoughts on this.

Thanks for reporting the bug (improvement) ;) 

> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05, 
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field 
> glAccountId are sorted on the primary key, per
> {code:java}
>         
>             
>                  key-field-name="glAccountId" description="${accountCode} - ${accountName} 
> [${glAccountId}]">
>                      operator="equals" env-name="defaultOrganizationPartyId"/>
>                     
>                 
>             
>         
> {code}
> The sort order should however be on the accountCode field of the entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10860) Send Email services should be called asynchronously

2019-03-11 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10860:
-

 Summary: Send Email services should be called asynchronously 
 Key: OFBIZ-10860
 URL: https://issues.apache.org/jira/browse/OFBIZ-10860
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL APPLICATIONS
Affects Versions: Upcoming Branch
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Currently there are some code references in which with the business logic, 
email services are triggered synchronously, so in any case if email service 
fails, whole transaction is rolled back.

All these occurrences should be replaced with asynchronous calling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10860) Send Email services should be called asynchronously

2019-03-11 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789495#comment-16789495
 ] 

Suraj Khurana commented on OFBIZ-10860:
---

Attached patch with GiftCertificate services.
I will check for more occurrences, and proceed accordingly.

> Send Email services should be called asynchronously 
> 
>
> Key: OFBIZ-10860
> URL: https://issues.apache.org/jira/browse/OFBIZ-10860
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10860.patch
>
>
> Currently there are some code references in which with the business logic, 
> email services are triggered synchronously, so in any case if email service 
> fails, whole transaction is rolled back.
> All these occurrences should be replaced with asynchronous calling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10860) Send Email services should be called asynchronously

2019-03-11 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10860:
--
Attachment: OFBIZ-10860.patch

> Send Email services should be called asynchronously 
> 
>
> Key: OFBIZ-10860
> URL: https://issues.apache.org/jira/browse/OFBIZ-10860
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10860.patch
>
>
> Currently there are some code references in which with the business logic, 
> email services are triggered synchronously, so in any case if email service 
> fails, whole transaction is rolled back.
> All these occurrences should be replaced with asynchronous calling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10861) Correct typo in 'GiftCertificate' UiLabels

2019-03-11 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10861:
-

 Summary: Correct typo in 'GiftCertificate' UiLabels
 Key: OFBIZ-10861
 URL: https://issues.apache.org/jira/browse/OFBIZ-10861
 Project: OFBiz
  Issue Type: Improvement
  Components: accounting
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana


There are some typos in UiLabels in code for GiftCertificates, need to fix all 
those occurrences.

'GiftCerticate' is used in code instead of 'GiftCertificate'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10861) Correct typo in 'GiftCertificate' UiLabels

2019-03-11 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789507#comment-16789507
 ] 

Suraj Khurana commented on OFBIZ-10861:
---

Attached patch for review.

> Correct typo in 'GiftCertificate' UiLabels
> --
>
> Key: OFBIZ-10861
> URL: https://issues.apache.org/jira/browse/OFBIZ-10861
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10861.patch
>
>
> There are some typos in UiLabels in code for GiftCertificates, need to fix 
> all those occurrences.
> 'GiftCerticate' is used in code instead of 'GiftCertificate'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10861) Correct typo in 'GiftCertificate' UiLabels

2019-03-11 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10861:
--
Attachment: OFBIZ-10861.patch

> Correct typo in 'GiftCertificate' UiLabels
> --
>
> Key: OFBIZ-10861
> URL: https://issues.apache.org/jira/browse/OFBIZ-10861
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10861.patch
>
>
> There are some typos in UiLabels in code for GiftCertificates, need to fix 
> all those occurrences.
> 'GiftCerticate' is used in code instead of 'GiftCertificate'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10579) Date filtered queries with caching should be restricted to cache

2019-03-09 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788599#comment-16788599
 ] 

Suraj Khurana commented on OFBIZ-10579:
---

Hello all,

Actually it was a work around which was introduced earlier to entertain 
filterBayDate when used with useCache, usingCache in makeWhereCondition is not 
making any sense.

Removing 
{code:java}
if (filterByDate && useCache) {
return EntityUtil.filterByCondition(result, this.makeDateCondition());
}
{code}
 This is because, now makeWhereCondition method will take case of filterByDate 
already if used with useCache parameter.

I hope it is making sense now.
Looking forward to hearing from you.


Thanks in advance !!

> Date filtered queries with caching should be restricted to cache
> 
>
> Key: OFBIZ-10579
> URL: https://issues.apache.org/jira/browse/OFBIZ-10579
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10579.patch, OFBIZ-10579.patch
>
>
> As per discussion on Dev ML 
> https://markmail.org/thread/3qnkihmsyhly3lsg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10797) CSS Styling for Party Content progress bar is wrong in multiple theme

2019-03-09 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788653#comment-16788653
 ] 

Suraj Khurana commented on OFBIZ-10797:
---

Hi Ayushi,

Please check and update affect version.

Thanks in advance !!

> CSS Styling for Party Content progress bar is wrong in multiple theme
> -
>
> Key: OFBIZ-10797
> URL: https://issues.apache.org/jira/browse/OFBIZ-10797
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Trunk
>Reporter: Ayushi Rathod
>Priority: Minor
> Attachments: CABC-10797.patch, OFBIZ_ProgressBar_CSS.png
>
>
> Steps to replicate:
>  # Login to demo-trunk: URL - 
> [https://demo-trunk.ofbiz.apache.org/partymgr/control/main]
>  # Find a Party
>  # Go to Party Content section
>  # Upload a file and click on Upload
>  # Notice the progress bar while the file is uploading
> Actual - The styling for the progress bar is not correct
> Please refer the screenshot attached over ticket 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-8857) Unit test case for service - CreateReturnAdjustment

2019-03-09 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-8857:


Assignee: Suraj Khurana  (was: vivek singh bisen)

> Unit test case for service - CreateReturnAdjustment
> ---
>
> Key: OFBIZ-8857
> URL: https://issues.apache.org/jira/browse/OFBIZ-8857
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Avnindra Sharma
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-8857.patch, OFBIZ-8857.patch
>
>
> Unit test case for service - CreateReturnAdjustment



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10851) Upload new file button is not visible on My Profile page

2019-03-09 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788638#comment-16788638
 ] 

Suraj Khurana commented on OFBIZ-10851:
---

Hello Shikha,

Please check and add affect version/s.

Thanks in advance !!

> Upload new file button is not visible on My Profile page
> 
>
> Key: OFBIZ-10851
> URL: https://issues.apache.org/jira/browse/OFBIZ-10851
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Shikha Jaiswal
>Priority: Minor
> Attachments: OFBIZ-10851.patch
>
>
> Steps to generate:
> # Navigate to 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile|https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile]
> # See the File Manager section
> # Upload New File input is not visible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10851) Upload new file button is not visible on My Profile page

2019-03-09 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10851:
-

Assignee: Suraj Khurana

> Upload new file button is not visible on My Profile page
> 
>
> Key: OFBIZ-10851
> URL: https://issues.apache.org/jira/browse/OFBIZ-10851
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Shikha Jaiswal
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-10851.patch
>
>
> Steps to generate:
> # Navigate to 
> [https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile|https://demo-trunk.ofbiz.apache.org/ecommerce/control/viewprofile]
> # See the File Manager section
> # Upload New File input is not visible



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10847) Issue in order history promotion

2019-03-09 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10847:
--
Affects Version/s: Release Branch 17.12
   Release Branch 16.11

> Issue in order history promotion
> 
>
> Key: OFBIZ-10847
> URL: https://issues.apache.org/jira/browse/OFBIZ-10847
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 16.11, Upcoming Branch, Release Branch 
> 17.12, Release Branch 18.12
>Reporter: Lalit Dashora
>Assignee: Lalit Dashora
>Priority: Major
> Attachments: OFBIZ-10847.patch
>
>
> Instance: [#https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> Reference promotion Id: 9019
> Promo Description: Spend more than $1000 in any 12 months on our fabulous 
> Widgets and Gizmos and get a 5% discount.
> PromoName: Test Percent off when Customer Orders over $1000 in 12 months
> Issue: According to the promotion customer should spend $1000 in any 12 
> months to avail 5% discount. The system is providing the discount even if the 
> customer is not logged in.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId

2019-03-09 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788615#comment-16788615
 ] 

Suraj Khurana commented on OFBIZ-10846:
---

Hello,
I will wait for sometime if someone else has any concern and proceed it as an 
improvement in case of no concerns.
Thanks !!

> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field 
> glAccountId are sorted on the primary key, per
> {code:java}
>         
>             
>                  key-field-name="glAccountId" description="${accountCode} - ${accountName} 
> [${glAccountId}]">
>                      operator="equals" env-name="defaultOrganizationPartyId"/>
>                     
>                 
>             
>         
> {code}
> The sort order should however be on the accountCode field of the entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId

2019-03-09 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-10846:
-

Assignee: Suraj Khurana  (was: Pawan Verma)

> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05, 
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field 
> glAccountId are sorted on the primary key, per
> {code:java}
>         
>             
>                  key-field-name="glAccountId" description="${accountCode} - ${accountName} 
> [${glAccountId}]">
>                      operator="equals" env-name="defaultOrganizationPartyId"/>
>                     
>                 
>             
>         
> {code}
> The sort order should however be on the accountCode field of the entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId

2019-03-09 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10846:
--
Affects Version/s: (was: 18.12.01)
   (was: Release Branch 18.12)
   (was: 16.11.06)
   (was: Release Branch 17.12)
   (was: 16.11.05)
   (was: 16.11.04)
   (was: Release Branch 16.11)
   (was: 17.12.01)
   (was: Release Branch 15.12)
   (was: Release Branch 14.12)
   (was: Release Branch 13.07)

> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field 
> glAccountId are sorted on the primary key, per
> {code:java}
>         
>             
>                  key-field-name="glAccountId" description="${accountCode} - ${accountName} 
> [${glAccountId}]">
>                      operator="equals" env-name="defaultOrganizationPartyId"/>
>                     
>                 
>             
>         
> {code}
> The sort order should however be on the accountCode field of the entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10811) PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all amount variables

2019-03-08 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788489#comment-16788489
 ] 

Suraj Khurana commented on OFBIZ-10811:
---

Thanks Jacques for your concerns:
 # Why a try block for captureAmount and not processAmount?
 # Why a try block for the 1st processAmount and not the 2nd?

Shifted same try block to cover ObjectTypeConvert exception as well with 
General exception.

Removing try block for pay to party as in refundPayment service payToPartyId is 
going to be actually order's billToParty and getBillingInformation is doing so 
many unnecessary things which are not used in this service context so simply 
replacing it.

HTH.

Please let us know in case of any further concerns.

 

> PaymentGatewayServices should be using ObjectType.simpleTypeConvert for all 
> amount variables
> 
>
> Key: OFBIZ-10811
> URL: https://issues.apache.org/jira/browse/OFBIZ-10811
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10811.patch
>
>
> Currently, it is direct typecasting into BigDecimal and it could throw 
> exception regarding string to BigDecimal typecasting.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10846) In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId

2019-03-08 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788568#comment-16788568
 ] 

Suraj Khurana commented on OFBIZ-10846:
---

Hello,

I think it should be an improvement rather than bug and we should change 
affected version/s accordingly.
Just my two cents !!

> In AddFinAccountTrans selectable glAccountId values are sorted on glAccountId
> -
>
> Key: OFBIZ-10846
> URL: https://issues.apache.org/jira/browse/OFBIZ-10846
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05, 
> 16.11.06, Release Branch 17.12, Release Branch 18.12, 18.12.01
>Reporter: Pierre Smits
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-10846.patch
>
>
> In the AddFinAccountTrans form in FinAccountForms.xml the values in the field 
> glAccountId are sorted on the primary key, per
> {code:java}
>         
>             
>                  key-field-name="glAccountId" description="${accountCode} - ${accountName} 
> [${glAccountId}]">
>                      operator="equals" env-name="defaultOrganizationPartyId"/>
>                     
>                 
>             
>         
> {code}
> The sort order should however be on the accountCode field of the entity



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10738) Product image is not displayed on showcart page of ecommerce

2019-03-08 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10738.
-

Thanks Arpit Mor for reporting the issue and Praveen Sharma for providing the 
patch.

> Product image is not displayed on showcart page of ecommerce
> 
>
> Key: OFBIZ-10738
> URL: https://issues.apache.org/jira/browse/OFBIZ-10738
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Arpit Mor
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 1-ViewCart.png, 2-showcartPage.png, 
> 3-TinyChromeWidget.png, 4-MicroChromeWidget.png, OFBIZ-10738.patch
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Add items to cart
>  # Click on View Cart at top of the page (Please refer attachment: 1-ViewCart)
> Actual: On showcart page product image is not displayed (Please refer 
> attachment: 2-showcartPage)
> Note: Product image is present and displayed on product link on showcart page 
> (Please refer attachment: 3-TinyChromeWidget and 4-MicroChromeWidget)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10738) Product image is not displayed on showcart page of ecommerce

2019-03-08 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10738:
--
Affects Version/s: Release Branch 18.12
   Release Branch 17.12

> Product image is not displayed on showcart page of ecommerce
> 
>
> Key: OFBIZ-10738
> URL: https://issues.apache.org/jira/browse/OFBIZ-10738
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12
>Reporter: Arpit Mor
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 18.12.01
>
> Attachments: 1-ViewCart.png, 2-showcartPage.png, 
> 3-TinyChromeWidget.png, 4-MicroChromeWidget.png, OFBIZ-10738.patch
>
>
> Steps to regenerate:
>  # Login to URL: [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
>  # Add items to cart
>  # Click on View Cart at top of the page (Please refer attachment: 1-ViewCart)
> Actual: On showcart page product image is not displayed (Please refer 
> attachment: 2-showcartPage)
> Note: Product image is present and displayed on product link on showcart page 
> (Please refer attachment: 3-TinyChromeWidget and 4-MicroChromeWidget)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-8579) Unit test case for service - updateProductCategory

2019-03-08 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana reassigned OFBIZ-8579:


Assignee: Suraj Khurana  (was: Yogesh Naroliya)

> Unit test case for service - updateProductCategory
> --
>
> Key: OFBIZ-8579
> URL: https://issues.apache.org/jira/browse/OFBIZ-8579
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: product
>Reporter: Akash Jain
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-8579.patch, OFBIZ-8579.patch
>
>
> Unit test case for service - updateProductCategory



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-9002) Unit test case for service - createAcctgTrans

2019-03-08 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788495#comment-16788495
 ] 

Suraj Khurana commented on OFBIZ-9002:
--

This has been committed to trunk at rev #1855077.

Thanks Deepak Nigam for reporting and Yogesh Naroliya for providing the updated 
patch.

> Unit test case for service -  createAcctgTrans
> --
>
> Key: OFBIZ-9002
> URL: https://issues.apache.org/jira/browse/OFBIZ-9002
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-9002.patch, OFBIZ-9002.patch
>
>
> Unit test case for service -  createAcctgTrans



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-9002) Unit test case for service - createAcctgTrans

2019-03-08 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-9002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-9002.


> Unit test case for service -  createAcctgTrans
> --
>
> Key: OFBIZ-9002
> URL: https://issues.apache.org/jira/browse/OFBIZ-9002
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Deepak Nigam
>Assignee: Suraj Khurana
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-9002.patch, OFBIZ-9002.patch
>
>
> Unit test case for service -  createAcctgTrans



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void

2019-03-08 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana closed OFBIZ-10727.
-

Thanks Amit Gadaley for reporting the issue and providing the patch, thanks 
Jacopo for discussion and feedback.

> Service failed to mark expired authorized payments of Authorize.net as void
> ---
>
> Key: OFBIZ-10727
> URL: https://issues.apache.org/jira/browse/OFBIZ-10727
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 16.11.06, Upcoming Branch, 18.12.01
>
> Attachments: OFBIZ-10727.patch
>
>
> Service failed to mark expired authorized payments of Authorize.net as void



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10727) Service failed to mark expired authorized payments of Authorize.net as void

2019-03-08 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10727:
--
Fix Version/s: (was: Upcoming Branch)

> Service failed to mark expired authorized payments of Authorize.net as void
> ---
>
> Key: OFBIZ-10727
> URL: https://issues.apache.org/jira/browse/OFBIZ-10727
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, 
> Release Branch 18.12
>Reporter: Amit Gadaley
>Assignee: Suraj Khurana
>Priority: Major
> Fix For: 17.12.01, 16.11.06, 18.12.01
>
> Attachments: OFBIZ-10727.patch
>
>
> Service failed to mark expired authorized payments of Authorize.net as void



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-8143) When Creating an Order from a Quote, the items are added to the purchase order in reverse order

2019-03-08 Thread Suraj Khurana (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-8143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788514#comment-16788514
 ] 

Suraj Khurana commented on OFBIZ-8143:
--

Thanks Forest Rae for your contribution.

After this patch, every item added into PO will get added as first item in 
cart, I think it's OK, not a big deal.

Any other thoughts are welcome, otherwise I will commit in few days.

> When Creating an Order from a Quote, the items are added to the purchase 
> order in reverse order
> ---
>
> Key: OFBIZ-8143
> URL: https://issues.apache.org/jira/browse/OFBIZ-8143
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, 
> Release Branch 15.12
>Reporter: Forrest Rae
>Assignee: Suraj Khurana
>Priority: Minor
> Attachments: OFBIZ-8143.patch
>
>
> When creating an order from a Quote, if a purchase order is required (due to 
> dropship) the items are added to the purchase order in reverse order as they 
> appear on the quote and sales order.  This is because the call to 
> ShoppingCartItem.makePurchaseOrderItem() is made with the first argument 
> always set to 0, thus adding the all items as the first item.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10868) ReturnType entity should be extended with generic type entity fields

2019-03-20 Thread Suraj Khurana (JIRA)
Suraj Khurana created OFBIZ-10868:
-

 Summary: ReturnType entity should be extended with generic type 
entity fields
 Key: OFBIZ-10868
 URL: https://issues.apache.org/jira/browse/OFBIZ-10868
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: Trunk
Reporter: Suraj Khurana
Assignee: Suraj Khurana


Currently, as many type entities have parentTypeId and hasTable fields 
available, we should have it in ReturnType entity as well to maintain 
consistency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10867) OrderId should be set in FinAccountTrans while gift card redemption

2019-03-19 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10867:
--
Attachment: OFBIZ-10867.patch

> OrderId should be set in FinAccountTrans while gift card redemption
> ---
>
> Key: OFBIZ-10867
> URL: https://issues.apache.org/jira/browse/OFBIZ-10867
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10867.patch
>
>
> Currently, there is a field in FinAccountTrans entity but it is not taken 
> care while redemption of gift card, payment got successfully settled and no 
> data renders on orderId field.
> I had a cursory look and found that reedemGiftCard service doesn't takes care 
> of this field while create transaction record.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10867) OrderId should be set in FinAccountTrans while gift card redemption

2019-03-19 Thread Suraj Khurana (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Suraj Khurana updated OFBIZ-10867:
--
Attachment: (was: OFBIZ-10867)

> OrderId should be set in FinAccountTrans while gift card redemption
> ---
>
> Key: OFBIZ-10867
> URL: https://issues.apache.org/jira/browse/OFBIZ-10867
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting
>Affects Versions: Trunk
>Reporter: Suraj Khurana
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10867.patch
>
>
> Currently, there is a field in FinAccountTrans entity but it is not taken 
> care while redemption of gift card, payment got successfully settled and no 
> data renders on orderId field.
> I had a cursory look and found that reedemGiftCard service doesn't takes care 
> of this field while create transaction record.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


<    1   2   3   4   5   6   7   8   9   10   >