[jira] [Commented] (OFBIZ-12496) Webapp Position overrides older entries
[ https://issues.apache.org/jira/browse/OFBIZ-12496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17477266#comment-17477266 ] Benjamin Jugl commented on OFBIZ-12496: --- As of now it resides in WebAppCache.java. I just provided a pull request for a fix. As I said, it would be good if we could have a more elaborate way of handling this. > Webapp Position overrides older entries > --- > > Key: OFBIZ-12496 > URL: https://issues.apache.org/jira/browse/OFBIZ-12496 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > > The Algorithm deciding where the actual position is in the menu is faulty. If > a later plugin is defined with position=1, the Party Manager that is defined > as position=1 by default is overwritten and does not appear in the menu > anymore. > I can provide a quick fix that shifts the newer app to the end of the line, > so no entry is lost. Ultimately we should find a solution that offers more > control. > One possible solution might be, to leave the current implementation but add a > functionality that enables themes to override this and establish their own > order. > What Do you think? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Created] (OFBIZ-12496) Webapp Position overrides older entries
Benjamin Jugl created OFBIZ-12496: - Summary: Webapp Position overrides older entries Key: OFBIZ-12496 URL: https://issues.apache.org/jira/browse/OFBIZ-12496 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Reporter: Benjamin Jugl Assignee: Benjamin Jugl The Algorithm deciding where the actual position is in the menu is faulty. If a later plugin is defined with position=1, the Party Manager that is defined as position=1 by default is overwritten and does not appear in the menu anymore. I can provide a quick fix that shifts the newer app to the end of the line, so no entry is lost. Ultimately we should find a solution that offers more control. One possible solution might be, to leave the current implementation but add a functionality that enables themes to override this and establish their own order. What Do you think? -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17453903#comment-17453903 ] Benjamin Jugl commented on OFBIZ-10093: --- Hi there. We discovered another alternative and had so far very good experiences with it: [Trubowyg|https://alex-d.github.io/Trumbowyg/] It has all the features of summernote and additionally is highly customizable with plugins. I can provide a PR, if you want. > Replace ELRTE plugin with Quill. > > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Benjamin Jugl >Priority: Major > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (OFBIZ-12016) DiskFileItem as request attribute creates problems
[ https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430397#comment-17430397 ] Benjamin Jugl commented on OFBIZ-12016: --- I tested R18 with the patch you provided and it worked great. Trunk was ok already. OFBIZ-10837 resolves the Issue in RequestHandler. All is fine. Thank you very much. > DiskFileItem as request attribute creates problems > -- > > Key: OFBIZ-12016 > URL: https://issues.apache.org/jira/browse/OFBIZ-12016 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-12016.patch > > > Hi, > while working on a custom project based on the 18.12.01 version, I noticed a > problem with the request handling during a request-redirect-noparam if a > DiskFileItem was involved. > So the situation for me is as follows: during the first request a file is > uploaded. I choose a wrong format on purpose, which results in an error > respond for that event. Nevertheless the DiskFileItem is set as request > attribute together with the error message. > The request is finished and based on the controller configurations redirected > to a second request. > While handling the second request the previous request's attributes get > restored (RequestHandler.java line 733ff). This goes down into > SafeObjectInfo.resolveClass() where an Incompatible class exception is > thrown. I compared my custom project with the current development status and > worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in > OFBIZ-10837. > While this fixes the issue with the incompatible class exception it also > makes it impossible to retrieve any attributes from the first request. > Therefore my error message cannot be shown. > Is there a way to fix it or is it otherwise necessary to always set > "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12016) DiskFileItem as request attribute creates problems
[ https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17429909#comment-17429909 ] Benjamin Jugl commented on OFBIZ-12016: --- Works fine, as far as I can see. Error is handled. The Removal of the "fileItem" from the Attributes for callRedirect in EventHandler would get rid of the Error alltogether. Should we redo this also? > DiskFileItem as request attribute creates problems > -- > > Key: OFBIZ-12016 > URL: https://issues.apache.org/jira/browse/OFBIZ-12016 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-12016.patch > > > Hi, > while working on a custom project based on the 18.12.01 version, I noticed a > problem with the request handling during a request-redirect-noparam if a > DiskFileItem was involved. > So the situation for me is as follows: during the first request a file is > uploaded. I choose a wrong format on purpose, which results in an error > respond for that event. Nevertheless the DiskFileItem is set as request > attribute together with the error message. > The request is finished and based on the controller configurations redirected > to a second request. > While handling the second request the previous request's attributes get > restored (RequestHandler.java line 733ff). This goes down into > SafeObjectInfo.resolveClass() where an Incompatible class exception is > thrown. I compared my custom project with the current development status and > worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in > OFBIZ-10837. > While this fixes the issue with the incompatible class exception it also > makes it impossible to retrieve any attributes from the first request. > Therefore my error message cannot be shown. > Is there a way to fix it or is it otherwise necessary to always set > "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12016) DiskFileItem as request attribute creates problems
[ https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17428128#comment-17428128 ] Benjamin Jugl commented on OFBIZ-12016: --- I do not know for sure it it can be reproduced ootb. I think there is just no use-case atm. There could be a file-upload leading into a request-redirect, that I am not aware of, yet. I had another look. There are indeed three commits. One for trunk, one for 17.12 and one for 18.12. The commit for trunk is just fine and you are absolutely correct, that it is the way it should be. The commits for the releases are quite different, though. That caused my confusion. In those the ClassCastException is not handled. We can indeed redo the removal of fileItems as in [https://github.com/apache/ofbiz-framework/commit/4725ae6]. > DiskFileItem as request attribute creates problems > -- > > Key: OFBIZ-12016 > URL: https://issues.apache.org/jira/browse/OFBIZ-12016 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Hi, > while working on a custom project based on the 18.12.01 version, I noticed a > problem with the request handling during a request-redirect-noparam if a > DiskFileItem was involved. > So the situation for me is as follows: during the first request a file is > uploaded. I choose a wrong format on purpose, which results in an error > respond for that event. Nevertheless the DiskFileItem is set as request > attribute together with the error message. > The request is finished and based on the controller configurations redirected > to a second request. > While handling the second request the previous request's attributes get > restored (RequestHandler.java line 733ff). This goes down into > SafeObjectInfo.resolveClass() where an Incompatible class exception is > thrown. I compared my custom project with the current development status and > worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in > OFBIZ-10837. > While this fixes the issue with the incompatible class exception it also > makes it impossible to retrieve any attributes from the first request. > Therefore my error message cannot be shown. > Is there a way to fix it or is it otherwise necessary to always set > "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12016) DiskFileItem as request attribute creates problems
[ https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17427758#comment-17427758 ] Benjamin Jugl commented on OFBIZ-12016: --- Hello all, I just had a look at this. The main issue here is, that there is no Caller that can handle the Exception. The exception is thrown on a request-redirect and thus the error is never handled. I had a look at OFBIZ-12216 and the version history and comments are quite confusing. In UtilObject.java (ll.99) the comment states that "DiskFileItem [...] are not serializable, so So SafeObjectInputStream::resolveClass return ClassNotFoundException" That is not true, SafeObjectInputStream::resolveClass returns ClassCastException. In the actual version of UtilObject.java, ClassCastException ist not handled, but in the first version of OFBIZ-12216s resolution it had been. I cannot find an explanation anywhere, why it had been removed. Although handling this error would at least solve the hard exception on the frontend, this alone is not a sufficial solution. Since Request-Redirects can not handle DiskFileItems, is anything contraindicative for removing them in the redirect (RequestHandler::callRedirect) and logging a warning, that it has been removed? Or are there other solutions that I am not aware of? If not, I would provide a patch that does this. > DiskFileItem as request attribute creates problems > -- > > Key: OFBIZ-12016 > URL: https://issues.apache.org/jira/browse/OFBIZ-12016 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Hi, > while working on a custom project based on the 18.12.01 version, I noticed a > problem with the request handling during a request-redirect-noparam if a > DiskFileItem was involved. > So the situation for me is as follows: during the first request a file is > uploaded. I choose a wrong format on purpose, which results in an error > respond for that event. Nevertheless the DiskFileItem is set as request > attribute together with the error message. > The request is finished and based on the controller configurations redirected > to a second request. > While handling the second request the previous request's attributes get > restored (RequestHandler.java line 733ff). This goes down into > SafeObjectInfo.resolveClass() where an Incompatible class exception is > thrown. I compared my custom project with the current development status and > worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in > OFBIZ-10837. > While this fixes the issue with the incompatible class exception it also > makes it impossible to retrieve any attributes from the first request. > Therefore my error message cannot be shown. > Is there a way to fix it or is it otherwise necessary to always set > "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10093) Replace ELRTE plugin with Quill.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-10093: - Assignee: Benjamin Jugl (was: Aditya Sharma) > Replace ELRTE plugin with Quill. > > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Benjamin Jugl >Priority: Major > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17386228#comment-17386228 ] Benjamin Jugl commented on OFBIZ-10093: --- [~adityasharma] What do you think? Given that Quill does not have a code and Summernote provides integration with CodeMirror and thus the ability for .ftl syntax, I think we should switch to Summernote. Do you want to implement it or should I take care of it? > Replace ELRTE plugin with Quill. > > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12223) CSV-Exports generate empty trailing columns
Benjamin Jugl created OFBIZ-12223: - Summary: CSV-Exports generate empty trailing columns Key: OFBIZ-12223 URL: https://issues.apache.org/jira/browse/OFBIZ-12223 Project: OFBiz Issue Type: Bug Components: ALL APPLICATIONS Affects Versions: Trunk, Upcoming Branch Reporter: Benjamin Jugl As encountered in OFBIZ-12175 the CSV-Exports that utilize the element in Screens renders a trailing "," at the end of each line. These exports are also used to generate files that should potentially be imported again. The imports on the other hand can (and should) not deal with this format-error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12175) Party Export/Import not congruent
[ https://issues.apache.org/jira/browse/OFBIZ-12175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316369#comment-17316369 ] Benjamin Jugl commented on OFBIZ-12175: --- We have two issues here: # The export ads an extra "," at the end of each line, as the import can not cope with this. Should be fixed on the output side. # The import creates ContactMechs using the Service "createPartyContactMech". This Service has been changed to expect a contactMechTypeId and the call on this end has not been modified. The first problem lies somewhere deep in the Context of the Form-Renderer. In fact every CSV-Export that utilizes the grid-Element of Screens renders to an extra column. Usually this is not so much of an issue, as it is not very important, if reports have an extra column or not. But when using this as an export-import function, it should be working ootb without issues or users having to delete trailing commas. We should create an extra issue for this. For the second one I will a create a CR. As it is quite easily fixed. > Party Export/Import not congruent > - > > Key: OFBIZ-12175 > URL: https://issues.apache.org/jira/browse/OFBIZ-12175 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > > Clickpath: > Party -> Import/Export -> Export Party (or Parties) -> Browse (Import Form) > ->Select Exported File -> Upload > Expected Behaviour: > Should either import the file, giving new partyIds, leading to duplicate > Entries or (if partyIds are imported as well) should give an error, because > of duplicate keys or should simply overwrite. > Behaviour: Error Message reads: > ??The Following Errors Occurred:?? > ??Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: > Service invocation error (A header name is missing in [partyId, > preferredCurrencyUomId, groupName, firstName, middleName, lastName, > companyPartyId, companyName, roleTypeId, contactMechPurposeTypeId, > contactMechTypeId, emailAddress, telCountryCode, telAreaCode, > telContactNumber, address1, address2, city, stateProvinceGeoId, postalCode, > countryGeoId, ])?? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12178) ModelInduceFromDb does not show entity relations.
[ https://issues.apache.org/jira/browse/OFBIZ-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287117#comment-17287117 ] Benjamin Jugl commented on OFBIZ-12178: --- Problem is, that the ModelEntity initialized through the "DB Names Constructor" does not cover references in its current state at all. While working on an implementation I realized, that the API is not very congruent in this regards. I would expect that I could initialize ModelRelations the same way ModelFields are initialized in this context: The create() Method takes a ModelEntity, DatabaseUtil.ColumnCheckInfo (respectively a DatabaseUtil.ReferenceCheckInfo) and a ModelFieldTypeReader (that could be left out for references) and creates ModelField (ModelRelation) objects that are added to the ModelEntity. But that is not the case at the moment. On one hand not all fields that would be necessary are covered in the DatabaseUtil.ReferenceCheckInfo Objects (e.g. "type" is missing), on the other the object is missing public getters to make the values available in the first place. > ModelInduceFromDb does not show entity relations. > - > > Key: OFBIZ-12178 > URL: https://issues.apache.org/jira/browse/OFBIZ-12178 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > > As encountered in OFBIZ-6510, the ModelInduceFromDb does currently not > include entity relations and foreign key constraints. Since they are an > important part of the database model, we should fix that. > I could track down the problem to an incomplete invocation of the ModelEntity > through the constructor used in the DatabaseUtil.induceModelFromDb() Methods. > This constructor does not initialize the Relations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12178) ModelInduceFromDb does not show realtions.
[ https://issues.apache.org/jira/browse/OFBIZ-12178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-12178: - Assignee: Benjamin Jugl > ModelInduceFromDb does not show realtions. > -- > > Key: OFBIZ-12178 > URL: https://issues.apache.org/jira/browse/OFBIZ-12178 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > > As encountered in OFBIZ-6510, the ModelInduceFromDb does currently not > include entity relations and foreign key constraints. Since they are an > important part of the database model, we should fix that. > I could track down the problem to an incomplete invocation of the ModelEntity > through the constructor used in the DatabaseUtil.induceModelFromDb() Methods. > This constructor does not initialize the Relations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285092#comment-17285092 ] Benjamin Jugl commented on OFBIZ-6510: -- Created OFBIZ-12178 to tackle this. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12178) ModelInduceFromDb does not show realtions.
Benjamin Jugl created OFBIZ-12178: - Summary: ModelInduceFromDb does not show realtions. Key: OFBIZ-12178 URL: https://issues.apache.org/jira/browse/OFBIZ-12178 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk, Release Branch 18.12 Reporter: Benjamin Jugl As encountered in OFBIZ-6510, the ModelInduceFromDb does currently not include entity relations and foreign key constraints. Since they are an important part of the database model, we should fix that. I could track down the problem to an incomplete invocation of the ModelEntity through the constructor used in the DatabaseUtil.induceModelFromDb() Methods. This constructor does not initialize the Relations. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283789#comment-17283789 ] Benjamin Jugl commented on OFBIZ-6510: -- You are right, the relations should be contained. But I think this never worked. The .jsp did iterate over the relations and ModelEntity.toXmlElement() does this as well. Problem is, that the ModelEntities are generated using a constructor that does not initialize the Relations. This was used in the old version as well as in this one. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Release Branch 18.12, Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: 18.12.01, Upcoming Branch > > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12175) Party Export/Import not congruent
[ https://issues.apache.org/jira/browse/OFBIZ-12175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-12175: - Assignee: Benjamin Jugl > Party Export/Import not congruent > - > > Key: OFBIZ-12175 > URL: https://issues.apache.org/jira/browse/OFBIZ-12175 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > > Clickpath: > Party -> Import/Export -> Export Party (or Parties) -> Browse (Import Form) > ->Select Exported File -> Upload > Expected Behaviour: > Should either import the file, giving new partyIds, leading to duplicate > Entries or (if partyIds are imported as well) should give an error, because > of duplicate keys or should simply overwrite. > Behaviour: Error Message reads: > ??The Following Errors Occurred:?? > ??Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: > Service invocation error (A header name is missing in [partyId, > preferredCurrencyUomId, groupName, firstName, middleName, lastName, > companyPartyId, companyName, roleTypeId, contactMechPurposeTypeId, > contactMechTypeId, emailAddress, telCountryCode, telAreaCode, > telContactNumber, address1, address2, city, stateProvinceGeoId, postalCode, > countryGeoId, ])?? > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12175) Party Export/Import not congruent
Benjamin Jugl created OFBIZ-12175: - Summary: Party Export/Import not congruent Key: OFBIZ-12175 URL: https://issues.apache.org/jira/browse/OFBIZ-12175 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Benjamin Jugl Clickpath: Party -> Import/Export -> Export Party (or Parties) -> Browse (Import Form) ->Select Exported File -> Upload Expected Behaviour: Should either import the file, giving new partyIds, leading to duplicate Entries or (if partyIds are imported as well) should give an error, because of duplicate keys or should simply overwrite. Behaviour: Error Message reads: ??The Following Errors Occurred:?? ??Error calling event: org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error (A header name is missing in [partyId, preferredCurrencyUomId, groupName, firstName, middleName, lastName, companyPartyId, companyName, roleTypeId, contactMechPurposeTypeId, contactMechTypeId, emailAddress, telCountryCode, telAreaCode, telContactNumber, address1, address2, city, stateProvinceGeoId, postalCode, countryGeoId, ])?? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-5487) Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types
[ https://issues.apache.org/jira/browse/OFBIZ-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-5487: Assignee: (was: Benjamin Jugl) > Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types > --- > > Key: OFBIZ-5487 > URL: https://issues.apache.org/jira/browse/OFBIZ-5487 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Priority: Major > > When using the ModelInduceFromDb.jsp to import MSSQL data many of the fields > were assigned to types like "invalid-float:0:50". This is because the > induceFieldType() of ModelUtil.java does not handle "FLOAT The function > should be changed to allow FLOAT type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-5487) Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types
[ https://issues.apache.org/jira/browse/OFBIZ-5487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-5487: Assignee: Benjamin Jugl > Improve induceFieldType() of ModelUtil.java to handle MSSQL FLOAT types > --- > > Key: OFBIZ-5487 > URL: https://issues.apache.org/jira/browse/OFBIZ-5487 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Benjamin Jugl >Priority: Major > > When using the ModelInduceFromDb.jsp to import MSSQL data many of the fields > were assigned to types like "invalid-float:0:50". This is because the > induceFieldType() of ModelUtil.java does not handle "FLOAT The function > should be changed to allow FLOAT type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-7473) Induce Model XML from Database throws exception
[ https://issues.apache.org/jira/browse/OFBIZ-7473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278016#comment-17278016 ] Benjamin Jugl commented on OFBIZ-7473: -- With OFBIZ-6510, Induce Model XML from Database is accessible again. Can be closed. > Induce Model XML from Database throws exception > --- > > Key: OFBIZ-7473 > URL: https://issues.apache.org/jira/browse/OFBIZ-7473 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: 17.12.01, Trunk >Reporter: Gopal Yadav >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-7473.patch > > > Go to Webtools -> Import/Export -> Induce Model XML from Database > (https://localhost:8443/webtools/control/view/ModelInduceFromDb) > An exception is thrown: javax.servlet.ServletException: File > [/entity/ModelInduceFromDb.jsp] not found. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6509) webtools/control/view/ModelInduceFromDb should support package-name attribute setting
[ https://issues.apache.org/jira/browse/OFBIZ-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278009#comment-17278009 ] Benjamin Jugl commented on OFBIZ-6509: -- Has been incorporated in OFBIZ-6510. Can be closed. > webtools/control/view/ModelInduceFromDb should support package-name > attribute setting > -- > > Key: OFBIZ-6509 > URL: https://issues.apache.org/jira/browse/OFBIZ-6509 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > > OFBIZ-6508 added support for generating from ModelInduceFromDb > by adding groupName field for setting group-name attribute. > The field should be reused to allow setting the package-name > attribute also. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6508) webtools/control/view/ModelInduceFromDb should support
[ https://issues.apache.org/jira/browse/OFBIZ-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277997#comment-17277997 ] Benjamin Jugl commented on OFBIZ-6508: -- Has been incorporated in OFBIZ-6510. Can be closed. > webtools/control/view/ModelInduceFromDb should support > - > > Key: OFBIZ-6508 > URL: https://issues.apache.org/jira/browse/OFBIZ-6508 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6508.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12164) NPE in Party/My Communications
[ https://issues.apache.org/jira/browse/OFBIZ-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-12164: -- Affects Version/s: Release Branch 17.12 Release Branch 18.12 > NPE in Party/My Communications > -- > > Key: OFBIZ-12164 > URL: https://issues.apache.org/jira/browse/OFBIZ-12164 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Benjamin Jugl >Assignee: Michael Brohl >Priority: Major > > If you create a new communication in the "Party" menu, "Communications" tab, > which concerns the current user, it is shown in the "My communications" tab > in the "ListPartyCommEvents" section. However, it throws an NPE with the > following message: > ??java.lang.RuntimeException: Error rendering included form named > [ListPartyCommEvents] at location > [component://party/widget/partymgr/CommunicationEventForms.xml]: > java.lang.NullPointerExceptionjava.lang.NullPointerException?? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12164) NPE in Party/My Communications
[ https://issues.apache.org/jira/browse/OFBIZ-12164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-12164: - Assignee: Benjamin Jugl > NPE in Party/My Communications > -- > > Key: OFBIZ-12164 > URL: https://issues.apache.org/jira/browse/OFBIZ-12164 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Major > > If you create a new communication in the "Party" menu, "Communications" tab, > which concerns the current user, it is shown in the "My communications" tab > in the "ListPartyCommEvents" section. However, it throws an NPE with the > following message: > ??java.lang.RuntimeException: Error rendering included form named > [ListPartyCommEvents] at location > [component://party/widget/partymgr/CommunicationEventForms.xml]: > java.lang.NullPointerExceptionjava.lang.NullPointerException?? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12164) NPE in Party/My Communications
Benjamin Jugl created OFBIZ-12164: - Summary: NPE in Party/My Communications Key: OFBIZ-12164 URL: https://issues.apache.org/jira/browse/OFBIZ-12164 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Benjamin Jugl If you create a new communication in the "Party" menu, "Communications" tab, which concerns the current user, it is shown in the "My communications" tab in the "ListPartyCommEvents" section. However, it throws an NPE with the following message: ??java.lang.RuntimeException: Error rendering included form named [ListPartyCommEvents] at location [component://party/widget/partymgr/CommunicationEventForms.xml]: java.lang.NullPointerExceptionjava.lang.NullPointerException?? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270258#comment-17270258 ] Benjamin Jugl commented on OFBIZ-10461: --- Bumping that up. Thank you [~jleroux] , for asking. [~deepak] do you still want to provide the css? As I am very much for having clean .ftl - files, I would really like to create a PR with the changes I made in the patches. Even if you can remove whitespaces later via css. > Texts of checkboxes sometimes have whitespaces > -- > > Key: OFBIZ-10461 > URL: https://issues.apache.org/jira/browse/OFBIZ-10461 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch > > > On some pages, when there are checkboxes, the text after the checkbox has a > rendered whitespace in front of it. > A good example for this can be seen right here: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist] > The first checkboxes do not have this rendered whitespace, the lines after > that do have it. > This issue can be fixed simply through removing the whitespaces inside the > .ftl files. > > After that there an added styling should create a new gap between the > checkbox and the following text, but this time all the gaps would have the > same distance. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11956) Re-thinking the Log-Level
Benjamin Jugl created OFBIZ-11956:
-
Summary: Re-thinking the Log-Level
Key: OFBIZ-11956
URL: https://issues.apache.org/jira/browse/OFBIZ-11956
Project: OFBiz
Issue Type: Improvement
Components: content, framework
Affects Versions: Trunk
Reporter: Benjamin Jugl
The following log messages have all a log level of "info" or "warning". In our
experience, however, this is a very large source of noise during operation. The
messages are in my opinion only of interpretation, if it is necessary to
examine the signal flow in case of error. I know that there is a difference of
opinion on this subject, so I have listed the places that we have put on
Verbose in our projects. I am looking forward to hearing your thoughts on this
topic.
# {{ScreenFactory |I| Got %s screens in 0.004s from: %s}}
# {{ConfigXMLReader |I| controller loaded: 0.001s, 115 requests, 59 views in
file: %s}}
# {{ModelService |I| Set default value [%s] for parameter [%s]}}
# {{ServiceEcaCondition |I| From Field (%s) is not found in context for %s,
defaulting to null.
}}
# {{ServiceEcaCondition |W| doRealCompare returned null, returning false}}
# {{DataResourcePermissionServices.xml#genericDataResourcePermission line 69]
}}
# {{DataResourcePermissionServices.xml#genericDataResourcePermission line 73]}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11469) Convert DataServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-11469: - Assignee: Benjamin Jugl > Convert DataServices.xml minilang to groovy > --- > > Key: OFBIZ-11469 > URL: https://issues.apache.org/jira/browse/OFBIZ-11469 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Major > > With the purpose to deprecate mini-lang OFBIZ-9350, convert DataServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11469) Convert DataServices.xml minilang to groovy
Benjamin Jugl created OFBIZ-11469: - Summary: Convert DataServices.xml minilang to groovy Key: OFBIZ-11469 URL: https://issues.apache.org/jira/browse/OFBIZ-11469 Project: OFBiz Issue Type: Sub-task Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS Affects Versions: Trunk Reporter: Benjamin Jugl With the purpose to deprecate mini-lang OFBIZ-9350, convert DataServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11455) Blog-Content shows in profiles filemanager section
Benjamin Jugl created OFBIZ-11455: - Summary: Blog-Content shows in profiles filemanager section Key: OFBIZ-11455 URL: https://issues.apache.org/jira/browse/OFBIZ-11455 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk Reporter: Benjamin Jugl Do as follows: # Open Url: [https://demo-trunk.ofbiz.apache.org/ecomseo/] (or stable) # Click on a Blog to navigate there. # Create New Blog Post # Fill the fields with text and image and submit as "publish". # Go to profile ERROR: Filemanager shows all blog-content-items as Files. EXPECTED: Only uploaded files should be displayed. Text and publishPoints should be excluded. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11454) Content for Blogs is not properly saved
Benjamin Jugl created OFBIZ-11454: - Summary: Content for Blogs is not properly saved Key: OFBIZ-11454 URL: https://issues.apache.org/jira/browse/OFBIZ-11454 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk Reporter: Benjamin Jugl Do as follows: # Open Url: [https://demo-trunk.ofbiz.apache.org/ecomseo/] (or stable) # Click on a Blog to navigate there. # Create New Blog Post # Fill the fields with text and image and submit as "publish". ERROR: The content will not be available and replaced by placeholders EXPECTED: Blogarticle should be displayed showing all text and images -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11327) Unable to upload content at view profile screen
[ https://issues.apache.org/jira/browse/OFBIZ-11327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-11327: - Assignee: Benjamin Jugl (was: Michael Brohl) > Unable to upload content at view profile screen > --- > > Key: OFBIZ-11327 > URL: https://issues.apache.org/jira/browse/OFBIZ-11327 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Mohammed Rehan Khan >Assignee: Benjamin Jugl >Priority: Minor > Attachments: FileManager-Ecommerce-New.png, FileManager-Ecommerce.png > > > Steps to regenerate - > # Open URL > [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main|http://example.com] > # Click on the profile tab > # Go to file manager section > # Upload any type of content > Error - No uploaded content found in the context > Expected - User should be able to upload content > Please refer attachment -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10679) Regarding national laws when applying taxes on shipping costs
[
https://issues.apache.org/jira/browse/OFBIZ-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055989#comment-17055989
]
Benjamin Jugl commented on OFBIZ-10679:
---
My ticket at that time included a way to deal with the taxes on shipping costs.
The shipping costs for an item are based on the taxes that apply to the item.
So if there is an item with 9% tax, the same percentage is applied to the
shipping costs. This has already been implemented. But for the case that
several items are shipped with mixed tax rates, I have only introduced the
apparently most common method for the time being, namely calculating the
shipping tax weighted by price and tax rate of each item. But the calculation
of the tax on shipping costs is not uniform in all countries, states and even
companies. Some companies simplify the procedure and simply apply the highest
rate of the items shipped to the shipping costs. Some countries apply a fixed
rate to the shipping costs. Others do not tax them at all. It should be
configurable, depending on the ProductStore and tax authority, how shipping tax
is handled.
> Regarding national laws when applying taxes on shipping costs
> -
>
> Key: OFBIZ-10679
> URL: https://issues.apache.org/jira/browse/OFBIZ-10679
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Priority: Minor
>
> As mentioned in [#OFBIZ-4160] there are different ways to approach
> tax-calculation on shipping-costs.
> While some countries (like the Netherlands) have a fixed price for this,
> others calculate the delivery just like the delivered good (or a weighted
> version, if multiple taxrates are applied to the shipping).
> As I stated:
> {quote}[..]it is advisable to introduce a new ProductCategory "TAX_SHIPPING".
> This could be administered through TAX_AUTHORITY_RATE_PRODUCT for individual
> tax authorities. Then there could be a condition before my newly implemented
> logic, to use this tax rate, if it is found, and if it is not, my logic is
> executed.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10044) Refactor and cleanup DhlServices.java
[ https://issues.apache.org/jira/browse/OFBIZ-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054884#comment-17054884 ] Benjamin Jugl commented on OFBIZ-10044: --- Can you please elaborate? Do you mean that we should create a plugin for any third party transportation service provider? Or just for DHL? Can we do one plugin for all, should we seperate? What led you to this demand? I see that it's nicer to run Thirdparty Services in the plugins. Are there any other reasons I don't see? This would be a much bigger project than just refactoring this one class and should probably get its own issue, don't you think? > Refactor and cleanup DhlServices.java > - > > Key: OFBIZ-10044 > URL: https://issues.apache.org/jira/browse/OFBIZ-10044 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > > The DhlServices class contains many TODO comments and needs > refactoring/cleanup. > Hard coded defaults should be moved out to properties or database entries. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10679) Regarding national laws when applying taxes on shipping costs
[
https://issues.apache.org/jira/browse/OFBIZ-10679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054742#comment-17054742
]
Benjamin Jugl commented on OFBIZ-10679:
---
Hello [~pierresmits]. We had a discussion on this subject in [#OFBIZ-4160]. I
think that you did not see any benefit in this implementation. What do others
think about it? The opinion of someone with experience in the US market would
be nice.
> Regarding national laws when applying taxes on shipping costs
> -
>
> Key: OFBIZ-10679
> URL: https://issues.apache.org/jira/browse/OFBIZ-10679
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Priority: Minor
>
> As mentioned in [#OFBIZ-4160] there are different ways to approach
> tax-calculation on shipping-costs.
> While some countries (like the Netherlands) have a fixed price for this,
> others calculate the delivery just like the delivered good (or a weighted
> version, if multiple taxrates are applied to the shipping).
> As I stated:
> {quote}[..]it is advisable to introduce a new ProductCategory "TAX_SHIPPING".
> This could be administered through TAX_AUTHORITY_RATE_PRODUCT for individual
> tax authorities. Then there could be a condition before my newly implemented
> logic, to use this tax rate, if it is found, and if it is not, my logic is
> executed.
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11434) Forum Articles do not respond to pagination
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Jugl updated OFBIZ-11434:
--
Attachment: OFBIZ-11434.patch
> Forum Articles do not respond to pagination
> ---
>
> Key: OFBIZ-11434
> URL: https://issues.apache.org/jira/browse/OFBIZ-11434
> Project: OFBiz
> Issue Type: Bug
> Components: ecommerce
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Benjamin Jugl
>Priority: Minor
> Attachments: OFBIZ-11434.patch
>
>
> Neither the view-size nor the view-index have any effect on the shown
> articles in the forum.
> To reproduce:
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message" 21 times
> # Try using the pagination
> Should be: The view should be limited to 20 items on the first page, if the
> view-size is 20. The second page should only display the 21st entry.
> Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050050#comment-17050050
]
Benjamin Jugl commented on OFBIZ-10688:
---
Since I can not reproduce the Error, neither with the minilang-service nor with
the groovy that is still in progress (thanks [~priya.sharma.9362]), once the
display-errors from VIEW_INDEX are fixed (see OFBIZ-11429). If anyone can,
please give an update on how to reproduce it. Else I would recommend closing
this issue.
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Bildschirmfoto 2020-02-28 um 12.45.18.png,
> OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11434) Forum Articles do not respond to pagination
Benjamin Jugl created OFBIZ-11434:
-
Summary: Forum Articles do not respond to pagination
Key: OFBIZ-11434
URL: https://issues.apache.org/jira/browse/OFBIZ-11434
Project: OFBiz
Issue Type: Bug
Components: ecommerce
Affects Versions: Trunk
Reporter: Benjamin Jugl
Assignee: Benjamin Jugl
Neither the view-size nor the view-index have any effect on the shown articles
in the forum.
To reproduce:
# Log into the Frontend (ecommerce) as admin
# go to Browse Forums
# click any link ("Ask the Experts" was used for testing)
# Create "New Message" 21 times
# Try using the pagination
Should be: The view should be limited to 20 items on the first page, if the
view-size is 20. The second page should only display the 21st entry.
Is: The list always shows all 21 entries.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11429) Setting VIEW-INDEX to 0, when not initialised in ForumScreens.xml#Showforum "New Message" Link
[ https://issues.apache.org/jira/browse/OFBIZ-11429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11429: -- Attachment: OFBIZ-11429.patch > Setting VIEW-INDEX to 0, when not initialised in ForumScreens.xml#Showforum > "New Message" Link > -- > > Key: OFBIZ-11429 > URL: https://issues.apache.org/jira/browse/OFBIZ-11429 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-11429.patch > > > Leaving the value at null will result in creating a hidden input in > AddForumMessage Form with the value "null" (String). This leads to a nice > error-window after successfully creating a new message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11429) Setting VIEW-INDEX to 0, when not initialised in ForumScreens.xml#Showforum "New Message" Link
Benjamin Jugl created OFBIZ-11429: - Summary: Setting VIEW-INDEX to 0, when not initialised in ForumScreens.xml#Showforum "New Message" Link Key: OFBIZ-11429 URL: https://issues.apache.org/jira/browse/OFBIZ-11429 Project: OFBiz Issue Type: Bug Components: ecommerce Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl Leaving the value at null will result in creating a hidden input in AddForumMessage Form with the value "null" (String). This leads to a nice error-window after successfully creating a new message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047548#comment-17047548
]
Benjamin Jugl commented on OFBIZ-10688:
---
I thought that was not possible in this case, due to parameter-declarations not
being able to take a default, but I found a solution. Patch is available that
sets VIEW_INDEX to 0. New Issue for that?
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Bildschirmfoto 2020-02-28 um 12.45.18.png,
> OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047517#comment-17047517
]
Benjamin Jugl commented on OFBIZ-10688:
---
The "New Message" link on the "Showforum"-View tries to get the VIEW_INDEX
parameter. When called initially, this is not set and thus the value is null.
The AddForumThread Screen uses this value in the AddForumMessage Form where it
is created as a hidden input with the value "null" (String). By successfully
creating a new message, the "Showforum"-view should be shown again, but this
fails, because now the String "null" can not be cast to Integer (As we read in
the error-message).
Additionally, the Pagination is flawed. The list does not interact with the
pagination in any way, it seems: !Bildschirmfoto 2020-02-28 um 12.45.18.png!
I think a first fix for the error message might be to remove the VIEW_INDEX
from the "New message" link. Upon creation of a message I would expect to land
either on the first site of the forum or at the latest post (last page), where
my message is displayed, no matter where I came from.
Should we create a new issue for this and/or an additional one for fixing
pagination?
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Bildschirmfoto 2020-02-28 um 12.45.18.png,
> OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Jugl updated OFBIZ-10688:
--
Attachment: Bildschirmfoto 2020-02-28 um 12.45.18.png
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: Bildschirmfoto 2020-02-28 um 12.45.18.png,
> OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047449#comment-17047449 ] Benjamin Jugl edited comment on OFBIZ-11383 at 2/28/20 10:38 AM: - I thought it was only called Elvis in a context like a=b?:c, specific to groovy, not when you use it like a = b?c:d... The correct technical term is ternary, btw. My fault. was (Author: bjugl): I thought it was only called Evvis in a context like a=b?:c, specific to groovy, not when you use it like a = b?c:d... The correct technical term is ternary, btw. My fault. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047449#comment-17047449 ] Benjamin Jugl commented on OFBIZ-11383: --- I thought it was only called Evvis in a context like a=b?:c, specific to groovy, not when you use it like a = b?c:d... The correct technical term is ternary, btw. My fault. > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: OFBIZ-11383.patch > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: (was: OFBIZ-11383.patch) > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: OFBIZ-11383.patch > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: (was: OFBIZ-11383.patch) > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[
https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046659#comment-17046659
]
Benjamin Jugl commented on OFBIZ-11383:
---
Hey Priya,
I did review your patch and intorduced some changes. Here is a nearly complete
list of the changes I did:
* Variable "module" should be defined in the class, so it scope includes all
other methods that will be added in the future.
* Variables should be declared with strong typing. This makes it more readable
and better to maintain (if you do not use any types, the variables are written
into the context object of the groovies "this". That is quite cumbersome to
debug.
* "createMain.dataResourceId" was declared twice, "createMain.assocTypeId" was
not declared. "createMain.partyId" was not declared.
* "createImage.contentNam" Typo, misses an "e"
* "createImage._uploadedFile_contentType" missing entirely.
* GroovyBaseScript.groovy provides a "run service" implementation. Not sure
how the overall preferences are, but its sheer existence implies that it should
be used...
* Inserted some {} for inline if-clauses. They can be omitted but reduce
readability
* Inserted trinary Operator (? : ) where possible
* Renamed variable "map" into "result"
> Convert createArticleContent service from mini-lang to groovy DSL
> -
>
> Key: OFBIZ-11383
> URL: https://issues.apache.org/jira/browse/OFBIZ-11383
> Project: OFBiz
> Issue Type: Sub-task
> Components: content
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Priya Sharma
>Priority: Minor
> Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch
>
>
> Convert createArticleContent service code from mini-lang to groovy DSL.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11383: -- Attachment: OFBIZ-11383.patch > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch, OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046530#comment-17046530
]
Benjamin Jugl commented on OFBIZ-10688:
---
I can not reproduce the bug anymore. The data is stored and instead of the bug
mentioned above, another bug is thrown:
{noformat}
Could not convert field value for the field: [viewIndex] to the [Integer] type
for the value [null]: org.apache.ofbiz.base.util.GeneralException:
java.text.ParseException: Unparseable number: "null" (java.text.ParseException:
Unparseable number: "null"){noformat}
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10688) textareas do not save data, when visual-editor is used
[
https://issues.apache.org/jira/browse/OFBIZ-10688?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045680#comment-17045680
]
Benjamin Jugl commented on OFBIZ-10688:
---
The service has been converted to goovy in OFBIZ-11383. I will review the
patch. We should however separate the conversion and the fix. So I will base my
development on the conversion once it is done.
> textareas do not save data, when visual-editor is used
> --
>
> Key: OFBIZ-10688
> URL: https://issues.apache.org/jira/browse/OFBIZ-10688
> Project: OFBiz
> Issue Type: Bug
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Assignee: Michael Brohl
>Priority: Major
> Attachments: OFBIZ-10688-HtmlFormMacroLibrary.patch
>
>
> Can be reproduced by
> # Log into the Frontend (ecommerce) as admin
> # go to Browse Forums
> # click any link ("Ask the Experts" was used for testing)
> # Create "New Message"
> # click "add"
> Following Error occurs:
> "ERROR: Could not complete the Post a new Content article Entry
> [file:/Users/bjugl/Projekte/community/ofbiz-framework-trunk/applications/content/minilang/content/ContentServices.xml#createArticleContent]
> process [problem invoking the [createTextContent] service with the map named
> [...]"
> Data is not stored.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11383) Convert createArticleContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045674#comment-17045674 ] Benjamin Jugl commented on OFBIZ-11383: --- Hi there. This service was subject to Issue OFBIZ-10688. Thank you for the groovy conversion. I will check it as you demanded and additionally check if the Bug of former mentioned issue is still occuring. You might already have fixed it, if not, I would gladly use your conversion as a starting point. Greetings! > Convert createArticleContent service from mini-lang to groovy DSL > - > > Key: OFBIZ-11383 > URL: https://issues.apache.org/jira/browse/OFBIZ-11383 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11383.patch > > > Convert createArticleContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: OFBIZ-6510.patch > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: (was: OFBIZ-6510_ModelInduceFromDb.patch) > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: (was: OFBIZ-6510_ModelInduceFromDb_002.patch) > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: (was: OFBIZ-6510_ModelInduceFromDb_003.patch) > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043626#comment-17043626 ] Benjamin Jugl commented on OFBIZ-6510: -- Provided new Patch, Converted Form Elements to .ftl, Event now uses ModelEntity.toXmlElement. Added some methods to ModelEntity and UtilXml that could be of general use in other context to make the Event itself a little more lean. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch, OFBIZ-6510_ModelInduceFromDb_002.patch, > OFBIZ-6510_ModelInduceFromDb_003.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: OFBIZ-6510_ModelInduceFromDb_003.patch > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch, OFBIZ-6510_ModelInduceFromDb_002.patch, > OFBIZ-6510_ModelInduceFromDb_003.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11385) Possible NPE in DatabaseUtil.getColumnInfo(...)
[ https://issues.apache.org/jira/browse/OFBIZ-11385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11385: -- Attachment: OFBIZ-11385_Possible_NPE_in_DatabaseUtil_001.patch > Possible NPE in DatabaseUtil.getColumnInfo(...) > --- > > Key: OFBIZ-11385 > URL: https://issues.apache.org/jira/browse/OFBIZ-11385 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Major > Attachments: OFBIZ-11385_Possible_NPE_in_DatabaseUtil_001.patch > > > Right at the start DatabaseUtil.getColumnInfo() does an if comparison to > 0 with the unchecked parameter tableNames. > The way this method and especially the parameter is used in > DatabaseUtil.induceModelFromDb(Collection messages) is not secure to > not provide null-values for this parameter. > I suggest using a UtilValidate.isEmpty(...) instead of the unsave comparison. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
[ https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043609#comment-17043609 ] Benjamin Jugl commented on OFBIZ-11312: --- I provided a patch. It removes the error-prone future-logic. Please let me know, if I oversimplified things. > DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to > connection-locks > -- > > Key: OFBIZ-11312 > URL: https://issues.apache.org/jira/browse/OFBIZ-11312 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > > > The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using > a List> object. This does not work properly > as it runs into connection-locks. When debugging the error does not occur. I > assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
[ https://issues.apache.org/jira/browse/OFBIZ-11312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-11312: -- Attachment: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to > connection-locks > -- > > Key: OFBIZ-11312 > URL: https://issues.apache.org/jira/browse/OFBIZ-11312 > Project: OFBiz > Issue Type: Bug > Components: framework/webtools >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-11312_getColumnInfo_connection_locks_001.patch > > > The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using > a List> object. This does not work properly > as it runs into connection-locks. When debugging the error does not occur. I > assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11385) Possible NPE in DatabaseUtil.getColumnInfo(...)
Benjamin Jugl created OFBIZ-11385: - Summary: Possible NPE in DatabaseUtil.getColumnInfo(...) Key: OFBIZ-11385 URL: https://issues.apache.org/jira/browse/OFBIZ-11385 Project: OFBiz Issue Type: Bug Components: framework/webtools Affects Versions: Trunk Reporter: Benjamin Jugl Right at the start DatabaseUtil.getColumnInfo() does an if comparison to 0 with the unchecked parameter tableNames. The way this method and especially the parameter is used in DatabaseUtil.induceModelFromDb(Collection messages) is not secure to not provide null-values for this parameter. I suggest using a UtilValidate.isEmpty(...) instead of the unsave comparison. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17008620#comment-17008620 ] Benjamin Jugl commented on OFBIZ-6510: -- [~nmalin]: Mostly because I was unaware of its existence. I just converted the groovy-event into Java and gave it a (imho) clearer structure. Since that development has been collecting dust for some time now, I should have double-checked if something suitable already existed. Thank you for pointing me there, I will check if it is suitable for this purpose and maybe provide another patch. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch, OFBIZ-6510_ModelInduceFromDb_002.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000824#comment-17000824 ] Benjamin Jugl commented on OFBIZ-6510: -- I provided a new patch. This one does handle security better and implements a java event instead of the groovy functionality of previous patches. The Issue of the missing Private Keys stems from the DatabaseUtil class, as already said. When the method of DatabaseUtil provides the correct data, the Output is correctly displayed. Therefore, I created a new Issue to tackle the problems within DatabaseUtil. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch, OFBIZ-6510_ModelInduceFromDb_002.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11312) DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks
Benjamin Jugl created OFBIZ-11312: - Summary: DatabaseUtil.getColumnInfo(...) does not retrieve primary keys due to connection-locks Key: OFBIZ-11312 URL: https://issues.apache.org/jira/browse/OFBIZ-11312 Project: OFBiz Issue Type: Bug Components: framework/webtools Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl The method DatabaseUtil.getColumnInfo(...) uses an elaborate algorithm using a List> object. This does not work properly as it runs into connection-locks. When debugging the error does not occur. I assume that the slower pace of debugging prevents the error. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: OFBIZ-6510_ModelInduceFromDb_002.patch > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch, OFBIZ-6510_ModelInduceFromDb_002.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: (was: OFBIZ-6510_ModelInduceFromDb_002.patch) > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: OFBIZ-6510_ModelInduceFromDb_002.patch > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch, OFBIZ-6510_ModelInduceFromDb_002.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775380#comment-16775380 ] Benjamin Jugl commented on OFBIZ-10707: --- Patch provided that utilizes the suggested functionality. > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch, > OFBIZ-10707_ListLocals.ftl_02.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10707: -- Attachment: OFBIZ-10707_ListLocals.ftl_02.patch > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch, > OFBIZ-10707_ListLocals.ftl_02.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-6510: - Attachment: OFBIZ-6510_ModelInduceFromDb.patch > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch, > OFBIZ-6510_ModelInduceFromDb.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-6510) Replace webtools/control/view/ModelInduceFromDb with widgets
[ https://issues.apache.org/jira/browse/OFBIZ-6510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733148#comment-16733148 ] Benjamin Jugl commented on OFBIZ-6510: -- My patch consolidates the previous patches. The primary keys are still not integrated. I will investigate upon that, when I have the time. I could not verify, if or how the functionality did work in the old version, because it is flawed in trunk/demo and only gives an java.lang.StackOverflowError, when called. The patch fixes that. Entry Point for further Investigation: DatabaseUtil.java#getColumnInfo(...). Apparently the Connection used can not cope with the parallel call of createPrimaryKeyFetcher(..) (java.sql.SQLException: Connection can not be used while enlisted in another transaction) Have to figure out, where exactly the error occurs and what means I can use to fix it. > Replace webtools/control/view/ModelInduceFromDb with widgets > > > Key: OFBIZ-6510 > URL: https://issues.apache.org/jira/browse/OFBIZ-6510 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Christian Carlow >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-6510.patch, OFBIZ-6510.patch, OFBIZ-6510.patch > > > The page is written in JSP probably from very long ago when FTL and widgets > didn't even exist yet. It should be implemented in widgets now that they are > available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721368#comment-16721368 ] Benjamin Jugl commented on OFBIZ-10710: --- Corrected. Thank you. > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10710: -- Attachment: OFBIZ-10710_ObjectType.java.patch > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10710: -- Attachment: (was: OFBIZ-10710_ObjectType.java.patch) > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721257#comment-16721257 ] Benjamin Jugl commented on OFBIZ-10710: --- Thank you, @Martin Becker, for this patch. > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
[ https://issues.apache.org/jira/browse/OFBIZ-10710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10710: -- Attachment: OFBIZ-10710_ObjectType.java.patch > Avoid logging warning message from ObjectType.java while using > sourceType.toString() for getting String targetType > -- > > Key: OFBIZ-10710 > URL: https://issues.apache.org/jira/browse/OFBIZ-10710 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10710_ObjectType.java.patch > > > Avoid logging this warning (for example on freemarker.ext.beans.StringModel > source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10710) Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType
Benjamin Jugl created OFBIZ-10710: - Summary: Avoid logging warning message from ObjectType.java while using sourceType.toString() for getting String targetType Key: OFBIZ-10710 URL: https://issues.apache.org/jira/browse/OFBIZ-10710 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl Fix For: Trunk Avoid logging this warning (for example on freemarker.ext.beans.StringModel source type at screen rendering), change to info adviseable. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721255#comment-16721255 ] Benjamin Jugl commented on OFBIZ-10461: --- My patch already removes all nbsp and linebreaks. I did not touch the css, though. > Texts of checkboxes sometimes have whitespaces > -- > > Key: OFBIZ-10461 > URL: https://issues.apache.org/jira/browse/OFBIZ-10461 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch > > > On some pages, when there are checkboxes, the text after the checkbox has a > rendered whitespace in front of it. > A good example for this can be seen right here: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist] > The first checkboxes do not have this rendered whitespace, the lines after > that do have it. > This issue can be fixed simply through removing the whitespaces inside the > .ftl files. > > After that there an added styling should create a new gap between the > checkbox and the following text, but this time all the gaps would have the > same distance. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10709) LoginWorker.autoLoginCheck performance improvement
[ https://issues.apache.org/jira/browse/OFBIZ-10709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10709: -- Attachment: OFBIZ-10709_LoginWorker.java.patch > LoginWorker.autoLoginCheck performance improvement > -- > > Key: OFBIZ-10709 > URL: https://issues.apache.org/jira/browse/OFBIZ-10709 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10709_LoginWorker.java.patch > > > LoginWorker.autoLoginCheck does not check if the attribute "autoUserLogin" is > not already filled and executes even if it is not needed. A check on the > attribute beforehand can improve performance significantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10709) LoginWorker.autoLoginCheck performance improvement
Benjamin Jugl created OFBIZ-10709: - Summary: LoginWorker.autoLoginCheck performance improvement Key: OFBIZ-10709 URL: https://issues.apache.org/jira/browse/OFBIZ-10709 Project: OFBiz Issue Type: Improvement Components: framework Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl Fix For: Trunk LoginWorker.autoLoginCheck does not check if the attribute "autoUserLogin" is not already filled and executes even if it is not needed. A check on the attribute beforehand can improve performance significantly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
Benjamin Jugl created OFBIZ-10707: - Summary: ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 Key: OFBIZ-10707 URL: https://issues.apache.org/jira/browse/OFBIZ-10707 Project: OFBiz Issue Type: Bug Components: themes Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl Fix For: Trunk Because langAttr can be empty on some occations, the check of available languages can result in a SringINdexOutOfBounds Exception -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720377#comment-16720377 ] Benjamin Jugl commented on OFBIZ-10707: --- Thank you, [~mbecker], for providing the fix. > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10707) ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181
[ https://issues.apache.org/jira/browse/OFBIZ-10707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10707: -- Attachment: OFBIZ-10707_ListLocales.ftl.patch > ListLocales throws StringIndexOutOfBounds Exception under Java 1.8.0_181 > > > Key: OFBIZ-10707 > URL: https://issues.apache.org/jira/browse/OFBIZ-10707 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10707_ListLocales.ftl.patch > > > Because langAttr can be empty on some occations, the check of available > languages can result in a SringINdexOutOfBounds Exception > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10706) EmailServices.sendMail causes a NPE, when sendFrom is missing
Benjamin Jugl created OFBIZ-10706: - Summary: EmailServices.sendMail causes a NPE, when sendFrom is missing Key: OFBIZ-10706 URL: https://issues.apache.org/jira/browse/OFBIZ-10706 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: Trunk Reporter: Benjamin Jugl Assignee: Benjamin Jugl Fix For: Trunk Because the Error occurs further down in Java, there are two options # Either catch the NPE in sendMail and try to send a mail without a sendFrom field (I doubt that this will work) # Or expand the sendMailOnePartInterface to have sendFrom mandatory just like sendTo -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10706) EmailServices.sendMail causes a NPE, when sendFrom is missing
[ https://issues.apache.org/jira/browse/OFBIZ-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720334#comment-16720334 ] Benjamin Jugl commented on OFBIZ-10706: --- Decided to provide option 2 in the patch. > EmailServices.sendMail causes a NPE, when sendFrom is missing > - > > Key: OFBIZ-10706 > URL: https://issues.apache.org/jira/browse/OFBIZ-10706 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10706_services_Email.xml.patch > > > Because the Error occurs further down in Java, there are two options > # Either catch the NPE in sendMail and try to send a mail without a > send>From field (I doubt that this will work) > # Or expand the sendMailOnePartInterface to have sendFrom mandatory just > like sendTo > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10706) EmailServices.sendMail causes a NPE, when sendFrom is missing
[ https://issues.apache.org/jira/browse/OFBIZ-10706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10706: -- Attachment: OFBIZ-10706_services_Email.xml.patch > EmailServices.sendMail causes a NPE, when sendFrom is missing > - > > Key: OFBIZ-10706 > URL: https://issues.apache.org/jira/browse/OFBIZ-10706 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Benjamin Jugl >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10706_services_Email.xml.patch > > > Because the Error occurs further down in Java, there are two options > # Either catch the NPE in sendMail and try to send a mail without a > send>From field (I doubt that this will work) > # Or expand the sendMailOnePartInterface to have sendFrom mandatory just > like sendTo > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10461: -- Attachment: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch > Texts of checkboxes sometimes have whitespaces > -- > > Key: OFBIZ-10461 > URL: https://issues.apache.org/jira/browse/OFBIZ-10461 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Benjamin Jugl >Priority: Minor > Attachments: OFBIZ-10461_RemoveBlanksBetweenCheckboxesAndLabels.patch > > > On some pages, when there are checkboxes, the text after the checkbox has a > rendered whitespace in front of it. > A good example for this can be seen right here: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist] > The first checkboxes do not have this rendered whitespace, the lines after > that do have it. > This issue can be fixed simply through removing the whitespaces inside the > .ftl files. > > After that there an added styling should create a new gap between the > checkbox and the following text, but this time all the gaps would have the > same distance. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[
https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720206#comment-16720206
]
Benjamin Jugl edited comment on OFBIZ-10461 at 12/13/18 2:10 PM:
-
There are in fact a few hard coded 'nbsp' in ftl files acting as spacers
between checkbox and text. The case that acts as an example is not one of them.
It is a result of the format that prevents code-lines from being (much) longer
than 120 characters. Thus the text will be formated this way:
{code:java}
checked="checked"/>
${descr_PURCHASE_ORDER}
{code}
The linebreak is interpreted as a blank.
Solution: format all occurences like
{code:java}
checked="checked"/>${descr_PURCHASE_ORDER}
{code}
I will add a comment to the code, that describes the problem, so it will not
accidentally get autoformated and commited again.
was (Author: bjugl):
There are in fact a few hard coded in ftl files acting as spacers
between checkbox and text. The case that acts as an example is not one of them.
It is a result of the format that prevents code-lines from being (much) longer
than 120 characters. Thus the text will be formated this way:
{code:java}
checked="checked"/>
${descr_PURCHASE_ORDER}
{code}
The linebreak is interpreted as a blank.
Solution: format all occurences like
{code:java}
checked="checked"/>${descr_PURCHASE_ORDER}
{code}
I will add a comment to the code, that describes the problem, so it will not
accidentally get autoformated and commited again.
> Texts of checkboxes sometimes have whitespaces
> --
>
> Key: OFBIZ-10461
> URL: https://issues.apache.org/jira/browse/OFBIZ-10461
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Benjamin Jugl
>Priority: Minor
>
> On some pages, when there are checkboxes, the text after the checkbox has a
> rendered whitespace in front of it.
> A good example for this can be seen right here:
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
> The first checkboxes do not have this rendered whitespace, the lines after
> that do have it.
> This issue can be fixed simply through removing the whitespaces inside the
> .ftl files.
>
> After that there an added styling should create a new gap between the
> checkbox and the following text, but this time all the gaps would have the
> same distance.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[
https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720206#comment-16720206
]
Benjamin Jugl commented on OFBIZ-10461:
---
There are in fact a few hard coded in ftl files acting as spacers
between checkbox and text. The case that acts as an example is not one of them.
It is a result of the format that prevents code-lines from being (much) longer
than 120 characters. Thus the text will be formated this way:
{code:java}
checked="checked"/>
${descr_PURCHASE_ORDER}
{code}
The linebreak is interpreted as a blank.
Solution: format all occurences like
{code:java}
checked="checked"/>${descr_PURCHASE_ORDER}
{code}
I will add a comment to the code, that describes the problem, so it will not
accidentally get autoformated and commited again.
> Texts of checkboxes sometimes have whitespaces
> --
>
> Key: OFBIZ-10461
> URL: https://issues.apache.org/jira/browse/OFBIZ-10461
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Dennis Balkir
>Assignee: Benjamin Jugl
>Priority: Minor
>
> On some pages, when there are checkboxes, the text after the checkbox has a
> rendered whitespace in front of it.
> A good example for this can be seen right here:
> [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist]
> The first checkboxes do not have this rendered whitespace, the lines after
> that do have it.
> This issue can be fixed simply through removing the whitespaces inside the
> .ftl files.
>
> After that there an added styling should create a new gap between the
> checkbox and the following text, but this time all the gaps would have the
> same distance.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10461) Texts of checkboxes sometimes have whitespaces
[ https://issues.apache.org/jira/browse/OFBIZ-10461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl reassigned OFBIZ-10461: - Assignee: Benjamin Jugl > Texts of checkboxes sometimes have whitespaces > -- > > Key: OFBIZ-10461 > URL: https://issues.apache.org/jira/browse/OFBIZ-10461 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Benjamin Jugl >Priority: Minor > > On some pages, when there are checkboxes, the text after the checkbox has a > rendered whitespace in front of it. > A good example for this can be seen right here: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderlist] > The first checkboxes do not have this rendered whitespace, the lines after > that do have it. > This issue can be fixed simply through removing the whitespaces inside the > .ftl files. > > After that there an added styling should create a new gap between the > checkbox and the following text, but this time all the gaps would have the > same distance. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10093) Replace ELRTE plugin with Quill.
[ https://issues.apache.org/jira/browse/OFBIZ-10093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719908#comment-16719908 ] Benjamin Jugl commented on OFBIZ-10093: --- I see the point in the arguments against a html view as well, but it is simply not our use-case. I have created a confluence-discussion, so that we can evaluate, which features a visual editor should support for ofbiz and what editor would suite these needs. > Replace ELRTE plugin with Quill. > > > Key: OFBIZ-10093 > URL: https://issues.apache.org/jira/browse/OFBIZ-10093 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Major > > As there is no support for elrte since elrte-1.3 > [https://github.com/Studio-42/elRTE] it is to be replaced with some other > good editor & we found Quill Js editor as quite suitable: > * 139 releases > * Good community support of 101 contributors > * Licence - BSD 3-Clause "New" or "Revised" License > Links for reference: > [https://quilljs.com/] > [https://github.com/quilljs/quill] > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718953#comment-16718953
]
Benjamin Jugl edited comment on OFBIZ-10298 at 12/12/18 1:12 PM:
-
The patches also provide some improvements to the code, like removing
unnecessary autoboxing.
was (Author: bjugl):
The patches also provides some improvements to the code, like removing
unnecessary autoboxing.
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Priority: Minor
> Attachments:
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718953#comment-16718953
]
Benjamin Jugl commented on OFBIZ-10298:
---
The patches also provides some improvements to the code, like removing
unnecessary autoboxing.
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Priority: Minor
> Attachments:
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10298) Fluent API Bug in getFieldList()
[
https://issues.apache.org/jira/browse/OFBIZ-10298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Jugl updated OFBIZ-10298:
--
Description:
In EntityQuery the method getFieldList() uses the class variable {{distinct}}
to decide if the list of genericValues should be stored in a set to eliminate
duplicate values. This variable is set by the function distinct() and normally
it should only be used for the sql statement. But here the flag gets mistreated
since, if the list of values was ordered because of orderBy(), the order of
values gets lost by putting them into a set. To summarize, the following
statement:
{{orderBy("...").dinstinct().getFieldLlist("...");}}
does not produce an ordered list.
Replacing the HashSet by a LinkedHashSet fixes this issue.
was:
In EntityQuery the method getFieldList() uses the class variable {{distinct}}
to decide if the list of genericValues should be stored in a set to eliminate
duplicate values. This variable is set by the function distinct() and normally
it should only be used for the sql statement. But here the flag gets mistreated
since, if the list of values was ordered because of orderBy(), the order of
values gets lost by putting them into a set. To summarize, the following
statement:
{{orderBy("...").dinstinct().getFieldLlist("...");}}
does not produce an ordered list.
This can be fixed, for example, by extending the signature of getFieldList by a
boolean parameter which decides if the list needs distinct values.
> Fluent API Bug in getFieldList()
>
>
> Key: OFBIZ-10298
> URL: https://issues.apache.org/jira/browse/OFBIZ-10298
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Trunk
>Reporter: Benjamin Jugl
>Priority: Minor
> Attachments:
> OFBIZ-10298_org.apache.ofbiz.entity.util_distinct_to_primitive.patch,
> OFBIZ-10298_org.apache.ofbiz.entity.util_getFieldList_Fix.patch
>
>
> In EntityQuery the method getFieldList() uses the class variable {{distinct}}
> to decide if the list of genericValues should be stored in a set to eliminate
> duplicate values. This variable is set by the function distinct() and
> normally it should only be used for the sql statement. But here the flag gets
> mistreated since, if the list of values was ordered because of orderBy(), the
> order of values gets lost by putting them into a set. To summarize, the
> following statement:
> {{orderBy("...").dinstinct().getFieldLlist("...");}}
> does not produce an ordered list.
> Replacing the HashSet by a LinkedHashSet fixes this issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-10300) Convert Minilang to Groovy Guide into asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16718901#comment-16718901 ] Benjamin Jugl commented on OFBIZ-10300: --- I know that the code-blocks are a bit off. This is dependant on the compiler. The "code" is correct. I tried to remedy this by introducing a theme via an .yml file, but did not get much better results (to a point where improvements were highly subjective) If an individual theme holds interest for the community, I can provide a seperate patch that could act as a basis for discussion. > Convert Minilang to Groovy Guide into asciidoc > --- > > Key: OFBIZ-10300 > URL: https://issues.apache.org/jira/browse/OFBIZ-10300 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Fix For: 17.12.01 > > Attachments: > OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc02.patch > > > Convert [~Dennis Balkir]s [Minilang to Groovy > Guide|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+From+Mini+Language+to+Groovy] > into AsciiDoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10300) Convert Minilang to Groovy Guide into asciidoc
[ https://issues.apache.org/jira/browse/OFBIZ-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Jugl updated OFBIZ-10300: -- Attachment: (was: OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc.patch) > Convert Minilang to Groovy Guide into asciidoc > --- > > Key: OFBIZ-10300 > URL: https://issues.apache.org/jira/browse/OFBIZ-10300 > Project: OFBiz > Issue Type: Improvement > Components: framework >Affects Versions: Trunk >Reporter: Benjamin Jugl >Assignee: Jacques Le Roux >Priority: Minor > Attachments: > OFBIZ-10300_Convert_Minilang_to_Groovy_guide_into_asciidoc02.patch > > > Convert [~Dennis Balkir]s [Minilang to Groovy > Guide|https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+From+Mini+Language+to+Groovy] > into AsciiDoc. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
