[jira] [Commented] (OFBIZ-12856) Use docker containers to host demo-stable

2023-12-04 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17792730#comment-17792730
 ] 

Jacopo Cappellato commented on OFBIZ-12856:
---

Hello Daniel, is this task completed now?

> Use docker containers to host demo-stable
> -
>
> Key: OFBIZ-12856
> URL: https://issues.apache.org/jira/browse/OFBIZ-12856
> Project: OFBiz
>  Issue Type: Task
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Major
> Fix For: 18.12.10
>
>
> Over the last few months we have found that our demo VM is frequently 
> restarted.
> The trunk and next demos are run using docker containers. We recently applied 
> restart policies to these containers to ensure the demos are restarted once 
> the VM has restarted.
> We do not have a similar mechanism in place to automatically restart the 
> stable demo.
> Since the 18.12 branch is likely to remain as our stable branch for some 
> time, we can explore the automatic build of docker container images following 
> the application of any release tags to this branch. We can then pull those 
> container images nightly to the demo VM and use them to run the demo-stable 
> site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12856) Use docker containers to host demo-stable

2023-11-05 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12856:
--
Fix Version/s: 18.12.10
   (was: 18.12.09)

> Use docker containers to host demo-stable
> -
>
> Key: OFBIZ-12856
> URL: https://issues.apache.org/jira/browse/OFBIZ-12856
> Project: OFBiz
>  Issue Type: Task
>Reporter: Daniel Watford
>Assignee: Daniel Watford
>Priority: Major
> Fix For: 18.12.10
>
>
> Over the last few months we have found that our demo VM is frequently 
> restarted.
> The trunk and next demos are run using docker containers. We recently applied 
> restart policies to these containers to ensure the demos are restarted once 
> the VM has restarted.
> We do not have a similar mechanism in place to automatically restart the 
> stable demo.
> Since the 18.12 branch is likely to remain as our stable branch for some 
> time, we can explore the automatic build of docker container images following 
> the application of any release tags to this branch. We can then pull those 
> container images nightly to the demo VM and use them to run the demo-stable 
> site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (OFBIZ-12686) Tax calculation not considering productStoreGroup

2022-09-01 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12686:
--
Fix Version/s: (was: 18.12.06)

> Tax calculation not considering productStoreGroup
> -
>
> Key: OFBIZ-12686
> URL: https://issues.apache.org/jira/browse/OFBIZ-12686
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting, order
>Affects Versions: Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12686-1.patch, OFBIZ-12686.patch, StoreForms.xml, 
> taxCalc.patch, taxCalc2.patch, taxCalc3.patch
>
>
> For one product I have different prices according to the product store:
> B2C store: taxinPrice = Y
> B2B store: taxinPrice = N
> The tax calc service takes the most current price and ignores the product 
> store.
> Therefore it may happen that SALES_TAX is calculated instead of VAT_TAX.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (OFBIZ-12455) Product inventory reservation places orders if quantityNotReserved !=0 and requireInventory=Y

2022-03-23 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511297#comment-17511297
 ] 

Jacopo Cappellato commented on OFBIZ-12455:
---

Hi [~Giulio_MpStyle] 

I have reviewed your last patch and it looks good to me.

> Product inventory reservation places orders if quantityNotReserved !=0 and 
> requireInventory=Y
> -
>
> Key: OFBIZ-12455
> URL: https://issues.apache.org/jira/browse/OFBIZ-12455
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, order
>Affects Versions: Trunk, 17.12.08, 18.12.01, 18.12.02, 18.12.03, Upcoming 
> Branch
> Environment: Linux/Ubuntu 20.04 LTS, Java 8
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Major
> Attachments: OFBIZ-12455_14122021_trunk.patch
>
>
> The service *reserveProductInventoryByFacility* (file 
> InventoryReserveServices.xml) simply do nothing in case quantityNotReserved 
> value is not 0, but (ProductStore) requireInventory = Y.
> Now, no action is taken and quantityNotReserved is simply returned to the 
> caller (ie: reserveStoreInventory).
> In this scenario an order can be placed despite there is no available 
> inventory to fulfill an order item, causing backorder (that we wanted to 
> avoid setting requireInventory flag on the ProductStore to Y ).
>  
> {code:java}
>  value="0" type="BigDecimal">
>   
>     
>    {code}
> I checked the usage of the service around the project and it seems to me that 
> we can make an important assertion:  we can consider that also  
> requireInventory flag of the ProductStore is Y.
>  
> This issue is strictly related to OFBIZ-12264 issue.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12264) Multiple Facility Inventory reservation does not consider store facility thru date

2022-03-23 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17511296#comment-17511296
 ] 

Jacopo Cappellato commented on OFBIZ-12264:
---

Hi [~Giulio_MpStyle] 

I have reviewed your last patch and it looks good to me for being committed.

> Multiple Facility Inventory reservation does not consider store facility thru 
> date
> --
>
> Key: OFBIZ-12264
> URL: https://issues.apache.org/jira/browse/OFBIZ-12264
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce, product
>Affects Versions: Release Branch 18.12, 17.12.03, Trunk, 17.12.04, 
> 17.12.05, 17.12.06, 17.12.07, Upcoming Branch
> Environment: Linux/Ubuntu 18.04 LTS, Java jdk 8, OFBiz v13.07.03
>  
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Major
> Attachments: OFBIZ-12264_13122021_trunk.patch, 
> OFBIZ-12264_v130703.patch, OFBIZ-12264_v17.patch, Screenshot from 2021-11-12 
> 01-58-45.png, image-2021-06-24-00-35-10-392.png, 
> image-2021-06-24-00-37-21-890.png, image-2021-06-24-00-40-41-737.png, 
> image-2021-06-24-00-41-56-344.png, image-2021-06-24-00-43-33-640.png, 
> image-2021-06-24-00-46-17-924.png, image-2021-06-24-00-49-23-904.png
>
>
> The ProductStore is set up to reserve inventory from more than one facility, 
> so the flag oneInventoryFacility is set to N. 
>  The we have 8 different facilities configured (each with a specific sequence 
> num from 1 to 8) in the entity ProductStoreFacility.
>   
>  Due to customer requests I had to disable 6 out of 8 facilities associated 
> with the store, so basically only facilities with (sequence) numbers 1 and 2 
> are left. To achieve this I set the thruDate on the other six records.
>   
>  After that, an order came in with a variant product that had only 1 quantity 
> left available in one of the disabled facilities and 0 in both the two 
> facilities left enabled, but despite this the system reserved inventory from 
> the disabled facility: I wouldn't expect that.
>   
>  The service responsible for the reservation is reserveStoreInventory that in 
> our ofbiz version (13.07.03) is minilang and is implemented in 
> ProductStoreServices.xml: I checked that service and I noticed that when the 
> ProductStore is set to multi facility (oneInventoryFacility to N) and the 
> list of productStoreFacility records are retrieved, they are not filtered by 
> date, and this lead to a "bad" reservation.
>  I took a look also at the current revision of ofbiz and the code (groovy 
> script) is basically the same, so the issue is present there also.
>  
> ADDITIONAL NOTE:
> The the reservation should not be done for this product, but this part is 
> only the last step of the ecommerce sales order flow.
> I think that with a scenario like the one above, the specific product variant 
> should not even be added to the cart, so in the item page (productdetail) 
> this particular variant should not have been visible/selected by the user.
> But I have to take a better look at this part.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-12479) Announce 17.12 branch EOL (End Of Life)

2022-01-15 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-12479.
-
Resolution: Fixed

> Announce 17.12 branch EOL (End Of Life)
> ---
>
> Key: OFBIZ-12479
> URL: https://issues.apache.org/jira/browse/OFBIZ-12479
> Project: OFBiz
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 17.12.09
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.09
>
>
> Following https://lists.apache.org/thread/ohso3zk7l2os8w1l6395l5tvhyzwngq4 I 
> propose an announcement for the EOL of the 18.12 branch with 17.12.08. Next 
> time we will, like Struts, announce 6 months ago before the definitive 
> announcement: https://s.apache.org/qr8ci



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12479) Announce 17.12.09 EOL

2022-01-07 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470687#comment-17470687
 ] 

Jacopo Cappellato commented on OFBIZ-12479:
---

Or maybe:
{quote}Subject: [ANNOUNCE] Apache OFBiz 17.12 End-OF-LiFE (EOL) announcement
{quote}
 

> Announce 17.12.09 EOL
> -
>
> Key: OFBIZ-12479
> URL: https://issues.apache.org/jira/browse/OFBIZ-12479
> Project: OFBiz
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 17.12.09
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.09
>
>
> Following https://lists.apache.org/thread/ohso3zk7l2os8w1l6395l5tvhyzwngq4 I 
> propose an announcement for the EOL of the 18.12 branch with 17.12.08. Next 
> time we will, like Struts, announce 6 months ago before the definitive 
> announcement: https://s.apache.org/qr8ci



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Comment Edited] (OFBIZ-12479) Announce 17.12.09 EOL

2022-01-07 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470534#comment-17470534
 ] 

Jacopo Cappellato edited comment on OFBIZ-12479 at 1/7/22, 11:01 AM:
-

Hi [~jleroux], all,

here is a modified version of your draft for your review:

 
{quote}=== Recipients ===
to: u...@ofbiz.apache.org
to: d...@ofbiz.apache.org
reply to: d...@ofbiz.apache.org
cc: secur...@ofbiz.apache.org
cc: annou...@apache.org. Must be sent from an Apache email address

Subject: [ANN] Apache OFBiz 17.12.09 End-OF-LiFE (EOL) announcement

=== Body ===
The Apache OFBiz Project Team would like to inform you that OFBiz 17.12.09
is the last release of the 17.12 branch, which has reached its end of life and 
won’t be longer officially supported.

[https://ofbiz.apache.org/release-notes-17.12.09.html]

This announcement takes place on 2022-01-xx and starting from today
we will only support Apache OFBiz 18.12.x in case of security
vulnerabilities.

Questions and Answers:

With the announcement of OFBiz 17.12.09 EOL, what happens to
OFBiz 17.12.09 resources?

All resources will stay where they are. The documentation will still
be accessible from the Apache OFBiz homepage [*], as well as the
downloads for all released OFBiz 17.12.xx versions. All of the OFBiz
17.12.09 source code can be found in the Apache OFBiz Git repository
under branch release17.12, now and in future. This concerns the
framework [*] and the plugins [**].

[*] [https://ofbiz.apache.org/]

[**] [https://github.com/apache/ofbiz-framework]

[***] [https://github.com/apache/ofbiz-plugins]

Is there an immediate need to upgrade from OFBiz 17.12.09 in my projects?

If you are using a release between 17.12.01 and 17.12.08 you should immediately
upgrade to 17.12.09, because there are several Log4j vulnerabilities present in 
all
OFBiz releases before 17.12.09.
As today, there aren't known vulnerabilities affecting OFBiz 17.12.09;
however, considering that the 17.12.09 is the last release in this branch, 
you should plan to migrate to the latest version of 18.12.x as soon as possible.

My friends / colleagues and I would like to see OFBiz 17.12.x being
maintained again. What can we do?

You may fork the existing source and support it on your own.

Kind regards
–
The Apache OFBiz Team
{quote}


was (Author: jacopoc):
Hi [~jleroux], all,

here is a modified version of your draft for your review:

 
{quote}=== Recipients ===
to: u...@ofbiz.apache.org
to: d...@ofbiz.apache.org
reply to: d...@ofbiz.apache.org
cc: secur...@ofbiz.apache.org
cc: annou...@apache.org. Must be sent from an Apache email address

Subject: [ANN] Apache OFBiz 17.12.09 End-OF-LiFE (EOL) announcement

=== Body ===
The Apache OFBiz Project Team would like to inform you that OFBiz 17.12.09
is the last release of the 17.12 branch, which has reached its end of life and 
won’t be longer officially supported.

https://ofbiz.apache.org/release-notes-17.12.09.html

This announcement takes place on 2022-01-xx and starting from today
we will only support Apache OFBiz 18.12.x in case of security
vulnerabilities.

Questions and Answers:

With the announcement of OFBiz 17.12.09 EOL, what happens to
OFBiz 17.12.09 resources?

All resources will stay where they are. The documentation will still
be accessible from the Apache OFBiz homepage (*), as well as the
downloads for all released OFBiz 17.12.xx versions. All of the OFBiz
17.12.09 source code can be found in the Apache OFBiz Git repository
under branch release17.12, now and in future. This concerns the
framework (**) and the plugins (***).
* https://ofbiz.apache.org/
** https://github.com/apache/ofbiz-framework
*** https://github.com/apache/ofbiz-plugins

Is there an immediate need to upgrade from OFBiz 17.12.09 in my projects?

If you are using a release between 17.12.01 and 17.12.08 you should immediately
upgrade to 17.12.09, because there are several Log4j vulnerabilities present in 
all
OFBiz releases before 17.12.09.
As today, there aren't known vulnerabilities affecting OFBiz 17.12.09;
however, considering that the 17.12.09 is the last release in this branch, 
you should plan to migrate to the latest version of 18.12.x as soon as possible.

My friends / colleagues and I would like to see OFBiz 17.12.x being
maintained again. What can we do?

You may fork the existing source and support it on your own.

Kind regards
--
The Apache OFBiz Team
{quote}

> Announce 17.12.09 EOL
> -
>
> Key: OFBIZ-12479
> URL: https://issues.apache.org/jira/browse/OFBIZ-12479
> Project: OFBiz
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 17.12.09
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.09
>

[jira] [Commented] (OFBIZ-12479) Announce 17.12.09 EOL

2022-01-07 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17470534#comment-17470534
 ] 

Jacopo Cappellato commented on OFBIZ-12479:
---

Hi [~jleroux], all,

here is a modified version of your draft for your review:

 
{quote}=== Recipients ===
to: u...@ofbiz.apache.org
to: d...@ofbiz.apache.org
reply to: d...@ofbiz.apache.org
cc: secur...@ofbiz.apache.org
cc: annou...@apache.org. Must be sent from an Apache email address

Subject: [ANN] Apache OFBiz 17.12.09 End-OF-LiFE (EOL) announcement

=== Body ===
The Apache OFBiz Project Team would like to inform you that OFBiz 17.12.09
is the last release of the 17.12 branch, which has reached its end of life and 
won’t be longer officially supported.

https://ofbiz.apache.org/release-notes-17.12.09.html

This announcement takes place on 2022-01-xx and starting from today
we will only support Apache OFBiz 18.12.x in case of security
vulnerabilities.

Questions and Answers:

With the announcement of OFBiz 17.12.09 EOL, what happens to
OFBiz 17.12.09 resources?

All resources will stay where they are. The documentation will still
be accessible from the Apache OFBiz homepage (*), as well as the
downloads for all released OFBiz 17.12.xx versions. All of the OFBiz
17.12.09 source code can be found in the Apache OFBiz Git repository
under branch release17.12, now and in future. This concerns the
framework (**) and the plugins (***).
* https://ofbiz.apache.org/
** https://github.com/apache/ofbiz-framework
*** https://github.com/apache/ofbiz-plugins

Is there an immediate need to upgrade from OFBiz 17.12.09 in my projects?

If you are using a release between 17.12.01 and 17.12.08 you should immediately
upgrade to 17.12.09, because there are several Log4j vulnerabilities present in 
all
OFBiz releases before 17.12.09.
As today, there aren't known vulnerabilities affecting OFBiz 17.12.09;
however, considering that the 17.12.09 is the last release in this branch, 
you should plan to migrate to the latest version of 18.12.x as soon as possible.

My friends / colleagues and I would like to see OFBiz 17.12.x being
maintained again. What can we do?

You may fork the existing source and support it on your own.

Kind regards
--
The Apache OFBiz Team
{quote}

> Announce 17.12.09 EOL
> -
>
> Key: OFBIZ-12479
> URL: https://issues.apache.org/jira/browse/OFBIZ-12479
> Project: OFBiz
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 17.12.09
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.09
>
>
> Following https://lists.apache.org/thread/ohso3zk7l2os8w1l6395l5tvhyzwngq4 I 
> propose an announcement for the EOL of the 18.12 branch with 17.12.08. Next 
> time we will, like Struts, announce 6 months ago before the definitive 
> announcement: https://s.apache.org/qr8ci



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12479) Announce 17.12.08 EOL

2022-01-06 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17469792#comment-17469792
 ] 

Jacopo Cappellato commented on OFBIZ-12479:
---

[~jleroux] I think that the draft should be rewritten to clarify that 17.12.08 
has been published in August 2021 and since the release of 18.12.01 in October 
2021, the release branch 17.12 is no longer supported.

If we want to maintain the format of your draft, we should release one last 
release from 17.12 (aka 17.12.09) containing fixes for all the CVEs reported up 
to now and then  announce its EOL.

 

> Announce 17.12.08 EOL
> -
>
> Key: OFBIZ-12479
> URL: https://issues.apache.org/jira/browse/OFBIZ-12479
> Project: OFBiz
>  Issue Type: Task
>  Components: Documentation
>Affects Versions: 17.12.08
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: 17.12.08
>
>
> Following https://lists.apache.org/thread/ohso3zk7l2os8w1l6395l5tvhyzwngq4 I 
> propose an announcement for the EOL of the 18.12 branch with 17.12.08. Next 
> time we will, like Struts, announce 6 months ago before the definitive 
> announcement: https://s.apache.org/qr8ci



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12470) [SECURITY] CVE-2021-45105: Apache Log4j2

2021-12-19 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12470:
--
Fix Version/s: 18.12.04

> [SECURITY] CVE-2021-45105: Apache Log4j2
> 
>
> Key: OFBIZ-12470
> URL: https://issues.apache.org/jira/browse/OFBIZ-12470
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 18.12.03
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
> Fix For: 18.12.04
>
>
> CVE-2021-45105: Apache Log4j2 versions 2.0-alpha1 through 2.16.0 does not 
> protect from uncontrolled recursion from self-referential lookups. This 
> allows an attacker with control over Thread Context Map data to cause a 
> denial of service when a crafted string is interpreted. This issue is fixed 
> in Log4j 2.17.0.: https://logging.apache.org/log4j/2.x/security.html



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12470) [SECURITY] CVE-2021-45105: Apache Log4j2

2021-12-19 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12470:
--
Affects Version/s: 18.12.03
   (was: 18.12.04)

> [SECURITY] CVE-2021-45105: Apache Log4j2
> 
>
> Key: OFBIZ-12470
> URL: https://issues.apache.org/jira/browse/OFBIZ-12470
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: 18.12.03
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Blocker
>
> CVE-2021-45105: Apache Log4j2 versions 2.0-alpha1 through 2.16.0 does not 
> protect from uncontrolled recursion from self-referential lookups. This 
> allows an attacker with control over Thread Context Map data to cause a 
> denial of service when a crafted string is interpreted. This issue is fixed 
> in Log4j 2.17.0.: https://logging.apache.org/log4j/2.x/security.html



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12468) Bug in HtmlFormMacroLibrary.ftl::makeHyperlinkString macro

2021-12-19 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12468:
--
Affects Version/s: 18.12.03
   (was: 18.12.04)

> Bug in HtmlFormMacroLibrary.ftl::makeHyperlinkString macro 
> ---
>
> Key: OFBIZ-12468
> URL: https://issues.apache.org/jira/browse/OFBIZ-12468
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, 18.12.03
> Environment: Trunk demo
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 18.12.04
>
> Attachments: console.tar.gz
>
>
> I noticed a very big (1.7GB) console.log on trunk demo 2 days ago 
> (2021-12-16). I thought it was related to makeHyperlinkString macro in 
> HtmlFormMacroLibrary.ftl. But actually



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6796) Group menu items to a side panel

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6796:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Group menu items to a side panel
> 
>
> Key: OFBIZ-6796
> URL: https://issues.apache.org/jira/browse/OFBIZ-6796
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Consolidate the menus definitions for management modules into one file and 
> display them in a side panel for easy access. 
> The menus can be displayed in accordion + tree form.
> There will be a content panel, and clicking the menu item will refresh the 
> content panel.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-4896) ProductionRunDeclaration doesn't show Routing

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-4896:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> ProductionRunDeclaration doesn't show Routing
> -
>
> Key: OFBIZ-4896
> URL: https://issues.apache.org/jira/browse/OFBIZ-4896
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Release Branch 12.04, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Trunk
>
> Attachments: EditProductionRun.png, EditRoutingProductLink.png, 
> ProductionRunDeclaration_Confirmed.png
>
>
> When having created a new production run in MFG with a routing selected, the 
> routing isn't shown when the production run is confirmed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-4896) ProductionRunDeclaration doesn't show Routing

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-4896:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> ProductionRunDeclaration doesn't show Routing
> -
>
> Key: OFBIZ-4896
> URL: https://issues.apache.org/jira/browse/OFBIZ-4896
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing
>Affects Versions: Release Branch 12.04, Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: EditProductionRun.png, EditRoutingProductLink.png, 
> ProductionRunDeclaration_Confirmed.png
>
>
> When having created a new production run in MFG with a routing selected, the 
> routing isn't shown when the production run is confirmed.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6796) Group menu items to a side panel

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6796?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6796:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Group menu items to a side panel
> 
>
> Key: OFBIZ-6796
> URL: https://issues.apache.org/jira/browse/OFBIZ-6796
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> Consolidate the menus definitions for management modules into one file and 
> display them in a side panel for easy access. 
> The menus can be displayed in accordion + tree form.
> There will be a content panel, and clicking the menu item will refresh the 
> content panel.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6928) Have the layered model renderer work with EntityUtilProperties regarding retrieval of property values

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6928:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Have the layered model renderer work with EntityUtilProperties regarding 
> retrieval of property values
> -
>
> Key: OFBIZ-6928
> URL: https://issues.apache.org/jira/browse/OFBIZ-6928
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
>  Labels: multi-tenant
> Fix For: Trunk
>
>
> Currently property values are retrieved through
> {code}
> UtilProperties.getPropertyValue
> {code} function
> This should be using  EntityUtilProperties.getPropertyValue function.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6928) Have the layered model renderer work with EntityUtilProperties regarding retrieval of property values

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6928:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Have the layered model renderer work with EntityUtilProperties regarding 
> retrieval of property values
> -
>
> Key: OFBIZ-6928
> URL: https://issues.apache.org/jira/browse/OFBIZ-6928
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pierre Smits
>Priority: Major
>  Labels: multi-tenant
> Fix For: Upcoming Branch
>
>
> Currently property values are retrieved through
> {code}
> UtilProperties.getPropertyValue
> {code} function
> This should be using  EntityUtilProperties.getPropertyValue function.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7762) Full support for serialized inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7762:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Full support for serialized inventory
> -
>
> Key: OFBIZ-7762
> URL: https://issues.apache.org/jira/browse/OFBIZ-7762
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing, order, product
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> The serialized inventory support is not feature complete.
> There have been some discussion on it at
> http://ofbiz.135035.n4.nabble.com/Serialized-inventory-not-well-implemented-td4656591.html
> Need further discussion to finalise implementation details and create 
> sub-issues as required. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7762) Full support for serialized inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7762?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7762:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Full support for serialized inventory
> -
>
> Key: OFBIZ-7762
> URL: https://issues.apache.org/jira/browse/OFBIZ-7762
> Project: OFBiz
>  Issue Type: Improvement
>  Components: manufacturing, order, product
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The serialized inventory support is not feature complete.
> There have been some discussion on it at
> http://ofbiz.135035.n4.nabble.com/Serialized-inventory-not-well-implemented-td4656591.html
> Need further discussion to finalise implementation details and create 
> sub-issues as required. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7976) ebaystore screen rendering exception

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7976:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> ebaystore screen rendering exception
> 
>
> Key: OFBIZ-7976
> URL: https://issues.apache.org/jira/browse/OFBIZ-7976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Wai
>Priority: Major
> Fix For: Upcoming Branch
>
>
> go to https://localhost:8443/ebaystore/control/main
> click on submit
> page show errors...
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://ebaystore/widget/EbayAccountScreens.xml#EbayPersonalInformation]:
>  org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).) (Error rendering screen 
> [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).))



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7248) Improve the layout of PDF documents

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7248:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Improve the layout of PDF documents
> ---
>
> Key: OFBIZ-7248
> URL: https://issues.apache.org/jira/browse/OFBIZ-7248
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Mohammad Kathawala
>Priority: Major
> Fix For: Upcoming Branch
>
>
> The layout of all the PDF documents in OFBiz like Order, Invoice, Picklist, 
> Shipment etc. does not look very good and is not very readable for end users. 
> We need to have a properly structured PDF documents which is easy to read.
> I am going  to create sub-tasks of this parent task for all the different 
> objects.  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8253) Success/Error Message On CRUD Operations

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8253:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Success/Error Message On CRUD Operations
> 
>
> Key: OFBIZ-8253
> URL: https://issues.apache.org/jira/browse/OFBIZ-8253
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Reporter: Avnindra Sharma
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: screenshot-withoutSuccessMessage.png
>
>
> There are many screens where we don't get any success/error message on any 
> CRUD operation. 
> In this ticket, we will cover all that screen and make the Generic 
> Success/Error message of CRUD operations.
> For eg: While creating a new facility, we don't get any success message and 
> on also not a generic error message for it.
>  
> Please find the attached screenshot for more reference.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7976) ebaystore screen rendering exception

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7976:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> ebaystore screen rendering exception
> 
>
> Key: OFBIZ-7976
> URL: https://issues.apache.org/jira/browse/OFBIZ-7976
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Wai
>Priority: Major
> Fix For: Trunk
>
>
> go to https://localhost:8443/ebaystore/control/main
> click on submit
> page show errors...
> ERROR rendering error page [/error/error.jsp], but here is the error text: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://ebaystore/widget/EbayAccountScreens.xml#EbayPersonalInformation]:
>  org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).) (Error rendering screen 
> [component://ebaystore/widget/CommonScreens.xml#AccountDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: Error in Service 
> [getEbayUser]: Please set the API developer (ApiAccount.setDeveloper()). (The 
> current transaction is marked for rollback, not beginning a new transaction 
> and aborting current operation; the rollbackOnly was caused by: Error in 
> Service [getEbayUser]: Please set the API developer 
> (ApiAccount.setDeveloper()).))



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10360:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10361) Refactoring Variable Scope for org.apache.ofbiz.service

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10361:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.service
> ---
>
> Key: OFBIZ-10361
> URL: https://issues.apache.org/jira/browse/OFBIZ-10361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10343) Refactoring Variable Scope

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10343:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope  
> 
>
> Key: OFBIZ-10343
> URL: https://issues.apache.org/jira/browse/OFBIZ-10343
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
>
> Here is the detailed information about the things I am working on for 
> performance optimization in our OFBiz code.
>  
>  *1.) Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract 
> class, declared member variables, enumerations, methods, and constructors to 
> as minimum as possible as per OFBIz current implementation, still there is a 
> lot of scope for improvement but it would require changes at the granular 
> level. I've used 
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
> as my reference point. example:
>  
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
>  
>  *2.) Using Lambda Expressions*
> Then tried to use lambda expressions on simple functional work to leverage 
> implicit type of coding an example: 
>  
> {code:java}
> Map initParameters = new LinkedHashMap<>();
> for (Element e : initParamList) {
> initParameters.put(e.getAttribute("name"), e.getAttribute("value"));
> }{code}
> {code:java}
> Map initParameters = 
> initParamList.stream().collect(Collectors.toMap(e -> e.getAttribute("name"), 
> e -> e.getAttribute("value"), (a, b) -> b, LinkedHashMap::new));{code}
> Some of the key benefits of using lambdas will introduce [Functional style 
> over Imperative 
> style|https://stackoverflow.com/questions/2078978/functional-programming-vs-object-oriented-programming],
>  we can use [method 
> referencing|https://docs.oracle.com/javase/tutorial/java/javaOO/methodreferences.html],
>  usage of aggregate operations, and it will help developers to write memory 
> efficient code. 
>  
>  *3.) Using Type Inference*
> Java uses type inference so to make code lightweight I've updated code 
> constructs as shown in the example for more on this refer this 
> [article|https://docs.oracle.com/javase/tutorial/java/generics/genTypeInference.htmlv].
>  
> {code:java}
> Map systemProps = UtilGenerics. 
> checkMap(System.getProperties());{code}
> {code:java}
> Map systemProps = 
> UtilGenerics.checkMap(System.getProperties());{code}
>  
>  *4.) Use of single quote for character*
> There is a significant usage of <"Single Character"> in the codebase for 
> example:-
>  
> {code:java}
> throw new GenericConfigException("Error opening file at location [" + 
> fileUrl.toExternalForm() + "]", e);{code}
> {code:java}
> throw new GenericConfigException("Error opening file at location [" + 
> fileUrl.toExternalForm() + ']', e);  "]" {code}
> "]" is comparatively slower than ']' Java internally uses Flyweight Design 
> pattern to create String literals so for every call it will not create a new 
> Object and used an existing one this will improve performance to some extent 
> a study can be seen on 
> [this|https://stackoverflow.com/questions/24859500/concatenate-char-literal-x-vs-single-char-string-literal-x]
>  page.  
>  
>  *5.) Updated Variable Declaration*
> Lastly, some of the variable declarations are updated this doesn't create a 
> huge difference but helps JVM at the from implicit conversion. 
>  
> {code:java}
> private long cumulativeEvents = 0;{code}
> {code:java}
> private long cumulativeEvents = 0L;{code}
> Based on above findings, I have done some code improvement and provided 
> following patches.
> *And need community help for reviewing these changes.*
> Kindly provide any improvements or suggestion you have in mind :)
>  
> P.S. Apart from this I am also working on performance matrix and will share 
> it soon.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10360) Refactoring Variable Scope for org.apache.ofbiz.webapp

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10360:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.webapp 
> ---
>
> Key: OFBIZ-10360
> URL: https://issues.apache.org/jira/browse/OFBIZ-10360
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8538) Unit test case for service - updateSimpleTextContent

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8538:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Unit test case for service - updateSimpleTextContent
> 
>
> Key: OFBIZ-8538
> URL: https://issues.apache.org/jira/browse/OFBIZ-8538
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: content
>Reporter: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Unit test case for service - updateSimpleTextContent



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10477:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract 
> class, declared member variables, enumerations, methods, and constructors to 
> as minimum as possible as per OFBIz current implementation, still there is a 
> lot of scope for improvement but it would require changes at the granular 
> level. I've used 
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
> as my reference point. example:
>  
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope 
> furthermore can be enhanced 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10361) Refactoring Variable Scope for org.apache.ofbiz.service

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10361:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.service
> ---
>
> Key: OFBIZ-10361
> URL: https://issues.apache.org/jira/browse/OFBIZ-10361
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11409) POC for Dynamic Screen Using MVVM

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11409:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> POC for Dynamic Screen Using MVVM
> -
>
> Key: OFBIZ-11409
> URL: https://issues.apache.org/jira/browse/OFBIZ-11409
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch, 
> OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch
>
>
> Proof of concept for Model–view–viewmodel (MVVM) in form widgets.
> Added data-bind attribute to the field, form and grid tag.
> *Example 1:*
> Go to [https://localhost:8443/humanres/control/NewEmployee] and try the 
> following field:
>  # First name
>  # Middle name
>  # Last name
> Added Full Name field to demonstrate computed observable/property.
> *Example 2:*
> Page at 
> [https://localhost:8443/ordermgr/control/ListQuoteItemsDemo?quoteId=CQ0001] 
> duplicated the functionality of Quote Items page, but done using data-binding 
> way. 
> mbrohl: here is a link to the discussion on the dev mailing list: 
> [https://lists.apache.org/thread.html/r1cddbc8041e5a6559bfad979bc8570581a3d1f662a0f8692c7ee9e59%40%3Cdev.ofbiz.apache.org%3E]
> *15th March 2020* 
>  Updated the patch with more concrete examples for form and grid.
> *10th April 2020*
> Updated the patch with initVmFunc and some refactoring.
> *3rd May 2020*
> Updated the patch with a single demo that uses form and grid together.
>  # The demo can be accessed from 
> [https://localhost:8443/ordermgr/control/EditQuoteAndItems].
>  # Added a view='knockout' attribute so that form renderer will render the 
> form / grid for use by knockout framework.
>  # Added autocomplete templates
>  
> *Details*
> 1) -A javascript model function will be generated for the form / grid widgets 
> when its data-bind attribute is defined.- 
>  As of 3rd April, all datamodel are not autogenerated.
> 2) First row of the grid is generated by the ofbiz form renderer at the 
> server side. Subsequent rows will be generated by knockout at the browser 
> side.
> -3) Naming convention of the viewmodel function is  Grid>*VmFunc*. There is a viewmodel for the Grid widget at row level; naming 
> convention is *VmRowFunc*.-
> 4) Viewmodel function can be extended using javascript prototype. See the 
> *.js.ftl files in the patch. 
> 5) The following javascript files are used:
>  * big/big.js - for basic mathematics operation
>  * knockout/knockout-3.5.1.js - knockout library
>  * knockout/knockout-config.js - extending the library and some code to 
> configure knockout-secure-binding
>  * knockout/knockout-secure-binding - allow knockout js to be used with a 
> Content Security Policy that disables eval and new Function.
>  * knockout-jqAutocomplete.js -  for autocomplete
> 6)  Example of hyperlink:
> Before:
> {code:xml}
>  widget-style="buttontext" use-when="${groovy: 'N'.equals(isPromo)}">
>  also-hidden="false">
> 
> 
> 
> 
> {code}
> After:
> {code:xml}
>  data-bind="text:quoteItemSeqId, attr: { href: 
> editQuoteItemLink, title: 'Quote Item Seq ID'}"
>widget-style="buttontext">
> 
> 
> {code}
> {code:javascript}
> QuoteItem.prototype = {
> computed: {
> "editQuoteItemLink": function(){
> return "<@ofbizUrl>EditQuoteItem?=" + 
> this.quoteItemSeqId() + "=" + this.quoteId();
> },
>...
> };
> {code}
> From the value of data-bind attribute, we can see that the href attribute 
> points to the editQuoteItemLink function.
> editQuoteItemLink is a prototype member of QuoteItems which is viewmodel 
> function for the Grid widget at row level.
> 7) Example of decimal places:
> {code:javascript}
> extend: {
> "quoteUnitPrice": {numeric: 2}
> }
> {code}
> The column or field for qouteUnitPrice will be rounded to 2 decimal places.
> 8) Example of calculating line totals:
> {code:xml}
>  
> {code}
> {code:javascript}
> QuoteItems.prototype = {
> computed: {
> ...
> "lineTotal": function() {
> var itemPrice = this.quoteUnitPrice();
> var selectedAmount = this.selectedAmount() || 1;
> var quantity = this.quantity() || 0;
> return new 
> Big(itemPrice).times(selectedAmount).times(quantity).toFixed(2);
> }
> ...
> };
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11069) Add coalesce to aggregate-function of model view

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11069:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Add coalesce to aggregate-function of model view
> 
>
> Key: OFBIZ-11069
> URL: https://issues.apache.org/jira/browse/OFBIZ-11069
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Shi Jinghai
>Priority: Trivial
>  Labels: IoT, ModelViewEntity
> Fix For: Upcoming Branch
>
> Attachments: ModelViewEntity-function-coalesce.patch
>
>
> While in our IoT case, a product may have a sku product id as well as a 
> productId (product instance) by identified from unique id i.e. an EPC.
> When building operation/inventory reports, to be compatible with previous 
> implement, I have to merge the sku product Id column into the productId 
> column, so comes the coalesce patch. 
> The usage example:
> {code:java}
>  function="coalesce">
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10477) Parent ticket for reducing scope of variables and methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10477:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Parent ticket for reducing scope of variables and methods
> -
>
> Key: OFBIZ-10477
> URL: https://issues.apache.org/jira/browse/OFBIZ-10477
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
>
> *Downsize Accessibility Scope*
> I've tried to downsize accessibility scope of classes, interfaces, abstract 
> class, declared member variables, enumerations, methods, and constructors to 
> as minimum as possible as per OFBIz current implementation, still there is a 
> lot of scope for improvement but it would require changes at the granular 
> level. I've used 
> [this|https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html] 
> as my reference point. example:
>  
> {code:java}
> public void noteKeyRemoval(UtilCache cache, K key, V oldValue);{code}
> {code:java}
> void noteKeyRemoval(UtilCache cache, K key, V oldValue); {code}
> As per the current implementation, I will try to give minimum scope 
> furthermore can be enhanced 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11409) POC for Dynamic Screen Using MVVM

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11409:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> POC for Dynamic Screen Using MVVM
> -
>
> Key: OFBIZ-11409
> URL: https://issues.apache.org/jira/browse/OFBIZ-11409
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch, 
> OFBIZ-11409.patch, OFBIZ-11409.patch, OFBIZ-11409.patch
>
>
> Proof of concept for Model–view–viewmodel (MVVM) in form widgets.
> Added data-bind attribute to the field, form and grid tag.
> *Example 1:*
> Go to [https://localhost:8443/humanres/control/NewEmployee] and try the 
> following field:
>  # First name
>  # Middle name
>  # Last name
> Added Full Name field to demonstrate computed observable/property.
> *Example 2:*
> Page at 
> [https://localhost:8443/ordermgr/control/ListQuoteItemsDemo?quoteId=CQ0001] 
> duplicated the functionality of Quote Items page, but done using data-binding 
> way. 
> mbrohl: here is a link to the discussion on the dev mailing list: 
> [https://lists.apache.org/thread.html/r1cddbc8041e5a6559bfad979bc8570581a3d1f662a0f8692c7ee9e59%40%3Cdev.ofbiz.apache.org%3E]
> *15th March 2020* 
>  Updated the patch with more concrete examples for form and grid.
> *10th April 2020*
> Updated the patch with initVmFunc and some refactoring.
> *3rd May 2020*
> Updated the patch with a single demo that uses form and grid together.
>  # The demo can be accessed from 
> [https://localhost:8443/ordermgr/control/EditQuoteAndItems].
>  # Added a view='knockout' attribute so that form renderer will render the 
> form / grid for use by knockout framework.
>  # Added autocomplete templates
>  
> *Details*
> 1) -A javascript model function will be generated for the form / grid widgets 
> when its data-bind attribute is defined.- 
>  As of 3rd April, all datamodel are not autogenerated.
> 2) First row of the grid is generated by the ofbiz form renderer at the 
> server side. Subsequent rows will be generated by knockout at the browser 
> side.
> -3) Naming convention of the viewmodel function is  Grid>*VmFunc*. There is a viewmodel for the Grid widget at row level; naming 
> convention is *VmRowFunc*.-
> 4) Viewmodel function can be extended using javascript prototype. See the 
> *.js.ftl files in the patch. 
> 5) The following javascript files are used:
>  * big/big.js - for basic mathematics operation
>  * knockout/knockout-3.5.1.js - knockout library
>  * knockout/knockout-config.js - extending the library and some code to 
> configure knockout-secure-binding
>  * knockout/knockout-secure-binding - allow knockout js to be used with a 
> Content Security Policy that disables eval and new Function.
>  * knockout-jqAutocomplete.js -  for autocomplete
> 6)  Example of hyperlink:
> Before:
> {code:xml}
>  widget-style="buttontext" use-when="${groovy: 'N'.equals(isPromo)}">
>  also-hidden="false">
> 
> 
> 
> 
> {code}
> After:
> {code:xml}
>  data-bind="text:quoteItemSeqId, attr: { href: 
> editQuoteItemLink, title: 'Quote Item Seq ID'}"
>widget-style="buttontext">
> 
> 
> {code}
> {code:javascript}
> QuoteItem.prototype = {
> computed: {
> "editQuoteItemLink": function(){
> return "<@ofbizUrl>EditQuoteItem?=" + 
> this.quoteItemSeqId() + "=" + this.quoteId();
> },
>...
> };
> {code}
> From the value of data-bind attribute, we can see that the href attribute 
> points to the editQuoteItemLink function.
> editQuoteItemLink is a prototype member of QuoteItems which is viewmodel 
> function for the Grid widget at row level.
> 7) Example of decimal places:
> {code:javascript}
> extend: {
> "quoteUnitPrice": {numeric: 2}
> }
> {code}
> The column or field for qouteUnitPrice will be rounded to 2 decimal places.
> 8) Example of calculating line totals:
> {code:xml}
>  
> {code}
> {code:javascript}
> QuoteItems.prototype = {
> computed: {
> ...
> "lineTotal": function() {
> var itemPrice = this.quoteUnitPrice();
> var selectedAmount = this.selectedAmount() || 1;
> var quantity = this.quantity() || 0;
> return new 
> Big(itemPrice).times(selectedAmount).times(quantity).toFixed(2);
> }
> ...
> };
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7789) ReserveStoreInventory with insufficient inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7789:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> ReserveStoreInventory with insufficient inventory
> -
>
> Key: OFBIZ-7789
> URL: https://issues.apache.org/jira/browse/OFBIZ-7789
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Upcoming Branch
>Reporter: Mirko Vogelsmeier
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-7789.patch
>
>
> When trying to reserve inventory for an item that does not have sufficient 
> amount of inventory ( ProductStoreServices#reserveStoreInventory ) no error 
> is thrown. This results in a successfully processed service.
> Following problem occured to us:
> We have a unique product (qoh 1) that is in the current order.
> Using the appendOrderItem on the exact product, does trigger 
> updateCartForUpdate which removes all reservations followed by 
> saveUpdatedCartToOrder that does store all orderItems to the order. Since no 
> error is being thrown due to the insufficient inventory, the product is added 
> to the order twice, although there is not enough inventory.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-7789) ReserveStoreInventory with insufficient inventory

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-7789:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> ReserveStoreInventory with insufficient inventory
> -
>
> Key: OFBIZ-7789
> URL: https://issues.apache.org/jira/browse/OFBIZ-7789
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: Release Branch 13.07, Upcoming Branch
>Reporter: Mirko Vogelsmeier
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-7789.patch
>
>
> When trying to reserve inventory for an item that does not have sufficient 
> amount of inventory ( ProductStoreServices#reserveStoreInventory ) no error 
> is thrown. This results in a successfully processed service.
> Following problem occured to us:
> We have a unique product (qoh 1) that is in the current order.
> Using the appendOrderItem on the exact product, does trigger 
> updateCartForUpdate which removes all reservations followed by 
> saveUpdatedCartToOrder that does store all orderItems to the order. Since no 
> error is being thrown due to the insufficient inventory, the product is added 
> to the order twice, although there is not enough inventory.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6360) Form widget rendering broken for EmailServices.java

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6360:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Form widget rendering broken for EmailServices.java
> ---
>
> Key: OFBIZ-6360
> URL: https://issues.apache.org/jira/browse/OFBIZ-6360
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Christian Carlow
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-6360-release13.07.patch, OFBIZ-6360.patch
>
>
> Currently only FTL files are rendered by EmailServices.java because 
> formStringRenderer is null for 
> HtmlScreenRenderer.java#renderScreenletSubWidget which is supposed to be 
> extracted from the context parameter, previously from the request parameter, 
> which never exists for the emailing service.  This issue was encountered when 
> testing the sendQuoteReportMail service for the form widget that replaced the 
> FTL for OFBIZ-6349.  
> EmailServices.java is still using the deprecated HtmlScreenRenderer and 
> FoScreenRenderer which should both be replaced by MacroScreenRenderer.  This 
> made me realize I left out the new header rendering functionality for patch 
> OFBIZ-6354 for these two deprecated classes which probably need to be 
> provided along with the existing patch.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-6360) Form widget rendering broken for EmailServices.java

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-6360:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Form widget rendering broken for EmailServices.java
> ---
>
> Key: OFBIZ-6360
> URL: https://issues.apache.org/jira/browse/OFBIZ-6360
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Christian Carlow
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-6360-release13.07.patch, OFBIZ-6360.patch
>
>
> Currently only FTL files are rendered by EmailServices.java because 
> formStringRenderer is null for 
> HtmlScreenRenderer.java#renderScreenletSubWidget which is supposed to be 
> extracted from the context parameter, previously from the request parameter, 
> which never exists for the emailing service.  This issue was encountered when 
> testing the sendQuoteReportMail service for the form widget that replaced the 
> FTL for OFBIZ-6349.  
> EmailServices.java is still using the deprecated HtmlScreenRenderer and 
> FoScreenRenderer which should both be replaced by MacroScreenRenderer.  This 
> made me realize I left out the new header rendering functionality for patch 
> OFBIZ-6354 for these two deprecated classes which probably need to be 
> provided along with the existing patch.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10344) Refactoring Variable Scope for org.apache.ofbiz.base package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10344:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base package
> 
>
> Key: OFBIZ-10344
> URL: https://issues.apache.org/jira/browse/OFBIZ-10344
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10344.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10164) Splitter Widget

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10164:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, 
> horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at 
> https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8301) The state dropdown not ordered alphabetically on the create/edit address screen of related components

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8301:
-
Affects Version/s: Upcoming Branch
   (was: Trunk)

> The state dropdown not ordered alphabetically on the create/edit address 
> screen of related components
> -
>
> Key: OFBIZ-8301
> URL: https://issues.apache.org/jira/browse/OFBIZ-8301
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Supatthra Nawicha
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Image2.png, Image4.png, OFBIZ-8301.patch
>
>
> I have found this issue when I try to create a new customer from the party 
> manager. Then I try to select the state of UK but I see the state is not 
> order alphabetically. 
> I have check on the getAssociatedStateList service and it provide the 
> listOrderBy parameter for order the value on the state dropdown but the 
> getDependentDropdownValues function on javascript does not send the 
> listOrderBy parameter to the service. 
> {code:title=framework/common/src/main/java/org/apache/ofbiz/common/CommonWorkers.java|borderStyle=solid}
> public static List getAssociatedStateList(Delegator delegator, 
> String country, String listOrderBy) {
> if (UtilValidate.isEmpty(country)) {
> // Load the system default country
> country = EntityUtilProperties.getPropertyValue("general", 
> "country.geo.id.default", delegator);
> }
> if (UtilValidate.isEmpty(listOrderBy)) {
> listOrderBy = "geoId";
> }
> List sortList = UtilMisc.toList(listOrderBy);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10344) Refactoring Variable Scope for org.apache.ofbiz.base package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10344:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base package
> 
>
> Key: OFBIZ-10344
> URL: https://issues.apache.org/jira/browse/OFBIZ-10344
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10344.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8301) The state dropdown not ordered alphabetically on the create/edit address screen of related components

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8301?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8301:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> The state dropdown not ordered alphabetically on the create/edit address 
> screen of related components
> -
>
> Key: OFBIZ-8301
> URL: https://issues.apache.org/jira/browse/OFBIZ-8301
> Project: OFBiz
>  Issue Type: Bug
>  Components: party
>Affects Versions: Upcoming Branch
>Reporter: Supatthra Nawicha
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: Image2.png, Image4.png, OFBIZ-8301.patch
>
>
> I have found this issue when I try to create a new customer from the party 
> manager. Then I try to select the state of UK but I see the state is not 
> order alphabetically. 
> I have check on the getAssociatedStateList service and it provide the 
> listOrderBy parameter for order the value on the state dropdown but the 
> getDependentDropdownValues function on javascript does not send the 
> listOrderBy parameter to the service. 
> {code:title=framework/common/src/main/java/org/apache/ofbiz/common/CommonWorkers.java|borderStyle=solid}
> public static List getAssociatedStateList(Delegator delegator, 
> String country, String listOrderBy) {
> if (UtilValidate.isEmpty(country)) {
> // Load the system default country
> country = EntityUtilProperties.getPropertyValue("general", 
> "country.geo.id.default", delegator);
> }
> if (UtilValidate.isEmpty(listOrderBy)) {
> listOrderBy = "geoId";
> }
> List sortList = UtilMisc.toList(listOrderBy);
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-8641) Unit test case for service - createPostalAddressAndPurposes

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-8641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-8641:
-
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Unit test case for service - createPostalAddressAndPurposes
> ---
>
> Key: OFBIZ-8641
> URL: https://issues.apache.org/jira/browse/OFBIZ-8641
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: party
>Reporter: Akash Jain
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-8641.patch
>
>
> Unit test case for service - createPostalAddressAndPurposes



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10164) Splitter Widget

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10164:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Splitter Widget
> ---
>
> Key: OFBIZ-10164
> URL: https://issues.apache.org/jira/browse/OFBIZ-10164
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10164.patch, OFBIZ-10164.patch, OFBIZ-10164.patch, 
> horizontal.png, vertical.png
>
>
> A new splitter widget that will use a tag named 'splitter'.
> This splitter tag has the following attributes:
> a. sizes = [25, 75] where the containers within will be splitted with a ratio 
> of 25% and 75%
> b. parentId which is the ID of the parent container
> c. direction = vertical or horizonal (default)
> The splitter tag can only contains container(s) as immediate child.
> Using the library from http://nathancahill.github.io/Split.js/ which is 
> licensed under MIT license.
> Update on 20180128:
> 1) The patch comes with an example where you can view the splitter at 
> https://localhost:8443/catalog/control/main
> 2) No need to add square brackets when defining sizes.
> 3) parentId attribute is removed,



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10346) Refactoring Variable Scope for org.apache.ofbiz.common

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10346:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.common
> --
>
> Key: OFBIZ-10346
> URL: https://issues.apache.org/jira/browse/OFBIZ-10346
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10346.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10345) Refactoring Variable Scope for org.apache.ofbiz.catalina.container

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10345:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.catalina.container
> --
>
> Key: OFBIZ-10345
> URL: https://issues.apache.org/jira/browse/OFBIZ-10345
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10345.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10346) Refactoring Variable Scope for org.apache.ofbiz.common

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10346:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.common
> --
>
> Key: OFBIZ-10346
> URL: https://issues.apache.org/jira/browse/OFBIZ-10346
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10346.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10347:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.datafile
> 
>
> Key: OFBIZ-10347
> URL: https://issues.apache.org/jira/browse/OFBIZ-10347
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10345) Refactoring Variable Scope for org.apache.ofbiz.catalina.container

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10345:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.catalina.container
> --
>
> Key: OFBIZ-10345
> URL: https://issues.apache.org/jira/browse/OFBIZ-10345
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10345.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10347) Refactoring Variable Scope for org.apache.ofbiz.datafile

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10347:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.datafile
> 
>
> Key: OFBIZ-10347
> URL: https://issues.apache.org/jira/browse/OFBIZ-10347
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10347.patch, OFBIZ-10347_updated.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10348) Refactoring Variable Scope for org.apache.ofbiz.entity

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10348:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entity
> --
>
> Key: OFBIZ-10348
> URL: https://issues.apache.org/jira/browse/OFBIZ-10348
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10348_1.patch, OFBIZ-10348_2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10351:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10349) Refactoring Variable Scope for org.apache.ofbiz.entityext

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10349:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entityext
> -
>
> Key: OFBIZ-10349
> URL: https://issues.apache.org/jira/browse/OFBIZ-10349
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10349.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10349) Refactoring Variable Scope for org.apache.ofbiz.entityext

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10349:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entityext
> -
>
> Key: OFBIZ-10349
> URL: https://issues.apache.org/jira/browse/OFBIZ-10349
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10349.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10352) Refactoring Variable Scope for org.apache.ofbiz.minilang

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10352:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.minilang
> 
>
> Key: OFBIZ-10352
> URL: https://issues.apache.org/jira/browse/OFBIZ-10352
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10352.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10352) Refactoring Variable Scope for org.apache.ofbiz.minilang

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10352:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.minilang
> 
>
> Key: OFBIZ-10352
> URL: https://issues.apache.org/jira/browse/OFBIZ-10352
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10352.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10348) Refactoring Variable Scope for org.apache.ofbiz.entity

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10348:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.entity
> --
>
> Key: OFBIZ-10348
> URL: https://issues.apache.org/jira/browse/OFBIZ-10348
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10348_1.patch, OFBIZ-10348_2.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10351:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10358:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10358.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10358) Refactoring Variable Scope for org.apache.ofbiz.base.start

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10358?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10358:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope for org.apache.ofbiz.base.start
> --
>
> Key: OFBIZ-10358
> URL: https://issues.apache.org/jira/browse/OFBIZ-10358
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10358.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10359) Refactoring Variable Scope for org.apache.ofbiz.security

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10359:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope  for org.apache.ofbiz.security
> -
>
> Key: OFBIZ-10359
> URL: https://issues.apache.org/jira/browse/OFBIZ-10359
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10359.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10359) Refactoring Variable Scope for org.apache.ofbiz.security

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10359:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring Variable Scope  for org.apache.ofbiz.security
> -
>
> Key: OFBIZ-10359
> URL: https://issues.apache.org/jira/browse/OFBIZ-10359
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: framework
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10359.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10480:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be 
> done on this package. Not to limit this ticket for only variable/method 
> scoping.
> Please let me know if anyone has any issue and I will revert the update.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10480) Refactoring and Reducing scope of variables in org.apache.ofbiz.common package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10480:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Refactoring and Reducing scope of variables in org.apache.ofbiz.common package
> --
>
> Key: OFBIZ-10480
> URL: https://issues.apache.org/jira/browse/OFBIZ-10480
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Assignee: Girish Vasmatkar
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10480.patch
>
>
> Updated summary of this ticket to include any code refactoring that can be 
> done on this package. Not to limit this ticket for only variable/method 
> scoping.
> Please let me know if anyone has any issue and I will revert the update.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10496:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Defective inventories are valuating in Inventory valuation report 
> --
>
> Key: OFBIZ-10496
> URL: https://issues.apache.org/jira/browse/OFBIZ-10496
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Trunk
>
> Attachments: OFBIZ-10496.patch
>
>
> Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also 
> included in the inventory valuation report.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10481) Reducing scope of variables in org.apache.ofbiz.datafile package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10481:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Reducing scope of variables in org.apache.ofbiz.datafile package
> 
>
> Key: OFBIZ-10481
> URL: https://issues.apache.org/jira/browse/OFBIZ-10481
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10481.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10481) Reducing scope of variables in org.apache.ofbiz.datafile package

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10481:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Reducing scope of variables in org.apache.ofbiz.datafile package
> 
>
> Key: OFBIZ-10481
> URL: https://issues.apache.org/jira/browse/OFBIZ-10481
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Upcoming Branch
>Reporter: Pradhan Yash Sharma
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10481.patch
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10496) Defective inventories are valuating in Inventory valuation report

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10496:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Defective inventories are valuating in Inventory valuation report 
> --
>
> Key: OFBIZ-10496
> URL: https://issues.apache.org/jira/browse/OFBIZ-10496
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Amit Gadaley
>Assignee: Amit Gadaley
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10496.patch
>
>
> Inventory items with status 'INV_NS_DEFECTIVE' and 'INV_DEFECTIVE' are also 
> included in the inventory valuation report.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10630) eCommerce - Return History Feature

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10630:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> eCommerce - Return History Feature
> --
>
> Key: OFBIZ-10630
> URL: https://issues.apache.org/jira/browse/OFBIZ-10630
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Upcoming Branch
>Reporter: Ratnesh Upadhyay
>Assignee: Ratnesh Upadhyay
>Priority: Major
> Fix For: Trunk
>
>
> While walk though the eCommerce application, noticed that we have Order 
> History section there but we don't have Return History. So based upon 
> community's approval we have to add support for "Return History" feature in 
> eCommerce application.
>  Items needs to be implemented under this ticket : 
>  - Add new navigation for return history.
>  - Display list of returns submitted by the customer along with basic details.
>  - Customer should be able to view return details by clicking upon view link 
> OR returnID.
>   
>  Thanks to all the members for the discussion and approval.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11039) add a chapter "About this documentation"

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11039:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> add a chapter "About this documentation"
> 
>
> Key: OFBIZ-11039
> URL: https://issues.apache.org/jira/browse/OFBIZ-11039
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
> Fix For: Trunk
>
> Attachments: Employee_Main_Screen.png, 
> HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, 
> HR_Application_Submenu_Rainbow_Stone.png, 
> HR_Application_Submenu_Tomahawk.png, 
> OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch, 
> hr-about-doc.adoc
>
>
> This chapter present the main OFBiz GUI rules with some screenshot and link 
> between tutorial and video of "Scenario GUI Test"
> Currently it's in HR, but when other application will be done it can be 
> generalize and go to User Manual introduction.
> The file hr-about-doc.adoc associated with this task is included via a 
> include:: line in the humanres.adoc



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10630) eCommerce - Return History Feature

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10630:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> eCommerce - Return History Feature
> --
>
> Key: OFBIZ-10630
> URL: https://issues.apache.org/jira/browse/OFBIZ-10630
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ecommerce
>Affects Versions: Upcoming Branch
>Reporter: Ratnesh Upadhyay
>Assignee: Ratnesh Upadhyay
>Priority: Major
> Fix For: Upcoming Branch
>
>
> While walk though the eCommerce application, noticed that we have Order 
> History section there but we don't have Return History. So based upon 
> community's approval we have to add support for "Return History" feature in 
> eCommerce application.
>  Items needs to be implemented under this ticket : 
>  - Add new navigation for return history.
>  - Display list of returns submitted by the customer along with basic details.
>  - Customer should be able to view return details by clicking upon view link 
> OR returnID.
>   
>  Thanks to all the members for the discussion and approval.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-10976) Unable to add product to cart when user enter detail in Tell-A-Friend link.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10976?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-10976:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Unable to add product to cart when user enter detail in Tell-A-Friend link.
> ---
>
> Key: OFBIZ-10976
> URL: https://issues.apache.org/jira/browse/OFBIZ-10976
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Reporter: Ashish Sharma
>Assignee: Swapnil Mane
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10976.patch, OFBIZ-10976.png
>
>
> *Step to reproduce*
> 1. Login with valid username and password.
> 2. Navigate to ecommerce.
> 3. Select a product and click on link Tell-A-Friend.
> 4. Enter detail in Tell-A-Friend window.
> 5. Click on link add to cart link.
> *Actual Result:* Error message is displayed as "Tell a friend sorry".
> *Screen print attached*
> *Note - Email validation is not added in Tell-A-Friend window.*



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11039) add a chapter "About this documentation"

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11039:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> add a chapter "About this documentation"
> 
>
> Key: OFBIZ-11039
> URL: https://issues.apache.org/jira/browse/OFBIZ-11039
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Employee_Main_Screen.png, 
> HR-Employee_Submenu_Rainbow_Stone.png, HR-Employee_Submenu_Tomahawk.png, 
> HR_Application_Submenu_Rainbow_Stone.png, 
> HR_Application_Submenu_Tomahawk.png, 
> OFBIZ-11039_Documented-add-a-chapter-About-this-documentation-in.patch, 
> hr-about-doc.adoc
>
>
> This chapter present the main OFBiz GUI rules with some screenshot and link 
> between tutorial and video of "Scenario GUI Test"
> Currently it's in HR, but when other application will be done it can be 
> generalize and go to User Manual introduction.
> The file hr-about-doc.adoc associated with this task is included via a 
> include:: line in the humanres.adoc



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11042) Allow to choose salaryStepSeqId when create a SalaryStep

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11042:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Allow to choose salaryStepSeqId when create a SalaryStep
> 
>
> Key: OFBIZ-11042
> URL: https://issues.apache.org/jira/browse/OFBIZ-11042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11042.patch
>
>
> Comming from "The Data model Resource Book"
> {{«}} Salary Grade-Step are used in entreprise that have a predefined, highly 
> structure pay system (such as the federal government). This is done by 
> reference to a structure pay schedule.{{»}}
> Currently in OFBiz in HR in Global HR Settings, it's possible to choose 
> gradeId but not stepSeqId and so it's not readable when you want select a 
> Grade-Step for a EmployeePositionType or a Employment / PayHistory because 
> it's not same as legal "Structure Pay Schedule" (like "Convention collective, 
> salaire minimum par position" in France).
> In patch propose, add a field in form and in create service use it if not 
> empty



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11042) Allow to choose salaryStepSeqId when create a SalaryStep

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11042:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Allow to choose salaryStepSeqId when create a SalaryStep
> 
>
> Key: OFBIZ-11042
> URL: https://issues.apache.org/jira/browse/OFBIZ-11042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Trunk
>
> Attachments: OFBIZ-11042.patch
>
>
> Comming from "The Data model Resource Book"
> {{«}} Salary Grade-Step are used in entreprise that have a predefined, highly 
> structure pay system (such as the federal government). This is done by 
> reference to a structure pay schedule.{{»}}
> Currently in OFBiz in HR in Global HR Settings, it's possible to choose 
> gradeId but not stepSeqId and so it's not readable when you want select a 
> Grade-Step for a EmployeePositionType or a Employment / PayHistory because 
> it's not same as legal "Structure Pay Schedule" (like "Convention collective, 
> salaire minimum par position" in France).
> In patch propose, add a field in form and in create service use it if not 
> empty



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11044) EmplPositionType Rate and Grade better User interface

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11044:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> EmplPositionType Rate and Grade better User interface
> -
>
> Key: OFBIZ-11044
> URL: https://issues.apache.org/jira/browse/OFBIZ-11044
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: humanres
> Fix For: Upcoming Branch
>
> Attachments: 
> 0001-Improved-EmplPositionType-Rate-and-Grade-better-User.patch, 
> OFBIZ-11044.patch
>
>
> EmplPositionType can be associated with a Rate or a Grade-Step, look to 
> [Position Type - User 
> Manual|[https://ofbizextra.org/ofbizextra_adocs/docs/asciidoc/user-manual.html#_position_types].]
> Currently Rate and Grade-Step are on the same Form, I propose to split in two 
> form, one for Rate and one for Grade-Step.
> Sub enhancement, Grade and Step lookup don't work, corrections for this are 
> included



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11044) EmplPositionType Rate and Grade better User interface

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11044:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> EmplPositionType Rate and Grade better User interface
> -
>
> Key: OFBIZ-11044
> URL: https://issues.apache.org/jira/browse/OFBIZ-11044
> Project: OFBiz
>  Issue Type: Improvement
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Minor
>  Labels: humanres
> Fix For: Trunk
>
> Attachments: 
> 0001-Improved-EmplPositionType-Rate-and-Grade-better-User.patch, 
> OFBIZ-11044.patch
>
>
> EmplPositionType can be associated with a Rate or a Grade-Step, look to 
> [Position Type - User 
> Manual|[https://ofbizextra.org/ofbizextra_adocs/docs/asciidoc/user-manual.html#_position_types].]
> Currently Rate and Grade-Step are on the same Form, I propose to split in two 
> form, one for Rate and one for Grade-Step.
> Sub enhancement, Grade and Step lookup don't work, corrections for this are 
> included



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11046) add a HR Data model chapter

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11046:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> add a HR Data model chapter
> ---
>
> Key: OFBIZ-11046
> URL: https://issues.apache.org/jira/browse/OFBIZ-11046
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Trunk
>
> Attachments: EmplPosition.png, EmplPositionDetail.png, 
> Employment.png, EmploymentApp.png, OFBIZ_11046_humanres.adoc.patch, 
> PartyHumanRes.png, PerfReview.png, ability.png, hr-data-model.adoc
>
>
> Add some UML diagram about main HR entities.
> Each diagram contain not all associated entities but only one important to 
> have a first understanding about the main entity of the diagram.
> In the doc, each diagram is associated with some link to others diagram to 
> easily naviguate.
> This chapter could be included in hr-documentation just before hr-glossary



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11046) add a HR Data model chapter

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11046:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> add a HR Data model chapter
> ---
>
> Key: OFBIZ-11046
> URL: https://issues.apache.org/jira/browse/OFBIZ-11046
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: humanres
>Affects Versions: Upcoming Branch
>Reporter: Olivier Heintz
>Priority: Major
>  Labels: humanres
> Fix For: Upcoming Branch
>
> Attachments: EmplPosition.png, EmplPositionDetail.png, 
> Employment.png, EmploymentApp.png, OFBIZ_11046_humanres.adoc.patch, 
> PartyHumanRes.png, PerfReview.png, ability.png, hr-data-model.adoc
>
>
> Add some UML diagram about main HR entities.
> Each diagram contain not all associated entities but only one important to 
> have a first understanding about the main entity of the diagram.
> In the doc, each diagram is associated with some link to others diagram to 
> easily naviguate.
> This chapter could be included in hr-documentation just before hr-glossary



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11222) Wrong heading on creating quote under Accounting-AP component.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11222:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Wrong heading on creating quote under Accounting-AP component.
> --
>
> Key: OFBIZ-11222
> URL: https://issues.apache.org/jira/browse/OFBIZ-11222
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pradyum Dharwa
>Assignee: Aditya Sharma
>Priority: Trivial
>  Labels: agreement(s)
> Fix For: Upcoming Branch
>
> Attachments: Accounting-ap.png, OFBIZ-11222.patch
>
>
> Steps to re-generate
>  # Logging with the correct username and password.
>  # Click on the Accounting Section.
>  # Click on Agreements section.
>  # Click on create new
> Error: Edit quote is shown on the place of edit quote/new quote .
> Actual: edit quote/new quote  should be shown on the place of edit quote



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11222) Wrong heading on creating quote under Accounting-AP component.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11222:
--
Affects Version/s: Upcoming Branch

> Wrong heading on creating quote under Accounting-AP component.
> --
>
> Key: OFBIZ-11222
> URL: https://issues.apache.org/jira/browse/OFBIZ-11222
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch, Trunk
>Reporter: Pradyum Dharwa
>Assignee: Aditya Sharma
>Priority: Trivial
>  Labels: agreement(s)
> Fix For: Trunk
>
> Attachments: Accounting-ap.png, OFBIZ-11222.patch
>
>
> Steps to re-generate
>  # Logging with the correct username and password.
>  # Click on the Accounting Section.
>  # Click on Agreements section.
>  # Click on create new
> Error: Edit quote is shown on the place of edit quote/new quote .
> Actual: edit quote/new quote  should be shown on the place of edit quote



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-11222) Wrong heading on creating quote under Accounting-AP component.

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-11222:
--
Affects Version/s: (was: Trunk)

> Wrong heading on creating quote under Accounting-AP component.
> --
>
> Key: OFBIZ-11222
> URL: https://issues.apache.org/jira/browse/OFBIZ-11222
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Upcoming Branch
>Reporter: Pradyum Dharwa
>Assignee: Aditya Sharma
>Priority: Trivial
>  Labels: agreement(s)
> Fix For: Trunk
>
> Attachments: Accounting-ap.png, OFBIZ-11222.patch
>
>
> Steps to re-generate
>  # Logging with the correct username and password.
>  # Click on the Accounting Section.
>  # Click on Agreements section.
>  # Click on create new
> Error: Edit quote is shown on the place of edit quote/new quote .
> Actual: edit quote/new quote  should be shown on the place of edit quote



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12244) Code clarity - separate Groovy implementations vs test cases in org.apache.ofbiz.order

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12244:
--
Affects Version/s: Upcoming Branch
   (was: Trunk)

> Code clarity - separate Groovy implementations vs test cases in 
> org.apache.ofbiz.order
> --
>
> Key: OFBIZ-12244
> URL: https://issues.apache.org/jira/browse/OFBIZ-12244
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: Carsten Schinzer
>Assignee: Carsten Schinzer
>Priority: Minor
>  Labels: test
> Fix For: Upcoming Branch
>
> Attachments: ofbiz-12244.patch
>
>
> 1. File move:
> 1.a Create package org.apache.ofbiz.order.test in path 
> ofbiz-framework/applications/order/src/main
> 1.b Move the following files to the new package:
>  * OrderRequirementTests
>  * OrderReturnTests
>  * OrderTests
>  * QuoteTests
>  * TestCustRequestPermissionCheck
> 2. Apply attached patch



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (OFBIZ-12244) Code clarity - separate Groovy implementations vs test cases in org.apache.ofbiz.order

2021-12-17 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12244:
--
Fix Version/s: Upcoming Branch
   (was: Trunk)

> Code clarity - separate Groovy implementations vs test cases in 
> org.apache.ofbiz.order
> --
>
> Key: OFBIZ-12244
> URL: https://issues.apache.org/jira/browse/OFBIZ-12244
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Carsten Schinzer
>Assignee: Carsten Schinzer
>Priority: Minor
>  Labels: test
> Fix For: Upcoming Branch
>
> Attachments: ofbiz-12244.patch
>
>
> 1. File move:
> 1.a Create package org.apache.ofbiz.order.test in path 
> ofbiz-framework/applications/order/src/main
> 1.b Move the following files to the new package:
>  * OrderRequirementTests
>  * OrderReturnTests
>  * OrderTests
>  * QuoteTests
>  * TestCustRequestPermissionCheck
> 2. Apply attached patch



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12371) BudgetRole: improbable selection possible, PartyRole gets created

2021-11-09 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17441272#comment-17441272
 ] 

Jacopo Cappellato commented on OFBIZ-12371:
---

There are pros and cons, or rather scenarios that are facilitated by one 
approach and made more difficult by the other, to both ways of interpreting 
PartyRole records.

The current approach, implemented in many ootb applications, as [~mbrohl] has 
pointed out, is to interpret the PartyRole records as all the roles the party 
{*}actually plays{*}.

The other approach, that is the one advocated by [~pierresmits], is to 
interpret the PartyRole records as the roles the party {*}can play{*}.

 

> BudgetRole: improbable selection possible, PartyRole gets created
> -
>
> Key: OFBIZ-12371
> URL: https://issues.apache.org/jira/browse/OFBIZ-12371
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Affects Versions: Trunk, 18.12.01
>Reporter: Pierre Smits
>Assignee: Pierre Smits
>Priority: Major
>  Labels: roles
>
> On the BudgetRole page (see 
> [https://demo-stable.ofbiz.apache.org/accounting/control/BudgetRoles?budgetId=DemoBudget001)]
>  an improbable combination of Party and Role can be set and submitted. 
> Leading to PartyRole record being created.
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-10113) Replace Asm select plugin with Select2.

2021-10-29 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-10113.
-
Resolution: Fixed

> Replace Asm select plugin with Select2.
> ---
>
> Key: OFBIZ-10113
> URL: https://issues.apache.org/jira/browse/OFBIZ-10113
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Major
> Fix For: 18.12.01
>
> Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, 
> OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, select2.tar.gz
>
>
> Current Asm Select Plugin 
> (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced 
> with Select2 (https://select2.org/).
> * Select2 has much better community support on GitHub with 386 contributors 
> while Asm Select Plugin is handled by Ryan Cramer on 
> http://www.ryancramer.com/.
> * Select2 has 37 releases while Asm select has very few releases yet.
> * Both the plugin has MIT license.
> Refer https://select2.org/ and  https://github.com/select2/select2 for more 
> features and other information.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11993) display/selection of unit of measure is broken/plugins

2021-10-29 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-11993.
-
Resolution: Fixed

> display/selection of unit of measure is broken/plugins
> --
>
> Key: OFBIZ-11993
> URL: https://issues.apache.org/jira/browse/OFBIZ-11993
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 17.12, Trunk
>Reporter: Alex Bodnaru
>Priority: Major
>  Labels: patch
> Fix For: 18.12.01
>
> Attachments: p-variantinfojs-1.patch, p-variantinfojs-2.patch, 
> p-variantinfojs-clean1.patch, p-variantinfojs-final.patch
>
>
> allow selection of uom for multiple products on the same web page



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11215) Email password is not working

2021-10-29 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato closed OFBIZ-11215.
-
Resolution: Fixed

> Email password is not working
> -
>
> Key: OFBIZ-11215
> URL: https://issues.apache.org/jira/browse/OFBIZ-11215
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 16.11, 17.12.03
>Reporter: Rashi Dhagat
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01
>
>
> Steps to regenerate:
>  # User should be on the login page 
> [https://demo-stable.ofbiz.apache.org/ecommerce/control/login]
>  # Enter username
>  # Click on email password
> Actual: Email is not received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-19 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12171:
--
Fix Version/s: (was: 17.12.06)

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-19 Thread Jacopo Cappellato (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacopo Cappellato updated OFBIZ-12171:
--
Affects Version/s: (was: 17.12.05)

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12192) Replace Bintray by a new place to upload the Gradle Wrapper

2021-03-13 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300923#comment-17300923
 ] 

Jacopo Cappellato commented on OFBIZ-12192:
---

[~mbrohl] I have tested your changes for 17.12 on my Mac and they work great, 
thank you.

Should I proceed with the release preparation or we need more time to test the 
Windows scripts?

> Replace Bintray by a new place to upload the Gradle Wrapper
> ---
>
> Key: OFBIZ-12192
> URL: https://issues.apache.org/jira/browse/OFBIZ-12192
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 18.12.01, Trunk, 17.12.06
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Blocker
> Fix For: 18.12.01, Release Branch 17.12, Upcoming Branch
>
>
> We got an issue with Bintray and jcenter : 
> [https://markmail.org/message/hal4od7xeoig6xfw]
> The jcenter aspect is now fixed with OFBIZ-12171 (actually jcenter will allow 
> download until February 1st 2022)
> With our need to upload the Gradle Wrapper we have though still an issue with 
> Bintray: [https://markmail.org/message/74u6wsldx3ykzqiv]
> The problem is once we release a package the scripts at 
> [https://github.com/apache/ofbiz-framework/tree/trunk/gradle] are freezed. So 
> people using these scripts will not be able to download the related Gradle 
> Wrapper versions.
> So we need to replace Bintray by another place to upload the different 
> versions of the Gradle Wrapper. All supported OFBiz versions are concerned.
> Note: I have already put  
> [https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray]
>  in Wiki Attic 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12192) Replace Bintray by a new place to upload the Gradle Wrapper

2021-03-12 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300432#comment-17300432
 ] 

Jacopo Cappellato commented on OFBIZ-12192:
---

One solution for 17.12 that seems to work is to modify init-wrapper.sh to get 
the release 4.5.1 of the wrapper jar from GitHub's Gradle; the script should 
not grab the properties file because the one from GitHub contains an URL that 
doesn't work; instead we should just keep the properties file we already have 
in our repo (that already references 4.5.1)

> Replace Bintray by a new place to upload the Gradle Wrapper
> ---
>
> Key: OFBIZ-12192
> URL: https://issues.apache.org/jira/browse/OFBIZ-12192
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 18.12.01, Trunk, 17.12.06
>Reporter: Jacques Le Roux
>Priority: Blocker
>
> We got an issue with Bintray and jcenter : 
> [https://markmail.org/message/hal4od7xeoig6xfw]
> The jcenter aspect is now fixed with OFBIZ-12171 (actually jcenter will allow 
> download until February 1st 2022)
> With our need to upload the Gradle Wrapper we have though still an issue with 
> Bintray: [https://markmail.org/message/74u6wsldx3ykzqiv]
> The problem is once we release a package the scripts at 
> [https://github.com/apache/ofbiz-framework/tree/trunk/gradle] are freezed. So 
> people using these scripts will not be able to download the related Gradle 
> Wrapper versions.
> So we need to replace Bintray by another place to upload the different 
> versions of the Gradle Wrapper. All supported OFBiz versions are concerned.
> Note: I have already put  
> [https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray]
>  in Wiki Attic 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12192) Replace Bintray by a new place to upload the Gradle Wrapper

2021-03-12 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300287#comment-17300287
 ] 

Jacopo Cappellato commented on OFBIZ-12192:
---

[~jleroux] : I don't think that downloading from GitHub should concern Legal; 
the only issue may be related to infra (e.g. scalability issue if number of 
downloads is too large for GitHub), but for 17.12 we should be fine.

 

[~mbrohl] : I am also testing the init script with the backup url and I am 
facing some issues that I am trying to address (in my free time); we can sync 
up here if needed

> Replace Bintray by a new place to upload the Gradle Wrapper
> ---
>
> Key: OFBIZ-12192
> URL: https://issues.apache.org/jira/browse/OFBIZ-12192
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 18.12.01, Trunk, 17.12.06
>Reporter: Jacques Le Roux
>Priority: Blocker
>
> We got an issue with Bintray and jcenter : 
> [https://markmail.org/message/hal4od7xeoig6xfw]
> The jcenter aspect is now fixed with OFBIZ-12171 (actually jcenter will allow 
> download until February 1st 2022)
> With our need to upload the Gradle Wrapper we have though still an issue with 
> Bintray: [https://markmail.org/message/74u6wsldx3ykzqiv]
> The problem is once we release a package the scripts at 
> [https://github.com/apache/ofbiz-framework/tree/trunk/gradle] are freezed. So 
> people using these scripts will not be able to download the related Gradle 
> Wrapper versions.
> So we need to replace Bintray by another place to upload the different 
> versions of the Gradle Wrapper. All supported OFBiz versions are concerned.
> Note: I have already put  
> [https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray]
>  in Wiki Attic 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12192) Replace Bintray by a new place to upload the Gradle Wrapper

2021-03-12 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300244#comment-17300244
 ] 

Jacopo Cappellato commented on OFBIZ-12192:
---

The init-gradle-wrapper.sh (*nix version) already supports the download (as a 
backup url) from gradle on github (see variable GRADLE_WRAPPER_URI_BACKUP)

If it works, we could just leave with it at least in the old release branch 
17.12

 

> Replace Bintray by a new place to upload the Gradle Wrapper
> ---
>
> Key: OFBIZ-12192
> URL: https://issues.apache.org/jira/browse/OFBIZ-12192
> Project: OFBiz
>  Issue Type: Task
>  Components: Gradle
>Affects Versions: 18.12.01, Trunk, 17.12.06
>Reporter: Jacques Le Roux
>Priority: Blocker
>
> We got an issue with Bintray and jcenter : 
> [https://markmail.org/message/hal4od7xeoig6xfw]
> The jcenter aspect is now fixed with OFBIZ-12171 (actually jcenter will allow 
> download until February 1st 2022)
> With our need to upload the Gradle Wrapper we have though still an issue with 
> Bintray: [https://markmail.org/message/74u6wsldx3ykzqiv]
> The problem is once we release a package the scripts at 
> [https://github.com/apache/ofbiz-framework/tree/trunk/gradle] are freezed. So 
> people using these scripts will not be able to download the related Gradle 
> Wrapper versions.
> So we need to replace Bintray by another place to upload the different 
> versions of the Gradle Wrapper. All supported OFBiz versions are concerned.
> Note: I have already put  
> [https://cwiki.apache.org/confluence/display/OFBIZ/Load+new+gradle+wrapper+version+on+bintray]
>  in Wiki Attic 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12171) Handling the JCenter shutdown

2021-03-12 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300220#comment-17300220
 ] 

Jacopo Cappellato commented on OFBIZ-12171:
---

Hi [~mbrohl],

and thanks for all the work! I am preparing the release files for 17.12.06 and 
testing the build process for 17.12 and I am finding some issues introduced 
with 
[https://github.com/apache/ofbiz-framework/commit/d6c6330b390a96bdf6a7d65573117b693455c685]

The problem is that, in the release files, we have to remove the jar file in 
gradle/wrapper; at build time, as described in the README file, the jar file is 
downloaded using the script gradle/init-gradle-wrapper

This script actually downloads the jar file and the properties file from 

[https://dl.bintray.com/apacheofbiz/GradleWrapper/]

Currently in init-gradle-wrapper we still have the version 3.2.1; we should 
also update (I guess) the new properties file to bintray.

I may find other issues (I am still testing) but for now I ma reporting the one 
above.

 

 

> Handling the JCenter shutdown
> -
>
> Key: OFBIZ-12171
> URL: https://issues.apache.org/jira/browse/OFBIZ-12171
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Major
>  Labels: backport-needed
> Fix For: 18.12.01, Upcoming Branch, 17.12.06
>
> Attachments: OFBIZ-12171-1712-README.patch
>
>
> Citing Taher's message at [2]:
> Hello Everyone, 
>  
> I received emails and checked resources [1] that seem to confirm JCenter from 
> JFrog is going down and that the last day of operation for the repository is 
> going to be May 1st 2021. 
>  
> This is a big deal as many running instances will crash unless updated, so 
> not only do future versions of OFBiz need to adapt, but also existing 
> installations. 
>  
> I'm not sure how to best handle this? Especially for production instances out 
> there on older versions of OFBiz. Maybe one solution is to host the existing 
> libraries in some temporary location or try to migrate them to MavenCentral 
> ... Whatever is the solution I think we should make a fast move. 
>  
> [1] 
> [https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter]
>  
> [https://www.infoq.com/news/2021/02/jfrog-jcenter-bintray-closure]
> [2] 
> [https://lists.apache.org/thread.html/rf8e883ca8b90d51ad9d6d48c46f8f1fcc1cb82cce802daeeab0b910a%40%3Cdev.ofbiz.apache.org%3E]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12191) Bug preventing proper explosion of BOM containing virtual nodes

2021-03-02 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293518#comment-17293518
 ] 

Jacopo Cappellato commented on OFBIZ-12191:
---

thank you Nameet, I have faced the same issue and your fix resolves it, good 
catch!

> Bug preventing proper explosion of BOM containing virtual nodes
> ---
>
> Key: OFBIZ-12191
> URL: https://issues.apache.org/jira/browse/OFBIZ-12191
> Project: OFBiz
>  Issue Type: Bug
>  Components: manufacturing
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Priority: Major
> Attachments: OFBIZ-12191.patch, OFBIZ-12191_sample-data.xml, 
> image-2021-02-27-18-37-47-422.png
>
>
> I tried the following use case. We configured BOM for the virtual product 
> whose nodes can also be virtual.
>  
> {code:java}
> // Product To Be produced
> PROD_MANUF_1 (Virtual Product)
>  - PROD_MANUF_11 (Variant)
>  - PROD_MANUF_12 (Variant)
>  
> // Raw Material
> RAW_MAT_1 (Virtual)
>  - RAW_MAT_11 (Variant)
>  - RAW_MAT_12 (Variant)
>  
> RAW_MAT_2 (Standard)
> // BOM
> PROD_MANUF_1-> RAW_MAT_1
> -> RAW_MAT_2
> PROD_MANUF_11   -> RAW_MAT_11  -> 2 Qty
> -> RAW_MAT_2   -> 2 Qty
>  
>  
> PROD_MANUF_12   -> RAW_MAT_12  -> 3 Qty
> -> RAW_MAT_2   -> 2 Qty {code}
> Now let say we want to manufacture 10qty of PROD_MANUF_12. To my 
> expectations, the requirement generated should be like
>  - To produce 10qty for PROD_MANUF_12 we will need
>        - 30qty of RAW_MAT_12
>        - 20qty of RAW_MAT_2
> But the result for MRP and BOM simulation is incorrect. Please refer to the 
> screenshot.
> !image-2021-02-27-18-37-47-422.png!
> _I am also attaching sample data to test._



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script

2021-02-08 Thread Jacopo Cappellato (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281601#comment-17281601
 ] 

Jacopo Cappellato commented on OFBIZ-12173:
---

I confirm the reported error (I could recreate it) and also the fix looks good. 
Thanks

> Visit disabling causes NullPointerException on ecomm groovy script
> --
>
> Key: OFBIZ-12173
> URL: https://issues.apache.org/jira/browse/OFBIZ-12173
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Release Branch 18.12, Trunk, 17.12.05
> Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Blocker
>  Labels: visit
> Attachments: 
> OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, 
> newcustomer_error.jpg
>
>
> Disable tracking of Visits and Visitors, setting false the value of 
> stats.persist.visit stats.persist.visitor in serverstats.properties file, 
> causes a NullPointerException in the groovy script 
> ecommerce/groovyScript/customer/NewCustomer.groovy.
>  Attached here below a screenshot of the error.
> !newcustomer_error.jpg!
> This error also afflicts older version of OFBiz (the screenshot is taken from 
> an ecommerce site running on OFBiz 13.07.03)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   >