[jira] [Commented] (OFBIZ-12390) Order/Invoice: Item total result diff total result

2022-09-16 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17606027#comment-17606027
 ] 

James Yong commented on OFBIZ-12390:


I think it will be better solved by adding an adjustment at invoice item level. 

> Order/Invoice: Item total result diff total result
> --
>
> Key: OFBIZ-12390
> URL: https://issues.apache.org/jira/browse/OFBIZ-12390
> Project: OFBiz
>  Issue Type: Improvement
>  Components: accounting, order
>Affects Versions: Trunk, 17.12.08, 18.12.01, Upcoming Branch
>Reporter: Ingo Wolfmayr
>Assignee: Jacques Le Roux
>Priority: Major
> Attachments: Orders.xml, cartRounding.patch, 
> image-2021-11-19-09-44-18-759.png, image-2021-11-19-09-44-44-443.png, 
> image-2021-11-19-09-59-07-571.png, image-2022-09-16-16-43-38-897.png, 
> pricecheckData-1.xml
>
>
> In some cases the order total is not correct:
> net price: €1.273
> 10% sales tax: € 0.127
> quantity: 1
> grand total: € 1.40
> Now taking the same product and adding it with two order lines:
> grand total: € 2.79
> Right now the grand total is calculated by total all item net prices, total 
> all adjustments and finally adding those two values together.
> The following screenshots are taken from the orderview. Ofbiz request a 
> payment of € 2.80 but will create an invoice with a grand total of € 2.79.
> !image-2021-11-19-09-44-18-759.png!
> !image-2021-11-19-09-44-44-443.png!
> Heres the result with just one orderline:
> !image-2021-11-19-09-59-07-571.png!
>  
> I have created a XML file for testing.  Import the file via XML import and 
> create an order:
> partyId: AUT_CUSTOMER
> productStore: Test GmbH
> product 1: AUT_PRODUCT (quantity 1)
> product 1: AUT_PRODUCT_CP (quantity 1)
> Checkout with default settings.
> From my perspective the calculation should be changed to calculate the total 
> amount for each line and calculate the grand total from these results.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (OFBIZ-11996) Well-formed html in ftl template

2022-01-05 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-11996.
--
Resolution: Fixed

> Well-formed html in ftl template
> 
>
> Key: OFBIZ-11996
> URL: https://issues.apache.org/jira/browse/OFBIZ-11996
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11996.patch
>
>
> Check for well-formed html in ftl templates to catch programming errors.
> To test, set print.verbose=true and start up ofbiz.
>  Misformed HTML fragments are logged as warnings.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (OFBIZ-12460) Unable to build in M1 Mac

2021-12-19 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12460.
--
Resolution: Fixed

> Unable to build in M1 Mac
> -
>
> Key: OFBIZ-12460
> URL: https://issues.apache.org/jira/browse/OFBIZ-12460
> Project: OFBiz
>  Issue Type: Bug
>  Components: themes
>Affects Versions: Upcoming Branch
> Environment: Apple Mac: M1 processor
> Java version:
> Ofbiz release/branche
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
>  Labels: build-failure
> Fix For: Upcoming Branch
>
>
> Following error occurs when building in M1 Mac
> {code:java}
> Could not determine the dependencies of task ':nodeSetup'.
> > Failed to query the value of task ':nodeSetup' property 'nodeArchiveFile'.
>> Could not resolve all files for configuration ':detachedConfiguration1'.
>   > Could not find node-12.18.1-darwin-arm64.tar.gz 
> (org.nodejs:node:12.18.1).
> Searched in the following locations:
> https://nodejs.org/dist/v12.18.1/node-v12.18.1-darwin-arm64.tar.gz
> {code}
> Need to upgrade Node.js version from 12.x.x to 16.x.x as 16.x.x has support 
> for M1 Mac.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Created] (OFBIZ-12460) Unable to build in M1 Mac

2021-12-15 Thread James Yong (Jira)
James Yong created OFBIZ-12460:
--

 Summary: Unable to build in M1 Mac
 Key: OFBIZ-12460
 URL: https://issues.apache.org/jira/browse/OFBIZ-12460
 Project: OFBiz
  Issue Type: Bug
  Components: themes
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Following error occurs when building in M1 Mac
{code:java}
Could not determine the dependencies of task ':nodeSetup'.
> Failed to query the value of task ':nodeSetup' property 'nodeArchiveFile'.
   > Could not resolve all files for configuration ':detachedConfiguration1'.
  > Could not find node-12.18.1-darwin-arm64.tar.gz 
(org.nodejs:node:12.18.1).
Searched in the following locations:
https://nodejs.org/dist/v12.18.1/node-v12.18.1-darwin-arm64.tar.gz
{code}

Need to upgrade Node.js version from 12.x.x to 16.x.x as 16.x.x has support for 
M1 Mac.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (OFBIZ-12064) Load language js for date.js only when required

2021-03-17 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17303371#comment-17303371
 ] 

James Yong commented on OFBIZ-12064:


Hi Jacques,

The datetime picker depends on 
themes/common-themes/webapp/common/js/jquery/plugins/datejs.

Not sure about OFBIZ-11684

 

Regards,
 James

> Load language js for date.js only when required 
> 
>
> Key: OFBIZ-12064
> URL: https://issues.apache.org/jira/browse/OFBIZ-12064
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12064.patch
>
>
> Only load language js for Date.js when there is a date time picker in the 
> page. The library is located at 
> themes/common-themes/webapp/common/js/jquery/plugins/datejs.
> Discussion started at 
> https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12148) Display last-visited-time popup after login

2021-02-21 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287981#comment-17287981
 ] 

James Yong commented on OFBIZ-12148:


Hi Jacques,

Good points on afterlogin.lastvisit.show. 

Regarding the empty popup. Sometimes, the javascript from the unsafe message 
runs slower / longer. So can try to increase the setTimeout value in 
Messages.ftl.

Please help with the necessary changes in the repository.

Thanks,
James


> Display last-visited-time popup after login
> ---
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148, OFBIZ-12148.patch
>
>
> Popup last-visited time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-02-14 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284440#comment-17284440
 ] 

James Yong commented on OFBIZ-10351:


Hi Michael,

I haven't started on the suggestions from Jacques & Taher. 

For my use-case, I wanted the call graph to include services that are 
programmatically called from groovy, simple method or java codes during a 
request.

Understand the call graph is only used during development and will be turned 
off in production. If there is performance concern, I will not continue with 
this JIRA issue then.






> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-02-14 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284420#comment-17284420
 ] 

James Yong commented on OFBIZ-10351:


Updated the patch to include async, SECA, EECA and MCA

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-02-14 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-10351:
---
Attachment: OFBIZ-10351.patch

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-02-13 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284220#comment-17284220
 ] 

James Yong commented on OFBIZ-10351:


Uploaded another patch as some files not included in previous patch

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-02-13 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-10351:
---
Attachment: OFBIZ-10351.patch

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch, 
> OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-02-08 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281074#comment-17281074
 ] 

James Yong commented on OFBIZ-10351:


Updated the patch so that it can be applied to trunk version. Will look into 
the feedback.

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10351) Tree View of Call Graph for Services and Simple Methods

2021-02-08 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-10351:
---
Attachment: OFBIZ-10351.patch

> Tree View of Call Graph for Services and Simple Methods
> ---
>
> Key: OFBIZ-10351
> URL: https://issues.apache.org/jira/browse/OFBIZ-10351
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Trunk
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10351.patch, OFBIZ-10351.patch, OFBIZ-10351.patch
>
>
> Option to log a tree view of services and simple methods, and events that are 
> called in a request. 
> Some discussion at 
> https://lists.apache.org/thread.html/079455a596056334265ecbd410b4de13b6e61e1449ac258af5e9679b@%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12148) Display last-visited-time popup after login

2021-02-06 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280206#comment-17280206
 ] 

James Yong commented on OFBIZ-12148:


Hi Michael,

Thanks for the review.
Agree with the points made. 
I have amended with another commit.

> Display last-visited-time popup after login
> ---
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148, OFBIZ-12148.patch
>
>
> Popup last-visited time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12148) Display last-visited-time popup after login

2021-02-05 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17279702#comment-17279702
 ] 

James Yong commented on OFBIZ-12148:


Added the pull request in github.

> Display last-visited-time popup after login
> ---
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148, OFBIZ-12148.patch
>
>
> Popup last-visited time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12148) Display last-visited-time popup after login

2021-02-05 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12148:
---
Description: 
Popup last-visited time from database after user has logged in.

So users can know of any unauthorised access to their accounts.

 

  was:
Popup last-logged-in time from database after user has logged in.

So users can know of any unauthorised access to their accounts.

 


> Display last-visited-time popup after login
> ---
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148, OFBIZ-12148.patch
>
>
> Popup last-visited time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12148) Display last-visited-time popup after login

2021-02-05 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12148:
---
Summary: Display last-visited-time popup after login  (was: Display 
last-logged-in-time popup after login)

> Display last-visited-time popup after login
> ---
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148, OFBIZ-12148.patch
>
>
> Popup last-logged-in time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12148) Display last-logged-in-time popup after login

2021-02-04 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278901#comment-17278901
 ] 

James Yong commented on OFBIZ-12148:


Hi Michael,

Will try to do it this weekend.

> Display last-logged-in-time popup after login
> -
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148, OFBIZ-12148.patch
>
>
> Popup last-logged-in time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12148) Display last-logged-in-time popup after login

2021-02-04 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12148:
---
Attachment: OFBIZ-12148.patch

> Display last-logged-in-time popup after login
> -
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148, OFBIZ-12148.patch
>
>
> Popup last-logged-in time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12147) Allow Unsafe Event Message

2021-02-04 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12147.
--
Resolution: Fixed

> Allow Unsafe Event Message
> --
>
> Key: OFBIZ-12147
> URL: https://issues.apache.org/jira/browse/OFBIZ-12147
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute 
> "__EVENT_MESSAGE__".
>  Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for 
> messages that can contain inline javascript.
> One use case is to allow us to display last login timestamp with 
> browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12147) Allow Unsafe Event Message

2021-02-04 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17278815#comment-17278815
 ] 

James Yong commented on OFBIZ-12147:


Hi Michael,

Yes, this issue can be closed. Thank you for reminder.

> Allow Unsafe Event Message
> --
>
> Key: OFBIZ-12147
> URL: https://issues.apache.org/jira/browse/OFBIZ-12147
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute 
> "__EVENT_MESSAGE__".
>  Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for 
> messages that can contain inline javascript.
> One use case is to allow us to display last login timestamp with 
> browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12162) Single Form Widget on CSS Grid Layout

2021-01-26 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12162:
---
Attachment: OFBIZ-12162.patch

> Single Form Widget on CSS Grid Layout
> -
>
> Key: OFBIZ-12162
> URL: https://issues.apache.org/jira/browse/OFBIZ-12162
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12162.patch
>
>
> Add a new form widget type i.e. "single_css-grid-layout"
> Whereas single form widget is layout using table, single_css-grid-layout form 
> widget is layout using CSS Grid.
> Also will switch FindRequests & FindReturns forms to single_css-grid-layout.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12162) Single Form Widget on CSS Grid Layout

2021-01-26 Thread James Yong (Jira)
James Yong created OFBIZ-12162:
--

 Summary: Single Form Widget on CSS Grid Layout
 Key: OFBIZ-12162
 URL: https://issues.apache.org/jira/browse/OFBIZ-12162
 Project: OFBiz
  Issue Type: New Feature
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Add a new form widget type i.e. "single_css-grid-layout"

Whereas single form widget is layout using table, single_css-grid-layout form 
widget is layout using CSS Grid.

Also will switch FindRequests & FindReturns forms to single_css-grid-layout.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12155) Exporting the PDF for Cash Flow Statement displays the macro code for the date fields

2021-01-23 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270798#comment-17270798
 ] 

James Yong edited comment on OFBIZ-12155 at 1/24/21, 1:51 AM:
--

Hi Jacques,

Found a problem with 
parameters.get('ApplicationDecorator|organizationPartyId')
inside CashFlowStatement.groovy
when I navigate to 
/accounting/control/CashFlowStatement?organizationPartyId=Company directly

No problem when I navigate to /accounting/control/main, prior to  
/accounting/control/CashFlowStatement?organizationPartyId=Company

Will look into the pdf export issue.

Regards,
James

 


was (Author: jamesyong):
Hi Jacques,

No problem when I navigate to /accounting/control/main, prior to  
/accounting/control/CashFlowStatement?organizationPartyId=Company

Problem seems to occur with 
parameters.get('ApplicationDecorator|organizationPartyId')
inside CashFlowStatement.groovy

Regards,
James

 

> Exporting the PDF for Cash Flow Statement displays the macro code for the 
> date fields
> -
>
> Key: OFBIZ-12155
> URL: https://issues.apache.org/jira/browse/OFBIZ-12155
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Ankit Joshi
>Priority: Major
> Attachments: Cash-Flow-Statement.png
>
>
> Navigation-link 
> :https://demo-trunk.ofbiz.apache.org/accounting/control/CashFlowStatement?organizationPartyId=Company
> Steps to regenerate: 
> -- Navigate to Cash flow statement
> -- Submit the Export PDF button
> Issue: 
> The Macro code displays on the screen rather than the date for the date fields



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12155) Exporting the PDF for Cash Flow Statement displays the macro code for the date fields

2021-01-23 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270798#comment-17270798
 ] 

James Yong commented on OFBIZ-12155:


Hi Jacques,

No problem when I navigate to /accounting/control/main, prior to  
/accounting/control/CashFlowStatement?organizationPartyId=Company

Problem seems to occur with 
parameters.get('ApplicationDecorator|organizationPartyId')
inside CashFlowStatement.groovy

Regards,
James

 

> Exporting the PDF for Cash Flow Statement displays the macro code for the 
> date fields
> -
>
> Key: OFBIZ-12155
> URL: https://issues.apache.org/jira/browse/OFBIZ-12155
> Project: OFBiz
>  Issue Type: Bug
>  Components: accounting
>Reporter: Ankit Joshi
>Priority: Major
> Attachments: Cash-Flow-Statement.png
>
>
> Navigation-link 
> :https://demo-trunk.ofbiz.apache.org/accounting/control/CashFlowStatement?organizationPartyId=Company
> Steps to regenerate: 
> -- Navigate to Cash flow statement
> -- Submit the Export PDF button
> Issue: 
> The Macro code displays on the screen rather than the date for the date fields



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12148) Display last-logged-in-time popup after login

2021-01-21 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12148:
---
Attachment: OFBIZ-12148

> Display last-logged-in-time popup after login
> -
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12148
>
>
> Popup last-logged-in time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12148) Display last-logged-in-time popup after login

2021-01-21 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12148:
---
Summary: Display last-logged-in-time popup after login  (was: Display 
last-logged-in-time popup after login success)

> Display last-logged-in-time popup after login
> -
>
> Key: OFBIZ-12148
> URL: https://issues.apache.org/jira/browse/OFBIZ-12148
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Popup last-logged-in time from database after user has logged in.
> So users can know of any unauthorised access to their accounts.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12147) Allow Unsafe Event Message

2021-01-21 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269332#comment-17269332
 ] 

James Yong commented on OFBIZ-12147:


Hi Michael,

The jgrowl message is delayed slightly to avoid race condition as the 
UNSAFE_EVENT_MESSAGE may be running some scripts.

Other message type do not need the delay. So will make a change to only delay 
for UNSAFE_EVENT_MESSAGE.

Agreed on the short notice issue. Will give more time for review in the future.

Thanks,
James

> Allow Unsafe Event Message
> --
>
> Key: OFBIZ-12147
> URL: https://issues.apache.org/jira/browse/OFBIZ-12147
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute 
> "__EVENT_MESSAGE__".
>  Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for 
> messages that can contain inline javascript.
> One use case is to allow us to display last login timestamp with 
> browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12148) Display last-logged-in-time popup after login success

2021-01-21 Thread James Yong (Jira)
James Yong created OFBIZ-12148:
--

 Summary: Display last-logged-in-time popup after login success
 Key: OFBIZ-12148
 URL: https://issues.apache.org/jira/browse/OFBIZ-12148
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Popup last-logged-in time from database after user has logged in.

So users can know of any unauthorised access to their accounts.

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12147) Allow Unsafe Event Message

2021-01-21 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12147:
---
Summary: Allow Unsafe Event Message  (was: Allow Unsafe Message)

> Allow Unsafe Event Message
> --
>
> Key: OFBIZ-12147
> URL: https://issues.apache.org/jira/browse/OFBIZ-12147
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute 
> "__EVENT_MESSAGE__".
>  Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for 
> messages that can contain inline javascript.
> One use case is to allow us to display last login timestamp with 
> browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12147) Allow Unsafe Message

2021-01-21 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17269269#comment-17269269
 ] 

James Yong commented on OFBIZ-12147:


Hi Jacques,

Yes, no security issue as it is not meant for inputs from users.

 

> Allow Unsafe Message
> 
>
> Key: OFBIZ-12147
> URL: https://issues.apache.org/jira/browse/OFBIZ-12147
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute 
> "__EVENT_MESSAGE__".
>  Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for 
> messages that can contain inline javascript.
> One use case is to allow us to display last login timestamp with 
> browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12147) Allow Unsafe Message

2021-01-20 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12147:
---
Description: 
Currently, we can display flash message by setting in request attribute 
"__EVENT_MESSAGE__".
 Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for 
messages that can contain inline javascript.

One use case is to allow us to display last login timestamp with 
browser-specific format.

  was:
Currently, we can display flash message by setting in request attribute 
"_EVENT_MESSAGE_".
Propose to add another request attribute i.e. '_UNSAFE_EVENT_MESSAGE_' for 
messages that  can contain inline javascript.

One use case is to allow us to display last login timestamp with 
browser-specific format.


> Allow Unsafe Message
> 
>
> Key: OFBIZ-12147
> URL: https://issues.apache.org/jira/browse/OFBIZ-12147
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute 
> "__EVENT_MESSAGE__".
>  Propose to add another request attribute i.e. "__UNSAFE_EVENT_MESSAGE__" for 
> messages that can contain inline javascript.
> One use case is to allow us to display last login timestamp with 
> browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12147) Allow Unsafe Message

2021-01-20 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12147:
---
Attachment: OFBIZ-12147

> Allow Unsafe Message
> 
>
> Key: OFBIZ-12147
> URL: https://issues.apache.org/jira/browse/OFBIZ-12147
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12147
>
>
> Currently, we can display flash message by setting in request attribute 
> "_EVENT_MESSAGE_".
> Propose to add another request attribute i.e. '_UNSAFE_EVENT_MESSAGE_' for 
> messages that  can contain inline javascript.
> One use case is to allow us to display last login timestamp with 
> browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12147) Allow Unsafe Message

2021-01-20 Thread James Yong (Jira)
James Yong created OFBIZ-12147:
--

 Summary: Allow Unsafe Message
 Key: OFBIZ-12147
 URL: https://issues.apache.org/jira/browse/OFBIZ-12147
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Currently, we can display flash message by setting in request attribute 
"_EVENT_MESSAGE_".
Propose to add another request attribute i.e. '_UNSAFE_EVENT_MESSAGE_' for 
messages that  can contain inline javascript.

One use case is to allow us to display last login timestamp with 
browser-specific format.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12123) Incorrect date format in tooltip

2021-01-14 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12123.
--
Resolution: Fixed

> Incorrect date format in tooltip
> 
>
> Key: OFBIZ-12123
> URL: https://issues.apache.org/jira/browse/OFBIZ-12123
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Datetime picker uses locale-specific date format but its tooltip shows 
> hardcoded value i.e. 'Format: -MM-dd HH:mm:ss.SSS'.
> Discussion at 
> https://lists.apache.org/thread.html/rd8bfe016f50c2daf1f94fba5592057be8fa4cd2f651852970e6b24de%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12123) Incorrect date format in tooltip

2021-01-14 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264934#comment-17264934
 ] 

James Yong commented on OFBIZ-12123:


Yes, it can be closed. Thanks for the check.

> Incorrect date format in tooltip
> 
>
> Key: OFBIZ-12123
> URL: https://issues.apache.org/jira/browse/OFBIZ-12123
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Datetime picker uses locale-specific date format but its tooltip shows 
> hardcoded value i.e. 'Format: -MM-dd HH:mm:ss.SSS'.
> Discussion at 
> https://lists.apache.org/thread.html/rd8bfe016f50c2daf1f94fba5592057be8fa4cd2f651852970e6b24de%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11927) Deprecate unused HTML Renderers

2021-01-14 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264816#comment-17264816
 ] 

James Yong commented on OFBIZ-11927:


To my knowledge, the following classes are unused and should be deprecated:
HtmlMenuRendererImage
HtmlMenuWrapperImage
HtmlTreeRenderer

> Deprecate unused HTML Renderers
> ---
>
> Key: OFBIZ-11927
> URL: https://issues.apache.org/jira/browse/OFBIZ-11927
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework/widget
>Affects Versions: Trunk
>Reporter: Daniel Watford
>Priority: Minor
>
> The HTML renderers in package org.apache.ofbiz.widget.renderer.html do not 
> appear to be used.  While refactoring other parts of the widget system we 
> have to make corresponding changes to the HTML renderers, but don't have any 
> test cases to prove the HTML renderers continue to function correctly.
> OFBIZ-6281 suggests that HtmlScreenRenderer was deprecated some time ago and 
> has since been removed from ofbiz sources.
> Mark the remaining HTML renderers as deprecated since they should have been 
> superseded by the Macro renderers.
> Assuming the HTML renderer classes are deprecated in the next release they 
> can be removed in the following release.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12134) Rename MultiBlockHtmlTemplateUtil to ScriptLinkHelper

2021-01-13 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12134.
--
Resolution: Fixed

> Rename MultiBlockHtmlTemplateUtil to ScriptLinkHelper
> -
>
> Key: OFBIZ-12134
> URL: https://issues.apache.org/jira/browse/OFBIZ-12134
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Rename MultiBlockHtmlTemplateUtil to ScriptLinkHelper to better reflect the 
> functions provided by the class.
> Refactor ScriptLinkHelper.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12134) Rename MultiBlockHtmlTemplateUtil to ScriptLinkHelper

2021-01-12 Thread James Yong (Jira)
James Yong created OFBIZ-12134:
--

 Summary: Rename MultiBlockHtmlTemplateUtil to ScriptLinkHelper
 Key: OFBIZ-12134
 URL: https://issues.apache.org/jira/browse/OFBIZ-12134
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Rename MultiBlockHtmlTemplateUtil to ScriptLinkHelper to better reflect the 
functions provided by the class.

Refactor ScriptLinkHelper.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12123) Incorrect date format in tooltip

2021-01-11 Thread James Yong (Jira)
James Yong created OFBIZ-12123:
--

 Summary: Incorrect date format in tooltip
 Key: OFBIZ-12123
 URL: https://issues.apache.org/jira/browse/OFBIZ-12123
 Project: OFBiz
  Issue Type: Bug
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Datetime picker uses locale-specific date format but its tooltip shows 
hardcoded value i.e. 'Format: -MM-dd HH:mm:ss.SSS'.

Discussion at 
https://lists.apache.org/thread.html/rd8bfe016f50c2daf1f94fba5592057be8fa4cd2f651852970e6b24de%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12119) Open Menu file from browser

2021-01-08 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12119.
--
Resolution: Fixed

> Open Menu file from browser
> ---
>
> Key: OFBIZ-12119
> URL: https://issues.apache.org/jira/browse/OFBIZ-12119
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> User can choose to open menu definition file from the browser by clicking on 
> the named border. Server will send a command to open the source file.
> Save time looking for the menu definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12119) Open Menu file from browser

2021-01-08 Thread James Yong (Jira)
James Yong created OFBIZ-12119:
--

 Summary: Open Menu file from browser
 Key: OFBIZ-12119
 URL: https://issues.apache.org/jira/browse/OFBIZ-12119
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


User can choose to open menu definition file from the browser by clicking on 
the named border. Server will send a command to open the source file.
Save time looking for the menu definition file.

This feature depends on setting the following properties correctly
widget.dev.namedBorder
widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12116) Apply CSS Grid to Find Orders

2021-01-02 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12116.
--
Resolution: Fixed

> Apply CSS Grid to Find Orders
> -
>
> Key: OFBIZ-12116
> URL: https://issues.apache.org/jira/browse/OFBIZ-12116
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Use CSS Grid Layout to arrange form fields in Find Orders page at 
> /ordermgr/control/findorders
> Discussion started at 
> https://lists.apache.org/thread.html/r6dcf4a8db595e76ab70808ff46eb7d880d6a29a6dea616ca0415ed95%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12116) Apply CSS Grid to Find Orders

2021-01-02 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257613#comment-17257613
 ] 

James Yong commented on OFBIZ-12116:


Thanks for the review :)

> Apply CSS Grid to Find Orders
> -
>
> Key: OFBIZ-12116
> URL: https://issues.apache.org/jira/browse/OFBIZ-12116
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Use CSS Grid Layout to arrange form fields in Find Orders page at 
> /ordermgr/control/findorders
> Discussion started at 
> https://lists.apache.org/thread.html/r6dcf4a8db595e76ab70808ff46eb7d880d6a29a6dea616ca0415ed95%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10444) Investigate how to possibly use CSS Grid Layout

2021-01-02 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257606#comment-17257606
 ] 

James Yong commented on OFBIZ-10444:


I second that. Thanks Jacques. 

> Investigate how to possibly use CSS Grid Layout
> ---
>
> Key: OFBIZ-10444
> URL: https://issues.apache.org/jira/browse/OFBIZ-10444
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> After reading [https://alistapart.com/article/cult-of-the-complex], I 
> suggested [here|https://markmail.org/message/lz2i4qtdr7yqu3gj] we could 
> consider using CSS Grid Layout everywhere in OFBiz instead of js frameworks, 
> including 
> [Bootstrap|https://www.google.fr/search?q=compare+Bootstrap+to+%22CSS+Grid+Layout%22=UTF-8].
> Quoting myself:
> {quote}Depending the less possible on frameworks seems a good idea to me, and 
> the "CSS Grid Layout" seems simple enough to be a viable replacement. 
>  
> Who knows when Bootstrap will be out of date... 
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10444) Investigate how to possibly use CSS Grid Layout

2021-01-01 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17257292#comment-17257292
 ] 

James Yong commented on OFBIZ-10444:


IE 11 has reached end of life on 30th Nov 2020.
I think OFBiz trunk should start using CSS Grid Layout.

> Investigate how to possibly use CSS Grid Layout
> ---
>
> Key: OFBIZ-10444
> URL: https://issues.apache.org/jira/browse/OFBIZ-10444
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
>
> After reading [https://alistapart.com/article/cult-of-the-complex], I 
> suggested [here|https://markmail.org/message/lz2i4qtdr7yqu3gj] we could 
> consider using CSS Grid Layout everywhere in OFBiz instead of js frameworks, 
> including 
> [Bootstrap|https://www.google.fr/search?q=compare+Bootstrap+to+%22CSS+Grid+Layout%22=UTF-8].
> Quoting myself:
> {quote}Depending the less possible on frameworks seems a good idea to me, and 
> the "CSS Grid Layout" seems simple enough to be a viable replacement. 
>  
> Who knows when Bootstrap will be out of date... 
> {quote}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12116) Apply CSS Grid to Find Orders

2021-01-01 Thread James Yong (Jira)
James Yong created OFBIZ-12116:
--

 Summary: Apply CSS Grid to Find Orders
 Key: OFBIZ-12116
 URL: https://issues.apache.org/jira/browse/OFBIZ-12116
 Project: OFBiz
  Issue Type: Improvement
  Components: order
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Use CSS Grid Layout to arrange form fields in Find Orders page at 
/ordermgr/control/findorders

Discussion started at 
https://lists.apache.org/thread.html/r6dcf4a8db595e76ab70808ff46eb7d880d6a29a6dea616ca0415ed95%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12115) Change inline style to js for multiple select field

2020-12-31 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12115.
--
Resolution: Fixed

> Change inline style to js for multiple select field
> ---
>
> Key: OFBIZ-12115
> URL: https://issues.apache.org/jira/browse/OFBIZ-12115
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Avoid inline style for Content Security Policy compliance



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12115) Change inline style to js for multiple select field

2020-12-31 Thread James Yong (Jira)
James Yong created OFBIZ-12115:
--

 Summary: Change inline style to js for multiple select field
 Key: OFBIZ-12115
 URL: https://issues.apache.org/jira/browse/OFBIZ-12115
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Avoid inline style for Content Security Policy compliance



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12102) Do not limit form width if asm_formSize is not defined

2020-12-26 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12102.
--
Resolution: Fixed

> Do not limit form width if asm_formSize is not defined
> --
>
> Key: OFBIZ-12102
> URL: https://issues.apache.org/jira/browse/OFBIZ-12102
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> When asm_formSize is not set, the css will limit the form width to 700px.
> This causes fields in a 2-column form to be misaligned.
> {code:java}
> #${asm_multipleSelectForm}
> {
> width: ${asm_formSize!700}px
> ;
> position: relative
> ;
> }
> {code}
> Examples at /ordermgr/control/FindRequest and /content/control/findContent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12112) apply buttontext class for links inside screenlet title bar

2020-12-26 Thread James Yong (Jira)
James Yong created OFBIZ-12112:
--

 Summary: apply buttontext class for links inside screenlet title 
bar
 Key: OFBIZ-12112
 URL: https://issues.apache.org/jira/browse/OFBIZ-12112
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


For consistent look-and-feel, all links inside screenlet title bar should be 
styled with buttontext for class attribute.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12102) Do not limit form width if asm_formSize is not defined

2020-12-25 Thread James Yong (Jira)
James Yong created OFBIZ-12102:
--

 Summary: Do not limit form width if asm_formSize is not defined
 Key: OFBIZ-12102
 URL: https://issues.apache.org/jira/browse/OFBIZ-12102
 Project: OFBiz
  Issue Type: Bug
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


When asm_formSize is not set, the css will limit the form width to 700px.
This causes fields in a 2-column form to be misaligned.

{code:java}
#${asm_multipleSelectForm}
{
width: ${asm_formSize!700}px
;
position: relative
;
}
{code}

Examples at /ordermgr/control/FindRequest and /content/control/findContent



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12099) Support Freemarker square interpolation syntax

2020-12-25 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12099.
--
Resolution: Implemented

> Support Freemarker square interpolation syntax
> --
>
> Key: OFBIZ-12099
> URL: https://issues.apache.org/jira/browse/OFBIZ-12099
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Support Freemarker square interpolation syntax [=...] when the freemarker 
> template filename ends with '.sqi.ftl'. This avoids sharing the same 
> interpolation syntax as Javascript's template literal.  
>  
> Discussion started at 
> https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E
> Reference:
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
>  
> https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation
> To test / migrate:
> 1) Change template file extension from .ftl to .sqi.ftl
> 2) Use regular expresssion replacement:
>  From: \$\{([^${}]+)\}
>  To: [=$1] 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12099) Support Freemarker square interpolation syntax

2020-12-21 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12099:
---
Description: 
Support Freemarker square interpolation syntax [=...] when the freemarker 
template filename ends with '.sqi.ftl'. This avoids sharing the same 
interpolation syntax as Javascript's template literal.  
 
Discussion started at 
https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
 
https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation

To test / migrate:
1) Change template file extension from .ftl to .sqi.ftl
2) Use regular expresssion replacement:
 From: \$\{([^${}]+)\}
 To: [=$1] 

  was:
Support Freemarker square interpolation syntax [=...] when the freemarker 
template filename ends with '.sqi.ftl'. This avoids sharing the same 
interpolation syntax as Javascript's template literal.  
 
Discussion started at 
https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
 
https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation

To test / migrate:
1) Change template file extension from .ftl to .spi.ftl
2) Use regular expresssion replacement:
 From: \$\{([^${}]+)\}
 To: [=$1] 


> Support Freemarker square interpolation syntax
> --
>
> Key: OFBIZ-12099
> URL: https://issues.apache.org/jira/browse/OFBIZ-12099
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Support Freemarker square interpolation syntax [=...] when the freemarker 
> template filename ends with '.sqi.ftl'. This avoids sharing the same 
> interpolation syntax as Javascript's template literal.  
>  
> Discussion started at 
> https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E
> Reference:
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
>  
> https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation
> To test / migrate:
> 1) Change template file extension from .ftl to .sqi.ftl
> 2) Use regular expresssion replacement:
>  From: \$\{([^${}]+)\}
>  To: [=$1] 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12099) Support Freemarker square interpolation syntax

2020-12-21 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252844#comment-17252844
 ] 

James Yong commented on OFBIZ-12099:


Hi Jacques,

Should be .sqi.ftl. Thanks for spotting the mistake.

> Support Freemarker square interpolation syntax
> --
>
> Key: OFBIZ-12099
> URL: https://issues.apache.org/jira/browse/OFBIZ-12099
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Support Freemarker square interpolation syntax [=...] when the freemarker 
> template filename ends with '.sqi.ftl'. This avoids sharing the same 
> interpolation syntax as Javascript's template literal.  
>  
> Discussion started at 
> https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E
> Reference:
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
>  
> https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation
> To test / migrate:
> 1) Change template file extension from .ftl to .spi.ftl
> 2) Use regular expresssion replacement:
>  From: \$\{([^${}]+)\}
>  To: [=$1] 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12099) Support Freemarker square interpolation syntax

2020-12-21 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12099?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12099:
---
Description: 
Support Freemarker square interpolation syntax [=...] when the freemarker 
template filename ends with '.sqi.ftl'. This avoids sharing the same 
interpolation syntax as Javascript's template literal.  
 
Discussion started at 
https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
 
https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation

To test / migrate:
1) Change template file extension from .ftl to .spi.ftl
2) Use regular expresssion replacement:
 From: \$\{([^${}]+)\}
 To: [=$1] 

  was:
Support Freemarker square interpolation syntax [=...] when the freemarker 
template filename ends with '.sqi.ftl'. This avoids sharing the same 
interpolation syntax as Javascript's template literal.  
 
Discussion started at 
https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
 
https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation


> Support Freemarker square interpolation syntax
> --
>
> Key: OFBIZ-12099
> URL: https://issues.apache.org/jira/browse/OFBIZ-12099
> Project: OFBiz
>  Issue Type: New Feature
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Support Freemarker square interpolation syntax [=...] when the freemarker 
> template filename ends with '.sqi.ftl'. This avoids sharing the same 
> interpolation syntax as Javascript's template literal.  
>  
> Discussion started at 
> https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E
> Reference:
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
>  
> https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation
> To test / migrate:
> 1) Change template file extension from .ftl to .spi.ftl
> 2) Use regular expresssion replacement:
>  From: \$\{([^${}]+)\}
>  To: [=$1] 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12099) Support Freemarker square interpolation syntax

2020-12-20 Thread James Yong (Jira)
James Yong created OFBIZ-12099:
--

 Summary: Support Freemarker square interpolation syntax
 Key: OFBIZ-12099
 URL: https://issues.apache.org/jira/browse/OFBIZ-12099
 Project: OFBiz
  Issue Type: New Feature
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Support Freemarker square interpolation syntax [=...] when the freemarker 
template filename ends with '.spi.ftl'. This avoids sharing the same 
interpolation syntax as Javascript's template literal.  
 
Discussion started at 
https://lists.apache.org/thread.html/r485b78638f10f95089e5f1123d73a2d132a3f8c2faea0eb056fa1709%40%3Cdev.ofbiz.apache.org%3E

Reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals
 
https://freemarker.apache.org/docs/dgui_misc_alternativesyntax.html#dgui_misc_alternativesyntax_interpolation



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12097) Date picker not initialised in ajax-called form

2020-12-19 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12097.
--
Resolution: Fixed

> Date picker not initialised in ajax-called form 
> 
>
> Key: OFBIZ-12097
> URL: https://issues.apache.org/jira/browse/OFBIZ-12097
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The date picker icon is missing when the form is called with ajax.
> To test:
> 1) Go to /catalog/control/ProductStoreFacilities?productStoreId=9000
> 2) Click Add Facility button



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12097) Date picker not initialised in ajax-called form

2020-12-19 Thread James Yong (Jira)
James Yong created OFBIZ-12097:
--

 Summary: Date picker not initialised in ajax-called form 
 Key: OFBIZ-12097
 URL: https://issues.apache.org/jira/browse/OFBIZ-12097
 Project: OFBiz
  Issue Type: Bug
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


The date picker icon is missing when the form is called with ajax.

To test:
1) Go to /catalog/control/ProductStoreFacilities?productStoreId=9000
2) Click Add Facility button



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12095) Change inline style to class for wait-spinner

2020-12-19 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12095.
--
Resolution: Fixed

> Change inline style to class for wait-spinner
> -
>
> Key: OFBIZ-12095
> URL: https://issues.apache.org/jira/browse/OFBIZ-12095
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Inline style not encouraged by Content Security Policy
> Will change from
> {code:java}
> 
> 
> 
> {code}
> to
> {code:java}
> 
> 
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12095) Change inline style to class for wait-spinner

2020-12-18 Thread James Yong (Jira)
James Yong created OFBIZ-12095:
--

 Summary: Change inline style to class for wait-spinner
 Key: OFBIZ-12095
 URL: https://issues.apache.org/jira/browse/OFBIZ-12095
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Inline style not encouraged by Content Security Policy

Will change from
{code:java}



{code}
to
{code:java}



{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12094) wait spinner doesn't show when running ajaxUpdateArea

2020-12-18 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12094:
---
Description: 
Within ajaxUpdateArea js function, the wait spinner should be shown before ajax 
post request.  

To test:
1) go to 
https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000
2) click Add Facility button


  was:
Within ajaxUpdateArea js function, the wait spinner is not shown when 
waitSpinnerShow() is called before ajax post request.  

To test:
1) go to 
https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000
2) click Add Facility button



> wait spinner doesn't show when running ajaxUpdateArea
> -
>
> Key: OFBIZ-12094
> URL: https://issues.apache.org/jira/browse/OFBIZ-12094
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Within ajaxUpdateArea js function, the wait spinner should be shown before 
> ajax post request.  
> To test:
> 1) go to 
> https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000
> 2) click Add Facility button



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12094) wait spinner doesn't show when running ajaxUpdateArea

2020-12-18 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12094.
--
Resolution: Fixed

> wait spinner doesn't show when running ajaxUpdateArea
> -
>
> Key: OFBIZ-12094
> URL: https://issues.apache.org/jira/browse/OFBIZ-12094
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> Within ajaxUpdateArea js function, the wait spinner is not shown when 
> waitSpinnerShow() is called before ajax post request.  
> To test:
> 1) go to 
> https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000
> 2) click Add Facility button



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12094) wait spinner doesn't show when running ajaxUpdateArea

2020-12-18 Thread James Yong (Jira)
James Yong created OFBIZ-12094:
--

 Summary: wait spinner doesn't show when running ajaxUpdateArea
 Key: OFBIZ-12094
 URL: https://issues.apache.org/jira/browse/OFBIZ-12094
 Project: OFBiz
  Issue Type: Bug
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Within ajaxUpdateArea js function, the wait spinner is not shown when 
waitSpinnerShow() is called before ajax post request.  

To test:
1) go to 
https://localhost:8443/catalog/control/ProductStoreFacilities?productStoreId=9000
2) click Add Facility button




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12091) Hyperlink target-type attribute is deprecated and should be replaced by url-mode

2020-12-17 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17251113#comment-17251113
 ] 

James Yong commented on OFBIZ-12091:


Hi Jacques,

While creating a sale order from OrderEntry page, the following error occurred 
after selecting a product from the Lookup Product screen.
{code:java}
ERROR MESSAGE

org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
[javascript:set_value('WG-9943')]; this request does not exist or cannot be 
called directly.
{code}

> Hyperlink target-type attribute is deprecated and should be replaced by 
> url-mode
> 
>
> Key: OFBIZ-12091
> URL: https://issues.apache.org/jira/browse/OFBIZ-12091
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS, framework/widget
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Trivial
> Fix For: Upcoming Branch
>
>
> While workin on OFBIZ-12026 I noticed that hyperlink target-type attribute is 
> deprecated and should be replaced by url-mode.
> BTW, same for sub-hyperlink



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11347) Add GraphQL component

2020-12-08 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17245881#comment-17245881
 ] 

James Yong commented on OFBIZ-11347:


+1 
Having GraphQL helps to reduce calls between client and server.

> Add GraphQL component
> -
>
> Key: OFBIZ-11347
> URL: https://issues.apache.org/jira/browse/OFBIZ-11347
> Project: OFBiz
>  Issue Type: New Feature
>  Components: ALL PLUGINS
>Affects Versions: Trunk
>Reporter: Girish Vasmatkar
>Assignee: Girish Vasmatkar
>Priority: Minor
>
> Here's the relevant discussion around having a GraphQL component for OFBiz- 
> [https://lists.apache.org/thread.html/r2fd1decca7a71ae2270a0e2d1f03ed69a69253f68f957626c386a11a%40%3Cdev.ofbiz.apache.org%3E]
>  Also, add the capability for OFBiz to communicate with a GraphQL endpoint.
> Below repository contains GraphQL endpoint configuration for OFBiz. Further 
> details can be found in README.
> https://github.com/girishvasmatkar/ofbiz-graphql
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-11799) Move page-specific script links to html template

2020-12-05 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-11799.
--
Resolution: Fixed

> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
>  Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.
> 15 Aug 2020
> Used importLibrary js to load js / css files when needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12086) Make locale available for DateFindField and DateTimeField macros

2020-12-05 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12086.
--
Resolution: Fixed

> Make locale available for DateFindField and DateTimeField macros
> 
>
> Key: OFBIZ-12086
> URL: https://issues.apache.org/jira/browse/OFBIZ-12086
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> DateFindField and DateTimeField macros need to use the locale in order to get 
> the language-specific javascript library files.
> To expose the locale for DateFindField and DateTimeField macros



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12086) Make locale available for DateFindField and DateTimeField macros

2020-12-05 Thread James Yong (Jira)
James Yong created OFBIZ-12086:
--

 Summary: Make locale available for DateFindField and DateTimeField 
macros
 Key: OFBIZ-12086
 URL: https://issues.apache.org/jira/browse/OFBIZ-12086
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


DateFindField and DateTimeField macros need to use the locale in order to get 
the language-specific javascript library files.

To expose the locale for DateFindField and DateTimeField macros



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12071) jquery.ui.datepicker-en.js does not exist

2020-12-05 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12071:
---
Description: 
The following default language file specified for DateTime doesn't exist in the 
project:
/common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js

Will change to 
/common/js/jquery/plugins/datetimepicker/i18n/jquery-ui-timepicker-en.js

+2020 Dec 5th+
Default language file specified for Jquery DatePicker doesn't exists in the 
project too i.e.
/common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js

Will change to /common/js/jquery/ui/i18n/datepicker-en.js

  was:
The following default language file specified for DateTime doesn't exist in the 
project:
/common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js

Will change to 
/common/js/jquery/plugins/datetimepicker/i18n/jquery-ui-timepicker-en.js


> jquery.ui.datepicker-en.js does not exist
> -
>
> Key: OFBIZ-12071
> URL: https://issues.apache.org/jira/browse/OFBIZ-12071
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The following default language file specified for DateTime doesn't exist in 
> the project:
> /common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js
> Will change to 
> /common/js/jquery/plugins/datetimepicker/i18n/jquery-ui-timepicker-en.js
> +2020 Dec 5th+
> Default language file specified for Jquery DatePicker doesn't exists in the 
> project too i.e.
> /common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js
> Will change to /common/js/jquery/ui/i18n/datepicker-en.js



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-11799) Move page-specific script links to html template

2020-11-29 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-11799:
---
Description: 
As external script can be defined in html template, suggest to move some of the 
page-specific script links from layoutSettings.javaScripts to the html 
templates.

6 Aug 2020
 Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
VT_STYLESHEET.

15 Aug 2020
Used importLibrary js to load js / css files when needed.

  was:
As external script can be defined in html template, suggest to move some of the 
page-specific script links from layoutSettings.javaScripts to the html 
templates.

6 Aug 2020
Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
VT_STYLESHEET.


> Move page-specific script links to html template
> 
>
> Key: OFBIZ-11799
> URL: https://issues.apache.org/jira/browse/OFBIZ-11799
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS, ALL PLUGINS
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Trunk
>
>
> As external script can be defined in html template, suggest to move some of 
> the page-specific script links from layoutSettings.javaScripts to the html 
> templates.
> 6 Aug 2020
>  Also include moving from layoutSettings.styleSheets, VT_HDR_JAVASCRIPT and 
> VT_STYLESHEET.
> 15 Aug 2020
> Used importLibrary js to load js / css files when needed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12064) Load language js for date.js only when required

2020-11-28 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12064.
--
Resolution: Fixed

> Load language js for date.js only when required 
> 
>
> Key: OFBIZ-12064
> URL: https://issues.apache.org/jira/browse/OFBIZ-12064
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12064.patch
>
>
> Only load language js for Date.js when there is a date time picker in the 
> page. The library is located at 
> themes/common-themes/webapp/common/js/jquery/plugins/datejs.
> Discussion started at 
> https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12071) jquery.ui.datepicker-en.js does not exist

2020-11-28 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12071.
--
Resolution: Fixed

> jquery.ui.datepicker-en.js does not exist
> -
>
> Key: OFBIZ-12071
> URL: https://issues.apache.org/jira/browse/OFBIZ-12071
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The following default language file specified for DateTime doesn't exist in 
> the project:
> /common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js
> Will change to 
> /common/js/jquery/plugins/datetimepicker/i18n/jquery-ui-timepicker-en.js



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12071) jquery.ui.datepicker-en.js does not exist

2020-11-28 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12071:
---
Sprint: OFBiz Community Day (Nov 2020)

> jquery.ui.datepicker-en.js does not exist
> -
>
> Key: OFBIZ-12071
> URL: https://issues.apache.org/jira/browse/OFBIZ-12071
> Project: OFBiz
>  Issue Type: Bug
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> The following default language file specified for DateTime doesn't exist in 
> the project:
> /common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js
> Will change to 
> /common/js/jquery/plugins/datetimepicker/i18n/jquery-ui-timepicker-en.js



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12064) Load language js for date.js only when required

2020-11-28 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12064:
---
Sprint: OFBiz Community Day (Nov 2020)

> Load language js for date.js only when required 
> 
>
> Key: OFBIZ-12064
> URL: https://issues.apache.org/jira/browse/OFBIZ-12064
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12064.patch
>
>
> Only load language js for Date.js when there is a date time picker in the 
> page. The library is located at 
> themes/common-themes/webapp/common/js/jquery/plugins/datejs.
> Discussion started at 
> https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12071) jquery.ui.datepicker-en.js does not exist

2020-11-28 Thread James Yong (Jira)
James Yong created OFBIZ-12071:
--

 Summary: jquery.ui.datepicker-en.js does not exist
 Key: OFBIZ-12071
 URL: https://issues.apache.org/jira/browse/OFBIZ-12071
 Project: OFBiz
  Issue Type: Bug
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


The following default language file specified for DateTime doesn't exist in the 
project:
/common/js/jquery/ui/i18n/jquery.ui.datepicker-en.js

Will change to 
/common/js/jquery/plugins/datetimepicker/i18n/jquery-ui-timepicker-en.js



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12064) Load language js for date.js only when required

2020-11-26 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12064:
---
Attachment: OFBIZ-12064.patch

> Load language js for date.js only when required 
> 
>
> Key: OFBIZ-12064
> URL: https://issues.apache.org/jira/browse/OFBIZ-12064
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12064.patch
>
>
> Only load language js for Date.js when there is a date time picker in the 
> page. The library is located at 
> themes/common-themes/webapp/common/js/jquery/plugins/datejs.
> Discussion started at 
> https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12064) Load language js for date.js only when required

2020-11-26 Thread James Yong (Jira)
James Yong created OFBIZ-12064:
--

 Summary: Load language js for date.js only when required 
 Key: OFBIZ-12064
 URL: https://issues.apache.org/jira/browse/OFBIZ-12064
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Only load language js for Date.js when there is a date time picker in the page. 
The library is located at 
themes/common-themes/webapp/common/js/jquery/plugins/datejs.

Discussion started at 
https://lists.apache.org/thread.html/re9288f4d70f216677f08d859bba8d6fc195d0d2d754f0e93838d87f9%40%3Cdev.ofbiz.apache.org%3E



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12042) Move FlotChart screen from common to example component

2020-10-14 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12042.
--
Resolution: Not A Problem

> Move FlotChart screen from common to example component
> --
>
> Key: OFBIZ-12042
> URL: https://issues.apache.org/jira/browse/OFBIZ-12042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: example
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> FlotChart screen is used by example component and served as demo for jquery 
> flot library.
> Propose to move flotScreens.xml and PrepareDataForFlotGraph.groovy from 
> common to example component.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12042) Move FlotChart screen from common to example component

2020-10-14 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17214400#comment-17214400
 ] 

James Yong commented on OFBIZ-12042:


Hi Jacques,

Sorry, I checked that FlotChart screen is generic enough. 
So won't be refactoring it. Will close this JIRA issue. 

> Move FlotChart screen from common to example component
> --
>
> Key: OFBIZ-12042
> URL: https://issues.apache.org/jira/browse/OFBIZ-12042
> Project: OFBiz
>  Issue Type: Improvement
>  Components: example
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> FlotChart screen is used by example component and served as demo for jquery 
> flot library.
> Propose to move flotScreens.xml and PrepareDataForFlotGraph.groovy from 
> common to example component.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12042) Move FlotChart screen from common to example component

2020-10-10 Thread James Yong (Jira)
James Yong created OFBIZ-12042:
--

 Summary: Move FlotChart screen from common to example component
 Key: OFBIZ-12042
 URL: https://issues.apache.org/jira/browse/OFBIZ-12042
 Project: OFBiz
  Issue Type: Improvement
  Components: example
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


FlotChart screen is used by example component and served as demo for jquery 
flot library.

Propose to move flotScreens.xml and PrepareDataForFlotGraph.groovy from common 
to example component.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12041) Open Form Widget (Single Type) source file from browser

2020-10-10 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12041.
--
Resolution: Fixed

> Open Form Widget (Single Type) source file from browser
> ---
>
> Key: OFBIZ-12041
> URL: https://issues.apache.org/jira/browse/OFBIZ-12041
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12041.patch
>
>
> Allow form widget (single type) source file to be opened from the browser. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12041) Open Form Widget (Single Type) source file from browser

2020-10-10 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12041:
---
Attachment: OFBIZ-12041.patch

> Open Form Widget (Single Type) source file from browser
> ---
>
> Key: OFBIZ-12041
> URL: https://issues.apache.org/jira/browse/OFBIZ-12041
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12041.patch
>
>
> Allow form widget (single type) source file to be opened from the browser. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12041) Open Form Widget (Single Type) source file from browser

2020-10-10 Thread James Yong (Jira)
James Yong created OFBIZ-12041:
--

 Summary: Open Form Widget (Single Type) source file from browser
 Key: OFBIZ-12041
 URL: https://issues.apache.org/jira/browse/OFBIZ-12041
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


Allow form widget (single type) source file to be opened from the browser. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12040) Remove date.format-1.2.3-min.js

2020-10-10 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12040.
--
Resolution: Fixed

> Remove date.format-1.2.3-min.js
> ---
>
> Key: OFBIZ-12040
> URL: https://issues.apache.org/jira/browse/OFBIZ-12040
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> date.format-1.2.3-min.js doesn't seem to be in use by OFBiz



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12040) Remove date.format-1.2.3-min.js

2020-10-10 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211681#comment-17211681
 ] 

James Yong commented on OFBIZ-12040:


Hi Jacques,

Thanks for the review

> Remove date.format-1.2.3-min.js
> ---
>
> Key: OFBIZ-12040
> URL: https://issues.apache.org/jira/browse/OFBIZ-12040
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> date.format-1.2.3-min.js doesn't seem to be in use by OFBiz



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12040) Remove date.format-1.2.3-min.js

2020-10-10 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17211675#comment-17211675
 ] 

James Yong commented on OFBIZ-12040:


Hi Jacques,

Ok, will remove the mentioned lines.

> Remove date.format-1.2.3-min.js
> ---
>
> Key: OFBIZ-12040
> URL: https://issues.apache.org/jira/browse/OFBIZ-12040
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> date.format-1.2.3-min.js doesn't seem to be in use by OFBiz



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12040) Remove date.format-1.2.3-min.js

2020-10-10 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12040:
---
Description: date.format-1.2.3-min.js doesn't seem to be in use by OFBiz  
(was: date.format-1.2.3-min.js doesn't seem to be in use )

> Remove date.format-1.2.3-min.js
> ---
>
> Key: OFBIZ-12040
> URL: https://issues.apache.org/jira/browse/OFBIZ-12040
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
>
> date.format-1.2.3-min.js doesn't seem to be in use by OFBiz



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-12040) Remove date.format-1.2.3-min.js

2020-10-10 Thread James Yong (Jira)
James Yong created OFBIZ-12040:
--

 Summary: Remove date.format-1.2.3-min.js
 Key: OFBIZ-12040
 URL: https://issues.apache.org/jira/browse/OFBIZ-12040
 Project: OFBiz
  Issue Type: Improvement
  Components: base
Affects Versions: Upcoming Branch
Reporter: James Yong
Assignee: James Yong
 Fix For: Upcoming Branch


date.format-1.2.3-min.js doesn't seem to be in use 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Closed] (OFBIZ-12038) Open Screen file from browser

2020-10-08 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong closed OFBIZ-12038.
--
Resolution: Fixed

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12038) Open Screen file from browser

2020-10-08 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17210211#comment-17210211
 ] 

James Yong commented on OFBIZ-12038:


Hi Jacques, 

Thanks for logging the issue with eclipse.

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12038) Open Screen file from browser

2020-10-06 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208842#comment-17208842
 ] 

James Yong commented on OFBIZ-12038:


Hi Jacques,

Feel free to create the bug issue. Else i can do so tomorrow or later. Thanks.

 

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12038) Open Screen file from browser

2020-10-06 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208808#comment-17208808
 ] 

James Yong commented on OFBIZ-12038:


Hi Jacques,

I didn't managed to use command line to get Eclipse to open any source file in 
Macbook. Using Eclipse 2020-09.

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12038) Open Screen file from browser

2020-10-06 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208724#comment-17208724
 ] 

James Yong edited comment on OFBIZ-12038 at 10/6/20, 2:13 PM:
--

Seem no one tested with xml file editor for this bug

[https://bugs.eclipse.org/bugs/show_bug.cgi?id=305336]

I found the page to create an Eclipse account. So will add comment to the 
Eclipse issue above 

Should I go ahead and commit this patch? 

 


was (Author: jamesyong):
Seem no one tested with xml file editor for this bug

[https://bugs.eclipse.org/bugs/show_bug.cgi?id=305336]

Membership is required before allowed to add comment to the issue.

Should I go ahead and commit this patch? 

 

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (OFBIZ-12038) Open Screen file from browser

2020-10-06 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208724#comment-17208724
 ] 

James Yong edited comment on OFBIZ-12038 at 10/6/20, 2:02 PM:
--

Seem no one tested with xml file editor for this bug

[https://bugs.eclipse.org/bugs/show_bug.cgi?id=305336]

Membership is required before allowed to add comment to the issue.

Should I go ahead and commit this patch? 

 


was (Author: jamesyong):
Seem no one tested with xml file editor for this bug

[https://bugs.eclipse.org/bugs/show_bug.cgi?id=305336]

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12038) Open Screen file from browser

2020-10-06 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17208724#comment-17208724
 ] 

James Yong commented on OFBIZ-12038:


Seem no one tested with xml file editor for this bug

[https://bugs.eclipse.org/bugs/show_bug.cgi?id=305336]

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12038) Open Screen file from browser

2020-10-04 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207330#comment-17207330
 ] 

James Yong commented on OFBIZ-12038:


Hi Jacques,

I added a new patch to print out the command used.

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-12038) Open Screen file from browser

2020-10-04 Thread James Yong (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

James Yong updated OFBIZ-12038:
---
Attachment: OFBIZ-12038.patch

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch, OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12038) Open Screen file from browser

2020-10-04 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207284#comment-17207284
 ] 

James Yong commented on OFBIZ-12038:


Hi Jacques,

Does it work now?

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-12038) Open Screen file from browser

2020-10-04 Thread James Yong (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-12038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17207099#comment-17207099
 ] 

James Yong commented on OFBIZ-12038:


Hi Jacques, 

What is the current setting for
*widget.dev.cmd.openSourceFile* ?

Is it *eclipse "${sourceLocation}:${lineNumber}"* ?

> Open Screen file from browser
> -
>
> Key: OFBIZ-12038
> URL: https://issues.apache.org/jira/browse/OFBIZ-12038
> Project: OFBiz
>  Issue Type: Improvement
>  Components: base
>Affects Versions: Upcoming Branch
>Reporter: James Yong
>Assignee: James Yong
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-12038.patch
>
>
> User can choose to open screen definition file from the browser by clicking 
> on the named border. Server will send a command to open the source file.
> Save time looking for the screen definition file.
> This feature depends on setting the following properties correctly
> widget.dev.namedBorder
> widget.dev.cmd.openSourceFile



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


  1   2   3   4   5   6   >