[jira] [Updated] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12982:
--
Attachment: OFBIZ-12982.patch
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-12982.patch
>
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12982:
--
Attachment: (was: OFBIZ-12982.patch)
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-12982.patch
>
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838518#comment-17838518
]
Nicolas Malin edited comment on OFBIZ-12982 at 4/18/24 7:54 AM:
I updated a first patch to remove all mini lang with inter component
dependencies.
It's huge task and I didn't test all but just to give some visibility on that
[^OFBIZ-12982.patch]
was (Author: soledad):
I updated a first patch to remove all mini lang with inter component
dependencies.
It's huge task and I didn't test all but just to give some visibility on that
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-12982.patch
>
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17838518#comment-17838518
]
Nicolas Malin commented on OFBIZ-12982:
---
I updated a first patch to remove all mini lang with inter component
dependencies.
It's huge task and I didn't test all but just to give some visibility on that
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-12982.patch
>
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12982:
--
Attachment: OFBIZ-12982.patch
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Assignee: Nicolas Malin
>Priority: Major
> Attachments: OFBIZ-12982.patch
>
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin reassigned OFBIZ-12982:
-
Assignee: Nicolas Malin
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Assignee: Nicolas Malin
>Priority: Major
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837103#comment-17837103
]
Nicolas Malin commented on OFBIZ-12982:
---
I'm on it, just it's a nightmare, project is a good example of "what not to do"
!
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Priority: Major
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12982) updateMyTimesheet throws an error
[
https://issues.apache.org/jira/browse/OFBIZ-12982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832214#comment-17832214
]
Nicolas Malin commented on OFBIZ-12982:
---
Thanks for the alert, I'll take care on
> updateMyTimesheet throws an error
> -
>
> Key: OFBIZ-12982
> URL: https://issues.apache.org/jira/browse/OFBIZ-12982
> Project: OFBiz
> Issue Type: Bug
> Components: projectmgr
>Reporter: Pierre Smits
>Priority: Major
>
> When updating a timesheet in projectmgr following error is thrown:
> {code:java}
> The Following Errors Occurred:
> Error:Error running the simple-method: Could not find name="assignPartyToWorkEffort"> in XML document
> component://workeffort/minilang/workeffort/WorkEffortSimpleServices.xml,
> File#Method = ProjectServices.xml#updateTimeEntryByWorkeffort, Element =
> , Line 491null
> {code}
> to try/test:
> https://demo-trunk.ofbiz.apache.org/projectmgr/control/MyTimesheet and update
> the timesheet with a selected task and time.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12968) Convert WorkEffortServices.xml mini-lang to groovyDSL (partial)
[ https://issues.apache.org/jira/browse/OFBIZ-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12968. - Resolution: Done > Convert WorkEffortServices.xml mini-lang to groovyDSL (partial) > --- > > Key: OFBIZ-12968 > URL: https://issues.apache.org/jira/browse/OFBIZ-12968 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Fix For: Upcoming Branch > > > Convert the following service : > * assignPartyToWorkEffort > * updatePartyToWorkEffortAssignment > * deletePartyToWorkEffortAssignment -> deprecated suggest to use > expireWorkEffortPartyAssignment > * quickAssignPartyToWorkEffort > * quickAssignPartyToWorkEffortRole > * duplicateWorkEffort > * createWorkEffortContactMech > * updateWorkEffortContactMech > * createWorkEffortPostalAddress > * updateWorkEffortPostalAddress > * createWorkEffortTelecomNumber > * updateWorkEffortTelecomNumber > * createWorkEffortEmailAddress > * updateWorkEffortEmailAddress > For all WorkEffortContactMech service like, use only two generic functions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12968) Convert WorkEffortServices.xml mini-lang to groovyDSL (partial)
[ https://issues.apache.org/jira/browse/OFBIZ-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12968: -- Description: Convert the following service : * assignPartyToWorkEffort * updatePartyToWorkEffortAssignment * deletePartyToWorkEffortAssignment -> deprecated suggest to use expireWorkEffortPartyAssignment * quickAssignPartyToWorkEffort * quickAssignPartyToWorkEffortRole * duplicateWorkEffort * createWorkEffortContactMech * updateWorkEffortContactMech * createWorkEffortPostalAddress * updateWorkEffortPostalAddress * createWorkEffortTelecomNumber * updateWorkEffortTelecomNumber * createWorkEffortEmailAddress * updateWorkEffortEmailAddress For all WorkEffortContactMech service like, use only two generic functions. was: Convert the following service : * createWorkEffort * updateWorkEffort * deleteWorkEffort * copyWorkEffort * createWorkEffortAndPartyAssign createWorkEffort contains too functionnal logic on the base code so split it on different services and intoduce : * assocAcceptedCustRequestToWorkEffort, run throught seca * createWorkEffortStatus createWorkEffortAndPartyAssign use the entity-auto logic so create services createWorkEffortPartyAssignment, updateWorkEffortPartyAssignment and expireWorkEffortPartyAssignment to make them more generic > Convert WorkEffortServices.xml mini-lang to groovyDSL (partial) > --- > > Key: OFBIZ-12968 > URL: https://issues.apache.org/jira/browse/OFBIZ-12968 > Project: OFBiz > Issue Type: Sub-task > Components: workeffort >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Fix For: Upcoming Branch > > > Convert the following service : > * assignPartyToWorkEffort > * updatePartyToWorkEffortAssignment > * deletePartyToWorkEffortAssignment -> deprecated suggest to use > expireWorkEffortPartyAssignment > * quickAssignPartyToWorkEffort > * quickAssignPartyToWorkEffortRole > * duplicateWorkEffort > * createWorkEffortContactMech > * updateWorkEffortContactMech > * createWorkEffortPostalAddress > * updateWorkEffortPostalAddress > * createWorkEffortTelecomNumber > * updateWorkEffortTelecomNumber > * createWorkEffortEmailAddress > * updateWorkEffortEmailAddress > For all WorkEffortContactMech service like, use only two generic functions. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12968) Convert WorkEffortServices.xml mini-lang to groovyDSL (partial)
Nicolas Malin created OFBIZ-12968: - Summary: Convert WorkEffortServices.xml mini-lang to groovyDSL (partial) Key: OFBIZ-12968 URL: https://issues.apache.org/jira/browse/OFBIZ-12968 Project: OFBiz Issue Type: Sub-task Components: workeffort Reporter: Nicolas Malin Assignee: Nicolas Malin Fix For: Upcoming Branch Convert the following service : * createWorkEffort * updateWorkEffort * deleteWorkEffort * copyWorkEffort * createWorkEffortAndPartyAssign createWorkEffort contains too functionnal logic on the base code so split it on different services and intoduce : * assocAcceptedCustRequestToWorkEffort, run throught seca * createWorkEffortStatus createWorkEffortAndPartyAssign use the entity-auto logic so create services createWorkEffortPartyAssignment, updateWorkEffortPartyAssignment and expireWorkEffortPartyAssignment to make them more generic -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12965) Convert WorkEffortServices.xml mini-lang to groovyDSL (partial)
Nicolas Malin created OFBIZ-12965: - Summary: Convert WorkEffortServices.xml mini-lang to groovyDSL (partial) Key: OFBIZ-12965 URL: https://issues.apache.org/jira/browse/OFBIZ-12965 Project: OFBiz Issue Type: Sub-task Components: workeffort Reporter: Nicolas Malin Assignee: Nicolas Malin Convert the following service : * createWorkEffort * updateWorkEffort * deleteWorkEffort * copyWorkEffort * createWorkEffortAndPartyAssign createWorkEffort contains too functionnal logic on the base code so split it on different services and intoduce : * assocAcceptedCustRequestToWorkEffort, run throught seca * createWorkEffortStatus createWorkEffortAndPartyAssign use the entity-auto logic so create services createWorkEffortPartyAssignment, updateWorkEffortPartyAssignment and expireWorkEffortPartyAssignment to make them more generic -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12962) Convert PeriodServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830921#comment-17830921 ] Nicolas Malin commented on OFBIZ-12962: --- Oh thanks Jacques for your fix ! > Convert PeriodServices.xml mini-lang to groovyDSL > - > > Key: OFBIZ-12962 > URL: https://issues.apache.org/jira/browse/OFBIZ-12962 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Assignee: Jacques Le Roux >Priority: Minor > Labels: groovy, mini-lang > > Migration of file PeriodServices.xml to groovy with service : > * findCustomTimePeriods > * getPreviousTimePeriod -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12962) Convert PeriodServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12962. - Resolution: Done > Convert PeriodServices.xml mini-lang to groovyDSL > - > > Key: OFBIZ-12962 > URL: https://issues.apache.org/jira/browse/OFBIZ-12962 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > > Migration of file PeriodServices.xml to groovy with service : > * findCustomTimePeriods > * getPreviousTimePeriod -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12962) Convert PeriodServices.xml mini-lang to groovyDSL
Nicolas Malin created OFBIZ-12962: - Summary: Convert PeriodServices.xml mini-lang to groovyDSL Key: OFBIZ-12962 URL: https://issues.apache.org/jira/browse/OFBIZ-12962 Project: OFBiz Issue Type: Sub-task Components: accounting Reporter: Nicolas Malin Assignee: Nicolas Malin Migration of file PeriodServices.xml to groovy with service : * findCustomTimePeriods * getPreviousTimePeriod -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (OFBIZ-12875) Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reopened OFBIZ-12875: --- > Use screen engine for the request getJSONuilabels > - > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: 22.01.01, 18.12.10 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12875) Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12875. - Resolution: Done > Use screen engine for the request getJSONuilabels > - > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: 22.01.01, 18.12.10 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12875) Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12875. - Fix Version/s: 22.01.01 18.12.11 Resolution: Fixed Commit on different release : * 18.12 : 82c17376880a8fd8a11261e1e00dad45cfed344d (https://github.com/apache/ofbiz-framework/commit/82c17376880a8fd8a11261e1e00dad45cfed344d) * 22.01 : ad98d7807682ad346b200f08b90436b10082416f (https://github.com/apache/ofbiz-framework/commit/ad98d7807682ad346b200f08b90436b10082416f) * trunk : b87ff9e5b62d46bcf37f15e4a3f4c217cfd83ca9 (https://github.com/apache/ofbiz-framework/commit/b87ff9e5b62d46bcf37f15e4a3f4c217cfd83ca9) > Use screen engine for the request getJSONuilabels > - > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: 22.01.01, 18.12.10 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12875) Use screen engine for the request getJSONuilabels
[ https://issues.apache.org/jira/browse/OFBIZ-12875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12875: -- Affects Version/s: 22.01 (was: 22.01.01) > Use screen engine for the request getJSONuilabels > - > > Key: OFBIZ-12875 > URL: https://issues.apache.org/jira/browse/OFBIZ-12875 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: 18.12.10, 22.01 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01, 18.12.11 > > > Before this improvement, you can resolve a list of labels to display with the > uiLabel resource file > like : "CommonUiLabels" : ["CommonUpload", "CommonSave", > "CommonCompleted"] > > We remove the possibility to specify a uiLabel resource file and make it > work by default with CommonUiLabels. > After that we implement the json return on extend theme screen so we can > add some uiLabel ressource by theme extension or component screen definition. > > Other enhancement, on getJSONuiLabels instead resolve the label with a > list position you can call your label with it key. > resolve : uiLabelJsonObjects.CommonUiLabels[1] >become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12875) Use screen engine for the request getJSONuilabels
Nicolas Malin created OFBIZ-12875: - Summary: Use screen engine for the request getJSONuilabels Key: OFBIZ-12875 URL: https://issues.apache.org/jira/browse/OFBIZ-12875 Project: OFBiz Issue Type: Improvement Components: framework/common Affects Versions: 18.12.10, 22.01.01 Reporter: Nicolas Malin Assignee: Nicolas Malin Before this improvement, you can resolve a list of labels to display with the uiLabel resource file like : "CommonUiLabels" : ["CommonUpload", "CommonSave", "CommonCompleted"] We remove the possibility to specify a uiLabel resource file and make it work by default with CommonUiLabels. After that we implement the json return on extend theme screen so we can add some uiLabel ressource by theme extension or component screen definition. Other enhancement, on getJSONuiLabels instead resolve the label with a list position you can call your label with it key. resolve : uiLabelJsonObjects.CommonUiLabels[1] become : uiLabelJsonObjects.CommonSave -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12287) UserLoginHistory failed the store operation with large password
[
https://issues.apache.org/jira/browse/OFBIZ-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797325#comment-17797325
]
Nicolas Malin commented on OFBIZ-12287:
---
Yes sure and we can do both.
I'll commit a fix on the day with that.
> UserLoginHistory failed the store operation with large password
> ---
>
> Key: OFBIZ-12287
> URL: https://issues.apache.org/jira/browse/OFBIZ-12287
> Project: OFBiz
> Issue Type: Bug
> Components: framework/security
>Affects Versions: Trunk, 17.12.07, 18.12.01
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: Release Branch 18.12, Release Branch 17.12
>
> Attachments: OFBIZ-12287.patch
>
>
> When you have a user with long password (greater than 256 characters) present
> in OFBiz and you try to log with, OFBiz return a long error message with
> sensitive information.
> {code:java}
> Error saving UserLoginHistory and updating login status to reset
> hasLoggedOut, unsuccessful login count, etc.:
> org.apache.ofbiz.entity.GenericEntityException:
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
> [GenericEntity:UserLoginHistory][createdStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][createdTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][fromDate,2021-07-21
> 16:42:18.809(java.sql.Timestamp)][lastUpdatedStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][lastUpdatedTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][partyId,10010(java.lang.String)][passwordUsed,$SHA$l1rQ$i9Js3M3Mx3uQr4N1r8F6Jtj8dzQ(java.lang.String)][successfulLogin,N(java.lang.String)][userLoginId,lolo(java.lang.String)][visitId,10103(java.lang.String)]
> (SQL Exception while executing the following:null (A truncation error was
> encountered trying to shrink VARCHAR
> 'k+f3Qyf7vGwy/7lAh7xB3zerfnUUAZnx3Bkc9hMbQJxSt+wzeyj+plWWsHRa&' to length
> 255.)) (Error while inserting:
> [GenericEntity:UserLoginHistory][createdStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][createdTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][fromDate,2021-07-21
> 16:42:18.809(java.sql.Timestamp)][lastUpdatedStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][lastUpdatedTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][partyId,10010(java.lang.String)][passwordUsed,$SHA$l1rQ$i9Js3M3Mx3uQr4N1r8F6Jtj8dzQ(java.lang.String)][successfulLogin,N(java.lang.String)][userLoginId,lolo(java.lang.String)][visitId,10103(java.lang.String)]
> (SQL Exception while executing the following:null (A truncation error was
> encountered trying to shrink VARCHAR
> 'k+f3Qyf7vGwy/7lAh7xB3zerfnUUAZnx3Bkc9hMbQJxSt+wzeyj+plWWsHRa&' to length
> 255.)))
> {code}
> The error come from LoginService.java:353 that try to store without check
> the password size.
> This issue has been raise by Daniel Elkabes
> and Hagai Wechsler
> from white source software, many
> thanks to them !
> To solve this I suggest to don't return any information on the genericValue
> that failed and analyse the field passwordUsed to store to escape an
> unusefull error.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12287) UserLoginHistory failed the store operation with large password
[
https://issues.apache.org/jira/browse/OFBIZ-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17797225#comment-17797225
]
Nicolas Malin commented on OFBIZ-12287:
---
If you want we can simply pass the value to false as default. After that the
plateform administrator take the risk to use this functionnality
> UserLoginHistory failed the store operation with large password
> ---
>
> Key: OFBIZ-12287
> URL: https://issues.apache.org/jira/browse/OFBIZ-12287
> Project: OFBiz
> Issue Type: Bug
> Components: framework/security
>Affects Versions: Trunk, 17.12.07, 18.12.01
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: Release Branch 18.12, Release Branch 17.12
>
> Attachments: OFBIZ-12287.patch
>
>
> When you have a user with long password (greater than 256 characters) present
> in OFBiz and you try to log with, OFBiz return a long error message with
> sensitive information.
> {code:java}
> Error saving UserLoginHistory and updating login status to reset
> hasLoggedOut, unsuccessful login count, etc.:
> org.apache.ofbiz.entity.GenericEntityException:
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting:
> [GenericEntity:UserLoginHistory][createdStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][createdTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][fromDate,2021-07-21
> 16:42:18.809(java.sql.Timestamp)][lastUpdatedStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][lastUpdatedTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][partyId,10010(java.lang.String)][passwordUsed,$SHA$l1rQ$i9Js3M3Mx3uQr4N1r8F6Jtj8dzQ(java.lang.String)][successfulLogin,N(java.lang.String)][userLoginId,lolo(java.lang.String)][visitId,10103(java.lang.String)]
> (SQL Exception while executing the following:null (A truncation error was
> encountered trying to shrink VARCHAR
> 'k+f3Qyf7vGwy/7lAh7xB3zerfnUUAZnx3Bkc9hMbQJxSt+wzeyj+plWWsHRa&' to length
> 255.)) (Error while inserting:
> [GenericEntity:UserLoginHistory][createdStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][createdTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][fromDate,2021-07-21
> 16:42:18.809(java.sql.Timestamp)][lastUpdatedStamp,2021-07-21
> 16:42:18.81(java.sql.Timestamp)][lastUpdatedTxStamp,2021-07-21
> 16:42:18.804(java.sql.Timestamp)][partyId,10010(java.lang.String)][passwordUsed,$SHA$l1rQ$i9Js3M3Mx3uQr4N1r8F6Jtj8dzQ(java.lang.String)][successfulLogin,N(java.lang.String)][userLoginId,lolo(java.lang.String)][visitId,10103(java.lang.String)]
> (SQL Exception while executing the following:null (A truncation error was
> encountered trying to shrink VARCHAR
> 'k+f3Qyf7vGwy/7lAh7xB3zerfnUUAZnx3Bkc9hMbQJxSt+wzeyj+plWWsHRa&' to length
> 255.)))
> {code}
> The error come from LoginService.java:353 that try to store without check
> the password size.
> This issue has been raise by Daniel Elkabes
> and Hagai Wechsler
> from white source software, many
> thanks to them !
> To solve this I suggest to don't return any information on the genericValue
> that failed and analyse the field passwordUsed to store to escape an
> unusefull error.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12852) Convert FixedAssetServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12852. - Resolution: Done > Convert FixedAssetServices.xml mini lang to groovy > -- > > Key: OFBIZ-12852 > URL: https://issues.apache.org/jira/browse/OFBIZ-12852 > Project: OFBiz > Issue Type: Sub-task > Components: content >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > Finish to convert FixedAssetServices.xml with migrate service : > * createFixedAssetMaint > * updateFixedAssetMaint > * createMaintsFromTimeInterval > * autoAssignFixedAssetPartiesToMaintenance > * createMaintsFromMeterReading > * createFixedAssetMaintOrder > * checkUpdateFixedAssetDepreciation > * straightLineDepreciation > * doubleDecliningBalanceDepreciation > * calculateFixedAssetDepreciation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12852) Convert FixedAssetServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12852: -- Description: Finish to convert FixedAssetServices.xml with migrate service : * createFixedAssetMaint * updateFixedAssetMaint * createMaintsFromTimeInterval * autoAssignFixedAssetPartiesToMaintenance * createMaintsFromMeterReading * createFixedAssetMaintOrder * checkUpdateFixedAssetDepreciation * straightLineDepreciation * doubleDecliningBalanceDepreciation * calculateFixedAssetDepreciation was: Finish to convert ContentServices.xml with migrate service : * copyContentAndElectronicTextandAssoc * removeContentAndRelated * assocContent * getPublicForumMessage -> move only on service definition Move as deprecated : * assocContent * getPublicForumMessage * checkContentPermission * checkAssocPermission > Convert FixedAssetServices.xml mini lang to groovy > -- > > Key: OFBIZ-12852 > URL: https://issues.apache.org/jira/browse/OFBIZ-12852 > Project: OFBiz > Issue Type: Sub-task > Components: content >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > Finish to convert FixedAssetServices.xml with migrate service : > * createFixedAssetMaint > * updateFixedAssetMaint > * createMaintsFromTimeInterval > * autoAssignFixedAssetPartiesToMaintenance > * createMaintsFromMeterReading > * createFixedAssetMaintOrder > * checkUpdateFixedAssetDepreciation > * straightLineDepreciation > * doubleDecliningBalanceDepreciation > * calculateFixedAssetDepreciation -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12852) Convert FixedAssetServices.xml mini lang to groovy
Nicolas Malin created OFBIZ-12852: - Summary: Convert FixedAssetServices.xml mini lang to groovy Key: OFBIZ-12852 URL: https://issues.apache.org/jira/browse/OFBIZ-12852 Project: OFBiz Issue Type: Sub-task Components: content Reporter: Nicolas Malin Assignee: Nicolas Malin Finish to convert ContentServices.xml with migrate service : * copyContentAndElectronicTextandAssoc * removeContentAndRelated * assocContent * getPublicForumMessage -> move only on service definition Move as deprecated : * assocContent * getPublicForumMessage * checkContentPermission * checkAssocPermission -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12827) Convert ContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12827. - Resolution: Done > Convert ContentServices.xml mini lang to groovy > --- > > Key: OFBIZ-12827 > URL: https://issues.apache.org/jira/browse/OFBIZ-12827 > Project: OFBiz > Issue Type: Sub-task > Components: content >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > Finish to convert ContentServices.xml with migrate service : > * copyContentAndElectronicTextandAssoc > * removeContentAndRelated > * assocContent > * getPublicForumMessage -> move only on service definition > Move as deprecated : > * assocContent > * getPublicForumMessage > * checkContentPermission > * checkAssocPermission -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11388) Convert createMissingContentAltUrls service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-11388. - Resolution: Done Loaded in trunk with the OFBIZ-11387 thanks [~devanshu] > Convert createMissingContentAltUrls service from mini-lang to groovy DSL > > > Key: OFBIZ-11388 > URL: https://issues.apache.org/jira/browse/OFBIZ-11388 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Sourabh Punyani >Priority: Major > Attachments: OFBIZ-11388.patch > > > Convert createMissingContentAltUrls service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11387) Convert createMissingCategoryContentAltUrlInline service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-11387. - Resolution: Done Loaded in trunk thanks [~devanshu] > Convert createMissingCategoryContentAltUrlInline service from mini-lang to > groovy DSL > - > > Key: OFBIZ-11387 > URL: https://issues.apache.org/jira/browse/OFBIZ-11387 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-11387.patch > > > Convert createMissingCategoryContentAltUrlInline service code from mini-lang > to groovy DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12827) Convert ContentServices.xml mini lang to groovy
Nicolas Malin created OFBIZ-12827: - Summary: Convert ContentServices.xml mini lang to groovy Key: OFBIZ-12827 URL: https://issues.apache.org/jira/browse/OFBIZ-12827 Project: OFBiz Issue Type: Sub-task Components: content Reporter: Nicolas Malin Assignee: Nicolas Malin Finish to convert ContentServices.xml with migrate service : * copyContentAndElectronicTextandAssoc * removeContentAndRelated * assocContent * getPublicForumMessage -> move only on service definition Move as deprecated : * assocContent * getPublicForumMessage * checkContentPermission * checkAssocPermission -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-11378) Convert createCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-11378: - Assignee: Nicolas Malin (was: Anushi Gupta) > Convert createCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11378 > URL: https://issues.apache.org/jira/browse/OFBIZ-11378 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Minor > Attachments: OFBIZ-11378.patch > > > Convert createCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-11387) Convert createMissingCategoryContentAltUrlInline service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-11387: - Assignee: Nicolas Malin (was: Anushi Gupta) > Convert createMissingCategoryContentAltUrlInline service from mini-lang to > groovy DSL > - > > Key: OFBIZ-11387 > URL: https://issues.apache.org/jira/browse/OFBIZ-11387 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk, Upcoming Branch >Reporter: Devanshu Vyas >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-11387.patch > > > Convert createMissingCategoryContentAltUrlInline service code from mini-lang > to groovy DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Reopened] (OFBIZ-12823) Improve FileUtil to generate a zip fil with multiple entries
[ https://issues.apache.org/jira/browse/OFBIZ-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reopened OFBIZ-12823: --- > Improve FileUtil to generate a zip fil with multiple entries > > > Key: OFBIZ-12823 > URL: https://issues.apache.org/jira/browse/OFBIZ-12823 > Project: OFBiz > Issue Type: Improvement > Components: framework/base >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: util, zip > Attachments: OFBIZ-12823.patch > > > At this time the function to generate a zip file : FileUtil::zipFileStream > (FileUtil:345) offert to possibility to add only one file. > I propose to improve this with a new function zipFileStreams that take a > input map with file name as key and inputStream as value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12823) Improve FileUtil to generate a zip fil with multiple entries
[ https://issues.apache.org/jira/browse/OFBIZ-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12823. - Resolution: Done > Improve FileUtil to generate a zip fil with multiple entries > > > Key: OFBIZ-12823 > URL: https://issues.apache.org/jira/browse/OFBIZ-12823 > Project: OFBiz > Issue Type: Improvement > Components: framework/base >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: util, zip > Attachments: OFBIZ-12823.patch > > > At this time the function to generate a zip file : FileUtil::zipFileStream > (FileUtil:345) offert to possibility to add only one file. > I propose to improve this with a new function zipFileStreams that take a > input map with file name as key and inputStream as value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11443) Convert FixedAssetMaintServices.xml to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-11443. - Resolution: Done Loaded on ofbiz-plugins trunk, Thanks [~rohit.koushal] > Convert FixedAssetMaintServices.xml to groovy > - > > Key: OFBIZ-11443 > URL: https://issues.apache.org/jira/browse/OFBIZ-11443 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Trunk, Upcoming Branch >Reporter: Pierre Smits >Assignee: Rohit Koushal >Priority: Major > Labels: refactoring > Attachments: OFBIZ-11443.patch > > > Convert from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12823) Improve FileUtil to generate a zip fil with multiple entries
[ https://issues.apache.org/jira/browse/OFBIZ-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12823. - Resolution: Fixed Loaded on trunk > Improve FileUtil to generate a zip fil with multiple entries > > > Key: OFBIZ-12823 > URL: https://issues.apache.org/jira/browse/OFBIZ-12823 > Project: OFBiz > Issue Type: Improvement > Components: framework/base >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: util, zip > Attachments: OFBIZ-12823.patch > > > At this time the function to generate a zip file : FileUtil::zipFileStream > (FileUtil:345) offert to possibility to add only one file. > I propose to improve this with a new function zipFileStreams that take a > input map with file name as key and inputStream as value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12823) Improve FileUtil to generate a zip fil with multiple entries
[ https://issues.apache.org/jira/browse/OFBIZ-12823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12823: -- Attachment: OFBIZ-12823.patch > Improve FileUtil to generate a zip fil with multiple entries > > > Key: OFBIZ-12823 > URL: https://issues.apache.org/jira/browse/OFBIZ-12823 > Project: OFBiz > Issue Type: Improvement > Components: framework/base >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: util, zip > Attachments: OFBIZ-12823.patch > > > At this time the function to generate a zip file : FileUtil::zipFileStream > (FileUtil:345) offert to possibility to add only one file. > I propose to improve this with a new function zipFileStreams that take a > input map with file name as key and inputStream as value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12823) Improve FileUtil to generate a zip fil with multiple entries
Nicolas Malin created OFBIZ-12823: - Summary: Improve FileUtil to generate a zip fil with multiple entries Key: OFBIZ-12823 URL: https://issues.apache.org/jira/browse/OFBIZ-12823 Project: OFBiz Issue Type: Improvement Components: framework/base Reporter: Nicolas Malin Assignee: Nicolas Malin At this time the function to generate a zip file : FileUtil::zipFileStream (FileUtil:345) offert to possibility to add only one file. I propose to improve this with a new function zipFileStreams that take a input map with file name as key and inputStream as value. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12761) Multi Param Model Service Map
[ https://issues.apache.org/jira/browse/OFBIZ-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12761. - Resolution: Done I loaded it only on trunk this is an improvement. > Multi Param Model Service Map > - > > Key: OFBIZ-12761 > URL: https://issues.apache.org/jira/browse/OFBIZ-12761 > Project: OFBiz > Issue Type: Improvement > Components: framework/service >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Gaetan Chaboussie >Assignee: Nicolas Malin >Priority: Minor > Labels: patch > Attachments: MultiParamServiceMapAndTest.patch > > > Hello community. > We had a use case with the need for validation of IN params of services. > For example we had to check that the following service definition was > correctly filled. > ```xml > invoke="exampleService" transaction-timeout="7200"> > Service example use case with internal attributes to > validate > > > > > > > ``` > As is, the framework doesn't offer any clean way of doing this, so we > implemented some modification to ModelService. > So we used TDD to develop the improvement we needed and that may prove a > valuable improvement for the framework. > Using these tests, we took the opportunity to refactor outdated code using > java streams. > Please see the patch attached to the ticket containing code and tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12761) Multi Param Model Service Map
[ https://issues.apache.org/jira/browse/OFBIZ-12761?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12761: - Assignee: Nicolas Malin > Multi Param Model Service Map > - > > Key: OFBIZ-12761 > URL: https://issues.apache.org/jira/browse/OFBIZ-12761 > Project: OFBiz > Issue Type: Improvement > Components: framework/service >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Gaetan Chaboussie >Assignee: Nicolas Malin >Priority: Minor > Labels: patch > Attachments: MultiParamServiceMapAndTest.patch > > > Hello community. > We had a use case with the need for validation of IN params of services. > For example we had to check that the following service definition was > correctly filled. > ```xml > invoke="exampleService" transaction-timeout="7200"> > Service example use case with internal attributes to > validate > > > > > > > ``` > As is, the framework doesn't offer any clean way of doing this, so we > implemented some modification to ModelService. > So we used TDD to develop the improvement we needed and that may prove a > valuable improvement for the framework. > Using these tests, we took the opportunity to refactor outdated code using > java streams. > Please see the patch attached to the ticket containing code and tests. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12749) Use non string parameters on a update-area failed when comme from a JWToken
[
https://issues.apache.org/jira/browse/OFBIZ-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12749.
-
Resolution: Fixed
> Use non string parameters on a update-area failed when comme from a JWToken
> ---
>
> Key: OFBIZ-12749
> URL: https://issues.apache.org/jira/browse/OFBIZ-12749
> Project: OFBiz
> Issue Type: Bug
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
>
> When define a update-area with some parameters as List or Map the conversion
> failed due to a bad management of this case when the creation come from a
> JWToken.
> {code:xml}
>
>
>
>
>
>
>
>
> {code}
> The link generate for the callback contains the variable myField with the
> class name and not serialized List "{_}['myCase']"{_}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12749) Use non string parameters on a update-area failed when comme from a JWToken
[
https://issues.apache.org/jira/browse/OFBIZ-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12749:
--
Description:
When define a update-area with some parameters as List or Map the conversion
failed due to a bad management of this case when the creation come from a
JWToken.
{code:xml}
{code}
The link generate for the callback contains the variable myField with the class
name and not serialized List "{_}['myCase']"{_}
was:
When define a update-area with some parameters as List or Map the conversion
failed due to a bad management of this case
{code:xml}
{code}
The link contains the variable myField with the class name and not
serialization _['myCase']_
> Use non string parameters on a update-area failed when comme from a JWToken
> ---
>
> Key: OFBIZ-12749
> URL: https://issues.apache.org/jira/browse/OFBIZ-12749
> Project: OFBiz
> Issue Type: Bug
>Reporter: Nicolas Malin
>Priority: Minor
>
> When define a update-area with some parameters as List or Map the conversion
> failed due to a bad management of this case when the creation come from a
> JWToken.
> {code:xml}
>
>
>
>
>
>
>
>
> {code}
> The link generate for the callback contains the variable myField with the
> class name and not serialized List "{_}['myCase']"{_}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12749) Use non string parameters on a update-area failed when comme from a JWToken
[
https://issues.apache.org/jira/browse/OFBIZ-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12749:
--
Summary: Use non string parameters on a update-area failed when comme from
a JWToken (was: Use non string parameters on a update-area failed)
> Use non string parameters on a update-area failed when comme from a JWToken
> ---
>
> Key: OFBIZ-12749
> URL: https://issues.apache.org/jira/browse/OFBIZ-12749
> Project: OFBiz
> Issue Type: Bug
>Reporter: Nicolas Malin
>Priority: Minor
>
> When define a update-area with some parameters as List or Map the conversion
> failed due to a bad management of this case
> {code:xml}
>
>
>
>
>
>
> {code}
> The link contains the variable myField with the class name and not
> serialization _['myCase']_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (OFBIZ-12749) Use non string parameters on a update-area failed
Nicolas Malin created OFBIZ-12749:
-
Summary: Use non string parameters on a update-area failed
Key: OFBIZ-12749
URL: https://issues.apache.org/jira/browse/OFBIZ-12749
Project: OFBiz
Issue Type: Bug
Reporter: Nicolas Malin
When define a update-area with some parameters as List or Map the conversion
failed due to a bad management of this case
{code:xml}
{code}
The link contains the variable myField with the class name and not
serialization _['myCase']_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12748) Add CommonDynamicMulti generic form on the theming engine
[ https://issues.apache.org/jira/browse/OFBIZ-12748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12748. - Assignee: Nicolas Malin Resolution: Implemented > Add CommonDynamicMulti generic form on the theming engine > - > > Key: OFBIZ-12748 > URL: https://issues.apache.org/jira/browse/OFBIZ-12748 > Project: OFBiz > Issue Type: Improvement > Components: themes >Affects Versions: Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > To manage the multi form on the theming engine we added a new generic form > CommonDynamicMulti to help the theme to implement how rendering all them. > Example : > extends="CommonDynamicMulti" > extends-resource="component://common/widget/CommonForms.xml"> > ... > With this implementation, OFBiz can generate automatically the dynamic sort , > dynamic pagination and manage the presence of callback. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12748) Add CommonDynamicMulti generic form on the theming engine
Nicolas Malin created OFBIZ-12748: - Summary: Add CommonDynamicMulti generic form on the theming engine Key: OFBIZ-12748 URL: https://issues.apache.org/jira/browse/OFBIZ-12748 Project: OFBiz Issue Type: Improvement Components: themes Affects Versions: Upcoming Branch Reporter: Nicolas Malin To manage the multi form on the theming engine we added a new generic form CommonDynamicMulti to help the theme to implement how rendering all them. Example : ... With this implementation, OFBiz can generate automatically the dynamic sort , dynamic pagination and manage the presence of callback. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12745) Convert RequirementServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-12745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12745. - Resolution: Implemented > Convert RequirementServices.xml mini lang to groovy > --- > > Key: OFBIZ-12745 > URL: https://issues.apache.org/jira/browse/OFBIZ-12745 > Project: OFBiz > Issue Type: Sub-task >Reporter: Nicolas Malin >Priority: Minor > > Convert the following services : > * deleteRequirementAndRelated > * autoAssignRequirementToSupplier > * createTransferFromRequirement -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12747) Add missing french label on content component
[ https://issues.apache.org/jira/browse/OFBIZ-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12747. - Resolution: Implemented > Add missing french label on content component > - > > Key: OFBIZ-12747 > URL: https://issues.apache.org/jira/browse/OFBIZ-12747 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Trivial > Labels: label > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12747) Add missing french label on content component
Nicolas Malin created OFBIZ-12747: - Summary: Add missing french label on content component Key: OFBIZ-12747 URL: https://issues.apache.org/jira/browse/OFBIZ-12747 Project: OFBiz Issue Type: Improvement Components: content Reporter: Nicolas Malin Assignee: Nicolas Malin -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12746) Form field attribute tooltip-style didn't propage
[ https://issues.apache.org/jira/browse/OFBIZ-12746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12746. - Fix Version/s: 22.01.01 Resolution: Fixed > Form field attribute tooltip-style didn't propage > - > > Key: OFBIZ-12746 > URL: https://issues.apache.org/jira/browse/OFBIZ-12746 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: 22.01.01 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Trivial > Fix For: 22.01.01 > > > The form field attribute tooltip-style didn't propage between the xml > definition to macro rendering. > The problem came from the RenderableFtlFormElementBuilder witch resolved the > tooltip style value from the attribute "title-style" and not the > "tooltip-style" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12746) Form field attribute tooltip-style didn't propage
[ https://issues.apache.org/jira/browse/OFBIZ-12746?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12746: -- Priority: Trivial (was: Major) > Form field attribute tooltip-style didn't propage > - > > Key: OFBIZ-12746 > URL: https://issues.apache.org/jira/browse/OFBIZ-12746 > Project: OFBiz > Issue Type: Bug > Components: framework/widget >Affects Versions: 22.01.01 >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Trivial > > The form field attribute tooltip-style didn't propage between the xml > definition to macro rendering. > The problem came from the RenderableFtlFormElementBuilder witch resolved the > tooltip style value from the attribute "title-style" and not the > "tooltip-style" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12746) Form field attribute tooltip-style didn't propage
Nicolas Malin created OFBIZ-12746: - Summary: Form field attribute tooltip-style didn't propage Key: OFBIZ-12746 URL: https://issues.apache.org/jira/browse/OFBIZ-12746 Project: OFBiz Issue Type: Bug Components: framework/widget Affects Versions: 22.01.01 Reporter: Nicolas Malin Assignee: Nicolas Malin The form field attribute tooltip-style didn't propage between the xml definition to macro rendering. The problem came from the RenderableFtlFormElementBuilder witch resolved the tooltip style value from the attribute "title-style" and not the "tooltip-style" -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12745) Convert RequirementServices.xml mini lang to groovy
Nicolas Malin created OFBIZ-12745: - Summary: Convert RequirementServices.xml mini lang to groovy Key: OFBIZ-12745 URL: https://issues.apache.org/jira/browse/OFBIZ-12745 Project: OFBiz Issue Type: Sub-task Reporter: Nicolas Malin Convert the following services : * deleteRequirementAndRelated * autoAssignRequirementToSupplier * createTransferFromRequirement -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12725. - Resolution: Fixed Thanks Florian for the work and all for the look :) [~jleroux] I propose to keep Rainbow as defaut theme, we need to check Helveticus on catalog screen and order, I thinks some works need to do. > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652430#comment-17652430 ] Nicolas Malin commented on OFBIZ-12725: --- Thanks [~priyasharma] we will check this > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12725: - Assignee: Nicolas Malin (was: Jacques Le Roux) > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652429#comment-17652429 ] Nicolas Malin commented on OFBIZ-12725: --- [~jleroux] I will take it > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: helvetica-improved.png, helvetica.png, > image-2022-12-27-12-29-02-978.png, image-2022-12-27-12-32-26-819.png, > rainbow.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12725) Cannot expand tree of accounts in Navigate Accounts screen with Helveticus theme
[ https://issues.apache.org/jira/browse/OFBIZ-12725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17652253#comment-17652253 ] Nicolas Malin commented on OFBIZ-12725: --- [~FloMo] if this solve this issue, we can move forward :) > Cannot expand tree of accounts in Navigate Accounts screen with Helveticus > theme > > > Key: OFBIZ-12725 > URL: https://issues.apache.org/jira/browse/OFBIZ-12725 > Project: OFBiz > Issue Type: Sub-task > Components: accounting, themes/helveticus >Affects Versions: 22.01.01 >Reporter: Daniel Watford >Priority: Major > Fix For: 22.01.01 > > Attachments: image-2022-12-27-12-29-02-978.png, > image-2022-12-27-12-32-26-819.png > > > Viewing [OFBiz: Accounting Manager: Navigate Accounts > (apache.org)|https://demo-next.ofbiz.apache.org/accounting/control/GlAccountNavigate?trail=null], > it is not possible to expand the chart-of-accounts tree when the Helveticus > visual theme is used. > The Helveticus theme is the default theme for new deployments. > A workaround is to switch to a non-Helveticus theme. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12652) Define return user message from controller or context
[
https://issues.apache.org/jira/browse/OFBIZ-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12652.
-
Resolution: Implemented
> Define return user message from controller or context
> -
>
> Key: OFBIZ-12652
> URL: https://issues.apache.org/jira/browse/OFBIZ-12652
> Project: OFBiz
> Issue Type: New Feature
> Components: framework/webapp
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Labels: event, message, user-experience
> Attachments: OFBIZ-12652.patch
>
>
> Currently when you wish return a message to a user after an event request,
> you need to set it ine the called event.
> for a service in java :
> {code:java}
> ServiceUtil.returnSuccess("Your service is a success"){code}
>
> for a service in groovy :
> {code:java}
> return success("Your service is a success"){code}
>
> for a Java class :
> {code:java}
> request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");{code}
>
> If during an integration, you want to use standard service like
> createProduct, createPartyRelationship, and need a specific message for
> users, you need to define you own service.
> For escape this case and increase the service reusability, I propose to
> implement a new systeme to override the event return by a definition
> depending the buisness context.
> For that two improvement :
> 1. Add new child element to reques-map->response on the controller
> * With given the exact value
> {code:java}
>
>
> {code}
>
> * With a flexible expander
> {code:java}
>
>
>
> {code}
>
> * With a property
> {code:java}
>
> value="CommonSuccessfullyCreated"/>
>
> {code}
> * From a context field
> {code:java}
>
>
>
> {code}
> 2. From the context directly sent from the form
> {code:java}
>
>
> {code}
>
> related thread on dev :
> [https://lists.apache.org/thread/bv46xndbny6phfxycbmbmxs4t2n7jr28]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12652) Define return user message from controller or context
[
https://issues.apache.org/jira/browse/OFBIZ-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12652:
--
Affects Version/s: (was: 22.01.01)
> Define return user message from controller or context
> -
>
> Key: OFBIZ-12652
> URL: https://issues.apache.org/jira/browse/OFBIZ-12652
> Project: OFBiz
> Issue Type: New Feature
> Components: framework/webapp
>Affects Versions: Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Labels: event, message, user-experience
> Attachments: OFBIZ-12652.patch
>
>
> Currently when you wish return a message to a user after an event request,
> you need to set it ine the called event.
> for a service in java :
> {code:java}
> ServiceUtil.returnSuccess("Your service is a success"){code}
>
> for a service in groovy :
> {code:java}
> return success("Your service is a success"){code}
>
> for a Java class :
> {code:java}
> request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");{code}
>
> If during an integration, you want to use standard service like
> createProduct, createPartyRelationship, and need a specific message for
> users, you need to define you own service.
> For escape this case and increase the service reusability, I propose to
> implement a new systeme to override the event return by a definition
> depending the buisness context.
> For that two improvement :
> 1. Add new child element to reques-map->response on the controller
> * With given the exact value
> {code:java}
>
>
> {code}
>
> * With a flexible expander
> {code:java}
>
>
>
> {code}
>
> * With a property
> {code:java}
>
> value="CommonSuccessfullyCreated"/>
>
> {code}
> * From a context field
> {code:java}
>
>
>
> {code}
> 2. From the context directly sent from the form
> {code:java}
>
>
> {code}
>
> related thread on dev :
> [https://lists.apache.org/thread/bv46xndbny6phfxycbmbmxs4t2n7jr28]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12665) Calendar in Work Effort does not work
[ https://issues.apache.org/jira/browse/OFBIZ-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12665: -- Fix Version/s: 22.01.01 > Calendar in Work Effort does not work > - > > Key: OFBIZ-12665 > URL: https://issues.apache.org/jira/browse/OFBIZ-12665 > Project: OFBiz > Issue Type: Bug > Components: workeffort/workeffort >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: OFBIZ-12665.patch > > > I stumbled upon it while checking OFBIZ-12557. 22.01 is OK so must be a > recent issue and it's OFBIZ-12557 unrelated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12628) MenuItem doesn't follow correctly extend information
[
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12628.
-
Resolution: Fixed
> MenuItem doesn't follow correctly extend information
>
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the
> first menu on their model.
>
> {code:java}
> extends-resource="component://common/widget/CommonMenus.xml">
>
>
>
>
> {code}
> The result, if during the rendering some information are generate from the
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and
> MenuLink in memory with the new parent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12665) Calendar in Work Effort does not work
[ https://issues.apache.org/jira/browse/OFBIZ-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12665. - Resolution: Fixed thanks for the return Jacques, I pushed trunk > Calendar in Work Effort does not work > - > > Key: OFBIZ-12665 > URL: https://issues.apache.org/jira/browse/OFBIZ-12665 > Project: OFBiz > Issue Type: Bug > Components: workeffort/workeffort >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-12665.patch > > > I stumbled upon it while checking OFBIZ-12557. 22.01 is OK so must be a > recent issue and it's OFBIZ-12557 unrelated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12665) Calendar in Work Effort does not work
[ https://issues.apache.org/jira/browse/OFBIZ-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12665: - Assignee: Nicolas Malin (was: Jacques Le Roux) > Calendar in Work Effort does not work > - > > Key: OFBIZ-12665 > URL: https://issues.apache.org/jira/browse/OFBIZ-12665 > Project: OFBiz > Issue Type: Bug > Components: workeffort/workeffort >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Nicolas Malin >Priority: Major > Attachments: OFBIZ-12665.patch > > > I stumbled upon it while checking OFBIZ-12557. 22.01 is OK so must be a > recent issue and it's OFBIZ-12557 unrelated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12669) Convert StorageServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12669. - Resolution: Done > Convert StorageServices.xml mini-lang to groovyDSL > -- > > Key: OFBIZ-12669 > URL: https://issues.apache.org/jira/browse/OFBIZ-12669 > Project: OFBiz > Issue Type: Sub-task > Components: product/facility >Affects Versions: Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > Convert the service createFacilityLocation from mini-lang to groovyDSL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12669) Convert StorageServices.xml mini-lang to groovyDSL
Nicolas Malin created OFBIZ-12669: - Summary: Convert StorageServices.xml mini-lang to groovyDSL Key: OFBIZ-12669 URL: https://issues.apache.org/jira/browse/OFBIZ-12669 Project: OFBiz Issue Type: Sub-task Components: product/facility Affects Versions: Upcoming Branch Reporter: Nicolas Malin Assignee: Nicolas Malin Convert the service createFacilityLocation from mini-lang to groovyDSL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-9350) Deprecate Mini Lang
[ https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-9350: Assignee: Nicolas Malin (was: Michael Brohl) > Deprecate Mini Lang > --- > > Key: OFBIZ-9350 > URL: https://issues.apache.org/jira/browse/OFBIZ-9350 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk, Upcoming Branch >Reporter: Michael Brohl >Assignee: Nicolas Malin >Priority: Minor > Labels: documentation, refactoring > > According to the proposal thread in [1] we decided to deprecate mini lang. > This issue tracks the next steps proposed in the aformentioned thread, namely: > 1. create a Wiki page for the documentation and description of the migration > process and how mini lang will be replaced. > 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2] > 3. put deprecation tags in the corresponding code > 4. kindly ask contributors with open patches written in mini lang to replace > them by Groovy code [3] > 5. start an initiative to replace existing mini lang code with Groovy code > where applicable. This needs some more planning and discussion which parts > we'll like to replace with Groovy code and which parts will better be > replaced by some kind of DSL. A good starting point can be [4][5][6]. > [1] > [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E] > [2] > [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference] > [3] does anyone know a way to batch comment Jira issues like it is possible > in Redmine? > [4] > [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic] > [5] > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide] > [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12665) Calendar in Work Effort does not work
[ https://issues.apache.org/jira/browse/OFBIZ-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17567172#comment-17567172 ] Nicolas Malin commented on OFBIZ-12665: --- Hello Jacques, is it this patch [^OFBIZ-12665.patch] fix your issue ? > Calendar in Work Effort does not work > - > > Key: OFBIZ-12665 > URL: https://issues.apache.org/jira/browse/OFBIZ-12665 > Project: OFBiz > Issue Type: Bug > Components: workeffort/workeffort >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12665.patch > > > I stumbled upon it while checking OFBIZ-12557. 22.01 is OK so must be a > recent issue and it's OFBIZ-12557 unrelated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12665) Calendar in Work Effort does not work
[ https://issues.apache.org/jira/browse/OFBIZ-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12665: -- Attachment: OFBIZ-12665.patch > Calendar in Work Effort does not work > - > > Key: OFBIZ-12665 > URL: https://issues.apache.org/jira/browse/OFBIZ-12665 > Project: OFBiz > Issue Type: Bug > Components: workeffort/workeffort >Affects Versions: Upcoming Branch >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Attachments: OFBIZ-12665.patch > > > I stumbled upon it while checking OFBIZ-12557. 22.01 is OK so must be a > recent issue and it's OFBIZ-12557 unrelated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12668) Convert PromoServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12668. - Resolution: Done > Convert PromoServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-12668 > URL: https://issues.apache.org/jira/browse/OFBIZ-12668 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > Convert services createProductPromoCond and updateProductPromoCond from > minilang to groovyDSL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12668) Convert PromoServices.xml mini-lang to groovyDSL
Nicolas Malin created OFBIZ-12668: - Summary: Convert PromoServices.xml mini-lang to groovyDSL Key: OFBIZ-12668 URL: https://issues.apache.org/jira/browse/OFBIZ-12668 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Upcoming Branch Reporter: Nicolas Malin Assignee: Nicolas Malin Convert services createProductPromoCond and updateProductPromoCond from minilang to groovyDSL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12667) Convert SupplierProductServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12667: -- Fix Version/s: 22.01.01 > Convert SupplierProductServices.xml mini-lang to groovyDSL > -- > > Key: OFBIZ-12667 > URL: https://issues.apache.org/jira/browse/OFBIZ-12667 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: 22.01.01 > > > Convert the service getSupplierProductFeatures from mini-lang to groovyDSL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12667) Convert SupplierProductServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12667. - Resolution: Done > Convert SupplierProductServices.xml mini-lang to groovyDSL > -- > > Key: OFBIZ-12667 > URL: https://issues.apache.org/jira/browse/OFBIZ-12667 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > > Convert the service getSupplierProductFeatures from mini-lang to groovyDSL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12667) Convert SupplierProductServices.xml mini-lang to groovyDSL
Nicolas Malin created OFBIZ-12667: - Summary: Convert SupplierProductServices.xml mini-lang to groovyDSL Key: OFBIZ-12667 URL: https://issues.apache.org/jira/browse/OFBIZ-12667 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Upcoming Branch Reporter: Nicolas Malin Assignee: Nicolas Malin Convert the service getSupplierProductFeatures from mini-lang to groovyDSL -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12663) Allow DynamicView use in standard performFind services
[ https://issues.apache.org/jira/browse/OFBIZ-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12663: - Assignee: Nicolas Malin > Allow DynamicView use in standard performFind services > -- > > Key: OFBIZ-12663 > URL: https://issues.apache.org/jira/browse/OFBIZ-12663 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Leila Mekika >Assignee: Nicolas Malin >Priority: Major > Fix For: 22.01.01 > > Attachments: OFBIZ-12663.patch > > > This is a proposition to extend the use of standard find services > (prepareFind, executeFind and performFind) to dynamicView. > It can help to have performFind services (such has performFindParty) that use > the same standard service > To describe quickly, it adds dynamicViewEntity as an optional parameter of > prepareFind, executeFind and performFind services and adapt the query > accordingly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12663) Allow DynamicView use in standard performFind services
[ https://issues.apache.org/jira/browse/OFBIZ-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12663: -- Fix Version/s: 22.01.01 > Allow DynamicView use in standard performFind services > -- > > Key: OFBIZ-12663 > URL: https://issues.apache.org/jira/browse/OFBIZ-12663 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Leila Mekika >Priority: Major > Fix For: 22.01.01 > > Attachments: OFBIZ-12663.patch > > > This is a proposition to extend the use of standard find services > (prepareFind, executeFind and performFind) to dynamicView. > It can help to have performFind services (such has performFindParty) that use > the same standard service > To describe quickly, it adds dynamicViewEntity as an optional parameter of > prepareFind, executeFind and performFind services and adapt the query > accordingly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12663) Allow DynamicView use in standard performFind services
[ https://issues.apache.org/jira/browse/OFBIZ-12663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12663. - Resolution: Done Thanks for this proposal, it's on 22.01 and trunk > Allow DynamicView use in standard performFind services > -- > > Key: OFBIZ-12663 > URL: https://issues.apache.org/jira/browse/OFBIZ-12663 > Project: OFBiz > Issue Type: Improvement > Components: framework/common >Affects Versions: Upcoming Branch >Reporter: Leila Mekika >Priority: Major > Fix For: 22.01.01 > > Attachments: OFBIZ-12663.patch > > > This is a proposition to extend the use of standard find services > (prepareFind, executeFind and performFind) to dynamicView. > It can help to have performFind services (such has performFindParty) that use > the same standard service > To describe quickly, it adds dynamicViewEntity as an optional parameter of > prepareFind, executeFind and performFind services and adapt the query > accordingly -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-11596) Convert BlogServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-11596. - Resolution: Duplicate > Convert BlogServices.xml mini lang to groovy > > > Key: OFBIZ-11596 > URL: https://issues.apache.org/jira/browse/OFBIZ-11596 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Paetzold >Assignee: Wiebke Paetzold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12654) Add sequenceNum on contentAssoc list
[ https://issues.apache.org/jira/browse/OFBIZ-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12654. - Fix Version/s: (was: Upcoming Branch) Resolution: Done It's loaded on trunk, thanks > Add sequenceNum on contentAssoc list > > > Key: OFBIZ-12654 > URL: https://issues.apache.org/jira/browse/OFBIZ-12654 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Nicolas Malin >Priority: Trivial > Attachments: ContentAssocSeq.patch > > > It would be sometimes quite helpful if the sequence number is displayed on > the ContentAssoc List widget. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12586) Add missing parameter on xsd for widget-form:on-field-event-update-area
[
https://issues.apache.org/jira/browse/OFBIZ-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12586:
--
Affects Version/s: (was: 18.12.06)
> Add missing parameter on xsd for widget-form:on-field-event-update-area
> ---
>
> Key: OFBIZ-12586
> URL: https://issues.apache.org/jira/browse/OFBIZ-12586
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12586.patch
>
>
> On the widget-form.xsd definition, the element on-field-event-update-area
> haven't possibility to define some parameters.
> But on java code, the on-field-event-update-area is read like
> on-event-update-area.
> If you put some parameters on your code, your editor raise a syntax error but
> OFBiz analyse and execute it well.
> {code:java}
>
>
> area-target="ReloadIt">
> service-name="computeForReload" send-if-empty="false"/>
>
>
> {code}
> By the way we can synchronize the on-field-event-update-area xsd on
> on-event-update-area.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12586) Add missing parameter on xsd for widget-form:on-field-event-update-area
[
https://issues.apache.org/jira/browse/OFBIZ-12586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12586.
-
Fix Version/s: 22.01.01
Resolution: Done
> Add missing parameter on xsd for widget-form:on-field-event-update-area
> ---
>
> Key: OFBIZ-12586
> URL: https://issues.apache.org/jira/browse/OFBIZ-12586
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: 18.12.06, 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12586.patch
>
>
> On the widget-form.xsd definition, the element on-field-event-update-area
> haven't possibility to define some parameters.
> But on java code, the on-field-event-update-area is read like
> on-event-update-area.
> If you put some parameters on your code, your editor raise a syntax error but
> OFBiz analyse and execute it well.
> {code:java}
>
>
> area-target="ReloadIt">
> service-name="computeForReload" send-if-empty="false"/>
>
>
> {code}
> By the way we can synchronize the on-field-event-update-area xsd on
> on-event-update-area.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty
[
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12547.
-
Resolution: Done
> Convert a display-entity to hyperlink if subhyperlink this empty
>
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a
> sub-hyperlink related to the element displayed.
> {code}
>
> key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
> description="view">...
>
>
> {code}
> This display the party name with a link "view" connected.
> When you use the name a as link without a dedicate sub link, you need to
> change all the form to resolve the information to display for creating an
> hyperlink
> {code}
>
> value-field="partyName">
> from-field="partyIdFrom"/>
>
>
>
>
> description="${partyNameValue}">..
>
> {code}
> We lost the advantage of the display-entity. We can suggest to improve
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the
> display entity as a hyperlink
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty
[
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin reopened OFBIZ-12547:
---
> Convert a display-entity to hyperlink if subhyperlink this empty
>
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a
> sub-hyperlink related to the element displayed.
> {code}
>
> key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
> description="view">...
>
>
> {code}
> This display the party name with a link "view" connected.
> When you use the name a as link without a dedicate sub link, you need to
> change all the form to resolve the information to display for creating an
> hyperlink
> {code}
>
> value-field="partyName">
> from-field="partyIdFrom"/>
>
>
>
>
> description="${partyNameValue}">..
>
> {code}
> We lost the advantage of the display-entity. We can suggest to improve
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the
> display entity as a hyperlink
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12547) Convert a display-entity to hyperlink if subhyperlink this empty
[
https://issues.apache.org/jira/browse/OFBIZ-12547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12547.
-
Fix Version/s: 22.01.01
Resolution: Fixed
> Convert a display-entity to hyperlink if subhyperlink this empty
>
>
> Key: OFBIZ-12547
> URL: https://issues.apache.org/jira/browse/OFBIZ-12547
> Project: OFBiz
> Issue Type: Improvement
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12547.patch
>
>
> When you define a display-entity you have the possibility to add a
> sub-hyperlink related to the element displayed.
> {code}
>
> key-field-name="partyId" description="${groupName}${firstName} ${lastName}">
> description="view">...
>
>
> {code}
> This display the party name with a link "view" connected.
> When you use the name a as link without a dedicate sub link, you need to
> change all the form to resolve the information to display for creating an
> hyperlink
> {code}
>
> value-field="partyName">
> from-field="partyIdFrom"/>
>
>
>
>
> description="${partyNameValue}">..
>
> {code}
> We lost the advantage of the display-entity. We can suggest to improve
> display-entity with the rule :
> If the display-entity has a subhyperlink and the subhyperlink haven't
> description, the description of the link is the display-entity description.
> In the code, if a sub-hyperlink has an empty description, we convert the
> display entity as a hyperlink
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (OFBIZ-12624) Refactoring service resenquence
[ https://issues.apache.org/jira/browse/OFBIZ-12624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12624. - Fix Version/s: 22.01.01 Resolution: Done > Refactoring service resenquence > --- > > Key: OFBIZ-12624 > URL: https://issues.apache.org/jira/browse/OFBIZ-12624 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: Refactoring > Fix For: 22.01.01 > > Attachments: OFBIZ-12624.patch > > > Recently I discovered the service "resequence" that for a content compute all > sequenceNum on linked content assoc. > The code is very old (before apache) so I propose to refactore it and migrate > the service name *resequence* to *resequenceContentAssocChildren* (or if you > have a better suggest :) ) > By the way I kept the service definition resequence to move it as deprecated. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (OFBIZ-12628) MenuItem doesn't follow correctly extend information
[
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12628.
-
Resolution: Fixed
Ok thanks Jacques the pb appeared when your origin menu item haven't link.
It's now fixed
> MenuItem doesn't follow correctly extend information
>
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the
> first menu on their model.
>
> {code:java}
> extends-resource="component://common/widget/CommonMenus.xml">
>
>
>
>
> {code}
> The result, if during the rendering some information are generate from the
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and
> MenuLink in memory with the new parent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12654) Add sequenceNum on contentAssoc list
[ https://issues.apache.org/jira/browse/OFBIZ-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12654: - Assignee: Nicolas Malin > Add sequenceNum on contentAssoc list > > > Key: OFBIZ-12654 > URL: https://issues.apache.org/jira/browse/OFBIZ-12654 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Upcoming Branch >Reporter: Ingo Wolfmayr >Assignee: Nicolas Malin >Priority: Trivial > Fix For: Upcoming Branch > > Attachments: ContentAssocSeq.patch > > > It would be sometimes quite helpful if the sequence number is displayed on > the ContentAssoc List widget. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-12659) Lookups: No result option should not be selectable
[ https://issues.apache.org/jira/browse/OFBIZ-12659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12659: -- Affects Version/s: 22.01.01 Upcoming Branch > Lookups: No result option should not be selectable > -- > > Key: OFBIZ-12659 > URL: https://issues.apache.org/jira/browse/OFBIZ-12659 > Project: OFBiz > Issue Type: Bug > Components: themes >Affects Versions: 18.12.05, 22.01.01, Upcoming Branch >Reporter: Florian Motteau >Priority: Minor > Attachments: lookups-no-record-found.mp4 > > > On lookups, if the search request returns nothing, we have a dropdown with > only one option : "No records found". > This option is selectable, and when the user clicks it the input is filled > with the string "No records found". When the form is submitted, this value is > submitted as well. > The "No records found" option should not be selectable, it should not be > possible to submit the field with this value. When clicking on this option, > we could either : > * leave the input with its previous value (do nothing) > * empty the input -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-12628) MenuItem doesn't follow correctly extend information
[
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17556730#comment-17556730
]
Nicolas Malin commented on OFBIZ-12628:
---
ok thanks Jacques, I will check the problem soon
> MenuItem doesn't follow correctly extend information
>
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the
> first menu on their model.
>
> {code:java}
> extends-resource="component://common/widget/CommonMenus.xml">
>
>
>
>
> {code}
> The result, if during the rendering some information are generate from the
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and
> MenuLink in memory with the new parent.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (OFBIZ-12652) Define return user message from controller or context
[
https://issues.apache.org/jira/browse/OFBIZ-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12652:
--
Description:
Currently when you wish return a message to a user after an event request, you
need to set it ine the called event.
for a service in java :
{code:java}
ServiceUtil.returnSuccess("Your service is a success"){code}
for a service in groovy :
{code:java}
return success("Your service is a success"){code}
for a Java class :
{code:java}
request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");{code}
If during an integration, you want to use standard service like createProduct,
createPartyRelationship, and need a specific message for users, you need to
define you own service.
For escape this case and increase the service reusability, I propose to
implement a new systeme to override the event return by a definition depending
the buisness context.
For that two improvement :
1. Add new child element to reques-map->response on the controller
* With given the exact value
{code:java}
{code}
* With a flexible expander
{code:java}
{code}
* With a property
{code:java}
{code}
* From a context field
{code:java}
{code}
2. From the context directly sent from the form
{code:java}
{code}
related thread on dev :
[https://lists.apache.org/thread/bv46xndbny6phfxycbmbmxs4t2n7jr28]
was:
Currently when you wish return a message to a user after an event request, you
need to set it ine the called event.
for a service in java :
{code:java}
ServiceUtil.returnSuccess("Your service is a success"){code}
for a service in groovy :
{code:java}
return success("Your service is a success"){code}
for a Java class :
{code:java}
request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");{code}
If during an integration, you want to use standard service like createProduct,
createPartyRelationship, and need a specific message for users, you need to
define you own service.
For escape this case and increase the service reusability, I propose to
implement a new systeme to override the event return by a definition depending
the buisness context.
For that two improvement :
# Add new child element to reques-map->response on the controller
## With given the exact value
{code:java}
{code}
## With a flexible expander
{code:java}
{code}
## With a property
{code:java}
{code}
## From a context field
{code:java}
{code}
# From the context directly sent from the form
{code:java}
{code}
related thread on dev :
https://lists.apache.org/thread/bv46xndbny6phfxycbmbmxs4t2n7jr28
> Define return user message from controller or context
> -
>
> Key: OFBIZ-12652
> URL: https://issues.apache.org/jira/browse/OFBIZ-12652
> Project: OFBiz
> Issue Type: New Feature
> Components: framework/webapp
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Labels: event, message, user-experience
> Attachments: OFBIZ-12652.patch
>
>
> Currently when you wish return a message to a user after an event request,
> you need to set it ine the called event.
> for a service in java :
> {code:java}
> ServiceUtil.returnSuccess("Your service is a success"){code}
>
> for a service in groovy :
> {code:java}
> return success("Your service is a success"){code}
>
> for a Java class :
> {code:java}
> request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");{code}
>
> If during an integration, you want to use standard service like
> createProduct, createPartyRelationship, and need a specific message for
> users, you need to define you own service.
> For escape this case and increase the service reusability, I propose to
> implement a new systeme to override the event return by a definition
> depending the buisness context.
> For that two improvement :
> 1. Add new child element to reques-map->response on the controller
> * With given the exact value
> {code:java}
>
>
> {code}
>
> * With a flexible expander
> {code:java}
>
>
>
> {code}
>
> * With a property
> {code:java}
>
> value="CommonSuccessfullyCreated"/>
>
> {code}
> * From a context field
> {code:java}
>
>
>
> {code}
> 2. From the context directly sent from the form
> {code:java}
>
>
> {code}
>
> related thread on dev :
> [https://lists.apache.org/thread/bv46xndbny6phfxycbmbmxs4t2n7jr28]
--
This message was sent by
[jira] [Updated] (OFBIZ-12652) Define return user message from controller or context
[
https://issues.apache.org/jira/browse/OFBIZ-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12652:
--
Attachment: OFBIZ-12652.patch
> Define return user message from controller or context
> -
>
> Key: OFBIZ-12652
> URL: https://issues.apache.org/jira/browse/OFBIZ-12652
> Project: OFBiz
> Issue Type: New Feature
> Components: framework/webapp
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Labels: event, message, user-experience
> Attachments: OFBIZ-12652.patch
>
>
> Currently when you wish return a message to a user after an event request,
> you need to set it ine the called event.
> for a service in java :
>
> {code:java}
> ServiceUtil.returnSuccess("Your service is a success"){code}
>
>
> for a service in groovy :
>
> {code:java}
> return success("Your service is a success"){code}
>
>
> for a Java class :
>
> {code:java}
> request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");{code}
>
>
> If during an integration, you want to use standard service like
> createProduct, createPartyRelationship, and need a specific message for
> users, you need to define you own service.
> For escape this case and increase the service reusability, I propose to
> implement a new systeme to override the event return by a definition
> depending the buisness context.
> For that two improvement :
> # Add new child element to reques-map->response on the controller
> ## With given the exact value
> {code:java}
>
>
> {code}
> ## With a flexible expander
> {code:java}
>
>
>
> {code}
> ## With a property
> {code:java}
>
> value="CommonSuccessfullyCreated"/>
>
> {code}
> ## From a context field
> {code:java}
>
>
>
> {code}
> # From the context directly sent from the form
> {code:java}
>
>
> {code}
>
> related thread on dev :
> https://lists.apache.org/thread/bv46xndbny6phfxycbmbmxs4t2n7jr28
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (OFBIZ-12652) Define return user message from controller or context
Nicolas Malin created OFBIZ-12652:
-
Summary: Define return user message from controller or context
Key: OFBIZ-12652
URL: https://issues.apache.org/jira/browse/OFBIZ-12652
Project: OFBiz
Issue Type: New Feature
Components: framework/webapp
Affects Versions: 22.01.01, Upcoming Branch
Reporter: Nicolas Malin
Assignee: Nicolas Malin
Currently when you wish return a message to a user after an event request, you
need to set it ine the called event.
for a service in java :
{code:java}
ServiceUtil.returnSuccess("Your service is a success"){code}
for a service in groovy :
{code:java}
return success("Your service is a success"){code}
for a Java class :
{code:java}
request.setAttribute("_EVENT_MESSAGE_", "Your service is a success");{code}
If during an integration, you want to use standard service like createProduct,
createPartyRelationship, and need a specific message for users, you need to
define you own service.
For escape this case and increase the service reusability, I propose to
implement a new systeme to override the event return by a definition depending
the buisness context.
For that two improvement :
# Add new child element to reques-map->response on the controller
## With given the exact value
{code:java}
{code}
## With a flexible expander
{code:java}
{code}
## With a property
{code:java}
{code}
## From a context field
{code:java}
{code}
# From the context directly sent from the form
{code:java}
{code}
related thread on dev :
https://lists.apache.org/thread/bv46xndbny6phfxycbmbmxs4t2n7jr28
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (OFBIZ-12651) service getNextOrderId failed if a customMethod is present
[ https://issues.apache.org/jira/browse/OFBIZ-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-12651: -- Affects Version/s: Upcoming Branch > service getNextOrderId failed if a customMethod is present > -- > > Key: OFBIZ-12651 > URL: https://issues.apache.org/jira/browse/OFBIZ-12651 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Nicolas Malin >Priority: Minor > Fix For: 22.01.01 > > > When you generate an order on a party who have a PartyAcctgPreference with a > customMethod orderSequence_enforced, the service failed due to the missing > parameter partyAcctgPreference. > Like quote and invoice it's preferable to forward the partyAcctgPreference > information. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (OFBIZ-12651) service getNextOrderId failed if a customMethod is present
[ https://issues.apache.org/jira/browse/OFBIZ-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin closed OFBIZ-12651. - Fix Version/s: 22.01.01 Resolution: Fixed > service getNextOrderId failed if a customMethod is present > -- > > Key: OFBIZ-12651 > URL: https://issues.apache.org/jira/browse/OFBIZ-12651 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: 22.01.01 >Reporter: Nicolas Malin >Priority: Minor > Fix For: 22.01.01 > > > When you generate an order on a party who have a PartyAcctgPreference with a > customMethod orderSequence_enforced, the service failed due to the missing > parameter partyAcctgPreference. > Like quote and invoice it's preferable to forward the partyAcctgPreference > information. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Assigned] (OFBIZ-12651) service getNextOrderId failed if a customMethod is present
[ https://issues.apache.org/jira/browse/OFBIZ-12651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin reassigned OFBIZ-12651: - Assignee: Nicolas Malin > service getNextOrderId failed if a customMethod is present > -- > > Key: OFBIZ-12651 > URL: https://issues.apache.org/jira/browse/OFBIZ-12651 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: 22.01.01, Upcoming Branch >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Fix For: 22.01.01 > > > When you generate an order on a party who have a PartyAcctgPreference with a > customMethod orderSequence_enforced, the service failed due to the missing > parameter partyAcctgPreference. > Like quote and invoice it's preferable to forward the partyAcctgPreference > information. > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Created] (OFBIZ-12651) service getNextOrderId failed if a customMethod is present
Nicolas Malin created OFBIZ-12651: - Summary: service getNextOrderId failed if a customMethod is present Key: OFBIZ-12651 URL: https://issues.apache.org/jira/browse/OFBIZ-12651 Project: OFBiz Issue Type: Bug Components: order Affects Versions: 22.01.01 Reporter: Nicolas Malin When you generate an order on a party who have a PartyAcctgPreference with a customMethod orderSequence_enforced, the service failed due to the missing parameter partyAcctgPreference. Like quote and invoice it's preferable to forward the partyAcctgPreference information. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (OFBIZ-12628) MenuItem doesn't follow correctly extend information
[
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12628.
-
Fix Version/s: 22.01.01
Resolution: Fixed
Thanks to Marco Rodrigues for the alert
> MenuItem doesn't follow correctly extend information
>
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the
> first menu on their model.
>
> {code:java}
> extends-resource="component://common/widget/CommonMenus.xml">
>
>
>
>
> {code}
> The result, if during the rendering some information are generate from the
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and
> MenuLink in memory with the new parent.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (OFBIZ-12628) MenuItem doesn't follow correctly extend information
[
https://issues.apache.org/jira/browse/OFBIZ-12628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17555477#comment-17555477
]
Nicolas Malin commented on OFBIZ-12628:
---
Hello Jacques,
We detected this issue during write an exercice on dynamic screen:
Screens.xml
{code:java}
{code}
Forms.xml
{code:java}
{code}
Menus.xml
{code:java}
{code}
The menu ActionMenuList2 doesn't work because is the hidden form generate is
connected to the ActionMenuList.
> MenuItem doesn't follow correctly extend information
>
>
> Key: OFBIZ-12628
> URL: https://issues.apache.org/jira/browse/OFBIZ-12628
> Project: OFBiz
> Issue Type: Bug
> Components: framework/widget
>Affects Versions: 22.01.01, Upcoming Branch
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-12628.patch
>
>
> When you use two menus where the second extend the first, menu item and menu
> link aren't propage correctly.
> The menu items and menu link presents on the second menu already have the
> first menu on their model.
>
> {code:java}
> extends-resource="component://common/widget/CommonMenus.xml">
>
>
>
>
> {code}
> The result, if during the rendering some information are generate from the
> menu, in the previous case, it's always the "FirstMenu" that would be use.
> To solve it and don't break the thread safe pattern, I introduce two new
> constructor for ModelItem and MenuLink for duplicate the ModelMenuItem and
> MenuLink in memory with the new parent.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (OFBIZ-12649) Function ProductWorker.shippingApplies failed if chargeShipping is empty
[
https://issues.apache.org/jira/browse/OFBIZ-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin closed OFBIZ-12649.
-
Fix Version/s: 22.01.01
Resolution: Fixed
> Function ProductWorker.shippingApplies failed if chargeShipping is empty
>
>
> Key: OFBIZ-12649
> URL: https://issues.apache.org/jira/browse/OFBIZ-12649
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: 22.01.01
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
> Fix For: 22.01.01
>
>
> When you compute the estimated shipping cost, you compute the quantity of
> product to ship.
> This use the ProductWorker.shippingApplies for each product to know if it
> need to be ship or not.
> On this function the code
>
> {code:java}
> Boolean chargeShipping = product.getBoolean("chargeShipping");
> if (chargeShipping == null) {
> return true;
> }
> return chargeShipping;
> {code}
> is wrong if the field chargeShipping is empty on a product.
> The reason is simple, GenericValue.getBoolean return false if the field is
> empty
> GenericEntity.java:738
>
> {code:java}
> public Boolean getBoolean(String name) {
> Object obj = get(name);
> if (obj == null) {
> return false;
> }
> {code}
> So in this case the function ProductWorker.shippingApplies return always
> false instead true.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (OFBIZ-12649) Function ProductWorker.shippingApplies failed if chargeShipping is empty
[
https://issues.apache.org/jira/browse/OFBIZ-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12649:
--
Affects Version/s: (was: 18.12.06)
> Function ProductWorker.shippingApplies failed if chargeShipping is empty
>
>
> Key: OFBIZ-12649
> URL: https://issues.apache.org/jira/browse/OFBIZ-12649
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: 22.01.01
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
>
> When you compute the estimated shipping cost, you compute the quantity of
> product to ship.
> This use the ProductWorker.shippingApplies for each product to know if it
> need to be ship or not.
> On this function the code
>
> {code:java}
> Boolean chargeShipping = product.getBoolean("chargeShipping");
> if (chargeShipping == null) {
> return true;
> }
> return chargeShipping;
> {code}
> is wrong if the field chargeShipping is empty on a product.
> The reason is simple, GenericValue.getBoolean return false if the field is
> empty
> GenericEntity.java:738
>
> {code:java}
> public Boolean getBoolean(String name) {
> Object obj = get(name);
> if (obj == null) {
> return false;
> }
> {code}
> So in this case the function ProductWorker.shippingApplies return always
> false instead true.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (OFBIZ-12649) Function ProductWorker.shippingApplies failed if chargeShipping is empty
[
https://issues.apache.org/jira/browse/OFBIZ-12649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nicolas Malin updated OFBIZ-12649:
--
Affects Version/s: (was: Upcoming Branch)
> Function ProductWorker.shippingApplies failed if chargeShipping is empty
>
>
> Key: OFBIZ-12649
> URL: https://issues.apache.org/jira/browse/OFBIZ-12649
> Project: OFBiz
> Issue Type: Bug
> Components: product
>Affects Versions: 18.12.06, 22.01.01
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Trivial
>
> When you compute the estimated shipping cost, you compute the quantity of
> product to ship.
> This use the ProductWorker.shippingApplies for each product to know if it
> need to be ship or not.
> On this function the code
>
> {code:java}
> Boolean chargeShipping = product.getBoolean("chargeShipping");
> if (chargeShipping == null) {
> return true;
> }
> return chargeShipping;
> {code}
> is wrong if the field chargeShipping is empty on a product.
> The reason is simple, GenericValue.getBoolean return false if the field is
> empty
> GenericEntity.java:738
>
> {code:java}
> public Boolean getBoolean(String name) {
> Object obj = get(name);
> if (obj == null) {
> return false;
> }
> {code}
> So in this case the function ProductWorker.shippingApplies return always
> false instead true.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
