[jira] [Closed] (OFBIZ-12191) Bug preventing proper explosion of BOM containing virtual nodes
[
https://issues.apache.org/jira/browse/OFBIZ-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma closed OFBIZ-12191.
---
Fix Version/s: 17.12.06
18.12.01
Resolution: Fixed
> Bug preventing proper explosion of BOM containing virtual nodes
> ---
>
> Key: OFBIZ-12191
> URL: https://issues.apache.org/jira/browse/OFBIZ-12191
> Project: OFBiz
> Issue Type: Bug
> Components: manufacturing
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Pawan Verma
>Priority: Major
> Fix For: 18.12.01, 17.12.06
>
> Attachments: OFBIZ-12191.patch, OFBIZ-12191_sample-data.xml,
> image-2021-02-27-18-37-47-422.png
>
>
> I tried the following use case. We configured BOM for the virtual product
> whose nodes can also be virtual.
>
> {code:java}
> // Product To Be produced
> PROD_MANUF_1 (Virtual Product)
> - PROD_MANUF_11 (Variant)
> - PROD_MANUF_12 (Variant)
>
> // Raw Material
> RAW_MAT_1 (Virtual)
> - RAW_MAT_11 (Variant)
> - RAW_MAT_12 (Variant)
>
> RAW_MAT_2 (Standard)
> // BOM
> PROD_MANUF_1-> RAW_MAT_1
> -> RAW_MAT_2
> PROD_MANUF_11 -> RAW_MAT_11 -> 2 Qty
> -> RAW_MAT_2 -> 2 Qty
>
>
> PROD_MANUF_12 -> RAW_MAT_12 -> 3 Qty
> -> RAW_MAT_2 -> 2 Qty {code}
> Now let say we want to manufacture 10qty of PROD_MANUF_12. To my
> expectations, the requirement generated should be like
> - To produce 10qty for PROD_MANUF_12 we will need
> - 30qty of RAW_MAT_12
> - 20qty of RAW_MAT_2
> But the result for MRP and BOM simulation is incorrect. Please refer to the
> screenshot.
> !image-2021-02-27-18-37-47-422.png!
> _I am also attaching sample data to test._
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-12153. --- Fix Version/s: 17.12.06 18.12.01 Assignee: Pawan Verma (was: sourabh jain) Resolution: Fixed > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: Pawan Verma >Priority: Major > Fix For: 18.12.01, 17.12.06 > > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, > OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12191) Bug preventing proper explosion of BOM containing virtual nodes
[
https://issues.apache.org/jira/browse/OFBIZ-12191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma reassigned OFBIZ-12191:
---
Assignee: Pawan Verma
> Bug preventing proper explosion of BOM containing virtual nodes
> ---
>
> Key: OFBIZ-12191
> URL: https://issues.apache.org/jira/browse/OFBIZ-12191
> Project: OFBiz
> Issue Type: Bug
> Components: manufacturing
>Affects Versions: Trunk
>Reporter: Nameet Jain
>Assignee: Pawan Verma
>Priority: Major
> Attachments: OFBIZ-12191.patch, OFBIZ-12191_sample-data.xml,
> image-2021-02-27-18-37-47-422.png
>
>
> I tried the following use case. We configured BOM for the virtual product
> whose nodes can also be virtual.
>
> {code:java}
> // Product To Be produced
> PROD_MANUF_1 (Virtual Product)
> - PROD_MANUF_11 (Variant)
> - PROD_MANUF_12 (Variant)
>
> // Raw Material
> RAW_MAT_1 (Virtual)
> - RAW_MAT_11 (Variant)
> - RAW_MAT_12 (Variant)
>
> RAW_MAT_2 (Standard)
> // BOM
> PROD_MANUF_1-> RAW_MAT_1
> -> RAW_MAT_2
> PROD_MANUF_11 -> RAW_MAT_11 -> 2 Qty
> -> RAW_MAT_2 -> 2 Qty
>
>
> PROD_MANUF_12 -> RAW_MAT_12 -> 3 Qty
> -> RAW_MAT_2 -> 2 Qty {code}
> Now let say we want to manufacture 10qty of PROD_MANUF_12. To my
> expectations, the requirement generated should be like
> - To produce 10qty for PROD_MANUF_12 we will need
> - 30qty of RAW_MAT_12
> - 20qty of RAW_MAT_2
> But the result for MRP and BOM simulation is incorrect. Please refer to the
> screenshot.
> !image-2021-02-27-18-37-47-422.png!
> _I am also attaching sample data to test._
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-12153: Attachment: OFBIZ-12153.patch > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, > OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17300421#comment-17300421 ] Pawan Verma commented on OFBIZ-12153: - Hi [~jleroux] Here is the patch for R17 and R18, Could you please have a look! [^OFBIZ-12153.patch] > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, > OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295227#comment-17295227 ] Pawan Verma commented on OFBIZ-12153: - Ahh yes, conflicts. Updated here: [^OFBIZ-12153.patch] > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-12153: Attachment: OFBIZ-12153.patch > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294983#comment-17294983 ] Pawan Verma commented on OFBIZ-12153: - Hi [~jleroux] I've updated the patch to fix the testCase issue. Here is the patch: [^OFBIZ-12153.patch] EntityAutoEngine's expire method can also expire a field with a name date, so it was not allowing. FinAccount.fromDate is not part of PK, so the engine is attempting to update it and leaving thruDate field. Modified code will update both fields. Let me know your thoughts! > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-12153: Attachment: OFBIZ-12153.patch > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch, OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-12153: Attachment: OFBIZ-12153.patch > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293023#comment-17293023 ] Pawan Verma commented on OFBIZ-12153: - [~jleroux] Could you please test it with this patch? [^OFBIZ-12153.patch] I've updated the test as well. Thanks! > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch, OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292967#comment-17292967 ] Pawan Verma commented on OFBIZ-12153: - [~jleroux] [~sourabh.jain] I'm not fully convinced about the solution here. Delete service should delete a record or expire it. I'm attaching a quickly looked workaround. [^OFBIZ-12153.patch] Expire was not working as the fromDate field was not part of PK for FinAccount Entity, and it was setting fromDate as nowTime() instead of thruDate. So modified the check to only check thruDate field on the "expire" action. Please let us know your views on this. > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12153) Error in deleting Financial Account
[ https://issues.apache.org/jira/browse/OFBIZ-12153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-12153: Attachment: OFBIZ-12153.patch > Error in deleting Financial Account > --- > > Key: OFBIZ-12153 > URL: https://issues.apache.org/jira/browse/OFBIZ-12153 > Project: OFBiz > Issue Type: Bug > Components: accounting >Reporter: Lalit Dashora >Assignee: sourabh jain >Priority: Major > Attachments: FinAccountDelete.png, OFBIZ-12153.patch, > OFBIZ-12153.patch > > > 1. Navigate to URL: accounting/control/FindFinAccount > 2. Click on Find button. List of fin account will be displayed. > 3. Click on delete button near available balance column. > The Following Errors Occurred: > Error doing entity-auto operation for entity FinAccount in service > deleteFinAccount: org.apache.ofbiz.entity.GenericEntityException: > org.apache.ofbiz.entity.GenericDataSourceException: Exception while deleting > the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.)) (Exception while > deleting the following entity: > [GenericEntity:FinAccount][finAccountId,SC_CHECKING(java.lang.String)] (SQL > Exception while executing the following:null (DELETE on table 'FIN_ACCOUNT' > caused a violation of foreign key constraint 'FINACT_STTS_FNA' for key > (SC_CHECKING). The statement has been rolled back.))) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10863) Field 'govAgencyPartyId' shows all parties, not just Government Agencies
[ https://issues.apache.org/jira/browse/OFBIZ-10863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17292037#comment-17292037 ] Pawan Verma commented on OFBIZ-10863: - [~jleroux] Should we close this? > Field 'govAgencyPartyId' shows all parties, not just Government Agencies > > > Key: OFBIZ-10863 > URL: https://issues.apache.org/jira/browse/OFBIZ-10863 > Project: OFBiz > Issue Type: Improvement > Components: assetmaint >Affects Versions: Release Branch 16.11, 16.11.04, 16.11.05, 16.11.06, > 17.12.01, Trunk >Reporter: Pierre Smits >Assignee: Priya Sharma >Priority: Major > Labels: asset, registration > Attachments: OFBIZ-10863.patch, OFBIZ-10863.patch > > > The field govAgencyPartyId in the AddFixedAssetRegistration form shows all > parties through the > lookup target-form-name="LookupPartyName function. > This should be limited to those parties that qualify with the constraint. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12184) Textarea fields do not expand when typing into them
[
https://issues.apache.org/jira/browse/OFBIZ-12184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17287754#comment-17287754
]
Pawan Verma commented on OFBIZ-12184:
-
Hi [~ddev]
What about this solution?
{code:java}
var textarea = document.getElementById("textarea");
if (textarea) {
textarea.oninput = function() {
textarea.style.height = "";
textarea.style.height = Math.min(textarea.scrollHeight, 200) + "px";
};
}
{code}
> Textarea fields do not expand when typing into them
> ---
>
> Key: OFBIZ-12184
> URL: https://issues.apache.org/jira/browse/OFBIZ-12184
> Project: OFBiz
> Issue Type: Improvement
>Reporter: ddev
>Priority: Minor
> Attachments: autoexpand-textarea.js
>
>
> When typing into a textarea field with a large number of lines, you often can
> only see 2 lines of text at a time. It would make sense to add it to the HTML
> specification, but for whatever reason that did not happen, so it must be
> done in javascript.
>
> I am attaching a javascript file that includes one way of fixing it. One way
> of loading this would be to include it via themes/common/widget/Themes.xml
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script
[ https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-12173. --- Fix Version/s: Release Branch 17.12 Release Branch 18.12 Resolution: Fixed Thanks, [~Giulio_MpStyle] for the report and patch. And [~jacopoc] and [~deepak] for review. I've used UtilHttp.getSessionId() as suggested by [~deepak]. > Visit disabling causes NullPointerException on ecomm groovy script > -- > > Key: OFBIZ-12173 > URL: https://issues.apache.org/jira/browse/OFBIZ-12173 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 > Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Pawan Verma >Priority: Blocker > Labels: visit > Fix For: Release Branch 18.12, Release Branch 17.12 > > Attachments: > OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, > newcustomer_error.jpg > > > Disable tracking of Visits and Visitors, setting false the value of > stats.persist.visit stats.persist.visitor in serverstats.properties file, > causes a NullPointerException in the groovy script > ecommerce/groovyScript/customer/NewCustomer.groovy. > Attached here below a screenshot of the error. > !newcustomer_error.jpg! > This error also afflicts older version of OFBiz (the screenshot is taken from > an ecommerce site running on OFBiz 13.07.03) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-12173) Visit disabling causes NullPointerException on ecomm groovy script
[ https://issues.apache.org/jira/browse/OFBIZ-12173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-12173: --- Assignee: Pawan Verma (was: Giulio Speri) > Visit disabling causes NullPointerException on ecomm groovy script > -- > > Key: OFBIZ-12173 > URL: https://issues.apache.org/jira/browse/OFBIZ-12173 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Trunk, 17.12.05 > Environment: Linux Ubuntu 18.04 LTS, Apache OFBiz v13.07.03 >Reporter: Giulio Speri >Assignee: Pawan Verma >Priority: Blocker > Labels: visit > Attachments: > OFBIZ-12173_Visit_disabling_causes_NullPointerException.patch, > newcustomer_error.jpg > > > Disable tracking of Visits and Visitors, setting false the value of > stats.persist.visit stats.persist.visitor in serverstats.properties file, > causes a NullPointerException in the groovy script > ecommerce/groovyScript/customer/NewCustomer.groovy. > Attached here below a screenshot of the error. > !newcustomer_error.jpg! > This error also afflicts older version of OFBiz (the screenshot is taken from > an ecommerce site running on OFBiz 13.07.03) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11995) Define schema for RESTFul resources mapping.
[ https://issues.apache.org/jira/browse/OFBIZ-11995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190742#comment-17190742 ] Pawan Verma commented on OFBIZ-11995: - +1, looks good to me. Agree, we should use services instead of fetching data from entities. > Define schema for RESTFul resources mapping. > > > Key: OFBIZ-11995 > URL: https://issues.apache.org/jira/browse/OFBIZ-11995 > Project: OFBiz > Issue Type: Sub-task > Components: ALL PLUGINS >Affects Versions: Trunk >Reporter: Girish Vasmatkar >Assignee: Girish Vasmatkar >Priority: Major > Attachments: rest-api.xsd > > > As a developer, I need to have the ability to define REST resources using XML > DSL allowing to plug in OFBiz services to the resources that can serve the > HTTP requests. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182432#comment-17182432 ] Pawan Verma commented on OFBIZ-11919: - Hi [~rohit.koushal] Your patch looks good to me. +1 for commit :) > Convert SystemInfoServices.xml mini lang to groovy > -- > > Key: OFBIZ-11919 > URL: https://issues.apache.org/jira/browse/OFBIZ-11919 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Reporter: Rohit Koushal >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-11919.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182382#comment-17182382 ] Pawan Verma commented on OFBIZ-11944: - Thanks, [~priya.sharma.9362] and [~jleroux]! > Replace .size() == 0 with isEmpty() in Java files > - > > Key: OFBIZ-11944 > URL: https://issues.apache.org/jira/browse/OFBIZ-11944 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch > > > For a better understanding of how it may be helpful, this article puts some > light > https://rb.gy/mhpuzg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11944. --- Fix Version/s: Upcoming Branch Resolution: Implemented > Replace .size() == 0 with isEmpty() in Java files > - > > Key: OFBIZ-11944 > URL: https://issues.apache.org/jira/browse/OFBIZ-11944 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch > > > For a better understanding of how it may be helpful, this article puts some > light > https://rb.gy/mhpuzg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11944: --- Assignee: Pawan Verma (was: Priya Sharma) > Replace .size() == 0 with isEmpty() in Java files > - > > Key: OFBIZ-11944 > URL: https://issues.apache.org/jira/browse/OFBIZ-11944 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch > > > For a better understanding of how it may be helpful, this article puts some > light > https://rb.gy/mhpuzg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11944) Replace .size() == 0 with isEmpty() in Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11944: Sprint: OFBiz Community Day (Aug 2020) > Replace .size() == 0 with isEmpty() in Java files > - > > Key: OFBIZ-11944 > URL: https://issues.apache.org/jira/browse/OFBIZ-11944 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Priya Sharma >Priority: Minor > Attachments: OFBIZ-11944-plugin.patch, OFBIZ-11944.patch > > > For a better understanding of how it may be helpful, this article puts some > light > https://rb.gy/mhpuzg -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11380. --- Fix Version/s: Upcoming Branch Resolution: Implemented > Convert createCommEventContentAssoc service from mini-lang to groovy DSL > > > Key: OFBIZ-11380 > URL: https://issues.apache.org/jira/browse/OFBIZ-11380 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11380.patch, OFBIZ-11380.patch > > > Convert createCommEventContentAssoc service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-9350) Deprecate Mini Lang
[ https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-9350: --- Sprint: OFBiz Community Day (Feb 2020), OFBiz Community Day (May 2020), OFBiz Community Day (Aug 2020) (was: OFBiz Community Day (Feb 2020), OFBiz Community Day (May 2020)) > Deprecate Mini Lang > --- > > Key: OFBIZ-9350 > URL: https://issues.apache.org/jira/browse/OFBIZ-9350 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk >Reporter: Michael Brohl >Assignee: Michael Brohl >Priority: Minor > Labels: documentation, refactoring > > According to the proposal thread in [1] we decided to deprecate mini lang. > This issue tracks the next steps proposed in the aformentioned thread, namely: > 1. create a Wiki page for the documentation and description of the migration > process and how mini lang will be replaced. > 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2] > 3. put deprecation tags in the corresponding code > 4. kindly ask contributors with open patches written in mini lang to replace > them by Groovy code [3] > 5. start an initiative to replace existing mini lang code with Groovy code > where applicable. This needs some more planning and discussion which parts > we'll like to replace with Groovy code and which parts will better be > replaced by some kind of DSL. A good starting point can be [4][5][6]. > [1] > [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E] > [2] > [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference] > [3] does anyone know a way to batch comment Jira issues like it is possible > in Redmine? > [4] > [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic] > [5] > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide] > [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11380: --- Assignee: Pawan Verma (was: Rushikesh Mawal) > Convert createCommEventContentAssoc service from mini-lang to groovy DSL > > > Key: OFBIZ-11380 > URL: https://issues.apache.org/jira/browse/OFBIZ-11380 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11380.patch, OFBIZ-11380.patch > > > Convert createCommEventContentAssoc service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11837: Sprint: OFBiz Community Day (Aug 2020) > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11185) OrderReadHelper.getAvailableOrderHeaderAdjustments improvements
[ https://issues.apache.org/jira/browse/OFBIZ-11185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11185: Sprint: OFBiz Community Day (Aug 2020) > OrderReadHelper.getAvailableOrderHeaderAdjustments improvements > --- > > Key: OFBIZ-11185 > URL: https://issues.apache.org/jira/browse/OFBIZ-11185 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-11185.patch > > > We have a helper method in OrderReadHelper named as > getAvailableOrderHeaderAdjustments which is used to fetch order header > adjustments available for return. > It should also check for amount, it might possible, orderHeader adjustment > was of $100 and once a return is created for $20, then available $80 would > not render while creating second return for the same order. > So instead of checking only for orderAdjustmentId in ReturnAdjustment, it > should also check for adjustment amount. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration
[ https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182369#comment-17182369 ] Pawan Verma commented on OFBIZ-11837: - Hi [~pritam.kute] I've merged the PR. Shouldn't we close this? > First Data Payment Gateway Integration > -- > > Key: OFBIZ-11837 > URL: https://issues.apache.org/jira/browse/OFBIZ-11837 > Project: OFBiz > Issue Type: New Feature >Affects Versions: Trunk >Reporter: Pritam Kute >Assignee: Pritam Kute >Priority: Major > > Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih] > Apache OFBiz has OOTB integrations for most of the widely used payment > gateways around the world. > We are working on integrating First Data Payment Gateway for one of the > websites. The First Data payment gateway is quite popular and comes in the > list of top payment gateways around the globe. We would like to contribute > the basic payment gateway integration of First Data into Apache OFBiz. > Also as discussed over the DEV list, we will be contributing gateway as a > separate plugin. > We will create the subtasks under this main task to deliver different payment > gateway methods. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11728) Create new component, data configuration and connection request
[ https://issues.apache.org/jira/browse/OFBIZ-11728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182309#comment-17182309 ] Pawan Verma commented on OFBIZ-11728: - Hi [~shikha.jaiswal] Quite a big patch, would you mind creating a PR for faster review? TIA > Create new component, data configuration and connection request > --- > > Key: OFBIZ-11728 > URL: https://issues.apache.org/jira/browse/OFBIZ-11728 > Project: OFBiz > Issue Type: Sub-task >Affects Versions: Trunk >Reporter: Shikha Jaiswal >Assignee: Shikha Jaiswal >Priority: Major > Attachments: OFBIZ-11728.patch > > > We will be doing following tasks in this ticket: > # Create a new component named *shopify* > # Basic configuration data setup > # Implement a method for HTTP connection request with Shopify > To store configuration details we will create entity *ShopifyConfig* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10669) Getting Insecure connection error while navigating from product link
[ https://issues.apache.org/jira/browse/OFBIZ-10669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-10669. --- Fix Version/s: 17.12.05 18.12.01 Resolution: Fixed This has been fixed under OFBIZ-11735. > Getting Insecure connection error while navigating from product link > > > Key: OFBIZ-10669 > URL: https://issues.apache.org/jira/browse/OFBIZ-10669 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/processorder?checkoutpage=payment >Reporter: Archana Asthana >Assignee: Pawan Verma >Priority: Major > Fix For: 18.12.01, 17.12.05 > > Attachments: Error.png, OFBIZ-10669.patch, OrderViewPage.png > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/ecommerce/control/processorder?checkoutpage=payment > 2. Created Order with few products > 3. Login by creating a new user > 4. Submitted the order > 5 Click the product link > *Actual: * > Error is thrown as demo-trunk.ofbiz.apache.org sent an invalid response. > This site can’t provide a secure connection. > The Url is changing to 8080 in the url > When this value is removed and enter resubmit the url > View Product page gets open > The Image is attached for reference for both the screens. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10669) Getting Insecure connection error while navigating from product link
[ https://issues.apache.org/jira/browse/OFBIZ-10669?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-10669: --- Assignee: Pawan Verma (was: Pradeep Choudhary) > Getting Insecure connection error while navigating from product link > > > Key: OFBIZ-10669 > URL: https://issues.apache.org/jira/browse/OFBIZ-10669 > Project: OFBiz > Issue Type: Bug > Environment: > https://demo-trunk.ofbiz.apache.org/ecommerce/control/processorder?checkoutpage=payment >Reporter: Archana Asthana >Assignee: Pawan Verma >Priority: Major > Attachments: Error.png, OFBIZ-10669.patch, OrderViewPage.png > > > Steps to Regenerate > 1. Open > https://demo-trunk.ofbiz.apache.org/ecommerce/control/processorder?checkoutpage=payment > 2. Created Order with few products > 3. Login by creating a new user > 4. Submitted the order > 5 Click the product link > *Actual: * > Error is thrown as demo-trunk.ofbiz.apache.org sent an invalid response. > This site can’t provide a secure connection. > The Url is changing to 8080 in the url > When this value is removed and enter resubmit the url > View Product page gets open > The Image is attached for reference for both the screens. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11367) Convert updateSingleContentPurpose service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11367. --- Fix Version/s: Upcoming Branch Resolution: Implemented > Convert updateSingleContentPurpose service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11367 > URL: https://issues.apache.org/jira/browse/OFBIZ-11367 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11367.patch, OFBIZ-11367_Updated.patch > > > Convert updateSingleContentPurpose service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11367) Convert updateSingleContentPurpose service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11367: --- Assignee: Pawan Verma (was: Sourabh Punyani) > Convert updateSingleContentPurpose service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11367 > URL: https://issues.apache.org/jira/browse/OFBIZ-11367 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11367.patch, OFBIZ-11367_Updated.patch > > > Convert updateSingleContentPurpose service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17180506#comment-17180506 ] Pawan Verma commented on OFBIZ-11877: - Hello [~Dennis Balkir] Thanks, for the report. I've corrected it at R#71cfe0f. Please have a look! > Convert testCreateAndUpdateContactList test from XML to Groovy > -- > > Key: OFBIZ-11877 > URL: https://issues.apache.org/jira/browse/OFBIZ-11877 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11877.patch > > > Convert testCreateAndUpdateContactList test from XML to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11930) Remove unused imports from Java files
[ https://issues.apache.org/jira/browse/OFBIZ-11930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168863#comment-17168863 ] Pawan Verma commented on OFBIZ-11930: - +1 > Remove unused imports from Java files > - > > Key: OFBIZ-11930 > URL: https://issues.apache.org/jira/browse/OFBIZ-11930 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Reporter: Priya Sharma >Assignee: Priya Sharma >Priority: Minor > > Unused package imports can be removed for code optimization. > Similar effort was done previously for groovy files > https://issues.apache.org/jira/browse/OFBIZ-7334 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration
[
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17168724#comment-17168724
]
Pawan Verma commented on OFBIZ-10973:
-
Hi [~pritam.kute]
I second [~mbrohl] here with name msggateway-msg91, WDYT?
> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send
> sms".
> But could we not have another name, more explicit, for this component, like
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not
> associate the name of an open source component to a commercial services
> provider (with a free SMS quota option). Even if hopefully it will stay as
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-7935) Move 3rd party shipping integrations from product application to plugins
[ https://issues.apache.org/jira/browse/OFBIZ-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-7935: --- Description: This is a placeholder issue to capture all sub tasks for removing 3rd party shipping integrations from product application and moving to a new component in plugins. (was: This is a placeholder issue to capture all sub tasks for removing 3rd party shipping integrations from product application and moving to a new component in special purpose.) > Move 3rd party shipping integrations from product application to plugins > > > Key: OFBIZ-7935 > URL: https://issues.apache.org/jira/browse/OFBIZ-7935 > Project: OFBiz > Issue Type: Improvement > Components: product >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak >Priority: Major > > This is a placeholder issue to capture all sub tasks for removing 3rd party > shipping integrations from product application and moving to a new component > in plugins. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-7415) Move 3rd party payment integrations from accounting application to plugins
[ https://issues.apache.org/jira/browse/OFBIZ-7415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-7415: --- Description: This is a placeholder issue to capture all sub tasks for removing 3rd party payment integrations from accounting application and moving to a new component in plugins. (was: This is a placeholder issue to capture all sub tasks for removing 3rd party payment integrations from accounting application and moving to a new component in special purpose.) > Move 3rd party payment integrations from accounting application to plugins > -- > > Key: OFBIZ-7415 > URL: https://issues.apache.org/jira/browse/OFBIZ-7415 > Project: OFBiz > Issue Type: Improvement > Components: accounting >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Mridul Pathak >Priority: Major > Attachments: OFBIZ_7415.patch > > > This is a placeholder issue to capture all sub tasks for removing 3rd party > payment integrations from accounting application and moving to a new > component in plugins. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-7936) Move 3rd party tax integrations from order application to plugins
[ https://issues.apache.org/jira/browse/OFBIZ-7936?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-7936: --- Description: This is a placeholder issue to capture all subtasks for removing 3rd party tax integrations from order application and moving to a new component in plugins. (was: This is a placeholder issue to capture all sub tasks for removing 3rd party tax integrations from order application and moving to a new component in special purpose.) > Move 3rd party tax integrations from order application to plugins > - > > Key: OFBIZ-7936 > URL: https://issues.apache.org/jira/browse/OFBIZ-7936 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Trunk >Reporter: Mridul Pathak >Assignee: Mridul Pathak >Priority: Major > > This is a placeholder issue to capture all subtasks for removing 3rd party > tax integrations from order application and moving to a new component in > plugins. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11877. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, Akash for the report and Jacques for the review. > Convert testCreateAndUpdateContactList test from XML to Groovy > -- > > Key: OFBIZ-11877 > URL: https://issues.apache.org/jira/browse/OFBIZ-11877 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11877.patch > > > Convert testCreateAndUpdateContactList test from XML to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11929: Issue Type: Improvement (was: Bug) > Fix Literals comparisons with variable to avoid NPE > --- > > Key: OFBIZ-11929 > URL: https://issues.apache.org/jira/browse/OFBIZ-11929 > Project: OFBiz > Issue Type: Improvement > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > > With respect to our previous effort to fix the inconsistent string > comparisons[OFBIZ-9254], we are now creating a new ticket to continue this > effort. > In this ticket, we will cover all the remaining constants comparison with > variable that might lead to an NPE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11929) Fix Literals comparisons with variable to avoid NPE
[ https://issues.apache.org/jira/browse/OFBIZ-11929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11929: Description: With respect to our previous effort to fix the inconsistent string comparisons[OFBIZ-9254], we are now creating a new ticket to continue this effort. In this ticket, we will cover all the remaining constants comparison with variable that might lead to an NPE. was: With respect to our previous effort to fix the [inconsistent string comparisons|[http://issues.apache.org/jira/browse/OFBIZ-9254],] we are now creating a new ticket to continue this effort. In this ticket, we will cover all the remaining constants comparison with variable that might lead to an NPE. > Fix Literals comparisons with variable to avoid NPE > --- > > Key: OFBIZ-11929 > URL: https://issues.apache.org/jira/browse/OFBIZ-11929 > Project: OFBiz > Issue Type: Bug > Components: ALL COMPONENTS >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Devanshu Vyas >Priority: Minor > > With respect to our previous effort to fix the inconsistent string > comparisons[OFBIZ-9254], we are now creating a new ticket to continue this > effort. > In this ticket, we will cover all the remaining constants comparison with > variable that might lead to an NPE. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma closed OFBIZ-9254.
--
Resolution: Fixed
Thanks, Devanshu for your contribution.
[~jleroux] Lets create a new ticket for the number of constant changes so that
we can have a proper review. [~devanshu.vyas] Could you please create a new
Jira for the same.
I am using Fixed as Resolution as before reopen it was Fixed.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167829#comment-17167829
]
Pawan Verma commented on OFBIZ-9254:
Sure, [~jleroux] On it.
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pawan Verma reassigned OFBIZ-9254:
--
Assignee: Pawan Verma
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Pawan Verma
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167741#comment-17167741 ] Pawan Verma commented on OFBIZ-11877: - This can be tested using: ./gradlew "ofbiz --test component=marketing --test suitename=marketingtests" > Convert testCreateAndUpdateContactList test from XML to Groovy > -- > > Key: OFBIZ-11877 > URL: https://issues.apache.org/jira/browse/OFBIZ-11877 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11877.patch > > > Convert testCreateAndUpdateContactList test from XML to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11877: Attachment: OFBIZ-11877.patch > Convert testCreateAndUpdateContactList test from XML to Groovy > -- > > Key: OFBIZ-11877 > URL: https://issues.apache.org/jira/browse/OFBIZ-11877 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11877.patch > > > Convert testCreateAndUpdateContactList test from XML to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11877) Convert testCreateAndUpdateContactList test from XML to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11877?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11877: --- Assignee: Pawan Verma > Convert testCreateAndUpdateContactList test from XML to Groovy > -- > > Key: OFBIZ-11877 > URL: https://issues.apache.org/jira/browse/OFBIZ-11877 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11877.patch > > > Convert testCreateAndUpdateContactList test from XML to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167308#comment-17167308
]
Pawan Verma edited comment on OFBIZ-9254 at 7/29/20, 3:12 PM:
--
Hi [~jleroux] [~devanshu.vyas]
I think we missed to commit the latest patch that incorporates changes related
to this ticket i.e. [^OFBIZ-9254_plugins.patch] [^OFBIZ-9254.patch]
Shouldn't we reopen and handle this?
was (Author: pawan.verma):
Hi [~jleroux] [~devanshu.vyas]
I think we missed to commit the latest patch that corporates changes related to
this ticket i.e. [^OFBIZ-9254_plugins.patch] [^OFBIZ-9254.patch]
Shouldn't we reopen and handle this?
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-9254) Inconsistent String Comparisons
[
https://issues.apache.org/jira/browse/OFBIZ-9254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167308#comment-17167308
]
Pawan Verma commented on OFBIZ-9254:
Hi [~jleroux] [~devanshu.vyas]
I think we missed to commit the latest patch that corporates changes related to
this ticket i.e. [^OFBIZ-9254_plugins.patch] [^OFBIZ-9254.patch]
Shouldn't we reopen and handle this?
> Inconsistent String Comparisons
> ---
>
> Key: OFBIZ-9254
> URL: https://issues.apache.org/jira/browse/OFBIZ-9254
> Project: OFBiz
> Issue Type: Improvement
> Components: ALL COMPONENTS
>Affects Versions: Trunk
>Reporter: Devanshu Vyas
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: 18.12.01, 17.12.05
>
> Attachments: OFBIZ-9251_ftl_accounting.patch,
> OFBIZ-9251_ftl_framework.patch, OFBIZ-9251_ftl_manuf_workeffrt.patch,
> OFBIZ-9251_ftl_order.patch, OFBIZ-9251_ftl_party_content.patch,
> OFBIZ-9251_ftl_plugins_ebay_ebaystore.patch,
> OFBIZ-9251_ftl_plugins_ecommerce.patch,
> OFBIZ-9251_ftl_plugins_pricat_projmgr.patch, OFBIZ-9251_ftl_product.patch,
> OFBIZ-9251_ftl_themes.patch, OFBIZ-9254.patch, OFBIZ-9254_FTL-I.patch,
> OFBIZ-9254_groovy_applications.patch, OFBIZ-9254_groovy_framework.patch,
> OFBIZ-9254_java_Party_WE_MFC.patch, OFBIZ-9254_java_accounting.patch,
> OFBIZ-9254_java_base.patch, OFBIZ-9254_java_content.patch,
> OFBIZ-9254_java_entity.patch, OFBIZ-9254_java_order.patch,
> OFBIZ-9254_java_product.patch, OFBIZ-9254_java_service.patch,
> OFBIZ-9254_java_test_entityext_common_cattalina_datafile.patch,
> OFBIZ-9254_java_webapp.patch, OFBIZ-9254_java_webtools.patch,
> OFBIZ-9254_java_widget.patch, OFBIZ-9254_plugins.patch,
> OFBIZ-9254_plugins_groovy.patch, OFBIZ-9254_plugins_java.patch
>
>
> I found an inconsistency in the code for string comparison
> statusId.equals("PRUN_COMPLETED") whereas it should be written as
> "PRUN_COMPLETED".equals(statusId)
> cause the former can throw NullPointerException if the variable found to be
> NULL.
> This pattern should be applied to
> - Java Files
> - Groovy Files
> - FTL Files
> Here is the reference for the discussion done on the dev list.
> http://markmail.org/message/iqfaab3fl3ukxchy
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[
https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17167180#comment-17167180
]
Pawan Verma commented on OFBIZ-10791:
-
Hi [~priya.sharma.9362]
The solution makes sense to me. Just one suggestion shouldn't we use a
condition like:
if (quantity.compareTo(BigDecimal.ZERO) > 0) {
Does this make sense to you?
> Unable to add product (of ASSET_USAGE type) in order
>
>
> Key: OFBIZ-10791
> URL: https://issues.apache.org/jira/browse/OFBIZ-10791
> Project: OFBiz
> Issue Type: Bug
> Components: order
>Affects Versions: Release Branch 16.11, Release Branch 18.12, Release
> Branch 17.12, Trunk
>Reporter: Praveen Sharma
>Assignee: Priya Sharma
>Priority: Major
> Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL,
> SALES_RENTAL
> Attachments: OFBIZ-10791.patch, Screenshot from 2019-03-09
> 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot from
> 2019-03-09 11-06-36.png, asset-addtocart.png
>
>
> Steps to regenerate:
> # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main]
> # Click on order entry
> # Set customer and click on continue
> # Click continue on Enter Order Currency, Agreements, and Ship Dates page
> (Please refer attachment: 2-Continue)
> # Try to add product from Quick Lookup.
> Actual: Unable to add product for order.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11928: Description: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 2) Now change explode item to Y 3) Again create same order with same products and same quantity 4) Notice difference in item subtotal and grand total I see two issues here: - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order) Code reference: It should be handled inside ShoppingCartItem.java#explodeItem - Total sales tax is different in both orders: 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items. Demo orders on trunk (will not last for long): explode: N [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 ]explode: Y [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] was: Steps to re-generate: 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo 2) Now change explode item to Y 3) Again create same order with same products and same quantity 4) Notice difference in item subtotal and grand total I see two issues here: - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is correct when explode is set to N (default order)Code reference: It should be handled inside explodeItem method of ShoppingCartItem.java - Total sales tax is different in both orders: 10.72 and -0.03 which can be checked if this is any configuration issue, or taxes are not being handled while exploding items. Demo orders on trunk (will not last for long): explode: N [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001] explode: Y [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Priority: Major > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order) > Code reference: It should be handled inside ShoppingCartItem.java#explodeItem > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 > ]explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11859) Convert CostTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11859. --- Fix Version/s: Upcoming Branch Assignee: Pawan Verma (was: Anushi Gupta) Resolution: Implemented Thanks, Akash and Anushi! > Convert CostTests.xml to Groovy > --- > > Key: OFBIZ-11859 > URL: https://issues.apache.org/jira/browse/OFBIZ-11859 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11859.patch > > > Convert CostTests XML file to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11912) Shipment is not created during receiving
[ https://issues.apache.org/jira/browse/OFBIZ-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11912. --- Fix Version/s: Upcoming Branch Resolution: Fixed Hi [~yashwant.dhakad] The same issue is reported by Ravi under OFBIZ-11911, I've merged it in Trunk. Thanks, for your contribution. > Shipment is not created during receiving > > > Key: OFBIZ-11912 > URL: https://issues.apache.org/jira/browse/OFBIZ-11912 > Project: OFBiz > Issue Type: Bug > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11912.patch, POShipmentError.png > > > Purchase shipment is not created during receiving. In demo-stable it is > working fine so it breaks in the trunk. > Here are the steps to regenerate: > # Create the Purchase Order. > # Approve the Purchase Order. > # Click on the Receive button in Action section on the order view screen. > # The user navigated to receive screen and getting error. > Expected result: User navigated to receive screen and Purchase shipment > should be visible on the Receive screen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11911) Error in Quick Receive Purchase Order process
[ https://issues.apache.org/jira/browse/OFBIZ-11911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11911. --- Fix Version/s: Upcoming Branch Resolution: Fixed Thanks, [~lodhiravi]! > Error in Quick Receive Purchase Order process > - > > Key: OFBIZ-11911 > URL: https://issues.apache.org/jira/browse/OFBIZ-11911 > Project: OFBiz > Issue Type: Bug > Components: order, product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > Attachments: QuickReceivePOError.png > > > Quick Receive Purchase Order is not working. > Steps to regenerate- > # Create a PO by visiting > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry] if there is > no PO available to receive. > # Approve the PO. Now Quick Receive Purchase Order button appears. > # Click on that button. Error appears. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11911) Error in Quick Receive Purchase Order process
[ https://issues.apache.org/jira/browse/OFBIZ-11911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11911: --- Assignee: Pawan Verma > Error in Quick Receive Purchase Order process > - > > Key: OFBIZ-11911 > URL: https://issues.apache.org/jira/browse/OFBIZ-11911 > Project: OFBiz > Issue Type: Bug > Components: order, product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Pawan Verma >Priority: Major > Attachments: QuickReceivePOError.png > > > Quick Receive Purchase Order is not working. > Steps to regenerate- > # Create a PO by visiting > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderentry] if there is > no PO available to receive. > # Approve the PO. Now Quick Receive Purchase Order button appears. > # Click on that button. Error appears. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11912) Shipment is not created during receiving
[ https://issues.apache.org/jira/browse/OFBIZ-11912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11912: --- Assignee: Pawan Verma (was: Yashwant Dhakad) > Shipment is not created during receiving > > > Key: OFBIZ-11912 > URL: https://issues.apache.org/jira/browse/OFBIZ-11912 > Project: OFBiz > Issue Type: Bug > Components: hhfacility >Affects Versions: Trunk >Reporter: Yashwant Dhakad >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11912.patch, POShipmentError.png > > > Purchase shipment is not created during receiving. In demo-stable it is > working fine so it breaks in the trunk. > Here are the steps to regenerate: > # Create the Purchase Order. > # Approve the Purchase Order. > # Click on the Receive button in Action section on the order view screen. > # The user navigated to receive screen and getting error. > Expected result: User navigated to receive screen and Purchase shipment > should be visible on the Receive screen. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11909) Error while receiving the purchase order
[ https://issues.apache.org/jira/browse/OFBIZ-11909?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11909. --- Fix Version/s: Upcoming Branch Assignee: Pawan Verma Resolution: Fixed Thanks, [~lodhiravi]! > Error while receiving the purchase order > > > Key: OFBIZ-11909 > URL: https://issues.apache.org/jira/browse/OFBIZ-11909 > Project: OFBiz > Issue Type: Bug > Components: product/facility >Affects Versions: Trunk >Reporter: Ravi Lodhi >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > Attachments: ReceivePOError.png > > > Steps to regenerate - > 1. Log on to Facility application > (https://demo-trunk.ofbiz.apache.org/facility/control/main). > 2. Select the facility (I used Web Store Warehouse the default one) and > submit. > 3. Now from this Edit Facility page click on the Receive Inventory button > from the top button bar. > 4. Select Purchase Order Number(You can create one purchase order if there is > no PO to receive) and click on Receive Product(s) button. > 5. Select the radio button to receive the entire PO and click on the Receive > Selected Shipment button. > 6. By default, all the products of the PO come selected with the required > detail to receive. So no need to alter anything. Now click on Receive > Selected Product(s) button. > 7. The error message should appear. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11856) Convert ProductPriceTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11856. --- Fix Version/s: Upcoming Branch Resolution: Implemented > Convert ProductPriceTests.xml to Groovy > --- > > Key: OFBIZ-11856 > URL: https://issues.apache.org/jira/browse/OFBIZ-11856 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11856.patch > > > Convert ProductPriceTests XML fiel to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11217) Unable to proceed after payment information when Checkout Without Login
[ https://issues.apache.org/jira/browse/OFBIZ-11217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164769#comment-17164769 ] Pawan Verma commented on OFBIZ-11217: - Thanks, [~rashi.dhagat]! > Unable to proceed after payment information when Checkout Without Login > --- > > Key: OFBIZ-11217 > URL: https://issues.apache.org/jira/browse/OFBIZ-11217 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Rashi Dhagat >Priority: Major > Attachments: CheckoutWithoutLoginPaymentopt.webm, > V-CheckoutwithoutLogin.webm, > screencast-nimbus-capture-2020.07.25-11_34_27.webm > > > Following issues found: > # Open url [https://demo-stable.ofbiz.apache.org/ecommerce/control/main] > # Add item to cart > # Click on Quick Checkout > # Click on checkout under Checkout Without Login section > # Enter Personal Info and continue > # Enter the address and continue > # Select shipping option and continue > # Select Payment Option and continue > Actual: > # If Payment Option id PayPal/offline, Billing Address section is not > visible and unable to proceed after a click on continue on the Payment > Information page and groovy error occurred. > # If Payment Option id Credit card, Check the "Billing address is the same > as the shipping address". Page get refreshed and checked box is unchecked. > Please refer attachment for same. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11856) Convert ProductPriceTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11856: --- Assignee: Pawan Verma (was: Anushi Gupta) > Convert ProductPriceTests.xml to Groovy > --- > > Key: OFBIZ-11856 > URL: https://issues.apache.org/jira/browse/OFBIZ-11856 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11856.patch > > > Convert ProductPriceTests XML fiel to Groovy. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11895) Convert createPartyRelationshipType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11895. --- Fix Version/s: Upcoming Branch Assignee: Pawan Verma (was: Priya Sharma) Resolution: Implemented Thanks, [~priya.sharma.9362] and [~surajk]! > Convert createPartyRelationshipType service to entity-auto from Java and > update its service calls > - > > Key: OFBIZ-11895 > URL: https://issues.apache.org/jira/browse/OFBIZ-11895 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > Convert createPartyRelationshipType service to entity-auto from Java and > update its service calls > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161013#comment-17161013 ] Pawan Verma commented on OFBIZ-11894: - Thanks, [~priya.sharma.9362] [~surajk] I've approved the PR, if it looks good to you please go ahead and merge :) > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11895) Convert createPartyRelationshipType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17161010#comment-17161010 ] Pawan Verma commented on OFBIZ-11895: - Hi [~priya.sharma.9362] Changes looks good to me :) > Convert createPartyRelationshipType service to entity-auto from Java and > update its service calls > - > > Key: OFBIZ-11895 > URL: https://issues.apache.org/jira/browse/OFBIZ-11895 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Priya Sharma >Priority: Minor > > Convert createPartyRelationshipType service to entity-auto from Java and > update its service calls > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11895) Convert createPartyRelationshipType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11895?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11895: Description: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls was: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls Service should return roleTypeId instead of GenericValue. > Convert createPartyRelationshipType service to entity-auto from Java and > update its service calls > - > > Key: OFBIZ-11895 > URL: https://issues.apache.org/jira/browse/OFBIZ-11895 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Priya Sharma >Priority: Minor > > Convert createPartyRelationshipType service to entity-auto from Java and > update its service calls > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160898#comment-17160898 ] Pawan Verma commented on OFBIZ-11894: - +1 Suraj, Good point. [~priya.sharma.9362] Lets remove the test case, it's not needed now. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17160667#comment-17160667 ] Pawan Verma commented on OFBIZ-11894: - Hi [~priya.sharma.9362] Thanks for your quick work, it looks good to me :) I've tested it locally it works well, thanks again! will merge soon. > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
[ https://issues.apache.org/jira/browse/OFBIZ-11894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11894: --- Assignee: Pawan Verma (was: Priya Sharma) > Convert createRoleType service to entity-auto from Java and update its > service calls > > > Key: OFBIZ-11894 > URL: https://issues.apache.org/jira/browse/OFBIZ-11894 > Project: OFBiz > Issue Type: Improvement > Components: party >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Minor > > Convert createRoleType service to entity-auto from Java and update its > service calls > Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11370) Convert createEmailContent service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11370. --- Fix Version/s: Upcoming Branch Assignee: Pawan Verma (was: Rohit Hukkeri) Resolution: Implemented Thanks, [~devanshu.vyas] [~rohit.hukkeri] and [~nmalin]! > Convert createEmailContent service from mini-lang to groovy DSL > --- > > Key: OFBIZ-11370 > URL: https://issues.apache.org/jira/browse/OFBIZ-11370 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11370.patch, OFBIZ-11370.patch > > > Convert createEmailContent service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11392) Convert forceIndexContentKeywords service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11392. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~devanshu.vyas] and [~sourabh.jain]! > Convert forceIndexContentKeywords service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11392 > URL: https://issues.apache.org/jira/browse/OFBIZ-11392 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11392.patch > > > Convert forceIndexContentKeywords service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11390) Convert indexContentKeywords service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11390. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~devanshu.vyas] and [~aishwary]! > Convert indexContentKeywords service from mini-lang to groovy DSL > - > > Key: OFBIZ-11390 > URL: https://issues.apache.org/jira/browse/OFBIZ-11390 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-11390.patch > > > Convert indexContentKeywords service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11392) Convert forceIndexContentKeywords service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11392?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11392: --- Assignee: Pawan Verma (was: sourabh jain) > Convert forceIndexContentKeywords service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11392 > URL: https://issues.apache.org/jira/browse/OFBIZ-11392 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11392.patch > > > Convert forceIndexContentKeywords service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11390) Convert indexContentKeywords service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11390: --- Assignee: Pawan Verma (was: Aishwary Shrivastava) > Convert indexContentKeywords service from mini-lang to groovy DSL > - > > Key: OFBIZ-11390 > URL: https://issues.apache.org/jira/browse/OFBIZ-11390 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Major > Attachments: OFBIZ-11390.patch > > > Convert indexContentKeywords service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11379) Convert updateCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11379. --- Fix Version/s: Upcoming Branch Resolution: Implemented Thanks, [~devanshu.vyas], [~sourabh.jain] and [~nmalin]! > Convert updateCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11379 > URL: https://issues.apache.org/jira/browse/OFBIZ-11379 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11379.patch, OFBIZ-11379.patch > > > Convert updateCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11379) Convert updateCommContentDataResource service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11379: --- Assignee: Pawan Verma (was: sourabh jain) > Convert updateCommContentDataResource service from mini-lang to groovy DSL > -- > > Key: OFBIZ-11379 > URL: https://issues.apache.org/jira/browse/OFBIZ-11379 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-11379.patch, OFBIZ-11379.patch > > > Convert updateCommContentDataResource service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11898) Create new Find Security Group screen
Pawan Verma created OFBIZ-11898: --- Summary: Create new Find Security Group screen Key: OFBIZ-11898 URL: https://issues.apache.org/jira/browse/OFBIZ-11898 Project: OFBiz Issue Type: Improvement Components: framework/webtools Affects Versions: Trunk Reporter: Pawan Verma Implement new Find Security Group screen under webtools/security to facilitate webtools users to find appropriate security group with search parameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11897) Create new Find User Login screen
Pawan Verma created OFBIZ-11897: --- Summary: Create new Find User Login screen Key: OFBIZ-11897 URL: https://issues.apache.org/jira/browse/OFBIZ-11897 Project: OFBiz Issue Type: Improvement Components: framework/webtools Affects Versions: Trunk Reporter: Pawan Verma Implement new Find User Login screen under webtools/security to facilitate webtools users to find appropriate user login with search parameters. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11896) Quick Add Lead does not work without group name
Pawan Verma created OFBIZ-11896: --- Summary: Quick Add Lead does not work without group name Key: OFBIZ-11896 URL: https://issues.apache.org/jira/browse/OFBIZ-11896 Project: OFBiz Issue Type: Bug Components: marketing/sfa Affects Versions: Trunk Reporter: Pawan Verma Steps: # Go to [https://demo-trunk.ofbiz.apache.org/sfa/control/main] # Try to add lead with FirstName and LastName # See error on screen -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11895) Convert createPartyRelationshipType service to entity-auto from Java and update its service calls
Pawan Verma created OFBIZ-11895: --- Summary: Convert createPartyRelationshipType service to entity-auto from Java and update its service calls Key: OFBIZ-11895 URL: https://issues.apache.org/jira/browse/OFBIZ-11895 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Trunk Reporter: Pawan Verma Convert createPartyRelationshipType service to entity-auto from Java and update its service calls Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11894) Convert createRoleType service to entity-auto from Java and update its service calls
Pawan Verma created OFBIZ-11894: --- Summary: Convert createRoleType service to entity-auto from Java and update its service calls Key: OFBIZ-11894 URL: https://issues.apache.org/jira/browse/OFBIZ-11894 Project: OFBiz Issue Type: Improvement Components: party Affects Versions: Trunk Reporter: Pawan Verma Convert createRoleType service to entity-auto from Java and update its service calls Service should return roleTypeId instead of GenericValue. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159855#comment-17159855 ] Pawan Verma commented on OFBIZ-11888: - Thanks, [~pritam.kute] for the report. Done at #b0a9474. > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Fix For: Release Branch 18.12, Release Branch 17.12, Upcoming > Branch > > Attachments: API Reference.mp4, OFBIZ-11888.patch > > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159780#comment-17159780 ] Pawan Verma commented on OFBIZ-11888: - Thanks, Jacques for the confirmation. I've pushed the changes and it's live now. Please have a look and if it looks good, we can close this ticket. Thanks! > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: API Reference.mp4, OFBIZ-11888.patch > > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159701#comment-17159701 ] Pawan Verma commented on OFBIZ-11888: - Thanks Jacques, For that I would suggest this solution: [^API Reference.mp4] While working on this, I've done changes in header.tpl.php and run ./php2html.sh. It did changes in all the HTML templates including release-notes. Are these changes intentional? Attached a patch for the review. [^OFBIZ-11888.patch] > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: API Reference.mp4, OFBIZ-11888.patch > > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11888: Attachment: OFBIZ-11888.patch > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: API Reference.mp4, OFBIZ-11888.patch > > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11888: Attachment: API Reference.mp4 > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > Attachments: API Reference.mp4 > > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11732) Rendering issue on findorders page
[ https://issues.apache.org/jira/browse/OFBIZ-11732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11732. --- Resolution: Cannot Reproduce Thanks, Arpit, Akash, and Jacques! > Rendering issue on findorders page > -- > > Key: OFBIZ-11732 > URL: https://issues.apache.org/jira/browse/OFBIZ-11732 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Akash Jain >Priority: Major > Attachments: OFBIZ-11732.png, RenderingIssue.png > > > Steps to regenerate: > # Navigate to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders] > # Click on find button > Actual: Rendering issue on pages. Please refer attachment: RenderingIssue.jpg > !RenderingIssue.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11888: --- Assignee: Pawan Verma > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Assignee: Pawan Verma >Priority: Major > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
[ https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17157332#comment-17157332 ] Pawan Verma commented on OFBIZ-11888: - Yes, thanks [~jleroux] , dev discussion would be good, I'll start a thread soon. > OFBiz API Reference link does not work for Developers#Documentation and Help > > > Key: OFBIZ-11888 > URL: https://issues.apache.org/jira/browse/OFBIZ-11888 > Project: OFBiz > Issue Type: Bug > Components: site >Affects Versions: Trunk >Reporter: Pawan Verma >Priority: Major > > Steps: > # Go to [https://ofbiz.apache.org/developers.html] > # Navigate to Documentation and Help section > # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help
Pawan Verma created OFBIZ-11888: --- Summary: OFBiz API Reference link does not work for Developers#Documentation and Help Key: OFBIZ-11888 URL: https://issues.apache.org/jira/browse/OFBIZ-11888 Project: OFBiz Issue Type: Bug Components: site Affects Versions: Trunk Reporter: Pawan Verma Steps: # Go to [https://ofbiz.apache.org/developers.html] # Navigate to Documentation and Help section # Try to click OFBiz API Reference link. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-11751) Add getter in LabelFile.java
[ https://issues.apache.org/jira/browse/OFBIZ-11751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-11751. --- Resolution: Implemented > Add getter in LabelFile.java > > > Key: OFBIZ-11751 > URL: https://issues.apache.org/jira/browse/OFBIZ-11751 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > I am currently working on a custom plugin for the translation of LabelFiles. > For an easier search a getter for componentName is necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11867) Convert ShoppingCartTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156612#comment-17156612 ] Pawan Verma commented on OFBIZ-11867: - Hi Akash I tried converting testCreateOrderConfigurableServiceProduct to groovy while working on OFBIZ-11553. This might help while converting other tests as well. [^OFBIZ-11867.patch] > Convert ShoppingCartTests.xml to Groovy > --- > > Key: OFBIZ-11867 > URL: https://issues.apache.org/jira/browse/OFBIZ-11867 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Akash Jain >Priority: Minor > Attachments: OFBIZ-11867.patch > > > Convert ShoppingCartTests XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11867) Convert ShoppingCartTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11867?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-11867: Attachment: OFBIZ-11867.patch > Convert ShoppingCartTests.xml to Groovy > --- > > Key: OFBIZ-11867 > URL: https://issues.apache.org/jira/browse/OFBIZ-11867 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Akash Jain >Assignee: Akash Jain >Priority: Minor > Attachments: OFBIZ-11867.patch > > > Convert ShoppingCartTests XML file to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11751) Add getter in LabelFile.java
[ https://issues.apache.org/jira/browse/OFBIZ-11751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma reassigned OFBIZ-11751: --- Assignee: Pawan Verma > Add getter in LabelFile.java > > > Key: OFBIZ-11751 > URL: https://issues.apache.org/jira/browse/OFBIZ-11751 > Project: OFBiz > Issue Type: Improvement > Components: framework/webtools >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Pawan Verma >Priority: Minor > Fix For: Upcoming Branch > > > I am currently working on a custom plugin for the translation of LabelFiles. > For an easier search a getter for componentName is necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11380) Convert createCommEventContentAssoc service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156308#comment-17156308 ] Pawan Verma commented on OFBIZ-11380: - +1 > Convert createCommEventContentAssoc service from mini-lang to groovy DSL > > > Key: OFBIZ-11380 > URL: https://issues.apache.org/jira/browse/OFBIZ-11380 > Project: OFBiz > Issue Type: Sub-task > Components: content >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rushikesh Mawal >Priority: Minor > Attachments: OFBIZ-11380.patch > > > Convert createCommEventContentAssoc service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156293#comment-17156293 ] Pawan Verma edited comment on OFBIZ-11553 at 7/12/20, 11:27 AM: I'd looked into it and found that the order created with test case testCreateOrderServiceProduct did not get approved so the quick ship process did not work correctly while with specific configurableServiceOrder-test new order has got approved and the quick ship process worked correctly. I tried to have a deep look and we got multiple payment methods i.e. EXT_PAYPAL and EXT_COD but in the test case only EXT_COD was defined. I've removed the shopping cart tests and testIntegration works perfectly. So, IMO we can convert shopping cart tests to Groovy and have a deep look into the issue. HTH for further investigation. was (Author: pawan.verma): I'd looked into and found that the order created with test case testCreateOrderServiceProduct did not get approved so the quick ship process did not work correctly while with specific configurableServiceOrder-test new order has got approved and the quick ship process worked correctly. I tried to have a deep look and we got multiple payment methods i.e. EXT_PAYPAL and EXT_COD but in the test case only EXT_COD was defined. I've removed the shopping cart tests and testIntegration works perfectly. So, IMO we can convert shopping cart tests to Groovy and have a deep look into the issue. HTH for further investigation. > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156293#comment-17156293 ] Pawan Verma commented on OFBIZ-11553: - I'd looked into and found that the order created with test case testCreateOrderServiceProduct did not get approved so the quick ship process did not work correctly while with specific configurableServiceOrder-test new order has got approved and the quick ship process worked correctly. I tried to have a deep look and we got multiple payment methods i.e. EXT_PAYPAL and EXT_COD but in the test case only EXT_COD was defined. I've removed the shopping cart tests and testIntegration works perfectly. So, IMO we can convert shopping cart tests to Groovy and have a deep look into the issue. HTH for further investigation. > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11732) Rendering issue on findorders page
[ https://issues.apache.org/jira/browse/OFBIZ-11732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156073#comment-17156073 ] Pawan Verma commented on OFBIZ-11732: - Hi [~akash.jain] [~arpit.mor] I think this is the same issue I fixed under OFBIZ-11736, We can confirm it via revert change of OFBIZ-11736 and change admin's Name from partymgr and verify the issue. I think OFBIZ-11736 has fixed this issue :) > Rendering issue on findorders page > -- > > Key: OFBIZ-11732 > URL: https://issues.apache.org/jira/browse/OFBIZ-11732 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Trunk >Reporter: Arpit Mor >Assignee: Akash Jain >Priority: Major > Attachments: OFBIZ-11732.png, RenderingIssue.png > > > Steps to regenerate: > # Navigate to URL: > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/findorders] > # Click on find button > Actual: Rendering issue on pages. Please refer attachment: RenderingIssue.jpg > !RenderingIssue.png! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma closed OFBIZ-10891. --- Fix Version/s: 17.12.04 18.12.01 Resolution: Fixed > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ashish Sharma >Assignee: Pawan Verma >Priority: Minor > Fix For: 18.12.01, 17.12.04 > > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, > OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10891) Send me this every month link is not working in order items section.
[ https://issues.apache.org/jira/browse/OFBIZ-10891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pawan Verma updated OFBIZ-10891: Affects Version/s: (was: 17.12.03) Release Branch 17.12 > Send me this every month link is not working in order items section. > > > Key: OFBIZ-10891 > URL: https://issues.apache.org/jira/browse/OFBIZ-10891 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Ashish Sharma >Assignee: Pawan Verma >Priority: Minor > Attachments: OFBIZ-10891-Reopen.png, OFBIZ-10891.patch, > OFBIZ-10891.png > > > *Steps to Reproduce* > 1. Login with valid username and password. > 2. Navigate to ecommerce. > 3. Place a order. > 4. Navigate to order history and click on view link. > 5. Click on link “send me this every month” in order items section. > *Actual Result:* Error message is displayed. > *Screen print attached* -- This message was sent by Atlassian Jira (v8.3.4#803005)
