[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration

2020-08-22 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182334#comment-17182334
 ] 

Pritam Kute commented on OFBIZ-11837:
-

Improved the Auth service to handle more gateway errors. Also fixed the issue 
in refund service. Here is the link to PR

https://github.com/apache/ofbiz-plugins/pull/39

> First Data Payment Gateway Integration
> --
>
> Key: OFBIZ-11837
> URL: https://issues.apache.org/jira/browse/OFBIZ-11837
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
>
> Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih]
> Apache OFBiz has OOTB integrations for most of the widely used payment 
> gateways around the world.
> We are working on integrating First Data Payment Gateway for one of the 
> websites. The First Data payment gateway is quite popular and comes in the 
> list of top payment gateways around the globe. We would like to contribute 
> the basic payment gateway integration of First Data into Apache OFBiz.
> Also as discussed over the DEV list, we will be contributing gateway as a 
> separate plugin.
> We will create the subtasks under this main task to deliver different payment 
> gateway methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-10973) Rename custom component for SMS gateway integration

2020-08-01 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169282#comment-17169282
 ] 

Pritam Kute commented on OFBIZ-10973:
-

Hello [~pawan], we can rename this plugin to "sms-msg91" which is suggested by 
[~jleroux].

[~jleroux] the initial thought behind having this integration in place was to 
have common code in the framework which could be so generic that users can 
build any custom plugin and call framework methods to send SMS, WhatsApp 
message or even a message on Facebook messenger. So that's why we had called it 
"msggateway". But now, I think as it is an independent plugin and all generic 
code is in the framework itself, we can rename this plugin as sms-msg91

> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway 
> integration:
> {quote}
> "In understand that this component currently uses "msg91 services to send 
> sms".
> But could we not have another name, more explicit, for this component, like 
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not 
> associate the name of an open source component to a commercial services  
> provider (with a free SMS quota option). Even if hopefully it will stay as 
> is..."
> {quote}
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11727) Warning message should be shown when added back date with card details

2020-07-25 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164931#comment-17164931
 ] 

Pritam Kute commented on OFBIZ-11727:
-

Hello [~Dikpal.Kanungo]

Can you please check this once again? Looks like it is working fine now. We 
have fixed the related ticket. If it's working as expected, feel free to close 
the ticket.

> Warning message should be shown when added back date with card details
> --
>
> Key: OFBIZ-11727
> URL: https://issues.apache.org/jira/browse/OFBIZ-11727
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Pritam Kute
>Priority: Minor
> Attachments: Back date should not be selected.png
>
>
>  
> Steps to regenerate:
> 1. Navigate to : [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> 2. Add products to cart  and proceed with 'Single page checkout'
> 3. In step 4 for the checkout process at Billing and shipping form, try 
> adding a back date for the in reference to card details 
> 4. It will not prompt the user for adding an expiry date, and the page will 
> just refresh again and again 
>  
> Expected: User should be notified of adding an expired date. 
>  
> Reference: 
> !Back date should not be selected.png!
>  
> Let me know if you need any further help with the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11838) One page checkout is broken because of ordermgr::getAssociatedStateList

2020-07-25 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17164871#comment-17164871
 ] 

Pritam Kute commented on OFBIZ-11838:
-

Hello [~jleroux],

I have investigated more on 
[OFBIZ-2562|https://issues.apache.org/jira/browse/OFBIZ-2562] and made the 
following observations.

On orderview screen at the ordermgr, when a user tries to change the status of 
the order, in OrderInfo.ftl, we are calling "changeOrderStatus" request as

{code:java}

<@ofbizUrl>changeOrderStatus/orderview

{code}

Hence when the request is done, it is rewriting URL to 
https://localhost:8443/ordermgr/control/changeOrderStatus/orderview. When js 
functions are running in the backend like "getAssociatedStateList" are called, 
they are getting the wrong URL to send a request to. This was causing the issue.

For now, there are two different fixes that can handle both problems which are 
mentioned in [OFBIZ-2562|https://issues.apache.org/jira/browse/OFBIZ-2562] and 
[OFBIZ-11838|https://issues.apache.org/jira/browse/OFBIZ-11838].
# To change the request mapping for "changeOrderStatus" and add 
request-redirect to "orderview" screen. Change the actions in the forms in 
OrderInfo.ftl to call "changeOrderStatus" request only and then remove code in 
"getAssociatedStateList" js function to rewrite URL.
# To add .length to the existing URL rewrite code written in 
"getAssociatedStateList" js function as

{code:java}

if (jQuery('#orderViewed').length) {
requestToSend = "/ordermgr/control/getAssociatedStateList"
}

{code}


> One page checkout is broken because of ordermgr::getAssociatedStateList
> ---
>
> Key: OFBIZ-11838
> URL: https://issues.apache.org/jira/browse/OFBIZ-11838
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
>
> It works in example/control/FormWidgetExamples so it's an ecommerce issue. It 
> also works at https://demo-stable.ofbiz.apache.org/ecomseo/onePageCheckout so 
> it's something "recent"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11888) OFBiz API Reference link does not work for Developers#Documentation and Help

2020-07-17 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17159816#comment-17159816
 ] 

Pritam Kute commented on OFBIZ-11888:
-

[~pawan] I just checked the markup of the 
https://ofbiz.apache.org/developers.html and I feel that we could use "h3" tag 
for "OFBiz API Reference" title instead of "strong" to make it aligned with the 
markup on that page. 

{code:html}
OFBiz API Reference
{code}


> OFBiz API Reference link does not work for Developers#Documentation and Help
> 
>
> Key: OFBIZ-11888
> URL: https://issues.apache.org/jira/browse/OFBIZ-11888
> Project: OFBiz
>  Issue Type: Bug
>  Components: site
>Affects Versions: Trunk
>Reporter: Pawan Verma
>Assignee: Pawan Verma
>Priority: Major
> Fix For: Release Branch 18.12, Release Branch 17.12, Upcoming 
> Branch
>
> Attachments: API Reference.mp4, OFBIZ-11888.patch
>
>
> Steps:
>  # Go to [https://ofbiz.apache.org/developers.html]
>  # Navigate to Documentation and Help section
>  # Try to click  OFBiz API Reference link.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception

2020-06-30 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17149080#comment-17149080
 ] 

Pritam Kute commented on OFBIZ-11843:
-

Thanks [~jleroux]!

> Accept return process throwing missing method exception
> ---
>
> Key: OFBIZ-11843
> URL: https://issues.apache.org/jira/browse/OFBIZ-11843
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pawan Verma
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Steps to regenerate:
> 1. Open any return in requested status
> 2. Go to 'Return Items' menu
> 3. Click on the 'Accept Return' button.
> Expected Result:
> The return should be marked as accepted in the system.
> Actual:
> Error screen with error log as:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error 
> (groovy.lang.MissingMethodException: No signature of method: static 
> java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) 
> values: [0.01] Possible solutions: minus(java.lang.Character), 
> minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find())



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception

2020-06-29 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17147758#comment-17147758
 ] 

Pritam Kute commented on OFBIZ-11843:
-

[~jleroux] No I haven't created an issue for the other cases. I was waiting for 
the comments from the community if we can fix it under the same issue. I think 
we can create a separate issue for this.

> Accept return process throwing missing method exception
> ---
>
> Key: OFBIZ-11843
> URL: https://issues.apache.org/jira/browse/OFBIZ-11843
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pawan Verma
>Priority: Major
> Fix For: Upcoming Branch
>
>
> Steps to regenerate:
> 1. Open any return in requested status
> 2. Go to 'Return Items' menu
> 3. Click on the 'Accept Return' button.
> Expected Result:
> The return should be marked as accepted in the system.
> Actual:
> Error screen with error log as:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error 
> (groovy.lang.MissingMethodException: No signature of method: static 
> java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) 
> values: [0.01] Possible solutions: minus(java.lang.Character), 
> minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find())



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception

2020-06-27 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146916#comment-17146916
 ] 

Pritam Kute commented on OFBIZ-11843:
-

Create the PR at https://github.com/apache/ofbiz-framework/pull/211

Let me know if we are going to fix the typecasting issue in a single commit. I 
will update the patch accordingly.

> Accept return process throwing missing method exception
> ---
>
> Key: OFBIZ-11843
> URL: https://issues.apache.org/jira/browse/OFBIZ-11843
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
> Fix For: Trunk
>
>
> Steps to regenerate:
> 1. Open any return in requested status
> 2. Go to 'Return Items' menu
> 3. Click on the 'Accept Return' button.
> Expected Result:
> The return should be marked as accepted in the system.
> Actual:
> Error screen with error log as:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error 
> (groovy.lang.MissingMethodException: No signature of method: static 
> java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) 
> values: [0.01] Possible solutions: minus(java.lang.Character), 
> minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find())



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11843) Accept return process throwing missing method exception

2020-06-27 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146911#comment-17146911
 ] 

Pritam Kute commented on OFBIZ-11843:
-

I have observed that for typecasting in groovy, we have used the wrong coding 
pattern like

{code:java}
(BigDecimal) -0.01
{code}

It should be like

{code:java}
-0.01 as BigDecimal
{code}

Making these changes fixes this issue. Let me know if I am missing anything 
here.

I also found one more issue at OrderReturnServices.groovy:302

Here the 'ctx' map is initialized directly with the GenericValue 
'returnAdjustment'. This is throwing error as the ctx is not getting built up 
properly. We can fix it using following code snippet.

{code:java}

Map ctx = [:]
ctx << returnAdjustment
ctx.originalReturnPrice = originalReturnPrice

{code}


> Accept return process throwing missing method exception
> ---
>
> Key: OFBIZ-11843
> URL: https://issues.apache.org/jira/browse/OFBIZ-11843
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
> Fix For: Trunk
>
>
> Steps to regenerate:
> 1. Open any return in requested status
> 2. Go to 'Return Items' menu
> 3. Click on the 'Accept Return' button.
> Expected Result:
> The return should be marked as accepted in the system.
> Actual:
> Error screen with error log as:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error 
> (groovy.lang.MissingMethodException: No signature of method: static 
> java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) 
> values: [0.01] Possible solutions: minus(java.lang.Character), 
> minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find())



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11843) Accept return process throwing missing method exception

2020-06-27 Thread Pritam Kute (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-11843:
---

Assignee: Pritam Kute

> Accept return process throwing missing method exception
> ---
>
> Key: OFBIZ-11843
> URL: https://issues.apache.org/jira/browse/OFBIZ-11843
> Project: OFBiz
>  Issue Type: Bug
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
> Fix For: Trunk
>
>
> Steps to regenerate:
> 1. Open any return in requested status
> 2. Go to 'Return Items' menu
> 3. Click on the 'Accept Return' button.
> Expected Result:
> The return should be marked as accepted in the system.
> Actual:
> Error screen with error log as:
> org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error 
> (groovy.lang.MissingMethodException: No signature of method: static 
> java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) 
> values: [0.01] Possible solutions: minus(java.lang.Character), 
> minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find())



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11843) Accept return process throwing missing method exception

2020-06-27 Thread Pritam Kute (Jira)
Pritam Kute created OFBIZ-11843:
---

 Summary: Accept return process throwing missing method exception
 Key: OFBIZ-11843
 URL: https://issues.apache.org/jira/browse/OFBIZ-11843
 Project: OFBiz
  Issue Type: Bug
Reporter: Pritam Kute
 Fix For: Trunk


Steps to regenerate:
1. Open any return in requested status
2. Go to 'Return Items' menu
3. Click on the 'Accept Return' button.

Expected Result:
The return should be marked as accepted in the system.

Actual:
Error screen with error log as:

org.apache.ofbiz.webapp.event.EventHandlerException: Service invocation error 
(groovy.lang.MissingMethodException: No signature of method: static 
java.math.BigDecimal.minus() is applicable for argument types: (BigDecimal) 
values: [0.01] Possible solutions: minus(java.lang.Character), 
minus(java.lang.Number), min(java.math.BigDecimal), plus(), signum(), find())




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11841) Integration using token-based transaction support

2020-06-24 Thread Pritam Kute (Jira)
Pritam Kute created OFBIZ-11841:
---

 Summary: Integration using token-based transaction support
 Key: OFBIZ-11841
 URL: https://issues.apache.org/jira/browse/OFBIZ-11841
 Project: OFBiz
  Issue Type: Sub-task
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: Pritam Kute


In this ticket, we will take care of the configurable way to switch to 
token-based transactions instead of regular card transactions. This is a need 
to make website PCI DSS compliant.

We are going to make this configurable from PaymentGatewayFirstData entity 
using enableDataVault flag. This entity definition is already pushed in basic 
card-based integration implementation.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration

2020-06-24 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144647#comment-17144647
 ] 

Pritam Kute commented on OFBIZ-11837:
-

Here is the PR raised for this task. PR contains basic integration of the First 
Data payment gateway methods like Auth, Capture, Refund, and Release.

https://github.com/apache/ofbiz-plugins/pull/34

> First Data Payment Gateway Integration
> --
>
> Key: OFBIZ-11837
> URL: https://issues.apache.org/jira/browse/OFBIZ-11837
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
>
> Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih]
> Apache OFBiz has OOTB integrations for most of the widely used payment 
> gateways around the world.
> We are working on integrating First Data Payment Gateway for one of the 
> websites. The First Data payment gateway is quite popular and comes in the 
> list of top payment gateways around the globe. We would like to contribute 
> the basic payment gateway integration of First Data into Apache OFBiz.
> Also as discussed over the DEV list, we will be contributing gateway as a 
> separate plugin.
> We will create the subtasks under this main task to deliver different payment 
> gateway methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11837) First Data Payment Gateway Integration

2020-06-19 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140447#comment-17140447
 ] 

Pritam Kute commented on OFBIZ-11837:
-

Thanks [~jleroux] for this. We will use this ticket for moving custom gateway 
code from the framework to plugins.

> First Data Payment Gateway Integration
> --
>
> Key: OFBIZ-11837
> URL: https://issues.apache.org/jira/browse/OFBIZ-11837
> Project: OFBiz
>  Issue Type: New Feature
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
>
> Dev Thread Link: [https://markmail.org/thread/2p5top4idkeiwlih]
> Apache OFBiz has OOTB integrations for most of the widely used payment 
> gateways around the world.
> We are working on integrating First Data Payment Gateway for one of the 
> websites. The First Data payment gateway is quite popular and comes in the 
> list of top payment gateways around the globe. We would like to contribute 
> the basic payment gateway integration of First Data into Apache OFBiz.
> Also as discussed over the DEV list, we will be contributing gateway as a 
> separate plugin.
> We will create the subtasks under this main task to deliver different payment 
> gateway methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (OFBIZ-11837) First Data Payment Gateway Integration

2020-06-19 Thread Pritam Kute (Jira)
Pritam Kute created OFBIZ-11837:
---

 Summary: First Data Payment Gateway Integration
 Key: OFBIZ-11837
 URL: https://issues.apache.org/jira/browse/OFBIZ-11837
 Project: OFBiz
  Issue Type: New Feature
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: Pritam Kute


Apache OFBiz has OOTB integrations for most of the widely used payment gateways 
around the world.

We are working on integrating First Data Payment Gateway for one of the 
websites. The First Data payment gateway is quite popular and comes in the list 
of top payment gateways around the globe. We would like to contribute the basic 
payment gateway integration of First Data into Apache OFBiz.

Also as discussed over the DEV list, we will be contributing gateway as a 
separate plugin.

We will create the subtasks under this main task to deliver different payment 
gateway methods.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11727) Warning message should be shown when added back date with card details

2020-05-23 Thread Pritam Kute (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114810#comment-17114810
 ] 

Pritam Kute commented on OFBIZ-11727:
-

[~Dikpal.Kanungo] While fixing this issue, I found that list of states was not 
getting populated when we select the country in the drop-down while adding 
shipping and billing address on single page checkout screen. I am covering the 
fix of the issue in the same patch.

> Warning message should be shown when added back date with card details
> --
>
> Key: OFBIZ-11727
> URL: https://issues.apache.org/jira/browse/OFBIZ-11727
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Pritam Kute
>Priority: Minor
> Attachments: Back date should not be selected.png
>
>
>  
> Steps to regenerate:
> 1. Navigate to : [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> 2. Add products to cart  and proceed with 'Single page checkout'
> 3. In step 4 for the checkout process at Billing and shipping form, try 
> adding a back date for the in reference to card details 
> 4. It will not prompt the user for adding an expiry date, and the page will 
> just refresh again and again 
>  
> Expected: User should be notified of adding an expired date. 
>  
> Reference: 
> !Back date should not be selected.png!
>  
> Let me know if you need any further help with the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (OFBIZ-11727) Warning message should be shown when added back date with card details

2020-05-23 Thread Pritam Kute (Jira)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-11727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-11727:
---

Assignee: Pritam Kute

> Warning message should be shown when added back date with card details
> --
>
> Key: OFBIZ-11727
> URL: https://issues.apache.org/jira/browse/OFBIZ-11727
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Dikpal Kanungo
>Assignee: Pritam Kute
>Priority: Minor
> Attachments: Back date should not be selected.png
>
>
>  
> Steps to regenerate:
> 1. Navigate to : [https://demo-trunk.ofbiz.apache.org/ecommerce/control/main]
> 2. Add products to cart  and proceed with 'Single page checkout'
> 3. In step 4 for the checkout process at Billing and shipping form, try 
> adding a back date for the in reference to card details 
> 4. It will not prompt the user for adding an expiry date, and the page will 
> just refresh again and again 
>  
> Expected: User should be notified of adding an expired date. 
>  
> Reference: 
> !Back date should not be selected.png!
>  
> Let me know if you need any further help with the same.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (OFBIZ-10973) Rename custom component for SMS gateway integration

2019-04-27 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10973:

Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-10457

> Rename custom component for SMS gateway integration
> ---
>
> Key: OFBIZ-10973
> URL: https://issues.apache.org/jira/browse/OFBIZ-10973
> Project: OFBiz
>  Issue Type: Sub-task
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: vivek singh bisen
>Priority: Major
>
> As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway 
> integration:
> "In understand that this component currently uses "msg91 services to send 
> sms".
> But could we not have another name, more explicit, for this component, like 
> sms or sendsms for instance?
> Services tend to disappear or change (Google is the best example). So I'd not 
> associate the name of an open source component to a commercial services 
> provider (with a free SMS quota option). Even if hopefully it will stay as 
> is..."
> Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10973) Rename custom component for SMS gateway integration

2019-04-27 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10973:
---

 Summary: Rename custom component for SMS gateway integration
 Key: OFBIZ-10973
 URL: https://issues.apache.org/jira/browse/OFBIZ-10973
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: vivek singh bisen


As per the comment by [~jacques.le.roux] on the commit log of the SMS gateway 
integration:

"In understand that this component currently uses "msg91 services to send sms".

But could we not have another name, more explicit, for this component, like sms 
or sendsms for instance?

Services tend to disappear or change (Google is the best example). So I'd not 
associate the name of an open source component to a commercial services 
provider (with a free SMS quota option). Even if hopefully it will stay as 
is..."

Need to rename the custom component and replace all occurrences in code level.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10125) Error exporting Product entities

2019-04-27 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827480#comment-16827480
 ] 

Pritam Kute commented on OFBIZ-10125:
-

Hello [~trboyden]

I have followed the steps provided by you and I am able to export the data 
successfully.
OS used: Ubuntu 18.04
Directory used : /home

> Error exporting Product entities
> 
>
> Key: OFBIZ-10125
> URL: https://issues.apache.org/jira/browse/OFBIZ-10125
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Release Branch 16.11
> Environment: Windows 10 Pro x64. Java 8 152. MS SQL 2017 Linux Docker 
> image.
>Reporter: Timothy Boyden
>Priority: Major
>
> Got the following error attempting to export Products using the Export XML 
> tool:
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen [component://webtools/widget/EntityScreens.xml#xmldsdump]: 
> org.apache.ofbiz.widget.renderer.ScreenRenderException: Error rendering 
> screen 
> [component://webtools/widget/CommonScreens.xml#CommonImportExportDecorator]: 
> org.apache.ofbiz.entity.transaction.GenericTransactionException: The current 
> transaction is marked for rollback, not beginning a new transaction and 
> aborting current operation; the rollbackOnly was caused by: [1] [xxx] Error 
> when writing Product: org.apache.ofbiz.entity.GenericDataSourceException: SQL 
> Exception while executing the following:SELECT DISTINCT PRODUCT_ID, 
> PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, 
> FACILITY_ID, INTRODUCTION_DATE, RELEASE_DATE, SUPPORT_DISCONTINUATION_DATE, 
> SALES_DISCONTINUATION_DATE, SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, 
> BRAND_NAME, COMMENTS, PRODUCT_NAME, DESCRIPTION, LONG_DESCRIPTION, 
> PRICE_DETAIL_TEXT, SMALL_IMAGE_URL, MEDIUM_IMAGE_URL, LARGE_IMAGE_URL, 
> DETAIL_IMAGE_URL, ORIGINAL_IMAGE_URL, DETAIL_SCREEN, INVENTORY_MESSAGE, 
> INVENTORY_ITEM_TYPE_ID, REQUIRE_INVENTORY, QUANTITY_UOM_ID, 
> QUANTITY_INCLUDED, PIECES_INCLUDED, REQUIRE_AMOUNT, FIXED_AMOUNT, 
> AMOUNT_UOM_TYPE_ID, WEIGHT_UOM_ID, SHIPPING_WEIGHT, PRODUCT_WEIGHT, 
> HEIGHT_UOM_ID, PRODUCT_HEIGHT, SHIPPING_HEIGHT, WIDTH_UOM_ID, PRODUCT_WIDTH, 
> SHIPPING_WIDTH, DEPTH_UOM_ID, PRODUCT_DEPTH, SHIPPING_DEPTH, DIAMETER_UOM_ID, 
> PRODUCT_DIAMETER, PRODUCT_RATING, RATING_TYPE_ENUM, RETURNABLE, TAXABLE, 
> CHARGE_SHIPPING, AUTO_CREATE_KEYWORDS, INCLUDE_IN_PROMOTIONS, IS_VIRTUAL, 
> IS_VARIANT, VIRTUAL_VARIANT_METHOD_ENUM, ORIGIN_GEO_ID, 
> REQUIREMENT_METHOD_ENUM_ID, BILL_OF_MATERIAL_LEVEL, RESERV_MAX_PERSONS, 
> RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, CONFIG_ID, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> IN_SHIPPING_BOX, DEFAULT_SHIPMENT_BOX_TYPE_ID, LOT_ID_FILLED_IN, 
> ORDER_DECIMAL_QUANTITY, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
> CREATED_STAMP, CREATED_TX_STAMP FROM dbo.PRODUCT ORDER BY PRODUCT_ID ASC (The 
> text data type cannot be selected as DISTINCT because it is not 
> comparable.)org.apache.ofbiz.entity.GenericDataSourceException: SQL Exception 
> while executing the following:SELECT DISTINCT PRODUCT_ID, PRODUCT_TYPE_ID, 
> PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, FACILITY_ID, 
> INTRODUCTION_DATE, RELEASE_DATE, SUPPORT_DISCONTINUATION_DATE, 
> SALES_DISCONTINUATION_DATE, SALES_DISC_WHEN_NOT_AVAIL, INTERNAL_NAME, 
> BRAND_NAME, COMMENTS, PRODUCT_NAME, DESCRIPTION, LONG_DESCRIPTION, 
> PRICE_DETAIL_TEXT, SMALL_IMAGE_URL, MEDIUM_IMAGE_URL, LARGE_IMAGE_URL, 
> DETAIL_IMAGE_URL, ORIGINAL_IMAGE_URL, DETAIL_SCREEN, INVENTORY_MESSAGE, 
> INVENTORY_ITEM_TYPE_ID, REQUIRE_INVENTORY, QUANTITY_UOM_ID, 
> QUANTITY_INCLUDED, PIECES_INCLUDED, REQUIRE_AMOUNT, FIXED_AMOUNT, 
> AMOUNT_UOM_TYPE_ID, WEIGHT_UOM_ID, SHIPPING_WEIGHT, PRODUCT_WEIGHT, 
> HEIGHT_UOM_ID, PRODUCT_HEIGHT, SHIPPING_HEIGHT, WIDTH_UOM_ID, PRODUCT_WIDTH, 
> SHIPPING_WIDTH, DEPTH_UOM_ID, PRODUCT_DEPTH, SHIPPING_DEPTH, DIAMETER_UOM_ID, 
> PRODUCT_DIAMETER, PRODUCT_RATING, RATING_TYPE_ENUM, RETURNABLE, TAXABLE, 
> CHARGE_SHIPPING, AUTO_CREATE_KEYWORDS, INCLUDE_IN_PROMOTIONS, IS_VIRTUAL, 
> IS_VARIANT, VIRTUAL_VARIANT_METHOD_ENUM, ORIGIN_GEO_ID, 
> REQUIREMENT_METHOD_ENUM_ID, BILL_OF_MATERIAL_LEVEL, RESERV_MAX_PERSONS, 
> RESERV2ND_P_P_PERC, RESERV_NTH_P_P_PERC, CONFIG_ID, CREATED_DATE, 
> CREATED_BY_USER_LOGIN, LAST_MODIFIED_DATE, LAST_MODIFIED_BY_USER_LOGIN, 
> IN_SHIPPING_BOX, DEFAULT_SHIPMENT_BOX_TYPE_ID, LOT_ID_FILLED_IN, 
> ORDER_DECIMAL_QUANTITY, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, 
> CREATED_STAMP, CREATED_TX_STAMP FROM dbo.PRODUCT ORDER BY PRODUCT_ID ASC (The 
> text data type cannot be selected as DISTINCT because it is not comparable.) 
> (SQL Exception while executing the following:SELECT DISTINCT PRODUCT_ID, 
> PRODUCT_TYPE_ID, PRIMARY_PRODUCT_CATEGORY_ID, MANUFACTURER_PARTY_ID, 
> FACILITY_ID, INTRODUCTION_DATE, 

[jira] [Created] (OFBIZ-10952) Add support of applying price rule to the selected options during the configurable product ordering workflow

2019-04-24 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10952:
---

 Summary: Add support of applying price rule to the selected 
options during the configurable product ordering workflow
 Key: OFBIZ-10952
 URL: https://issues.apache.org/jira/browse/OFBIZ-10952
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Pritam Kute


Add the support for setting and apply the price rules on a configurable item 
based on other sets of opted configurable items.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10951) Add code level support to honor the compatibility between the opted products during configurable order workflow

2019-04-24 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10951:
---

 Summary: Add code level support to honor the compatibility between 
the opted products during configurable order workflow
 Key: OFBIZ-10951
 URL: https://issues.apache.org/jira/browse/OFBIZ-10951
 Project: OFBiz
  Issue Type: Improvement
  Components: product
Affects Versions: Trunk
Reporter: Pritam Kute


Have the ability to set and honor the compatibility between opted product 
during configurable goods ordering

There is already an entity "ProductConfigOptionIactn" in place for defining the 
compatibility between the config options. Need to add code level support to 
honor the compatibility rule defined in that entity. 




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10950) Having ability to make Configurable options date controlled

2019-04-24 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10950:
---

 Summary: Having ability to make Configurable options date 
controlled
 Key: OFBIZ-10950
 URL: https://issues.apache.org/jira/browse/OFBIZ-10950
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: Trunk
Reporter: Pritam Kute


Have the ability to make the Configurable Option Date Controlled while setting 
up the Configurable Good

We can add fromDate (not nullable) and thruDate fields to ProductConfigOption 
entity to achieve that. So while building ProductConfigWrapper object we can 
filter all those options which are expired. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10743) Error message is populating while clicking on product barcode

2019-03-26 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16801606#comment-16801606
 ] 

Pritam Kute commented on OFBIZ-10743:
-

Nice catch [~pawan.verma]

IMO, we should go for using code 128 instead of code 39 as it supports 
sufficient character set. Code128 is already supported by barcode4j. Many 
barcode scanners also support the same.

An example implementation can be found 
[http://barcode4j.sourceforge.net/2.1/symbol-code128.html|here]

We just need to update code39 to code128 in the file ProductBarCode.fo.ftl as 
follows:

{code:java}

  0.75in
  .375mm

{code}

Please let me know if I am missing something. I will upload the patch soon!

> Error message is populating while clicking on product barcode
> -
>
> Key: OFBIZ-10743
> URL: https://issues.apache.org/jira/browse/OFBIZ-10743
> Project: OFBiz
>  Issue Type: Bug
>Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12
>Reporter: Ashish Sharma
>Assignee: Pawan Verma
>Priority: Major
> Attachments: Screen Shot 2018-12-22 at 4.01.34 PM.png
>
>
> *Step to reproduce*
> Login with valid username and password.
> Navigate to Catalog->Product.
> Search for product (Please enter ‘a’ alphabet)
> Click on barcode
>  
> *Expected result:* Product barcode details should be displayed.
> *Actual result:*  Error message is populating while clicking on product 
> barcode.
>  
> Note:- Issue exist for some product (Forklift - Propane, Forklift - Battery, 
> Company Vehicle, Heating/Cooling Unit, Demo Product for Costing, Demo 
> Material A for Costing and Demo Material B for Costing) 
> Screen-print attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2019-03-11 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789550#comment-16789550
 ] 

Pritam Kute commented on OFBIZ-10457:
-

Updated the patch with following improvements:
1) Added optional "configId" as an input parameter to 
"sendTelecomMessageInterface".
2) Added optional "telecomGatewayConfigId" as an input parameter to 
"sendTelecomMessage" service.
3) Added "defaultFromTelecomAddress" property to general.properties to feed it 
to the CommunicationEvent. This will help in identifying the CommunicationEvent 
for Telecom transactions.
4) Instead of "fromString", "telecomMsgTypeEnumId" is now pushed to "subject" 
field in CommunicationEvent to make it more readable.
5) Added "default-value" to the "telecomMethodTypeId" attribute as "SMS".
6) Handled the case if ProductStoreTelecomSetting is not found for the given 
inputs.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, OFBIZ-10457.patch, 
> mobile-screenshot.jpeg, msg91.zip
>
>
> In reference to the [proposal|https://markmail.org/message/pna6ce3mkssbhg36] 
> sent on the developer list, this ticket will be used for tracking the work 
> progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2019-03-11 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10457:

Attachment: OFBIZ-10457.patch

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, OFBIZ-10457.patch, 
> mobile-screenshot.jpeg, msg91.zip
>
>
> In reference to the [proposal|https://markmail.org/message/pna6ce3mkssbhg36] 
> sent on the developer list, this ticket will be used for tracking the work 
> progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-30 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704660#comment-16704660
 ] 

Pritam Kute commented on OFBIZ-10457:
-

I have updated the documentation as per the new design. I have also updated the 
steps to set up the SMS gateway integration on the local development machine. 
The link of the document is mentioned in the ticket description.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, mobile-screenshot.jpeg, msg91.zip
>
>
> In reference to the [proposal|https://markmail.org/message/pna6ce3mkssbhg36] 
> sent on the developer list, this ticket will be used for tracking the work 
> progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Comment Edited] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698204#comment-16698204
 ] 

Pritam Kute edited comment on OFBIZ-10457 at 11/25/18 3:34 PM:
---

Thanks [~mbrohl]. You got it right. The patch contains the generic changes 
which can be pushed to the codebase. The plugin contains all the specific code 
need to write to push messages to the gateway server.

Thanks [~pfm.smits] for your review. Msg91 API can send the SMS all over the 
world. I haven't tested it but [API 
documentation|https://help.msg91.com/article/76-how-to-send-sms-worldwide] 
claims that. I can push some more plugins to show how this generic code can 
work with popular SMS gateways like [Textlocal|https://www.textlocal.in/] and 
[Twilio|https://www.twilio.com/].

I have used the implementation flow similar to payment gateway integration in 
OFBiz. The "Msg91GatewayConfig" entity is similar to "PaymentGatewayPayPal" 
entity.


was (Author: pritam.kute):
Thanks [~mbrohl]. You got it right. The patch contains the generic changes 
which can be pushed to the codebase. The plugin contains all the specific code 
need to write to push messages to the gateway server.

Thanks [~pfm.smits] for your review. Msg91 API can send the SMS all over the 
world I haven't tested it but [API 
documentation|https://help.msg91.com/article/76-how-to-send-sms-worldwide] 
claims that. I can push some more plugins to show how this generic code can 
work with popular SMS gateways like [Textlocal|https://www.textlocal.in/] and 
[Twilio|https://www.twilio.com/].

I have used the implementation flow similar to payment gateway integration in 
OFBiz. The "Msg91GatewayConfig" entity is similar to "PaymentGatewayPayPal" 
entity.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10457:

Attachment: mobile-screenshot.jpeg

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, mobile-screenshot.jpeg, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-25 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698204#comment-16698204
 ] 

Pritam Kute commented on OFBIZ-10457:
-

Thanks [~mbrohl]. You got it right. The patch contains the generic changes 
which can be pushed to the codebase. The plugin contains all the specific code 
need to write to push messages to the gateway server.

Thanks [~pfm.smits] for your review. Msg91 API can send the SMS all over the 
world I haven't tested it but [API 
documentation|https://help.msg91.com/article/76-how-to-send-sms-worldwide] 
claims that. I can push some more plugins to show how this generic code can 
work with popular SMS gateways like [Textlocal|https://www.textlocal.in/] and 
[Twilio|https://www.twilio.com/].

I have used the implementation flow similar to payment gateway integration in 
OFBiz. The "Msg91GatewayConfig" entity is similar to "PaymentGatewayPayPal" 
entity.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Rishi Solanki
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-24 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16697726#comment-16697726
 ] 

Pritam Kute commented on OFBIZ-10457:
-

I have attached the first pass of the SMS Gateway Integration. I have tested 
the integration with [Msg91 SMS 
Gateway|https://docs.msg91.com/collection/msg91-api-integration/5/send-sms/T26A6X72].

The patch contains the generic code/data. All custom code/data corresponding to 
Msg91 gateway is present in the attached plugin (msg91.zip). 

Please have a look and let me know your feedback/suggestions/improvements.

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-24 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10457:

Attachment: msg91.zip

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-11-24 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10457:

Attachment: OFBIZ-10457.patch

> Short Messaging Service(SMS) Gateway Integration
> 
>
> Key: OFBIZ-10457
> URL: https://issues.apache.org/jira/browse/OFBIZ-10457
> Project: OFBiz
>  Issue Type: New Feature
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10457.patch, msg91.zip
>
>
> In reference to the proposal sent on the developer list, this ticket will be 
> used for tracking the work progress of the SMS gateway integration.
> I have added design proposal for the SMS gateway integration to the wiki and 
> can be accessed from here.
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10325) EntityOne.java doesn't throw proper exception if field is not available in entity

2018-09-23 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10325:

Attachment: PartyProfile.png

> EntityOne.java doesn't throw proper exception if field is not available in 
> entity
> -
>
> Key: OFBIZ-10325
> URL: https://issues.apache.org/jira/browse/OFBIZ-10325
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Priority: Major
> Attachments: PartyProfile.png
>
>
> Using entity-one tag in xml services, if field is not a part of entity, 
> proper exception message should be thrown with returned error service 
> response.
>  Suppose:
> 
>      
>      
>     
>  
> partyId is not part of ProductFacility entity, if such code is used inside 
> any xml service, than proper exception should be thrown from EntityOne.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10325) EntityOne.java doesn't throw proper exception if field is not available in entity

2018-09-23 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625114#comment-16625114
 ] 

Pritam Kute commented on OFBIZ-10325:
-

Hello Suraj,

I have verified this issue and I think this improvement has been already done 
in the codebase. I have checked it at "Attributes" screen on party profile. 
Please check the following code snippet:

{code:xml}

  

















  

{code}

I have got a proper exception on the console like following:

{code:java}
2018-09-22 17:51:24,331 |jsse-nio-8443-exec-1 |ControlServlet
|E| Error in request handler: 
java.lang.IllegalArgumentException: [GenericEntity.set] "partyIdTo" is not a 
field of Party, must be one of: partyId, partyTypeId, externalId, 
preferredCurrencyUomId, description, statusId, createdDate, createdByUserLogin, 
lastModifiedDate, lastModifiedByUserLogin, dataSourceId, isUnread, 
lastUpdatedStamp, lastUpdatedTxStamp, createdStamp, createdTxStamp
at org.apache.ofbiz.entity.GenericEntity.set(GenericEntity.java:463) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.GenericEntity.setFields(GenericEntity.java:1057) 
~[ofbiz.jar:?]
at org.apache.ofbiz.entity.GenericEntity.init(GenericEntity.java:199) 
~[ofbiz.jar:?]
at org.apache.ofbiz.entity.GenericPK.create(GenericPK.java:45) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.GenericDelegator.makePK(GenericDelegator.java:695) 
~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.finder.PrimaryKeyFinder.runFind(PrimaryKeyFinder.java:145)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.finder.PrimaryKeyFinder.runFind(PrimaryKeyFinder.java:90)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.widget.model.AbstractModelAction$EntityOne.runAction(AbstractModelAction.java:278)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.widget.model.AbstractModelAction.runSubActions(AbstractModelAction.java:143)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.widget.model.ModelScreenWidget$Section.renderWidgetString(ModelScreenWidget.java:277)
 ~[ofbiz.jar:?]
{code}

Also, see the error displayed on the party profile screen. I have attached the 
screenshot of the same. Please let me if I am missing something or you expect 
it in some other way,

> EntityOne.java doesn't throw proper exception if field is not available in 
> entity
> -
>
> Key: OFBIZ-10325
> URL: https://issues.apache.org/jira/browse/OFBIZ-10325
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Suraj Khurana
>Priority: Major
> Attachments: PartyProfile.png
>
>
> Using entity-one tag in xml services, if field is not a part of entity, 
> proper exception message should be thrown with returned error service 
> response.
>  Suppose:
> 
>      
>      
>     
>  
> partyId is not part of ProductFacility entity, if such code is used inside 
> any xml service, than proper exception should be thrown from EntityOne.java
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10373) UI/UX issues found with Find Agreements screen

2018-09-22 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10373:

Attachment: OFBIZ-10373.patch

>  UI/UX issues found with Find Agreements screen
> ---
>
> Key: OFBIZ-10373
> URL: https://issues.apache.org/jira/browse/OFBIZ-10373
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/FindAgreement?fromDate_fld1_op=opLessThan=thruDate=Y_ic=Y_fld0_op=equals_op=contains
>Reporter: Aayush jain
>Priority: Trivial
> Attachments: OFBIZ-10373.patch, UI UX Issues.png
>
>
> Following UI/UX issues found with Find Agreements screen:
> 1. Create a new agreement and navigate to find agreements page and check for 
> from date on the newly created agreement. It is displayed in Red color, there 
> should be a color consistency on the screen. ( When we edit a date to 
> back-date is works fine)
> 2.  Behavior of Cancel button is not proper ( On find agreements page, Click 
> on Cancel button to cancel any of the active agreement, it will set a through 
> date. But Cancel button is still been displayed and the user is allowed to 
> cancel any kind of agreement multiple time with a success message). The 
> application should not be allowed to cancel already canceled agreement. I 
> think no process happens on click on cancel button again and again, but a 
> success message is displayed on the screen. Cancel button can be disabled for 
> already canceled agreements.
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/webtools
> 2. Navigate to Agreements
> 3. Check for Issues
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10373) UI/UX issues found with Find Agreements screen

2018-09-22 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-10373:
---

Assignee: Pritam Kute

>  UI/UX issues found with Find Agreements screen
> ---
>
> Key: OFBIZ-10373
> URL: https://issues.apache.org/jira/browse/OFBIZ-10373
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/FindAgreement?fromDate_fld1_op=opLessThan=thruDate=Y_ic=Y_fld0_op=equals_op=contains
>Reporter: Aayush jain
>Assignee: Pritam Kute
>Priority: Trivial
> Attachments: OFBIZ-10373.patch, UI UX Issues.png
>
>
> Following UI/UX issues found with Find Agreements screen:
> 1. Create a new agreement and navigate to find agreements page and check for 
> from date on the newly created agreement. It is displayed in Red color, there 
> should be a color consistency on the screen. ( When we edit a date to 
> back-date is works fine)
> 2.  Behavior of Cancel button is not proper ( On find agreements page, Click 
> on Cancel button to cancel any of the active agreement, it will set a through 
> date. But Cancel button is still been displayed and the user is allowed to 
> cancel any kind of agreement multiple time with a success message). The 
> application should not be allowed to cancel already canceled agreement. I 
> think no process happens on click on cancel button again and again, but a 
> success message is displayed on the screen. Cancel button can be disabled for 
> already canceled agreements.
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/webtools
> 2. Navigate to Agreements
> 3. Check for Issues
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10373) UI/UX issues found with Find Agreements screen

2018-09-22 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624597#comment-16624597
 ] 

Pritam Kute commented on OFBIZ-10373:
-

Hello Ayush,

I have checked for the issues which you have reported on the trunk. I found 
that issue reported around color coding is already fixed. So we can discard 
point#1

For the cancel button, its a good improvement according to me. I have attached 
the patch for the fix.

>  UI/UX issues found with Find Agreements screen
> ---
>
> Key: OFBIZ-10373
> URL: https://issues.apache.org/jira/browse/OFBIZ-10373
> Project: OFBiz
>  Issue Type: Bug
> Environment: 
> https://demo-trunk.ofbiz.apache.org/ap/control/FindAgreement?fromDate_fld1_op=opLessThan=thruDate=Y_ic=Y_fld0_op=equals_op=contains
>Reporter: Aayush jain
>Priority: Trivial
> Attachments: UI UX Issues.png
>
>
> Following UI/UX issues found with Find Agreements screen:
> 1. Create a new agreement and navigate to find agreements page and check for 
> from date on the newly created agreement. It is displayed in Red color, there 
> should be a color consistency on the screen. ( When we edit a date to 
> back-date is works fine)
> 2.  Behavior of Cancel button is not proper ( On find agreements page, Click 
> on Cancel button to cancel any of the active agreement, it will set a through 
> date. But Cancel button is still been displayed and the user is allowed to 
> cancel any kind of agreement multiple time with a success message). The 
> application should not be allowed to cancel already canceled agreement. I 
> think no process happens on click on cancel button again and again, but a 
> success message is displayed on the screen. Cancel button can be disabled for 
> already canceled agreements.
> Steps:
> 1. Open URL https://demo-trunk.ofbiz.apache.org/webtools
> 2. Navigate to Agreements
> 3. Check for Issues
> Thanks!



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10466) UI issue on blog screens on storefront

2018-07-06 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10466:

Attachment: OFBIZ-10466.patch

> UI issue on blog screens on storefront
> --
>
> Key: OFBIZ-10466
> URL: https://issues.apache.org/jira/browse/OFBIZ-10466
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
> Attachments: OFBIZ-10466.patch
>
>
>  
> This issue is because of the CSS rule written for  in [this 
> commit|https://ofbiz.markmail.org/message/sgyeuxqvjviijb2k?q=implemented+blog+rss+feed+list:org%2Eapache%2Eofbiz%2Ecommits=1].
> {code:java}
> .bloghr {
> border: 0.1em solid #99;
> color: white;
> background: #1C334D;
> padding: 4px;
> height: 13px;
> }
> {code}
> Increasing height property in the above rule will fix the UI of the blog 
> header on all blog related screens.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10466) UI issue on blog screens on storefront

2018-07-06 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10466:

Attachment: (was: OFBIZ-10466.patch)

> UI issue on blog screens on storefront
> --
>
> Key: OFBIZ-10466
> URL: https://issues.apache.org/jira/browse/OFBIZ-10466
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
>
>  
> This issue is because of the CSS rule written for  in [this 
> commit|https://ofbiz.markmail.org/message/sgyeuxqvjviijb2k?q=implemented+blog+rss+feed+list:org%2Eapache%2Eofbiz%2Ecommits=1].
> {code:java}
> .bloghr {
> border: 0.1em solid #99;
> color: white;
> background: #1C334D;
> padding: 4px;
> height: 13px;
> }
> {code}
> Increasing height property in the above rule will fix the UI of the blog 
> header on all blog related screens.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10466) UI issue on blog screens on storefront

2018-07-06 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10466:

Attachment: OFBIZ-10466.patch

> UI issue on blog screens on storefront
> --
>
> Key: OFBIZ-10466
> URL: https://issues.apache.org/jira/browse/OFBIZ-10466
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
>
>  
> This issue is because of the CSS rule written for  in [this 
> commit|https://ofbiz.markmail.org/message/sgyeuxqvjviijb2k?q=implemented+blog+rss+feed+list:org%2Eapache%2Eofbiz%2Ecommits=1].
> {code:java}
> .bloghr {
> border: 0.1em solid #99;
> color: white;
> background: #1C334D;
> padding: 4px;
> height: 13px;
> }
> {code}
> Increasing height property in the above rule will fix the UI of the blog 
> header on all blog related screens.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10466) UI issue on blog screens on storefront

2018-07-06 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10466:
---

 Summary: UI issue on blog screens on storefront
 Key: OFBIZ-10466
 URL: https://issues.apache.org/jira/browse/OFBIZ-10466
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: Pritam Kute
 Fix For: Upcoming Branch, Trunk


 

This issue is because of the CSS rule written for  in [this 
commit|https://ofbiz.markmail.org/message/sgyeuxqvjviijb2k?q=implemented+blog+rss+feed+list:org%2Eapache%2Eofbiz%2Ecommits=1].
{code:java}
.bloghr {
border: 0.1em solid #99;
color: white;
background: #1C334D;
padding: 4px;
height: 13px;
}
{code}
Increasing height property in the above rule will fix the UI of the blog header 
on all blog related screens.

 

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10462) UI for all promotions listing disturbed

2018-07-05 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-10462:
---

Assignee: Deepak Dixit  (was: Pritam Kute)

> UI for all promotions listing disturbed
> ---
>
> Key: OFBIZ-10462
> URL: https://issues.apache.org/jira/browse/OFBIZ-10462
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
> Attachments: OFBIZ-10462.patch
>
>
> Steps to regenerate the issue are as follows:
> 1) Navigate to storefront
> 2) Click on "[View All 
> Promotions|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/showAllPromotions];
>  button.
> Expected:
> All promotions should be in a listed format.
> Actual:
> All promotions are listed inline.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10462) UI for all promotions listing disturbed

2018-07-05 Thread Pritam Kute (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16533528#comment-16533528
 ] 

Pritam Kute commented on OFBIZ-10462:
-

This issue was because of not following best practices while overriding CSS 
rule in custom.css. Removed that CSS rule from the custom.css and fixed the UI 
on the main screen of the e-commerce storefront. 

> UI for all promotions listing disturbed
> ---
>
> Key: OFBIZ-10462
> URL: https://issues.apache.org/jira/browse/OFBIZ-10462
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
> Attachments: OFBIZ-10462.patch
>
>
> Steps to regenerate the issue are as follows:
> 1) Navigate to storefront
> 2) Click on "[View All 
> Promotions|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/showAllPromotions];
>  button.
> Expected:
> All promotions should be in a listed format.
> Actual:
> All promotions are listed inline.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10462) UI for all promotions listing disturbed

2018-07-05 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10462:

Attachment: OFBIZ-10462.patch

> UI for all promotions listing disturbed
> ---
>
> Key: OFBIZ-10462
> URL: https://issues.apache.org/jira/browse/OFBIZ-10462
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
> Attachments: OFBIZ-10462.patch
>
>
> Steps to regenerate the issue are as follows:
> 1) Navigate to storefront
> 2) Click on "[View All 
> Promotions|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/showAllPromotions];
>  button.
> Expected:
> All promotions should be in a listed format.
> Actual:
> All promotions are listed inline.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10462) UI for all promotions listing disturbed

2018-07-05 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10462:

Description: 
Steps to regenerate the issue are as follows:

1) Navigate to storefront

2) Click on "[View All 
Promotions|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/showAllPromotions];
 button.

Expected:

All promotions should be in a listed format.

Actual:

All promotions are listed inline.

  was:
Steps to regenerate the issue are as follows:

1) Navigate to storefront

2) Click on "View All Promotions" button.

Expected:

All promotions should be in a listed format.

Actual:

All promotions are listed inline.


> UI for all promotions listing disturbed
> ---
>
> Key: OFBIZ-10462
> URL: https://issues.apache.org/jira/browse/OFBIZ-10462
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk, Upcoming Branch
>
>
> Steps to regenerate the issue are as follows:
> 1) Navigate to storefront
> 2) Click on "[View All 
> Promotions|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/showAllPromotions];
>  button.
> Expected:
> All promotions should be in a listed format.
> Actual:
> All promotions are listed inline.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10462) UI for all promotions listing disturbed

2018-07-05 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10462:
---

 Summary: UI for all promotions listing disturbed
 Key: OFBIZ-10462
 URL: https://issues.apache.org/jira/browse/OFBIZ-10462
 Project: OFBiz
  Issue Type: Improvement
  Components: ecommerce
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: Pritam Kute
 Fix For: Upcoming Branch, Trunk


Steps to regenerate the issue are as follows:

1) Navigate to storefront

2) Click on "View All Promotions" button.

Expected:

All promotions should be in a listed format.

Actual:

All promotions are listed inline.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10459) Freemarker error on shopping list page on eCommerce storefront

2018-07-05 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-10459:
---

Assignee: Deepak Dixit

> Freemarker error on shopping list page on eCommerce storefront
> --
>
> Key: OFBIZ-10459
> URL: https://issues.apache.org/jira/browse/OFBIZ-10459
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Deepak Dixit
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10459.patch, Shopping List _ OFBiz E-Commerce 
> Store.png
>
>
> Regeneration steps are as follows:
> 1) Go to the [e-commerce 
> storefront|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/main] 
> and login using the demo credentials.
> 2) Click on "Shopping Lists" menu.
> 3) If there is no previously available shopping list present then create new 
> using the option available.
>  
> Actual:
> There is freemarker error on the page at List Item section.
> Expected:
> The page should render properly without any freemaker error.
>  
> For more details, see the attached screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10459) Freemarker error on shopping list page on eCommerce storefront

2018-07-05 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-10459:
---

Assignee: (was: Pritam Kute)

> Freemarker error on shopping list page on eCommerce storefront
> --
>
> Key: OFBIZ-10459
> URL: https://issues.apache.org/jira/browse/OFBIZ-10459
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-10459.patch, Shopping List _ OFBiz E-Commerce 
> Store.png
>
>
> Regeneration steps are as follows:
> 1) Go to the [e-commerce 
> storefront|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/main] 
> and login using the demo credentials.
> 2) Click on "Shopping Lists" menu.
> 3) If there is no previously available shopping list present then create new 
> using the option available.
>  
> Actual:
> There is freemarker error on the page at List Item section.
> Expected:
> The page should render properly without any freemaker error.
>  
> For more details, see the attached screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10459) Freemarker error on shopping list page on eCommerce storefront

2018-07-05 Thread Pritam Kute (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-10459:

Attachment: Shopping List _ OFBiz E-Commerce Store.png

> Freemarker error on shopping list page on eCommerce storefront
> --
>
> Key: OFBIZ-10459
> URL: https://issues.apache.org/jira/browse/OFBIZ-10459
> Project: OFBiz
>  Issue Type: Bug
>  Components: ecommerce
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk
>
> Attachments: Shopping List _ OFBiz E-Commerce Store.png
>
>
> Regeneration steps are as follows:
> 1) Go to the [e-commerce 
> storefront|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/main] 
> and login using the demo credentials.
> 2) Click on "Shopping Lists" menu.
> 3) If there is no previously available shopping list present then create new 
> using the option available.
>  
> Actual:
> There is freemarker error on the page at List Item section.
> Expected:
> The page should render properly without any freemaker error.
>  
> For more details, see the attached screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10459) Freemarker error on shopping list page on eCommerce storefront

2018-07-05 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10459:
---

 Summary: Freemarker error on shopping list page on eCommerce 
storefront
 Key: OFBIZ-10459
 URL: https://issues.apache.org/jira/browse/OFBIZ-10459
 Project: OFBiz
  Issue Type: Bug
  Components: ecommerce
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: Pritam Kute
 Fix For: Trunk


Regeneration steps are as follows:

1) Go to the [e-commerce 
storefront|https://demo-trunk-ofbiz.apache.org:8443/ecommerce/control/main] and 
login using the demo credentials.

2) Click on "Shopping Lists" menu.

3) If there is no previously available shopping list present then create new 
using the option available.

 

Actual:

There is freemarker error on the page at List Item section.

Expected:

The page should render properly without any freemaker error.

 

For more details, see the attached screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10457) Short Messaging Service(SMS) Gateway Integration

2018-07-02 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10457:
---

 Summary: Short Messaging Service(SMS) Gateway Integration
 Key: OFBIZ-10457
 URL: https://issues.apache.org/jira/browse/OFBIZ-10457
 Project: OFBiz
  Issue Type: New Feature
Reporter: Pritam Kute
Assignee: Pritam Kute
 Fix For: Upcoming Branch


In reference to the proposal sent on the developer list, this ticket will be 
used for tracking the work progress of the SMS gateway integration.

I have added design proposal for the SMS gateway integration to the wiki and 
can be accessed from here.

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=87296614



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10013) Screen Rendering issue on Payment Overview screen

2017-11-25 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-10013:
---

 Summary: Screen Rendering issue on Payment Overview screen
 Key: OFBIZ-10013
 URL: https://issues.apache.org/jira/browse/OFBIZ-10013
 Project: OFBiz
  Issue Type: Bug
  Components: accounting
Affects Versions: Release Branch 16.11, Trunk
Reporter: Pritam Kute


Steps to regenerate are - 
1. Go to https://demo-trunk.ofbiz.apache.org/accounting/control/main
2. Click on "show all payment" payments.
3. Select any payment of type "Customer Payment" and click on it to go to 
overview screen
4. On overview screen click on the button "Acctg Trans Entries PDF"

Result:
Actual: The broken screen

Should be the PDF with account transaction entries.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-8831) Typo in error message when OFBiz is unable to connect to database.

2016-11-04 Thread Pritam Kute (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute reassigned OFBIZ-8831:
--

Assignee: Pritam Kute

> Typo in error message when OFBiz is unable to connect to database.
> --
>
> Key: OFBIZ-8831
> URL: https://issues.apache.org/jira/browse/OFBIZ-8831
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Humera Khan
>Assignee: Pritam Kute
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-8831.patch
>
>
> Steps to regenerate : 
> 1. Go to entityengine.xml file of framework component.
> 2. Change the name of the database in entityengine.xml to random which does 
> not exists in your database.
> 3. Restart the OFBiz and check the error message on console.
> 4.It shows "Unable to esablish connection to database".
> Expected : It should show "Unable to establish connection to database".



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-8822) Search operation on 'AllExamplesWithDesiredCustomerFeaturesReport' entity causing exception

2016-11-03 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-8822:
--

 Summary: Search operation on 
'AllExamplesWithDesiredCustomerFeaturesReport' entity causing exception
 Key: OFBIZ-8822
 URL: https://issues.apache.org/jira/browse/OFBIZ-8822
 Project: OFBiz
  Issue Type: Bug
  Components: framework/webtools
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: Pritam Kute
 Fix For: Trunk


Steps to regenerate:
1. Go to Entity Data Maintenance in webtools
2. Search entity 'AllExamplesWithDesiredCustomerFeaturesReport'. Click and go 
to the overview page.
3. Click on the Search button.

We are getting following exception:
2016-11-03 21:29:22,584 |ttp-nio-8443-exec-10 |ScriptUtil
|W| Error running script at location 
[component://webtools/groovyScripts/entity/FindGeneric.groovy]: 
java.lang.IllegalArgumentException: 
[AllExamplesWithDesiredCustomerFeaturesReport]: Error in Entity Find: could not 
find field [featureSourceEnumId]
java.lang.IllegalArgumentException: 
[AllExamplesWithDesiredCustomerFeaturesReport]: Error in Entity Find: could not 
find field [featureSourceEnumId]
at 
org.apache.ofbiz.entity.model.ModelViewEntity$ViewConditionExpr.createCondition(ModelViewEntity.java:1395)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.model.ModelViewEntity$ViewEntityCondition.getWhereCondition(ModelViewEntity.java:1307)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.model.ModelViewEntity.populateViewEntityConditionInformation(ModelViewEntity.java:313)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.datasource.GenericDAO.selectListIteratorByCondition(GenericDAO.java:724)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.datasource.GenericHelperDAO.findListIteratorByCondition(GenericHelperDAO.java:140)
 ~[ofbiz.jar:?]
at 
org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1551) 
~[ofbiz.jar:?]
at org.apache.ofbiz.entity.Delegator$find$2.call(Unknown Source) ~[?:?]
at 
org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48)
 ~[groovy-all-2.4.5.jar:2.4.5]
at 
org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113)
 ~[groovy-all-2.4.5.jar:2.4.5]
at FindGeneric.run(FindGeneric.groovy:183) ~[?:?]

Expected: Data for view entity should be searched and displayed.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7977) View Entity is not marked on new entity listing UI in Webtools

2016-08-27 Thread Pritam Kute (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-7977:
---
Attachment: OFBIZ-7977.patch

> View Entity is not marked on new entity listing UI in Webtools
> --
>
> Key: OFBIZ-7977
> URL: https://issues.apache.org/jira/browse/OFBIZ-7977
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
> Attachments: OFBIZ-7977.patch, WebtoolsEntityList-New.png, 
> WebtoolsEntityList-Old.png
>
>
> View Entity is not marked on new entity listing UI in Webtools.
> See attached images for more details.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (OFBIZ-7977) View Entity is not marked on new entity listing UI in Webtools

2016-08-27 Thread Pritam Kute (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7977?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pritam Kute updated OFBIZ-7977:
---
Attachment: WebtoolsEntityList-Old.png
WebtoolsEntityList-New.png

> View Entity is not marked on new entity listing UI in Webtools
> --
>
> Key: OFBIZ-7977
> URL: https://issues.apache.org/jira/browse/OFBIZ-7977
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Pritam Kute
>Assignee: Pritam Kute
> Attachments: WebtoolsEntityList-New.png, WebtoolsEntityList-Old.png
>
>
> View Entity is not marked on new entity listing UI in Webtools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (OFBIZ-7977) View Entity is not marked on new entity listing UI in Webtools

2016-08-27 Thread Pritam Kute (JIRA)
Pritam Kute created OFBIZ-7977:
--

 Summary: View Entity is not marked on new entity listing UI in 
Webtools
 Key: OFBIZ-7977
 URL: https://issues.apache.org/jira/browse/OFBIZ-7977
 Project: OFBiz
  Issue Type: Improvement
  Components: framework/webtools
Affects Versions: Trunk
Reporter: Pritam Kute
Assignee: Pritam Kute


View Entity is not marked on new entity listing UI in Webtools.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)