[jira] [Commented] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748166#comment-17748166 ] Sebastian Berg commented on OFBIZ-12828: Hi, I provided a new PR to account for the moved groovy Files so the PR should work without conflicts now. Thanks Pascal Zoschke for providing the initial Patch. > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Improvement >Reporter: Pascal Zoschke >Assignee: Pascal Zoschke >Priority: Minor > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (OFBIZ-12828) Persist OrderItemAttributes of ShoppingCartItem in new entity ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList)
[ https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-12828: -- Assignee: Sebastian Berg > Persist OrderItemAttributes of ShoppingCartItem in new entity > ShoppingListItemAttributes along with persisted ShoppingCart (autoSaveList) > - > > Key: OFBIZ-12828 > URL: https://issues.apache.org/jira/browse/OFBIZ-12828 > Project: OFBiz > Issue Type: Improvement >Reporter: Pascal Zoschke >Assignee: Sebastian Berg >Priority: Minor > > Currently, the information about the attributes of the order item is not > saved and therefore cannot be retrieved later in the shopping cart > (autoSaveList). -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (OFBIZ-12630) Configure usability of after-login Events in BasigLogin
Sebastian Berg created OFBIZ-12630: -- Summary: Configure usability of after-login Events in BasigLogin Key: OFBIZ-12630 URL: https://issues.apache.org/jira/browse/OFBIZ-12630 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Sebastian Berg Assignee: Sebastian Berg At the moment after-login Events are only run in the 'doMainLogin' method. During the login at a new webapp with an externalLoginKey only 'doBasicLogin' is performed. Therefore while logging into an new webapp with an externalLoginKey now after-login events are run. I think there should be an option to run after-login Events during the BasicLogin instead of only during MainLogin. The MainLogin runs 'doBasicLogin' so after-login Events will then be run there. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (OFBIZ-12016) DiskFileItem as request attribute creates problems
[ https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17403605#comment-17403605 ] Sebastian Berg commented on OFBIZ-12016: Hi Jacques, unfortunately we have to reopen this issue. I ran into this error again. I have a file upload in one request, which results in a request-redirect-noparam on success. I noticed, that in SafeObjectInputStream.java we throw a ClassCastException which isn't catched anywhere. And there was a special code line for DiskFileItems where a ClassNotFound Exception was thrown, which was removed again. While this made it impossible to retrieve error messages from previous requests at least we don't have an Exception shown on the surface. > DiskFileItem as request attribute creates problems > -- > > Key: OFBIZ-12016 > URL: https://issues.apache.org/jira/browse/OFBIZ-12016 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Hi, > while working on a custom project based on the 18.12.01 version, I noticed a > problem with the request handling during a request-redirect-noparam if a > DiskFileItem was involved. > So the situation for me is as follows: during the first request a file is > uploaded. I choose a wrong format on purpose, which results in an error > respond for that event. Nevertheless the DiskFileItem is set as request > attribute together with the error message. > The request is finished and based on the controller configurations redirected > to a second request. > While handling the second request the previous request's attributes get > restored (RequestHandler.java line 733ff). This goes down into > SafeObjectInfo.resolveClass() where an Incompatible class exception is > thrown. I compared my custom project with the current development status and > worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in > OFBIZ-10837. > While this fixes the issue with the incompatible class exception it also > makes it impossible to retrieve any attributes from the first request. > Therefore my error message cannot be shown. > Is there a way to fix it or is it otherwise necessary to always set > "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-12016) DiskFileItem as request attribute creates problems
[ https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reopened OFBIZ-12016: > DiskFileItem as request attribute creates problems > -- > > Key: OFBIZ-12016 > URL: https://issues.apache.org/jira/browse/OFBIZ-12016 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > > Hi, > while working on a custom project based on the 18.12.01 version, I noticed a > problem with the request handling during a request-redirect-noparam if a > DiskFileItem was involved. > So the situation for me is as follows: during the first request a file is > uploaded. I choose a wrong format on purpose, which results in an error > respond for that event. Nevertheless the DiskFileItem is set as request > attribute together with the error message. > The request is finished and based on the controller configurations redirected > to a second request. > While handling the second request the previous request's attributes get > restored (RequestHandler.java line 733ff). This goes down into > SafeObjectInfo.resolveClass() where an Incompatible class exception is > thrown. I compared my custom project with the current development status and > worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in > OFBIZ-10837. > While this fixes the issue with the incompatible class exception it also > makes it impossible to retrieve any attributes from the first request. > Therefore my error message cannot be shown. > Is there a way to fix it or is it otherwise necessary to always set > "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12273) IndexOutOfBoundsException on Entity Import
[ https://issues.apache.org/jira/browse/OFBIZ-12273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17374556#comment-17374556 ] Sebastian Berg commented on OFBIZ-12273: Hi, my problem seems to be fixed on trunk. But I am not sure about the solution. For example simply allowing every URL on localhost might prevent you from finding mistakes and might lead to problems on production instances of OfBiz and/or errors which can't be mimiced on your local machine. There is also no customization this way. Isn't it possible to have a solution where you can adjust the pattern without making changes in the OfBiz code base? > IndexOutOfBoundsException on Entity Import > -- > > Key: OFBIZ-12273 > URL: https://issues.apache.org/jira/browse/OFBIZ-12273 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Jacques Le Roux >Priority: Major > > I get an IndexOutOfBoundsException when using the EntityImport. > The problem occurs while having a resemblance of an url in the data. > For example ' > screenPath="component://project/widget/project/ContentScreens.xml#main-page-template"' > is interpreted as url because of '://' but doesn't match a valid url > pattern. > The problem seems to be directly connected to Issue 12249. I think the used > pattern in UtilHttp.exctractUrl() should at least be configureable like the > customSafePolicy. [~jleroux] maybe you can have a look since you implemented > the changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12273) IndexOutOfBoundsException on Entity Import
Sebastian Berg created OFBIZ-12273: -- Summary: IndexOutOfBoundsException on Entity Import Key: OFBIZ-12273 URL: https://issues.apache.org/jira/browse/OFBIZ-12273 Project: OFBiz Issue Type: Bug Affects Versions: Trunk, 18.12.01, Release Branch 17.12 Reporter: Sebastian Berg I get an IndexOutOfBoundsException when using the EntityImport. The problem occurs while having a resemblance of an url in the data. For example ' screenPath="component://project/widget/project/ContentScreens.xml#main-page-template"' is interpreted as url because of '://' but doesn't match a valid url pattern. The problem seems to be directly connected to Issue 12249. I think the used pattern in UtilHttp.exctractUrl() should at least be configureable like the customSafePolicy. [~jleroux] maybe you can have a look since you implemented the changes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11855) Convert RoutingServices.xml mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373349#comment-17373349 ] Sebastian Berg commented on OFBIZ-11855: Hi, the filterByDate mechanic for ProductAssoc deviates in minilang, but not in your patch. Otherwise I noticed a typo and some of the explanatory comments were missing. I created a PullRequest with the adjustments. > Convert RoutingServices.xml mini-lang to groovy > --- > > Key: OFBIZ-11855 > URL: https://issues.apache.org/jira/browse/OFBIZ-11855 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Pätzold >Assignee: Yashwant Dhakad >Priority: Minor > Attachments: OFBIZ-11855.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11855) Convert RoutingServices.xml mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17373275#comment-17373275 ] Sebastian Berg commented on OFBIZ-11855: I'll have a look at the patch. > Convert RoutingServices.xml mini-lang to groovy > --- > > Key: OFBIZ-11855 > URL: https://issues.apache.org/jira/browse/OFBIZ-11855 > Project: OFBiz > Issue Type: Sub-task >Reporter: Wiebke Pätzold >Assignee: Yashwant Dhakad >Priority: Minor > Attachments: OFBIZ-11855.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
[ https://issues.apache.org/jira/browse/OFBIZ-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298096#comment-17298096 ] Sebastian Berg commented on OFBIZ-12193: [~jleroux] I created a new PR for the 18.12 branch where the log issues are fixed. The rendered form in trunk which was backportet is more advanced than the version used in 18.12 therefore the log issues. I worked in the necessary changes for fixing the ViewEntity Bug into the 18.12 form structure and now its working fine without errors in logs. There shouldn't be any problems applying these changes to the 17.12 version. > Cant search ViewEntity InventoryItemDetailForSum > > > Key: OFBIZ-12193 > URL: https://issues.apache.org/jira/browse/OFBIZ-12193 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Major > > Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) > -> search for entries -> an error message is shown. > A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
[ https://issues.apache.org/jira/browse/OFBIZ-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295823#comment-17295823 ] Sebastian Berg edited comment on OFBIZ-12193 at 3/5/21, 9:29 AM: - The error occurs not only for ViewEntity InventoryItemDetailForSum but for all ViewEntities, which have fields other than function fields without the specification group-by="true". The problem results from the SQL-Statement which is put together with all select Fields of the Entity. But for that part every field in the SELECT section either has to be a function Field or has to be part of the GROUP_BY section as well. That is not the case here. Previously (before the changes in OFBIZ-9217) when delegator.find() was called one parameter was fieldsToSelect which is relevant for ViewEntities. The list fieldsToSelect was filled with field names if the ModelEntity is a ViewEntity. fieldsToSelect combines the functionFields and the groupByFields and therefore a functional SQL-Statement is build. In the new FindGeneric.groovy where the 'peformFind' Service is used the field fieldsToSelect was lost during the refactoring. I tracked down the missing parts and implemented them. Also I had some difficulties spotting the missing information, because of the strange habit to put together a String in a groovy File, which gets rendered into an XML Document into a Form. I feel like there should be an easier and more readable way to achieve a dynamic form to search an list Entities. Maybe we can do some refactoring of this Part in the FindGeneric.groovy in the future. was (Author: sberg): The error occurs not only for ViewEntity InventoryItemDetailForSum but for all ViewEntities, which have fields other than function fields without the specification group-by="true". Previously (before the changes in OFBIZ-9217) when delegator.find() was called one parameter was fieldsToSelect which is relevant for ViewEntities. The list fieldsToSelect was filled with field names if the ModelEntity is a ViewEntity. fieldsToSelect combines the functionFields and the groupByFields and therefore a functional SQL-Statement is build. In the new FindGeneric.groovy where the 'peformFind' Service is used the field fieldsToSelect was lost during the refactoring. I tracked down the missing parts and implemented them. Also I had some difficulties spotting the missing information, because of the strange habit to put together a String in a groovy File, which gets rendered into an XML Document into a Form. I feel like there should be an easier and more readable way to achieve a dynamic form to search an list Entities. Maybe we can do some refactoring of this Part in the FindGeneric.groovy in the future. > Cant search ViewEntity InventoryItemDetailForSum > > > Key: OFBIZ-12193 > URL: https://issues.apache.org/jira/browse/OFBIZ-12193 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Major > > Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) > -> search for entries -> an error message is shown. > A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
[ https://issues.apache.org/jira/browse/OFBIZ-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295823#comment-17295823 ] Sebastian Berg edited comment on OFBIZ-12193 at 3/5/21, 9:27 AM: - The error occurs not only for ViewEntity InventoryItemDetailForSum but for all ViewEntities, which have fields other than function fields without the specification group-by="true". Previously (before the changes in OFBIZ-9217) when delegator.find() was called one parameter was fieldsToSelect which is relevant for ViewEntities. The list fieldsToSelect was filled with field names if the ModelEntity is a ViewEntity. fieldsToSelect combines the functionFields and the groupByFields and therefore a functional SQL-Statement is build. In the new FindGeneric.groovy where the 'peformFind' Service is used the field fieldsToSelect was lost during the refactoring. I tracked down the missing parts and implemented them. Also I had some difficulties spotting the missing information, because of the strange habit to put together a String in a groovy File, which gets rendered into an XML Document into a Form. I feel like there should be an easier and more readable way to achieve a dynamic form to search an list Entities. Maybe we can do some refactoring of this Part in the FindGeneric.groovy in the future. was (Author: sberg): Previously when delegator.find() was called one parameter was fieldsToSelect which is relevant for ViewEntities. In the new FindGeneric.groovy the performFind Service is missing this information. > Cant search ViewEntity InventoryItemDetailForSum > > > Key: OFBIZ-12193 > URL: https://issues.apache.org/jira/browse/OFBIZ-12193 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Major > > Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) > -> search for entries -> an error message is shown. > A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
[ https://issues.apache.org/jira/browse/OFBIZ-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17295823#comment-17295823 ] Sebastian Berg commented on OFBIZ-12193: Previously when delegator.find() was called one parameter was fieldsToSelect which is relevant for ViewEntities. In the new FindGeneric.groovy the performFind Service is missing this information. > Cant search ViewEntity InventoryItemDetailForSum > > > Key: OFBIZ-12193 > URL: https://issues.apache.org/jira/browse/OFBIZ-12193 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Major > > Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) > -> search for entries -> an error message is shown. > A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
[ https://issues.apache.org/jira/browse/OFBIZ-12193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-12193: --- Affects Version/s: Release Branch 17.12 > Cant search ViewEntity InventoryItemDetailForSum > > > Key: OFBIZ-12193 > URL: https://issues.apache.org/jira/browse/OFBIZ-12193 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Major > > Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) > -> search for entries -> an error message is shown. > A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12193) Cant search ViewEntity InventoryItemDetailForSum
Sebastian Berg created OFBIZ-12193: -- Summary: Cant search ViewEntity InventoryItemDetailForSum Key: OFBIZ-12193 URL: https://issues.apache.org/jira/browse/OFBIZ-12193 Project: OFBiz Issue Type: Bug Affects Versions: Trunk, Release Branch 18.12 Reporter: Sebastian Berg Assignee: Sebastian Berg Go to Entity Engine - > search entity InventoryItemDetailForSum (view entity) -> search for entries -> an error message is shown. A SQL exception occurred running the service executeFind -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12016) DiskFileItem as request attribute creates problems
[ https://issues.apache.org/jira/browse/OFBIZ-12016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293458#comment-17293458 ] Sebastian Berg commented on OFBIZ-12016: Hi Jacques, seems to be working now. I couldn't reproduce an error doing a request redirect. > DiskFileItem as request attribute creates problems > -- > > Key: OFBIZ-12016 > URL: https://issues.apache.org/jira/browse/OFBIZ-12016 > Project: OFBiz > Issue Type: Bug >Affects Versions: 18.12.01, Trunk >Reporter: Sebastian Berg >Priority: Major > > Hi, > while working on a custom project based on the 18.12.01 version, I noticed a > problem with the request handling during a request-redirect-noparam if a > DiskFileItem was involved. > So the situation for me is as follows: during the first request a file is > uploaded. I choose a wrong format on purpose, which results in an error > respond for that event. Nevertheless the DiskFileItem is set as request > attribute together with the error message. > The request is finished and based on the controller configurations redirected > to a second request. > While handling the second request the previous request's attributes get > restored (RequestHandler.java line 733ff). This goes down into > SafeObjectInfo.resolveClass() where an Incompatible class exception is > thrown. I compared my custom project with the current development status and > worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in > OFBIZ-10837. > While this fixes the issue with the incompatible class exception it also > makes it impossible to retrieve any attributes from the first request. > Therefore my error message cannot be shown. > Is there a way to fix it or is it otherwise necessary to always set > "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285133#comment-17285133 ] Sebastian Berg commented on OFBIZ-11684: This seems to be the same problem. The solution suggested in OFBIZ-11685 also fixes this issue. > Form to add an employee position doesn't function properly when invoked from > Humanres tree > -- > > Key: OFBIZ-11684 > URL: https://issues.apache.org/jira/browse/OFBIZ-11684 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Priority: Major > Labels: usability > > Selecting Add Employee Position or Add Person from the context menu opens the > corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17285132#comment-17285132 ] Sebastian Berg commented on OFBIZ-11685: After some investigating I noticed, that if I remove line 125 '' in 'common-theme/widget/CommonScreens#GlobalActions' the dateTimePicker works fine. In the trunk version CommonScreens#GlobalActions got refactored and the line was removed. Maybe that's why its working fine in trunk. Maybe someone with more knowledge on the subject can tell why we need line 125, otherwise I would suggest to remove it. > Form to add an employee doesn't function properly when invoked from Humanres > tree > - > > Key: OFBIZ-11685 > URL: https://issues.apache.org/jira/browse/OFBIZ-11685 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > > Selecting 'Add Person' from the context menu (on the 'Employment Position' > element opens the corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11683) Humanres tree right-click pop-up menu allows existing OU to be added again
[ https://issues.apache.org/jira/browse/OFBIZ-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284669#comment-17284669 ] Sebastian Berg edited comment on OFBIZ-11683 at 2/15/21, 11:19 AM: --- After some further investigation I know why OUs can be added again. With right-click add OU the function 'createInternalOrg' gets called. In this event the 'roleTypeIdFrom' and 'roleTypeIdTo' gets set to 'INTERNAL_ORGANIZATIO' and the service 'createPartyRelationship' is called. 'createPartyRelationship' checks whether the relation already exists. The existing relations shown in the tree are initialized with 'roleTypeIdFrom' and 'roleTypeIdTo' = '_NA__'_. Therefore a new 'PartyRelationship' is created. For the most part this can be easily fixed by changing the roleTypes in the demo data, 'DemoLeadOwnersGroup' is a special case. 'DemoLeadOwnersGroup' has the associated partyRoles '_NA_' and 'OTHER_ORGANIZATION_U' but is still assigned with 'INTERNAL_ORGANIZATIO'. I am not sure what's the best way to approach this, some input would be helpful. was (Author: sberg): After some further investigation I know why OUs can be added again. With right-click add OU the function 'createInternalOrg' gets called. In this event the 'roleTypeIdFrom' and 'roleTypeIdTo' gets set to 'INTERNAL_ORGANIZATIO' and the service 'createPartyRelationship' is called. 'createPartyRelationship' checks whether the relation already exists. The existing relations shown in the tree are initialized with 'roleTypeIdFrom' and 'roleTypeIdTo' = "_NA_". Therefore a new 'PartyRelationship' is created. For the most part this can be easily fixed by changing the roleTypes in the demo data, 'DemoLeadOwnersGroup' is a special case. 'DemoLeadOwnersGroup' has the associated partyRoles '_NA_' and 'OTHER_ORGANIZATION_U' but is still assigned with 'INTERNAL_ORGANIZATIO'. I am not sure what's the best way to approach this, some input would be helpful. > Humanres tree right-click pop-up menu allows existing OU to be added again > -- > > Key: OFBIZ-11683 > URL: https://issues.apache.org/jira/browse/OFBIZ-11683 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > Attachments: Screen Shot 2020-05-09 at 22.02.48.png, Screen Shot > 2020-05-09 at 22.03.09.png, Screen Shot 2020-05-09 at 22.03.25.png > > > When on the main page, the user right-clicks on an organisation or > organisation unit (OU) to add an new subordinate organisation unit, an > existing OU can be added again. > See attached images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11683) Humanres tree right-click pop-up menu allows existing OU to be added again
[ https://issues.apache.org/jira/browse/OFBIZ-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284669#comment-17284669 ] Sebastian Berg commented on OFBIZ-11683: After some further investigation I know why OUs can be added again. With right-click add OU the function 'createInternalOrg' gets called. In this event the 'roleTypeIdFrom' and 'roleTypeIdTo' gets set to 'INTERNAL_ORGANIZATIO' and the service 'createPartyRelationship' is called. 'createPartyRelationship' checks whether the relation already exists. The existing relations shown in the tree are initialized with 'roleTypeIdFrom' and 'roleTypeIdTo' = "_NA_". Therefore a new 'PartyRelationship' is created. For the most part this can be easily fixed by changing the roleTypes in the demo data, 'DemoLeadOwnersGroup' is a special case. 'DemoLeadOwnersGroup' has the associated partyRoles '_NA_' and 'OTHER_ORGANIZATION_U' but is still assigned with 'INTERNAL_ORGANIZATIO'. I am not sure what's the best way to approach this, some input would be helpful. > Humanres tree right-click pop-up menu allows existing OU to be added again > -- > > Key: OFBIZ-11683 > URL: https://issues.apache.org/jira/browse/OFBIZ-11683 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > Attachments: Screen Shot 2020-05-09 at 22.02.48.png, Screen Shot > 2020-05-09 at 22.03.09.png, Screen Shot 2020-05-09 at 22.03.25.png > > > When on the main page, the user right-clicks on an organisation or > organisation unit (OU) to add an new subordinate organisation unit, an > existing OU can be added again. > See attached images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10791) Unable to add product (of ASSET_USAGE type) in order
[ https://issues.apache.org/jira/browse/OFBIZ-10791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283685#comment-17283685 ] Sebastian Berg commented on OFBIZ-10791: [~mbrohl] I had no issues applying the patch. I created a PR for convenience. > Unable to add product (of ASSET_USAGE type) in order > > > Key: OFBIZ-10791 > URL: https://issues.apache.org/jira/browse/OFBIZ-10791 > Project: OFBiz > Issue Type: Bug > Components: order >Affects Versions: Release Branch 16.11, Release Branch 18.12, Release > Branch 17.12, Trunk >Reporter: Praveen Sharma >Assignee: Sebastian Berg >Priority: Major > Labels: ASSET_USAGE, CONTRACT_RENEWAL, PURCHASE_RENTAL, > SALES_RENTAL > Attachments: OFBIZ-10791.patch, OFBIZ-10791.patch, Screenshot from > 2019-03-09 11-05-31.png, Screenshot from 2019-03-09 11-06-20.png, Screenshot > from 2019-03-09 11-06-36.png, asset-addtocart.png > > > Steps to regenerate: > # Login to URL: [https://demo-trunk.ofbiz.apache.org/ordermgr/control/main] > # Click on order entry > # Set customer and click on continue > # Click continue on Enter Order Currency, Agreements, and Ship Dates page > (Please refer attachment: 2-Continue) > # Try to add product from Quick Lookup. > Actual: Unable to add product for order. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reopened OFBIZ-11685: > Form to add an employee doesn't function properly when invoked from Humanres > tree > - > > Key: OFBIZ-11685 > URL: https://issues.apache.org/jira/browse/OFBIZ-11685 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > > Selecting 'Add Person' from the context menu (on the 'Employment Position' > element opens the corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282399#comment-17282399 ] Sebastian Berg commented on OFBIZ-11685: Yeah sorry, I only checked on trunk. I was able to replicate the error on older branches. I will look into the problem > Form to add an employee doesn't function properly when invoked from Humanres > tree > - > > Key: OFBIZ-11685 > URL: https://issues.apache.org/jira/browse/OFBIZ-11685 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Labels: usability > > Selecting 'Add Person' from the context menu (on the 'Employment Position' > element opens the corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11685: -- Assignee: Sebastian Berg (was: Michael Brohl) > Form to add an employee doesn't function properly when invoked from Humanres > tree > - > > Key: OFBIZ-11685 > URL: https://issues.apache.org/jira/browse/OFBIZ-11685 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > > Selecting 'Add Person' from the context menu (on the 'Employment Position' > element opens the corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12174) Convert InventoryServices.xml mini lang to groovy
Sebastian Berg created OFBIZ-12174: -- Summary: Convert InventoryServices.xml mini lang to groovy Key: OFBIZ-12174 URL: https://issues.apache.org/jira/browse/OFBIZ-12174 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11684) Form to add an employee position doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282378#comment-17282378 ] Sebastian Berg commented on OFBIZ-11684: For me this is working correctly. Can somebody else confirm this so we can close the issue? > Form to add an employee position doesn't function properly when invoked from > Humanres tree > -- > > Key: OFBIZ-11684 > URL: https://issues.apache.org/jira/browse/OFBIZ-11684 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Priority: Major > Labels: usability > > Selecting Add Employee Position or Add Person from the context menu opens the > corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282377#comment-17282377 ] Sebastian Berg commented on OFBIZ-11685: For me this is working. Can somebody else confirm this so we can close the issue? > Form to add an employee doesn't function properly when invoked from Humanres > tree > - > > Key: OFBIZ-11685 > URL: https://issues.apache.org/jira/browse/OFBIZ-11685 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > > Selecting 'Add Person' from the context menu (on the 'Employment Position' > element opens the corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11685) Form to add an employee doesn't function properly when invoked from Humanres tree
[ https://issues.apache.org/jira/browse/OFBIZ-11685?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11685: -- Assignee: Sebastian Berg > Form to add an employee doesn't function properly when invoked from Humanres > tree > - > > Key: OFBIZ-11685 > URL: https://issues.apache.org/jira/browse/OFBIZ-11685 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, 18.12.01, Release Branch 17.12, > 17.12.03, Trunk, 17.12.04 >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > > Selecting 'Add Person' from the context menu (on the 'Employment Position' > element opens the corresponding edit forms with calendar lookup fields. > The calendar form does no open when the lookup icon is clicked. > Expected calendar to open on click. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11683) Humanres tree right-click pop-up menu allows existing OU to be added again
[ https://issues.apache.org/jira/browse/OFBIZ-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282356#comment-17282356 ] Sebastian Berg commented on OFBIZ-11683: Since I couldn't replicate the error I looked into the code. The event 'createInternalOrg' calls the service 'createPartyRelationship' which checks for an existing relationship and therefore doesn't create a new one. Maybe someone else can confirm this, otherwise I think we can close this issue. > Humanres tree right-click pop-up menu allows existing OU to be added again > -- > > Key: OFBIZ-11683 > URL: https://issues.apache.org/jira/browse/OFBIZ-11683 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > Attachments: Screen Shot 2020-05-09 at 22.02.48.png, Screen Shot > 2020-05-09 at 22.03.09.png, Screen Shot 2020-05-09 at 22.03.25.png > > > When on the main page, the user right-clicks on an organisation or > organisation unit (OU) to add an new subordinate organisation unit, an > existing OU can be added again. > See attached images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11683) Humanres tree right-click pop-up menu allows existing OU to be added again
[ https://issues.apache.org/jira/browse/OFBIZ-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282252#comment-17282252 ] Sebastian Berg commented on OFBIZ-11683: I will look into this. > Humanres tree right-click pop-up menu allows existing OU to be added again > -- > > Key: OFBIZ-11683 > URL: https://issues.apache.org/jira/browse/OFBIZ-11683 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > Attachments: Screen Shot 2020-05-09 at 22.02.48.png, Screen Shot > 2020-05-09 at 22.03.09.png, Screen Shot 2020-05-09 at 22.03.25.png > > > When on the main page, the user right-clicks on an organisation or > organisation unit (OU) to add an new subordinate organisation unit, an > existing OU can be added again. > See attached images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11683) Humanres tree right-click pop-up menu allows existing OU to be added again
[ https://issues.apache.org/jira/browse/OFBIZ-11683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11683: -- Assignee: Sebastian Berg > Humanres tree right-click pop-up menu allows existing OU to be added again > -- > > Key: OFBIZ-11683 > URL: https://issues.apache.org/jira/browse/OFBIZ-11683 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: usability > Attachments: Screen Shot 2020-05-09 at 22.02.48.png, Screen Shot > 2020-05-09 at 22.03.09.png, Screen Shot 2020-05-09 at 22.03.25.png > > > When on the main page, the user right-clicks on an organisation or > organisation unit (OU) to add an new subordinate organisation unit, an > existing OU can be added again. > See attached images. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11786) Packer can change data on shipment
[ https://issues.apache.org/jira/browse/OFBIZ-11786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281697#comment-17281697 ] Sebastian Berg commented on OFBIZ-11786: In order to edit a Shipment the permission service 'checkCanChangeShipmentStatusDelivered' is called which in succession calls 'facilityGenericPermission' followed by 'checkFacilityRelatedPermission' where the 'FACILITY' and 'CATALOG' permission in this case for 'UPDATE' is checked. At the moment only the Party 'system' gets assigned the 'Packer' RoleType. >From my perspective this seems to be a configuration issue on which >SecurityPermissions are assigned to a userLogin with the 'Packer' RoleType. [~pierresmits] can you maybe further describe why there is a problem here? > Packer can change data on shipment > -- > > Key: OFBIZ-11786 > URL: https://issues.apache.org/jira/browse/OFBIZ-11786 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: 17.12.03, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: refactoring, usability > > When a shipment has been created (e.g. > https://demo-stable.ofbiz.apache.org/facility/control/ViewShipment?shipmentId=10005), > a packer can edit the details via editShipment, including (but not limited > to) changing the customer and cost involved. > This should not be possible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11786) Packer can change data on shipment
[ https://issues.apache.org/jira/browse/OFBIZ-11786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281574#comment-17281574 ] Sebastian Berg commented on OFBIZ-11786: I will have a look into this. > Packer can change data on shipment > -- > > Key: OFBIZ-11786 > URL: https://issues.apache.org/jira/browse/OFBIZ-11786 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: 17.12.03, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: refactoring, usability > > When a shipment has been created (e.g. > https://demo-stable.ofbiz.apache.org/facility/control/ViewShipment?shipmentId=10005), > a packer can edit the details via editShipment, including (but not limited > to) changing the customer and cost involved. > This should not be possible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11786) Packer can change data on shipment
[ https://issues.apache.org/jira/browse/OFBIZ-11786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11786: -- Assignee: Sebastian Berg > Packer can change data on shipment > -- > > Key: OFBIZ-11786 > URL: https://issues.apache.org/jira/browse/OFBIZ-11786 > Project: OFBiz > Issue Type: Bug > Components: product >Affects Versions: 17.12.03, Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: refactoring, usability > > When a shipment has been created (e.g. > https://demo-stable.ofbiz.apache.org/facility/control/ViewShipment?shipmentId=10005), > a packer can edit the details via editShipment, including (but not limited > to) changing the customer and cost involved. > This should not be possible -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-12172) Remove CommunicationContent is not working as expected
[ https://issues.apache.org/jira/browse/OFBIZ-12172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281051#comment-17281051 ] Sebastian Berg commented on OFBIZ-12172: I provided a solution implementing what I think should be the default behavior feel free to suggest a different approach if I missed something. I changed the controller for the request 'removeAttachFile' so after deleting a CommunicationContent the user stays on the overview page and is not forced into the edit Screen. The reason why the content doesn't get deleted after clicking the button ist, that the CommunicationContent in the database doesn't get deleted on default instead in 'CommEventContentAssoc' a thru-Date is set. To account for that I added a filter-by-date for the 'ListCommContent' in order to show only active contents. Again feel free to suggest a different solution. Sebastian > Remove CommunicationContent is not working as expected > -- > > Key: OFBIZ-12172 > URL: https://issues.apache.org/jira/browse/OFBIZ-12172 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > > How to reproduce: > Go to Party -> Communication -> Search -> select any entry with > CommunicationContent -> On the right side under 'Related Content' in the > table 'Communication Content' delete any entry > Result: The user gets navigated to EditCommunicationEvent. If I go back to > the CommunicationContent the deleted entry still shows. > > From my perspective the expected behavior would be to remain on the current > view, while the CommunicationContent gets deleted. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12172) Remove CommunicationContent is not working as expected
Sebastian Berg created OFBIZ-12172: -- Summary: Remove CommunicationContent is not working as expected Key: OFBIZ-12172 URL: https://issues.apache.org/jira/browse/OFBIZ-12172 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch How to reproduce: Go to Party -> Communication -> Search -> select any entry with CommunicationContent -> On the right side under 'Related Content' in the table 'Communication Content' delete any entry Result: The user gets navigated to EditCommunicationEvent. If I go back to the CommunicationContent the deleted entry still shows. >From my perspective the expected behavior would be to remain on the current >view, while the CommunicationContent gets deleted. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11461: --- Attachment: (was: OFBIZ-11461-OrderDeliveryServices.xml-minilang-to-groovy.patch) > Convert OrderDeliveryServices.xml minilang to groovy > > > Key: OFBIZ-11461 > URL: https://issues.apache.org/jira/browse/OFBIZ-11461 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276898#comment-17276898 ] Sebastian Berg commented on OFBIZ-11461: I removed the patch and created a PR instead for easier merging. > Convert OrderDeliveryServices.xml minilang to groovy > > > Key: OFBIZ-11461 > URL: https://issues.apache.org/jira/browse/OFBIZ-11461 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11604) Convert ImageManagementServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276392#comment-17276392 ] Sebastian Berg commented on OFBIZ-11604: I updated the PR for easier merging. > Convert ImageManagementServices.xml minilang to groovy > -- > > Key: OFBIZ-11604 > URL: https://issues.apache.org/jira/browse/OFBIZ-11604 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11599) Convert CheckoutServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276389#comment-17276389 ] Sebastian Berg commented on OFBIZ-11599: I updated the PR for easier merging. > Convert CheckoutServices.xml minilang to groovy > --- > > Key: OFBIZ-11599 > URL: https://issues.apache.org/jira/browse/OFBIZ-11599 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11595) Convert CostServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276386#comment-17276386 ] Sebastian Berg commented on OFBIZ-11595: I have updated the PR for easier merging. > Convert CostServices.xml minilang to groovy > --- > > Key: OFBIZ-11595 > URL: https://issues.apache.org/jira/browse/OFBIZ-11595 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11868) Convert EmailServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11868: -- Assignee: Sebastian Berg (was: Harutyun Farajyan) > Convert EmailServices.xml mini lang to groovy > - > > Key: OFBIZ-11868 > URL: https://issues.apache.org/jira/browse/OFBIZ-11868 > Project: OFBiz > Issue Type: Sub-task >Reporter: Harutyun Farajyan >Assignee: Sebastian Berg >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12146) Update German UiLabel in relation with entity QuantityBreak
Sebastian Berg created OFBIZ-12146: -- Summary: Update German UiLabel in relation with entity QuantityBreak Key: OFBIZ-12146 URL: https://issues.apache.org/jira/browse/OFBIZ-12146 Project: OFBiz Issue Type: Improvement Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch Some of the German uiLabels in relation with the entity QuantityBreak already got updated like a couple of years ago. For example "Menge Sprung ID" to "Mengenstaffel ID", while other are still using the old description. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-12016) DiskFileItem as request attribute creates problems
Sebastian Berg created OFBIZ-12016: -- Summary: DiskFileItem as request attribute creates problems Key: OFBIZ-12016 URL: https://issues.apache.org/jira/browse/OFBIZ-12016 Project: OFBiz Issue Type: Bug Affects Versions: Trunk, 18.12.01 Reporter: Sebastian Berg Hi, while working on a custom project based on the 18.12.01 version, I noticed a problem with the request handling during a request-redirect-noparam if a DiskFileItem was involved. So the situation for me is as follows: during the first request a file is uploaded. I choose a wrong format on purpose, which results in an error respond for that event. Nevertheless the DiskFileItem is set as request attribute together with the error message. The request is finished and based on the controller configurations redirected to a second request. While handling the second request the previous request's attributes get restored (RequestHandler.java line 733ff). This goes down into SafeObjectInfo.resolveClass() where an Incompatible class exception is thrown. I compared my custom project with the current development status and worked in the changes from commit 3f60efb343a11723aa56c1bc1f5afac3a2f26e9f in OFBIZ-10837. While this fixes the issue with the incompatible class exception it also makes it impossible to retrieve any attributes from the first request. Therefore my error message cannot be shown. Is there a way to fix it or is it otherwise necessary to always set "fileItems" as request attribute as added in -OFBIZ-11246-? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11604) Convert ImageManagementServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17183944#comment-17183944 ] Sebastian Berg commented on OFBIZ-11604: I finished migrating the minilang methods. > Convert ImageManagementServices.xml minilang to groovy > -- > > Key: OFBIZ-11604 > URL: https://issues.apache.org/jira/browse/OFBIZ-11604 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11751) Add getter in LabelFile.java
Sebastian Berg created OFBIZ-11751: -- Summary: Add getter in LabelFile.java Key: OFBIZ-11751 URL: https://issues.apache.org/jira/browse/OFBIZ-11751 Project: OFBiz Issue Type: Improvement Components: framework/webtools Affects Versions: Trunk Reporter: Sebastian Berg Fix For: Upcoming Branch I am currently working on a custom plugin for the translation of LabelFiles. For an easier search a getter for componentName is necessary. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11604) Convert ImageManagementServices.xml minilang to groovy
Sebastian Berg created OFBIZ-11604: -- Summary: Convert ImageManagementServices.xml minilang to groovy Key: OFBIZ-11604 URL: https://issues.apache.org/jira/browse/OFBIZ-11604 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11599) Convert CheckoutServices.xml minilang to groovy
Sebastian Berg created OFBIZ-11599: -- Summary: Convert CheckoutServices.xml minilang to groovy Key: OFBIZ-11599 URL: https://issues.apache.org/jira/browse/OFBIZ-11599 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11572) Convert LeadServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085619#comment-17085619 ] Sebastian Berg commented on OFBIZ-11572: I testet my changes with the service definition implemented in OFBIZ-11413 for "createPartyGroupRoleAndContactMechs". > Convert LeadServices.xml minilang to groovy > --- > > Key: OFBIZ-11572 > URL: https://issues.apache.org/jira/browse/OFBIZ-11572 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11572) Convert LeadServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17085616#comment-17085616 ] Sebastian Berg commented on OFBIZ-11572: LeadServices.groovy calls upon the service "createPartyGroupRoleAndContactMechs" whose service definition is added in OFBIZ-11413. > Convert LeadServices.xml minilang to groovy > --- > > Key: OFBIZ-11572 > URL: https://issues.apache.org/jira/browse/OFBIZ-11572 > Project: OFBiz > Issue Type: Sub-task > Components: marketing >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11595) Convert CostServices.xml minilang to groovy
Sebastian Berg created OFBIZ-11595: -- Summary: Convert CostServices.xml minilang to groovy Key: OFBIZ-11595 URL: https://issues.apache.org/jira/browse/OFBIZ-11595 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11591) Convert InventoryIssueServices minilang to groovy
Sebastian Berg created OFBIZ-11591: -- Summary: Convert InventoryIssueServices minilang to groovy Key: OFBIZ-11591 URL: https://issues.apache.org/jira/browse/OFBIZ-11591 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-4361) Any ecommerce user has the ability to reset anothers password (including admin) via "Forget Your Password"
[
https://issues.apache.org/jira/browse/OFBIZ-4361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17079047#comment-17079047
]
Sebastian Berg commented on OFBIZ-4361:
---
Hi [~nmalin],
you wrote
{quote}Also I will open an issue for the works submitted by [~Dennis Balkir] to
open a new login with validation process
{quote}
a couple of month ago. Did you ever got around creating the issue? If so maybe
you can link it for me?
> Any ecommerce user has the ability to reset anothers password (including
> admin) via "Forget Your Password"
> --
>
> Key: OFBIZ-4361
> URL: https://issues.apache.org/jira/browse/OFBIZ-4361
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework
>Affects Versions: Release Branch 11.04, Release Branch 13.07, Release
> Branch 14.12, Release Branch 15.12, Release Branch 16.11, Release Branch
> 17.12, Trunk
> Environment: Ubuntu and others
>Reporter: mz4wheeler
>Assignee: Jacques Le Roux
>Priority: Major
> Labels: security
> Fix For: 18.12.01, Upcoming Branch
>
> Attachments: OFBIZ-4361.patch, OFBIZ-4361_OneScreen.patch,
> OFBIZ-4361_ReworkPasswordLogic.patch, OFBIZ-4361_ReworkPasswordLogic.patch,
> OFBIZ-4361_Token-Password-Registration.patch
>
>
> Currently, any user (via ecommerce "Forget Your Password") has the ability to
> reset another users password, including "admin" without permission. By
> simply entering "admin" and clicking "Email Password", the following is
> displayed.
> The following occurred:
> A new password has been created and sent to you. Please check your Email.
> This now forces the user of the ERP to change their password. It is also
> possible to generate a dictionary attack against ofbiz because there is no
> capta code required. This is serious security risk.
> This feature could be reduced to a certain sub-set of users, whose login name
> is optionally in the format of an email address, and maybe require a capta
> code to prevent dictionary attacks.
> For example, limit the feature to role "Customer" of type "Person" which was
> generated via an ecommerce transaction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (OFBIZ-11572) Convert LeadServices.xml minilang to groovy
Sebastian Berg created OFBIZ-11572: -- Summary: Convert LeadServices.xml minilang to groovy Key: OFBIZ-11572 URL: https://issues.apache.org/jira/browse/OFBIZ-11572 Project: OFBiz Issue Type: Sub-task Components: marketing Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11461: --- Attachment: OFBIZ-11461-OrderDeliveryServices.xml-minilang-to-groovy.patch > Convert OrderDeliveryServices.xml minilang to groovy > > > Key: OFBIZ-11461 > URL: https://issues.apache.org/jira/browse/OFBIZ-11461 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11461-OrderDeliveryServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11462) Convert ShipmentServices.xml from minilang to groovy
Sebastian Berg created OFBIZ-11462: -- Summary: Convert ShipmentServices.xml from minilang to groovy Key: OFBIZ-11462 URL: https://issues.apache.org/jira/browse/OFBIZ-11462 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11461) Convert OrderDeliveryServices.xml minilang to groovy
Sebastian Berg created OFBIZ-11461: -- Summary: Convert OrderDeliveryServices.xml minilang to groovy Key: OFBIZ-11461 URL: https://issues.apache.org/jira/browse/OFBIZ-11461 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11449) Convert ProductStoreServices.xml mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11449: --- Attachment: OFBIZ-11449-ProductStoreServices.xml-minilang-to-groovy.patch > Convert ProductStoreServices.xml mini-lang to groovy > > > Key: OFBIZ-11449 > URL: https://issues.apache.org/jira/browse/OFBIZ-11449 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11449-ProductStoreServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11442: --- Attachment: (was: OFBIZ-11442-OrderReturnServices.xml-minilang-to-groovy.patch) > Convert OrderReturnService mini-lang to groovy > -- > > Key: OFBIZ-11442 > URL: https://issues.apache.org/jira/browse/OFBIZ-11442 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11442-OrderReturnServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11442: --- Attachment: OFBIZ-11442-OrderReturnServices.xml-minilang-to-groovy.patch > Convert OrderReturnService mini-lang to groovy > -- > > Key: OFBIZ-11442 > URL: https://issues.apache.org/jira/browse/OFBIZ-11442 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11442-OrderReturnServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11442: --- Attachment: OFBIZ-11442-OrderReturnServices.xml-minilang-to-groovy.patch > Convert OrderReturnService mini-lang to groovy > -- > > Key: OFBIZ-11442 > URL: https://issues.apache.org/jira/browse/OFBIZ-11442 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11442-OrderReturnServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057906#comment-17057906 ] Sebastian Berg commented on OFBIZ-11442: Hi, I finished migrating all methods from minilang to groovy. However I had trouble verifying the functionality of a couple Methods, namely updateReturnStatusFromReceipt(), createReturnItemForRental(), cancelReplacementOrderItems() and quickReturnFromOrder(). For these methods the minilang basis seems to be incorrect. I made some minor changes where I could, but I suggest someone with more knowledge about the functionality of these methods should have a look at this. Sebastian > Convert OrderReturnService mini-lang to groovy > -- > > Key: OFBIZ-11442 > URL: https://issues.apache.org/jira/browse/OFBIZ-11442 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11449) Convert ProductStoreServices.xml mini-lang to groovy
Sebastian Berg created OFBIZ-11449: -- Summary: Convert ProductStoreServices.xml mini-lang to groovy Key: OFBIZ-11449 URL: https://issues.apache.org/jira/browse/OFBIZ-11449 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11436) Convert ProductContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11436: --- Attachment: OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch > Convert ProductContentServices.xml mini lang to groovy > -- > > Key: OFBIZ-11436 > URL: https://issues.apache.org/jira/browse/OFBIZ-11436 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch, > OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11436) Convert ProductContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055099#comment-17055099 ] Sebastian Berg commented on OFBIZ-11436: Thanks [~nmalin] for the feedback. I updated the patch accordingly. > Convert ProductContentServices.xml mini lang to groovy > -- > > Key: OFBIZ-11436 > URL: https://issues.apache.org/jira/browse/OFBIZ-11436 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch, > OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055075#comment-17055075 ] Sebastian Berg commented on OFBIZ-11030: Hi, I updated the groovy formatting accordingly and reuploaded the patch. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11439) Convert ProductFeatureServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11439: --- Attachment: OFBIZ-11439-Convert-ProductFeatureServices.xml-mini-lang-to-groovy.patch > Convert ProductFeatureServices.xml mini lang to groovy > -- > > Key: OFBIZ-11439 > URL: https://issues.apache.org/jira/browse/OFBIZ-11439 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11439-Convert-ProductFeatureServices.xml-mini-lang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy
Sebastian Berg created OFBIZ-11442: -- Summary: Convert OrderReturnService mini-lang to groovy Key: OFBIZ-11442 URL: https://issues.apache.org/jira/browse/OFBIZ-11442 Project: OFBiz Issue Type: Sub-task Components: order Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9984) Convert OrderServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-9984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17052201#comment-17052201 ] Sebastian Berg commented on OFBIZ-9984: --- Hi, I would like to convert the remaining Methods in OrderServices.xml to groovy. Do you mind if I take this one on me [~pgil]? > Convert OrderServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-9984 > URL: https://issues.apache.org/jira/browse/OFBIZ-9984 > Project: OFBiz > Issue Type: Sub-task > Components: order >Affects Versions: Trunk >Reporter: Julien NICOLAS >Assignee: Gil Portenseigne >Priority: Minor > Labels: groovy, mini-lang > Attachments: OFBIZ-9984-v1.patch, OFBIZ-9984.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, I tried to convert some > mini-lang service to groovy script. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11436) Convert ProductContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11436: --- Attachment: OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch > Convert ProductContentServices.xml mini lang to groovy > -- > > Key: OFBIZ-11436 > URL: https://issues.apache.org/jira/browse/OFBIZ-11436 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Sebastian Berg >Assignee: Sebastian Berg >Priority: Minor > Fix For: Upcoming Branch > > Attachments: > OFBIZ-11436-ProductContentServices.xml-minilang-to-groovy.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11439) Convert ProductFeatureServices.xml mini lang to groovy
Sebastian Berg created OFBIZ-11439: -- Summary: Convert ProductFeatureServices.xml mini lang to groovy Key: OFBIZ-11439 URL: https://issues.apache.org/jira/browse/OFBIZ-11439 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11436) Convert ProductContentServices.xml mini lang to groovy
Sebastian Berg created OFBIZ-11436: -- Summary: Convert ProductContentServices.xml mini lang to groovy Key: OFBIZ-11436 URL: https://issues.apache.org/jira/browse/OFBIZ-11436 Project: OFBiz Issue Type: Sub-task Components: product Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11361) Convert PartyServices.xml mini-lang to groovyDSL
[ https://issues.apache.org/jira/browse/OFBIZ-11361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049975#comment-17049975 ] Sebastian Berg commented on OFBIZ-11361: Hi [~nmalin], I just realized I made a mistake duplicating this ticket and started working on it. Are you currently working on the conversion of PartyServices.xml? > Convert PartyServices.xml mini-lang to groovyDSL > > > Key: OFBIZ-11361 > URL: https://issues.apache.org/jira/browse/OFBIZ-11361 > Project: OFBiz > Issue Type: Sub-task > Components: party >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Minor > Labels: groovy, mini-lang > > Migration of file PartyServices.xml to groovy > h4. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049345#comment-17049345 ] Sebastian Berg commented on OFBIZ-11030: Hi [~pierresmits], for me new entries appear in SalesInvoiceItemFact as well as SalesOrderItemFact. Patch should be fine. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049189#comment-17049189 ] Sebastian Berg commented on OFBIZ-11030: I reuploaded the patch with the correct if-check. Sorry for the inconvenience. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11424) createPartyContent not working
[ https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11424: --- Description: go to Party -> search -> select any PartyId -> Party Content Create will produce the following error: "The Following Errors Occurred: layoutEvents.no_files_uploaded" was: go to Party --> search --> select any PartyId --> Party Content Create will produce the following error: "The Following Errors Occurred: layoutEvents.no_files_uploaded" > createPartyContent not working > -- > > Key: OFBIZ-11424 > URL: https://issues.apache.org/jira/browse/OFBIZ-11424 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Sebastian Berg >Priority: Major > Fix For: Upcoming Branch > > > go to Party -> search -> select any PartyId -> Party Content > Create will produce the following error: > "The Following Errors Occurred: > layoutEvents.no_files_uploaded" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11424) createPartyContent not working
[ https://issues.apache.org/jira/browse/OFBIZ-11424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11424: -- Assignee: (was: Sebastian Berg) > createPartyContent not working > -- > > Key: OFBIZ-11424 > URL: https://issues.apache.org/jira/browse/OFBIZ-11424 > Project: OFBiz > Issue Type: Bug > Components: party >Affects Versions: Trunk >Reporter: Sebastian Berg >Priority: Major > Fix For: Upcoming Branch > > > go to Party --> search --> select any PartyId --> Party Content > Create will produce the following error: > "The Following Errors Occurred: > layoutEvents.no_files_uploaded" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11424) createPartyContent not working
Sebastian Berg created OFBIZ-11424: -- Summary: createPartyContent not working Key: OFBIZ-11424 URL: https://issues.apache.org/jira/browse/OFBIZ-11424 Project: OFBiz Issue Type: Bug Components: party Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch go to Party --> search --> select any PartyId --> Party Content Create will produce the following error: "The Following Errors Occurred: layoutEvents.no_files_uploaded" -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046355#comment-17046355 ] Sebastian Berg commented on OFBIZ-11030: You are right [~pierresmits] in loadInventoryFact() were some if-clauses in the wrong place. It should be fine now. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (OFBIZ-11422) Convert PartyServices.xml mini-lang to groovy
Sebastian Berg created OFBIZ-11422: -- Summary: Convert PartyServices.xml mini-lang to groovy Key: OFBIZ-11422 URL: https://issues.apache.org/jira/browse/OFBIZ-11422 Project: OFBiz Issue Type: Sub-task Components: party Affects Versions: Trunk Reporter: Sebastian Berg Assignee: Sebastian Berg Fix For: Upcoming Branch -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045547#comment-17045547 ] Sebastian Berg commented on OFBIZ-11030: I have reuploaded the patch, it should work now. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-11030: --- Attachment: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044452#comment-17044452 ] Sebastian Berg commented on OFBIZ-11030: Hi [~pierresmits], I have migrated the the Methods already and am currently testing my work. I will provide the results as soon as possible for you to enhance them. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg reassigned OFBIZ-11030: -- Assignee: Sebastian Berg > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10001) Convert CategoryContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-10001: --- Attachment: OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch > Convert CategoryContentServices.xml mini lang to groovy > --- > > Key: OFBIZ-10001 > URL: https://issues.apache.org/jira/browse/OFBIZ-10001 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Labels: refactoring > Attachments: > OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch, > > OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch > > > Migration of the CategoryContentServices.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10001) Convert CategoryContentServices.xml mini lang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-10001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043518#comment-17043518 ] Sebastian Berg commented on OFBIZ-10001: Hi, I have modified the patch according to Deepak's input. I integrated the uploadFileInterface into createDownloadContentForCategory and createDownloadContentForCategory. I also combined updateSimpleTextContentForCategory into a group service. I skipped createSimpleTextContentForCategory since there are some minor tasks other than calling services. > Convert CategoryContentServices.xml mini lang to groovy > --- > > Key: OFBIZ-10001 > URL: https://issues.apache.org/jira/browse/OFBIZ-10001 > Project: OFBiz > Issue Type: Sub-task > Components: product >Affects Versions: Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Minor > Labels: refactoring > Attachments: > OFBIZ-10001_org.apache.ofbiz.product.category.CategoryContentServices_convert.patch > > > Migration of the CategoryContentServices.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11335) Add CommonForms as template pattern configured by theme
[
https://issues.apache.org/jira/browse/OFBIZ-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17041133#comment-17041133
]
Sebastian Berg commented on OFBIZ-11335:
Hi,
I might be new around here, but I encountered a Problem which seems to be
related to this commit.
Clicking on Entity-Engine --> any Entity
results in this: !Bildschirmfoto 2020-02-20 um 17.49.22.png!
Maybe you can investigate the issue and take according steps.
Thank you
> Add CommonForms as template pattern configured by theme
> ---
>
> Key: OFBIZ-11335
> URL: https://issues.apache.org/jira/browse/OFBIZ-11335
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Bildschirmfoto 2020-02-20 um 17.49.22.png,
> OFBIZ-11335.patch
>
>
> Currently on OFBiz we implemented a process to define some different screen
> and menu that can be implemented by the theming
> But for the form we have nothing. All style are hard coded on each
> {code:java}
> odd-row-style="alternate-row" default-table-style="basic-table
> hover-bar">{code}
>
> I propose to extend the theming implementation principle to forms element.
> To start low, I define seven form tempates :
> * grid CommonSimpleGrid
> * grid CommonBasicGrid
> * form CommonSimpleList
> * form CommonBasicList
> * form CommonInLineEditList
> * form CommonSimpleSingle
> * form CommonBasicSingle
>
> We can use its like :
> {code:java}
> extends-resource="component://common/widget/CommonForms.xml"{code}
> The main difficulty raise to this task was propage the visualTheme during the
> ModelForm intanciation, because we need to load wiget style (and some other
> information wanted on the template) on model load in memory.
> With the linked patch I improved form present on screen
> [https://localhost:8443/webtools/control/WebtoolsLayoutDemo]
>
> Finally with this we can extend style form (pagination, header, line and so
> on ...) direclty by your theme without change the framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (OFBIZ-11335) Add CommonForms as template pattern configured by theme
[
https://issues.apache.org/jira/browse/OFBIZ-11335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebastian Berg updated OFBIZ-11335:
---
Attachment: Bildschirmfoto 2020-02-20 um 17.49.22.png
> Add CommonForms as template pattern configured by theme
> ---
>
> Key: OFBIZ-11335
> URL: https://issues.apache.org/jira/browse/OFBIZ-11335
> Project: OFBiz
> Issue Type: New Feature
> Components: framework, themes
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Fix For: Upcoming Branch
>
> Attachments: Bildschirmfoto 2020-02-20 um 17.49.22.png,
> OFBIZ-11335.patch
>
>
> Currently on OFBiz we implemented a process to define some different screen
> and menu that can be implemented by the theming
> But for the form we have nothing. All style are hard coded on each
> {code:java}
> odd-row-style="alternate-row" default-table-style="basic-table
> hover-bar">{code}
>
> I propose to extend the theming implementation principle to forms element.
> To start low, I define seven form tempates :
> * grid CommonSimpleGrid
> * grid CommonBasicGrid
> * form CommonSimpleList
> * form CommonBasicList
> * form CommonInLineEditList
> * form CommonSimpleSingle
> * form CommonBasicSingle
>
> We can use its like :
> {code:java}
> extends-resource="component://common/widget/CommonForms.xml"{code}
> The main difficulty raise to this task was propage the visualTheme during the
> ModelForm intanciation, because we need to load wiget style (and some other
> information wanted on the template) on model load in memory.
> With the linked patch I improved form present on screen
> [https://localhost:8443/webtools/control/WebtoolsLayoutDemo]
>
> Finally with this we can extend style form (pagination, header, line and so
> on ...) direclty by your theme without change the framework
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036284#comment-17036284 ] Sebastian Berg edited comment on OFBIZ-11215 at 2/13/20 3:47 PM: - Hi, I did some testing and for me this works fine on R17. Maybe someone else can confirm this? was (Author: sberg): Hi, I did some testing and for me this works fine on R17. Maybe someone else can test it as well. > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: 18.12.01 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list
[ https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036294#comment-17036294 ] Sebastian Berg commented on OFBIZ-10792: As mentioned before configurable products are not added to the shopping cart. Maybe we should implement a notification for the user, that not all products have been added and leave it there. What do you think? > When shopping list is added to cart only one of the item is added to cart > instead of all items in the list > -- > > Key: OFBIZ-10792 > URL: https://issues.apache.org/jira/browse/OFBIZ-10792 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Minor > Attachments: Shopping List.gif > > > Steps to regenerate: > # Open URL [https://demo-trunk.ofbiz.apache.org/ > |https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > [ecomseo/editShoppingList|https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > # Create a new shopping list > # Add items in the list > # Click on "Add List To Cart". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10792) When shopping list is added to cart only one of the item is added to cart instead of all items in the list
[ https://issues.apache.org/jira/browse/OFBIZ-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-10792: --- Description: Steps to regenerate: # Open URL [https://demo-trunk.ofbiz.apache.org/ |https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] [ecomseo/editShoppingList|https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] # Create a new shopping list # Add items in the list # Click on "Add List To Cart". was: Steps to regenerate: # Open URL [https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] # Create a new shopping list # Add items in the list # Click on "Add List To Cart". > When shopping list is added to cart only one of the item is added to cart > instead of all items in the list > -- > > Key: OFBIZ-10792 > URL: https://issues.apache.org/jira/browse/OFBIZ-10792 > Project: OFBiz > Issue Type: Bug > Components: ecommerce >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Minor > Attachments: Shopping List.gif > > > Steps to regenerate: > # Open URL [https://demo-trunk.ofbiz.apache.org/ > |https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > [ecomseo/editShoppingList|https://demo-trunk.ofbiz.apache.org/ecomseo/editShoppingList] > # Create a new shopping list > # Add items in the list > # Click on "Add List To Cart". -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11215) Email password is not working
[ https://issues.apache.org/jira/browse/OFBIZ-11215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036284#comment-17036284 ] Sebastian Berg commented on OFBIZ-11215: Hi, I did some testing and for me this works fine on R17. Maybe someone else can test it as well. > Email password is not working > - > > Key: OFBIZ-11215 > URL: https://issues.apache.org/jira/browse/OFBIZ-11215 > Project: OFBiz > Issue Type: Bug >Affects Versions: Release Branch 16.11 >Reporter: Rashi Dhagat >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > Fix For: 18.12.01 > > > Steps to regenerate: > # User should be on the login page > [https://demo-stable.ofbiz.apache.org/ecommerce/control/login] > # Enter username > # Click on email password > Actual: Email is not received. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17036221#comment-17036221 ] Sebastian Berg commented on OFBIZ-10833: Hi, I created a patch containing the missing contentAssoc and the revert so that by updating the child the parent is no longer updated. This should fix the issue. > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: LogCreateContent.txt, OFBIZ-10833.patch, > OFBIZ-10833.patch, cms_addImage.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (OFBIZ-10833) CMS add content not working
[ https://issues.apache.org/jira/browse/OFBIZ-10833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sebastian Berg updated OFBIZ-10833: --- Attachment: OFBIZ-10833.patch > CMS add content not working > --- > > Key: OFBIZ-10833 > URL: https://issues.apache.org/jira/browse/OFBIZ-10833 > Project: OFBiz > Issue Type: Bug > Components: content >Affects Versions: Trunk, 17.12.01 >Reporter: Ingo Wolfmayr >Assignee: Michael Brohl >Priority: Major > Fix For: 17.12.01, 18.12.01 > > Attachments: LogCreateContent.txt, OFBIZ-10833.patch, > OFBIZ-10833.patch, cms_addImage.patch > > > On demo: content --> "CmsSite" --> CMS: > Right click on one of the items to add "New Long Text" or "Image". > After saving the new content: > Edit WebSite CMS For: [] > "There is no Content PUBLISH_POINT for this WebSite!" > Having the same problem on a 17.12 local installation. > h1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
