[jira] [Comment Edited] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608998#comment-16608998 ] Shantanu edited comment on OFBIZ-10510 at 9/10/18 10:48 AM: Closing the issues as the original problem of employee names showing up as NULL on the tree was solved and there are million other things wrong with the whole HR module that need separate threads of their own. was (Author: srivastava): Closing the issues and the original problem of employee names showing up as NULL on the tree was solved and there are million other things wrong with the whole HR module that need separate threads of their own. > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Major > Fix For: 16.11.05 > > Attachments: Company Tree.jpg, Employee Profile.jpg, > HumanResEvents.java, OFBIZ ISSUES-Excel Sheet_V1 (1).xlsx > > > I've created a sample Internal Organisation called "New Department". > Made a position within it called "New Postion". > Then created an Employee named "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shantanu closed OFBIZ-10510. Resolution: Done Fix Version/s: 16.11.05 Closing the issues and the original problem of employee names showing up as NULL on the tree was solved and there are million other things wrong with the whole HR module that need separate threads of their own. > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Major > Fix For: 16.11.05 > > Attachments: Company Tree.jpg, Employee Profile.jpg, > HumanResEvents.java, OFBIZ ISSUES-Excel Sheet_V1 (1).xlsx > > > I've created a sample Internal Organisation called "New Department". > Made a position within it called "New Postion". > Then created an Employee named "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608992#comment-16608992 ] Shantanu commented on OFBIZ-10510: -- Hello everyone, [~deepak.nigam] [~jacques.le.roux] As of today my company has decided to stop using ofbiz as they didnt find the HR module suitable enough to continue working as too many features are missing, incomplete or malfunctioning hence I will no longer be using it either. I'd like to add another Issue that's not mentioned in the List of Issues I provided here. > The salaries of employees don't appear unless they are fulfilling a position > that is directly under the root node. If you shift the same position from > under the root to some other internal organization the salaries will not > appear. It's the case even if you create position and position type > specifically for a particular organization, the salary doesnt appear unless > the position is directly under the root node. Secondly, here's the HumanResEvents.java file I changed in order to display the employee names properly on the HR Tree, in case someone wants to check it out. The location is: ofbiz/applications/humanres/src/main/java/org/apache/ofbiz/humanres/ Paste it there, rebuild. [^HumanResEvents.java] > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Major > Attachments: Company Tree.jpg, Employee Profile.jpg, > HumanResEvents.java, OFBIZ ISSUES-Excel Sheet_V1 (1).xlsx > > > I've created a sample Internal Organisation called "New Department". > Made a position within it called "New Postion". > Then created an Employee named "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shantanu updated OFBIZ-10510: - Attachment: HumanResEvents.java > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Major > Attachments: Company Tree.jpg, Employee Profile.jpg, > HumanResEvents.java, OFBIZ ISSUES-Excel Sheet_V1 (1).xlsx > > > I've created a sample Internal Organisation called "New Department". > Made a position within it called "New Postion". > Then created an Employee named "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16604870#comment-16604870 ] Shantanu commented on OFBIZ-10510: -- [~jacques.le.roux] [~deepak.nigam] Sir, I do not know how to provide a patch, I just started my first job a month back and learning ofbiz HR module is my first task and I encountered this bug and got it fixed. There are a few more issues I've encountered that are a real pain to work with, I've made a list of the Issues, originally it's the document I submitted to my superiors but I'm providing it here too. I'd appreciate if more experienced people could have a look and see if it's really a bug or am I just doing something wrong. Ill provide the Java code I changed that was resulting in names being displayed as NULL in the tree by day after tomorrow when Im at the office. [^OFBIZ ISSUES-Excel Sheet_V1 (1).xlsx] > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Major > Attachments: Company Tree.jpg, Employee Profile.jpg, OFBIZ > ISSUES-Excel Sheet_V1 (1).xlsx > > > I've created a sample Internal Organisation called "New Department". > Made a position within it called "New Postion". > Then created an Employee named "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shantanu updated OFBIZ-10510: - Attachment: OFBIZ ISSUES-Excel Sheet_V1 (1).xlsx > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Major > Attachments: Company Tree.jpg, Employee Profile.jpg, OFBIZ > ISSUES-Excel Sheet_V1 (1).xlsx > > > I've created a sample Internal Organisation called "New Department". > Made a position within it called "New Postion". > Then created an Employee named "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[
https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603882#comment-16603882
]
Shantanu commented on OFBIZ-10510:
--
[~deepak.nigam]
I've solved this issue, there was a bug in the code.
in HumanResEvents.java I made some changes in this method.
private static List> getCurrentEmployeeDetails(Map params) throws GenericEntityException
{
Delegator delegator = (Delegator) params.get("delegator");
String partyId = (String) params.get("partyId");
String onclickFunction = (String) params.get("onclickFunction");
String additionParam = (String) params.get("additionParam");
String hrefString = (String) params.get("hrefString");
String hrefString2 = (String) params.get("hrefString2");
List> responseList = new ArrayList<>();
long emplPosCount;
try {
emplPosCount = EntityQuery.use(delegator).from("EmplPosition")
.where("emplPositionId", partyId).queryCount();
if (emplPosCount > 0) {
String emplId = partyId;
// Changes Get data by partyId => memberId
List emlpfillCtxs =
EntityQuery.use(delegator).from("EmplPositionFulfillment")
.where("emplPositionId", emplId)
.filterByDate().queryList();
if (UtilValidate.isNotEmpty(emlpfillCtxs)) {
for (GenericValue emlpfillCtx : emlpfillCtxs ) {
String memberId = emlpfillCtx.getString("partyId");
GenericValue memCtx =
EntityQuery.use(delegator).from("Person").where("partyId", memberId).queryOne();
String title = "Abc"; //debugging
if (UtilValidate.isNotEmpty(memCtx)) {
String firstname = memCtx.getString("firstName");
String lastname = memCtx.getString("lastName");
if (UtilValidate.isEmpty(lastname)) {
lastname = "";
}
if (UtilValidate.isEmpty(firstname)) {
firstname = "";
}
title = firstname +" "+ lastname;
}
GenericValue memGroupCtx =
EntityQuery.use(delegator).from("PartyGroup").where("partyId",
partyId).queryOne();
if (UtilValidate.isNotEmpty(memGroupCtx)) {
title = memGroupCtx.getString("groupName");
}
Map josonMap = new HashMap();
Map dataMap = new HashMap();
Map dataAttrMap = new HashMap();
Map attrMap = new HashMap();
dataAttrMap.put("onClick", onclickFunction + "('" +
memberId + additionParam + "')");
String hrefStr = hrefString + memberId;
if (UtilValidate.isNotEmpty(hrefString2)) {
hrefStr = hrefStr + hrefString2;
}
dataAttrMap.put("href", hrefStr);
attrMap.put("rel", "P");
attrMap.put("id", memberId);
dataMap.put("title", title);
dataMap.put("attr", dataAttrMap);
josonMap.put("attr",attrMap);
josonMap.put("data", dataMap);
responseList.add(josonMap) ;
}
}
}
} catch (GenericEntityException e) {
e.printStackTrace();
throw new GenericEntityException(e);
}
return responseList;
}
> Employee names appear as "Null" in company tree.
>
>
> Key: OFBIZ-10510
> URL: https://issues.apache.org/jira/browse/OFBIZ-10510
> Project: OFBiz
> Issue Type: Bug
> Components: humanres
>Affects Versions: 16.11.04
>Reporter: Shantanu
>Priority: Blocker
> Labels: beginner, newbie, starter
> Attachments: Company Tree.jpg, Employee Profile.jpg
>
>
> I've created a sample Internal Organisation called "New Department".
> Made a position within it called "New Postion".
> Then created an Employee named "Adi Singh" and added him the "New Postion"
> and Employed in "New Department"
> But in the company tree the name of employee appears as Null.
> Please help.
> I've attached two images showing the issues.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shantanu updated OFBIZ-10510: - Attachment: (was: Untitled.jpg) > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Blocker > Labels: beginner, newbie, starter > Attachments: Company Tree.jpg, Employee Profile.jpg > > > I've created a sample Internal Organisation called "New Department". > Made a position withing in called "New Postion". > Then created an Employee names "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shantanu updated OFBIZ-10510: - Description: I've created a sample Internal Organisation called "New Department". Made a position within it called "New Postion". Then created an Employee named "Adi Singh" and added him the "New Postion" and Employed in "New Department" But in the company tree the name of employee appears as Null. Please help. I've attached two images showing the issues. was: I've created a sample Internal Organisation called "New Department". Made a position withing in called "New Postion". Then created an Employee names "Adi Singh" and added him the "New Postion" and Employed in "New Department" But in the company tree the name of employee appears as Null. Please help. I've attached two images showing the issues. > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Blocker > Labels: beginner, newbie, starter > Attachments: Company Tree.jpg, Employee Profile.jpg > > > I've created a sample Internal Organisation called "New Department". > Made a position within it called "New Postion". > Then created an Employee named "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shantanu updated OFBIZ-10510: - Attachment: Company Tree.jpg Employee Profile.jpg > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Blocker > Labels: beginner, newbie, starter > Attachments: Company Tree.jpg, Employee Profile.jpg, Untitled.jpg > > > I've created a sample Internal Organisation called "New Department". > Made a position withing in called "New Postion". > Then created an Employee names "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (OFBIZ-10510) Employee names appear as "Null" in company tree.
[ https://issues.apache.org/jira/browse/OFBIZ-10510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shantanu updated OFBIZ-10510: - Attachment: (was: 2.jpg) > Employee names appear as "Null" in company tree. > > > Key: OFBIZ-10510 > URL: https://issues.apache.org/jira/browse/OFBIZ-10510 > Project: OFBiz > Issue Type: Bug > Components: humanres >Affects Versions: 16.11.04 >Reporter: Shantanu >Priority: Blocker > Labels: beginner, newbie, starter > Attachments: Company Tree.jpg, Employee Profile.jpg, Untitled.jpg > > > I've created a sample Internal Organisation called "New Department". > Made a position withing in called "New Postion". > Then created an Employee names "Adi Singh" and added him the "New Postion" > and Employed in "New Department" > But in the company tree the name of employee appears as Null. > Please help. > I've attached two images showing the issues. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (OFBIZ-10510) Employee names appear as "Null" in company tree.
Shantanu created OFBIZ-10510: Summary: Employee names appear as "Null" in company tree. Key: OFBIZ-10510 URL: https://issues.apache.org/jira/browse/OFBIZ-10510 Project: OFBiz Issue Type: Bug Components: humanres Affects Versions: 16.11.04 Reporter: Shantanu Attachments: 2.jpg, Untitled.jpg I've created a sample Internal Organisation called "New Department". Made a position withing in called "New Postion". Then created an Employee names "Adi Singh" and added him the "New Postion" and Employed in "New Department" But in the company tree the name of employee appears as Null. Please help. I've attached two images showing the issues. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
