[jira] [Commented] (OFBIZ-11069) Add coalesce to aggregate-function of model view

2019-05-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848557#comment-16848557
 ] 

Shi Jinghai commented on OFBIZ-11069:
-

Hi Jacques and Pierre,

Thanks for the comments and votes!

On the example of sku and product instance, it's more and more common in our 
life, a product has one or two identity code, for example, a mobile has one or 
two IMEI, a computor has a Serial Number, a car has an engine code and a 
VIN(Vehicle Identification Number), a cloth has a RFID and etc. If no 
objection, I'll create a new Jira on this topic.

> Add coalesce to aggregate-function of model view
> 
>
> Key: OFBIZ-11069
> URL: https://issues.apache.org/jira/browse/OFBIZ-11069
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Reporter: Shi Jinghai
>Priority: Trivial
>  Labels: IoT, ModelViewEntity
> Fix For: Trunk
>
> Attachments: ModelViewEntity-function-coalesce.patch
>
>
> While in our IoT case, a product may have a sku product id as well as a 
> productId (product instance) by identified from unique id i.e. an EPC.
> When building operation/inventory reports, to be compatible with previous 
> implement, I have to merge the sku product Id column into the productId 
> column, so comes the coalesce patch. 
> The usage example:
> {code:java}
>  function="coalesce">
> 
> 
> 
> 
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-7954) Add NLP function to parse text content

2019-05-25 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-7954:
---
Component/s: solr

Thank you Pierre! Yes, you're right. I just added solr in the component field. 
:)

> Add NLP function to parse text content
> --
>
> Key: OFBIZ-7954
> URL: https://issues.apache.org/jira/browse/OFBIZ-7954
> Project: OFBiz
>  Issue Type: Improvement
>  Components: solr
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
>  Labels: NER, NLP
>
> NLP(Natural Language Processing) is an amazing tech can help us to improve 
> our beloved OFBiz.
> NLP can be used to train your own model to parse product attributes and 
> understand what it is, before importing the product, or used as an online CRM 
> text robot to answer simple questions.
> We will try to add a new nlp component, and we hope we can get some help from 
> the community.
> AFAIK, two apache projects are working on NLP:
> http://tika.apache.org/
> http://opennlp.apache.org/
> The Stanford NLP is used in tika:
> http://nlp.stanford.edu/
> While implementing this component, we found an ebay paper on this topic is 
> very useful:
> http://aclweb.org/anthology/D/D11/D11-1144.pdf
> Kind Regards,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-11069) Add coalesce to aggregate-function of model view

2019-05-25 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-11069:
---

 Summary: Add coalesce to aggregate-function of model view
 Key: OFBIZ-11069
 URL: https://issues.apache.org/jira/browse/OFBIZ-11069
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Reporter: Shi Jinghai
 Fix For: Trunk
 Attachments: ModelViewEntity-function-coalesce.patch

While in our IoT case, a product may have a sku product id as well as a 
productId (product instance) by identified from unique id i.e. an EPC.

When building operation/inventory reports, to be compatible with previous 
implement, I have to merge the sku product Id column into the productId column, 
so comes the coalesce patch. 

The usage example:
{code:java}






{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-7954) Add NLP function to parse text content

2019-05-25 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-7954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848188#comment-16848188
 ] 

Shi Jinghai commented on OFBIZ-7954:


As solr supported OpenNLP/NER since version 7.3.0 which was released in April 
2018, I'll try to open an example of auto filling a form from parsing a 
copy/pasted text paragraph.

> Add NLP function to parse text content
> --
>
> Key: OFBIZ-7954
> URL: https://issues.apache.org/jira/browse/OFBIZ-7954
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
>  Labels: NER, NLP
>
> NLP(Natural Language Processing) is an amazing tech can help us to improve 
> our beloved OFBiz.
> NLP can be used to train your own model to parse product attributes and 
> understand what it is, before importing the product, or used as an online CRM 
> text robot to answer simple questions.
> We will try to add a new nlp component, and we hope we can get some help from 
> the community.
> AFAIK, two apache projects are working on NLP:
> http://tika.apache.org/
> http://opennlp.apache.org/
> The Stanford NLP is used in tika:
> http://nlp.stanford.edu/
> While implementing this component, we found an ebay paper on this topic is 
> very useful:
> http://aclweb.org/anthology/D/D11/D11-1144.pdf
> Kind Regards,



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10693) ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0

2019-04-12 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816537#comment-16816537
 ] 

Shi Jinghai commented on OFBIZ-10693:
-

I just tried to use 2.0.0 to ofbiz trunk in Fedora 29/openjdk 1.8.0_201-b09, it 
worked. Both 1.5.8.1 and 1.5.9.2 failed.

 
{code:java}
[workspace] $ /bin/sh -xe /tmp/jenkins2331645540419021206.sh
+ /usr/bin/java -version
openjdk version "1.8.0_201"
OpenJDK Runtime Environment (build 1.8.0_201-b09)
OpenJDK 64-Bit Server VM (build 25.201-b09, mixed mode)
+ /usr/bin/sed -i 's/id '\''org.asciidoctor.convert'\'' version 
'\''1.5.8.1'\''/id '\''org.asciidoctor.convert'\'' version '\''2.0.0'\''/g' 
build.gradle
+ /usr/bin/chmod +x gradlew
+ /usr/bin/sh gradlew generateOfbizDocumentation
Starting a Gradle Daemon (subsequent builds will be faster)

> Configure project :
You are using one or more deprecated Asciidoctor task or plugins. To help with 
migration run with --warnings=all

> Task :deleteOfbizDocumentation

> Task :generateOfbizDocumentation
四月 13, 2019 1:55:30 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
473: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:473
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse)
四月 13, 2019 1:55:30 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
511: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:511
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse)

四月 13, 2019 1:55:50 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse_table
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
473: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:473
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse_table)
四月 13, 2019 1:55:50 上午 
uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb parse_table
警告: ../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc: line 
511: unterminated listing block
unterminated listing block :: 
../../framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc :: 
/var/lib/jenkins/jobs/OFBiz Document 
Generation/workspace/framework/minilang/docs/asciidoc//var/lib/jenkins/jobs/OFBiz
 Document 
Generation/workspace/framework/minilang/docs/asciidoc/minilang-to-groovy-manual.adoc:511
 (uri:classloader:/gems/asciidoctor-1.5.8/lib/asciidoctor/parser.rb:parse_table)

BUILD SUCCESSFUL in 55s
2 actionable tasks: 2 executed

Finished: SUCCESS
{code}
 

> ‘./gradlew generateOfbizDocumentation’ fails with Gradle 5.0
> 
>
> Key: OFBIZ-10693
> URL: https://issues.apache.org/jira/browse/OFBIZ-10693
> Project: OFBiz
>  Issue Type: Bug
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Major
> Fix For: 17.12.01
>
> Attachments: 
> OFBIZ-10693_Fix-AsciiDoctor-tasks-by-downgrading-corresponding-G.patch
>
>
> We recently upgraded Gradle 3.2.1 → 5.0. The {{./gradlew 
> generateOfbizDocumentation}} command fails with the following stacktrace
> {code:java}
> > Task :deleteOfbizDocumentation
> > Task :generateOfbizDocumentation FAILED
> Exception in thread "main" java.lang.ExceptionInInitializerError
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.(InvokerHelper.java:86)
>   at 
> groovy.lang.GroovyObjectSupport.getDefaultMetaClass(GroovyObjectSupport.java:59)
>   at groovy.lang.GroovyObjectSupport.(GroovyObjectSupport.java:32)
>   at groovy.lang.Reference.(Reference.java:38)
>   at 
> org.asciidoctor.gradle.backported.AsciidoctorJavaExec.main(AsciidoctorJavaExec.groovy:188)
> Caused by: groovy.lang.GroovyRuntimeException: Conflicting 

[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-02 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782618#comment-16782618
 ] 

Shi Jinghai commented on OFBIZ-10700:
-

Hi Mathieu,

You are absolutely right.

The only one pro I suggested is that I can see all plugins in plugins, and make 
me easy to check whether any plugin should be upgraded.

Kind Regards,

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-02 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782398#comment-16782398
 ] 

Shi Jinghai commented on OFBIZ-10700:
-

Hi Mathieu,

Brilliant!

I suggest change 
{code:java}
if (project.hasProperty('enableOwasp')) {
plugins {
id 'org.owasp.dependencycheck' version '3.0.2'
}
}{code}
to 
{code:java}
plugins {
...
id "org.owasp.dependencycheck" version "3.0.2" apply false
}

if (project.hasProperty('enableOwasp')) {
apply plugin: 'org.owasp.dependencycheck'
}{code}
What do you think?

Kind Regards,

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10685) Support spring boot as OFBiz webapp

2018-12-02 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-10685:
---

 Summary: Support spring boot as OFBiz webapp
 Key: OFBIZ-10685
 URL: https://issues.apache.org/jira/browse/OFBIZ-10685
 Project: OFBiz
  Issue Type: New Feature
  Components: framework
Affects Versions: Trunk
Reporter: Shi Jinghai
Assignee: Shi Jinghai
 Fix For: Upcoming Branch


[Spring boot|https://spring.io/projects/spring-boot] is popular now, and some 
OFBiz users may want to develop plugins on spring-boot.

As a user mentioned in user mail list, currently OFBiz doesn't support 
spring-boot OOTB.

The main problem is in processing scan jars during each webapp context 
initialization.

I hope we can find a proper solution to resolve this issue as well as 
supporting web.xml in 3.0/3.1, META-INF/context.xml and websocket jar scan.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-12-02 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706440#comment-16706440
 ] 

Shi Jinghai commented on OFBIZ-10655:
-

Committed, rev 1848009.

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: OFBIZ-10655.patch
>
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698692#comment-16698692
 ] 

Shi Jinghai commented on OFBIZ-10655:
-

Hi Jacques,

Yeah, very strange, yesterday, I created the patch with eclipse subclipse 
plugin, I didn't test it locally before uploading.

I just tried to use TortoiseSVN to create a new patch, it's the same as the one 
here.

After applying the patch in my local environment, I have to remove the 
plugins/pricat/src/main/java/org/apache/poi/ manully.

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: OFBIZ-10655.patch
>
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-24 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698073#comment-16698073
 ] 

Shi Jinghai commented on OFBIZ-10655:
-

Hi Jacques,

I moved the OFBizPricatUtil to org.apache.ofbiz.pricat package in the patch, 
please check whether it's right.

Thanks,

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: OFBIZ-10655.patch
>
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-24 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-10655:

Attachment: OFBIZ-10655.patch

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: OFBIZ-10655.patch
>
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package

2018-11-23 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai reassigned OFBIZ-10655:
---

Assignee: Shi Jinghai

> OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
> -
>
> Key: OFBIZ-10655
> URL: https://issues.apache.org/jira/browse/OFBIZ-10655
> Project: OFBiz
>  Issue Type: Bug
>  Components: pricat
>Affects Versions: Trunk, 17.12.01
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Major
>
> Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10592) OutOfMemory and stucked JobPoller issue

2018-11-06 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676970#comment-16676970
 ] 

Shi Jinghai commented on OFBIZ-10592:
-

Inspired by two articles[1][2] recently I read on db automatic tuning, I think 
perhaps we should consider to implement an automatic tuning on OFBiz entity 
engine.

[1] 
[https://docs.microsoft.com/en-us/azure/sql-database/sql-database-automatic-tuning]

[2]https://brage.bibsys.no/xmlui/bitstream/handle/11250/2506148/19718_FULLTEXT.pdf

> OutOfMemory and stucked JobPoller issue
> ---
>
> Key: OFBIZ-10592
> URL: https://issues.apache.org/jira/browse/OFBIZ-10592
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 13.07
> Environment: Two instances Ofbiz installation on two machines, 
> connected to an Apache HTTPD instance which acts as a proxy.
> Request to ofbiz instances are handled and load balanced.
> OFBiz version : 13.07.03 with Multitenant enabled
> OS: Ubuntu Linux 16.04 LTS
> RDBMS: MariaDB v10.1.24
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Critical
> Attachments: alloc_tree_600k_12102018.png, 
> jvm_ofbiz1_profi_telem.png, jvm_prof_ofbiz1_telem2.png, 
> ofbiz1_jvm_profil_nojobpoller.png, recorder_object_600k_12102018.png, 
> telemetry_ovrl_600k_12102018.png
>
>
>  
> This installation is composed by two instances of OFBiz (v13.07.03), served 
> via an Apache Tomcat webserver, along with a load balancer.
> The database server is MariaDB.
>  
> We had the first problems, about 3 weeks ago, when suddenly, the front1 
> (ofbiz instance 1), stopped serving web requests; front2, instead, was still 
> working correctly.
>  
> Obviously we checked the log files, and we saw that async services were 
> failing; the failure was accompanied by this error line:
>  
> *_Thread "AsyncAppender-async" java.lang.OutOfMemoryError: GC overhead limit 
> exceeded_*
>  
> We analyzed the situation with our system specialists, and they told us that 
> the application was highly stressing machine resources (cpu always at or near 
> 100%, RAM usage rapidly increasing), until the jvm run out of memory.
> This "resource-high-consumption situation", occurred only when ofbiz1 
> instance was started with the JobPoller enabled; if the JobPoller was not 
> enabled, ofbiz run with low resource usage. 
>  
> We then focused on the db, to check first of all the dimensions; the result 
> was disconcerting; 45GB, mainly divided on four tables: SERVER_HIT (about 18 
> GB), VISIT (about 15 GB), ENTITY_SYNC_REMOVE (about 8 GB), VISITOR (about 2 
> GB).
> All the other tables had a size in the order of few MB each.
>  
> The first thing we did, was to clear all those tables, reducing considerably 
> the db size.
> After the cleaning, we tried to start ofbiz1 again, with the JobPoller 
> component enabled; this caused a lot of old scheduled/queued jobs, to execute.
> Except than for the start-up time, the resource usage of the machine, 
> stabilized around normal to low values (cpu 1-10%).
> Ofbiz seemed to work (web request was served), but we noticed taht the 
> JobPoller did not schedule or run jobs, anymore. 
> The number of job in "Pending" state in the JobSandbox entity was small 
> (about 20); no Queued, no Failed, no jobs in other states.
> In addition to this, unfortunately, after few hours, jvm run out of memory 
> again.
>  
> Our jvm has an heap maximum size of 20GB ( we have 32GB on the  machine), so 
> it's not so small, I think.
> The next step we're going to do is set-up locally the application over the 
> same production db to see what happens.
>  
> Now that I explained the situation, I am going to ask if, in your 
> opinion/experience:
>  
> Could the JobPoller component be the root (and only) cause of the OutOfMemory 
> of the jvm?
>  
> Could this issue be related to OFBIZ-5710?
>  
> Dumping and analyzing the heap of the jvm could help in some way to 
> understand what or who fills the memory or is this operation a waste of time?
>  
> Is there something that we did not considered or missed during the whole 
> process of problem analysis?
>  
>  
> I really thank you all for your attention and your help; any suggestion or 
> advice would really be greatly appreciated.
>  
> Kind regards,
> Giulio



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10592) OutOfMemory and stucked JobPoller issue

2018-10-15 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650296#comment-16650296
 ] 

Shi Jinghai commented on OFBIZ-10592:
-

Hi Giulio,

The offset-style attribute was introduced by OFBIZ-4346.

You mentioned your ShoppingList table had 600K records, and other services run 
properly, I guess the data fetched by queryList method blocks the connection 
between OFBiz and MariaDB.

Good Luck,

> OutOfMemory and stucked JobPoller issue
> ---
>
> Key: OFBIZ-10592
> URL: https://issues.apache.org/jira/browse/OFBIZ-10592
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 13.07
> Environment: Two instances Ofbiz installation on two machines, 
> connected to an Apache HTTPD instance which acts as a proxy.
> Request to ofbiz instances are handled and load balanced.
> OFBiz version : 13.07.03 with Multitenant enabled
> OS: Ubuntu Linux 16.04 LTS
> RDBMS: MariaDB v10.1.24
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Critical
> Attachments: alloc_tree_600k_12102018.png, 
> jvm_ofbiz1_profi_telem.png, jvm_prof_ofbiz1_telem2.png, 
> ofbiz1_jvm_profil_nojobpoller.png, recorder_object_600k_12102018.png, 
> telemetry_ovrl_600k_12102018.png
>
>
>  
> This installation is composed by two instances of OFBiz (v13.07.03), served 
> via an Apache Tomcat webserver, along with a load balancer.
> The database server is MariaDB.
>  
> We had the first problems, about 3 weeks ago, when suddenly, the front1 
> (ofbiz instance 1), stopped serving web requests; front2, instead, was still 
> working correctly.
>  
> Obviously we checked the log files, and we saw that async services were 
> failing; the failure was accompanied by this error line:
>  
> *_Thread "AsyncAppender-async" java.lang.OutOfMemoryError: GC overhead limit 
> exceeded_*
>  
> We analyzed the situation with our system specialists, and they told us that 
> the application was highly stressing machine resources (cpu always at or near 
> 100%, RAM usage rapidly increasing), until the jvm run out of memory.
> This "resource-high-consumption situation", occurred only when ofbiz1 
> instance was started with the JobPoller enabled; if the JobPoller was not 
> enabled, ofbiz run with low resource usage. 
>  
> We then focused on the db, to check first of all the dimensions; the result 
> was disconcerting; 45GB, mainly divided on four tables: SERVER_HIT (about 18 
> GB), VISIT (about 15 GB), ENTITY_SYNC_REMOVE (about 8 GB), VISITOR (about 2 
> GB).
> All the other tables had a size in the order of few MB each.
>  
> The first thing we did, was to clear all those tables, reducing considerably 
> the db size.
> After the cleaning, we tried to start ofbiz1 again, with the JobPoller 
> component enabled; this caused a lot of old scheduled/queued jobs, to execute.
> Except than for the start-up time, the resource usage of the machine, 
> stabilized around normal to low values (cpu 1-10%).
> Ofbiz seemed to work (web request was served), but we noticed taht the 
> JobPoller did not schedule or run jobs, anymore. 
> The number of job in "Pending" state in the JobSandbox entity was small 
> (about 20); no Queued, no Failed, no jobs in other states.
> In addition to this, unfortunately, after few hours, jvm run out of memory 
> again.
>  
> Our jvm has an heap maximum size of 20GB ( we have 32GB on the  machine), so 
> it's not so small, I think.
> The next step we're going to do is set-up locally the application over the 
> same production db to see what happens.
>  
> Now that I explained the situation, I am going to ask if, in your 
> opinion/experience:
>  
> Could the JobPoller component be the root (and only) cause of the OutOfMemory 
> of the jvm?
>  
> Could this issue be related to OFBIZ-5710?
>  
> Dumping and analyzing the heap of the jvm could help in some way to 
> understand what or who fills the memory or is this operation a waste of time?
>  
> Is there something that we did not considered or missed during the whole 
> process of problem analysis?
>  
>  
> I really thank you all for your attention and your help; any suggestion or 
> advice would really be greatly appreciated.
>  
> Kind regards,
> Giulio



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10592) OutOfMemory and stucked JobPoller issue

2018-10-13 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649268#comment-16649268
 ] 

Shi Jinghai commented on OFBIZ-10592:
-

Thank you Giulio for the details!

I think you can resolve this problem by changing the implement of 
autoDeleteAutoSaveShoppingList to use queryPagedList instead of queryList, 
adding offset-style="limit" to your mariadb datasource in entityengine.xml.

Hope your patch soon :)

> OutOfMemory and stucked JobPoller issue
> ---
>
> Key: OFBIZ-10592
> URL: https://issues.apache.org/jira/browse/OFBIZ-10592
> Project: OFBiz
>  Issue Type: Bug
>  Components: ALL APPLICATIONS
>Affects Versions: Release Branch 13.07
> Environment: Two instances Ofbiz installation on two machines, 
> connected to an Apache HTTPD instance which acts as a proxy.
> Request to ofbiz instances are handled and load balanced.
> OFBiz version : 13.07.03 with Multitenant enabled
> OS: Ubuntu Linux 16.04 LTS
> RDBMS: MariaDB v10.1.24
>Reporter: Giulio Speri
>Assignee: Giulio Speri
>Priority: Critical
> Attachments: alloc_tree_600k_12102018.png, 
> jvm_ofbiz1_profi_telem.png, jvm_prof_ofbiz1_telem2.png, 
> ofbiz1_jvm_profil_nojobpoller.png, recorder_object_600k_12102018.png, 
> telemetry_ovrl_600k_12102018.png
>
>
>  
> This installation is composed by two instances of OFBiz (v13.07.03), served 
> via an Apache Tomcat webserver, along with a load balancer.
> The database server is MariaDB.
>  
> We had the first problems, about 3 weeks ago, when suddenly, the front1 
> (ofbiz instance 1), stopped serving web requests; front2, instead, was still 
> working correctly.
>  
> Obviously we checked the log files, and we saw that async services were 
> failing; the failure was accompanied by this error line:
>  
> *_Thread "AsyncAppender-async" java.lang.OutOfMemoryError: GC overhead limit 
> exceeded_*
>  
> We analyzed the situation with our system specialists, and they told us that 
> the application was highly stressing machine resources (cpu always at or near 
> 100%, RAM usage rapidly increasing), until the jvm run out of memory.
> This "resource-high-consumption situation", occurred only when ofbiz1 
> instance was started with the JobPoller enabled; if the JobPoller was not 
> enabled, ofbiz run with low resource usage. 
>  
> We then focused on the db, to check first of all the dimensions; the result 
> was disconcerting; 45GB, mainly divided on four tables: SERVER_HIT (about 18 
> GB), VISIT (about 15 GB), ENTITY_SYNC_REMOVE (about 8 GB), VISITOR (about 2 
> GB).
> All the other tables had a size in the order of few MB each.
>  
> The first thing we did, was to clear all those tables, reducing considerably 
> the db size.
> After the cleaning, we tried to start ofbiz1 again, with the JobPoller 
> component enabled; this caused a lot of old scheduled/queued jobs, to execute.
> Except than for the start-up time, the resource usage of the machine, 
> stabilized around normal to low values (cpu 1-10%).
> Ofbiz seemed to work (web request was served), but we noticed taht the 
> JobPoller did not schedule or run jobs, anymore. 
> The number of job in "Pending" state in the JobSandbox entity was small 
> (about 20); no Queued, no Failed, no jobs in other states.
> In addition to this, unfortunately, after few hours, jvm run out of memory 
> again.
>  
> Our jvm has an heap maximum size of 20GB ( we have 32GB on the  machine), so 
> it's not so small, I think.
> The next step we're going to do is set-up locally the application over the 
> same production db to see what happens.
>  
> Now that I explained the situation, I am going to ask if, in your 
> opinion/experience:
>  
> Could the JobPoller component be the root (and only) cause of the OutOfMemory 
> of the jvm?
>  
> Could this issue be related to OFBIZ-5710?
>  
> Dumping and analyzing the heap of the jvm could help in some way to 
> understand what or who fills the memory or is this operation a waste of time?
>  
> Is there something that we did not considered or missed during the whole 
> process of problem analysis?
>  
>  
> I really thank you all for your attention and your help; any suggestion or 
> advice would really be greatly appreciated.
>  
> Kind regards,
> Giulio



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-20 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585460#comment-16585460
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Thank you Deepak!

I can reproduce the error now.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch, 
> URL-Error-SelectShipping.png, URL-Error-additem.png
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-15 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai closed OFBIZ-10438.
---
   Resolution: Fixed
Fix Version/s: Trunk

Thanks Mathieu Lirzin for the contribution, and many others great reviews and 
suggestions. Happy to close this issue now.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-10443) Remove org.apache.tomcat.util.net.secure_protocol_version from json output

2018-08-15 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai closed OFBIZ-10443.
---
Resolution: Fixed

> Remove org.apache.tomcat.util.net.secure_protocol_version from json output
> --
>
> Key: OFBIZ-10443
> URL: https://issues.apache.org/jira/browse/OFBIZ-10443
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-10443-CommonEvents-20180626.patch
>
>
> Visit [https://localhost:8443/example/control/createExampleAjax,] in the 
> output json, the 
> org.apache.tomcat.util.net.secure_protocol_version is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (OFBIZ-6858) Solr logging doesn't work

2018-08-10 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai closed OFBIZ-6858.
--
Resolution: Fixed

> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk 
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are 
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level 
> provide any insights.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work

2018-08-10 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16575811#comment-16575811
 ] 

Shi Jinghai commented on OFBIZ-6858:


By changing lucene and solr version to 7.4.0, this issue is gone, both 
[https://localhost:8443/solr/#/~logging] and 
[https://localhost:8443/solr/#/~logging/level] work well, so I close this issue 
now.

Thanks Shawn! Well done.

> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk 
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are 
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level 
> provide any insights.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work

2018-08-09 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574549#comment-16574549
 ] 

Shi Jinghai commented on OFBIZ-6858:


As Solr 7.4 has been released in Jun 27, I'm checking whether this issue could 
be closed.

Solr 7.4 includes NER/ERD, I'll test it if it works for OFBiz-7954 as well.

 

> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk 
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are 
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level 
> provide any insights.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-09 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574370#comment-16574370
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Forgot to say, I use postman plugin in chrome to request the 
https://localhost:8443/webtools/control/ping.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574287#comment-16574287
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Thank you Mathieu! I'm testing these new patches.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch, 
> OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0003-Handle-multiple-request-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-27 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524833#comment-16524833
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Thank you Nicolas!

If Mathieu agree, let's stop here, I'm very happy what Mathieu has done. Great.

Let's discuss whether this improvement is acceptable, whether it would be 
backported to stable branches in devML.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch, 
> OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524609#comment-16524609
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Hi Mathieu,

Your new patches are in rev. 1834465.

I tested them and all 3 cases listed above are OK.

And method="" and method="all" are OK. I insist to support method="" as 
according to the xsd, it's allowed and should be parsed as method="all".  

I'm happy you returned to doGet/doPost, I guess you read this tomcat document 
(the service method tortured me for a while)

https://tomcat.apache.org/tomcat-5.5-doc/servletapi/javax/servlet/http/HttpServlet.html

 
{code:java}
...
There's almost no reason to override the service method. service handles 
standard HTTP requests by dispatching them to the handler methods for each HTTP 
request type (the doXXX methods listed above).
...{code}
I have to say, you're very sensitive and smart. My last beg, could you remove 
the java.util.Optional(since JDK 1.8) to make the patches can be backported to 
OFBiz 14.07?

Kind Regards,

 

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch, 
> OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524442#comment-16524442
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Thank you Mathieu!

Let me test your new patches now.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch, 
> OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch, 
> OFBIZ-10438_0006-Improved-Split-resolveURI-in-two-methods.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10443) Remove org.apache.tomcat.util.net.secure_protocol_version from json output

2018-06-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524441#comment-16524441
 ] 

Shi Jinghai commented on OFBIZ-10443:
-

Hi Jacques,

Thanks for your reviewing. No, it's not a security issue.

> Remove org.apache.tomcat.util.net.secure_protocol_version from json output
> --
>
> Key: OFBIZ-10443
> URL: https://issues.apache.org/jira/browse/OFBIZ-10443
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-10443-CommonEvents-20180626.patch
>
>
> Visit [https://localhost:8443/example/control/createExampleAjax,] in the 
> output json, the 
> org.apache.tomcat.util.net.secure_protocol_version is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523370#comment-16523370
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Hi Jacques,

Thanks!

Sure, I'll start a thread after Mathieu submit the refactoring patch.

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-26 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523334#comment-16523334
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

On the refactoring, YES please.

On the backport, simple, the java.util.stream interfaces are supported since 
JDK 1.8, so the implement can be merged into OFBiz 16.11 and 17.12. That's what 
I mean. :)

Kind Regards,

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10443) Remove org.apache.tomcat.util.net.secure_protocol_version from json output

2018-06-25 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-10443:

Attachment: OFBIZ-10443-CommonEvents-20180626.patch

> Remove org.apache.tomcat.util.net.secure_protocol_version from json output
> --
>
> Key: OFBIZ-10443
> URL: https://issues.apache.org/jira/browse/OFBIZ-10443
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-10443-CommonEvents-20180626.patch
>
>
> Visit [https://localhost:8443/example/control/createExampleAjax,] in the 
> output json, the 
> org.apache.tomcat.util.net.secure_protocol_version is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10443) Remove org.apache.tomcat.util.net.secure_protocol_version from json output

2018-06-25 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-10443:
---

 Summary: Remove org.apache.tomcat.util.net.secure_protocol_version 
from json output
 Key: OFBIZ-10443
 URL: https://issues.apache.org/jira/browse/OFBIZ-10443
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Shi Jinghai
Assignee: Shi Jinghai


Visit [https://localhost:8443/example/control/createExampleAjax,] in the output 
json, the 

org.apache.tomcat.util.net.secure_protocol_version is unnecessary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-25 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16523079#comment-16523079
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Hi Mathieu,

I submitted your patches in rev. 1834389. I made 3 small changes:
 # Added a matchRequestMethod method in service of ControlServlet.java to check 
whether the method configured in request-map matches the HttpServletRequest 
method.
 # Added support method="" same as method="all".
 # Narrowed the methods supported to GET or POST only as the original 
ControlServlet did.

If you check my modifications ok, I'll backport it to other versions JDK >= 1.8 
and close this issue.

Appreciate your help. Well done!

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-22 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16520061#comment-16520061
 ] 

Shi Jinghai commented on OFBIZ-10438:
-

Hi Mathieu,

Amazing to see your patches, great work!

While I tested them in the following 3 cases, case 1 is OK, case 2 and 3 are 
not OK:

*CASE 1*: Loading and parsing speed of controller.xml:

The loading and parsing speeds with or without your patch in my local 
environment are same.

 

*CASE 2*: Error message when method not match:
 a. edit framework/webtools/webapp/webtools/WEB-INF/controller.xml, add 
method="post" to ping uri
{code:java}





{code}
b. visit [https://localhost:8443/webtools/control/ping] in browser
 c. error message:
{code:java}
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
[ping]; this request does not exist or cannot be called directly.{code}
 

*CASE 3*: Without /control in uri (when we build openapi, we hope the uri can 
be as clean as possible):
 a. edit framework/webtools/webapp/webtools/WEB-INF/web.xml:
{code:java}
// add /ping to allowedPaths

allowedPaths

/ping:/ping.txt:/error:/control:/select:/index.html:/index.jsp:/default.html:/default.jsp


// change ControlServlet from /control/* to /*

ControlServlet
/*

{code}
b. edit framework/webtools/webapp/webtools/WEB-INF/controller.xml, remove 
method="post" from ping uri

c. visit [https://localhost:8443/webtools/ping] in browser

d. PONG is displayed correctly

e. edit framework/webtools/webapp/webtools/WEB-INF/controller.xml, add 
method="post" to ping uri

f. visit [https://localhost:8443/webtools/ping] in browser

g. error message:
{code:java}
ERROR in error page, (infinite loop or error page not found with name 
[/error/error.jsp]), but here is the text just in case it helps you: 
org.apache.ofbiz.webapp.control.RequestHandlerException: Unknown request 
[ping]; this request does not exist or cannot be called directly.
{code}
Maybe case 3 is out of scope of this issue, you can ignore it.

 

Kind Regards,

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-21 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai reassigned OFBIZ-10438:
---

Assignee: Shi Jinghai

> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: 
> OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch, 
> OFBIZ-10438_0002-Improved-Add-optional-method-attribute-in-request-ma.patch, 
> OFBIZ-10438_0003-Improved-Factorize-default-request-search-in-Request.patch, 
> OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch
>
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-20 Thread Shi Jinghai (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-10438:

Description: 
As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter 
what request it is.

I like Mathieu's comment on adding a method attribute to the request-map 
element, it's almost the same as we implemented in our openapi:

 
{code:java}

   
   
   
   

{code}


 The difference is that we DON'T support method list expression:
{code:java}
...
{code}

  

 

  was:
As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter 
what request it is.

I like Mathieu's comment on adding a method attribute to the request-map 
element, it's almost the same as we implemented in our openapi:
            

The difference is that we DON'T support method list expression:
...
 


> Add method attribute to request-map to controll a uri can be called GET or 
> POST only
> 
>
> Key: OFBIZ-10438
> URL: https://issues.apache.org/jira/browse/OFBIZ-10438
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Priority: Minor
>
> As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no 
> matter what request it is.
> I like Mathieu's comment on adding a method attribute to the request-map 
> element, it's almost the same as we implemented in our openapi:
>  
> {code:java}
> 
>    
>    
>    
>    
> 
> {code}
>  The difference is that we DON'T support method list expression:
> {code:java}
> ...
> {code}
>   
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-06-20 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-10438:
---

 Summary: Add method attribute to request-map to controll a uri can 
be called GET or POST only
 Key: OFBIZ-10438
 URL: https://issues.apache.org/jira/browse/OFBIZ-10438
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Shi Jinghai


As discussed in OFBIZ-4274, OFBiz runs doGet method in ControlServlet no matter 
what request it is.

I like Mathieu's comment on adding a method attribute to the request-map 
element, it's almost the same as we implemented in our openapi:
            

The difference is that we DON'T support method list expression:
...
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10410) Refactor `JavaEventHandler` class

2018-05-24 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16488619#comment-16488619
 ] 

Shi Jinghai commented on OFBIZ-10410:
-

Thank you Mathieu!

I'm not sure whether the get/post method attribute of request-map is included 
in this issue scope, I saw you mentioned it in your comment in OFBIZ-4274.

> Refactor `JavaEventHandler` class
> -
>
> Key: OFBIZ-10410
> URL: https://issues.apache.org/jira/browse/OFBIZ-10410
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Attachments: OFBIZ-10410-refactor-java-event-handler.patch
>
>
> Instead of relying on manual synchronisation, use a concurrent map for 
> caching loaded classes.  Inline private `invoke` delegate which intent was 
> fuzzy.  Spread arguments when calling `Method::invoke` and `Class::getMethod`.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-4274) Implement a REST Servlet

2018-05-16 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16478390#comment-16478390
 ] 

Shi Jinghai commented on OFBIZ-4274:


Yes, swagger is suitable for api document. We're using swagger as api document. 
As trying to contribute a webpos2 component, I'm cleaning the api and 
translating the document into English. Our swagger doc in yaml format, it's 
more convenient than json format. We haven't used swagger as a validator until 
now.

The only problem I met is on expressing OFBiz auth, I don't know how to define 
a http or https path in openapi spec. 

!swagger-pos-openapi.png!

> Implement a REST Servlet
> 
>
> Key: OFBIZ-4274
> URL: https://issues.apache.org/jira/browse/OFBIZ-4274
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Adrian Crum
>Priority: Minor
>  Labels: REST
> Attachments: RestExampleSchema.xsd, RestXmlRepresentation.xml, 
> rest-conf.xml, swagger-pos-openapi.png
>
>
> Implement a REST servlet that will map REST requests to OFBiz services. 
> Details are in the comments.
> [here is the discussion which took place on the dev 
> ML|http://markmail.org/message/ai6q2fbksowaayn4]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-4274) Implement a REST Servlet

2018-05-16 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-4274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-4274:
---
Attachment: swagger-pos-openapi.png

> Implement a REST Servlet
> 
>
> Key: OFBIZ-4274
> URL: https://issues.apache.org/jira/browse/OFBIZ-4274
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: Adrian Crum
>Priority: Minor
>  Labels: REST
> Attachments: RestExampleSchema.xsd, RestXmlRepresentation.xml, 
> rest-conf.xml, swagger-pos-openapi.png
>
>
> Implement a REST servlet that will map REST requests to OFBiz services. 
> Details are in the comments.
> [here is the discussion which took place on the dev 
> ML|http://markmail.org/message/ai6q2fbksowaayn4]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work

2018-05-06 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465193#comment-16465193
 ] 

Shi Jinghai commented on OFBIZ-6858:


Thank you Shawn!

Great news.

> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
>Priority: Major
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk 
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are 
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level 
> provide any insights.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10137) Order : Communication between customer and product store

2018-01-15 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326732#comment-16326732
 ] 

Shi Jinghai commented on OFBIZ-10137:
-

Hi Julien,

I uploaded a screenshot of our CRM system based on OFBiz and Asterisk. Please 
ignore the English words as it's used in Chinese. There's a Service Direction 
Indicator to indicate a communication is IN or OUT.

Kind Regards,

> Order : Communication between customer and product store
> 
>
> Key: OFBIZ-10137
> URL: https://issues.apache.org/jira/browse/OFBIZ-10137
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
> Attachments: ServiceDirectionIndicator.png
>
>
> We are working for a customer to add a communication management linked to 
> orders between the customer and the product store.
> It will use communication events and add a new communication screenlet at the 
> bottom of the order screen of the back office.
> We plan to commit modifications to the trunk.
> If anybody have some suggestions about this point, don't hesitate to share, 
> we will be pleased to fit to the community recommendations. 
> The discussion started here: http://markmail.org/message/hq2zfmy3zyqefm6v



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-10137) Order : Communication between customer and product store

2018-01-15 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-10137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-10137:

Attachment: ServiceDirectionIndicator.png

> Order : Communication between customer and product store
> 
>
> Key: OFBIZ-10137
> URL: https://issues.apache.org/jira/browse/OFBIZ-10137
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: Trunk
>Reporter: Julien NICOLAS
>Assignee: Julien NICOLAS
>Priority: Minor
> Attachments: ServiceDirectionIndicator.png
>
>
> We are working for a customer to add a communication management linked to 
> orders between the customer and the product store.
> It will use communication events and add a new communication screenlet at the 
> bottom of the order screen of the back office.
> We plan to commit modifications to the trunk.
> If anybody have some suggestions about this point, don't hesitate to share, 
> we will be pleased to fit to the community recommendations. 
> The discussion started here: http://markmail.org/message/hq2zfmy3zyqefm6v



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (OFBIZ-9233) Enable a service to run by a specific service engine

2018-01-11 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-9233:
---
Attachment: OFBIZ-9233-20180111.patch

In the OFBIZ-9233-20180111.patch, a new attribute "service-engine-name" is 
introduced to service element in service define file, i.e. in 
framework/service/servicedef/services_test_serviceengine_specific.xml:

{code:xml}


http://www.w3.org/2001/XMLSchema-instance;
xsi:noNamespaceSchemaLocation="../dtd/services.xsd">
Test services run on the "specific" service 
engine


Test "specific" service engine.





{code}

This service-engine-name value will be set to every services defined in the 
file, this makes it simple to change a service running pool dynamically in the 
future.

When running an async service in scheduler, if the poolId is wrong configured 
according to current service define, the poolId in JobSandbox can be 
automatically changed. The sample is the jobId="TestJSSOnDefault" in 
framework/service/testdef/data/MultiServiceEngineScheduledServiceData.xml.

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-9233-20170301.patch, OFBIZ-9233-20170413.patch, 
> OFBIZ-9233-20180111.patch, OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7034) Showing QRCodes in PDF

2018-01-09 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-7034:
---
Attachment: barcode4j-trunk-fop-ext-complete-zxing1.7-jdk6.jar

This jar can be used to replace barcode4j-fop-ext-complete-2.1.jar in former 
OFBiz versions and works with zxing 1.7 to output qrcode in fop.

> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-fop-ext-complete-zxing1.7-jdk6.jar, 
> barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine

2018-01-07 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315569#comment-16315569
 ] 

Shi Jinghai commented on OFBIZ-9233:


I'm working on this issue, I'll try to create a new patch to comply with the 
new pattern Nicolas mentioned.

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-9233-20170301.patch, OFBIZ-9233-20170413.patch, 
> OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work

2018-01-07 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315560#comment-16315560
 ] 

Shi Jinghai commented on OFBIZ-6858:


Yes, we can wait a little bit but I'm afraid it would be similar to the qr case 
of barcode4j, one year later, it's still no change.

I'm willing to try SOLR-7887 this week.


> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk 
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are 
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level 
> provide any insights.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-6858) Solr logging doesn't work

2018-01-05 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312860#comment-16312860
 ] 

Shi Jinghai commented on OFBIZ-6858:


I played this issue today. 

OFBiz uses Log4J2 directly for logging, Solr uses SLF4J. According to the 
document from SLF4J (https://www.slf4j.org/legacy.html), SLF4J can be bound to 
Log4J. Log4J is end of life, Solr doesn't upgrade to Log4J2 until now (see 
SOLR-7887 for details).

Here are the steps to make Solr log working in OFBiz trunk:
1. Comment out  log4j-1.2-api and log4j-slf4j-impl in /build.gradle, as 
delegating Solr' logging to Log4J2 wouldn't work.

{code:java}
//runtime 'org.apache.logging.log4j:log4j-1.2-api:2.10.0' // for external 
jars using the old log4j1.2: routes logging to log4j 2
runtime 'org.apache.logging.log4j:log4j-core:2.10.0' // the implementation 
of the log4j 2 API
runtime 'org.apache.logging.log4j:log4j-jul:2.10.0' // for external jars 
using the java.util.logging: routes logging to log4j 2
//runtime 'org.apache.logging.log4j:log4j-slf4j-impl:2.10.0' // for 
external jars using slf4j: routes logging to log4j 2
{code}


2. Add slf4j-api, slf4j-log4j12 and log4j in plugins/solr/build.gradle:

{code:java}
pluginLibsRuntime 'org.slf4j:slf4j-api:1.7.7'
pluginLibsRuntime 'org.slf4j:slf4j-log4j12:1.7.7'
pluginLibsRuntime 'log4j:log4j:1.2.17'
{code}


3. Add log4j.configuration to system properties in /build.gradle:

{code:java}
// java settings
def jvmArguments = ['-Xms128M', '-Xmx1024M', 

'-Dlog4j.configuration=file:///D:/workspaces/OFBiz/ofbiz-framework-trunk/plugins/solr/config/log4j.properties']
{code}


4. Copy log4j.properties from Solr repository 
(https://github.com/apache/lucene-solr/blob/releases/lucene-solr/7.1.0/solr/server/resources/log4j.properties),
 change solr.log to runtime/logs/solr

{code:java}
# rootLogger log level may be programmatically overridden by -Dsolr.log.level
solr.log=runtime/logs/solr
log4j.rootLogger=INFO, file, CONSOLE

# Console appender will be programmatically disabled when Solr is started with 
option -Dsolr.log.muteconsole
log4j.appender.CONSOLE=org.apache.log4j.ConsoleAppender
log4j.appender.CONSOLE.layout=org.apache.log4j.EnhancedPatternLayout
log4j.appender.CONSOLE.layout.ConversionPattern=%d{-MM-dd HH:mm:ss.SSS} 
%-5p (%t) [%X{collection} %X{shard} %X{replica} %X{core}] %c{1.} %m%n

#- size rotation with log cleanup.
log4j.appender.file=org.apache.log4j.RollingFileAppender
log4j.appender.file.MaxFileSize=4MB
log4j.appender.file.MaxBackupIndex=9

#- File to log to and log format
log4j.appender.file.File=${solr.log}/solr.log
log4j.appender.file.layout=org.apache.log4j.EnhancedPatternLayout
log4j.appender.file.layout.ConversionPattern=%d{-MM-dd HH:mm:ss.SSS} %-5p 
(%t) [%X{collection} %X{shard} %X{replica} %X{core}] %c{1.} %m%n

# Adjust logging levels that should differ from root logger
log4j.logger.org.apache.zookeeper=WARN
log4j.logger.org.apache.hadoop=WARN
log4j.logger.org.eclipse.jetty=WARN
log4j.logger.org.eclipse.jetty.server.Server=INFO
log4j.logger.org.eclipse.jetty.server.ServerConnector=INFO

# set to INFO to enable infostream log messages
log4j.logger.org.apache.solr.update.LoggingInfoStream=OFF
{code}

5. Start OFBiz

6. Visit https://localhost:8443/solr/#/~logging and 
https://localhost:8443/solr/#/~logging/level works as expected.


> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
>  Issue Type: Bug
>  Components: solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk 
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are 
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level 
> provide any insights.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine

2018-01-03 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309307#comment-16309307
 ] 

Shi Jinghai commented on OFBIZ-9233:


Thanks Nicolas!

Yes, I agree with you, the relation between service and pool can be defined in 
new files.

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-9233-20170301.patch, OFBIZ-9233-20170413.patch, 
> OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7034) Showing QRCodes in PDF

2018-01-02 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309229#comment-16309229
 ] 

Shi Jinghai commented on OFBIZ-7034:


Hi Jacques,

I gave up modifying barcode4j to implement the 2 functions, as 
org.krysalis.barcode4j.impl.qr.QRLogicImpl has to be changed completely.

Anyway, I think this issue can be closed.

Kind Regards,

> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7034) Showing QRCodes in PDF

2018-01-01 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307609#comment-16307609
 ] 

Shi Jinghai commented on OFBIZ-7034:


Hi Jacques,

I want to add 2 functions currently in our QRCode implement to barcode4j:
1. an element to turn on/off verifying the image generated, i.e. 

{code:java}
true
{code}

2. embed a logo image at the center of QRCode
{code:java}
true
{code}

I'll try to complete this today.

Kind Regards,

> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7034) Showing QRCodes in PDF

2017-12-28 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305229#comment-16305229
 ] 

Shi Jinghai commented on OFBIZ-7034:


Hi Murugeswari,

You can resolve this issue by:
# Download barcode4j-trunk-zxing3.3.1-jdk8.jar in this issue;
# Copy it to ofbiz_home/plugins/example/lib/;
# Start OFBiz;
# Edit ofbiz_home/plugins/example/template/reports/BarCode.fo.ftl, change

{code:java}
  
<#setting url_escaping_charset='UTF-8'>

  
{code}
to
{code:java}
  

  http://barcode4j.krysalis.org/ns; 
message="${example.exampleName!url!'Welcome To Apache OFBiz'}">

  1mm
  UTF-8
  H
  5mm

  

  
{code}

# Visit 
https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01 , 
the QRCode should be able to display correctly.

Have fun :)

Shi Jinghai

> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-7034) Showing QRCodes in PDF

2017-12-28 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-7034:
---
Attachment: barcode4j-trunk-zxing3.3.1-jdk8.jar

This file is built from barcode4j 
(svn://svn.code.sf.net/p/barcode4j/svn/trunk/barcode4j), code slightly adjusted 
with zxing 3.3.1.


> Showing QRCodes in PDF
> --
>
> Key: OFBIZ-7034
> URL: https://issues.apache.org/jira/browse/OFBIZ-7034
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Murugeswari
>Assignee: Shi Jinghai
> Attachments: barcode4j-trunk-zxing3.3.1-jdk8.jar
>
>
> Hi Folks,
>   I have to generate a pdf which should have Barcode as well as QRCode so 
> I followed this one OFBIZ-4154.
>   In trunk version, I run with demo data and tried to create a PDF with 
> QRCode by using this link 
> https://localhost:8443/example/control/ExampleReportPdfBarcode?exampleId=EX01.
>   But it fails to render QRCode but BarCodes are rendered successfully. 
> In console I get following error.
> {code}
>  [java] 2016-05-04 12:29:34,677 |http-nio-8080-exec-5 |ControlServlet 
>|T| [[[qrcode(Domain:http://localhost)] Request Done- 
> total:0.245,since last([qrcode(Domain:ht...):0.245]]
>  [java] 2016-05-04 12:29:34,686 |ttp-nio-8443-exec-17 |FOUserAgent
>|E| Image not available. URI: 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
>  [java] org.apache.xmlgraphics.image.loader.ImageException: The file 
> format is not supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=62AC52C9641B9948F98F73CD0D53DF6B.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
>  [java]   at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
>  [java]   at org.apache.fop.fo.FObj.processNode(FObj.java:129) 
> [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
>  [java]   at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> {code}
> Same thing tested with Release15.12 here also it fails to render QRCode and 
> same exception was caught .



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-7137) ExampleReportPdfOptions no longer works

2017-12-26 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-7137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303651#comment-16303651
 ] 

Shi Jinghai commented on OFBIZ-7137:


Hi Jacques,

I tested the ExampleReportPdfOptions with Chrome, both online 
(https://demo-trunk.ofbiz.apache.org/example/control/ExampleReportPdfOptions?exampleId=EX01)
 and local work fine.

I checked the dependencies of fop, it's org.apache.xmlgraphics:fop:2.2 in 
trunk. The methods are all same as fop 2.0.

The test steps are:

# input "Owner Password" 22, "User Password" 11, "Allow Print" false.
# click "Generate PDF" button, input password 11, click Print button in the 
page, no response.
# return to ExampleReportPdfOptions page and click "Generate PDF" button, input 
password 22, click Print button in the page, Print page popup.

BTW, in Firefox, the Print button always works no matter which password I 
input. :)

I'll check the QRCode problem in OFBIZ-7034.

Kind Regards,

> ExampleReportPdfOptions no longer works
> ---
>
> Key: OFBIZ-7137
> URL: https://issues.apache.org/jira/browse/OFBIZ-7137
> Project: OFBiz
>  Issue Type: Bug
>  Components: example
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Jacques Le Roux
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: Screen Shot 2016-05-30 at 6.39.46 PM.png, Screen Shot 
> 2016-05-30 at 6.40.09 PM.png
>
>
> While working on OFBIZ-7136 "Ugrade PDFBox to 1.8.12 (or 2.0.1?) due to 
> vulnerability" I noticed these PDF options no longer work. This was done with 
> OFBIZ-6504 "how to Create PDF with password Protected in Ofbiz"
> # I did not get any error with ExampleReportPdfOptions but a blank screen. 
> # Here is the error in log for ExampleReportPdfBarcode 
> {code}
> 2016-05-27 14:11:35,737 |http-nio-8443-exec-7 |FOUserAgent   
> |E| Image not available. URI: 
> /example/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201=b
> mp=UTF-8=true=20=20.
>  Reason: org.apache.xmlgraphics.image.loader.ImageException: The file format 
> is not supported. No ImagePreloader found for /examp
> le/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201=bmp=UTF-8=true=20=20
>  (See position 43:308)
> org.apache.xmlgraphics.image.loader.ImageException: The file format is not 
> supported. No ImagePreloader found for 
> /example/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201
> ormat=bmp=UTF-8=true=20=20
> at 
> org.apache.xmlgraphics.image.loader.ImageManager.preloadImage(ImageManager.java:181)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
> at 
> org.apache.xmlgraphics.image.loader.cache.ImageCache.needImageInfo(ImageCache.java:128)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
> at 
> org.apache.xmlgraphics.image.loader.ImageManager.getImageInfo(ImageManager.java:123)
>  ~[xmlgraphics-commons-2.0.1.jar:2.0.1]
> at 
> org.apache.fop.fo.flow.ExternalGraphic.bind(ExternalGraphic.java:81) 
> [fop-2.0.jar:?]
> at org.apache.fop.fo.FObj.processNode(FObj.java:129) [fop-2.0.jar:?]
> at 
> org.apache.fop.fo.FOTreeBuilder$MainFOHandler.startElement(FOTreeBuilder.java:291)
>  [fop-2.0.jar:?]
> at 
> org.apache.fop.fo.FOTreeBuilder.startElement(FOTreeBuilder.java:179) 
> [fop-2.0.jar:?]
> [...]
> 2016-05-27 14:11:36,084 |http-nio-8443-exec-7 |FOUserAgent   
> |E| Image not found. URI: 
> /example/control/qrcode;jsessionid=B15ED8C1DE5124CA1769B8DEBDD8C1BD.jvm1?message=Example%201=bmp
> ncoding=UTF-8=true=20=20. 
> (No context info available)
> 2016-05-27 14:11:36,088 |http-nio-8443-exec-7 |ServerHitBin  
> |I| Visit delegatorName=default, ServerHitBin delegatorName=default
> 2016-05-27 14:11:36,099 |http-nio-8443-exec-7 |ControlServlet
> |T| [[[ExampleReportPdfBarcode(Domain:https://localhost)] Request Done- 
> total:1.131,since last([ExampleReportPdf...):1.131]]
> {code}
> But, as Pierre mentionned in a comment below this is already reported at 
> OFBIZ-7034



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16201303#comment-16201303
 ] 

Shi Jinghai commented on OFBIZ-9829:


Thank you Michael, got it. I'll start a thread on whether it's OK to add this 
redis plugin to codebase.

> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200456#comment-16200456
 ] 

Shi Jinghai commented on OFBIZ-9829:


Hi Michael,

Thank you for your concern!

Redis is a key-value db in memory, which makes it's the fastest way to get/set 
info. In CRM, we can get the customer info when a call in by phone number as 
Redis key, a chat in by openid and etc. In ecommerce systems of China, Redis is 
heavily used in Alibaba, JingDong, 12306, Qunar and many others to support 
rush-hour requests on products, tickets, caches and etc.

I think a Redis plugin would be very helpful to OFBiz. Please see Redis project 
on https://github.com/antirez/redis, it's very popular, over 25,000 stars and 
almost 10,000 forks.

Redis has become an important part of modern infrastructures, Amazon, Azure, 
Twitter, Youtube, SAP, I have to say, almost everybody are supporting it.

I'm sure you'll like it.

Kind Regards,


> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9829) Add a new plugin for the redis

2017-10-11 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200352#comment-16200352
 ] 

Shi Jinghai commented on OFBIZ-9829:


Thank you Haipeng (代海鹏)!

This redis component is in trunk rev. 1811826.

I changed the READ.md to include some introductions on the Redis, Codis and 
Redisson.

And I changed redis port from 19000 to 6379 as well.

BTW, would you please modify the getRedisInfo and setRedisInfo to allow empty 
redis.encrypt.password and plain text values in Redis?

Regards,

> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Assigned] (OFBIZ-9829) Add a new plugin for the redis

2017-10-08 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai reassigned OFBIZ-9829:
--

Assignee: Shi Jinghai

> Add a new plugin for the redis
> --
>
> Key: OFBIZ-9829
> URL: https://issues.apache.org/jira/browse/OFBIZ-9829
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Hadwin Dai
>Assignee: Shi Jinghai
>  Labels: redis
> Attachments: OFBIZ-9829_redis-plugins.patch
>
>
> Redis is an open source (BSD licensed), in-memory data structure store, used 
> as a database, cache and message broker.
> Included services: get data, set data and delete data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9484) Enable webapp's META-INF/context.xml works

2017-07-09 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-9484:
--

 Summary: Enable webapp's META-INF/context.xml works
 Key: OFBIZ-9484
 URL: https://issues.apache.org/jira/browse/OFBIZ-9484
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: 16.11.02
Reporter: Shi Jinghai
Priority: Trivial


Besides the EL error, another problem when deploying Drools-Workbench in OFBiz 
I met is the webapp's META-INF/context.xml not loaded.

Add the following code in 
framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/CatalinaContainer.java
 and drools-wb works fine in OFBiz:

{code:java}
context.addLifecycleListener(new ContextConfig());

// adding webapp's META-INF/context.xml begin
String contextXmlFilePath = new 
StringBuilder().append("file:///").append(location).append("/").append(Constants.ApplicationContextXml).toString();
URL contextXmlUrl = null;
try {
contextXmlUrl = 
FlexibleLocation.resolveLocation(contextXmlFilePath);
contextXmlFilePath = new 
StringBuilder().append(location).append("/").append(Constants.ApplicationContextXml).toString();
File contextXmlFile = FileUtil.getFile(contextXmlFilePath);
if(contextXmlFile.exists() && contextXmlFile.isFile()) { 
// Debug.logInfo(contextXmlFilePath + " found and will be 
loaded.", module);
context.setConfigFile(contextXmlUrl);
}
} catch (MalformedURLException e) {
// Debug.logInfo(contextXmlFilePath+ " not found.", module);
}
// add webapp's META-INF/context.xml end

Tomcat.initWebappDefaults(context);
{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (OFBIZ-9483) Enable EL in OFBiz

2017-07-09 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-9483:
--

 Summary: Enable EL in OFBiz
 Key: OFBIZ-9483
 URL: https://issues.apache.org/jira/browse/OFBIZ-9483
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: 16.11.02
Reporter: Shi Jinghai
Assignee: Shi Jinghai
Priority: Trivial


While deploying CAS and Drools-Workbench in OFBiz 16.11.02, the pages with EL 
report error messages:
 
{code:java}
java.lang.NullPointerException
javax.el.CompositeELResolver.add(CompositeELResolver.java:117)
org.apache.jasper.el.JasperELResolver.add(JasperELResolver.java:70)
org.apache.jasper.el.JasperELResolver.(JasperELResolver.java:58)

org.apache.jasper.runtime.JspApplicationContextImpl.createELResolver(JspApplicationContextImpl.java:120)

org.apache.jasper.runtime.JspApplicationContextImpl.createELContext(JspApplicationContextImpl.java:89)

org.apache.jasper.runtime.PageContextImpl.getELContext(PageContextImpl.java:949)

org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:934)

org.apache.jsp.WEB_002dINF.view.jsp.default_.ui.casGenericSuccessView_jsp._jspService(casGenericSuccessView_jsp.java:152)
{code}


According to the doc of javax.el.ExpressionFactorym 
(http://docs.oracle.com/javaee/6/api/javax/el/ExpressionFactory.html):

{code:java}
Creates a new instance of a ExpressionFactory?. This method uses the following 
ordered lookup procedure to determine the ExpressionFactory? implementation 
class to load: 
•Use the Services API (as detailed in the JAR specification). If a resource 
with the name of META-INF/services/javax.el.ExpressionFactory? exists, then its 
first line, if present, is used as the UTF-8 encoded name of the implementation 
class. 
•Use the properties file "lib/el.properties" in the JRE directory. If this file 
exists and it is readable by the java.util.Properties.load(InputStream?) 
method, and it contains an entry whose key is "javax.el.ExpressionFactory?", 
then the value of that entry is used as the name of the implementation class. 
•Use the javax.el.ExpressionFactory? system property. If a system property with 
this name is defined, then its value is used as the name of the implementation 
class. 
•Use a platform default implementation. 

{code}

I added an el.properties in ${jre_home}/lib/, the el.properties has one line:

{code:java}
javax.el.ExpressionFactory=org.apache.el.ExpressionFactoryImpl
{code}

Restarting OFBiz, the error messages are still there, so there is at least a 
META-INF/services/javax.el.ExpressionFactory in runtime jars. It comes to 
'de.odysseus.juel:juel-spi:2.2.7', unzip it, it only contains a 
javax.el.ExpressionFactory file with de.odysseus.el.ExpressionFactoryImpl.

Remove runtime 'de.odysseus.juel:juel-spi:2.2.7' and restart OFBiz, the error 
messages are still there. Unzip 'de.odysseus.juel:juel-impl:2.2.7', an 
OSGI-INF/services.xml found:

{code:java}

http://www.osgi.org/xmlns/scr/v1.1.0;>







{code}

It's easy to get it defines javax.el.ExpressionFactory implemented by 
de.odysseus.el.ExpressionFactoryImpl. Unzip it and create a new jar with 
command:

{code:java}
jar cf juel-impl-no-osgi-2.2.7.jar de/ META-INF/
{code}

Put the juel-impl-no-osgi-2.2.7.jar under ${ofbiz.home}/lib/, change the 
build.gradle:
{code:java}
// compile 'de.odysseus.juel:juel-impl:2.2.7'
compile files('./lib/juel-impl-no-osgi-2.2.7.jar')
{code}

Restart OFBiz, both OFBiz pages and EL pages are ok now.

Stop OFBiz, remove ${jre_home}/lib/el.properties, start OFBiz, EL pages fail. 
Obviously, this fail is caused by no javax.el.ExpressionFactory defined. Add a 
META-INF/javax.el.ExpressionFactory with one line content of 
org.apache.el.ExpressionFactoryImpl in juel-impl-no-osgi-2.2.7.jar.

Restart OFBiz, all OFBiz and EL pages are right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Updated] (OFBIZ-9483) Enable EL in OFBiz

2017-07-09 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-9483:
---
Attachment: juel-impl-no-osgi-2.2.7.jar

The juel-impl-no-osgi-2.2.7.jar mentioned in the description.

> Enable EL in OFBiz
> --
>
> Key: OFBIZ-9483
> URL: https://issues.apache.org/jira/browse/OFBIZ-9483
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL COMPONENTS
>Affects Versions: 16.11.02
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Attachments: juel-impl-no-osgi-2.2.7.jar
>
>
> While deploying CAS and Drools-Workbench in OFBiz 16.11.02, the pages with EL 
> report error messages:
>  
> {code:java}
> java.lang.NullPointerException
>   javax.el.CompositeELResolver.add(CompositeELResolver.java:117)
>   org.apache.jasper.el.JasperELResolver.add(JasperELResolver.java:70)
>   org.apache.jasper.el.JasperELResolver.(JasperELResolver.java:58)
>   
> org.apache.jasper.runtime.JspApplicationContextImpl.createELResolver(JspApplicationContextImpl.java:120)
>   
> org.apache.jasper.runtime.JspApplicationContextImpl.createELContext(JspApplicationContextImpl.java:89)
>   
> org.apache.jasper.runtime.PageContextImpl.getELContext(PageContextImpl.java:949)
>   
> org.apache.jasper.runtime.PageContextImpl.proprietaryEvaluate(PageContextImpl.java:934)
>   
> org.apache.jsp.WEB_002dINF.view.jsp.default_.ui.casGenericSuccessView_jsp._jspService(casGenericSuccessView_jsp.java:152)
> {code}
> According to the doc of javax.el.ExpressionFactorym 
> (http://docs.oracle.com/javaee/6/api/javax/el/ExpressionFactory.html):
> {code:java}
> Creates a new instance of a ExpressionFactory?. This method uses the 
> following ordered lookup procedure to determine the ExpressionFactory? 
> implementation class to load: 
> •Use the Services API (as detailed in the JAR specification). If a resource 
> with the name of META-INF/services/javax.el.ExpressionFactory? exists, then 
> its first line, if present, is used as the UTF-8 encoded name of the 
> implementation class. 
> •Use the properties file "lib/el.properties" in the JRE directory. If this 
> file exists and it is readable by the java.util.Properties.load(InputStream?) 
> method, and it contains an entry whose key is "javax.el.ExpressionFactory?", 
> then the value of that entry is used as the name of the implementation class. 
> •Use the javax.el.ExpressionFactory? system property. If a system property 
> with this name is defined, then its value is used as the name of the 
> implementation class. 
> •Use a platform default implementation. 
> {code}
> I added an el.properties in ${jre_home}/lib/, the el.properties has one line:
> {code:java}
> javax.el.ExpressionFactory=org.apache.el.ExpressionFactoryImpl
> {code}
> Restarting OFBiz, the error messages are still there, so there is at least a 
> META-INF/services/javax.el.ExpressionFactory in runtime jars. It comes to 
> 'de.odysseus.juel:juel-spi:2.2.7', unzip it, it only contains a 
> javax.el.ExpressionFactory file with de.odysseus.el.ExpressionFactoryImpl.
> Remove runtime 'de.odysseus.juel:juel-spi:2.2.7' and restart OFBiz, the error 
> messages are still there. Unzip 'de.odysseus.juel:juel-impl:2.2.7', an 
> OSGI-INF/services.xml found:
> {code:java}
> 
> http://www.osgi.org/xmlns/scr/v1.1.0;>
>   
>   
>   
>   
>   
>   
> 
> {code}
> It's easy to get it defines javax.el.ExpressionFactory implemented by 
> de.odysseus.el.ExpressionFactoryImpl. Unzip it and create a new jar with 
> command:
> {code:java}
> jar cf juel-impl-no-osgi-2.2.7.jar de/ META-INF/
> {code}
> Put the juel-impl-no-osgi-2.2.7.jar under ${ofbiz.home}/lib/, change the 
> build.gradle:
> {code:java}
> // compile 'de.odysseus.juel:juel-impl:2.2.7'
> compile files('./lib/juel-impl-no-osgi-2.2.7.jar')
> {code}
> Restart OFBiz, both OFBiz pages and EL pages are ok now.
> Stop OFBiz, remove ${jre_home}/lib/el.properties, start OFBiz, EL pages fail. 
> Obviously, this fail is caused by no javax.el.ExpressionFactory defined. Add 
> a META-INF/javax.el.ExpressionFactory with one line content of 
> org.apache.el.ExpressionFactoryImpl in juel-impl-no-osgi-2.2.7.jar.
> Restart OFBiz, all OFBiz and EL pages are right.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (OFBIZ-9390) Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, OAuth2LinkedIn and LinkedInUser entities.

2017-06-08 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16042345#comment-16042345
 ] 

Shi Jinghai commented on OFBIZ-9390:


Thanks Renuka!

I agree with you, your patch is in rev. 1798029. Please check if it's right.

> Screen broken on click ThirdPartyLogin, OAuth2GitHub, GitHubUser, 
> OAuth2LinkedIn and LinkedInUser entities.
> ---
>
> Key: OFBIZ-9390
> URL: https://issues.apache.org/jira/browse/OFBIZ-9390
> Project: OFBiz
>  Issue Type: Bug
>  Components: passport
>Affects Versions: Trunk
>Reporter: Renuka Srishti
>Assignee: Renuka Srishti
> Attachments: OFBIZ-9390.patch, OFBiz9390.png
>
>
> PassportEntityLabels does not exist, but its reference is used in 
> passport/entitydef/entitymodel.xml



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-05-11 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006190#comment-16006190
 ] 

Shi Jinghai commented on OFBIZ-8316:


Yes, Pengan and me are in the same team. Pengan gave me the patch face to face 
a week ago. I'm a bit late to check them in. :)

I removed the comments related to this issue in rev. 1794801.

On the "runtime/indexes/products", the "products" index name is hardcoded in 
plugins/lucene/src/main/java/org/apache/ofbiz/content/search/SearchServices.java:
DocumentIndexer indexer = DocumentIndexer.getInstance(delegator, "products");


> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-05-10 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005852#comment-16005852
 ] 

Shi Jinghai commented on OFBIZ-8316:


Thanks Cao Pengan for the new 6.5.1 patch! I have submitted it to 
plugins-trunk, rev.1794770, 1794771.

Cheers,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-04-27 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987878#comment-15987878
 ] 

Shi Jinghai commented on OFBIZ-8316:


Thanks Michael. Go go go :)

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-04-23 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980412#comment-15980412
 ] 

Shi Jinghai commented on OFBIZ-8316:


Thanks Jacques for the ping!

I discussed the solr component upgrade with Pengan last Tuesday, he suggested 
waiting solr 6.5.1 as it is in the procedure of release voting. I just checked 
the status, it's in RC2 now:
https://dist.apache.org/repos/dist/dev/lucene/lucene-solr-6.5.1-RC2-revcd1f23c63abe03ae650c75ec8ccb37762806cc75

I guess the 6.5.1 will be final released before May 1.

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-04-08 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962009#comment-15962009
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Jacques,

Thanks for the ping!

Happy to see Lucene/Solr 6.5.0 has released. I changed lucene and solr from 
6.2.1 to 6.5.0, ProductDocument.java to use LongPoint and DoublePoint locally, 
it works great fine now.

I'll ask Pengan to upgrade all the files (including html and js files) to 6.5.0 
and submit a new patch when we meet next Tuesday.

Cheers,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2017-03-26 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15942334#comment-15942334
 ] 

Shi Jinghai commented on OFBIZ-9123:


Thank you Jacques for the reopen, and thanks Pierre and Michael for the code 
review and suggestion!

I submitted the changes in rev. 1788744, please check if it's ok now.

Kind Regards,

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-9233) Enable a service to run by a specific service engine

2017-03-02 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891928#comment-15891928
 ] 

Shi Jinghai commented on OFBIZ-9233:


Hi Jacques,

Thanks for your reviewing! Very appreciated.

BTW, I didn't change the service-config.xsd, it allows multiple elements of 
service-engine in serviceengine.xml, so it's ok.

Yeah, I should write more test cases :(, for example, poolId in JobSandbox can 
be corrected to the one in the service configuration automatically.

Kind Regards,

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-9233-20170301.patch, 
> OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9233) Enable a service to run by a specific service engine

2017-03-01 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-9233:
---
Attachment: OFBIZ-9233-20170301.patch

This patch implemented multi-service-engine functions.

It introduces a new attribute to service define: service-engine-name. If it's 
not set, the default service-engine will be used, i.e.

Test default service engine name.





if set, the assigned service-engine will used, i.e.

Test specific service engine name.





The example services aboved are in 2 new test cases: testJavaDefaultInvocation 
and testJavaSpecificInvocation, run
./gradlew "ofbiz --test component=service"
 to check whether the services run by different service engines and with 
different poolIds.

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-9233-20170301.patch, 
> OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Assigned] (OFBIZ-9233) Enable a service to run by a specific service engine

2017-02-27 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai reassigned OFBIZ-9233:
--

Assignee: Shi Jinghai

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Updated] (OFBIZ-9233) Enable a service to run by a specific service engine

2017-02-27 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-9233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-9233:
---
Attachment: OFBIZ-9233-MultiServiceEnginesEnv.png

Environment of multiple service engines.

> Enable a service to run by a specific service engine
> 
>
> Key: OFBIZ-9233
> URL: https://issues.apache.org/jira/browse/OFBIZ-9233
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-9233-MultiServiceEnginesEnv.png
>
>
> Currently, all of the services of OFBiz are run by the 'default' service 
> engine.
> In a project, we have to make a service run by different service engines 
> rather than the 'default' one, i.e. order services run by 'order' service 
> engine and 'orderpool', shipment services run by 'shipment' service engine 
> and 'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (OFBIZ-9233) Enable a service to run by a specific service engine

2017-02-27 Thread Shi Jinghai (JIRA)
Shi Jinghai created OFBIZ-9233:
--

 Summary: Enable a service to run by a specific service engine
 Key: OFBIZ-9233
 URL: https://issues.apache.org/jira/browse/OFBIZ-9233
 Project: OFBiz
  Issue Type: Improvement
  Components: framework
Affects Versions: Trunk
Reporter: Shi Jinghai
Priority: Minor
 Fix For: Trunk


Currently, all of the services of OFBiz are run by the 'default' service engine.

In a project, we have to make a service run by different service engines rather 
than the 'default' one, i.e. order services run by 'order' service engine and 
'orderpool', shipment services run by 'shipment' service engine and 
'shipmentpool'.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-02-13 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865123#comment-15865123
 ] 

Shi Jinghai commented on OFBIZ-8316:


I have tested Lucene/Solr 6.4.1, the error on wrapping point fields is still 
there. I'll wait their next release and try again.

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: lucene, solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-24 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15837120#comment-15837120
 ] 

Shi Jinghai commented on OFBIZ-8316:


A temp fix is submitted in rev. 1780133.

To caopengan:

Hi Pengan,

It would be great if you can change the products and content indexes folder 
structure like:
runtime/indexes/products/index
runtime/indexes/products/snapshot_metadata
runtime/indexes/products/tlog

runtime/indexes/content/index
runtime/indexes/content/snapshot_metadata
runtime/indexes/content/tlog

TIA,


> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-21 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832926#comment-15832926
 ] 

Shi Jinghai commented on OFBIZ-8316:


Yesterday, I played indexProduct method of ProductDocument.java for several 
hours with
clean build loadDefault :ofbiz.

The problem that products index cannot be loaded turns out to be caused by 
LongPoint and DoublePoint fields, comment out the fields related to these two 
methods used in indexProduct, everything will be ok.

Today, I'll check further why the LongPoint and DoublePoint fields cannot work 
in our project environment (they are correct in solr test cases i.e. 
TestFieldCacheSort.java).


> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Shi Jinghai
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Issue Comment Deleted] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-10 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai updated OFBIZ-8316:
---
Comment: was deleted

(was: Hi Jacques,

Sorry, I'm totally wrong. Today Cao Pengan helped me to reproduce the error you 
found locally. It's the products index couldn't be recogonized by solr after 
running loadDefault.

I don't know why, but the content index is OK (the content index can be 
generated by running test lucene component). Setting it as solrdefault in 
runtime/indexes/index.properties: index=content, start ofbiz, in this case solr 
works fine.

We'll try to find how to resolve this problem.

Kind Regards,)

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-10 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815323#comment-15815323
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Jacques,

Sorry, I'm totally wrong. Today Cao Pengan helped me to reproduce the error you 
found locally. It's the products index couldn't be recogonized by solr after 
running loadDefault.

I don't know why, but the content index is OK (the content index can be 
generated by running test lucene component). Setting it as solrdefault in 
runtime/indexes/index.properties: index=content, start ofbiz, in this case solr 
works fine.

We'll try to find how to resolve this problem.

Kind Regards,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-10 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15815322#comment-15815322
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Jacques,

Sorry, I'm totally wrong. Today Cao Pengan helped me to reproduce the error you 
found locally. It's the products index couldn't be recogonized by solr after 
running loadDefault.

I don't know why, but the content index is OK (the content index can be 
generated by running test lucene component). Setting it as solrdefault in 
runtime/indexes/index.properties: index=content, start ofbiz, in this case solr 
works fine.

We'll try to find how to resolve this problem.

Kind Regards,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch, 
> solr6.2.1_1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811952#comment-15811952
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Jacques,

On the errors you found, I tested locally and checked our production system, an 
absolute path configed in dataDir of solrconfig.xml would work fine, i.e.

for Windows:
D:/workspaces/OFBiz/ofbiz/runtime/indexes/

for Linux:
/opt/ofbiz/runtime/indexes/

The product index can be loaded correctly and the tlog folder will be under 
runtime/indexes/ as expected.

Kind Regards,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811930#comment-15811930
 ] 

Shi Jinghai commented on OFBIZ-8316:


Unfortunately, I'm a human and programmer, I write codes everyday, and bugs 
everyday.

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-09 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15811768#comment-15811768
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Michael,

Thanks for the reminding! Really appreciate it.

I didn't notice the errors Jacques found, now I find it while visiting 
https://ofbiz-vm2.apache.org:8443/solr/, I'm sure it's a problem of dataDir in 
solrconfig.xml. I'm fixing it.

I have asked PengAn to submit a patch to remove the deprecated UI files 
tomorrow, and he promised me OK. If the patch come, we can keep . :)

Kind Regards,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-02 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793747#comment-15793747
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi PengAn,

It would great if you can remove the "original UI" files of solr and submit a 
patch on it. The original UI is deprecated, right?

Thanks,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-02 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15793740#comment-15793740
 ] 

Shi Jinghai commented on OFBIZ-8316:


Hi Michael,

I have run the Lucene test cases locally and successfully:
lucene-tests-data-load took 0.009s
testSearchTermHand took 3.534s

Kind Regards,

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-02 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15792956#comment-15792956
 ] 

Shi Jinghai commented on OFBIZ-8316:


No, I didn't correct the error you mentioned. Let me check it now.

Sorry for my crude submit.

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Assigned] (OFBIZ-6858) Solr logging doesn't work

2017-01-02 Thread Shi Jinghai (JIRA)

 [ 
https://issues.apache.org/jira/browse/OFBIZ-6858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shi Jinghai reassigned OFBIZ-6858:
--

Assignee: Shi Jinghai

> Solr logging doesn't work
> -
>
> Key: OFBIZ-6858
> URL: https://issues.apache.org/jira/browse/OFBIZ-6858
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/solr
>Affects Versions: Trunk, Release Branch 15.12
>Reporter: Pierre Smits
>Assignee: Shi Jinghai
> Attachments: Image2.png
>
>
> When looking at the logging screen in demo-trunk 
> (https://demo-trunk-ofbiz.apache.org/solr/#/~logging) no logging results are 
> shown. Nor does https://demo-trunk-ofbiz.apache.org/solr/#/~logging/level 
> provide any insights.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-02 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15792912#comment-15792912
 ] 

Shi Jinghai commented on OFBIZ-8316:


Oh, the bug on viewing solr log file is OFBIZ-6858. I'll try to work on it 
later.

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8316) Update Apache Solr/Lucene to release 6.2.1

2017-01-02 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15792907#comment-15792907
 ] 

Shi Jinghai commented on OFBIZ-8316:


Thanks Michael and caopengan(曹鹏安) for the contribution!

Your patches are in trunk rev. 1776930.

To caopengan:
Would it possible to add a sample page in solr component, i.e. uri 
/solr/control/sample? Provides several basic functions:
1. search products with productId or product name
2. provide suggestions while user inputing the productId or product name
3. paginate with AngularJS included in Solr 6.2.1

Happy new year.

> Update Apache Solr/Lucene to release 6.2.1
> --
>
> Key: OFBIZ-8316
> URL: https://issues.apache.org/jira/browse/OFBIZ-8316
> Project: OFBiz
>  Issue Type: Improvement
>  Components: specialpurpose/lucene, specialpurpose/solr
>Affects Versions: Trunk
>Reporter: Michael Brohl
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-8316_corrected.patch, 
> ofbiz-truck-lucene-6.2.1.patch, ofbiz-truck-solr-6.2.1.patch
>
>
> According to the announcements in 
> https://lists.apache.org/thread.html/5d2cb1ecbe04c6c40b8eeba3b7f8da586d1271af98c9b07ceee8ada2@%3Cannounce.apache.org%3E
>  and 
> https://lists.apache.org/thread.html/c1269b52229f6bce68399e813b7c6b79eb3f6283ae21bde11c82fc7c@%3Cannounce.apache.org%3E
>  there is a new Solr/Lucene release available.
> This issue takes care of the update.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6963) Single sign-on to OFBiz with CAS

2016-12-20 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763893#comment-15763893
 ] 

Shi Jinghai commented on OFBIZ-6963:


Sorry James,

I misunderstood your comment. Sorry for my bad English.

Personally, I think CAS is the right choice, but the learning curve may be 
steep. The cookie and token implement of CAS is more suitable for OFBiz then 
Tomcat SSO and for further extension.

For example, with CAS + Shiro component, OFBiz can provide a long term token 
(i.e. one month token) specially to Android/iOS APPs, and the token can be 
verified as a bearer in http header.

Kind Regards,

> Single sign-on to OFBiz with CAS
> 
>
> Key: OFBIZ-6963
> URL: https://issues.apache.org/jira/browse/OFBIZ-6963
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>
> OFBiz is made up of several web applications. 
> To allow the user to sign in only once, a unique token value is presented for 
> verification each time the user navigates to an unvisited web application.
> This approach has the following limitations:
> 1) You cannot work with multiple windows, as there is only 1 valid token 
> value at any time and other token values will be invalid in older-opened 
> windows.
> 2) There is a need to refresh the whole page, so that all links will contain 
> the valid token value.
> 3) Not easy to compose a page that get contents from different web 
> applications in OFBiz
> Adding CAS SSO component as a core into OFBiz will remove the limitations 
> mentioned above. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-6963) Single sign-on to OFBiz with CAS

2016-12-20 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-6963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15763613#comment-15763613
 ] 

Shi Jinghai commented on OFBIZ-6963:


Great! Hope to see your patch soon.

CAS SSO is promising, and with Shiro, you can make OFBiz be a OAuth2 provider.

BTW, you can also replace the current externalLoginKey to TGC value.

> Single sign-on to OFBiz with CAS
> 
>
> Key: OFBIZ-6963
> URL: https://issues.apache.org/jira/browse/OFBIZ-6963
> Project: OFBiz
>  Issue Type: Improvement
>  Components: ALL APPLICATIONS
>Affects Versions: Trunk
>Reporter: james yong
>
> OFBiz is made up of several web applications. 
> To allow the user to sign in only once, a unique token value is presented for 
> verification each time the user navigates to an unvisited web application.
> This approach has the following limitations:
> 1) You cannot work with multiple windows, as there is only 1 valid token 
> value at any time and other token values will be invalid in older-opened 
> windows.
> 2) There is a need to refresh the whole page, so that all links will contain 
> the valid token value.
> 3) Not easy to compose a page that get contents from different web 
> applications in OFBiz
> Adding CAS SSO component as a core into OFBiz will remove the limitations 
> mentioned above. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-14 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15748401#comment-15748401
 ] 

Shi Jinghai commented on OFBIZ-9123:


Thank you Jacques! You are my mentor forever :)

No, I haven't installed the client configuration file. I'm installing it now.

Have a nice day,

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731930#comment-15731930
 ] 

Shi Jinghai commented on OFBIZ-9123:


Ha, finally I got the feeling of what you are worrying about. When plugin done, 
I can take back the LDAP, Passport, Pricat and Solr components, move them to 
github. :)

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-12-08 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15731687#comment-15731687
 ] 

Shi Jinghai commented on OFBIZ-9123:


Hi Jacques,

Here's the test case on OFBizPricatUtil:
1. Import the sample pricat file and download it;
2. Comment out the OFBizPricatUtil.formatCommentShape method used in pricat;
3. Rebuild and import the sample pricat file;
4. Download the commented pricat file;
5. Open it in Microsoft Excel, the style of comments is not readable.
6. Open it in OpenOffice or WPS, the style of comments is correct.

Unzip the commented pricat file (.xlsx), compare the files with/without running 
OFBizPricatUtil.formatCommentShape, the difference is in 
xl/drawings/vmlDrawing1.vml file. According to POI document:

In Excel 2007 VML drawings are used to describe properties of cell comments, 
although the spec says that VML is deprecated:
The VML format is a legacy format originally introduced with Office 2000 and is 
included and fully defined in this Standard for backwards compatibility 
reasons. The DrawingML format is a newer and richer format created with the 
goal of eventually replacing any uses of VML in the Office Open XML formats. 
VML should be considered a deprecated format included in Office Open XML for 
legacy reasons only and new applications that need a file format for drawings 
are strongly encouraged to use preferentially DrawingML

Warning - Excel is known to put invalid XML into these files! For example, >br< 
without being closed or escaped crops up.
See 6.4 VML - SpreadsheetML Drawing in Office Open XML Part 4 - Markup Language 
Reference.pdf


By putting OFBizPricatUtil under POI path, I can call the protected method 
XSSFVMLDrawing.findCommentShape and build the comments look right in Microsoft 
Excel.

This is the reason. I'm sure there's a better way to do this.

Kind Regards,

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8537) LoginWorker HashCrypt the type of hash for one-way encryption

2016-12-07 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15728688#comment-15728688
 ] 

Shi Jinghai commented on OFBIZ-8537:


Thank you Junyuan!

Your patch is in rev.1773066. Please check if it's right. If yes, please close 
this issue for now.

You can open a new issue if there's any further improvement such as auto 
upgrading password from SHA/MD5 to PBKDF2 after user logged in successfully.

Kind Regards,

> LoginWorker HashCrypt the type of hash for one-way encryption
> -
>
> Key: OFBIZ-8537
> URL: https://issues.apache.org/jira/browse/OFBIZ-8537
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: wangjunyuan
>Assignee: Shi Jinghai
>Priority: Minor
>  Labels: HashCrypt, PBKDF2, security.properties
> Attachments: HashCrypt.patch, HashCrypt_new.patch
>
>
> PBKDF2 (Password-Based Key Derivation Function 2) is part of RSA 
> Laboratories' Public-Key Cryptography Standards (PKCS) series, specifically 
> PKCS #5 v2.0, also published as Internet Engineering Task Force's RFC 2898. 
> It replaces an earlier key derivation function, PBKDF1, which could only 
> produce derived keys up to 160 bits long.Add this function to ofbiz ,this 
> PBKDF2 has four types in 
> Java:'PBKDF2WithHmacSHA1','PBKDF2WithHmacSHA256','PBKDF2WithHmacSHA384','PBKDF2WithHmacSHA512'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8537) LoginWorker HashCrypt the type of hash for one-way encryption

2016-12-06 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15725615#comment-15725615
 ] 

Shi Jinghai commented on OFBIZ-8537:


Hi Michael,

I have reverted the framework/security/data/PasswordSecurityDemoData.xml.

Kind Regards,

> LoginWorker HashCrypt the type of hash for one-way encryption
> -
>
> Key: OFBIZ-8537
> URL: https://issues.apache.org/jira/browse/OFBIZ-8537
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: wangjunyuan
>Assignee: Shi Jinghai
>Priority: Minor
>  Labels: HashCrypt, PBKDF2, security.properties
> Attachments: HashCrypt.patch
>
>
> PBKDF2 (Password-Based Key Derivation Function 2) is part of RSA 
> Laboratories' Public-Key Cryptography Standards (PKCS) series, specifically 
> PKCS #5 v2.0, also published as Internet Engineering Task Force's RFC 2898. 
> It replaces an earlier key derivation function, PBKDF1, which could only 
> produce derived keys up to 160 bits long.Add this function to ofbiz ,this 
> PBKDF2 has four types in 
> Java:'PBKDF2WithHmacSHA1','PBKDF2WithHmacSHA256','PBKDF2WithHmacSHA384','PBKDF2WithHmacSHA512'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8537) LoginWorker HashCrypt the type of hash for one-way encryption

2016-12-05 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15721830#comment-15721830
 ] 

Shi Jinghai commented on OFBIZ-8537:


Thanks Michael for reviewing and Pierre for the suggestion on password format 
(see https://github.com/hamano/openldap-pbkdf2)!

I'll change flexadmin's password back to SHA as currently the password format 
of PBKDF2 is not complied with RFC standard.

> LoginWorker HashCrypt the type of hash for one-way encryption
> -
>
> Key: OFBIZ-8537
> URL: https://issues.apache.org/jira/browse/OFBIZ-8537
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: wangjunyuan
>Assignee: Shi Jinghai
>Priority: Minor
>  Labels: HashCrypt, PBKDF2, security.properties
> Attachments: HashCrypt.patch
>
>
> PBKDF2 (Password-Based Key Derivation Function 2) is part of RSA 
> Laboratories' Public-Key Cryptography Standards (PKCS) series, specifically 
> PKCS #5 v2.0, also published as Internet Engineering Task Force's RFC 2898. 
> It replaces an earlier key derivation function, PBKDF1, which could only 
> produce derived keys up to 160 bits long.Add this function to ofbiz ,this 
> PBKDF2 has four types in 
> Java:'PBKDF2WithHmacSHA1','PBKDF2WithHmacSHA256','PBKDF2WithHmacSHA384','PBKDF2WithHmacSHA512'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8537) LoginWorker HashCrypt the type of hash for one-way encryption

2016-12-04 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15720956#comment-15720956
 ] 

Shi Jinghai commented on OFBIZ-8537:


Thank you Junyuan!

Your patch is in rev.1772589. I changed currentPassword from short-varchar to 
long-varchar as a PBKDF2 hashed password is longer than 60 charactors.

> LoginWorker HashCrypt the type of hash for one-way encryption
> -
>
> Key: OFBIZ-8537
> URL: https://issues.apache.org/jira/browse/OFBIZ-8537
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: wangjunyuan
>Assignee: Shi Jinghai
>Priority: Minor
>  Labels: HashCrypt, PBKDF2, security.properties
> Attachments: HashCrypt.patch
>
>
> PBKDF2 (Password-Based Key Derivation Function 2) is part of RSA 
> Laboratories' Public-Key Cryptography Standards (PKCS) series, specifically 
> PKCS #5 v2.0, also published as Internet Engineering Task Force's RFC 2898. 
> It replaces an earlier key derivation function, PBKDF1, which could only 
> produce derived keys up to 160 bits long.Add this function to ofbiz ,this 
> PBKDF2 has four types in 
> Java:'PBKDF2WithHmacSHA1','PBKDF2WithHmacSHA256','PBKDF2WithHmacSHA384','PBKDF2WithHmacSHA512'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-8537) LoginWorker HashCrypt the type of hash for one-way encryption

2016-12-01 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-8537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15712382#comment-15712382
 ] 

Shi Jinghai commented on OFBIZ-8537:


Thank you Junyuan for this fuction! (谢谢王军元!)

Well done!

It would be better if the following errors be corrected:
1. I have to remove the first 2 lines of the patch to apply it in my local 
environment as my project is not named as "trunk"

2. the getIterations() should be removed, simply using this line would be ok:
private static final int PBKDF2_Iterations = 
UtilProperties.getPropertyAsInteger("security.properties", 
"password.encrypt.pbkdf2.iterations", 1000);

3. change PBKDF2_SHA1 and other variables from public to private.

4. remove TODOs.

5. change flexadmin's password from 'admin' to our brand 'ofbiz' :)

Please DO submit a new patch tomorrow. Thanks again!


> LoginWorker HashCrypt the type of hash for one-way encryption
> -
>
> Key: OFBIZ-8537
> URL: https://issues.apache.org/jira/browse/OFBIZ-8537
> Project: OFBiz
>  Issue Type: New Feature
>  Components: framework
>Affects Versions: Trunk
>Reporter: wangjunyuan
>Assignee: Shi Jinghai
>Priority: Minor
>  Labels: HashCrypt, PBKDF2, security.properties
> Attachments: HashCrypt.patch
>
>
> PBKDF2 (Password-Based Key Derivation Function 2) is part of RSA 
> Laboratories' Public-Key Cryptography Standards (PKCS) series, specifically 
> PKCS #5 v2.0, also published as Internet Engineering Task Force's RFC 2898. 
> It replaces an earlier key derivation function, PBKDF1, which could only 
> produce derived keys up to 160 bits long.Add this function to ofbiz ,this 
> PBKDF2 has four types in 
> Java:'PBKDF2WithHmacSHA1','PBKDF2WithHmacSHA256','PBKDF2WithHmacSHA384','PBKDF2WithHmacSHA512'



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-11-23 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15690317#comment-15690317
 ] 

Shi Jinghai commented on OFBIZ-9123:


Hi Jacques,

I submitted a simple readme and replaced some (many) tabs with spaces.

BTW, Apache Archiva is a good tool to build a maven repo.

> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9123) Add a PriCat component under specialpurpose

2016-11-22 Thread Shi Jinghai (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15688517#comment-15688517
 ] 

Shi Jinghai commented on OFBIZ-9123:


Hi Jacques,

Thanks for your review!

I'll add a readme asap, and remove tabs in the source code. :)

I'm eager to see the plugin model works in OFBiz. I have publish right of 
central maven repository but it's not allowed to publish any artifacts of 
Apache as Apache has ourown repository server, my question is where to publish 
our plugins?

Love you,


> Add a PriCat component under specialpurpose
> ---
>
> Key: OFBIZ-9123
> URL: https://issues.apache.org/jira/browse/OFBIZ-9123
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shi Jinghai
>Assignee: Shi Jinghai
>Priority: Trivial
> Fix For: Trunk
>
>
> Add a PriCat component to view excel import with html report and download 
> excel output with errors commented.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


  1   2   >