[jira] [Commented] (OFBIZ-9157) "View Order" throws exception in getReturnableQuantity

2017-01-21 Thread Leonard Lin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832948#comment-15832948
 ] 

Leonard Lin commented on OFBIZ-9157:


Thanks!

> "View Order" throws exception in getReturnableQuantity
> --
>
> Key: OFBIZ-9157
> URL: https://issues.apache.org/jira/browse/OFBIZ-9157
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 15.12, Release Branch 16.11
> Environment: Encountered this in 15.x and 16.x Trunk versions
>Reporter: Leonard Lin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Release Branch 14.12, Release Branch 15.12, Upcoming 
> Release, 16.11.02
>
> Attachments: services_return.xml.patch
>
>
> Steps to Reproduce:
> - Create a sales order
> - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product
> - set the status of the order to completed
> - go to order-management and try to open the order for display like:
> https://localhost:8443/ordermgr/control/orderview?orderId=X
> Expected:
> - the order is displayed with status completed
> Actual:
> - A groovy exception is displayed.
> Analysis:
> The service "getReturnableQuantity" throws an exception because it returns 
> the returnablePrice = null, because the unitPrice of the orderItem was null.
> The OUT field returnablePrice is mandatory according to the 
> service-definition. The return parameter is set but the value is null, hence 
> the exception.
> Attached is a patch that will adjust the service-deinition to allow for 
> "null" value of the OUT parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9157) "View Order" throws exception in getReturnableQuantity

2017-01-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832930#comment-15832930
 ] 

Jacques Le Roux commented on OFBIZ-9157:


OK thanks, makes sense. I'll apply your solution

> "View Order" throws exception in getReturnableQuantity
> --
>
> Key: OFBIZ-9157
> URL: https://issues.apache.org/jira/browse/OFBIZ-9157
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 15.12, Release Branch 16.11
> Environment: Encountered this in 15.x and 16.x Trunk versions
>Reporter: Leonard Lin
>Priority: Minor
> Attachments: services_return.xml.patch
>
>
> Steps to Reproduce:
> - Create a sales order
> - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product
> - set the status of the order to completed
> - go to order-management and try to open the order for display like:
> https://localhost:8443/ordermgr/control/orderview?orderId=X
> Expected:
> - the order is displayed with status completed
> Actual:
> - A groovy exception is displayed.
> Analysis:
> The service "getReturnableQuantity" throws an exception because it returns 
> the returnablePrice = null, because the unitPrice of the orderItem was null.
> The OUT field returnablePrice is mandatory according to the 
> service-definition. The return parameter is set but the value is null, hence 
> the exception.
> Attached is a patch that will adjust the service-deinition to allow for 
> "null" value of the OUT parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9157) "View Order" throws exception in getReturnableQuantity

2017-01-21 Thread Leonard Lin (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832922#comment-15832922
 ] 

Leonard Lin commented on OFBIZ-9157:


Hi [~jacques.le.roux],

Yes, the order and orderItem is created programmatically.

I import orders from an external Webshop into OFBiz for fulfillment processing.
In this project I'm not using OFBiz accounting / pricing, that's why no prices 
are set.

Best,
Leonard

> "View Order" throws exception in getReturnableQuantity
> --
>
> Key: OFBIZ-9157
> URL: https://issues.apache.org/jira/browse/OFBIZ-9157
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 15.12, Release Branch 16.11
> Environment: Encountered this but in 15.x and 16.x Trunk versions
>Reporter: Leonard Lin
>Priority: Minor
> Attachments: services_return.xml.patch
>
>
> Steps to Reproduce:
> - Create a sales order
> - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product
> - set the status of the order to completed
> - go to order-management and try to open the order for display like:
> https://localhost:8443/ordermgr/control/orderview?orderId=X
> Expected:
> - the order is displayed with status completed
> Actual:
> - A groovy exception is displayed.
> Analysis:
> The service "getReturnableQuantity" throws an exception because it returns 
> the returnablePrice = null, because the unitPrice of the orderItem was null.
> The OUT field returnablePrice is mandatory according to the 
> service-definition. The return parameter is set but the value is null, hence 
> the exception.
> Attached is a patch that will adjust the service-deinition to allow for 
> "null" value of the OUT parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (OFBIZ-9157) "View Order" throws exception in getReturnableQuantity

2017-01-21 Thread Jacques Le Roux (JIRA)

[ 
https://issues.apache.org/jira/browse/OFBIZ-9157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15832916#comment-15832916
 ] 

Jacques Le Roux commented on OFBIZ-9157:


Hi Leonard, 

About
bq. - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product
I know no product with a null price. So you do that programatically, right? 

> "View Order" throws exception in getReturnableQuantity
> --
>
> Key: OFBIZ-9157
> URL: https://issues.apache.org/jira/browse/OFBIZ-9157
> Project: OFBiz
>  Issue Type: Bug
>  Components: order
>Affects Versions: Release Branch 15.12, Release Branch 16.11
> Environment: Encountered this but in 15.x and 16.x Trunk versions
>Reporter: Leonard Lin
>Priority: Minor
> Attachments: services_return.xml.patch
>
>
> Steps to Reproduce:
> - Create a sales order
> - Add 1 orderitem with no unitPrice set (unitPrice = null) for the product
> - set the status of the order to completed
> - go to order-management and try to open the order for display like:
> https://localhost:8443/ordermgr/control/orderview?orderId=X
> Expected:
> - the order is displayed with status completed
> Actual:
> - A groovy exception is displayed.
> Analysis:
> The service "getReturnableQuantity" throws an exception because it returns 
> the returnablePrice = null, because the unitPrice of the orderItem was null.
> The OUT field returnablePrice is mandatory according to the 
> service-definition. The return parameter is set but the value is null, hence 
> the exception.
> Attached is a patch that will adjust the service-deinition to allow for 
> "null" value of the OUT parameter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)