[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115654#comment-16115654
]
Deepak Dixit commented on OFBIZ-9351:
-
Thanks Aditya,
This has been committed at ofbiz plugins trunk at r#1804224
While clean up I remove these but forgot to commit plugin folder.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115367#comment-16115367
]
Aditya Sharma commented on OFBIZ-9351:
--
It won't be affecting that as these field types were only implemented at the
code level & had no special significance at the database level i.e. both "id"
and "id-ne" were same for the database.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115171#comment-16115171
]
Wai commented on OFBIZ-9351:
Now that "id-ne", "id-long-ne" and "id-vlong-ne" has been modified with "id",
"id-long" and "id-vlong" respectively.
How does this affect an existing database with production data?
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16114018#comment-16114018
]
Jacques Le Roux commented on OFBIZ-9351:
Good catch, thanks Aditya.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113968#comment-16113968
]
Aditya Sharma commented on OFBIZ-9351:
--
Updated Entity Engine Guide
https://cwiki.apache.org/confluence/display/OFBIZ/Entity+Engine+Guide.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113894#comment-16113894
]
Aditya Sharma commented on OFBIZ-9351:
--
Thanks Deepak :)
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113223#comment-16113223
]
Deepak Dixit commented on OFBIZ-9351:
-
This has been committed at ofbiz framework trunk at r#1804031
Thanks Aditya Sharma for your contribution.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Fix For: Upcoming Release
>
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112691#comment-16112691
]
Aditya Sharma commented on OFBIZ-9351:
--
Before committing the latest patch, patch in OFBIZ-9355 needs to be committed.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351.patch,
> OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027406#comment-16027406
]
Aditya Sharma commented on OFBIZ-9351:
--
Thanks Deepak :)
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027404#comment-16027404
]
Deepak Dixit commented on OFBIZ-9351:
-
Thanks Aditya for your contribution,
OFBIZ-9351.patch has been committed to ofbiz-framework at r#r1796379
and
OFBIZ-9351_plugins.patch has been committed to ofbiz-plugins at r#1796380
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Deepak Dixit
>Priority: Trivial
> Attachments: OFBIZ-9351.patch, OFBIZ-9351_plugins.patch
>
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004706#comment-16004706
]
Aditya Sharma commented on OFBIZ-9351:
--
+1
As no of occurrences is a really large figure.
Just to keep a track and distinguish them I would prefer to create 2 separate
sub-tickets for primary and non-primary occurrences.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (OFBIZ-9351) Remove unnecessary field types
[
https://issues.apache.org/jira/browse/OFBIZ-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002281#comment-16002281
]
Deepak Dixit commented on OFBIZ-9351:
-
If field is define as primary key field so by default is will be set as
not-null=true,
so we can replace all the primary key field type from id-ne to id in one shot.
> Remove unnecessary field types
> --
>
> Key: OFBIZ-9351
> URL: https://issues.apache.org/jira/browse/OFBIZ-9351
> Project: OFBiz
> Issue Type: Task
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
>
> As discussed in http://markmail.org/message/d2tpovewhtotukwa the "not empty"
> field types ("id-ne", "id-long-ne" and "id-vlong-ne") were initially added
> to implement validations on data. But, because the validations where only
> implemented in some place like webtools, it contradicts the distinction to be
> upheld on various layers. So it is better to remove these field types. So we
> will remove all those field types and will create sub tickets to replace them
> in entity definitions by corresponding "id" types.
> When replacing the "not empty" field types in entity definitions by
> corresponding "id" types we will add a *not-null="true"* attribute to "makes
> the field NOT NULL on the database (like primary key fields)" as explained in
> "not-null" documentation in fieldtypemodel.xsd. We will finally clean the
> documentation of the "not-null" in fieldtypemodel.xsd.
> Related Links:
> http://ofbiz.135035.n4.nabble.com/EntityEngine-field-types-td2251546.html
> http://markmail.org/message/otec62xiwkpjttkq
> A more vivid description:
> http://ofbiz.markmail.org/thread/c6ee3ewyo6jpik7k
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
