[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051750#comment-16051750 ] Deepak Dixit commented on OFBIZ-9409: - Created OFBIZ-9413 for currency uom update. > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release > > Attachments: OFBIZ-9409.patch, OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051741#comment-16051741 ] Deepak Dixit commented on OFBIZ-9409: - Thanks [~mbrohl] and [~jacques.le.roux] for review and suggestion. This has been committed at ofbiz-framework trunk r#1798907 > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Fix For: Upcoming Release > > Attachments: OFBIZ-9409.patch, OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051728#comment-16051728 ] Jacques Le Roux commented on OFBIZ-9409: Hi Michael, Ah, indeed, I did not look down to the end of the patch, and thought the numericCode field type was already numeric + 1 for numeric type for numericCode field > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051675#comment-16051675 ] Michael Brohl commented on OFBIZ-9409: -- Jacques, seems to be a misunderstanding: the patch already contains short-varchar as type for the numeric field, I think Pierre suggested to change this to a field type which only allows numbers. I second this. > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051676#comment-16051676 ] Michael Brohl commented on OFBIZ-9409: -- Hi [~deepak.dixit], +1 for your patch with a change to use numeric field type for the numericCode field. > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051656#comment-16051656 ] Jacques Le Roux commented on OFBIZ-9409: Hi Pierre, Why would you want to use the 'short-varchar' field type when it's only a 3 digits code? > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051599#comment-16051599 ] Deepak Dixit commented on OFBIZ-9409: - Thanks Pierre for review, I simply took reference from geo.geoSecCode that used to store numericCode value for Geo I think we can use numeric as field type for this case. > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050996#comment-16050996 ] Pierre Smits commented on OFBIZ-9409: - Hi [~deepak.dixit], I reviewed your patch file. Maybe you should consider changing the field type for the numericCode field. The 'short-varchar' field type also allows alpha numeric entries (and in the case of PostgreSQL up to 60 characters). I suspect that also applies for other RDBMSes. Best regards, Pierre > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > Attachments: OFBIZ-9409.patch > > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050900#comment-16050900 ] Deepak Dixit commented on OFBIZ-9409: - While adding nurmericCode to currency UOM, I found we need to update some old currency UOM as well, as uomId has been modified. https://www.currency-iso.org/en/home/amendments.html I'll create new ticket to honor currency amendments. Here is the short summary *Following UOM not found* * Santo Domiongo(CDP) * Brazil (BRR) * Argentinian Austral(ARA) * Andoran peseta(ADP) * Maltese Lira (MTL) * Mexican Peso (old)(MXP) * Peruvian Inti(PEI) * Peruvian Sol(PES) * Tadzhikistani Ruble(TJR) *Following UOM using other currency * Used Other * ANDORRA == Euro * Cyprus Pound(CYP) == Euro * Ecuador Sucre(ECS) = USD * Estonian Krone(EEK) = EURO * Lithuanian Lita(LTL) == EURO * Latvian Lat(LVL) == EURO * Timor Escudo(TPE) == US Dollor *Following UOM has been changed* ||Old||New|| |Belorussian Ruble(BYR)|Belarusian Ruble(BYN)| |Bosnia-Herzogovinian Dinar(BAD)|Convertible Mark(BAM)| |Azerbaijan Manat (AZM)|Azerbaijan Manat(AZN)| |Angolan Kwanza (AOK)|Kwanza (AOA)| |Afghani (AFA)|Afghani(AFN)| |Dominican Republic Peso(DRP)|Dominican Peso (DOP)| |Ghanian Cedi(GHC)|Ghana Cedi(GHS)| |Guinea Peso(GWP)| Guinean Franc(GNF)| |Kirghizstan Som(KIS)|KYRGYZSTANSom (KGS)| |Madagascan Franc(MGF)|Malagasy Ariary(MGA)| |Mozambique Metical(MZM)|Mozambique Metical(MZN)| |Nicaragua (NIC)|Cordoba Oro (NIO)| |New Israeli Shekel(NIS)|New Israeli Sheqel (ILS)| |Poland(PLZ)|Zloty (PLN)| |Romanian Leu(ROL)|Romanian Leu(RON)| |Russian Rouble(RUR)|Russian Ruble(RUB)| |Sudanese Pound(SDP)|Sudanese Pound(SDG)| |Peru (SOL)|Sol (PEN)| |Surinam Guilder(SRG)|Surinam Dollar (SRD)| |Turkmenistani Manat(TMM)|Turkmenistan New Manat(TMT)| |Uganda Shilling(UGS)|Uganda Shilling(UGX)| |Uruguayan New Peso(UYP)|Uruguay Peso en Unidades Indexadas (URUIURUI)(UYI)| |Venezuelan Bolivar(VEB)|Bolívar(VEF)| |Zambian Kwacha(ZMK)|Zambian Kwacha(ZMW)| |Zimbabwean Dollar(ZWD)|Zimbabwe Dollar(ZWL)| |Georgian Kupon (GEK)|GEORGIA Lari (GEL)| > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9409) Add numeric code for Currency UOM
[ https://issues.apache.org/jira/browse/OFBIZ-9409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16050344#comment-16050344 ] Deepak Dixit commented on OFBIZ-9409: - For this we need to extend Uom entity and add new field numericCode (or better name) > Add numeric code for Currency UOM > - > > Key: OFBIZ-9409 > URL: https://issues.apache.org/jira/browse/OFBIZ-9409 > Project: OFBiz > Issue Type: Improvement >Affects Versions: Trunk >Reporter: Deepak Dixit >Assignee: Deepak Dixit > > The three-digit numeric code is useful when currency codes need to be > understood in countries that do not use Latin scripts and for computerised > systems. Where possible the 3 digit numeric code is the same as the numeric > country code. > https://www.iso.org/iso-4217-currency-codes.html > https://www.currency-iso.org/en/home/tables/table-a1.html -- This message was sent by Atlassian JIRA (v6.4.14#64029)
