[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305368#comment-17305368 ] Jacques Le Roux commented on OFBIZ-9516: Hi Priya, Did not test nor review, but that sounds better to me, +1 for commit. > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Sourabh Punyani >Priority: Trivial > Attachments: OFBIZ-9516.patch, OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17305323#comment-17305323 ] Priya Sharma commented on OFBIZ-9516: - Hi Sourabh & All, I tested the patch locally and it works fine. Though I would like to suggest one improvement, to consider using the workeffort type description instead of the id, that would make more sense to the end-user. The message would look like "Production Run Task : 10481 created successfully" instead of "PROD_ORDER_TASK: 10481 created successfully" WDYT? Else we can proceed with the current patch. Thanks! > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Sourabh Punyani >Priority: Trivial > Attachments: OFBIZ-9516.patch, OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17182294#comment-17182294 ] Sourabh Punyani commented on OFBIZ-9516: Hello [~adityasharma] , I have added a patch (OFBIZ-9516.patch) for the same. Please verify. > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Sourabh Punyani >Priority: Trivial > Attachments: OFBIZ-9516.patch, OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[
https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16119408#comment-16119408
]
Sonal Patwari commented on OFBIZ-9516:
--
Thanks Pranay, Pierre and Aditya for your comments.
I agree with Aditya as '${workEffortType}: ${workEffortId} created
successfully' would be more generic and convenient.
> User should be notified with success message on Creating New Routing
>
>
> Key: OFBIZ-9516
> URL: https://issues.apache.org/jira/browse/OFBIZ-9516
> Project: OFBiz
> Issue Type: Sub-task
> Components: manufacturing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: OFBIZ-9516.patch
>
>
> Steps to regenerate:
> 1. Go to Manufacturing component
> (https://localhost:8443/manufacturing/control/main)
> 2. Click on Routing sub menu
> (https://localhost:8443/manufacturing/control/FindRouting)
> 3. Click on New Routing
> button.(https://localhost:8443/manufacturing/control/EditRouting)
> 4. Fill required fields and Click Submit button.
> 7. On success, the user should be notified with success message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101536#comment-16101536 ] Pierre Smits commented on OFBIZ-9516: - I suggest to follow the same principle as used with the creation of production runs. > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Attachments: OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[
https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101365#comment-16101365
]
Pranay Pandey commented on OFBIZ-9516:
--
Thanks Sonal and Aditya for your comment.
There is already a label as "WorkEffortCreatedSuccessfully". IMO we can use
that one and to make it read better, we can add Id and type to its value as-
Work Effort: ${workEffortId} of type ${workEffortType} created successfully. I
am saying this because workEffortTypeId is not an optional input to
createWorkEffort service. Does that make sense and serve the purpose of this
ticket?
> User should be notified with success message on Creating New Routing
>
>
> Key: OFBIZ-9516
> URL: https://issues.apache.org/jira/browse/OFBIZ-9516
> Project: OFBiz
> Issue Type: Sub-task
> Components: manufacturing
>Affects Versions: Trunk
>Reporter: Aditya Sharma
>Assignee: Aditya Sharma
>Priority: Trivial
> Attachments: OFBIZ-9516.patch
>
>
> Steps to regenerate:
> 1. Go to Manufacturing component
> (https://localhost:8443/manufacturing/control/main)
> 2. Click on Routing sub menu
> (https://localhost:8443/manufacturing/control/FindRouting)
> 3. Click on New Routing
> button.(https://localhost:8443/manufacturing/control/EditRouting)
> 4. Fill required fields and Click Submit button.
> 7. On success, the user should be notified with success message.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101288#comment-16101288 ] Aditya Sharma commented on OFBIZ-9516: -- Hello Pranay, Really nice observation. I agree with Sonal we can go with '[WORKEFFORT_ID] created successfully' as that would be a more generic message. Thanks > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Attachments: OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101275#comment-16101275 ] Sonal Patwari commented on OFBIZ-9516: -- Hello Pranay Thanks for the review, I think we can update the success message as '[WORKEFFORT_ID] created successfully'. So that would be applicable wherever 'createWorkEffort' service is used. Thanks! > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma >Priority: Trivial > Attachments: OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (OFBIZ-9516) User should be notified with success message on Creating New Routing
[ https://issues.apache.org/jira/browse/OFBIZ-9516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101199#comment-16101199 ] Pranay Pandey commented on OFBIZ-9516: -- Hi Aditya, Sonal I reviewed this patch and have one question. As the given patch sets this success message for service "createWorkEffort", which indicates that it is always going to be used for creating a routing. IMO that assumption may create some issues where the same generic service is used to create other types of work efforts. Please share your thoughts. Thanks! > User should be notified with success message on Creating New Routing > > > Key: OFBIZ-9516 > URL: https://issues.apache.org/jira/browse/OFBIZ-9516 > Project: OFBiz > Issue Type: Sub-task > Components: manufacturing >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Pranay Pandey >Priority: Trivial > Attachments: OFBIZ-9516.patch > > > Steps to regenerate: > 1. Go to Manufacturing component > (https://localhost:8443/manufacturing/control/main) > 2. Click on Routing sub menu > (https://localhost:8443/manufacturing/control/FindRouting) > 3. Click on New Routing > button.(https://localhost:8443/manufacturing/control/EditRouting) > 4. Fill required fields and Click Submit button. > 7. On success, the user should be notified with success message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
