[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16328795#comment-16328795 ] Aditya Sharma edited comment on OFBIZ-10113 at 1/17/18 1:59 PM: Ohh Yes!. Thanks Jacques :). I should have even read the comment properly. There is one more instance that should be updated. Added another patch for themes/common/template/includes/SetMultipleSelectJsList.ftl file. was (Author: aditya.sharma): Ohh Yes!. Thanks Jacques !/jira/images/icons/emoticons/smile.png! I should have even read the comment properly. There is one more instance that should be updated. Added another patch for themes/common/template/includes/SetMultipleSelectJsList.ftl file. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113.patch, OFBIZ-10113.patch, > OFBIZ-10113_plugins.patch, select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16326286#comment-16326286 ] Aditya Sharma edited comment on OFBIZ-10113 at 1/15/18 2:33 PM: Thanks Jacques :) I have created a new ticket OFBIZ-10165 and will cover it under OFBIZ-9465. I will add a detailed description when I will pick that. was (Author: aditya.sharma): Thanks Jacques :) I have created a new ticket OFBIZ-10165 and will cover it under OFBIZ-9465. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux >Priority: Major > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16324498#comment-16324498 ] Jacques Le Roux edited comment on OFBIZ-10113 at 1/12/18 8:54 PM: -- At r1821028+1821032 , I reverted from r1821001 some unrelated files (pending changes) that inadvertently slipped in. was (Author: jacques.le.roux): At r1821028, I reverted from r1821001 some unrelated files (pending changes) that inadvertently slipped in. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Jacques Le Roux > Fix For: Upcoming Branch > > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322338#comment-16322338 ] Aditya Sharma edited comment on OFBIZ-10113 at 1/12/18 5:08 AM: Replaced Asm select plugin with Select2 4.0.6 Added i18n support so added logic in JsLanguageFileMappingCreator and JsLanguageFilesMapping accordingly. Added some custom CSS as the Select2 seems to be too fancy in accordance with the current OFBiz themes Verify: Multiple drop-downs field in FormWidgetExamples. I have added multiple="true" with OFBIZ-10113_plugins.patch https://localhost:8443/example/control/FormWidgetExamples Find Request page with StatusId , CustRequestId https://localhost:8443/ordermgr/control/FindRequest I have replaced the plugins though I feel the implementation of select multiple js code is to be reviewed & refactored. I will pick when I am done with all my current tasks if I get some consensus. was (Author: aditya.sharma): Replaced Asm select plugin with Select2 4.0.6 Verify: Multiple drop-downs field in FormWidgetExamples. I have added multiple="true" with OFBIZ-10113_plugins.patch https://localhost:8443/example/control/FormWidgetExamples Find Request page with StatusId , CustRequestId https://localhost:8443/ordermgr/control/FindRequest I have replaced the plugins though I feel the implementation of select multiple js code is to be reviewed & refactored. I will pick when I am done with all my current tasks if I get some consensus. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-10113) Replace Asm select plugin with Select2.
[ https://issues.apache.org/jira/browse/OFBIZ-10113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16322338#comment-16322338 ] Aditya Sharma edited comment on OFBIZ-10113 at 1/12/18 3:57 AM: Replaced Asm select plugin with Select2 4.0.6 Verify: Multiple drop-downs field in FormWidgetExamples. I have added multiple="true" with OFBIZ-10113_plugins.patch https://localhost:8443/example/control/FormWidgetExamples Find Request page with StatusId , CustRequestId https://localhost:8443/ordermgr/control/FindRequest I have replaced the plugins though I feel the implementation of select multiple js code is to be reviewed & refactored. I will pick when I am done with all my current tasks if I get some consensus. was (Author: aditya.sharma): Replace Asm select plugin with Select2 4.0.6 Verify: Multiple drop-downs field in FormWidgetExamples. I have added multiple="true" with OFBIZ-10113_plugins.patch https://localhost:8443/example/control/FormWidgetExamples Find Request page with StatusId , CustRequestId https://localhost:8443/ordermgr/control/FindRequest I have replaced the plugins though I feel the implementation of select multiple js code is to be reviewed & refactored. I will pick when I am done with all my current tasks if I get some consensus. > Replace Asm select plugin with Select2. > --- > > Key: OFBIZ-10113 > URL: https://issues.apache.org/jira/browse/OFBIZ-10113 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Aditya Sharma >Assignee: Aditya Sharma > Attachments: OFBIZ-10113.patch, OFBIZ-10113_plugins.patch, > select2.tar.gz > > > Current Asm Select Plugin > (http://www.ryancramer.com/journal/entries/asmselect_v104/) can be replaced > with Select2 (https://select2.org/). > * Select2 has much better community support on GitHub with 386 contributors > while Asm Select Plugin is handled by Ryan Cramer on > http://www.ryancramer.com/. > * Select2 has 37 releases while Asm select has very few releases yet. > * Both the plugin has MIT license. > Refer https://select2.org/ and https://github.com/select2/select2 for more > features and other information. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
