[jira] [Comment Edited] (OFBIZ-10131) ID should be the abbreviation for identity in English
[ https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16315237#comment-16315237 ] James Yong edited comment on OFBIZ-10131 at 1/7/18 12:36 PM: - Hi Jacques, Forgot to mention that I am unable to apply your patch for AccountingErrorUiLabels.xml, so the changes are missing from the commits. Can you look into it? Regards, James was (Author: jamesyong): Hi Jacques, Forget to mention that I am unable to apply your patch for AccountingErrorUiLabels.xml, so the changes are missing from the commits. Can you look into it? Regards, James > ID should be the abbreviation for identity in English > - > > Key: OFBIZ-10131 > URL: https://issues.apache.org/jira/browse/OFBIZ-10131 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10131-plugins.patch, OFBIZ-10131.patch, > OFBIZ-10131.patch > > > This affects the display on the web pages. Not the naming of variables in the > codes. > Will search the *Labels.xml files and replace the word 'Id' with 'ID'. > Will also improve the logic for auto title so that labels generated for > variables like productTypeId will be 'Product Type ID' instead of 'Product > Type Id'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-10131) ID should be the abbreviation for identity in English
[ https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309785#comment-16309785 ] James Yong edited comment on OFBIZ-10131 at 1/7/18 12:23 PM: - Sorry I didn't see the new patch. PS: So this issue is re-opened to review the new patches provided by Jacques. was (Author: jamesyong): Sorry I didn't see the new patch. > ID should be the abbreviation for identity in English > - > > Key: OFBIZ-10131 > URL: https://issues.apache.org/jira/browse/OFBIZ-10131 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Trunk > > Attachments: OFBIZ-10131-plugins.patch, OFBIZ-10131.patch, > OFBIZ-10131.patch > > > This affects the display on the web pages. Not the naming of variables in the > codes. > Will search the *Labels.xml files and replace the word 'Id' with 'ID'. > Will also improve the logic for auto title so that labels generated for > variables like productTypeId will be 'Product Type ID' instead of 'Product > Type Id'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (OFBIZ-10131) ID should be the abbreviation for identity in English
[ https://issues.apache.org/jira/browse/OFBIZ-10131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16307597#comment-16307597 ] James Yong edited comment on OFBIZ-10131 at 1/2/18 12:57 PM: - Hi Jacques, English is the language to fallback on if labels cannot be found for non-English locale. So the check for the English language is not used in ModelFormField.java. IMHO, would be easier to add language-check for exceptions. Regards, James was (Author: jamesyong): Hi Jacques, English is the language to fallback on if labels cannot be found for non-English locale. So the check for the English language is not used in ModelFormField.java. IMHO, would be easier to add language-check for exceptional cases. Regards, James > ID should be the abbreviation for identity in English > - > > Key: OFBIZ-10131 > URL: https://issues.apache.org/jira/browse/OFBIZ-10131 > Project: OFBiz > Issue Type: Improvement > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: James Yong >Assignee: James Yong >Priority: Minor > Fix For: Upcoming Release > > Attachments: OFBIZ-10131.patch > > > This affects the display on the web pages. Not the naming of variables in the > codes. > Will search the *Labels.xml files and replace the word 'Id' with 'ID'. > Will also improve the logic for auto title so that labels generated for > variables like productTypeId will be 'Product Type ID' instead of 'Product > Type Id'. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
