[jira] [Comment Edited] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17165169#comment-17165169 ] Jacques Le Roux edited comment on OFBIZ-11553 at 7/26/20, 6:47 AM: --- Thank you much guys, This was bugging me, never good to have a bug pending too long, waiting to me be mixed with others and making us lossing tracks :) was (Author: jacques.le.roux): Thank you much guys, This was bugging me, never good to have a bug pending too long time, waiting to me be mixed with others and lossing tracks :) > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > Attachments: OFBIZ-11553-test.patch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17156293#comment-17156293 ] Pawan Verma edited comment on OFBIZ-11553 at 7/12/20, 11:27 AM: I'd looked into it and found that the order created with test case testCreateOrderServiceProduct did not get approved so the quick ship process did not work correctly while with specific configurableServiceOrder-test new order has got approved and the quick ship process worked correctly. I tried to have a deep look and we got multiple payment methods i.e. EXT_PAYPAL and EXT_COD but in the test case only EXT_COD was defined. I've removed the shopping cart tests and testIntegration works perfectly. So, IMO we can convert shopping cart tests to Groovy and have a deep look into the issue. HTH for further investigation. was (Author: pawan.verma): I'd looked into and found that the order created with test case testCreateOrderServiceProduct did not get approved so the quick ship process did not work correctly while with specific configurableServiceOrder-test new order has got approved and the quick ship process worked correctly. I tried to have a deep look and we got multiple payment methods i.e. EXT_PAYPAL and EXT_COD but in the test case only EXT_COD was defined. I've removed the shopping cart tests and testIntegration works perfectly. So, IMO we can convert shopping cart tests to Groovy and have a deep look into the issue. HTH for further investigation. > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > Fix For: Upcoming Branch > > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146017#comment-17146017 ] Pawan Verma edited comment on OFBIZ-11553 at 6/26/20, 5:22 AM: --- Thanks, [~priya.sharma.9362]. It works well for me. Tested with: ./gradlew "ofbiz --test component=accounting --test suitename=invoicetests" Can we convert Debug.logInfo to logInfo() method? But for that, we need to add this method in OFBizTestCase class. I am fine in both approaches. Thanks. was (Author: pawan.verma): Thanks, [~priya.sharma.9362] Can we convert Debug.logInfo to logInfo() method? But for that, we need to add this method in OFBizTestCase class. I am fine in both approaches. Thanks. > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > > Convert InvoicePerShipmentTests.xml to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (OFBIZ-11553) Convert InvoicePerShipmentTests.xml to Groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144859#comment-17144859 ] Priya Sharma edited comment on OFBIZ-11553 at 6/25/20, 11:37 AM: - Thanks, Jacques. The tickets that will be affected are - https://issues.apache.org/jira/browse/OFBIZ-11554 https://issues.apache.org/jira/browse/OFBIZ-11555 https://issues.apache.org/jira/browse/OFBIZ-11556 I will be making a single PR to cover all these tests. Also updated the ticket title and the summary. was (Author: priya.sharma.9362): Thanks, Jacques. The tickets that will be affected are - https://issues.apache.org/jira/browse/OFBIZ-11554 https://issues.apache.org/jira/browse/OFBIZ-11555 https://issues.apache.org/jira/browse/OFBIZ-11556 I will be making a single PR to cover all these tests. > Convert InvoicePerShipmentTests.xml to Groovy > -- > > Key: OFBIZ-11553 > URL: https://issues.apache.org/jira/browse/OFBIZ-11553 > Project: OFBiz > Issue Type: Sub-task > Components: accounting >Affects Versions: Trunk >Reporter: Rohit Hukkeri >Assignee: Priya Sharma >Priority: Minor > > Convert testInvoicePerShipmentSetFalse test from XML to Groovy -- This message was sent by Atlassian Jira (v8.3.4#803005)
