[jira] [Comment Edited] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587162#comment-16587162 ] Deepak Dixit edited comment on OFBIZ-9241 at 8/21/18 8:37 AM: -- Mistakenly assigned this to myself (sometime shortcut keys behave abnormally) One way to handle this kind of thing is to enhance renderLink method, we can check if request or view response component exits then only it tuned into link else it will be simple text or we can hide it. was (Author: deepak.dixit): Mistakenly I assigned this to myself (sometime shortcut keys behave abnormally) One way to handle this kind of thing is to enhance renderLink method, we can check if request or view response component exits then only it tuned into link else it will be simple text or we can hide it. > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch, OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587152#comment-16587152 ] Jacques Le Roux edited comment on OFBIZ-9241 at 8/21/18 8:30 AM: - Yes I thought about that, I'll add FIXMEs. As soon as we have a better solution we can remove it. was (Author: jacques.le.roux): Yes I thought about that, I'll add FIXMEs > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch, OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587102#comment-16587102 ] Jacques Le Roux edited comment on OFBIZ-9241 at 8/21/18 7:58 AM: - Michael, I understand your concern and I agree with your analysis. But I believe we need an intermediary temporary solution. Today you get NPEs when you use the framework only solution. My temporary solution is to avoid these NPEs. was (Author: jacques.le.roux): Michael, I understand your concern and I agree with your analysis. But I believe we need an intermediary temporary solution. Today you get a NPEs when you use the framework only solution. My temporary solution is to avoid these NPEs. > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch, OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325725#comment-16325725 ] Jacques Le Roux edited comment on OFBIZ-9241 at 8/20/18 5:01 PM: - Thinking about that, we can simply hide the button when the ecommerce component is not present. I don't know yet for the 95 other cases which should be handled in OFBIZ-9283, this is only for ecommerce. was (Author: jacques.le.roux): Thinking about that, we can simply hide the button when the ecommerce component is not present. I don't know yet for the 95 other cases. > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (OFBIZ-9241) Removes ecommerce links from applications
[ https://issues.apache.org/jira/browse/OFBIZ-9241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586210#comment-16586210 ] Jacques Le Roux edited comment on OFBIZ-9241 at 8/20/18 4:58 PM: - I have begun to work on that, with the attached patch The same should be done for other plugins, ecommerce being by far the most prominent I don't expect as work with others. I have created OFBIZ-9283 for that was (Author: jacques.le.roux): I have begun to work on that, with the attached patch The same should be done for other plugins, ecommerce being by far the most prominent I don't expect as work with others. > Removes ecommerce links from applications > - > > Key: OFBIZ-9241 > URL: https://issues.apache.org/jira/browse/OFBIZ-9241 > Project: OFBiz > Issue Type: Sub-task > Components: ALL APPLICATIONS >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Major > Fix For: 17.12.01 > > Attachments: OFBIZ-9241.patch > > > While working on OFBIZ-9206 I remembered how the ecommerce webapp is deeply > entrenched in some applications components. This can at least be tested with > product and catalog webapp. > # Get to catalog/control/EditProduct?productId=GZ-1000 > # Click on the "Product Page" button => ecommerce > There are much more cases (96 occurrences actually) but most of them are not > hard dependencies. > Since the ecommerce component is now a plugin, we need to remove all > ecommerce links from applications, I even wonder if this issue is really an > improvement or should not be now considered a bug... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
