[jira] [Commented] (OFBIZ-10376) Remove hard coded values from removePromotion

2020-05-09 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17103154#comment-17103154
 ] 

ASF subversion and git services commented on OFBIZ-10376:
-

Commit f365a9b7a0b450da3b14784f272b33f148533b56 in ofbiz-framework's branch 
refs/heads/trunk from Pawan Verma
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f365a9b ]

Improved: Remove hard coded values from removePromotion

(OFBIZ-10376)

Thanks: Shikha Jaiswal for your contribution.


> Remove hard coded values from removePromotion
> -
>
> Key: OFBIZ-10376
> URL: https://issues.apache.org/jira/browse/OFBIZ-10376
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shikha Jaiswal
>Assignee: Pawan Verma
>Priority: Minor
> Attachments: OFBIZ-10376.patch
>
>
> In removePromotion, values used to fetch data from ProductPromoAction are 
> hard coded. Need to remove these hard-coded values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10376) Remove hard coded values from removePromotion

2020-05-08 Thread Pawan Verma (Jira) 


[ 
https://issues.apache.org/jira/browse/OFBIZ-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17102778#comment-17102778
 ] 

Pawan Verma commented on OFBIZ-10376:
-

Hi [~nmalin]

I hope you wouldn't mind if I take over and commit it ;)

> Remove hard coded values from removePromotion
> -
>
> Key: OFBIZ-10376
> URL: https://issues.apache.org/jira/browse/OFBIZ-10376
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: Trunk
>Reporter: Shikha Jaiswal
>Assignee: Nicolas Malin
>Priority: Minor
> Attachments: OFBIZ-10376.patch
>
>
> In removePromotion, values used to fetch data from ProductPromoAction are 
> hard coded. Need to remove these hard-coded values.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (OFBIZ-10376) Remove hard coded values from removePromotion

2018-04-28 Thread Shikha Jaiswal (JIRA) 

[ 
https://issues.apache.org/jira/browse/OFBIZ-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457406#comment-16457406
 ] 

Shikha Jaiswal commented on OFBIZ-10376:


Attaching patch for this improvement.

> Remove hard coded values from removePromotion
> -
>
> Key: OFBIZ-10376
> URL: https://issues.apache.org/jira/browse/OFBIZ-10376
> Project: OFBiz
>  Issue Type: Improvement
>Reporter: Shikha Jaiswal
>Assignee: Shikha Jaiswal
>Priority: Minor
> Attachments: OFBIZ-10376.patch
>
>
> In removePromotion, values used to fetch data from ProductPromoAction are 
> hard coded. Need to remove these hard-coded values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)