[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544212#comment-16544212 ] Pradhan Yash Sharma commented on OFBIZ-10398: - +1 Looks good to me. > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10398-rename.patch, OFBIZ-10398.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544149#comment-16544149 ] Jacques Le Roux commented on OFBIZ-10398: - Thanks Suraj, After a cursory review this sounds good to me > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10398-rename.patch, OFBIZ-10398.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16544143#comment-16544143 ] Suraj Khurana commented on OFBIZ-10398: --- Hello, I have added an updated patch containing all the enhancements suggested. Please review and let me know in case of any concerns. > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch, OFBIZ-10398.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473078#comment-16473078 ] Pierre Smits commented on OFBIZ-10398: -- We can also, when the patch passes scrutiny, commit it as is. And address the suggestions in subsequent tickets. > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473057#comment-16473057 ] Deepak Dixit commented on OFBIZ-10398: -- We can break this into two patch one is for deletePartyContactMechPurpose and another is for deletePartyContactMechPurposeIfExists > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473055#comment-16473055 ] Pierre Smits commented on OFBIZ-10398: -- The patch does not pass scrutiny? > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473035#comment-16473035 ] Jacques Le Roux commented on OFBIZ-10398: - +1 for expirePartyContactMechPurpose and expirePartyContactMechPurpose names. > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473008#comment-16473008 ] Deepak Dixit commented on OFBIZ-10398: -- Nah, I am suggesting that we can improve code in same ticket. As we are doing effort to rename and update service occurrences, so why not update it properly :) > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473005#comment-16473005 ] Pierre Smits commented on OFBIZ-10398: -- Thanks [~deepak.dixit], So you feel this ticket should be closed with resolution 'Won't Implement'? > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10398) Rename deletePartyContactMechPurpose* services
[ https://issues.apache.org/jira/browse/OFBIZ-10398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472975#comment-16472975 ] Deepak Dixit commented on OFBIZ-10398: -- Thanks Pierre, I think we can convert expirePartyContactMechPurpose service to entity-auto, and can use partyIdPermissionCheck as permission service. Also as we are renaming service so why not think to remove ifExists as suffix from service name and use expirePartyContactMechPurposes or much better name. > Rename deletePartyContactMechPurpose* services > -- > > Key: OFBIZ-10398 > URL: https://issues.apache.org/jira/browse/OFBIZ-10398 > Project: OFBiz > Issue Type: Improvement > Components: order, party >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Pierre Smits >Priority: Major > Attachments: OFBIZ-10398-rename.patch > > > Both deletePartyContactMechPurposeIfExists and deletePartyContactMechPurpose > are misnomers, as these functions don't delete records but expires those by > setting the thruDate. The misnomers creates unnecessary confusion. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
