[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284247#comment-17284247 ] Michael Brohl commented on OFBIZ-10476: --- This is now done for trunk. I will wait a bit if this show problems and will backport to 18.12 if everything is fine. > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Release Branch 18.12, Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284246#comment-17284246 ] ASF subversion and git services commented on OFBIZ-10476: - Commit 662a3f9d1c60fcf1d4787600129f9ae8e28b011b in ofbiz-framework's branch refs/heads/trunk from Michael Brohl [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=662a3f9 ] Improved: Remove Compdoc functionality from content manager (OFBIZ-10476) > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Release Branch 18.12, Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Labels: backport-needed > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17284200#comment-17284200 ] Jacques Le Roux commented on OFBIZ-10476: - At 1st glance all seems to work correctly in the UI and the console.log is clean: +1 > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Release Branch 18.12, Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17283417#comment-17283417 ] Michael Brohl commented on OFBIZ-10476: --- I had to rework the patch. There were changes in forms which should not be made (parent content), probably because of a misleading uiLabel. The uiLabel was renamed and the parent content Id fields were not removed in the forms. The changes are now in a pull request linked to this issue. I'd appreciate if someone could test if everything works as expected in the content component after the changes are applied. Thanks! > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Affects Versions: Release Branch 18.12, Trunk >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276506#comment-17276506 ] Jacques Le Roux commented on OFBIZ-10476: - Hi Michael, +1 to remove > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17276499#comment-17276499 ] Michael Brohl commented on OFBIZ-10476: --- [~jleroux] any objections to remove CompDoc and backport to 18.12? > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742274#comment-16742274 ] Jacques Le Roux commented on OFBIZ-10476: - We could wait a bit before backporting (say a month?), but I'm for it yes (in both, nothing has been released yet). > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10476) Remove Compdoc functionality from content manager
[ https://issues.apache.org/jira/browse/OFBIZ-10476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16742267#comment-16742267 ] Michael Brohl commented on OFBIZ-10476: --- This looks good to me. Any objections to move on and commit this? Should we at least backport this to 18.12 or even 17.12? It can be viewed as a bugfix (even if I changed to "improvement"). > Remove Compdoc functionality from content manager > - > > Key: OFBIZ-10476 > URL: https://issues.apache.org/jira/browse/OFBIZ-10476 > Project: OFBiz > Issue Type: Improvement > Components: content >Reporter: Dennis Balkir >Assignee: Michael Brohl >Priority: Major > Attachments: OFBIZ-10476_Content-CompDoc.patch > > > While creating a theme and looking for not correctly styled elements I came > across "some" not functional links and buttons in Compdoc. > This module seems not to be finished or working properly, because most of the > times, the buttons inside the appbar produce errors or just empty pages. > Even when searching for existing elements and then clicking on them to > examine or edit them will mostly create an error (example: go to compdoc, > search for template child, click edit on some random found element -> error). > Sometimes the menu which is included inside the appbar, mostly the menu > called "tree", need the contentId for the buttons to work. > Including this menu while creating a new entry will result in every button > not working and throwing an error, except the edit button, which will produce > a completely empty page. > Those things appear all over the module, trying some button or clicking some > link resulted in an error screen more than it resulted in something actually > working. > This should either be fixed or removed, if this doesn't has a real purpose at > all. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
