[jira] [Commented] (OFBIZ-10570) Requirement is created for wrong facility
[ https://issues.apache.org/jira/browse/OFBIZ-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624475#comment-16624475 ] Suraj Khurana commented on OFBIZ-10570: --- Thanks Jacques, This has been committed to trunk at rev #1841644. > Requirement is created for wrong facility > - > > Key: OFBIZ-10570 > URL: https://issues.apache.org/jira/browse/OFBIZ-10570 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Upcoming Branch >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Fix For: Trunk > > Attachments: OFBIZ-10570.patch > > > Design description: > In service _createAutoRequirementsForOrder_ ProductStore.inventoryFacilityId > is directly used for creating requirement. > Here, an order can have multiple ship group and each ship group can be > fulfilled from various facilities, so instead of creating requirement for > ProductStore.inventoryFacilityId, it should create requirement using > OrderItemShipGroup.facilityId. If not found, we can have an additional check > to use orderHeader.facilityId. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10570) Requirement is created for wrong facility
[ https://issues.apache.org/jira/browse/OFBIZ-10570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622147#comment-16622147 ] Jacques Le Roux commented on OFBIZ-10570: - The code makes sense to me, +1 > Requirement is created for wrong facility > - > > Key: OFBIZ-10570 > URL: https://issues.apache.org/jira/browse/OFBIZ-10570 > Project: OFBiz > Issue Type: Improvement > Components: order >Affects Versions: Upcoming Branch >Reporter: Suraj Khurana >Assignee: Suraj Khurana >Priority: Major > Attachments: OFBIZ-10570.patch > > > Design description: > In service _createAutoRequirementsForOrder_ ProductStore.inventoryFacilityId > is directly used for creating requirement. > Here, an order can have multiple ship group and each ship group can be > fulfilled from various facilities, so instead of creating requirement for > ProductStore.inventoryFacilityId, it should create requirement using > OrderItemShipGroup.facilityId. If not found, we can have an additional check > to use orderHeader.facilityId. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
