[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
[ https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706440#comment-16706440 ] Shi Jinghai commented on OFBIZ-10655: - Committed, rev 1848009. > OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package > - > > Key: OFBIZ-10655 > URL: https://issues.apache.org/jira/browse/OFBIZ-10655 > Project: OFBiz > Issue Type: Bug > Components: pricat >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Shi Jinghai >Priority: Major > Attachments: OFBIZ-10655.patch > > > Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
[ https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706170#comment-16706170 ] Jacques Le Roux commented on OFBIZ-10655: - Could you please commit Jinghai? > OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package > - > > Key: OFBIZ-10655 > URL: https://issues.apache.org/jira/browse/OFBIZ-10655 > Project: OFBiz > Issue Type: Bug > Components: pricat >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Shi Jinghai >Priority: Major > Attachments: OFBIZ-10655.patch > > > Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
[ https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698855#comment-16698855 ] Jacques Le Roux commented on OFBIZ-10655: - +1 > OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package > - > > Key: OFBIZ-10655 > URL: https://issues.apache.org/jira/browse/OFBIZ-10655 > Project: OFBiz > Issue Type: Bug > Components: pricat >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Shi Jinghai >Priority: Major > Attachments: OFBIZ-10655.patch > > > Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
[ https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698692#comment-16698692 ] Shi Jinghai commented on OFBIZ-10655: - Hi Jacques, Yeah, very strange, yesterday, I created the patch with eclipse subclipse plugin, I didn't test it locally before uploading. I just tried to use TortoiseSVN to create a new patch, it's the same as the one here. After applying the patch in my local environment, I have to remove the plugins/pricat/src/main/java/org/apache/poi/ manully. > OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package > - > > Key: OFBIZ-10655 > URL: https://issues.apache.org/jira/browse/OFBIZ-10655 > Project: OFBiz > Issue Type: Bug > Components: pricat >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Shi Jinghai >Priority: Major > Attachments: OFBIZ-10655.patch > > > Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
[ https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698594#comment-16698594 ] Jacques Le Roux commented on OFBIZ-10655: - HI Jinghai, I see a redundancy in your patch (OFBizPricatUtil.java is removed 3 times) and when applied the previous path to it is not removed (plugins/pricat/src/main/java/org/apache/poi/xssf/usermodel). Apart that, it can be applied in Eclipse, it compiles and is OK with me, thanks. > OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package > - > > Key: OFBIZ-10655 > URL: https://issues.apache.org/jira/browse/OFBIZ-10655 > Project: OFBiz > Issue Type: Bug > Components: pricat >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Shi Jinghai >Priority: Major > Attachments: OFBIZ-10655.patch > > > Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (OFBIZ-10655) OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package
[ https://issues.apache.org/jira/browse/OFBIZ-10655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16698073#comment-16698073 ] Shi Jinghai commented on OFBIZ-10655: - Hi Jacques, I moved the OFBizPricatUtil to org.apache.ofbiz.pricat package in the patch, please check whether it's right. Thanks, > OFBizPricatUtil class don't use a org.apache.ofbiz.pricat package > - > > Key: OFBIZ-10655 > URL: https://issues.apache.org/jira/browse/OFBIZ-10655 > Project: OFBiz > Issue Type: Bug > Components: pricat >Affects Versions: Trunk, 17.12.01 >Reporter: Jacques Le Roux >Assignee: Shi Jinghai >Priority: Major > Attachments: OFBIZ-10655.patch > > > Hi [~shi.jinghai], I noticed this anomaly, is there a reason for it? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
