[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-04 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783155#comment-16783155
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

I wait the [decision in dev ML|https://markmail.org/message/7utt6ylkntjzix27] 
before committing the  [^OWASP-failure.patch].

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch, 
> OWASP-failure.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782712#comment-16782712
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

It works here with  [^OWASP-failure.patch] applied


{noformat}
C:\projectsASF\ofbiz>gradlew -PenableOwasp dependencyCheckAnalyze

> Task :dependencyCheckAnalyze
Verifying dependencies for project ofbiz
Checking for updates and analyzing vulnerabilities for dependencies
A new version of dependency-check is available. Consider updating to version 
5.0.0.m1.

Unable to download pom.xml for 
org.eclipse.datatools.enablement.postgresql-1.1.1.v201205252207.jar from 
Central; this could result in undetected CPE/CVEs.
Unable to download pom.xml for org.apache.batik.transcoder-1.6.0.jar from 
Central; this could result in undetected CPE/CVEs.
Unable to download pom.xml for org.apache.batik.xml-1.6.0.jar from Central; 
this could result in undetected CPE/CVEs.
Unable to download pom.xml for org.apache.xerces-2.9.0.jar from Central; this 
could result in undetected CPE/CVEs.
Unable to download pom.xml for 
org.eclipse.datatools.modelbase.sql.query-1.1.4.v201212120619.jar from Central; 
this could result in undetected CPE/CVEs.
Unable to download pom.xml for Tidy-1.jar from Central; this could result in 
undetected CPE/CVEs.
Unable to download pom.xml for org.w3c.css.sac-1.3.0.jar from Central; this 
could result in undetected CPE/CVEs.
Unable to download pom.xml for 
org.eclipse.datatools.connectivity.console.profile-1.0.10.v201109250955.jar 
from Central; this could result in undetected CPE/CVEs.
Unable to download pom.xml for org.apache.commons.codec-1.3.0.jar from Central; 
this could result in undetected CPE/CVEs.
Unable to download pom.xml for aspectjrt-1.5.3.jar from Central; this could 
result in undetected CPE/CVEs.
Unable to download pom.xml for antlr-2.7.6.jar from Central; this could result 
in undetected CPE/CVEs.

> Task :dependencyCheckAnalyze
Generating report for project ofbiz
Found 498 vulnerabilities in project ofbiz


One or more dependencies were identified with known vulnerabilities:

asciidoctorj-1.5.7.jar (cpe:/a:jruby:jruby:1.5.7, 
org.asciidoctor:asciidoctorj:1.5.7) : CVE-2011-4838, CVE-2012-5370
[...]
{noformat}


> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch, 
> OWASP-failure.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782674#comment-16782674
 ] 

Mathieu Lirzin commented on OFBIZ-10700:


Here you are [^OWASP-failure.patch] :)
 I observe the same behavior when checking out revision 1854593 which 
correspond the commit before 
[^OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch] has been applied.

In fact the error message I get is not stable, here is what I am getting 
currenly when running {{./gradlew -PenableOwasp dependencyCheckAnalyze}}:
{code:java}
> Task :dependencyCheckAnalyze
Verifying dependencies for project ofbiz
Checking for updates and analyzing vulnerabilities for dependencies
Unable to update Cached Web DataSource, using local data instead. Results may 
not include recent vulnerabilities.
No documents exist

Unable to continue dependency-check analysis.

> Task :dependencyCheckAnalyze FAILED
{code}

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch, 
> OWASP-failure.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782663#comment-16782663
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

Mathieu,

Please provide a patch...

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782662#comment-16782662
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

Michael,

I started a convo on dev ML, better discuss there...

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782661#comment-16782661
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

Yes, Jira is stupidely adding the ":" in the URL, removed

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782660#comment-16782660
 ] 

Mathieu Lirzin commented on OFBIZ-10700:


Hello [~mbrohl],

the actual link is 
https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check 
without the final ':'

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Michael Brohl (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782658#comment-16782658
 ] 

Michael Brohl commented on OFBIZ-10700:
---

{quote}Actually let's think about it. I added the OWASP Dependency Check 
feature before we switched to Gradle. It was then really useful, but it's no 
disputable as explained at 
[https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check:]
{quote}
This link does not work for me.
{quote}So one option would be to completly remove this feature, what do you 
think, should we not discuss that on dev ML?
{quote}
I did not get the point why you want to disable the feature?

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782657#comment-16782657
 ] 

Mathieu Lirzin commented on OFBIZ-10700:


Hello [~jacques.le.roux],

I tried the version proposed by [~shi.jinghai] which fixes the Gradle DSL bug I 
introduced. However I now get the following error when running {{./gradlew 
-PenableOwasp dependencyCheckAnalyze}}:

{code}
> Task :dependencyCheckAnalyze
Verifying dependencies for project ofbiz
Checking for updates and analyzing vulnerabilities for dependencies

IO Exception: Connection reset
IO Exception: Connection reset
IO Exception: Connection reset
IO Exception: Connection reset
IO Exception: Connection reset

> Task :dependencyCheckAnalyze FAILED
Unable to download the NVD CVE data; the results may not include the most 
recent CPE/CVEs from the NVD.
Unable to update Cached Web DataSource, using local data instead. Results may 
not include recent vulnerabilities.
No documents exist

Unable to continue dependency-check analysis.
IO Exception: Connection reset

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':dependencyCheckAnalyze'.
> Analysis failed.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug 
option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 8s
1 actionable task: 1 executed
{code}

Do you get same results?

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782649#comment-16782649
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

I start a convo on dev ML...

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782648#comment-16782648
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

BTW I just had a look and the report (in build\reports) is barely usable, for 
instance reports about
 * apache:xml-rpc:3.1.3 was fixed in OFBiz (it's 
[CVE-2011-3600|https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2011-3600] 
which is unclear because Archiva and the ASF at large did not report text to 
the CVE, cf *[CVE-2016-5002|https://nvd.nist.gov/vuln/detail/CVE-2016-5002]*)

 * groovy-2.4.15.jar not a problem we use groovy-2.4.16.jar

 * tomcat-catalina-9.0.13.jar, makes no sense, no problem there.


I did not dig further, but I believe unfortunately unlike before this report is 
useless and time wasting.

 

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-03 Thread Jacques Le Roux (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782646#comment-16782646
 ] 

Jacques Le Roux commented on OFBIZ-10700:
-

Actually let's think about it. I added the OWASP Dependency Check feature 
before we switched to Gradle. It was then really useful, but it's no disputable 
as explained at 
[https://cwiki.apache.org/confluence/display/OFBIZ/About+OWASP+Dependency+Check:]
{quote}Since OFBiz uses Gradle, all dependent libraries (ie also dependencies 
from the libraries OFBiz uses and recursively) are loaded by Gradle and 
analysed by the OWASP Dependency Check plugin. So it's materially impossible to 
check all the possible vulnerabilities. I decided to only check the higher 
ones, currently (2017-09-29) we have only already know ones:
{quote}
So one option would be to completly remove this feature, what do you think, 
should we not discuss that on dev ML?

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-02 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782618#comment-16782618
 ] 

Shi Jinghai commented on OFBIZ-10700:
-

Hi Mathieu,

You are absolutely right.

The only one pro I suggested is that I can see all plugins in plugins, and make 
me easy to check whether any plugin should be upgraded.

Kind Regards,

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-02 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782434#comment-16782434
 ] 

Mathieu Lirzin commented on OFBIZ-10700:


Hello [~shi.jinghai],

According to the [Gradle 
doc|https://docs.gradle.org/current/userguide/plugins.html#sec:subprojects_plugins_dsl]
 the change you are proposing is about separating the *resolution* and the 
*application* of the {{org.owasp.dependencycheck}} which is useful in 
multi-project builds where you want to apply a plugin only to a subset of 
subprojects. I guess (without testing) that plugins *resolution* mean that the 
plugin is downloaded which in our case would be better to avoid as long as the 
{{enableOwasp}} property is not provided. As a consequence If this guess is 
correct I would prefer to keep the {{plugins}} block inside the {{if}} 
otherwise I will be fine with the version you are proposing. Please correct me 
if I am making a wrong guess or missing some other obvious advantage of the 
second form.

Thanks

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2019-03-02 Thread Shi Jinghai (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782398#comment-16782398
 ] 

Shi Jinghai commented on OFBIZ-10700:
-

Hi Mathieu,

Brilliant!

I suggest change 
{code:java}
if (project.hasProperty('enableOwasp')) {
plugins {
id 'org.owasp.dependencycheck' version '3.0.2'
}
}{code}
to 
{code:java}
plugins {
...
id "org.owasp.dependencycheck" version "3.0.2" apply false
}

if (project.hasProperty('enableOwasp')) {
apply plugin: 'org.owasp.dependencycheck'
}{code}
What do you think?

Kind Regards,

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (OFBIZ-10700) Use the Gradle Plugin DSL

2018-12-10 Thread Mathieu Lirzin (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-10700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16714701#comment-16714701
 ] 

Mathieu Lirzin commented on OFBIZ-10700:


I have included [^OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch] to use 
the {{plugins {\}}} block.

> Use the Gradle Plugin DSL
> -
>
> Key: OFBIZ-10700
> URL: https://issues.apache.org/jira/browse/OFBIZ-10700
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-10700_Improved-Use-the-Gradle-Plugin-DSL.patch
>
>
> Since Gradle 2.1 it is recommended to use the {{plugins {}}} block for
> binary plugins instead of the “traditional” {{apply()}} method.  See 
> [here|https://docs.gradle.org/current/userguide/plugins.html] for more 
> details.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)