[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759368#comment-16759368
]
Jacques Le Roux commented on OFBIZ-10814:
-
Michael,
Right, after finishing my review, I
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759348#comment-16759348
]
Deepak Dixit commented on OFBIZ-10814:
--
Michael,
Patch looks good, I think you can commit it.
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759345#comment-16759345
]
Michael Brohl commented on OFBIZ-10814:
---
{quote}Should we not use HttpHeaders.AUTHORIZATION in
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759342#comment-16759342
]
Jacques Le Roux commented on OFBIZ-10814:
-
Thanks Deepak,
We crossed on wire (did not update
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759341#comment-16759341
]
Jacques Le Roux commented on OFBIZ-10814:
-
Hi Michael,
Should we not use
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759295#comment-16759295
]
Deepak Dixit commented on OFBIZ-10814:
--
Hi Jacques,
This is similar to LoginWorker.login method,
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759138#comment-16759138
]
Jacques Le Roux commented on OFBIZ-10814:
-
Hi Michael,
I tested your changes with the trunk, it
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754841#comment-16754841
]
Jacques Le Roux commented on OFBIZ-10814:
-
Hi Jacopo,
This is indeed a fine architecture idea
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754772#comment-16754772
]
Jacopo Cappellato commented on OFBIZ-10814:
---
Michael wrote:
{quote}if I understand it
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16754040#comment-16754040
]
Jacques Le Roux commented on OFBIZ-10814:
-
Hi Michael,
Please wait a bit I'd like to test the
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753090#comment-16753090
]
Michael Brohl commented on OFBIZ-10814:
---
I've updates the examples application with a hint to the
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753047#comment-16753047
]
Jacques Le Roux commented on OFBIZ-10814:
-
When OFBIZ-10751 will be done, in security.properties
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16753044#comment-16753044
]
Jacques Le Roux commented on OFBIZ-10814:
-
Hi Michael,
bq. I think it is the best solution to
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751617#comment-16751617
]
Michael Brohl commented on OFBIZ-10814:
---
Hi Jacques,
yes, you are right, I forgot about the
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751594#comment-16751594
]
Jacques Le Roux commented on OFBIZ-10814:
-
Michael,
In the discussion you started on dev ML
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749599#comment-16749599
]
Jacques Le Roux commented on OFBIZ-10814:
-
You are right, this is now useless. I forgot to
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16749058#comment-16749058
]
Michael Brohl commented on OFBIZ-10814:
---
Actually the webappName is passed to sendJWT and then
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748881#comment-16748881
]
Jacques Le Roux commented on OFBIZ-10814:
-
Hi Michael,
Actually the webappName is passed to
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748815#comment-16748815
]
Michael Brohl commented on OFBIZ-10814:
---
Hi [~jacques.le.roux],
another question: the
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748777#comment-16748777
]
Michael Brohl commented on OFBIZ-10814:
---
Hi [~deepak.dixit],
if I understand it correctly, the
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748664#comment-16748664
]
Deepak Dixit commented on OFBIZ-10814:
--
Hi [~mbrohl],
Its filter and if we want to user token as
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748662#comment-16748662
]
Michael Brohl commented on OFBIZ-10814:
---
Another question, [~deepak.dixit] and [~jacques.le.roux]:
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748637#comment-16748637
]
Deepak Dixit commented on OFBIZ-10814:
--
Thanks Michael,
Indeed these are the separate issue and can
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748611#comment-16748611
]
Michael Brohl commented on OFBIZ-10814:
---
Hi [~deepak.dixit],
One minor improvement in
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748504#comment-16748504
]
Jacques Le Roux commented on OFBIZ-10814:
-
Good idea Deepak,
Michael, I commented in the dev ML
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748445#comment-16748445
]
Deepak Dixit commented on OFBIZ-10814:
--
One minor improvement in
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16748389#comment-16748389
]
Deepak Dixit commented on OFBIZ-10814:
--
Thanks Michael,
Changes look good to me.
> Error parsing
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747030#comment-16747030
]
Jacques Le Roux commented on OFBIZ-10814:
-
Indeed
> Error parsing JWT
> -
>
>
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747024#comment-16747024
]
Michael Brohl commented on OFBIZ-10814:
---
Ok, I will start a new discussion in the dev mailing
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747006#comment-16747006
]
Jacques Le Roux commented on OFBIZ-10814:
-
Thanks Michael,
You said.
bq. In current OOTB OFBiz,
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746989#comment-16746989
]
Michael Brohl commented on OFBIZ-10814:
---
Everything is described above but in brief: with the now
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746926#comment-16746926
]
Jacques Le Roux commented on OFBIZ-10814:
-
Yes, that's what I saw refactoring in
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746735#comment-16746735
]
Michael Brohl commented on OFBIZ-10814:
---
The ExternalLoginKeysManager was mainly refactored, the
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746660#comment-16746660
]
Jacques Le Roux commented on OFBIZ-10814:
-
Hi Michael,
>From my review of
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746413#comment-16746413
]
Michael Brohl commented on OFBIZ-10814:
---
I have attached a patch fixing which contains the
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746388#comment-16746388
]
Jacques Le Roux commented on OFBIZ-10814:
-
I have no preference
> Error parsing JWT
>
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746278#comment-16746278
]
Michael Brohl commented on OFBIZ-10814:
---
Another question: the used JWT API expects to get the key
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746209#comment-16746209
]
Michael Brohl commented on OFBIZ-10814:
---
Ok, thanks Deepak and Jacques, I'll try to improve and
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746199#comment-16746199
]
Michael Brohl commented on OFBIZ-10814:
---
ExternalLoginKeysManager.checkJWTLogin has it's own
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746204#comment-16746204
]
Deepak Dixit commented on OFBIZ-10814:
--
One suggestion,
We can use HttpHeaders.AUTHORIZATION
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746203#comment-16746203
]
Deepak Dixit commented on OFBIZ-10814:
--
Thanks Michael, Please proceed with your suggestion.
>
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746201#comment-16746201
]
Jacques Le Roux commented on OFBIZ-10814:
-
Michael,
I agree about
bq. have all claims pass so
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746191#comment-16746191
]
Michael Brohl commented on OFBIZ-10814:
---
Another comment:
JWTManager.validateToken strips all
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746184#comment-16746184
]
Michael Brohl commented on OFBIZ-10814:
---
Hi Deepak, thanks for looking at it.
To my
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746179#comment-16746179
]
Deepak Dixit commented on OFBIZ-10814:
--
Hi Michael,
The issue is in the header attribute, Need to
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746157#comment-16746157
]
Jacques Le Roux commented on OFBIZ-10814:
-
HI Michael,
Not at the moment, but sure I'll ASAP
>
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16746087#comment-16746087
]
Michael Brohl commented on OFBIZ-10814:
---
Hi [~deepak.dixit], [~jacques.le.roux],
can you please
[
https://issues.apache.org/jira/browse/OFBIZ-10814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745245#comment-16745245
]
Michael Brohl commented on OFBIZ-10814:
---
Added a simple Postman [1] collection for easy testing.
48 matches
Mail list logo
