[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17832419#comment-17832419 ] ASF subversion and git services commented on OFBIZ-11030: - Commit e47086d269c73ca8bafe97a9ec620174bac938ba in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=e47086d26 ] Improved: Convert FactServices.xml minilang to groovy. (OFBIZ-11030) Replaces UtilValidate.isNotEmpty() by Groovy Truth > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067756#comment-17067756 ] ASF subversion and git services commented on OFBIZ-11030: - Commit 492dcb9208e0daeb853bd5bd7f2499aae9afd099 in ofbiz-plugins's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-plugins.git;h=492dcb9 ] Improved: fixes a typo due to OFBIZ-11030 Thanks: Pierre Smits for spotting it > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Labels: Fact, dwh, services > Fix For: Upcoming Branch > > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058927#comment-17058927 ] Pierre Smits commented on OFBIZ-11030: -- And thank you, [~pierresmits], for your review and testing! > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Michael Brohl >Priority: Major > Labels: Fact, dwh, services > Fix For: Upcoming Branch > > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17055075#comment-17055075 ] Sebastian Berg commented on OFBIZ-11030: Hi, I updated the groovy formatting accordingly and reuploaded the patch. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17054933#comment-17054933 ] Michael Brohl commented on OFBIZ-11030: --- [~sberg]I think the latest patch needs more refactoring to be more "groovyish", e.g. replace the UtilValidate.isEmpty with the appropriate Groovy checks. See the reviews from Nicolas in other Jiras. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049584#comment-17049584 ] Pierre Smits commented on OFBIZ-11030: -- Then I guess we're good to go and have this merged, so that the project can move forward. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049351#comment-17049351 ] Pierre Smits commented on OFBIZ-11030: -- Thanks, [~sberg], Must be on my side then. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049345#comment-17049345 ] Sebastian Berg commented on OFBIZ-11030: Hi [~pierresmits], for me new entries appear in SalesInvoiceItemFact as well as SalesOrderItemFact. Patch should be fine. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049229#comment-17049229 ] Pierre Smits commented on OFBIZ-11030: -- Hi [~sberg], Did you see, while testing, data appearing in either SalesInvoiceItemFact entity or SalesOrderItemFact entity with latest patch? I currently don't, but that may be the result of some local changes. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049196#comment-17049196
]
Pierre Smits commented on OFBIZ-11030:
--
I got this again when trying to apply your patch in my git client (SourceTree):
{code:java}
git --no-optional-locks -c color.branch=false -c color.diff=false -c
color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c
credential.helper=sourcetree apply -v --reject -p 1
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-4.patch
error: corrupt patch at line 1530
Completed with errors, see above
{code}
> Convert FactServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11030
> URL: https://issues.apache.org/jira/browse/OFBIZ-11030
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Sebastian Berg
>Priority: Major
> Labels: Fact, dwh, services
> Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-InventoryItemFact-DemoTrunk.png,
> OFBIZ-11030-InventoryItemFact-test.png,
> OFBIZ-11030-Order-SalesOrder-overview.png,
> OFBIZ-11030-SalesInvoiceItemFact-test.png,
> OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049189#comment-17049189 ] Sebastian Berg commented on OFBIZ-11030: I reuploaded the patch with the correct if-check. Sorry for the inconvenience. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048488#comment-17048488
]
Pierre Smits commented on OFBIZ-11030:
--
[~sberg]
In 'loadSalesInvoiceItemFact' you have:
{code:java}
// conversion of the invoice currency
if (UtilValidate.isNotEmpty(invoiceItem.productId)) {
inMap = [:]
naturalKeyFields = [:]
inMap.dimensionEntityName = "CurrencyDimension"
{code}
This is not correct.
{code:java}
if (UtilValidate.isNotEmpty(invoiceItem.productId)) {
{code}
This is not correct. Value retrieved should be from the 'currencyUomId' of the
invoice.
> Convert FactServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11030
> URL: https://issues.apache.org/jira/browse/OFBIZ-11030
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Sebastian Berg
>Priority: Major
> Labels: Fact, dwh, services
> Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-InventoryItemFact-DemoTrunk.png,
> OFBIZ-11030-InventoryItemFact-test.png,
> OFBIZ-11030-Order-SalesOrder-overview.png,
> OFBIZ-11030-SalesInvoiceItemFact-test.png,
> OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[
https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046616#comment-17046616
]
Pierre Smits commented on OFBIZ-11030:
--
[~sberg]
Applying the patch gave following in a window in my git client (SourceTree)
{code:java}
git --no-optional-locks -c color.branch=false -c color.diff=false -c
color.status=false -c diff.mnemonicprefix=false -c core.quotepath=false -c
credential.helper=sourcetree apply -v --reject -p 1
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:79:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:107:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:123:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:139:
trailing whitespace.
/Users/nl04748/Downloads/OFBIZ-11030-FactServices.xml-minilang-to-groovy-3.patch:153:
trailing whitespace.
Checking patch bi/groovyScripts/FactServices.groovy...
Checking patch bi/minilang/FactServices.xml...
Checking patch bi/servicedef/services.xml...
Applied patch bi/groovyScripts/FactServices.groovy cleanly.
Applied patch bi/minilang/FactServices.xml cleanly.
Applied patch bi/servicedef/services.xml cleanly.
warning: squelched 49 whitespace errors
warning: 54 lines add whitespace errors.
Completed successfully
{code}
Apart from that, loadInventoryFact() now delivered an acceptable result in a
test.
> Convert FactServices.xml minilang to groovy
> ---
>
> Key: OFBIZ-11030
> URL: https://issues.apache.org/jira/browse/OFBIZ-11030
> Project: OFBiz
> Issue Type: Sub-task
> Components: bi
>Affects Versions: Trunk
>Reporter: Pierre Smits
>Assignee: Sebastian Berg
>Priority: Major
> Labels: Fact, dwh, services
> Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch,
> OFBIZ-11030-InventoryItemFact-DemoTrunk.png,
> OFBIZ-11030-InventoryItemFact-test.png,
> OFBIZ-11030-Order-SalesOrder-overview.png,
> OFBIZ-11030-SalesInvoiceItemFact-test.png,
> OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png
>
>
> With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046358#comment-17046358 ] Pierre Smits commented on OFBIZ-11030: -- No worries, [~sberg]. Human errors do happen. For all kinds of reasons. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046355#comment-17046355 ] Sebastian Berg commented on OFBIZ-11030: You are right [~pierresmits] in loadInventoryFact() were some if-clauses in the wrong place. It should be fine now. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045911#comment-17045911 ] Pierre Smits commented on OFBIZ-11030: -- Thanks [~sberg], I did some aceptance testing with the changes, and it seems to look good. Except for the loading of the InventoryItemFact entity. Compare OFBIZ-11030-InventoryItemFact-test to OFBIZ-11030-InventoryItemFact-DemoTrunk. Maybe you could have a look at this? And there are some flaws implemented previously (e.g. compare OFBIZ-11030-Order-SalesOrder-overview to OFBIZ-11030-SalesOrderItemFact-test, where order DEMO10090 is not included in the SalesOrderItemFact, or the flaws in OFBIZ-11030-SalesInvoiceItemFact-test) With the GIGO (Garbage In Garbage Out) regarding the pre-change code the project should decide wether or not accept the migration. I suggest it should, and deal with the bug fixes at a later date. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-InventoryItemFact-DemoTrunk.png, > OFBIZ-11030-InventoryItemFact-test.png, > OFBIZ-11030-Order-SalesOrder-overview.png, > OFBIZ-11030-SalesInvoiceItemFact-test.png, > OFBIZ-11030-SalesOrderItemFact-test.png, OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045547#comment-17045547 ] Sebastian Berg commented on OFBIZ-11030: I have reuploaded the patch, it should work now. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045450#comment-17045450 ] Pierre Smits commented on OFBIZ-11030: -- When trying to apply the patch I get an error as shown in uploaded image. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch, > OFBIZ-11030-applyPatch-error.png > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045403#comment-17045403 ] Pierre Smits commented on OFBIZ-11030: -- HI [~sberg], A cursory review looks good. I will test later today. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > Attachments: OFBIZ-11030-FactServices.xml-minilang-to-groovy.patch > > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044456#comment-17044456 ] Pierre Smits commented on OFBIZ-11030: -- Ahh. Ok. Thanks for the update. I will postpone changes to Fact tables. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044452#comment-17044452 ] Sebastian Berg commented on OFBIZ-11030: Hi [~pierresmits], I have migrated the the Methods already and am currently testing my work. I will provide the results as soon as possible for you to enhance them. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11030) Convert FactServices.xml minilang to groovy
[ https://issues.apache.org/jira/browse/OFBIZ-11030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044433#comment-17044433 ] Pierre Smits commented on OFBIZ-11030: -- Hi [~sberg], Do you mind if I takes this on me. I am regarding OFBIZ-111414 related services already doing the new services in groovy, and with upcoming improvements to various fact tables I need to enhance the services and underlying functions therefore. > Convert FactServices.xml minilang to groovy > --- > > Key: OFBIZ-11030 > URL: https://issues.apache.org/jira/browse/OFBIZ-11030 > Project: OFBiz > Issue Type: Sub-task > Components: bi >Affects Versions: Trunk >Reporter: Pierre Smits >Assignee: Sebastian Berg >Priority: Major > Labels: Fact, dwh, services > > With the purpose to deprecate mini-lang OFBIZ-9350, convert FactServices.xml -- This message was sent by Atlassian Jira (v8.3.4#803005)
