[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837303#comment-17837303
]
Jacques Le Roux commented on OFBIZ-11067:
-
(y)
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837285#comment-17837285
]
ASF subversion and git services commented on OFBIZ-11067:
-
Commit 739c02563fdadb00df0849521a82eca5c13449c4 in ofbiz-framework's branch
refs/heads/trunk from Gil Portenseigne
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=739c02563f ]
Fixed: Migrate integration tests to unit tests when possible (OFBIZ-11067)
Move unit test that are not currently running.
Make those tests pass, adding a TODO, where an object reference
comparison was done.
Thanks Gaëtan for your contribution
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837282#comment-17837282
]
Jacques Le Roux commented on OFBIZ-11067:
-
Yes sure please do Gil, thanks
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837261#comment-17837261
]
Gil Portenseigne commented on OFBIZ-11067:
--
Hi [~jleroux] , if you don't mind, i will take care of it at the same time.
There is a git move and this modification in the patch to make the
FlexibleMapAccessorTests run.
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837175#comment-17837175
]
Jacques Le Roux commented on OFBIZ-11067:
-
HI Gaetan,
Your patch is weird:
{quote}
C:\projectsASF\Git\ofbiz-framework>git apply 11067.patch
error: corrupt patch at line 1132
{quote}
Can you confirm the only change is
{code:java}
.../java/org/apache/ofbiz/base/util/string/FlexibleStringExpander.java | 3 +++
1 file changed, 3 insertions(+)
diff --git
a/framework/base/src/main/java/org/apache/ofbiz/base/util/string/FlexibleStringExpander.java
b/framework/base/src/main/java/org/apache/ofbiz/base/util/string/FlexibleStringExpander.java
index 9e86b50fa8..6a60a166b6 100644
---
a/framework/base/src/main/java/org/apache/ofbiz/base/util/string/FlexibleStringExpander.java
+++
b/framework/base/src/main/java/org/apache/ofbiz/base/util/string/FlexibleStringExpander.java
@@ -393,6 +393,9 @@ public abstract class FlexibleStringExpander implements
Serializable, IsEmpty {
Map autoUserLogin =
UtilGenerics.cast(context.get("autoUserLogin"));
locale =
UtilMisc.ensureLocale(autoUserLogin.get("lastLocale"));
}
+if (locale == null &&
context.containsKey(UelUtil.getLocalizedMapLocaleKey())) {
+locale =
UtilMisc.ensureLocale(context.get(UelUtil.getLocalizedMapLocaleKey()));
+}
if (locale == null) {
locale = Locale.getDefault();
}
{code}
Else please provide another patch, or a PR.
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837143#comment-17837143
]
Gaetan Chaboussie commented on OFBIZ-11067:
---
New patch including the FlexibleMapAccessor test file that was forgotten in
previous patch
[^Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch]
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch,
>
> Patch_with_FlexibleMapAccessorTests_included_that_was_forgotten_in_the_previous_patch.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837094#comment-17837094
]
Gil Portenseigne commented on OFBIZ-11067:
--
i do it this day :D
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17835187#comment-17835187
]
Gil Portenseigne commented on OFBIZ-11067:
--
Sure, i will when i got some time :)
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834981#comment-17834981
]
Jacques Le Roux commented on OFBIZ-11067:
-
Hi [~pgil], would you mind handle it?
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834946#comment-17834946
]
Gaetan Chaboussie commented on OFBIZ-11067:
---
Hi, during OFBIZ-12991 i stumbled upon two tests classes that escaped
migration, and that wil be necessary for the migration.
here are the two classes (and the patch that fixes tham). Thanks [~pgil] for
the help
[^OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch]
[^OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch]
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Assignee: Jacques Le Roux
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch,
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests-1.patch,
>
> OFBIZ-11067_fixes_FlexibleStringExpanderTests_and_FlexibleMapAcessor_tests.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests-1.patch,
>
> OFBIZ-11067_turns_FlexibleMapAccessorTests_and_FlexibleStringExpanderTests_into_unit_tests.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819622#comment-17819622
]
ASF subversion and git services commented on OFBIZ-11067:
-
Commit 940ada36260ba7f13e0dc62986b95ec381a978df in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=940ada3626 ]
Improved: Migrate integration tests to unit tests when possible (OFBIZ-11067)
Fixes previous commit where @Test was place one line too low
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819614#comment-17819614
]
ASF subversion and git services commented on OFBIZ-11067:
-
Commit 0e657234cf59da498c5365760096a0c3fec63c95 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=0e657234cf ]
Improved: Migrate integration tests to unit tests when possible (OFBIZ-11067)
According to Mathieu, this closes the Jira. As he mentioned:
The remaining classes to convert to unit test before closing this ticket are:
FlexibleStringExpanderTests
FlexibleMapAccessorTests
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819572#comment-17819572
]
ASF subversion and git services commented on OFBIZ-11067:
-
Commit 65be575cdd1a2712a0e9b38603f4339952d79f60 in ofbiz-framework's branch
refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=65be575cdd ]
Improved: Migrate integration tests to unit tests when possible (OFBIZ-11067)
As mentioned by Mathieu in (OFBIZ-11014)
https://github.com/apache/ofbiz-framework/commit/aa874841cea2652dc193b919120fa77a9d50184f
<>
It uses @Ignore("Failing test") so better remove it
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk, Upcoming Branch
>Reporter: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960440#comment-16960440
]
Mathieu Lirzin commented on OFBIZ-11067:
Committed
[^OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch] in
revision 1869022.
Committed
[^OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch] in
revision 1869023.
The remaining classes to convert to unit test before closing this ticket are:
* FlexibleStringExpanderTests
* FlexibleMapAccessorTests
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch,
> OFBIZ-11067_0018-Turn-UtilObjectTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0019-Merge-UtilObjectUnitTest-into-UtilObjectTes.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848293#comment-16848293
]
Mathieu Lirzin commented on OFBIZ-11067:
Committed patches 8 to 17 on trunk in revisions: r1860015 r1860016 r1860017
r1860018 r1860019 r1860020 r1860021 r1860022 r1860023 r1860024
The remaining classes to convert to unit test before closing this ticket are:
- FlexibleStringExpanderTests
- FlexibleMapAccessorTests
- UtilObjectTests
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0008-Turn-ReferenceCleanerTests-into-a-unit-test.patch,
> OFBIZ-11067_0009-Turn-TimeDurationTests-into-a-unit-test-cla.patch,
> OFBIZ-11067_0010-Turn-UtilCacheTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0011-Remove-empty-UtilHttpTests-class.patch,
> OFBIZ-11067_0012-Turn-UtilIOTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0013-Turn-UtilMiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0014-Turn-AssertTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0015-Turn-BaseUnitTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0016-Turn-TestBooleanConverters-into-a-unit-test.patch,
> OFBIZ-11067_0017-Turn-TestJSONConverters-into-a-unit-test-cl.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848217#comment-16848217
]
Mathieu Lirzin commented on OFBIZ-11067:
When trying to convert {{FlexibleMapAccessorsTests}} class to unit test, the
{{testFlexibleMapAccessor}} test fails, I will investigate more later.
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848214#comment-16848214
]
Mathieu Lirzin commented on OFBIZ-11067:
{{UtilPropertiesTests}} is surprisingly slow meaning it takes around 30 second
to execute on my machine. If someone want to investigate the reason for this
slowness, please do.
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (OFBIZ-11067) Migrate integration tests to unit tests when possible
[
https://issues.apache.org/jira/browse/OFBIZ-11067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848213#comment-16848213
]
Mathieu Lirzin commented on OFBIZ-11067:
Committed patches 1 to 7 on trunk in revisions r1859975 r1859976 r1859977
r1859978 r1859979 r1859982 r1859984
> Migrate integration tests to unit tests when possible
> -
>
> Key: OFBIZ-11067
> URL: https://issues.apache.org/jira/browse/OFBIZ-11067
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
>Affects Versions: Trunk
>Reporter: Mathieu Lirzin
>Assignee: Mathieu Lirzin
>Priority: Minor
> Attachments:
> OFBIZ-11067_0001-Turn-UtilPropertiesTests-into-a-unit-test-c.patch,
> OFBIZ-11067_0002-Turn-ComparableRangeTests-into-a-unit-test-.patch,
> OFBIZ-11067_0003-Turn-DateTimeTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0004-Turn-GenericMapTest-into-a-unit-test-class.patch,
> OFBIZ-11067_0005-Turn-IndentingWriterTests-into-a-unit-test-.patch,
> OFBIZ-11067_0006-Turn-MiscTests-into-a-unit-test-class.patch,
> OFBIZ-11067_0007-Turn-ObjectTypeTests-into-a-unit-test-class.patch
>
>
> In OFBiz there are both unit tests and integration tests which are
> respectively run by {{./gradlew test}} and {{./gradlew testIntegration}}.
> However some integration tests are in fact unit tests that doesn't depend on
> the entity and service engines. Those unit tests should run on the their
> appropriate task.
> To do that it is necessary to convert them to use Junit4 instead of Junit3
> which is what is done for the integration test suite.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
