[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2020-05-25 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115799#comment-17115799
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

Hello [~lodhiravi],

This improvement tend to reduce a lot the error log noise. But, if my memory is 
clear, i think the multi thread part make it complicated to remove completly 
the issue.

If you have a way to improve this contribution, that'd be great !

Thanks

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2020-05-23 Thread Ravi Lodhi (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17114744#comment-17114744
 ] 

Ravi Lodhi commented on OFBIZ-11204:


Hello Team,

I tried to test the mentioned fix by backporting to release17.12 and 
release18.12 branch and found that the error still appears. 

To test the changes I have created a test service with the *semaphore* 
attribute set to *wait* in the service definition. I called this service 
asynchronously from a loop to create a large number of  JobSandbox records (I 
called that service 100,000 times in a loop). Once the async jobs start 
executing I closely watched the console logs.

Though the frequency was low, still that error (Failure in create operation for 
entity ServiceSemaphore) comes during the execution.

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2020-05-06 Thread Jacques Le Roux (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100525#comment-17100525
 ] 

Jacques Le Roux commented on OFBIZ-11204:
-

Hi Suraj,

OK on my side for all supported release branches

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2020-05-06 Thread Suraj Khurana (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100503#comment-17100503
 ] 

Suraj Khurana commented on OFBIZ-11204:
---

Hello team,

We are facing this issue on release branch, can we backport?

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2019-10-25 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959867#comment-16959867
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

Thanks [~jleroux] and [~mthl] for your feedbacks :)

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Fix For: Trunk
>
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2019-10-06 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945430#comment-16945430
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

hi [~mthl] , I updated the patch with missing modification within 
ServiceDispatcher.java, sorry for the inconvenience and thanks for your test :).

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-11204.patch, OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2019-10-05 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945248#comment-16945248
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

Oh ! Sorry there might have been something with the patch... I'll answer at the 
end of the day...

 

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2019-10-05 Thread Mathieu Lirzin (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945152#comment-16945152
 ] 

Mathieu Lirzin commented on OFBIZ-11204:


Hello Gil,

I have tried  [^OFBIZ-11204.patch]  but I got a compile error when running 
{{gradlew}} with the following message:

{code}
...
/home/mthl/src/ofbiz/framework/service/src/main/java/org/apache/ofbiz/service/ServiceDispatcher.java:597:
 error: exception GenericServiceException is never thrown in body of 
corresponding try statement
} catch (GenericServiceException e) {
  ^
1 error
8 warnings

> Task :compileJava FAILED
{code}
Have you the same issue on your side?

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2019-10-05 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16945081#comment-16945081
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

Yes I deleted the first ones, the valid one is the unique for the Jira

 

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2019-10-04 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944530#comment-16944530
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

Information mail done in dev mailing list : [https://s.apache.org/kjiio]

 

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  

[jira] [Commented] (OFBIZ-11204) Remove unwanted error log by `ServiceSemaphore` waiting process

2019-09-25 Thread Gil Portenseigne (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16937765#comment-16937765
 ] 

Gil Portenseigne commented on OFBIZ-11204:
--

While working on it i did improve the refactoring. I'll update new patches soon

> Remove unwanted error log by `ServiceSemaphore` waiting process
> ---
>
> Key: OFBIZ-11204
> URL: https://issues.apache.org/jira/browse/OFBIZ-11204
> Project: OFBiz
>  Issue Type: Improvement
>  Components: framework
>Affects Versions: Trunk
>Reporter: Gil Portenseigne
>Assignee: Gil Portenseigne
>Priority: Minor
> Attachments: 0001-OFBIZ-11204.patch, 0002-OFBIZ-11204.patch
>
>
> When a lot of semaphore configured service instances are running in a short 
> period, multiple errors of this type are logged :
> {code:none}
> // | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |GenericDelegator  |E| Failure in create operation for entity 
> [ServiceSemaphore]: org.apache.ofbiz.entity.GenericEntityException: Error 
> while inserting: [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lockThread,OFBiz-JobQueue-2(java.lang.String)][lockTime,2019-09-19
>  
> 16:47:44.676(java.sql.Timestamp)][lockedByInstanceId,emb-ofbiz-prd-technical-asg-20171209-01-eu-west-1b(java.lang.String)][serviceName,xxx(java.lang.String)]
>  (SQL Exception while executing the following:INSERT INTO 
> public.SERVICE_SEMAPHORE (SERVICE_NAME, LOCKED_BY_INSTANCE_ID, LOCK_THREAD, 
> LOCK_TIME, LAST_UPDATED_STAMP, LAST_UPDATED_TX_STAMP, CREATED_STAMP, 
> CREATED_TX_STAMP) VALUES (?, ?, ?, ?, ?, ?, ?, ?) (ERROR: duplicate key value 
> violates unique constraint "pk_service_semaphore"   Detail: Key 
> (service_name)=(xxx) already exists.)). Rolling back transaction. 
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>   
>  |
> | 2019-09-19 14:47:44.000 | 2019-09-19 16:47:44,692 |OFBiz-JobQueue-2 
> |ServiceSemaphore  |E| null 
> |
> | 2019-09-19 14:47:44.000 | org.apache.ofbiz.entity.GenericEntityException: 
> org.apache.ofbiz.entity.GenericEntityException: Error while inserting: 
> [GenericEntity:ServiceSemaphore][createdStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][createdTxStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedStamp,2019-09-19 
> 16:47:44.678(java.sql.Timestamp)][lastUpdatedTxStamp,2019-09-19 
>