[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050988#comment-17050988 ] Jacques Le Roux commented on OFBIZ-11229: - bq. Most OFBiz pages will have only one URL, so no canonical URL element is necessary. So we can restrict it to entities that might have duplicate URLs. The prime example is Product. So if we add a canonical for that using the OFBiz productId, that might be all that is needed. Interesting, thanks Paul > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch, > OfbizUrlTransform vs UrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[
https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050707#comment-17050707
]
Paul Foxworthy commented on OFBIZ-11229:
Back in OFBIZ-5312 [~jleroux] asked:
{quote}Good, clean URLs are beneficial for all of OFBiz, not just e-commerce,
not just product information.
{quote}
??Do you think we need to apply the same scheme everywhere? Even in backend???
Yes. It would certainly help for RESTful services. I'll repeat what I said
earlier: URLs are for people, not just computers.
{quote}The solution is to add a canonical URL link
([https://en.wikipedia.org/wiki/Canonical_link_element]) to the content, to
make clear the primary URL and to make clear alternative URLs are just that,
alternative paths to the same thing.
{quote}
??That's quite a good idea, have you an idea on how to implement that in
OFBiz???
Most OFBiz pages will have only one URL, so no canonical URL element is
necessary. So we can restrict it to entities that might have duplicate URLs.
The prime example is Product. So if we add a canonical for that using the OFBiz
productId, that might be all that is needed.
Down the track, URLs like mybiz.com/employee/1234 and mybiz.com/customer/1234
might be interesting, but that can wait until after products.
> Merge UrlRegexpTransform and OfbizUrlTransform classes
> --
>
> Key: OFBIZ-11229
> URL: https://issues.apache.org/jira/browse/OFBIZ-11229
> Project: OFBiz
> Issue Type: Bug
> Components: framework, product
>Affects Versions: Trunk
>Reporter: Jacques Le Roux
>Assignee: Michael Brohl
>Priority: Minor
> Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch,
> OfbizUrlTransform vs UrlRegexpTransform.patch
>
>
> This improvemnt follows Paul's suggestion and this discussion which contains
> other references:
> https://markmail.org/message/bobj2uhnkzjddrtt.
> Globally can be summarised by my comment in this thread:
> bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used
> it everywhere. Now there are maybe few features in OfbizUrlTransform that are
> not in UrlRegexpTransform. That needs to be checked. If we can merge
> OfbizUrlTransform in UrlRegexpTransform then the later could be used
> everywhere.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038134#comment-17038134 ] Jacques Le Roux commented on OFBIZ-11229: - Here is the "UrlRegexpTransform vs OfbizUrlTransform classes" diff: [^OfbizUrlTransform vs UrlRegexpTransform.patch] > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Assignee: Michael Brohl >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch, > OfbizUrlTransform vs UrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17037507#comment-17037507 ] ASF subversion and git services commented on OFBIZ-11229: - Commit 969f48b7c9f692b8a6f1c54e2b4ce6ae1392961b in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=969f48b ] Fixed: Add 'controlPath' attribute to 'ofbizUrl' freemarker macro (OFBIZ-11317) In some place, like at least themes/tomahawk/template/AppBarClose.ftl the CSRF token is not generated. Because in those places OfbizUrlTransform is used. An immediate solution is to add the CSRF token generation in OfbizUrlTransform class. A definitive solution is to complete OFBIZ-11229 "Merge UrlRegexpTransform and OfbizUrlTransform classes" > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950826#comment-16950826 ] Jacques Le Roux commented on OFBIZ-11229: - Ha forgot to mention that of course I did not put the general.properties in ;) > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950278#comment-16950278 ] Jacques Le Roux commented on OFBIZ-11229: - Thanks Nicolas Your patch is in trunk r1868395 R18 r1868396 R17 r1868397 R16 is harder to backport I gave up. I wondered about duplicating convertToString(). But since the idea is to replace OfbizUrlTransform by UrlRegexpTransform it's not a problem. Note: I only created this issue as a bug because OFBIZ-4361 depends on it. Else it would be an improvement. > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11229) Merge UrlRegexpTransform and OfbizUrlTransform classes
[ https://issues.apache.org/jira/browse/OFBIZ-11229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944468#comment-16944468 ] Nicolas Malin commented on OFBIZ-11229: --- To solve issue OFBIZ-4361 I create a first version to merge OfbizUrlTransform in UrlRegexpTransform, the main identify point was when the request isn't present (email send, service call) the website isn't pull from context. It's solve with this patch [^OFBIZ-11229-mergeUrlRegexpTransform.patch] > Merge UrlRegexpTransform and OfbizUrlTransform classes > -- > > Key: OFBIZ-11229 > URL: https://issues.apache.org/jira/browse/OFBIZ-11229 > Project: OFBiz > Issue Type: Bug > Components: framework, product >Affects Versions: Trunk >Reporter: Jacques Le Roux >Priority: Minor > Attachments: OFBIZ-11229-mergeUrlRegexpTransform.patch > > > This improvemnt follows Paul's suggestion and this discussion which contains > other references: > https://markmail.org/message/bobj2uhnkzjddrtt. > Globally can be summarised by my comment in this thread: > bq. I suggest that UrlRegexpTransform (with maybe some changes) could be used > it everywhere. Now there are maybe few features in OfbizUrlTransform that are > not in UrlRegexpTransform. That needs to be checked. If we can merge > OfbizUrlTransform in UrlRegexpTransform then the later could be used > everywhere. -- This message was sent by Atlassian Jira (v8.3.4#803005)
