[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047337#comment-17047337 ] Jacques Le Roux commented on OFBIZ-11301: - Hi Pierre, What, in your opinion, should be the status of this Jira now that the wiki page is no longer in progress? > Clarify usage of Github PR > -- > > Key: OFBIZ-11301 > URL: https://issues.apache.org/jira/browse/OFBIZ-11301 > Project: OFBiz > Issue Type: Sub-task > Components: git >Affects Versions: Release Branch 18.12, Release Branch 17.12, Trunk >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Major > Labels: documentation > > The PullRequest reflex is now an acquired behaviour. > I started a discussion at [https://markmail.org/message/jx426hxxwvllynx3], > summary: > Our workflow is to contribute patches through Jira. We need to clearly > document how the project is going to work with Pull Requests. as part of > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices] > Remark Jacques: _But I know that it will not be enough. So I'll also add a > notice in the top of our main README.adoc to make it clear on our main Github > page_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032849#comment-17032849 ] Jacques Le Roux commented on OFBIZ-11301: - I have moved the comments related to Git and GitHub usage from OFBIZ-11306 to the [wiki page|https://cwiki.apache.org/confluence/display/OFBIZ/Contributing+via+Git+and+Github++-+WIP] > Clarify usage of Github PR > -- > > Key: OFBIZ-11301 > URL: https://issues.apache.org/jira/browse/OFBIZ-11301 > Project: OFBiz > Issue Type: Sub-task > Components: git >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Major > Labels: documentation > > The PullRequest reflex is now an acquired behaviour. > I started a discussion at [https://markmail.org/message/jx426hxxwvllynx3], > summary: > Our workflow is to contribute patches through Jira. We need to clearly > document how the project is going to work with Pull Requests. as part of > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices] > Remark Jacques: _But I know that it will not be enough. So I'll also add a > notice in the top of our main README.adoc to make it clear on our main Github > page_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032847#comment-17032847 ] Jacques Le Roux commented on OFBIZ-11301: - I have made some modifications, notably about drawback of pullAllPluginsSource which is still Svn based > Clarify usage of Github PR > -- > > Key: OFBIZ-11301 > URL: https://issues.apache.org/jira/browse/OFBIZ-11301 > Project: OFBiz > Issue Type: Sub-task > Components: git >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Major > Labels: documentation > > The PullRequest reflex is now an acquired behaviour. > I started a discussion at [https://markmail.org/message/jx426hxxwvllynx3], > summary: > Our workflow is to contribute patches through Jira. We need to clearly > document how the project is going to work with Pull Requests. as part of > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices] > Remark Jacques: _But I know that it will not be enough. So I'll also add a > notice in the top of our main README.adoc to make it clear on our main Github > page_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032244#comment-17032244 ] Pierre Smits commented on OFBIZ-11301: -- The first draft of the guidelines document is now available for review. > Clarify usage of Github PR > -- > > Key: OFBIZ-11301 > URL: https://issues.apache.org/jira/browse/OFBIZ-11301 > Project: OFBiz > Issue Type: Sub-task > Components: git >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Major > Labels: documentation > > The PullRequest reflex is now an acquired behaviour. > I started a discussion at [https://markmail.org/message/jx426hxxwvllynx3], > summary: > Our workflow is to contribute patches through Jira. We need to clearly > document how the project is going to work with Pull Requests. as part of > [https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices] > Remark Jacques: _But I know that it will not be enough. So I'll also add a > notice in the top of our main README.adoc to make it clear on our main Github > page_. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17028340#comment-17028340 ] Pierre Smits commented on OFBIZ-11301: -- Effort to address this has been started. Currently work is done on a WIP page in Confluence, see [https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=145724011] > Clarify usage of Github PR > -- > > Key: OFBIZ-11301 > URL: https://issues.apache.org/jira/browse/OFBIZ-11301 > Project: OFBiz > Issue Type: Sub-task > Components: git >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Pierre Smits >Priority: Minor > Labels: documentation > > I started a discussion at https://markmail.org/message/jx426hxxwvllynx3, > summary: > Our workflow is to contribute patches through Jira. I want to clearly > document that in > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices > But I know that it will not be enough. The PR reflex is now an acquired > behaviour. So I'll also add a notice in the top of our main README.adoc to > make it clear on our main Github page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984956#comment-16984956 ] Jacques Le Roux commented on OFBIZ-11301: - I like the idea of CONTRIBUTING.adoc + 1 > Clarify usage of Github PR > -- > > Key: OFBIZ-11301 > URL: https://issues.apache.org/jira/browse/OFBIZ-11301 > Project: OFBiz > Issue Type: Sub-task > Components: git >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > I started a discussion at https://markmail.org/message/jx426hxxwvllynx3, > summary: > Our workflow is to contribute patches through Jira. I want to clearly > document that in > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices > But I know that it will not be enough. The PR reflex is now an acquired > behaviour. So I'll also add a notice in the top of our main README.adoc to > make it clear on our main Github page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11301) Clarify usage of Github PR
[ https://issues.apache.org/jira/browse/OFBIZ-11301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984879#comment-16984879 ] Mathieu Lirzin commented on OFBIZ-11301: Personnally I think the CONTRIBUTING.adoc file I proposed in OFBIZ-11271 (but did not implement yet) might be a better fit for such information than README.adoc > Clarify usage of Github PR > -- > > Key: OFBIZ-11301 > URL: https://issues.apache.org/jira/browse/OFBIZ-11301 > Project: OFBiz > Issue Type: Sub-task > Components: git >Affects Versions: Trunk, Release Branch 17.12, Release Branch 18.12 >Reporter: Jacques Le Roux >Assignee: Jacques Le Roux >Priority: Minor > > I started a discussion at https://markmail.org/message/jx426hxxwvllynx3, > summary: > Our workflow is to contribute patches through Jira. I want to clearly > document that in > https://cwiki.apache.org/confluence/display/OFBIZ/OFBiz+Contributors+Best+Practices > But I know that it will not be enough. The PR reflex is now an acquired > behaviour. So I'll also add a notice in the top of our main README.adoc to > make it clear on our main Github page. -- This message was sent by Atlassian Jira (v8.3.4#803005)
