[jira] [Commented] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy

2020-04-08 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17078229#comment-17078229
 ] 

ASF subversion and git services commented on OFBIZ-11442:
-

Commit f6418d52f598e64340268fadf2b22d361bdd2a49 in ofbiz-framework's branch 
refs/heads/trunk from Nicolas Malin
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=f6418d5 ]

Improved: Convert OrderReturnService.xml from mini lang to groovy
(OFBIZ-11442)

Thanks to Sebastian Berg for providing the patch


> Convert OrderReturnService mini-lang to groovy
> --
>
> Key: OFBIZ-11442
> URL: https://issues.apache.org/jira/browse/OFBIZ-11442
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
> Attachments: 
> OFBIZ-11442-OrderReturnServices.xml-minilang-to-groovy.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (OFBIZ-11442) Convert OrderReturnService mini-lang to groovy

2020-03-12 Thread Sebastian Berg (Jira)


[ 
https://issues.apache.org/jira/browse/OFBIZ-11442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057906#comment-17057906
 ] 

Sebastian Berg commented on OFBIZ-11442:


Hi,

I finished migrating all methods from minilang to groovy. However I had trouble 
verifying the functionality of a couple Methods, namely 
updateReturnStatusFromReceipt(), createReturnItemForRental(), 
cancelReplacementOrderItems() and quickReturnFromOrder(). For these methods the 
minilang basis seems to be incorrect. I made some minor changes where I could, 
but I suggest someone with more knowledge about the functionality of these 
methods should have a look at this.

Sebastian

> Convert OrderReturnService mini-lang to groovy
> --
>
> Key: OFBIZ-11442
> URL: https://issues.apache.org/jira/browse/OFBIZ-11442
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: order
>Affects Versions: Trunk
>Reporter: Sebastian Berg
>Assignee: Sebastian Berg
>Priority: Minor
> Fix For: Upcoming Branch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)