[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264187#comment-17264187 ] Jacques Le Roux commented on OFBIZ-11809: - >With Gil we tried to resume all concepts on slides here >https://10031.pages.nereide.fr/slides/yolande.html. Great stuff thanks guys :) > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: screen, widget > Fix For: Upcoming Branch > > Attachments: OFBIZ-11808-OFBIZ-11809.patch, > OFBIZ-11808-OFBIZ-11809.patch, OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[
https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264022#comment-17264022
]
Nicolas Malin commented on OFBIZ-11809:
---
Of course no problem Michael.
This issue is a base to simplify and homogenize the screen development and it's
the reason it's a sub task of the OFBIZ-11808.
Alone, the most valuable of this issue isn't clear and will become clearer with
issue OFBIZ-11813 and OFBIZ-11811.
First improvement visible for developer is that the dynamic refresh for a list
(when you sort or paginate) will be directly managed by OFBiz without
informations of the area to refresh. We separated the definition of the area
that a form can update from the screen that include the form.
Typically a facility list will be simplify like this :
{code:xml}
...
...
...
{code}
and this definition will support all theme specifications and all form
dynamism. But for this we have the constraint to found how the form can know
the screen who include it. This is an example with a form but it can be
extended to other element like menu, links, layered-modal and some other
element that we currently not imagine :)
With Gil we tried to resume all concepts on slides here
https://10031.pages.nereide.fr/slides/yolande.html.
Don't hesitate if some you have some doubts, imagine an other solution to do
that or see potential regression that we missed.
> Access to the current screen from any widget element
>
>
> Key: OFBIZ-11809
> URL: https://issues.apache.org/jira/browse/OFBIZ-11809
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Assignee: Nicolas Malin
>Priority: Major
> Labels: screen, widget
> Fix For: Upcoming Branch
>
> Attachments: OFBIZ-11808-OFBIZ-11809.patch,
> OFBIZ-11808-OFBIZ-11809.patch, OFBIZ-11808-OFBIZ-11809.patch
>
>
> During the rendering process, an element have no information on the screen
> that it depend. This not really help to automatism some refresh treatment and
> force the developer to know the screen structure where is the element.
> To solve this situation we implement a new class, ScreenStack that permit at
> every time for an element to identify who it depend. This help to resolve the
> unique Id that the screen take and can be exploit by the theme.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263733#comment-17263733 ] Michael Brohl commented on OFBIZ-11809: --- I know I'm a bit late to he party and somehow missed this issue before. Can you elaborate why this change is needed, do you have an example? > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Assignee: Nicolas Malin >Priority: Major > Labels: screen, widget > Fix For: Upcoming Branch > > Attachments: OFBIZ-11808-OFBIZ-11809.patch, > OFBIZ-11808-OFBIZ-11809.patch, OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263480#comment-17263480 ] ASF subversion and git services commented on OFBIZ-11809: - Commit e0a840a0c4928080f7a3e3bdf3a42e327483939c in ofbiz-framework's branch refs/heads/trunk from Nicolas Malin [ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=e0a840a ] Implemented: Access to the current screen from any widget element (OFBIZ-11809) During the rendering process, an element have no information about the screen which is dependent from. This not really help to automate some refresh treatment and force the developer to know the screen structure where is the element. To solve this situation we implement a new class, ScreenStack that allow anytime for any element to identify its direct dependency. This help to resolve the unique Id that the screen take and can be used by the theme. At any time a developer can retrieve the screen reference with uel function screen:id(screenStack) example: The object screenStack is always present during a rendering process. > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: screen, widget > Attachments: OFBIZ-11808-OFBIZ-11809.patch, > OFBIZ-11808-OFBIZ-11809.patch, OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17262837#comment-17262837 ] Nicolas Malin commented on OFBIZ-11809: --- After a new test, I discover a regression for rendering fop screen and xml screen. The problem came from use the macro renderScreenBegin and renderScreenEnd not to start a screen but for start the rendering in global process. I solve it with the last patch [^OFBIZ-11808-OFBIZ-11809.patch] with dedicate two new macro renderBegin and renderEnd for indicate to start or end a page rendering and keep renderScreenBegin and renderScreenEnd. This avoid any confusion with the xml screen definition and the rendering process > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: screen, widget > Attachments: OFBIZ-11808-OFBIZ-11809.patch, > OFBIZ-11808-OFBIZ-11809.patch, OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134190#comment-17134190 ] Nicolas Malin commented on OFBIZ-11809: --- Thanks both for your review, It's not really currently finish, I just expose own work. This will be more interesting with the work on sub-decorator and inherit form. I'm focused to consolidate all concepts on presentation slide. I hope to expose this soon :) However, I appreciate your return > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: screen, widget > Attachments: OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134170#comment-17134170 ] James Yong commented on OFBIZ-11809: Reviewed the patch. Looks good. > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: screen, widget > Attachments: OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[
https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17134126#comment-17134126
]
Jacques Le Roux commented on OFBIZ-11809:
-
Hi Nicolas,
I have reviewed, applied and succesfully compiled the patch. It looks good to
me and I can see this
when getting to
https://localhost:8443/catalog/control/login?USERNAME=admin=ofbiz=Y
So I guess it's OK (disclaimer: I did not test the areaId thing)
Just a trivial syntax point :) :
* {{if (! context.containsKey("screenStack")) {}} no space after !
I have still to carefully read all the chapters at OFBIZ-1808...
Thank you Nicolas!
> Access to the current screen from any widget element
>
>
> Key: OFBIZ-11809
> URL: https://issues.apache.org/jira/browse/OFBIZ-11809
> Project: OFBiz
> Issue Type: Sub-task
> Components: framework/widget
>Affects Versions: Trunk
>Reporter: Nicolas Malin
>Priority: Major
> Labels: screen, widget
> Attachments: OFBIZ-11808-OFBIZ-11809.patch
>
>
> During the rendering process, an element have no information on the screen
> that it depend. This not really help to automatism some refresh treatment and
> force the developer to know the screen structure where is the element.
> To solve this situation we implement a new class, ScreenStack that permit at
> every time for an element to identify who it depend. This help to resolve the
> unique Id that the screen take and can be exploit by the theme.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (OFBIZ-11809) Access to the current screen from any widget element
[ https://issues.apache.org/jira/browse/OFBIZ-11809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17128035#comment-17128035 ] Nicolas Malin commented on OFBIZ-11809: --- This patch [^OFBIZ-11808-OFBIZ-11809.patch] load the new class to manage the stack during the rendering, and add a UEL to call the stack directly from xml screen (usefull for the decorator) > Access to the current screen from any widget element > > > Key: OFBIZ-11809 > URL: https://issues.apache.org/jira/browse/OFBIZ-11809 > Project: OFBiz > Issue Type: Sub-task > Components: framework/widget >Affects Versions: Trunk >Reporter: Nicolas Malin >Priority: Major > Labels: screen, widget > Attachments: OFBIZ-11808-OFBIZ-11809.patch > > > During the rendering process, an element have no information on the screen > that it depend. This not really help to automatism some refresh treatment and > force the developer to know the screen structure where is the element. > To solve this situation we implement a new class, ScreenStack that permit at > every time for an element to identify who it depend. This help to resolve the > unique Id that the screen take and can be exploit by the theme. -- This message was sent by Atlassian Jira (v8.3.4#803005)
